Re: [PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

hfinkel added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:734-737 @@ +733,6 @@ + + OS << llvm::format_decimal(L + 1, LNDigits) << " "; + OS << (LLI.Inlined.Transformed && InlinedCols < 2 ? "I" : " "); + OS << (LLI.Unrolled.Transformed && UnrolledCols

Re: [PATCH] D17841: [libclang/python] Add bindings for children of diagnostics

hansonw added a comment. Thanks! I don't have commit permissions; could you check this in for me? Comment at: bindings/python/clang/cindex.py:369 @@ +368,3 @@ +def __len__(self): +return int(conf.lib.clang_getNumDiagnosticsInSet(self.diag_set)) + ---

[libcxx] r267983 - Move extern C include test into test/libcxx

Author: ericwf Date: Thu Apr 28 23:19:48 2016 New Revision: 267983 URL: http://llvm.org/viewvc/llvm-project?rev=267983&view=rev Log: Move extern C include test into test/libcxx Added: libcxx/trunk/test/libcxx/depr/ libcxx/trunk/test/libcxx/depr/depr.c.headers/ libcxx/trunk/test/libcxx

Re: [PATCH] D17841: [libclang/python] Add bindings for children of diagnostics

compnerd accepted this revision. This revision is now accepted and ready to land. Comment at: bindings/python/clang/cindex.py:369 @@ +368,3 @@ +def __len__(self): +return int(conf.lib.clang_getNumDiagnosticsInSet(self.diag_set)) + Why

[libcxx] r267982 - Fix test failures by adding missing include

Author: ericwf Date: Thu Apr 28 23:18:13 2016 New Revision: 267982 URL: http://llvm.org/viewvc/llvm-project?rev=267982&view=rev Log: Fix test failures by adding missing include Modified: libcxx/trunk/test/std/strings/c.strings/cwchar.pass.cpp Modified: libcxx/trunk/test/std/strings/c.strings

Re: [PATCH] D19654: PR27132: Proper mangling for __unaligned qualifier (now with PR27367 fixed)

majnemer added a comment. It would be good to have a test for the variable template case: template T x; auto g() { return x; } should mangle to `??$x@PEFAH@@3PEFAHEFA` http://reviews.llvm.org/D19654 ___ cfe-commits mailing list cfe-commi

[libcxx] r267981 - Fix or move various non-standard tests.

Author: ericwf Date: Thu Apr 28 23:07:45 2016 New Revision: 267981 URL: http://llvm.org/viewvc/llvm-project?rev=267981&view=rev Log: Fix or move various non-standard tests. This patch does the following: * Remove <__config> includes from some container tests. * Guards uses of std::launch::any in

Re: [PATCH] D19703: [clang-tidy] Improve misc-redundant-expression and decrease false-positive

etienneb updated this revision to Diff 55526. etienneb added a comment. adding unittests http://reviews.llvm.org/D19703 Files: clang-tidy/misc/RedundantExpressionCheck.cpp docs/clang-tidy/checks/misc-redundant-expression.rst test/clang-tidy/misc-redundant-expression.cpp Index: test/clang

[PATCH] D19708: [CGDebugInfo] Generate debug info for member calls in the context of the callee expression

hfinkel created this revision. hfinkel added reviewers: rsmith, aprantl, dexonsmith, dblaikie, echristo. hfinkel added a subscriber: cfe-commits. Herald added subscribers: joker.eph, mcrosier. We currently generate debug info for member calls in the context of the call expression. For member call

Re: [PATCH] D19175: Fix for PR27015 (variable template initialized with a generic lambda expression)

On Thu, Apr 28, 2016 at 7:34 PM, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > ahatanak added a comment. > > Thanks for the review. I committed the patch in r267956 and r267975. > > Do you think I should make setFlags(unsigned F) return early if F == Flags? I don't think

Re: [PATCH] D19175: Fix for PR27015 (variable template initialized with a generic lambda expression)

ahatanak added a comment. Thanks for the review. I committed the patch in r267956 and r267975. Do you think I should make setFlags(unsigned F) return early if F == Flags? Repository: rL LLVM http://reviews.llvm.org/D19175 ___ cfe-commits mailing

r267975 - [Parser] Clear the TemplateParamScope bit of the current scope's flag

Author: ahatanak Date: Thu Apr 28 21:24:14 2016 New Revision: 267975 URL: http://llvm.org/viewvc/llvm-project?rev=267975&view=rev Log: [Parser] Clear the TemplateParamScope bit of the current scope's flag if we are parsing a template specialization. This commit makes changes to clear the Template

Re: [PATCH] D19175: Fix for PR27015 (variable template initialized with a generic lambda expression)

This revision was automatically updated to reflect the committed changes. Closed by commit rL267975: [Parser] Clear the TemplateParamScope bit of the current scope's flag (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D19175?vs=55484&id=55523#toc Repository: rL LLVM

Re: [PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

hfinkel added a comment. In http://reviews.llvm.org/D19678#416039, @hfinkel wrote: > In http://reviews.llvm.org/D19678#415902, @rsmith wrote: > > > You give this example: > > > > > 343 | Loc = ConvertBackendLocation(D, > > > Context->getSourceManager()); > > > > > I |

Re: [PATCH] D18474: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets

carlo.bertolli closed this revision. carlo.bertolli marked an inline comment as done. carlo.bertolli added a comment. Committed revision 267972. Repository: rL LLVM http://reviews.llvm.org/D18474 ___ cfe-commits mailing list cfe-commits@lists.llv

r267972 - [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets

Author: cbertol Date: Thu Apr 28 20:37:30 2016 New Revision: 267972 URL: http://llvm.org/viewvc/llvm-project?rev=267972&view=rev Log: [OPENMP] Enable correct generation of runtime call when target directive is separated from teams directive by multiple curly brackets http://reviews.llvm.org/D184

RE: [PATCH] D19702: [libcxx] [test] Fix get_temp_file_name() to compile for Windows.

[David Majnemer] > Er, I don't think mingw provides _mktemp_s. Yeah, I don't know what needs to be done for MinGW. (I avoided using _mktemp for MSVC because I knew it would complain about "security".) I am pretty sure that this code was already broken for MinGW - I grepped and found no inclusio

Re: [PATCH] D19623: [libcxx] [test] Initialize local doubles to NaN.

EricWF added a comment. *disclaimer* I have no idea what I'm talking about. Is there any reason why using signalling NaN would be better than quiet NaN in this case? http://reviews.llvm.org/D19623 ___ cfe-commits mailing list cfe-commits@lists.llv

Re: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

EricWF requested changes to this revision. EricWF added a comment. This revision now requires changes to proceed. One inline change requested. Comment at: test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp:24421

Re: [PATCH] D19702: [libcxx] [test] Fix get_temp_file_name() to compile for Windows.

EricWF added a comment. In http://reviews.llvm.org/D19702#416314, @majnemer wrote: > Er, I don't think mingw provides _mktemp_s. I went back to the old method for MinGW in r267968 just to be safe. Thanks for the input. http://reviews.llvm.org/D19702 ___

r267969 - PR27549: fix bug that resulted in us giving a translation-unit-scope variable a

Author: rsmith Date: Thu Apr 28 20:23:20 2016 New Revision: 267969 URL: http://llvm.org/viewvc/llvm-project?rev=267969&view=rev Log: PR27549: fix bug that resulted in us giving a translation-unit-scope variable a mangled name if it happened to be declared in an 'extern "C++"' context. This also ca

[libcxx] r267968 - Fix possible test breakage for MinGW

Author: ericwf Date: Thu Apr 28 20:22:16 2016 New Revision: 267968 URL: http://llvm.org/viewvc/llvm-project?rev=267968&view=rev Log: Fix possible test breakage for MinGW Modified: libcxx/trunk/test/support/platform_support.h Modified: libcxx/trunk/test/support/platform_support.h URL: http:/

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

EricWF added a comment. In http://reviews.llvm.org/D19698#416315, @rsmith wrote: > In http://reviews.llvm.org/D19698#416309, @EricWF wrote: > > > Most tests pretty much rely on getting dragged in indirectly, > > same thing with and the bits of we actually define in > > . > > > There are also

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

rsmith added a comment. In http://reviews.llvm.org/D19698#416309, @EricWF wrote: > Most tests pretty much rely on getting dragged in indirectly, > same thing with and the bits of we actually define in > . There are also a few symbols that libc++ defines in the wrong header and then #inclu

Re: [PATCH] D19702: [libcxx] [test] Fix get_temp_file_name() to compile for Windows.

Er, I don't think mingw provides _mktemp_s. On Thu, Apr 28, 2016 at 5:57 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > EricWF closed this revision. > EricWF added a comment. > > r267963. > > > http://reviews.llvm.org/D19702 > > > > __

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

Eugene.Zelenko added a comment. > I was hoping that maybe "Include What You Use" had a fix-it mode. I'll look > into this further tonight. It has fix_includes.py script, but I encountered quite a lot of false positives, so I prefer to fix problems manually. http://reviews.llvm.org/D19698

Re: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

STL_MSFT added a comment. Are there any issues with these changes? I tried to follow the existing practice for void-casting, including the comment (although the comments varied). http://reviews.llvm.org/D19625 ___ cfe-commits mailing list cfe-commi

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

EricWF added a comment. In http://reviews.llvm.org/D19698#416306, @rsmith wrote: > In http://reviews.llvm.org/D19698#416255, @Eugene.Zelenko wrote: > > > It'll be good idea to run Include What You Use > > to make sure > > that all d

RE: [PATCH] D19700: [libcxx] [test] nasty_mutex::operator& should return nullptr, like nasty_list above it.

[Eric Fiselier] > Well arguable it should be `no return` or even better it should > have an "= delete" so it's diagnosed even if it's not called. > For now this works though. Agreed - I just wasn't sure what this code was trying to do, and I figured it should be consistent. I'm trying to keep my

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

rsmith added a subscriber: rsmith. rsmith added a comment. In http://reviews.llvm.org/D19698#416255, @Eugene.Zelenko wrote: > It'll be good idea to run Include What You Use > to make sure > that all dependencies are explicit. You

Re: [PATCH] D19702: [libcxx] [test] Fix get_temp_file_name() to compile for Windows.

EricWF closed this revision. EricWF added a comment. r267963. http://reviews.llvm.org/D19702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r267963 - Fix get_temp_file_name() to compile on Windows. Patch from s...@microsoft.com

Author: ericwf Date: Thu Apr 28 19:51:24 2016 New Revision: 267963 URL: http://llvm.org/viewvc/llvm-project?rev=267963&view=rev Log: Fix get_temp_file_name() to compile on Windows. Patch from s...@microsoft.com Modified: libcxx/trunk/test/support/platform_support.h Modified: libcxx/trunk/tes

Re: [PATCH] D19702: [libcxx] [test] Fix get_temp_file_name() to compile for Windows.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM but I don't know much about Windows or MinGW. http://reviews.llvm.org/D19702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: [PATCH] D19701: [libcxx] [test] Remove more names of unreferenced parameters.

EricWF closed this revision. EricWF added a comment. r267962. http://reviews.llvm.org/D19701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r267962 - Remove more names of unreferenced parameters. Patch from s...@microsoft.com

Author: ericwf Date: Thu Apr 28 19:47:16 2016 New Revision: 267962 URL: http://llvm.org/viewvc/llvm-project?rev=267962&view=rev Log: Remove more names of unreferenced parameters. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/input.output/iostreams.base/ios/basic.ios.members/m

Re: [PATCH] D19700: [libcxx] [test] nasty_mutex::operator& should return nullptr, like nasty_list above it.

EricWF closed this revision. EricWF added a comment. r267961. http://reviews.llvm.org/D19700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19700: [libcxx] [test] nasty_mutex::operator& should return nullptr, like nasty_list above it.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Well arguable it should be `no return` or even better it should have an "= delete" so it's diagnosed even if it's not called. For now this works though. http://reviews.llvm.org/D19700 ___

[libcxx] r267961 - Add a return value for nasty_mutex::operator&. Patch from s...@microsoft.com

Author: ericwf Date: Thu Apr 28 19:45:46 2016 New Revision: 267961 URL: http://llvm.org/viewvc/llvm-project?rev=267961&view=rev Log: Add a return value for nasty_mutex::operator&. Patch from s...@microsoft.com Modified: libcxx/trunk/test/support/nasty_containers.hpp Modified: libcxx/trunk/te

Re: [PATCH] D19699: [libcxx] [test] Need to include for its streaming operators.

EricWF closed this revision. EricWF added a comment. r267959. http://reviews.llvm.org/D19699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r267959 - Add include for streaming operators. Patch from s...@microsoft.com

Author: ericwf Date: Thu Apr 28 19:39:40 2016 New Revision: 267959 URL: http://llvm.org/viewvc/llvm-project?rev=267959&view=rev Log: Add include for streaming operators. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/depr/depr.str.strstreams/depr.istrstream/depr.istrstream.co

r267957 - Avoid -Wshadow warnings about constructor parameters named after fields

Author: rnk Date: Thu Apr 28 19:37:43 2016 New Revision: 267957 URL: http://llvm.org/viewvc/llvm-project?rev=267957&view=rev Log: Avoid -Wshadow warnings about constructor parameters named after fields Usually these parameters are used solely to initialize the field in the initializer list, and t

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

EricWF closed this revision. EricWF added a comment. r267958. http://reviews.llvm.org/D19698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

This revision was automatically updated to reflect the committed changes. Closed by commit rL267957: Avoid -Wshadow warnings about constructor parameters named after fields (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D18271?vs=55359&id=55515#toc Repository: rL LLVM h

[libcxx] r267958 - Add proper include for unique_ptr. Patch from s...@microsoft.com

Author: ericwf Date: Thu Apr 28 19:37:56 2016 New Revision: 267958 URL: http://llvm.org/viewvc/llvm-project?rev=267958&view=rev Log: Add proper include for unique_ptr. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/utilities/meta/meta.rel/is_callable.pass.cpp Modified: libcxx/

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Woops. My bad. http://reviews.llvm.org/D19698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D19703: [clang-tidy] Improve misc-redundant-expression and decrease false-positive

etienneb updated this revision to Diff 55514. etienneb added a comment. nit http://reviews.llvm.org/D19703 Files: clang-tidy/misc/RedundantExpressionCheck.cpp docs/clang-tidy/checks/misc-redundant-expression.rst test/clang-tidy/misc-redundant-expression.cpp Index: test/clang-tidy/misc-re

Re: [PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

anemet added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:734-737 @@ +733,6 @@ + + OS << llvm::format_decimal(L + 1, LNDigits) << " "; + OS << (LLI.Inlined.Transformed && InlinedCols < 2 ? "I" : " "); + OS << (LLI.Unrolled.Transformed && UnrolledCols <

[PATCH] D19703: [clang-tidy] Improve misc-redundant-expression and decrease false-positive

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. This patch is adding support for conditional expression and overloaded operators. To decrease false-positive, this patch is adding a list of banned macro names that has multiple variant

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. It'll be good idea to run Include What You Use to make sure that all dependencies are explicit. http://reviews.llvm.org/D19698 __

[PATCH] D19702: [libcxx] [test] Fix get_temp_file_name() to compile for Windows.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix get_temp_file_name() to compile for Windows. It was including but attempting to use GetTempPath() and GetTempFileName(), which are provided by . Instead

[PATCH] D19701: [libcxx] [test] Remove more names of unreferenced parameters.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Remove more names of unreferenced parameters. Fixes MSVC "warning C4100: unreferenced formal parameter". http://reviews.llvm.org/D19701 Files: test/std/inpu

[PATCH] D19700: [libcxx] [test] nasty_mutex::operator& should return nullptr, like nasty_list above it.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] nasty_mutex::operator& should return nullptr, like nasty_list above it. Fixes MSVC "error C4716: 'nasty_mutex::operator&': must return a value". http://review

[PATCH] D19699: [libcxx] [test] Need to include for its streaming operators.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Need to include for its streaming operators. Fixes MSVC errors: "error C2678: binary '>>': no operator found which takes a left-hand operand of type 'std::ist

[PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Need to include for std::unique_ptr. Fixes MSVC "error C2039: 'unique_ptr': is not a member of 'std'". http://reviews.llvm.org/D19698 Files: test/std/utili

Re: [PATCH] D19623: [libcxx] [test] Initialize local doubles to NaN.

STL_MSFT retitled this revision from "[libc++] Initialize local doubles to 0.0." to "[libcxx] [test] Initialize local doubles to NaN.". STL_MSFT updated the summary for this revision. STL_MSFT updated this revision to Diff 55506. STL_MSFT added a comment. Now I'm using NaN instead of 0.0 for the

r267956 - [Sema] Fix a crash that occurs when a variable template is initialized

Author: ahatanak Date: Thu Apr 28 18:50:12 2016 New Revision: 267956 URL: http://llvm.org/viewvc/llvm-project?rev=267956&view=rev Log: [Sema] Fix a crash that occurs when a variable template is initialized with a generic lambda. This patch fixes Sema::InstantiateVariableInitializer to switch to t

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

EricWF added a comment. OK. I *think* this is my last round of review comments except for one specific issue. I'm still looking into the changes to the static mutex's and condition_variables in `memory.cpp` and `algorithm.cpp`. In these cases I don't want to go from compile-time initialization

RE: [PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

Generally tests test something other than "this program doesn't crash" - should it test that we apply the attribute correctly? (either via ast dump, or checking the resulting DWARF doesn't have debug info on the relevant entity) Or is this not actually a new/separate codepath? In which case do w

Re: r267904 - Debug info: Apply an artificial debug location to __cyg_profile_func.* calls.

> On Apr 28, 2016, at 4:31 PM, David Blaikie wrote: > > > > On Thu, Apr 28, 2016 at 1:11 PM, Adrian Prantl > wrote: > >> On Apr 28, 2016, at 12:53 PM, David Blaikie > > wrote: >> >> >> >> On Thu, Apr 28, 2016 at 12:50 PM, Adrian Prantl

Re: r267904 - Debug info: Apply an artificial debug location to __cyg_profile_func.* calls.

On Thu, Apr 28, 2016 at 1:11 PM, Adrian Prantl wrote: > > On Apr 28, 2016, at 12:53 PM, David Blaikie wrote: > > > > On Thu, Apr 28, 2016 at 12:50 PM, Adrian Prantl wrote: > >> >> On Apr 28, 2016, at 12:34 PM, David Blaikie wrote: >> >> Should these have no/artificial location? It seems like p

Re: [PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

LGTM On Thu, Apr 28, 2016 at 2:10 PM, Paul Robinson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > probinson created this revision. > probinson added a reviewer: aaron.ballman. > probinson added a subscriber: cfe-commits. > > The 'nodebug' attribute had hand-coded constraints; replace tho

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18823: Implementation of VlA of GNU C++ extension

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D18823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

r267948 - Differential Revision: http://reviews.llvm.org/D19687

Author: tmsriram Date: Thu Apr 28 17:34:00 2016 New Revision: 267948 URL: http://llvm.org/viewvc/llvm-project?rev=267948&view=rev Log: Differential Revision: http://reviews.llvm.org/D19687 Set module flag PIELevel. Simplify code that sets PICLevel flag. Modified: cfe/trunk/lib/CodeGen/CodeGe

Re: [PATCH] D19693: [Clang][Darwin] Define __ARM_DWARF_EH__ for WatchABI

Yea… Arc seems to have done something odd with my out-of-date checkout. I’ll make sure that gets cleaned up, and I’ll add a test. Thanks, -Chris > On Apr 28, 2016, at 3:23 PM, Tim Northover wrote: > > t.p.northover added a comment. > > The __ARM_DWARF_EH__ change looks reasonable, but it's pr

Re: [PATCH] D19693: [Clang][Darwin] Define __ARM_DWARF_EH__ for WatchABI

beanz added a subscriber: beanz. beanz added a comment. Yea… Arc seems to have done something odd with my out-of-date checkout. I’ll make sure that gets cleaned up, and I’ll add a test. Thanks, -Chris http://reviews.llvm.org/D19693 ___ cfe-commits

Re: [PATCH] D19415: [libcxx][rfc] Externalized threading support

rmaprath updated this revision to Diff 55503. rmaprath added a comment. Updating to syc-up with http://reviews.llvm.org/D19412. Obviously, this patch needs more work in terms of setting up the testing story (using a pthreads based implementation of the threading API). http://reviews.llvm.org/D

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

rmaprath updated this revision to Diff 55501. rmaprath added a comment. Addressing review comments from @EricWF: - Agree with all the suggested changes, I've applied them all. Thanks! / Asiri http://reviews.llvm.org/D19412 Files: include/__config include/__mutex_base include/__threadin

Re: [PATCH] D19048: Test for a module related crash in CGDebugInfo.cpp

aprantl added a comment. Please make sure that the two DINodes are connected, otherwise LGTM. Thanks! http://reviews.llvm.org/D19048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

hfinkel added a comment. In http://reviews.llvm.org/D19678#416127, @rcox2 wrote: > Actually, the Intel compiler distinguishes between an optimization report > (-qopt-report) and an annotated listing (-qopt-report-annotate). Interesting; thanks for pointing this out (and for the example). >

Re: [PATCH] D19687: Set PIELevel module flag

tmsriram updated this revision to Diff 55493. tmsriram added a comment. Simplify code setting PICLevel and PIELevel module flags. http://reviews.llvm.org/D19687 Files: lib/CodeGen/CodeGenModule.cpp Index: lib/CodeGen/CodeGenModule.cpp =

Re: [PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

rcox2 added a comment. Actually, the Intel compiler distinguishes between an optimization report (-qopt-report) and an annotated listing (-qopt-report-annotate). The optimization report lists the info for optimizations in a hierarchical fashion. To use you example, icc -c -O3 -qopt-report=

[PATCH] D19687: Set PIELevel module flag

tmsriram created this revision. tmsriram added reviewers: rnk, davidxl. tmsriram added a subscriber: cfe-commits. In patch http://reviews.llvm.org/D19671, I added a patch to create PIELevel module flag. This patch sets the flag. http://reviews.llvm.org/D19687 Files: lib/CodeGen/CodeGenModule

Re: [PATCH] D19693: [Clang][Darwin] Define __ARM_DWARF_EH__ for WatchABI

t.p.northover added a comment. The __ARM_DWARF_EH__ change looks reasonable, but it's probably an idea to put a check into tools/clang/tests/Preprocessor/arm-target-features.c (watch is checked with "ARMV7K"). The rest of the changes look like they're from an unsynchronized branch? http://rev

Re: [PATCH] D19346: [CUDA] Copy host builtin types to NVPTXTargetInfo.

rsmith added inline comments. Comment at: lib/Basic/Targets.cpp:1648-1684 @@ +1647,39 @@ + +// Match the host's types. +PointerWidth = HostTarget->getPointerWidth(/* AddrSpace = */ 0); +PointerAlign = HostTarget->getPointerAlign(/* AddrSpace = */ 0); +BoolWidth = H

Re: [PATCH] D19687: Set PIELevel module flag

rnk added a comment. still lgtm Comment at: lib/CodeGen/CodeGenModule.cpp:480 @@ -479,8 +479,3 @@ if (uint32_t PLevel = Context.getLangOpts().PICLevel) { -llvm::PICLevel::Level PL = llvm::PICLevel::Default; -switch (PLevel) { -case 0: break; -case 1: PL = llvm

Re: [PATCH] D19346: [CUDA] Copy host builtin types to NVPTXTargetInfo.

tra added inline comments. Comment at: lib/Basic/Targets.cpp:1642 @@ +1641,3 @@ + +std::unique_ptr HostTarget( +AllocateTarget(llvm::Triple(Opts.HostTriple), Opts)); You may want to make sure we don't recurse here if someone specifies host triple to b

Re: [PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

rjmccall added a comment. In http://reviews.llvm.org/D19678#416059, @hfinkel wrote: > In http://reviews.llvm.org/D19678#415844, @rjmccall wrote: > > > I see what you're going for with "listing file", but I like ICC's option > > name much better, or at least something along those lines. > > > Sou

[PATCH] D19693: [Clang][Darwin] Define __ARM_DWARF_EH__ for WatchABI

beanz created this revision. beanz added a reviewer: t.p.northover. beanz added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. The Darwin armv7k ABI uses Dwarf EH, so we need to set the OS define correctly. Without this the gcc_personality fails to build. http://reviews

Re: [PATCH] D19048: Test for a module related crash in CGDebugInfo.cpp

dyung updated this revision to Diff 55495. dyung added a comment. Fixed up test and check for that DIImportedEntity and DIModule are present in the generated output. http://reviews.llvm.org/D19048 Files: test/Modules/Inputs/getSourceDescriptor-crash/h1.h test/Modules/Inputs/getSourceDescri

Re: [PATCH] D18088: Add a new warning to notify users of mismatched SDK and deployment target

rsmith added inline comments. Comment at: lib/Driver/ToolChains.cpp:722-733 @@ -700,1 +721,14 @@ + + if (const Arg *A = Args.getLastArg(options::OPT_isysroot)) { +StringRef isysroot = A->getValue(); +// Assume SDK has path: SOME_PATH/SDKs/PlatformXX.YY.sdk +size_t Beg

Re: [PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

hfinkel added a comment. In http://reviews.llvm.org/D19678#415844, @rjmccall wrote: > I see what you're going for with "listing file", but I like ICC's option name > much better, or at least something along those lines. Sounds good to me. Do you have a preference on -fopt-report vs. -foptimiz

Re: [PATCH] D19175: Fix for PR27015 (variable template initialized with a generic lambda expression)

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D19175 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

hfinkel added a comment. In http://reviews.llvm.org/D19678#415902, @rsmith wrote: > You give this example: > > > 343 | Loc = ConvertBackendLocation(D, > > Context->getSourceManager()); > > > I | ^ > > > I | ^ > > > How does

Re: [PATCH] D19346: [CUDA] Copy host builtin types to NVPTXTargetInfo.

jlebar added a comment. Richard, friendly ping? http://reviews.llvm.org/D19346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19175: Fix for PR27015 (variable template initialized with a generic lambda expression)

ahatanak updated this revision to Diff 55484. ahatanak added a comment. - Defined a private overload of Scope::setFlags which is called from Scope::setFlags and Scope::Init. - Stop checking TmplScope->isTemplateParamScope() in Sema::ActOnStartOfLambdaDefinition. - Fix test case test/CXX/drs/dr1x

r267942 - [clang][AVX512][Builtin] Adding intrinsics for the SAD instruction set.

Author: mzuckerm Date: Thu Apr 28 16:21:08 2016 New Revision: 267942 URL: http://llvm.org/viewvc/llvm-project?rev=267942&view=rev Log: [clang][AVX512][Builtin] Adding intrinsics for the SAD instruction set. Differential Revision: http://reviews.llvm.org/D19591 Modified: cfe/trunk/include/cla

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

apelete added a comment. Thanks for your reviews. http://reviews.llvm.org/D19385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

apelete updated this revision to Diff 55487. apelete marked 3 inline comments as done. apelete added a comment. [scan-build] fix logic error warnings emitted on clang code base Changes since last revision: - lib/Format/AffectedRangeManager.cpp: fix the call to AffectedRangeManager::nonPPLineAff

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

apelete updated this revision to Diff 55483. apelete added a comment. [scan-build] fix logic error warnings emitted on clang code base Changes since last revison: - lib/Format/AffectedRangeManager.h: fix declaration of nonPPLineAffected() to pass a reference to AnnotatedLine as first parameter.

[PATCH] D19689: Add Subjects to NoDebugAttr [NFC]

probinson created this revision. probinson added a reviewer: aaron.ballman. probinson added a subscriber: cfe-commits. The 'nodebug' attribute had hand-coded constraints; replace those with a Subjects line in Attr.td. Also add a missing test to verify the attribute is okay on an Objective-C meth

Re: [PATCH] D19048: Test for a module related crash in CGDebugInfo.cpp

dyung added inline comments. Comment at: test/Modules/getSourceDescriptor-crash.cpp:6 @@ +5,2 @@ + +// CHECK: DIModule2 aprantl wrote: > This doesn't actually appear in the output :-) > You probably want to at least check for the correct name of the module and >

Re: [PATCH] D19687: Set PIELevel module flag

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/CodeGen/CodeGenModule.cpp:492-498 @@ +491,9 @@ + if (uint32_t PLevel = Context.getLangOpts().PIELevel) { +llvm::PIELevel::Level PL = llvm::PIELevel::Defaul

Re: [PATCH] D14274: Add alloc_size attribute to clang

george.burgess.iv added inline comments. Comment at: include/clang/Basic/Attr.td:753 @@ +752,3 @@ + let Args = [IntArgument<"ElemSizeParam">, IntArgument<"NumElemsParam", 1>]; + let TemplateDependent = 1; + let Documentation = [AllocSizeDocs]; aaron.ballman wro

Re: [PATCH] D14274: Add alloc_size attribute to clang

george.burgess.iv updated this revision to Diff 55478. george.burgess.iv marked 2 inline comments as done. george.burgess.iv added a comment. Addressed all feedback http://reviews.llvm.org/D14274 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/Diagno

[clang-tools-extra] r267933 - [clang-tidy] cppcoreguidelines-pro-type-member-init should not complain about static variables

Author: alexfh Date: Thu Apr 28 15:20:01 2016 New Revision: 267933 URL: http://llvm.org/viewvc/llvm-project?rev=267933&view=rev Log: [clang-tidy] cppcoreguidelines-pro-type-member-init should not complain about static variables Summary: Variables with static storage duration are zero-initialized

Re: [PATCH] D19672: [clang-tidy] cppcoreguidelines-pro-type-member-init should not complain about static variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL267933: [clang-tidy] cppcoreguidelines-pro-type-member-init should not complain about… (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D19672?vs=55441&id=55476#toc Repository:

Re: [PATCH] D19679: Method pool in modules: sync up out of date selectors before writing the module

aprantl added inline comments. Comment at: include/clang/Serialization/ASTReader.h:657 @@ +656,3 @@ + /// Whether a selector is out of date. We mark a selector as out of date + // if we load another module after the method pool entry was pulled in. + llvm::DenseMap SelectorOutO

Re: [PATCH] D19048: Test for a module related crash in CGDebugInfo.cpp

aprantl added inline comments. Comment at: test/Modules/getSourceDescriptor-crash.cpp:6 @@ +5,2 @@ + +// CHECK: DIModule2 This doesn't actually appear in the output :-) You probably want to at least check for the correct name of the module and for the DIImportedE

Re: [PATCH] D19175: Fix for PR27015 (variable template initialized with a generic lambda expression)

On Thu, Apr 28, 2016 at 1:14 PM, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > ahatanak added a comment. > > If I try calling Init(AnyParent, F) in Scope::setFlags, clang fails to > compile the following code because it cannot find the definition of struct > "foo": > > vo

  1   2   3   >