Yep, looks like that fixed it. Sorry for the prolonged break.
-Chris
> On Apr 29, 2016, at 10:33 PM, Chris Bieneman wrote:
>
> Took a blind stab at fixing it in r268156.
>
> -Chris
>
>> On Apr 29, 2016, at 10:10 PM, Chris Bieneman via cfe-commits
>> mailto:cfe-commits@lists.llvm.org>> wrote:
Took a blind stab at fixing it in r268156.
-Chris
> On Apr 29, 2016, at 10:10 PM, Chris Bieneman via cfe-commits
> wrote:
>
> Unless I'm reading the log wrong there doesn't seem to be any error text
> getting logged.
>
> Any idea what that is about?
>
> -Chris
>
> On Apr 29, 2016, at 9:49
Author: cbieneman
Date: Sat Apr 30 00:27:17 2016
New Revision: 268156
URL: http://llvm.org/viewvc/llvm-project?rev=268156&view=rev
Log:
Stab in the dark to fix the PS4 bot
r268127 is causing the PS4 bots to fail. Not sure what is causing it, but
hopefully this will fix it.
Modified:
cfe/tru
Unless I'm reading the log wrong there doesn't seem to be any error text
getting logged.
Any idea what that is about?
-Chris
> On Apr 29, 2016, at 9:49 PM, Sean Silva wrote:
>
> This breaks the PS4 bots at least. They've been red for hours now.
> http://lab.llvm.org:8011/builders/llvm-clang-l
This breaks the PS4 bots at least. They've been red for hours now.
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast?numbuilds=100
On Fri, Apr 29, 2016 at 3:28 PM, Chris Bieneman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: cbieneman
> Date: Fri Apr 29
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
This is awesome! lgtm
I only have nits and questions.
Want to reference PR27522 in the patch description?
Also in the description:
> I also expanded the workaround handle C++ records with constr
ryee88 updated this revision to Diff 55707.
ryee88 added a comment.
Removed unnecessary code changes. This patch contains a unit test to detect a
regression of this global name specifier issue.
http://reviews.llvm.org/D16965
Files:
test/Parser/cxx-class.cpp
Index: test/Parser/cxx-class.cpp
mlemay-intel updated this revision to Diff 55706.
mlemay-intel added a comment.
Add documentation for -safe-stack-usp-storage=tcb,
-safe-stack-usp-tcb-offset=, and -safe-stack-usp-init.
http://reviews.llvm.org/D19483
Files:
docs/SafeStack.rst
Index: docs/SafeStack.rst
==
EricWF added a comment.
Our test harness has a switch to enable warnings. I would be happy to set up a
bot in that configuration. It would probably be easier than setting up one that
uses MSVC.
Currently that mode disables the unused variable warnings but if/when STL
cleans all of those we can
EricWF added a comment.
In http://reviews.llvm.org/D19412#416596, @rmaprath wrote:
> In http://reviews.llvm.org/D19412#416183, @EricWF wrote:
>
> > OK. I *think* this is my last round of review comments except for one
> > specific issue. I'm still looking into the changes to the static mutex's
EricWF closed this revision.
EricWF added a comment.
r268153.
http://reviews.llvm.org/D19759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Fri Apr 29 21:30:18 2016
New Revision: 268153
URL: http://llvm.org/viewvc/llvm-project?rev=268153&view=rev
Log:
Replace one more occurrence of non-standard std:launch::any. Patch from
s...@microsoft.com
Modified:
libcxx/trunk/test/std/thread/futures/futures.async/async.p
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Woops, guess I was a bit careless there.
http://reviews.llvm.org/D19759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Replace one more occurrence of non-Standard std::launch::any
with AnyPolicy.
Also, fix MSVC "warning C4101: 'ex': unreferenced local variable".
http://reviews
Author: aaboud
Date: Fri Apr 29 20:44:38 2016
New Revision: 268151
URL: http://llvm.org/viewvc/llvm-project?rev=268151&view=rev
Log:
Reverting 268055 as it caused PR27579.
Removed:
cfe/trunk/test/CodeGenCXX/debug-info-lb.cpp
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
cfe/trunk/li
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Replace non-Standard "atomic_flag f(false);" with Standard
"atomic_flag f = ATOMIC_FLAG_INIT;".
The test init03.pass.cpp is explicitly testing this non-Standar
rnk created this revision.
rnk added reviewers: majnemer, hans.
rnk added a subscriber: cfe-commits.
Before this change, we would pass all non-HFA record arguments on
Windows with byval. Byval often blocks optimizations and results in bad
code generation. Windows now uses the existing workaround t
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: bkramer, hokein, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6. Regressions were OK.
Repository:
probinson created this revision.
probinson added reviewers: aaron.ballman, dblaikie, aprantl.
probinson added a subscriber: cfe-commits.
Expand the purview of the 'nodebug' attribute from functions/methods and
static-storage variables to include local variables. Parameters and members of
aggreg
[STL]
> When my work is finished (currently 3132 tests are passing out of 4541), I
> expect that
> we'll start running libcxx's tests in our automation, which will detect
> regressions rapidly and reliably.
[David Blaikie]
> It'd be great to have this sort of stuff upstream (in a public facing
Author: eugenezelenko
Date: Fri Apr 29 19:11:10 2016
New Revision: 268140
URL: http://llvm.org/viewvc/llvm-project?rev=268140&view=rev
Log:
[Release Notes] Mention Clang-tidy cert-err34-c check.
Fix order and style of Boost related notes.
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.r
On Fri, Apr 29, 2016 at 4:59 PM, Stephan T. Lavavej <
s...@exchange.microsoft.com> wrote:
> [David Blaikie]
> > Unused-variable seems pretty low value.
>
> Yeah, but it still has the potential to detect mistakes (e.g. typos, or
> code you intended to write but forgot about).
>
> I figured I'd subm
Yeah, I was thinking the diff would show the array decl so that the
motivation would be less ambiguous, but it looks like it was clipped out
entirely. I'll try to be a bit more descriptive in the future, though;
thanks for asking to clarify. :)
On Fri, Apr 29, 2016 at 4:59 PM, Aaron Ballman
wrote
[David Blaikie]
> Unused-variable seems pretty low value.
Yeah, but it still has the potential to detect mistakes (e.g. typos, or code
you intended to write but forgot about).
I figured I'd submit a patch, since there weren't actually that many
occurrences, and they were all easy to silence in
On Fri, Apr 29, 2016 at 6:02 PM, George Burgess IV
wrote:
> Right under the enum is an 11x11 static array of PromotedType. This change
> makes that array size go from 484 bytes to 121.
Ah, good to know. That sort of information would be useful in the
commit message (in case we ever do code archae
On Fri, Apr 29, 2016 at 4:34 PM, Stephan T. Lavavej via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> STL_MSFT marked 2 inline comments as done.
> STL_MSFT added a comment.
>
> What I'm doing is running libcxx's tests against MSVC's compiler and
> libraries. I could aggressively suppress warn
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268137: Delete store to Target option
PositionIndependentExecutable as PIE is now set… (authored by tmsriram).
Changed prior to commit:
http://reviews.llvm.org/D19749?vs=55676&id=55687#toc
Repository:
Author: tmsriram
Date: Fri Apr 29 18:38:53 2016
New Revision: 268137
URL: http://llvm.org/viewvc/llvm-project?rev=268137&view=rev
Log:
Delete store to Target option PositionIndependentExecutable as PIE is now set
in module flags.
Differential Revision: http://reviews.llvm.org/D19749
Modified:
On Fri, Apr 29, 2016 at 3:50 PM, Denis Zobnin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: dzobnin
> Date: Fri Apr 29 17:50:16 2016
> New Revision: 268129
>
> URL: http://llvm.org/viewvc/llvm-project?rev=268129&view=rev
> Log:
> [NFC] Initialize a variable to make buildbot green.
STL_MSFT marked 2 inline comments as done.
STL_MSFT added a comment.
What I'm doing is running libcxx's tests against MSVC's compiler and libraries.
I could aggressively suppress warnings (and indeed I'm doing that for the
noisiest, lowest-value warnings), but instead I'm building the tests with
I'm not sure why we'd want to compile the test suite with -Wunused-variable
(& even if we did, I imagine Clang's doesn't fire here because the
variables are used, just in non-evaluated contexts?)? Is there a benefit to
it being clean of unused-variable warnings? (in Clang's test case we just
aggres
STL_MSFT updated the summary for this revision.
STL_MSFT updated this revision to Diff 55683.
STL_MSFT added a comment.
This moves "str" as requested. It also adds void casts to another file, and
removes an unused argc/argv pair.
http://reviews.llvm.org/D19625
Files:
test/std/depr/depr.c.hea
rjmccall added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:806
@@ -792,1 +805,3 @@
+ }
+ src = Builder.CreateStructGEP(Addr, Idx, Offset, FD->getName());
} else {
Hmm. It's become increasingly clear that my original decision to expand the
Author: jlebar
Date: Fri Apr 29 18:05:19 2016
New Revision: 268131
URL: http://llvm.org/viewvc/llvm-project?rev=268131&view=rev
Log:
[CUDA] Copy host builtin types to NVPTXTargetInfo.
Summary:
Host and device types must match, otherwise when we pass values back and
forth between the host and devi
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D19749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
jlebar marked 2 inline comments as done.
Closed by commit rL268131: [CUDA] Copy host builtin types to NVPTXTargetInfo.
(authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D19346?vs=55648&id=55682#toc
R
Author: dzobnin
Date: Fri Apr 29 17:50:16 2016
New Revision: 268129
URL: http://llvm.org/viewvc/llvm-project?rev=268129&view=rev
Log:
[NFC] Initialize a variable to make buildbot green.
In r268085 "[MS] Make #pragma pack use PragmaStack<> class." there was an
uninitialized variable 'Alignment', w
Author: cbieneman
Date: Fri Apr 29 17:44:33 2016
New Revision: 268128
URL: http://llvm.org/viewvc/llvm-project?rev=268128&view=rev
Log:
Fix test case for incompatible sysroot warning
r268127 broke some bots because it needs to specify a darwin target.
Modified:
cfe/trunk/test/Driver/incompat
Author: cbieneman
Date: Fri Apr 29 17:28:34 2016
New Revision: 268127
URL: http://llvm.org/viewvc/llvm-project?rev=268127&view=rev
Log:
Add a new warning to notify users of mismatched SDK and deployment target
Summary:
This patch adds a new driver warning -Wincompatible-sdk which notifies the use
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268127: Add a new warning to notify users of mismatched SDK
and deployment target (authored by cbieneman).
Changed prior to commit:
http://reviews.llvm.org/D18088?vs=55652&id=55678#toc
Repository:
rL
beanz added a comment.
Thanks!
Will commit soon.
Comment at: lib/Driver/ToolChains.cpp:733
@@ +732,3 @@
+ StringRef SDKName = SDK.slice(0, StartVer);
+ if (!SDKName.startswith(getPlatformFamily()))
+getDriver().Diag(diag::warn_incompatible_sysroot)
---
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
This revision is now accepted and ready to land.
Comment at: lib/Driver/ToolChains.cpp:733
@@ +732,3 @@
+ StringRef SDKName = SDK.slice(0, StartVer);
+ if (!SDKName.startswith(getPlatformFamily()))
+
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Makes sense to me.
http://reviews.llvm.org/D19739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
rsmith accepted this revision.
This revision is now accepted and ready to land.
Comment at: test/Preprocessor/cuda-types.cu:7-9
@@ +6,5 @@
+// RUN: %clang --cuda-device-only -nocudainc -target i386-unknown-linux-gnu -x
cuda -E -dM -o - /dev/null > %T/i386-device-defines
+// RUN:
Author: cbieneman
Date: Fri Apr 29 17:17:15 2016
New Revision: 268124
URL: http://llvm.org/viewvc/llvm-project?rev=268124&view=rev
Log:
[CMake] Create a separate install target for libcxx headers
This change doesn't impact the behavior of the install-libcxx target which
installs whichever libcxx
tmsriram created this revision.
tmsriram added a reviewer: rnk.
tmsriram added subscribers: cfe-commits, davidxl.
Delete store to Target option PositionIndependentExecutable which will be
deleted. PIE is set in module flags.
http://reviews.llvm.org/D19749
Files:
lib/CodeGen/BackendUtil.cpp
Right under the enum is an 11x11 static array of PromotedType. This change
makes that array size go from 484 bytes to 121.
On Fri, Apr 29, 2016 at 2:43 PM, Aaron Ballman
wrote:
> On Fri, Apr 29, 2016 at 5:32 PM, George Burgess IV via cfe-commits
> wrote:
> > Author: gbiv
> > Date: Fri Apr 29 16
You could simplify the test case further, down to just:
struct foo { void bar(); };
void f(foo *f) {
f->bar();
}
and check that the call instruction has the desired column (or if you want
a test that doesn't depend on column info (you can force it on with a flag,
but we might vary whether it's
On Fri, Apr 29, 2016 at 5:32 PM, George Burgess IV via cfe-commits
wrote:
> Author: gbiv
> Date: Fri Apr 29 16:32:53 2016
> New Revision: 268113
>
> URL: http://llvm.org/viewvc/llvm-project?rev=268113&view=rev
> Log:
> [Sema] Specify the underlying type for an enum. NFC.
What is the benefit to th
tra created this revision.
tra added reviewers: jlebar, rnk.
tra added a subscriber: cfe-commits.
__global__ functions are a special case in CUDA.
Even when the symbol would normally not be externally
visible according to C++ rules, they still must be visible
to host-side stub which launches the
Author: gbiv
Date: Fri Apr 29 16:32:53 2016
New Revision: 268113
URL: http://llvm.org/viewvc/llvm-project?rev=268113&view=rev
Log:
[Sema] Specify the underlying type for an enum. NFC.
Modified:
cfe/trunk/lib/Sema/SemaOverload.cpp
Modified: cfe/trunk/lib/Sema/SemaOverload.cpp
URL:
http://llv
Chromium builds are failing too, see https://llvm.org/bugs/show_bug.cgi?id=27579
That is with LLVM/Clang r268086.
On Fri, Apr 29, 2016 at 1:47 PM, Aboud, Amjad via cfe-commits
wrote:
> I could not reproduce the issue.
> This error appeared before and it always meant that LLVM and Clang were not
The same error message shows up in https://llvm.org/bugs/show_bug.cgi?id=27579.
On 29 April 2016 at 16:47, Aboud, Amjad wrote:
> I could not reproduce the issue.
> This error appeared before and it always meant that LLVM and Clang were not
> aligned.
> You need both revisions to work correctly:
Author: aaronballman
Date: Fri Apr 29 16:05:55 2016
New Revision: 268103
URL: http://llvm.org/viewvc/llvm-project?rev=268103&view=rev
Log:
Add the ability to determine whether a format string argument is of a double
type or not. This change is tested by clang-tidy in r268100.
Modified:
cfe/t
aaboud added a subscriber: aaboud.
Comment at: cfe/trunk/lib/Sema/SemaAttr.cpp:110
@@ -200,3 +109,3 @@
case POAK_Reset:
// Reset just pops the top of the stack, or resets the current alignment to
You forgot to initialize "Alignment" in this case.
This is
howard.hinnant added a comment.
A quiet nan is the right tool. A signaling nan is nothing more than a
40-year-old design flaw. A quiet nan is "sticky" in that if you try to compute
with it, the result is quiet nan. But you can assign a valid number to
something containing a quiet nan. So if
aaron.ballman closed this revision.
aaron.ballman marked 3 inline comments as done.
aaron.ballman added a comment.
Thanks! I've commit in r268100 with the changes you requested.
Comment at: clang-tidy/cert/StrToNumCheck.cpp:182
@@ +181,3 @@
+void StrToNumCheck::check(const Match
Author: aaronballman
Date: Fri Apr 29 15:56:48 2016
New Revision: 268100
URL: http://llvm.org/viewvc/llvm-project?rev=268100&view=rev
Log:
Add a clang-tidy check that flags string-to-number conversion functions that
have insufficient error checking, suggesting a better alternative.
This check co
STL_MSFT added a comment.
According to my equally vague understanding, a quiet NaN (if used in
operations, instead of being overwritten with something valid) will silently
propagate down to the assert, which will complain that it's not equal to
whatever you were expecting. That would detect any
I could not reproduce the issue.
This error appeared before and it always meant that LLVM and Clang were not
aligned.
You need both revisions to work correctly: (LLVM) 268054, (Clang) 268055
Please, let me know if you can reproduce the issue locally using these versions.
Regards,
Amjad
> -O
Hello everyone,
Below are some buildbot numbers for the last week of 4/17/2016 - 4/23/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
beanz updated this revision to Diff 55652.
beanz added a comment.
Cleanup and refactoring based on feedback from @rsmith.
http://reviews.llvm.org/D18088
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
test/Driver/incompatible_sysroot
Hello everyone,
Below are some buildbot numbers for the week of 4/10/2016 - 4/16/2016.
Thanks
Galina
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to red or from red to green):
buildername
Anastasia added inline comments.
Comment at: lib/Headers/opencl-c.h:14
@@ +13,3 @@
+#if __OPENCL_C_VERSION__ >= CL_VERSION_2_0
+#define _CL20_AND_ABOVE 1
+#endif
Is there any reason to define this extra macro?
Could we not just check __OPENCL_C_VERSION__ >= CL_VE
hfinkel created this revision.
hfinkel added reviewers: rsmith, rjmccall, aprantl, dblaikie, echristo, anemet.
hfinkel added a subscriber: cfe-commits.
Herald added subscribers: joker.eph, mcrosier.
Getting accurate locations for loops is important, because those locations are
used by the fronten
Maybe this is the cause of this bootstrap failure:
http://lab.llvm.org:8080/green/job/llvm-stage2-cmake-RgLTO_build/6843
?
Cheers,
Rafael
On 29 April 2016 at 12:08, Amjad Aboud via cfe-commits
wrote:
> Author: aaboud
> Date: Fri Apr 29 11:08:08 2016
> New Revision: 268055
>
> URL: http://llvm.o
jlebar updated this revision to Diff 55648.
jlebar added a comment.
Add test for host == nvptx.
http://reviews.llvm.org/D19346
Files:
include/clang/Basic/TargetOptions.h
lib/Basic/Targets.cpp
lib/Frontend/CompilerInstance.cpp
lib/Frontend/CompilerInvocation.cpp
test/Preprocessor/cuda-
jlebar marked 2 inline comments as done.
jlebar added a comment.
Richard, friendly ping?
Comment at: lib/Basic/Targets.cpp:1642
@@ +1641,3 @@
+
+std::unique_ptr HostTarget(
+AllocateTarget(llvm::Triple(Opts.HostTriple), Opts));
tra wrote:
> You may w
OK. Feel free to add an early exit if you like if F == Flags.
On Fri, Apr 29, 2016 at 12:19 PM, Akira Hatanaka via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> OK, I understand your question now.
>
> I added the assert to the public overload of setFlags that has one
> parameter (just the fl
jlebar updated this revision to Diff 55646.
jlebar added a comment.
Add more comprehensive test.
http://reviews.llvm.org/D19346
Files:
include/clang/Basic/TargetOptions.h
lib/Basic/Targets.cpp
lib/Frontend/CompilerInstance.cpp
lib/Frontend/CompilerInvocation.cpp
test/Preprocessor/cuda
OK, I understand your question now.
I added the assert to the public overload of setFlags that has one parameter
(just the flag value), not the one the constructor eventually calls.
void setFlags(unsigned F) { assert(F != Flags); setFlags(getParent(), F); }
> On Apr 29, 2016, at 12:13 PM, Richa
On Fri, Apr 29, 2016 at 12:12 PM, Akira Hatanaka via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Scope’s constructor passes the parameter ScopeFlags to Scope::Init, which
> calls setFlags(Scope *parent, unsigned flags) and setFlags initializes
> Scope::Flags to the value passed to the const
Scope’s constructor passes the parameter ScopeFlags to Scope::Init, which calls
setFlags(Scope *parent, unsigned flags) and setFlags initializes Scope::Flags
to the value passed to the constructor.
> On Apr 29, 2016, at 11:36 AM, Richard Smith wrote:
>
> On Fri, Apr 29, 2016 at 11:07 AM, Akira
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Apart from small comments that can be addressed directly before
committing.
Comment at: include/clang/Basic/OpenCLExtensions.def:18
@@ +17,3 @@
+#else
+#define OP
Author: mren
Date: Fri Apr 29 14:04:05 2016
New Revision: 268091
URL: http://llvm.org/viewvc/llvm-project?rev=268091&view=rev
Log:
Method Pool in modules: we make sure that if a module contains an entry for
a selector, the entry should be complete, containing everything introduced by
that module a
phosek abandoned this revision.
phosek added a comment.
Superseded by http://reviews.llvm.org/D19734
http://reviews.llvm.org/D12860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: eraman
Date: Fri Apr 29 13:53:16 2016
New Revision: 268090
URL: http://llvm.org/viewvc/llvm-project?rev=268090&view=rev
Log:
Use the new path for coverage related headers and update CMakeLists.txt
Differential Revision: http://reviews.llvm.org/D19612
Modified:
cfe/trunk/lib/CodeGen/C
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268090: Use the new path for coverage related headers and
update CMakeLists.txt (authored by eraman).
Changed prior to commit:
http://reviews.llvm.org/D19612?vs=55279&id=55643#toc
Repository:
rL LLVM
manmanren marked 3 inline comments as done.
Comment at: lib/Serialization/ASTWriter.cpp:4394
@@ +4393,3 @@
+ // date, so we need to pull in the new content here.
+
+ // It's possible that updateOutOfDateSelector can update SelectorIDs. To be
Nice catch. Thanks,
doug.gregor accepted this revision.
doug.gregor added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D19679
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
manmanren updated this revision to Diff 55638.
manmanren added a comment.
Addressing review comments from Doug and Adrian.
Manman
http://reviews.llvm.org/D19679
Files:
include/clang/Sema/ExternalSemaSource.h
include/clang/Sema/MultiplexExternalSemaSource.h
include/clang/Sema/Sema.h
inc
On Fri, Apr 29, 2016 at 11:07 AM, Akira Hatanaka via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> If I add an assert to check (F != Flags) in setFlags, 2700+ out of 5000+
> clang regression tests fail. I haven’t figured out which parts of clang are
> passing the same value to setFlags.
>
Wh
tmsriram closed this revision.
tmsriram added a comment.
267948
http://reviews.llvm.org/D19687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268085: [MS] Make #pragma pack use PragmaStack<> class.
(authored by dzobnin).
Changed prior to commit:
http://reviews.llvm.org/D19727?vs=55598&id=55634#toc
Repository:
rL LLVM
http://reviews.llvm.o
Author: dzobnin
Date: Fri Apr 29 13:17:40 2016
New Revision: 268085
URL: http://llvm.org/viewvc/llvm-project?rev=268085&view=rev
Log:
[MS] Make #pragma pack use PragmaStack<> class.
Make implementation of #pragma pack consistent with other "stack" pragmas.
Use PragmaStack<> class instead of old r
vsk added a comment.
Thanks, lgtm with a nit.
Comment at: lib/CodeGen/CoverageMappingGen.cpp:452
@@ +451,3 @@
+[=](const SourceMappingRegion &Region) {
+ assert(Region.hasStartLoc() && "incomplete region");
+
doug.gregor added a comment.
Mostly looks good, but see my comment about MapVector invalidation.
Comment at: lib/Serialization/ASTWriter.cpp:4394
@@ +4393,3 @@
+ // date, so we need to pull in the new content here.
+ for (auto &SelectorAndID : SelectorIDs)
+SemaRef.updateO
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268082: Fix crash in BuildCXXDefaultInitExpr. (authored by
rnk).
Changed prior to commit:
http://reviews.llvm.org/D19721?vs=55580&id=55631#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19721
Fil
Author: rnk
Date: Fri Apr 29 13:06:53 2016
New Revision: 268082
URL: http://llvm.org/viewvc/llvm-project?rev=268082&view=rev
Log:
Fix crash in BuildCXXDefaultInitExpr.
Fix crash in BuildCXXDefaultInitExpr when member of template class has
same name as the class itself.
Based on patch by Raphael
Author: hubert.reinterpretcast
Date: Fri Apr 29 13:05:37 2016
New Revision: 268081
URL: http://llvm.org/viewvc/llvm-project?rev=268081&view=rev
Log:
[Concepts] Pass requires-clause to ActOnTemplateParameterList; NFC
Summary:
Prepare to store requires-clause expression for access via
TemplateParam
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268081: [Concepts] Pass requires-clause to
ActOnTemplateParameterList; NFC (authored by hubert.reinterpretcast).
Changed prior to commit:
http://reviews.llvm.org/D19220?vs=54050&id=55629#toc
Repository
If I add an assert to check (F != Flags) in setFlags, 2700+ out of 5000+ clang
regression tests fail. I haven’t figured out which parts of clang are passing
the same value to setFlags.
> On Apr 28, 2016, at 7:38 PM, Richard Smith via cfe-commits
> wrote:
>
> On Thu, Apr 28, 2016 at 7:34 PM, A
[Sebastian Redl]
> I rail against this warning here:
> http://stackoverflow.com/questions/18979503/why-locally-defined-struct-in-function-need-assignment-operator-copy-construct/18979812#18979812
> It's not just that the warning is silly, it's also a level 1 warning, which
> is extra-silly. (MSVC'
Author: prazek
Date: Fri Apr 29 12:58:29 2016
New Revision: 268079
URL: http://llvm.org/viewvc/llvm-project?rev=268079&view=rev
Log:
Add boost-use-to-string
http://reviews.llvm.org/D18136
Added:
clang-tools-extra/trunk/clang-tidy/boost/
clang-tools-extra/trunk/clang-tidy/boost/BoostTidyM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268078: [Clang][Darwin] Define __ARM_DWARF_EH__ for WatchABI
(authored by cbieneman).
Changed prior to commit:
http://reviews.llvm.org/D19693?vs=55626&id=55627#toc
Repository:
rL LLVM
http://reviews
Author: cbieneman
Date: Fri Apr 29 12:53:00 2016
New Revision: 268078
URL: http://llvm.org/viewvc/llvm-project?rev=268078&view=rev
Log:
[Clang][Darwin] Define __ARM_DWARF_EH__ for WatchABI
Summary: The Darwin armv7k ABI uses Dwarf EH, so we need to set the OS define
correctly. Without this the g
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Looks good. Thanks Chris!
http://reviews.llvm.org/D19693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
beanz updated this revision to Diff 55626.
beanz added a comment.
Adding a test case, and properly rebasing on trunk.
http://reviews.llvm.org/D19693
Files:
lib/Basic/Targets.cpp
test/Preprocessor/arm-target-features.c
Index: test/Preprocessor/arm-target-features.c
=
etienneb added a comment.
In http://reviews.llvm.org/D19586#417063, @xazax.hun wrote:
> In http://reviews.llvm.org/D19586#417053, @etienneb wrote:
>
> > The rule also apply for statements in a same compound:
> >
> > {
> > statement1();
> > statement2();
> > statement3();
> >
> >
>
Author: prazek
Date: Fri Apr 29 12:45:20 2016
New Revision: 268076
URL: http://llvm.org/viewvc/llvm-project?rev=268076&view=rev
Log:
small reformat to test access
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/PassByValueCheck.cpp
Modified: clang-tools-extra/trunk/clang-tidy/moderniz
1 - 100 of 181 matches
Mail list logo
