Re: [PATCH] D19524: [OpenCL] Fix pipe type dump.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268364: [OpenCL] Fix pipe type dump. (authored by pxl). Changed prior to commit: http://reviews.llvm.org/D19524?vs=55161=55946#toc Repository: rL LLVM http://reviews.llvm.org/D19524 Files:

r268364 - [OpenCL] Fix pipe type dump.

Author: pxl Date: Tue May 3 00:37:07 2016 New Revision: 268364 URL: http://llvm.org/viewvc/llvm-project?rev=268364=rev Log: [OpenCL] Fix pipe type dump. Summary: Fix the dump of PipeType. Now we will have "pipe int" and element type. Reviewers: yaxunl, Anastasia Subscribers: cfe-commits,

Re: [PATCH] D19835: Tolerate incorrect return type for 'isinf' and 'isnan' in tests.

mclow.lists added a comment. How about not using XFAIL? Instead, just test for those two conditions. Psuedo-code: #if defined(GLIBC) #if GLIBC < 226 #error #elif TEST_STD_VER >= 11 #error #endif. http://reviews.llvm.org/D19835 ___

[libcxx] r268363 - Fix dependencies on install-libcxx CMake target

Author: ericwf Date: Tue May 3 00:34:38 2016 New Revision: 268363 URL: http://llvm.org/viewvc/llvm-project?rev=268363=rev Log: Fix dependencies on install-libcxx CMake target Modified: libcxx/trunk/lib/CMakeLists.txt Modified: libcxx/trunk/lib/CMakeLists.txt URL:

[PATCH] D19854: Define Contiki OS toolchain

mlemay-intel created this revision. mlemay-intel added reviewers: pcc, eugenis. mlemay-intel added a subscriber: cfe-commits. It is defined with support for the SafeStack sanitizer on x86. http://reviews.llvm.org/D19854 Files: lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp

[PATCH] D19853: [safestack] Add -fruntime-init to support invoking functions during runtime init

mlemay-intel created this revision. mlemay-intel added reviewers: pcc, eugenis. mlemay-intel added a subscriber: cfe-commits. SafeStack uses thread-local storage by default in most OSes for the unsafe stack pointer. For SafeStack to be applied to functions that may be invoked while initializing

[PATCH] D19851: Warn on binding reference to null in copy initialization

nicholas created this revision. nicholas added a reviewer: cfe-commits. The attached patch adds a warning when placing a call like: func(*static_cast(nullptr)); to the existing -Wnull-dereference warning. The existing warning catches the case where the empty lvalue undergoes

Re: [PATCH] D19841: [clang-tidy] Lift common matchers to utils namespace

etienneb added a comment. Who is the owner of ASTMatcher? If he is willing to receive these matchers in ASTMatcher, I'll lift them. Otherwise, we should at least lift them within clang-tidy. http://reviews.llvm.org/D19841 ___ cfe-commits mailing

[clang-tools-extra] r268356 - [clang-tidy] Cleanup namespace in utils folder.

Author: etienneb Date: Mon May 2 21:54:05 2016 New Revision: 268356 URL: http://llvm.org/viewvc/llvm-project?rev=268356=rev Log: [clang-tidy] Cleanup namespace in utils folder. Summary: This is a step forward cleaning up the namespaces in clang-tidy/utils. There is no behavior change.

Re: [PATCH] D19412: [libcxx] Refactor pthread usage - II

EricWF added a comment. In http://reviews.llvm.org/D19412#417729, @rmaprath wrote: > So, perhaps it is best to leave these pthread mutexes alone, purely for > performance reasons. We'll have to excuse a couple of `#ifdef > _LIBCPP_THREAD_API_` conditionals in the library sources to allow

[libcxx] r268355 - [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f; "

Author: ericwf Date: Mon May 2 21:12:26 2016 New Revision: 268355 URL: http://llvm.org/viewvc/llvm-project?rev=268355=rev Log: [libcxx] [test] Replace non-Standard "atomic_flag f(false);" with Standard "atomic_flag f;" Summary: Replace non-Standard "atomic_flag f(false);" with Standard

Re: [PATCH] D19849: [clang-tidy] MoveConstructorInitCheck - Add parameter name to check message.

alexfh added inline comments. Comment at: clang-tidy/misc/MoveConstructorInitCheck.cpp:114 @@ -114,1 +113,3 @@ + "value argument %0 can be moved to avoid copy") + << MovableParam->getName(); DiagOut << FixItHint::CreateReplacement(

[libcxx] r268354 - Don't use std::__clz in 'test/support/hexfloat.h'.

Author: ericwf Date: Mon May 2 21:04:26 2016 New Revision: 268354 URL: http://llvm.org/viewvc/llvm-project?rev=268354=rev Log: Don't use std::__clz in 'test/support/hexfloat.h'. std::__clz is a libc++ specific function so it can't be used in the test suite. This patch implements a dumb "count

Re: [PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

rjmccall added a comment. This discussion of the command line interface makes me think that we should be taking Richard's suggestion one step further. Why is Clang's involvement here more than just handing down specific requests for optimization data to LLVM and packaging that information

Re: [PATCH] D19841: [clang-tidy] Lift common matchers to utils namespace

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/utils/Matchers.h:20 @@ -19,1 +19,3 @@ +AST_MATCHER_P(StringLiteral, lengthIs, unsigned, N) { + return Node.getLength() == N; All these should go to

Re: [PATCH] D18300: [clang-tidy] ProTypeMemberInitCheck - check that field decls do not have in-class initializer

This revision was automatically updated to reflect the committed changes. Closed by commit rL268352: [clang-tidy] ProTypeMemberInitCheck - check that field decls do not have in… (authored by flx). Changed prior to commit: http://reviews.llvm.org/D18300?vs=51123=55934#toc Repository: rL LLVM

[clang-tools-extra] r268352 - [clang-tidy] ProTypeMemberInitCheck - check that field decls do not have in-class initializer.

Author: flx Date: Mon May 2 20:41:19 2016 New Revision: 268352 URL: http://llvm.org/viewvc/llvm-project?rev=268352=rev Log: [clang-tidy] ProTypeMemberInitCheck - check that field decls do not have in-class initializer. Reviewers: alexfh, JVApen, aaron.ballman Subscribers: flx, aaron.ballman,

Re: [PATCH] D19819: [clang-tidy] Cleanup namespace in utils folder.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! http://reviews.llvm.org/D19819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D19846: [clang-tidy] Lift parsing of sequence of names functions to utils.

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. Lift some common code used by multiple checkers. This function is also used by checkers that are coming. It is quite common for a checker to parse a list of names.

[clang-tools-extra] r268349 - [Clang-tidy] Fix Clang-tidy modernize-use-override and some Include What You Use warnings in modernize/MakeSmartPtrCheck.h.

Author: eugenezelenko Date: Mon May 2 20:13:27 2016 New Revision: 268349 URL: http://llvm.org/viewvc/llvm-project?rev=268349=rev Log: [Clang-tidy] Fix Clang-tidy modernize-use-override and some Include What You Use warnings in modernize/MakeSmartPtrCheck.h. Modified:

Re: [PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

hfinkel added a comment. In http://reviews.llvm.org/D19678#419361, @rcox2 wrote: > Of course, it would be my preference to mirror the functionality of what is > available in the "new" hierarchical form of optimization report Intel > compiler. So, I would like to distinguish between what Hal

Re: [PATCH] D19758: [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f; "

STL_MSFT added a comment. I think this will work for me. Thanks! http://reviews.llvm.org/D19758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r268346 - Guard use of in test.

Author: ericwf Date: Mon May 2 19:36:57 2016 New Revision: 268346 URL: http://llvm.org/viewvc/llvm-project?rev=268346=rev Log: Guard use of in test. Modified: libcxx/trunk/test/std/numerics/rand/rand.device/ctor.pass.cpp Modified:

Re: [PATCH] D19048: Test for a module related crash in CGDebugInfo.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rL268344: Adding a test for a compiler crash that was fixed in r248069. (authored by dyung). Changed prior to commit: http://reviews.llvm.org/D19048?vs=55495=55925#toc Repository: rL LLVM

r268344 - Adding a test for a compiler crash that was fixed in r248069.

Author: dyung Date: Mon May 2 19:29:56 2016 New Revision: 268344 URL: http://llvm.org/viewvc/llvm-project?rev=268344=rev Log: Adding a test for a compiler crash that was fixed in r248069. Differential Revision: http://reviews.llvm.org/D19048 Added:

[PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

eric_niebler created this revision. eric_niebler added a reviewer: bruno. eric_niebler added a subscriber: cfe-commits. Full discussion of this diff can be found here: http://lists.llvm.org/pipermail/cfe-dev/2016-April/048298.html See D19842 for the corresponding LLVM diff. Before this is

Re: [PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

rcox2 added a comment. Of course, it would be my preference to mirror the functionality of what is available in the "new" hierarchical form of optimization report Intel compiler. So, I would like to distinguish between what Hal is proposing (which we call an "annotated listing") and what I am

Re: [PATCH] D19758: [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f; "

EricWF retitled this revision from "[libcxx] [test] Replace non-Standard "atomic_flag f(false);" with Standard "atomic_flag f = ATOMIC_FLAG_INIT;"." to "[libcxx] [test] Replace non-Standard "atomic_flag f(false);" with Standard "atomic_flag f;" ". EricWF updated the summary for this revision.

Re: [PATCH] D19758: [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f = ATOMIC_FLAG_INIT; ".

EricWF commandeered this revision. EricWF edited reviewers, added: STL_MSFT; removed: EricWF. EricWF added a comment. Stealing this review from STL. http://reviews.llvm.org/D19758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D19841: [clang-tidy] Lift common matchers to utils namespace

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. This patch is lifting matchers used by more than one checkers to the common namespace. http://reviews.llvm.org/D19841 Files: clang-tidy/misc/BoolPointerImplicitConversionCheck.cpp

Re: [PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

On Mon, May 2, 2016 at 4:14 PM, Hal Finkel via cfe-commits < cfe-commits@lists.llvm.org> wrote: > hfinkel added a comment. > > In http://reviews.llvm.org/D19678#416127, @rcox2 wrote: > > > Actually, the Intel compiler distinguishes between an optimization > report (-qopt-report) and an annotated

Re: [PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

hfinkel added a comment. In http://reviews.llvm.org/D19678#416127, @rcox2 wrote: > Actually, the Intel compiler distinguishes between an optimization report > (-qopt-report) and an annotated listing (-qopt-report-annotate). The > optimization report lists the info for optimizations in a

Re: [PATCH] D19802: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a class that initializes itself as a base

aaron.ballman added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:342 @@ +341,3 @@ + +// This pathological template fails to compile if actually instantiated. It +// results in the check seeing a null RecordDecl when examining the base

Re: [PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

hfinkel updated this revision to Diff 55907. hfinkel added a comment. Renamed the option from -flisting to -foptimization-report as suggested. Moved I/O-related and formatting-related code into Frontend. http://reviews.llvm.org/D19678 Files: include/clang/Driver/CC1Options.td

r268322 - [CMake] Enable LIBCXX HEADERS in Apple-Stage2.cmake

Author: cbieneman Date: Mon May 2 17:43:23 2016 New Revision: 268322 URL: http://llvm.org/viewvc/llvm-project?rev=268322=rev Log: [CMake] Enable LIBCXX HEADERS in Apple-Stage2.cmake This enables installing the libcxx headers. Modified: cfe/trunk/cmake/caches/Apple-stage2.cmake Modified:

r268320 - [CMake] Install libcxx-headers as part of the Apple-stage2 distribution

Author: cbieneman Date: Mon May 2 17:42:09 2016 New Revision: 268320 URL: http://llvm.org/viewvc/llvm-project?rev=268320=rev Log: [CMake] Install libcxx-headers as part of the Apple-stage2 distribution This installs the clang headers as part of the install-distribution target. Modified:

r268321 - Fix argument expansion of reference fields of structs

Author: rnk Date: Mon May 2 17:42:34 2016 New Revision: 268321 URL: http://llvm.org/viewvc/llvm-project?rev=268321=rev Log: Fix argument expansion of reference fields of structs r268261 made Clang "expand" more struct arguments on Windows. It removed the check for 'RD->isCLike()', which was

r268319 - [CMake] Adding clang-headers to the Apple-stage2 distribution

Author: cbieneman Date: Mon May 2 17:38:06 2016 New Revision: 268319 URL: http://llvm.org/viewvc/llvm-project?rev=268319=rev Log: [CMake] Adding clang-headers to the Apple-stage2 distribution This installs the clang headers as part of the install-distribution target. Modified:

Re: r268314 - [CodeGenObjCXX] Don't rematerialize default arguments of function

Thanks, fixed in r268318. > On May 2, 2016, at 3:05 PM, Richard Smith wrote: > > On Mon, May 2, 2016 at 2:52 PM, Akira Hatanaka via cfe-commits > > wrote: > Author: ahatanak > Date: Mon May 2 16:52:57 2016 >

Re: [PATCH] D19835: Tolerate incorrect return type for 'isinf' and 'isnan' in tests.

jroelofs added a comment. > Alternatively `static_assert(std::is_same bool>::value);` :-P > > Testing the return type isn't the problem. The problem is telling LIT *when* > we expect the test to fail using the `XFAIL` directive. O. I see.

Re: [PATCH] D19802: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a class that initializes itself as a base

michael_miller updated this revision to Diff 55904. michael_miller added a comment. Added a comment explaining the new test added. http://reviews.llvm.org/D19802 Files: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp

Re: [PATCH] D19802: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a class that initializes itself as a base

michael_miller marked 4 inline comments as done. Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:342 @@ +341,3 @@ + +// This pathological template fails to compile if actually instantiated. It +// results in the check seeing a null RecordDecl when examining

Re: [PATCH] D19536: [CodeGenObjCXX] Fix handling of blocks in lambda

ahatanak added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:806 @@ -792,1 +805,3 @@ + } + src = Builder.CreateStructGEP(Addr, Idx, Offset, FD->getName()); } else { rjmccall wrote: > Hmm. It's become increasingly clear that my original

r268318 - Remove unneeded test in tryCaptureAsConstant.

Author: ahatanak Date: Mon May 2 17:29:40 2016 New Revision: 268318 URL: http://llvm.org/viewvc/llvm-project?rev=268318=rev Log: Remove unneeded test in tryCaptureAsConstant. It isn't necessary to call hasDefaultArg because we can't rematerialize a captured variable that is a function

Re: [PATCH] D19802: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a class that initializes itself as a base

michael_miller added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:342 @@ +341,3 @@ + +template +class PositiveSelfInitialization : NegativeAggregateType aaron.ballman wrote: > hokein wrote: > > aaron.ballman wrote: > >

Re: r268314 - [CodeGenObjCXX] Don't rematerialize default arguments of function

It looks like turning it to an assert wouldn’t be correct, I’ll probably just remove it. > On May 2, 2016, at 3:12 PM, Akira Hatanaka via cfe-commits > wrote: > > I see. Perhaps this should be an assert? > >> On May 2, 2016, at 3:05 PM, Richard Smith

Re: r268314 - [CodeGenObjCXX] Don't rematerialize default arguments of function

I see. Perhaps this should be an assert? > On May 2, 2016, at 3:05 PM, Richard Smith wrote: > > On Mon, May 2, 2016 at 2:52 PM, Akira Hatanaka via cfe-commits > > wrote: > Author: ahatanak > Date: Mon May 2

Re: r268314 - [CodeGenObjCXX] Don't rematerialize default arguments of function

On Mon, May 2, 2016 at 2:52 PM, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ahatanak > Date: Mon May 2 16:52:57 2016 > New Revision: 268314 > > URL: http://llvm.org/viewvc/llvm-project?rev=268314=rev > Log: > [CodeGenObjCXX] Don't rematerialize default arguments

Re: [PATCH] D19831: [scan-build] fix dead store warnings emitted on clang code base

apelete added a comment. In http://reviews.llvm.org/D19831#419140, @dblaikie wrote: > Any reason not to remove the story instead? What do you mean by "remove the story" ? http://reviews.llvm.org/D19831 ___ cfe-commits mailing list

r268314 - [CodeGenObjCXX] Don't rematerialize default arguments of function

Author: ahatanak Date: Mon May 2 16:52:57 2016 New Revision: 268314 URL: http://llvm.org/viewvc/llvm-project?rev=268314=rev Log: [CodeGenObjCXX] Don't rematerialize default arguments of function parameters in the body of a block. This fixes a bug where clang would materialize the default

Re: [PATCH] D19835: Tolerate incorrect return type for 'isinf' and 'isnan' in tests.

EricWF added a comment. In http://reviews.llvm.org/D19835#419211, @jroelofs wrote: > I think you could lean on the linker to cause the test to fail when the type > is wrong: > > bool isinf(double); > > typedef int (*expected_signature)(double); > > void

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Eugene.Zelenko added a comment. Check is still not mentioned in docs/ReleaseNotes.rst. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

Prazek added a comment. lgtm, but I'd rather see Hokein acceptance. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19835: Tolerate incorrect return type for 'isinf' and 'isnan' in tests.

jroelofs added a subscriber: jroelofs. jroelofs added a comment. I think you could lean on the linker to cause the test to fail when the type is wrong: bool isinf(double); typedef int (*expected_signature)(double); void assert_via_linker(decltype(isinf) blah); void

[PATCH] D19835: Tolerate incorrect return type for 'isinf' and 'isnan' it tests.

EricWF created this revision. EricWF added reviewers: rsmith, mclow.lists. EricWF added a subscriber: cfe-commits. GLIBC recently removed the incorrect `int isinf(double)` and `int isnan(double)` overloads in C++11 and greater. This causes previously `XFAIL: linux` tests to start passing.

Re: [PATCH] D19831: [scan-build] fix dead store warnings emitted on clang code base

Any reason not to remove the story instead? On Mon, May 2, 2016 at 1:36 PM, Apelete Seketeli via cfe-commits < cfe-commits@lists.llvm.org> wrote: > apelete created this revision. > apelete added a reviewer: akyrtzi. > apelete added a subscriber: cfe-commits. > > This fixes dead store warnings of

[PATCH] D19831: [scan-build] fix dead store warnings emitted on clang code base

apelete created this revision. apelete added a reviewer: akyrtzi. apelete added a subscriber: cfe-commits. This fixes dead store warnings of the type "dead assignment" reported by CLang Static Analyzer on the following file: - tools/c-index-test/c-index-test.c. Signed-off-by: Apelete Seketeli

Re: [PATCH] D19748: [CUDA] Make sure device-side __global__ functions are always visible.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268299: [CUDA] Make sure device-side __global__ functions are always visible. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D19748?vs=55674=55885#toc Repository: rL LLVM

r268299 - [CUDA] Make sure device-side __global__ functions are always visible.

Author: tra Date: Mon May 2 15:30:03 2016 New Revision: 268299 URL: http://llvm.org/viewvc/llvm-project?rev=268299=rev Log: [CUDA] Make sure device-side __global__ functions are always visible. __global__ functions are a special case in CUDA. Even when the symbol would normally not be

[PATCH] D19830: [scan-build] fix dead store warnings emitted on clang code base

apelete created this revision. apelete added a reviewer: doug.gregor. apelete added a subscriber: cfe-commits. This fixes dead store warnings of the type "dead assignment" reported by CLang Static Analyzer on the following files: - lib/Lex/Lexer.cpp, - lib/Lex/ModuleMap.cpp. Signed-off-by:

[PATCH] D19829: [scan-build] fix dead store warnings emitted on clang code base

apelete created this revision. apelete added reviewers: rjmccall, rtrieu, rsmith. apelete added a subscriber: cfe-commits. This fixes dead store warnings of the type "dead assignment" reported by CLang Static Analyzer on the following files: - lib/Sema/SemaDeclCXX.cpp, - lib/Sema/SemaExpr.cpp, -

r268297 - Revert "[Driver] Quote clang full version in dwarf producer when invoking cc1as"

Author: bruno Date: Mon May 2 15:20:49 2016 New Revision: 268297 URL: http://llvm.org/viewvc/llvm-project?rev=268297=rev Log: Revert "[Driver] Quote clang full version in dwarf producer when invoking cc1as" This reverts commit r264813 / 6484b95d634f53dd929c75265ef3c4decf397584. While using it

Re: [PATCH] D19708: [CGDebugInfo] Generate debug info for member calls in the context of the callee expression

- Original Message - > From: "David Blaikie" > To: reviews+d19708+public+e9ddc42503732...@reviews.llvm.org, "Hal Finkel" > > Cc: "Richard Smith" , "Adrian Prantl" > , "Duncan P. N. Exon Smith" >

[PATCH] D19827: Do not disable completely loop unroll according to optimization level.

mamai created this revision. mamai added a reviewer: chandlerc. mamai added a subscriber: cfe-commits. mamai set the repository for this revision to rL LLVM. By disabling completely the loop unroll at some optimization levels (e.g. /Os), the #pragma unroll have no effect at those optimization

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

yaxunl added a comment. typo. saved 300KB space. http://reviews.llvm.org/D18369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r268294 - Cleanup warnings and remove use of __builtin_va_list in depr.c.headers

Author: ericwf Date: Mon May 2 15:08:16 2016 New Revision: 268294 URL: http://llvm.org/viewvc/llvm-project?rev=268294=rev Log: Cleanup warnings and remove use of __builtin_va_list in depr.c.headers Modified: libcxx/trunk/test/std/depr/depr.c.headers/fenv_h.pass.cpp

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL header file.

yaxunl added inline comments. Comment at: lib/Headers/opencl-c.h:4872 @@ +4871,3 @@ + +#ifdef cl_khr_fp64 +char __const_func __attribute__((overloadable)) convert_char(double); Anastasia wrote: > Interesting, macro has the same name as an extension? The spec

Re: [PATCH] D19819: [clang-tidy] Cleanup namespace in utils folder.

etienneb updated this revision to Diff 55876. etienneb added a comment. fix unittests http://reviews.llvm.org/D19819 Files: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.h

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna marked 4 inline comments as done. krystyna added a comment. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna updated this revision to Diff 55867. Repository: rL LLVM http://reviews.llvm.org/D18919 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseUsingCheck.cpp clang-tidy/modernize/UseUsingCheck.h

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna added a comment. hide done comments Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19758: [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f = ATOMIC_FLAG_INIT; ".

STL_MSFT added a comment. Makes sense. MSVC will never have C++03 or C++11 modes (only 14/17/future) so anything you do in C++03 mode is fine by me. http://reviews.llvm.org/D19758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19758: [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f = ATOMIC_FLAG_INIT; ".

EricWF added a comment. I actually want this form of initialization to break in C++03, From the original review: > After putting this question up on cfe-dev I have decided that it would be > best to allow the use of in C++03. Although static initialization is > a concern the syntax required

Re: [PATCH] D19623: [libcxx] [test] Initialize local doubles to NaN.

EricWF closed this revision. EricWF added a comment. r268285. http://reviews.llvm.org/D19623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r268285 - Initialize local doubles to NaN. Patch from s...@microsoft.com

Author: ericwf Date: Mon May 2 14:20:16 2016 New Revision: 268285 URL: http://llvm.org/viewvc/llvm-project?rev=268285=rev Log: Initialize local doubles to NaN. Patch from s...@microsoft.com Modified:

Re: [PATCH] D19758: [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f = ATOMIC_FLAG_INIT; ".

STL_MSFT added a comment. Since you control the definition of ATOMIC_FLAG_INIT, can you make it something like __secret_tag_type() in C++03? That would allow you to continue to provide the atomic_flag(bool) extension in C++03. http://reviews.llvm.org/D19758

Re: [PATCH] D19623: [libcxx] [test] Initialize local doubles to NaN.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I have no objections to this change. Howard seems to agree. http://reviews.llvm.org/D19623 ___ cfe-commits mailing list

Re: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

EricWF closed this revision. EricWF added a comment. r268284. In http://reviews.llvm.org/D19625#418697, @STL_MSFT wrote: > No problem! With these changes, my test runs are currently clean wrt "warning > C4100: unreferenced formal parameter" and "warning C4101: unreferenced local > variable",

[libcxx] r268284 - Void cast runtime-unused variables. Patch from s...@microsoft.com

Author: ericwf Date: Mon May 2 14:15:48 2016 New Revision: 268284 URL: http://llvm.org/viewvc/llvm-project?rev=268284=rev Log: Void cast runtime-unused variables. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/depr/depr.c.headers/setjmp_h.pass.cpp

Re: [PATCH] D18919: [Clang-tidy] Add check "modernize use using"

krystyna marked 8 inline comments as done. krystyna added a comment. Repository: rL LLVM http://reviews.llvm.org/D18919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19758: [libcxx] [test] Replace non-Standard "atomic_flag f(false); " with Standard "atomic_flag f = ATOMIC_FLAG_INIT; ".

EricWF added a comment. This is a small problem. We actually provide in C++03 minus `ATOMIC_FLAG_INIT` since it requires C++11. I'll come up with a way to fix these tests so they keep working in C++03. http://reviews.llvm.org/D19758 ___

Re: [PATCH] D19819: [clang-tidy] Cleanup namespace in utils folder.

etienneb updated this revision to Diff 55858. etienneb added a comment. add missing case http://reviews.llvm.org/D19819 Files: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.h

Re: [PATCH] D19754: Allow 'nodebug' on local variables

dblaikie added inline comments. Comment at: test/CodeGenCXX/debug-info-nodebug.cpp:50 @@ -49,1 +49,3 @@ NODEBUG static int static_local = 6; + NODEBUG const int const_local = 7; + NODEBUGint normal_local = 8; Doesn't look like the const case is any

[PATCH] D19819: [clang-tidy] Cleanup namespace in utils folder.

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. This is a step forward cleaning up the namespaces in clang-tidy/utils. There is no behavior change. http://reviews.llvm.org/D19819 Files:

Re: [PATCH] D19567: PR21823: 'nodebug' attribute on global/static variables

dblaikie added a comment. In http://reviews.llvm.org/D19567#414906, @probinson wrote: > Huh. There are strange interactions here, which makes me even more nervous > about testing fewer cases. Generally this sort of thing makes me more interested in testing fewer cases so we can see/make

Re: [PATCH] D19802: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a class that initializes itself as a base

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a commenting request. Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:342 @@ +341,3 @@ + +template +class PositiveSelfInitialization : NegativeAggregateType

Re: [PATCH] D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC

hubert.reinterpretcast marked 2 inline comments as done. hubert.reinterpretcast added a comment. @rsmith; I've addressed Faisal's comment. Please let me know if this patch (and http://reviews.llvm.org/D19770) is good to go. If it isn't ready yet, I'd like your opinion on

[clang-tools-extra] r268264 - [clang-tidy] Cleaning namespaces to be more consistant across checkers.

Author: etienneb Date: Mon May 2 13:00:29 2016 New Revision: 268264 URL: http://llvm.org/viewvc/llvm-project?rev=268264=rev Log: [clang-tidy] Cleaning namespaces to be more consistant across checkers. Summary: The goal of the patch is to bring checkers in their appropriate namespace. This path

Re: [PATCH] D19815: Support '#pragma once' in headers when using PCH

rnk added a subscriber: rnk. rnk added a comment. I think threading this through PP options is reasonable. Comment at: test/PCH/pragma-once.h:1 @@ +1,2 @@ +#pragma once + This should be in test/PCH/Inputs http://reviews.llvm.org/D19815

Re: [PATCH] D19322: Concepts: Create space for requires-clause in TemplateParameterList; NFC

hubert.reinterpretcast updated this revision to Diff 55850. hubert.reinterpretcast added a comment. Address Faisal's comment; supercedes http://reviews.llvm.org/D19771 Replaces the custom FixedSizeTemplateParameterListStorage implementation with one that follows the interface provided by

Re: [PATCH] D19802: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a class that initializes itself as a base

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:342 @@ +341,3 @@ + +template +class PositiveSelfInitialization : NegativeAggregateType

[clang-tools-extra] r268262 - [include-fixer] Fix Clang-tidy modernize-use-override and some Include What You Use warnings.

Author: eugenezelenko Date: Mon May 2 12:49:00 2016 New Revision: 268262 URL: http://llvm.org/viewvc/llvm-project?rev=268262=rev Log: [include-fixer] Fix Clang-tidy modernize-use-override and some Include What You Use warnings. Differential revision: http://reviews.llvm.org/D19755 Modified:

Re: [PATCH] D19755: [include-fixer] Fix Clang-tidy modernize-use-override and some Include What You Use warnings

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rL LLVM http://reviews.llvm.org/D19755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19756: Expand aggregate arguments more often on 32-bit Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL268261: Expand aggregate arguments more often on 32-bit Windows (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D19756?vs=55695=55845#toc Repository: rL LLVM

r268261 - Expand aggregate arguments more often on 32-bit Windows

Author: rnk Date: Mon May 2 12:41:07 2016 New Revision: 268261 URL: http://llvm.org/viewvc/llvm-project?rev=268261=rev Log: Expand aggregate arguments more often on 32-bit Windows Before this change, we would pass all non-HFA record arguments on Windows with byval. Byval often blocks

Re: [PATCH] D19756: Expand aggregate arguments more often on 32-bit Windows

rnk marked an inline comment as done. rnk added a comment. In http://reviews.llvm.org/D19756#417718, @hans wrote: > This is awesome! lgtm Great! > Want to reference PR27522 in the patch description? > > Also in the description: > > > I also expanded the workaround handle C++ records

Re: [PATCH] D19815: Support '#pragma once' in headers when using PCH

wristow added a comment. To check for whether we're in "generate a PCH file mode", I added a new flag (`GeneratePCHMode`) to `PreprocessorOptions`. If the `CompilerInstance` had been visible in lexical analysis, it would have been easy to do this without adding a new flag. Is there a better

[PATCH] D19815: Support '#pragma once' in headers when using PCH

wristow created this revision. wristow added a reviewer: rsmith. wristow added a subscriber: cfe-commits. The '#pragma once' directive was erroneously ignored when encountered in the header-file specified in generate-PCH-mode. This resulted in compile-time errors in some cases with legal code,

r268256 - [WebAssembly] Rename memory_size intrinsic to current_memory

Author: dschuff Date: Mon May 2 12:26:19 2016 New Revision: 268256 URL: http://llvm.org/viewvc/llvm-project?rev=268256=rev Log: [WebAssembly] Rename memory_size intrinsic to current_memory This follows the recent change in the wasm spec. Modified:

Re: [PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target info.

yaxunl updated this revision to Diff 55839. yaxunl marked 2 inline comments as done. yaxunl added a comment. Add comments about macros for enumerating extensions. Improve diagnostics about extensions. http://reviews.llvm.org/D19484 Files: include/clang/Basic/DiagnosticParseKinds.td

  1   2   >