Re: [PATCH] D19484: [OpenCL] Add supported OpenCL extensions to target info.

2016-05-02 Thread Yaxun Liu via cfe-commits
yaxunl added inline comments. Comment at: test/CodeGenOpenCL/builtins-r600.cl:2 @@ -1,3 +1,3 @@ // REQUIRES: amdgpu-registered-target -// RUN: %clang_cc1 -triple r600-unknown-unknown -S -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple r600-unknown-unknown

[clang-tools-extra] r268253 - [clang-tidy] Add modernize-make-shared check

2016-05-02 Thread Piotr Padlewski via cfe-commits
Author: prazek Date: Mon May 2 11:56:39 2016 New Revision: 268253 URL: http://llvm.org/viewvc/llvm-project?rev=268253=rev Log: [clang-tidy] Add modernize-make-shared check Because modernize-make-shared do almost the same job as modernize-make-unique, I refactored common code to

Re: [PATCH] D19811: [clang-tidy] Cleaning namespaces to be more consistant across checkers.

2016-05-02 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! http://reviews.llvm.org/D19811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19625: [libc++] Void-cast runtime-unused variables.

2016-05-02 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT added a comment. No problem! With these changes, my test runs are currently clean wrt "warning C4100: unreferenced formal parameter" and "warning C4101: unreferenced local variable", but note that (1) Clang may emit unused-variable warnings in somewhat different situations, and (2)

[PATCH] D19811: [clang-tidy] Cleaning namespaces to be more consistant across checkers.

2016-05-02 Thread Etienne Bergeron via cfe-commits
etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. The goal of the patch is to bring checkers in their appropriate namespace. This path doesn't change any behavior. http://reviews.llvm.org/D19811 Files:

Re: [PATCH] D19403: Add loop pragma for Loop Distribution

2016-05-02 Thread Adam Nemet via cfe-commits
anemet added a comment. @rsmith, hi! Do you have any comments on this or you're OK with this per Aaron's LGTM? Thanks, Adam http://reviews.llvm.org/D19403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19754: Allow 'nodebug' on local variables

2016-05-02 Thread Paul Robinson via cfe-commits
probinson added inline comments. Comment at: include/clang/Basic/Attr.td:86-88 @@ -85,1 +85,5 @@ +def NonParmVar : SubsetSubjectgetKind() != Decl::ImplicitParam && + S->getKind() != Decl::ParmVar && +

Re: [PATCH] D19771: Rework FixedSizeTemplateParameterListStorage

2016-05-02 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast updated this revision to Diff 55825. hubert.reinterpretcast added a comment. Adjust for changes to http://reviews.llvm.org/D19770 http://reviews.llvm.org/D19771 Files: include/clang/AST/DeclTemplate.h Index: include/clang/AST/DeclTemplate.h

Re: [PATCH] D19770: Add FixedSizeStorage to TrailingObjects; NFC

2016-05-02 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast marked 5 inline comments as done. hubert.reinterpretcast added a comment. Responded to all comments. http://reviews.llvm.org/D19770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r268230 - [CLANG][AVX512][BUILTIN]movap{d|s}{128|256|512}

2016-05-02 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Mon May 2 09:02:01 2016 New Revision: 268230 URL: http://llvm.org/viewvc/llvm-project?rev=268230=rev Log: [CLANG][AVX512][BUILTIN]movap{d|s}{128|256|512} Differential Revision: http://reviews.llvm.org/D17818 Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

[PATCH] D19804: Make clang-format cleaner remove redundant commas/colons in constructor initializer list.

2016-05-02 Thread Eric Liu via cfe-commits
ioeric created this revision. ioeric added reviewers: djasper, klimek. ioeric added a subscriber: cfe-commits. Herald added a subscriber: klimek. Make clang-format cleaner remove redundant commas/colons in constructor initializer list. http://reviews.llvm.org/D19804 Files:

Re: [PATCH] D14274: Add alloc_size attribute to clang

2016-05-02 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for working on this! LGTM, but please wait for @rsmith to okay as well. Comment at: test/SemaCXX/constant-expression-cxx11.cpp:1171 @@ -1170,3

Re: [PATCH] D19802: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a class that initializes itself as a base

2016-05-02 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp:342 @@ +341,3 @@ + +template +class PositiveSelfInitialization : NegativeAggregateType Is it required to be a templated class to trigger the crash?

Re: [PATCH] D19754: Allow 'nodebug' on local variables

2016-05-02 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:86-88 @@ -85,1 +85,5 @@ +def NonParmVar : SubsetSubjectgetKind() != Decl::ImplicitParam && + S->getKind() != Decl::ParmVar && +

Re: [clang-tools-extra] r268140 - [Release Notes] Mention Clang-tidy cert-err34-c check.

2016-05-02 Thread Aaron Ballman via cfe-commits
On Fri, Apr 29, 2016 at 8:11 PM, Eugene Zelenko via cfe-commits wrote: > Author: eugenezelenko > Date: Fri Apr 29 19:11:10 2016 > New Revision: 268140 > > URL: http://llvm.org/viewvc/llvm-project?rev=268140=rev > Log: > [Release Notes] Mention Clang-tidy cert-err34-c

Re: [PATCH] D19769: [clang-tidy] Add explicitly given array size heuristic to misc-suspicious-missing-comma check.

2016-05-02 Thread Dominik Szabó via cfe-commits
szdominik marked 3 inline comments as done. Comment at: clang-tidy/misc/SuspiciousMissingCommaCheck.cpp:106 @@ +105,3 @@ + if (InitializerList->hasArrayFiller()) { + diag(InitializerList->getExprLoc(), + "wrong string array initialization: "

Re: [PATCH] D19769: [clang-tidy] Add explicitly given array size heuristic to misc-suspicious-missing-comma check.

2016-05-02 Thread Dominik Szabó via cfe-commits
szdominik added inline comments. Comment at: clang-tidy/misc/SuspiciousMissingCommaCheck.cpp:94 @@ -93,3 +93,3 @@ Finder->addMatcher(StringsInitializerList.bind("list"), this); } etienneb wrote: > If it's working as-is,... this is neat :) Well, the array

[PATCH] D19796: Add new intrinsic support for MONITORX and MWAITX instructions.

2016-05-02 Thread Ganesh Gopalasubramanian via cfe-commits
GGanesh created this revision. GGanesh added reviewers: echristo, craig.topper. GGanesh added subscribers: cfe-commits, llvm-commits. Herald added a subscriber: joker.eph. This patch adds new intrinsics, new flag (-mwaitx) and flag enablement based on cpuid for the instructions MONITORX and

[PATCH] D19802: Fix a crash in cppcoreguidelines-pro-type-member-init when checking a class that initializes itself as a base

2016-05-02 Thread Michael Miller via cfe-commits
michael_miller created this revision. michael_miller added reviewers: hokein, alexfh, aaron.ballman. michael_miller added a subscriber: cfe-commits. Fix a crash when a record type initializes itself in its own base class initializer list. http://reviews.llvm.org/D19802 Files:

r268217 - [Clang][AVX512][BuiltIn] Adding intrinsics for cvtps2pd instruction set

2016-05-02 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Mon May 2 04:42:31 2016 New Revision: 268217 URL: http://llvm.org/viewvc/llvm-project?rev=268217=rev Log: [Clang][AVX512][BuiltIn] Adding intrinsics for cvtps2pd instruction set Differential Revision: http://reviews.llvm.org/D19774 Modified:

r268214 - [Clang][avx512][builtin] Adding intrinsics for vexpand{d|q|ps|pd} instrctuon set

2016-05-02 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Mon May 2 03:36:41 2016 New Revision: 268214 URL: http://llvm.org/viewvc/llvm-project?rev=268214=rev Log: [Clang][avx512][builtin] Adding intrinsics for vexpand{d|q|ps|pd} instrctuon set Differential Revision: http://reviews.llvm.org/D19467 Modified:

Re: [PATCH] D19534: [clang-tidy] new google-default-arguments check

2016-05-02 Thread Haojian Wu via cfe-commits
hokein added inline comments. Comment at: clang-tidy/google/DefaultArgumentsCheck.cpp:31 @@ +30,3 @@ + diag(MatchedDecl->getLocation(), + "default argument given for virtual or override method."); +} Usually, clang-tidy's warning message is not a sentence,

Re: [PATCH] D19183: [clang-tidy] Add modernize-make-shared check

2016-05-02 Thread Haojian Wu via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D19183 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r268213 - [Clang][BuiltIn][avx512] Adding intrinsics for vpshufd instruction set

2016-05-02 Thread Michael Zuckerman via cfe-commits
Author: mzuckerm Date: Mon May 2 02:35:27 2016 New Revision: 268213 URL: http://llvm.org/viewvc/llvm-project?rev=268213=rev Log: [Clang][BuiltIn][avx512] Adding intrinsics for vpshufd instruction set Differential Revision: http://reviews.llvm.org/D19580 Modified:

<    1   2