Re: [PATCH] D20052: Add new ASTMatcher that matches dynamic exception specifications.

2016-05-14 Thread don hinton via cfe-commits
hintonda updated this revision to Diff 57290. hintonda added a comment. - Added new isThrow matcher to complement isNoThrow, and changed hadDynamicExceptionSpec to take a parameter, e.g., isThrow() or isNoThrow(). http://reviews.llvm.org/D20052 Files: docs/LibASTMatchersReference.html incl

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

2016-05-14 Thread don hinton via cfe-commits
hintonda added a comment. I agree -- things got messy. I'm in the process of completely refactoring the whole thing -- including the ast matchers that I'll checkin later today. Thanks for your patience. http://reviews.llvm.org/D18575 ___ cfe-comm

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

2016-05-14 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. The last diff has nothing but a 2-line change in the docs. http://reviews.llvm.org/D20196 ___ cfe-commits mailing list cfe-commits@list

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

2016-05-14 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/modernize/UseNoexceptCheck.cpp:37 @@ +36,3 @@ +bool UseNoexceptCheck::checkHelper(const MatchFinder::MatchResult &Result, + const Sour

[libcxx] r269585 - Disable LIBCXX_ENABLE_ABI_LINKER_SCRIPT for static library builds.

2016-05-14 Thread Asiri Rathnayake via cfe-commits
Author: asiri Date: Sat May 14 18:58:11 2016 New Revision: 269585 URL: http://llvm.org/viewvc/llvm-project?rev=269585&view=rev Log: Disable LIBCXX_ENABLE_ABI_LINKER_SCRIPT for static library builds. This option is geared towards shared library builds and causes static library builds to fail if no

Re: [PATCH] D20170: [clang-tidy] TypeTraits - Type is not expensive to copy when it has a deleted copy constructor.

2016-05-14 Thread Felix Berger via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL269581: [clang-tidy] TypeTraits - Type is not expensive to copy when it has a deleted… (authored by flx). Changed prior to commit: http://reviews.llvm.org/D20170?vs=57286&id=57287#toc Repository: rL

[clang-tools-extra] r269581 - [clang-tidy] TypeTraits - Type is not expensive to copy when it has a deleted copy constructor.

2016-05-14 Thread Felix Berger via cfe-commits
Author: flx Date: Sat May 14 17:43:50 2016 New Revision: 269581 URL: http://llvm.org/viewvc/llvm-project?rev=269581&view=rev Log: [clang-tidy] TypeTraits - Type is not expensive to copy when it has a deleted copy constructor. Reviewers: alexfh, sbenza Subscribers: etienneb, aaron.ballman, cfe-c

Re: [PATCH] D20170: [clang-tidy] TypeTraits - Type is not expensive to copy when it has a deleted copy constructor.

2016-05-14 Thread Felix Berger via cfe-commits
flx added inline comments. Comment at: clang-tidy/utils/TypeTraits.cpp:42 @@ -27,3 +41,3 @@ llvm::Optional isExpensiveToCopy(QualType Type, ASTContext &Context) { if (Type->isDependentType()) etienneb wrote: > You're right too. > But, it's possible to fix th

Re: [PATCH] D20170: [clang-tidy] TypeTraits - Type is not expensive to copy when it has a deleted copy constructor.

2016-05-14 Thread Felix Berger via cfe-commits
flx updated this revision to Diff 57286. flx marked 3 inline comments as done. http://reviews.llvm.org/D20170 Files: clang-tidy/utils/TypeTraits.cpp clang-tidy/utils/TypeTraits.h test/clang-tidy/performance-unnecessary-value-param.cpp Index: test/clang-tidy/performance-unnecessary-value-pa

r269580 - [AVX512] Make the permd builtins take a 32-bit immediate to match the software spec.

2016-05-14 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat May 14 16:13:31 2016 New Revision: 269580 URL: http://llvm.org/viewvc/llvm-project?rev=269580&view=rev Log: [AVX512] Make the permd builtins take a 32-bit immediate to match the software spec. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def Modified: cfe/tr

r269575 - Revert r269546 "Added support to the ASTImporter for C++ constructor initializers." as it breaks TestDataFormatterSynthVal.DataFormatterSynthValueTestCase.test_with_run_command_dwarf test -

2016-05-14 Thread Oleksiy Vyalov via cfe-commits
Author: ovyalov Date: Sat May 14 14:07:13 2016 New Revision: 269575 URL: http://llvm.org/viewvc/llvm-project?rev=269575&view=rev Log: Revert r269546 "Added support to the ASTImporter for C++ constructor initializers." as it breaks TestDataFormatterSynthVal.DataFormatterSynthValueTestCase.test_wi

Re: [PATCH] D20053: [clang-tidy] Add misc-unnecessary-mutable check.

2016-05-14 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: test/clang-tidy/misc-unnecessary-mutable.cpp:237 @@ +236,3 @@ + +// Fails for now. +/* It would be good to put further information in about why this fails. http://reviews.llvm.org/D20053 ___

r269572 - Warn when a reference is bound to an empty l-value (dereferenced null pointer).

2016-05-14 Thread Nick Lewycky via cfe-commits
Author: nicholas Date: Sat May 14 12:44:14 2016 New Revision: 269572 URL: http://llvm.org/viewvc/llvm-project?rev=269572&view=rev Log: Warn when a reference is bound to an empty l-value (dereferenced null pointer). Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/l

Re: [PATCH] D19851: Warn on binding reference to null in copy initialization

2016-05-14 Thread Nick Lewycky via cfe-commits
nicholas closed this revision. nicholas added a comment. Closed by r269572. http://reviews.llvm.org/D19851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r269570 - [AVX512] Immediate for permd builtins should be an ICE.

2016-05-14 Thread Craig Topper via cfe-commits
Author: ctopper Date: Sat May 14 10:27:13 2016 New Revision: 269570 URL: http://llvm.org/viewvc/llvm-project?rev=269570&view=rev Log: [AVX512] Immediate for permd builtins should be an ICE. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def Modified: cfe/trunk/include/clang/Basic/Builti

Re: r269559 - ModuleMap.h: Fix a \param. [-Wdocumentation]

2016-05-14 Thread Alex Denisov via cfe-commits
> On 14 May 2016, at 14:37, NAKAMURA Takumi via cfe-commits > wrote: > > - /// \param Filename The umbreall header to collect. > + /// \param Header The umbreall header to collect. s/Umbreall/Umbrella/ signature.asc Description: Message signed with OpenPGP using GPGMail ___

r269560 - [mips] Enable IAS by default for 32-bit MIPS targets (O32).

2016-05-14 Thread Daniel Sanders via cfe-commits
Author: dsanders Date: Sat May 14 07:43:08 2016 New Revision: 269560 URL: http://llvm.org/viewvc/llvm-project?rev=269560&view=rev Log: [mips] Enable IAS by default for 32-bit MIPS targets (O32). Summary: The MIPS IAS can now pass 'ninja check-all', recurse, build a bootable linux kernel, and pass

r269559 - ModuleMap.h: Fix a \param. [-Wdocumentation]

2016-05-14 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Sat May 14 07:37:06 2016 New Revision: 269559 URL: http://llvm.org/viewvc/llvm-project?rev=269559&view=rev Log: ModuleMap.h: Fix a \param. [-Wdocumentation] Modified: cfe/trunk/include/clang/Lex/ModuleMap.h Modified: cfe/trunk/include/clang/Lex/ModuleMap.h URL: http://

r269557 - MSVCToolChain.cpp: Make version.dll generic for win32.

2016-05-14 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Sat May 14 03:12:37 2016 New Revision: 269557 URL: http://llvm.org/viewvc/llvm-project?rev=269557&view=rev Log: MSVCToolChain.cpp: Make version.dll generic for win32. We may consider msvc features may be capable on mingw host, if it can. Consider --host=mingw --target=msvc.

r269556 - MSVCToolChain.cpp: Use explicit constructor for SmallString from std::string, to appease mingw-g++.

2016-05-14 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Sat May 14 03:09:12 2016 New Revision: 269556 URL: http://llvm.org/viewvc/llvm-project?rev=269556&view=rev Log: MSVCToolChain.cpp: Use explicit constructor for SmallString from std::string, to appease mingw-g++. Modified: cfe/trunk/lib/Driver/MSVCToolChain.cpp Modified