Re: [PATCH] D20492: Clang support for __is_assignable intrinsic

EricWF added a subscriber: EricWF. EricWF added a comment. Should this have a test in `test/Lexer/has_feature_type_traits.cpp`? http://reviews.llvm.org/D20492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20500: [ms] Allow more unqualified lookup of types in dependent base classes

rsmith added inline comments. Comment at: lib/Parse/ParseDecl.cpp:2282 @@ -2281,3 +2281,3 @@ // Otherwise, if we don't consume this token, we are going to emit an // error anyway. Try to recover from various common problems. Check Maybe put the check

Re: [PATCH] D20498: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr

rsmith added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:5636-5639 @@ -5634,4 +5635,6 @@ - Expr *E = ExprWithCleanups::Create(Context, SubExpr, Cleanups); + auto *E = ExprWithCleanups::Create(Context, SubExpr, Cleanups); + if (Cleanup.cleanupsHaveSideEffects()) +

[clang-tools-extra] r270288 - Fix docs

Author: alexfh Date: Fri May 20 17:42:03 2016 New Revision: 270288 URL: http://llvm.org/viewvc/llvm-project?rev=270288=rev Log: Fix docs Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-avoid-bind.rst Modified:

Re: [PATCH] D19479: 26748 - clang-cl fails to compile atlctrlw.h header from WTL

rnk added a comment. In http://reviews.llvm.org/D19479#435620, @rnk wrote: > To deal with the specific case in ATL, we can use the 'new' expression as a > hint that the unknown identifier is actually a dependent type. There should > be some bit of context we can look at in

[PATCH] D20500: [ms] Allow more unqualified lookup of types in dependent base classes

rnk created this revision. rnk added reviewers: avt77, rsmith. rnk added a subscriber: cfe-commits. In dependent contexts where we know a type name is required, such as a new expression, we can recover by forming a DependentNameType. Works towards parsing atlctrlw.h, which is PR26748.

Re: [PATCH] D19930: [Lifetime] Add lifetime markers for C++ lifetime-extended temporaries

timshen abandoned this revision. timshen added a comment. Abandon this change, since http://reviews.llvm.org/D20498 and http://reviews.llvm.org/D20499 handle all temporaries. http://reviews.llvm.org/D19930 ___ cfe-commits mailing list

[PATCH] D20498: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr

timshen created this revision. timshen added a reviewer: rsmith. timshen added a subscriber: cfe-commits. Herald added a subscriber: klimek. These ExprWithCleanups are added for holding a RunCleanupsScope not for destructor calls; rather, they are for lifetime marks. This requires

Re: [PATCH] D20492: Clang support for __is_assignable intrinsic

DaveBartolomeo updated this revision to Diff 58014. DaveBartolomeo added a comment. Removed unnecessary braces. Moved BTT_IsAssignable case to a more clear location. http://reviews.llvm.org/D20492 Files: docs/LanguageExtensions.rst include/clang/Basic/TokenKinds.def

Re: [PATCH] D20457: Update -ffast-math documentation to match reality.

jlebar marked 2 inline comments as done. jlebar added a comment. Repository: rL LLVM http://reviews.llvm.org/D20457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20457: Update -ffast-math documentation to match reality.

jlebar added a comment. Thank you for the review! http://reviews.llvm.org/D20457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r270279 - Update -ffast-math documentation to match reality.

Author: jlebar Date: Fri May 20 16:33:01 2016 New Revision: 270279 URL: http://llvm.org/viewvc/llvm-project?rev=270279=rev Log: Update -ffast-math documentation to match reality. Reviewers: rsmith Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D20457 Modified:

Re: [PATCH] D20457: Update -ffast-math documentation to match reality.

This revision was automatically updated to reflect the committed changes. Closed by commit rL270279: Update -ffast-math documentation to match reality. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D20457?vs=57958=57995#toc Repository: rL LLVM

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

bruno added reviewers: dexonsmith, silvas. bruno removed subscribers: silvas, dexonsmith. bruno updated this revision to Diff 57993. bruno added a comment. Great idea Duncan, attached a new patch! http://reviews.llvm.org/D20404 Files: include/clang/Frontend/CompilerInvocation.h

Re: [PATCH] D20457: Update -ffast-math documentation to match reality.

rsmith accepted this revision. This revision is now accepted and ready to land. Comment at: docs/UsersManual.rst:1067 @@ +1066,3 @@ + ``(a + b) * c == a * c + b * c``), + * operands to fp operations are not equal to ``NaN`` and ``Inf``, and + * ``+0`` and ``-0`` are

Re: [PATCH] D20492: Clang support for __is_assignable intrinsic

majnemer added a subscriber: majnemer. Comment at: lib/Sema/SemaExprCXX.cpp:4523-4525 @@ -4521,1 +4522,5 @@ +if (BTT == BTT_IsAssignable) { + return true; +} + I'd remove the braces and sort it above the `BTT_IsNothrowAssignable` case.

[PATCH] D20493: [CUDA] Add -fcuda-approx-transcendentals flag.

jlebar created this revision. jlebar added a reviewer: rnk. jlebar added subscribers: cfe-commits, tra. This lets us emit e.g. sin.approx.f32. See http://docs.nvidia.com/cuda/parallel-thread-execution/#floating-point-instructions-sin http://reviews.llvm.org/D20493 Files:

[PATCH] D20492: Clang support for __is_assignable intrinsic

DaveBartolomeo created this revision. DaveBartolomeo added a reviewer: rnk. DaveBartolomeo added a subscriber: cfe-commits. MSVC now supports the __is_assignable type trait intrinsic, to enable easier and more efficient implementation of the Standard Library's is_assignable trait. As of Visual

Re: [PATCH] D20468: [X86][AVX] Ensure zero-extension of _mm256_extract_epi8 and _mm256_extract_epi16

mkuper accepted this revision. mkuper added a comment. This revision is now accepted and ready to land. Thanks, Dave! In that case, LGTM. Repository: rL LLVM http://reviews.llvm.org/D20468 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20468: [X86][AVX] Ensure zero-extension of _mm256_extract_epi8 and _mm256_extract_epi16

DavidKreitzer added a subscriber: DavidKreitzer. DavidKreitzer added a comment. Hi Michael, I think the Intel Intrinsics reference and the Intel Compiler are in error and that this is the right fix for the LLVM headers. (I'll follow up to get the Intel Intrinsics reference & Intel Compiler

[PATCH] D20490: [Parser] Fix a crash on invalid where a delayed TypoExpr was corrected twice

erik.pilkington created this revision. erik.pilkington added a reviewer: rsmith. erik.pilkington added a subscriber: cfe-commits. Previously, Clang crashed when parsing a `BinaryOperator` in C with a typo when a typo was already found. This is because the parser called `Sema::ActOnBinOp`, which

Re: [PATCH] D20113: Fix mangled name of method with ns_consumed parameters.

rjmccall added a comment. That looks great, thank you. http://reviews.llvm.org/D20113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3477 @@ -3473,1 +3476,3 @@ +InitExpr = +DBuilder.createConstantValueExpression(Init.getInt().getExtValue()); GV.reset(DBuilder.createGlobalVariable( pcc wrote: > aprantl wrote:

Re: [PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8

rjmccall added a comment. Top-level attributes shouldn't really be affecting the ABI or code-generation in any way, so desugaring should be fine. http://reviews.llvm.org/D20407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

pcc added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3477 @@ -3473,1 +3476,3 @@ +InitExpr = +DBuilder.createConstantValueExpression(Init.getInt().getExtValue()); GV.reset(DBuilder.createGlobalVariable( aprantl wrote: > pcc wrote: > >

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3477 @@ -3473,1 +3476,3 @@ +InitExpr = +DBuilder.createConstantValueExpression(Init.getInt().getExtValue()); GV.reset(DBuilder.createGlobalVariable( pcc wrote: > aprantl wrote:

Re: [PATCH] D20481: [CUDA] Define __USE_FAST_MATH__ when __FAST_MATH__ is defined.

jlebar abandoned this revision. jlebar added a comment. Actually, after talking offline with Chandler, I need something more complicated than this. I will send a new patch. Sorry for the noise. http://reviews.llvm.org/D20481 ___ cfe-commits

Re: [PATCH] D20407: [CodeGen][ObjC] zero-ext an i1 value to i8

ahatanak added a comment. I've managed to remove _Atomic from the types of the return and parameter of getter and setter functions in my new patch. I'm not sure how I should handle typedefs though. If I had the following typedef, typedef _Atomic(_Bool) AtomicBool, would it be OK to desugar

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

pcc added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3477 @@ -3473,1 +3476,3 @@ +InitExpr = +DBuilder.createConstantValueExpression(Init.getInt().getExtValue()); GV.reset(DBuilder.createGlobalVariable( aprantl wrote: > Are we

Re: [PATCH] D18138: Add -fnative-half-arguments-and-returns

pirama added inline comments. Comment at: cfe/trunk/lib/CodeGen/TargetInfo.cpp:5109 @@ -5108,3 +5108,3 @@ // natively, and does not need to interwork with AAPCS code. - if (Ty->isHalfType() && !getContext().getLangOpts().OpenCL) { + if (Ty->isHalfType() &&

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

Thanks Sam! @Jeroen, could you give us more details about your problem. Anastasia -Original Message- From: Liu, Yaxun (Sam) [mailto:yaxun@amd.com] Sent: 20 May 2016 20:52 To: Anastasia Stulova; Jeroen Ketema Cc: Clang Commits; nd Subject: RE: r269670 - [OpenCL] Add supported OpenCL

r270261 - [OpenCL] Add to_{global|local|private} builtin functions.

Author: yaxunl Date: Fri May 20 14:54:38 2016 New Revision: 270261 URL: http://llvm.org/viewvc/llvm-project?rev=270261=rev Log: [OpenCL] Add to_{global|local|private} builtin functions. OpenCL builtin functions to_{global|local|private} accepts argument of pointer type to arbitrary pointee

Re: [PATCH] D19932: [OpenCL] Add to_{global|local|private} builtin functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL270261: [OpenCL] Add to_{global|local|private} builtin functions. (authored by yaxunl). Changed prior to commit: http://reviews.llvm.org/D19932?vs=57478=57972#toc Repository: rL LLVM

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

I think this feature can be implemented by keeping a record of enabled OpenCL extensions by user's program. For optional core feature cl_khr_fp64, we just need to detect if double type is used by user's program. Sam -Original Message- From: Liu, Yaxun (Sam) Sent: Friday, May 20, 2016

RE: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

Currently Clang does not emit opencl.used.extensions metadata, so the issue mentioned does not exist. Also extensions supported by a target and extensions used by an OpenCL program is different concept. I'd say Clang currently miss a feature to detect used extensions and emit the metadata.

Re: [PATCH] D18138: Add -fnative-half-arguments-and-returns

Anastasia added a subscriber: Anastasia. Anastasia added a comment. Has this commit been merged without being approved by all the reviewers? Comment at: cfe/trunk/lib/CodeGen/TargetInfo.cpp:5109 @@ -5108,3 +5108,3 @@ // natively, and does not need to interwork with AAPCS

Re: r269670 - [OpenCL] Add supported OpenCL extensions to target info.

Hi Sam, Has this been addressed? @Jeroen, as far as I am aware adding supported extensions is completely new to Clang and shouldn't be braking any existing functionality that are related to that. Could you elaborate on the problem. Would creating new Clang target help? Otherwise, do you have

[PATCH] D20481: [CUDA] Define __USE_FAST_MATH__ when __FAST_MATH__ is defined.

jlebar created this revision. jlebar added a reviewer: rsmith. jlebar added a subscriber: cfe-commits. The CUDA headers look for __USE_FAST_MATH__. http://reviews.llvm.org/D20481 Files: lib/Headers/__clang_cuda_runtime_wrapper.h Index: lib/Headers/__clang_cuda_runtime_wrapper.h

RE: D20468: [X86][AVX] Ensure zero-extension of _mm256_extract_epi8 and _mm256_extract_epi16

Hi Simon, Thank you for the patch and for fixing the doxygen comments. There is no need to update Sony's intrinsics document. Very soon our documentation team is planning to release the documentation based on the doxygen headers in the upstream headers, so your change will funnel through

Re: [PATCH] D20457: Update -ffast-math documentation to match reality.

jlebar updated this revision to Diff 57958. jlebar added a comment. Update per Richard's review. http://reviews.llvm.org/D20457 Files: docs/UsersManual.rst include/clang/Basic/LangOptions.def include/clang/Driver/Options.td Index: include/clang/Driver/Options.td

r270241 - ObjectiveC: canonicalize "kindof id" to "id".

Author: mren Date: Fri May 20 12:29:43 2016 New Revision: 270241 URL: http://llvm.org/viewvc/llvm-project?rev=270241=rev Log: ObjectiveC: canonicalize "kindof id" to "id". There is no need to apply kindof on an unqualified id type. rdar://24753825 Modified: cfe/trunk/lib/Sema/SemaType.cpp

Re: [PATCH] D20037: Make __FreeBSD_cc_version predefined macro configurable at build time

This revision was automatically updated to reflect the committed changes. Closed by commit rL270240: Make __FreeBSD_cc_version predefined macro configurable at build time (authored by dim). Changed prior to commit: http://reviews.llvm.org/D20037?vs=56476=57952#toc Repository: rL LLVM

r270240 - Make __FreeBSD_cc_version predefined macro configurable at build time

Author: dim Date: Fri May 20 12:27:22 2016 New Revision: 270240 URL: http://llvm.org/viewvc/llvm-project?rev=270240=rev Log: Make __FreeBSD_cc_version predefined macro configurable at build time The `FreeBSDTargetInfo` class has always set the `__FreeBSD_cc_version` predefined macro to a rather

Re: [PATCH] D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type

This revision was automatically updated to reflect the committed changes. Closed by commit rL270238: [OpenCL] Allow explicit cast of 0 to event_t. (authored by yaxunl). Changed prior to commit: http://reviews.llvm.org/D17578?vs=56615=57951#toc Repository: rL LLVM

r270238 - [OpenCL] Allow explicit cast of 0 to event_t.

Author: yaxunl Date: Fri May 20 12:18:16 2016 New Revision: 270238 URL: http://llvm.org/viewvc/llvm-project?rev=270238=rev Log: [OpenCL] Allow explicit cast of 0 to event_t. Patch by Aaron Enye Shi. Differential Revision: http://reviews.llvm.org/D17578 Modified:

Re: [PATCH] D20467: [include-fixer] Mention more details in the document.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Could you please mention include-fixer in docs/ReleaseNotes.rst? This is definitely major new feature in upcoming release. http://reviews.llvm.org/D20467 ___

Re: [PATCH] D20468: [X86][AVX] Ensure zero-extension of _mm256_extract_epi8 and _mm256_extract_epi16

mkuper added a comment. You're right, the underlying instructions zext, and it seems like it's the right thing to do. I'm just wondering if this is something user code is supposed to rely on, given the way the intrinsics guide documents them right now. H.J, could you please take a look?

Re: [PATCH] D20422: [MSVC2015] dllexport for defaulted special class members

rnk added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:13111 @@ -13090,3 +13110,3 @@ llvm_unreachable("Invalid special member."); } } else { DmitryPolukhin wrote: > rnk wrote: > > Can we add `if (InClassDef)

Re: [PATCH] D20468: [X86][AVX] Ensure zero-extension of _mm256_extract_epi8 and _mm256_extract_epi16

RKSimon added a comment. In http://reviews.llvm.org/D20468#435522, @mkuper wrote: > Could you point me to where in the documentation it says they must be > zero-extended? > The Intel intrinsics guide actually has them with shorter return types: > > __int8 _mm256_extract_epi8 (__m256i a,

Re: [PATCH] D19479: 26748 - clang-cl fails to compile atlctrlw.h header from WTL

rnk added a comment. You've described the core issue with parsing C++ templates prior to instantiation, you have to know what identifiers are types, and that's why we need typename. :) MSVC only parses templates after instantiation, so it doesn't need typename. To deal with the specific case

Re: [clang-tools-extra] r261991 - [clang-tidy] Fix a crash issue when clang-tidy runs with compilation database.

Hi, This looks fine to me, go ahead and merge. -Tom On Thu, May 19, 2016 at 08:29:14PM +0200, Alexander Kornienko wrote: > On Thu, May 19, 2016 at 4:45 PM, Hans Wennborg wrote: > > > +Tom who manages 3.8.1 > > +Alex who's owner of clang-tidy: is this ok for 3.8.1? > > > >

Re: r270164 - Avoid depending on test inputes that aren't in Inputs

I'm not sure, but assume the Inputs directories could be sunk to a common parent (test/Inputs rather than test/CodeGen/Inputs, etc) On Thu, May 19, 2016 at 5:38 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Thu May 19 19:38:25 2016 > New Revision:

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3393 @@ +3392,3 @@ +DContext, FieldName, LinkageName, Unit, LineNo, FieldTy, +Var->hasInternalLinkage(), nullptr, nullptr); +Var->addDebugInfo(GV); aprantl wrote: > Is

Re: [PATCH] D20415: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3393 @@ +3392,3 @@ +DContext, FieldName, LinkageName, Unit, LineNo, FieldTy, +Var->hasInternalLinkage(), nullptr, nullptr); +Var->addDebugInfo(GV); Is there a good reason

r270227 - [X86][AVX] Added _mm256_testc_si256/_mm256_testnzc_si256/_mm256_testz_si256 tests

Author: rksimon Date: Fri May 20 10:49:17 2016 New Revision: 270227 URL: http://llvm.org/viewvc/llvm-project?rev=270227=rev Log: [X86][AVX] Added _mm256_testc_si256/_mm256_testnzc_si256/_mm256_testz_si256 tests Modified: cfe/trunk/test/CodeGen/avx-builtins.c Modified:

Re: [PATCH] D20454: Eliminate unnecessary file access checks in Clang driver on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL270226: Eliminate unnecessary file access checks in Clang driver on Windows (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D20454?vs=57872=57936#toc Repository: rL LLVM

r270226 - Eliminate unnecessary file access checks in Clang driver on Windows

Author: amccarth Date: Fri May 20 10:46:23 2016 New Revision: 270226 URL: http://llvm.org/viewvc/llvm-project?rev=270226=rev Log: Eliminate unnecessary file access checks in Clang driver on Windows Differential Revision: http://reviews.llvm.org/D20454 Modified:

r270224 - Add all the avx512 flavors to __builtin_cpu_supports's list.

Author: d0k Date: Fri May 20 10:21:08 2016 New Revision: 270224 URL: http://llvm.org/viewvc/llvm-project?rev=270224=rev Log: Add all the avx512 flavors to __builtin_cpu_supports's list. This is matching what trunk gcc is accepting. Also adds a missing ssse3 case. PR27779. The amount of

Re: [PATCH] D20468: [X86][AVX] Ensure zero-extension of _mm256_extract_epi8 and _mm256_extract_epi16

mkuper added a comment. Could you point me to where in the documentation it says they must be zero-extended? The Intel intrinsics guide actually has them with shorter return types: __int8 _mm256_extract_epi8 (__m256i a, const int index) __int16 _mm256_extract_epi16 (__m256i a, const int

[PATCH] D20468: [X86][AVX] Ensure zero-extension of _mm256_extract_epi8 and _mm256_extract_epi16

RKSimon created this revision. RKSimon added reviewers: mkuper, craig.topper, kromanova, spatel. RKSimon added a subscriber: cfe-commits. RKSimon set the repository for this revision to rL LLVM. Ensure _mm256_extract_epi8 and _mm256_extract_epi16 zero extend their i8/i16 result to i32. This

r270212 - [X86][AVX] Added _mm256_extract_epi64 test

Author: rksimon Date: Fri May 20 07:57:21 2016 New Revision: 270212 URL: http://llvm.org/viewvc/llvm-project?rev=270212=rev Log: [X86][AVX] Added _mm256_extract_epi64 test Modified: cfe/trunk/test/CodeGen/avx-builtins.c Modified: cfe/trunk/test/CodeGen/avx-builtins.c URL:

Re: [PATCH] D17416: [libcxx] Reorganize locale extension fallbacks. NFCI

bcraig closed this revision. bcraig added a comment. r270213 http://reviews.llvm.org/D17416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20467: [include-fixer] Mention more details in the document.

hokein created this revision. hokein added a reviewer: bkramer. hokein added subscribers: ioeric, cfe-commits. http://reviews.llvm.org/D20467 Files: docs/include-fixer.rst Index: docs/include-fixer.rst === ---

[libcxx] r270213 - Reorganize locale extension fallbacks. NFCI

Author: bcraig Date: Fri May 20 07:58:41 2016 New Revision: 270213 URL: http://llvm.org/viewvc/llvm-project?rev=270213=rev Log: Reorganize locale extension fallbacks. NFCI The various _l locale extension functions originate from very different places. Some come from POSIX, some are BSD

RE: r270047 - [Clang][AVX512][intrinsics] continue completing missing set intrinsics

No problem, I will look at it. Regards Michael Zuckerman -Original Message- From: steve...@apple.com [mailto:steve...@apple.com] Sent: Thursday, May 19, 2016 23:27 To: Zuckerman, Michael Cc: cfe-commits@lists.llvm.org Subject: Re: r270047 -

[clang-tools-extra] r270211 - [find-all-symbols] Some cleanups in unittest.

Author: hokein Date: Fri May 20 07:47:56 2016 New Revision: 270211 URL: http://llvm.org/viewvc/llvm-project?rev=270211=rev Log: [find-all-symbols] Some cleanups in unittest. Modified: clang-tools-extra/trunk/unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp Modified:

r270210 - [X86][AVX] Full set of AVX intrinsics tests

Author: rksimon Date: Fri May 20 07:41:02 2016 New Revision: 270210 URL: http://llvm.org/viewvc/llvm-project?rev=270210=rev Log: [X86][AVX] Full set of AVX intrinsics tests llvm/test/CodeGen/X86/avx-intrinsics-fast-isel.ll will be synced to this Modified:

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

courbet marked 10 inline comments as done. courbet added a comment. http://reviews.llvm.org/D19324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20446: clang-rename: fix renaming members when referenced as macro arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL270204: clang-rename: fix renaming members when referenced as macro arguments (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20446?vs=57921=57923#toc Repository: rL LLVM

[clang-tools-extra] r270204 - clang-rename: fix renaming members when referenced as macro arguments

Author: vmiklos Date: Fri May 20 06:43:59 2016 New Revision: 270204 URL: http://llvm.org/viewvc/llvm-project?rev=270204=rev Log: clang-rename: fix renaming members when referenced as macro arguments The second check failed, FOO(C.X) wasn't renamed to FOO(C.Y). Reviewers: klimek Differential

Re: [PATCH] D20446: clang-rename: fix renaming members when referenced as macro arguments

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D20446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r269907 - Add new intrinsic support for MONITORX and MWAITX instructions

Apologize for breaking the build bot. Thanks a lot Richard for taking care and fixing it. Regards, Ashutosh On Fri, May 20, 2016 at 6:43 AM, Richard Smith wrote: > Fixed in r270169. > > On Thu, May 19, 2016 at 2:13 PM, Richard Smith > wrote: >

Re: [PATCH] D19783: Fix cv-qualification of '*this' captures (and nasty bug PR27507 introduced by commit 263921 "Implement Lambda Capture of *this by Value as [=,*this]")

I'm also a huge advocate of simple composable interfaces that do the 'one' task that they are expected (i.e. named) to do - and do it well. I thought about this some, but perhaps not exhaustively - and settled on being ok with getCurThisType, always returning the correct type for 'this' as

Re: [PATCH] D20198: clang-format: [JS] sort ES6 imports.

This revision was automatically updated to reflect the committed changes. mprobst marked 2 inline comments as done. Closed by commit rL270203: clang-format: [JS] sort ES6 imports. (authored by mprobst). Changed prior to commit: http://reviews.llvm.org/D20198?vs=57795=57922#toc Repository:

r270203 - clang-format: [JS] sort ES6 imports.

Author: mprobst Date: Fri May 20 06:24:24 2016 New Revision: 270203 URL: http://llvm.org/viewvc/llvm-project?rev=270203=rev Log: clang-format: [JS] sort ES6 imports. Summary: This change automatically sorts ES6 imports and exports into four groups: absolute imports, parent imports, relative

[clang-tools-extra] r270202 - [find-all-symbols] fix failing unittest for Windows build bot.

Author: ioeric Date: Fri May 20 06:14:36 2016 New Revision: 270202 URL: http://llvm.org/viewvc/llvm-project?rev=270202=rev Log: [find-all-symbols] fix failing unittest for Windows build bot. Modified: clang-tools-extra/trunk/include-fixer/find-all-symbols/FindAllMacros.cpp Modified:

[clang-tools-extra] r270199 - [find-all-symbol] Try to fix the failure windows unittest.

Author: hokein Date: Fri May 20 05:36:53 2016 New Revision: 270199 URL: http://llvm.org/viewvc/llvm-project?rev=270199=rev Log: [find-all-symbol] Try to fix the failure windows unittest. Modified: clang-tools-extra/trunk/unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp

Re: [PATCH] D20446: clang-rename: fix renaming members when referenced as macro arguments

vmiklos updated this revision to Diff 57921. vmiklos added a comment. Done. http://reviews.llvm.org/D20446 Files: clang-rename/USRLocFinder.cpp test/clang-rename/MemberExprMacro.cpp Index: test/clang-rename/MemberExprMacro.cpp

Re: [PATCH] D19479: 26748 - clang-cl fails to compile atlctrlw.h header from WTL

avt77 added a comment. It seems I gave up with this issue :-( We have 2 possible situations here: 1. A type from instantiated type used inside the template (like in the test I'm working on) 2. A feature from instantiated type used inside the template (like below) struct A { int bar (); }

Re: [PATCH] D20446: clang-rename: fix renaming members when referenced as macro arguments

klimek added inline comments. Comment at: clang-rename/USRLocFinder.cpp:106-113 @@ -105,3 +105,10 @@ if (getUSRForDecl(Decl) == USR) { - LocationsFound.push_back(Expr->getMemberLoc()); + SourceLocation Location = Expr->getMemberLoc(); + if

Re: [PATCH] D20465: [find-all-symbol] Ignore inline namespace context.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D20465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20463: [clang-tidy] Add more descriptive comments and examples in misc-definitions-in-headers check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL270197: [clang-tidy] Add more descriptive comments and examples in misc-definitions… (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20463?vs=57917=57919#toc Repository: rL

[clang-tools-extra] r270197 - [clang-tidy] Add more descriptive comments and examples in misc-definitions-in-headers check.

Author: hokein Date: Fri May 20 04:38:25 2016 New Revision: 270197 URL: http://llvm.org/viewvc/llvm-project?rev=270197=rev Log: [clang-tidy] Add more descriptive comments and examples in misc-definitions-in-headers check. Reviewers: alexfh Subscribers: cfe-commits Differential Revision:

Re: [PATCH] D18575: [clang-tidy] New checker to replace deprecated throw() specifications

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Let's wait for http://reviews.llvm.org/D20428 http://reviews.llvm.org/D18575 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20463: [clang-tidy] Add more descriptive comments and examples in misc-definitions-in-headers check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! http://reviews.llvm.org/D20463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20465: [find-all-symbol] Ignore inline namespace context.

hokein created this revision. hokein added a reviewer: bkramer. hokein added subscribers: ioeric, cfe-commits. http://reviews.llvm.org/D20465 Files: include-fixer/find-all-symbols/FindAllSymbols.cpp unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp Index:

Re: [PATCH] D20196: [clang-tidy] Inefficient string operation

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/performance/InefficientStringAdditionCheck.cpp:28 @@ +27,3 @@ +: ClangTidyCheck(Name, Context), + IsStrictMode(Options.get("isStrictMode", 0)) {} +

Re: [PATCH] D20463: [clang-tidy] Add more descriptive comments and examples in misc-definitions-in-headers check.

hokein updated this revision to Diff 57917. hokein added a comment. fix a nit. http://reviews.llvm.org/D20463 Files: docs/clang-tidy/checks/misc-definitions-in-headers.rst Index: docs/clang-tidy/checks/misc-definitions-in-headers.rst

Re: [PATCH] D20463: [clang-tidy] Add more descriptive comments and examples in misc-definitions-in-headers check.

hokein updated this revision to Diff 57915. hokein marked 5 inline comments as done. hokein added a comment. Address review comments. http://reviews.llvm.org/D20463 Files: docs/clang-tidy/checks/misc-definitions-in-headers.rst Index: docs/clang-tidy/checks/misc-definitions-in-headers.rst

[clang-tools-extra] r270196 - [find-all-symbols] fixed FindAllMacros compilation error.

Author: ioeric Date: Fri May 20 04:23:19 2016 New Revision: 270196 URL: http://llvm.org/viewvc/llvm-project?rev=270196=rev Log: [find-all-symbols] fixed FindAllMacros compilation error. Modified: clang-tools-extra/trunk/include-fixer/find-all-symbols/tool/FindAllSymbolsMain.cpp Modified:

Re: [PATCH] D20287: [Coverage] Ensure that the hash for a used function is non-zero.

ikudrin abandoned this revision. ikudrin added a comment. This change is not needed anymore because the whole issue was fixed in http://reviews.llvm.org/D20286. http://reviews.llvm.org/D20287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20463: [clang-tidy] Add more descriptive comments and examples in misc-definitions-in-headers check.

alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: docs/clang-tidy/checks/misc-definitions-in-headers.rst:8 @@ +7,3 @@ +If these headers are included from multiple translation units, there will be +redefinition linker errors. +

[clang-tools-extra] r270193 - [find-all-symbols] make HeaderMapCollector optional in FindAllSymbols and FindAllMacros.

Author: ioeric Date: Fri May 20 04:12:01 2016 New Revision: 270193 URL: http://llvm.org/viewvc/llvm-project?rev=270193=rev Log: [find-all-symbols] make HeaderMapCollector optional in FindAllSymbols and FindAllMacros. Modified:

Re: [PATCH] D20429: [clang-tidy] Handle using-decls with more than one shadow decl.

hokein added inline comments. Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:59 @@ -59,1 +58,3 @@ /*SkipTrailingWhitespaceAndNewLine=*/true)); +for (const auto It : Using->shadows()) { + const auto *TargetDecl =

[PATCH] D20463: [clang-tidy] Add more descriptive comments and examples in misc-definitions-in-headers check.

hokein created this revision. hokein added a reviewer: alexfh. hokein added a subscriber: cfe-commits. http://reviews.llvm.org/D20463 Files: docs/clang-tidy/checks/misc-definitions-in-headers.rst Index: docs/clang-tidy/checks/misc-definitions-in-headers.rst

Re: [PATCH] D20429: [clang-tidy] Handle using-decls with more than one shadow decl.

alexfh added inline comments. Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:59 @@ -59,1 +58,3 @@ /*SkipTrailingWhitespaceAndNewLine=*/true)); +for (const auto It : Using->shadows()) { + const auto *TargetDecl =

Re: [PATCH] D20437: [MSVC] Support of __unaligned qualifier for function types

andreybokhanko updated this revision to Diff 57907. andreybokhanko added a comment. Added a test for __unaligned arrays. http://reviews.llvm.org/D20437 Files: include/clang/AST/Type.h include/clang/Sema/DeclSpec.h lib/AST/DeclCXX.cpp lib/AST/MicrosoftMangle.cpp lib/Sema/DeclSpec.cpp

Re: [PATCH] D20429: [clang-tidy] Handle using-decls with more than one shadow decl.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rL270191: [clang-tidy] Handle using-decls with more than one shadow decl. (authored by hokein). Changed prior to commit:

[clang-tools-extra] r270191 - [clang-tidy] Handle using-decls with more than one shadow decl.

Author: hokein Date: Fri May 20 03:34:32 2016 New Revision: 270191 URL: http://llvm.org/viewvc/llvm-project?rev=270191=rev Log: [clang-tidy] Handle using-decls with more than one shadow decl. Reviewers: alexfh Subscribers: cfe-commits, djasper Differential Revision:

Re: [PATCH] D20429: [clang-tidy] Handle using-decls with more than one shadow decl.

hokein marked 2 inline comments as done. Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:59 @@ -59,1 +58,3 @@ /*SkipTrailingWhitespaceAndNewLine=*/true)); +for (const auto It : Using->shadows()) { + const auto *TargetDecl =

  1   2   >