rmaprath added a subscriber: rmaprath.
rmaprath accepted this revision.
rmaprath added a reviewer: rmaprath.
rmaprath added a comment.
This revision is now accepted and ready to land.
That looks fine to me.
http://reviews.llvm.org/D21673
___
cfe-com
Author: majnemer
Date: Fri Jun 24 00:48:59 2016
New Revision: 273651
URL: http://llvm.org/viewvc/llvm-project?rev=273651&view=rev
Log:
try to fix the MSVC build
Modified:
cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
Modified: cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
URL:
http:
pgode added a comment.
Ping ?
http://reviews.llvm.org/D21501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: majnemer
Date: Fri Jun 24 00:33:44 2016
New Revision: 273650
URL: http://llvm.org/viewvc/llvm-project?rev=273650&view=rev
Log:
Use even more ArrayRefs
No functional change is intended, just a small refactoring.
Modified:
cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
cfe/trunk
rtrieu created this revision.
rtrieu added a subscriber: cfe-commits.
Early prototype of an improved ODR checker for Clang and modules. The current
ODR checking of classes is limited to a small number of attributes such as
number of methods and base classes. This still allows a number of ODR
On Thu, Jun 23, 2016 at 12:26 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Thu, Jun 23, 2016 at 3:16 PM, Richard Smith via cfe-commits
> wrote:
> > Author: rsmith
> > Date: Thu Jun 23 14:16:49 2016
> > New Revision: 273602
> >
> > URL: http://llvm.org/viewvc/llvm-pr
Author: majnemer
Date: Thu Jun 23 23:05:35 2016
New Revision: 273646
URL: http://llvm.org/viewvc/llvm-project?rev=273646&view=rev
Log:
Use the same underlying type for bitfields
MSVC allocates fresh storage for consecutive bitfields with different
underlying types.
Modified:
cfe/trunk/includ
Author: majnemer
Date: Thu Jun 23 23:05:48 2016
New Revision: 273647
URL: http://llvm.org/viewvc/llvm-project?rev=273647&view=rev
Log:
Use more ArrayRefs
No functional change is intended, just a small refactoring.
Modified:
cfe/trunk/include/clang/AST/Decl.h
cfe/trunk/include/clang/AST/D
weimingz created this revision.
weimingz added a subscriber: cfe-commits.
this fixes build error when built with c++14 and no exceptions
http://reviews.llvm.org/D21673
Files:
include/experimental/optional
Index: include/experimental/optional
===
2016-06-22 16:55 GMT+08:00 Peter Smith :
> Hello Lei,
>
> Thanks for all the updates. That looks good to me from an ARM perspective.
Ping.
Are the patches good enough to be committed?
Lei
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
ABataev added a comment.
LG
Comment at: lib/Sema/SemaOpenMP.cpp:1826-1827
@@ +1825,4 @@
+std::make_pair(".bound_tid.", KmpInt32PtrTy),
+std::make_pair(".previous.lb.", KmpUInt64Ty),
+std::make_pair(".previous.ub.", KmpUInt64Ty),
+std::make_pair(St
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D21564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Hello everyone,
Below are some buildbot numbers for the last week of 6/12/2016 - 6/18/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from
dcoughlin created this revision.
dcoughlin added reviewers: zaks.anna, rsmith.
dcoughlin added a subscriber: cfe-commits.
This proposed patch adds crude handling of atomics to the static analyzer.
Rather than ignore AtomicExprs, as we now do, this patch causes the analyzer
to escape the arguments.
ahatanak updated this revision to Diff 61743.
ahatanak added a comment.
Address review comments and change the wording in AttrDocs.td to explain what
the attribute means and how it is used. Also, fixed the code in VisitMemberExpr
to set LValue::OverAllocated before the base class of the member e
sivachandra created this revision.
sivachandra added reviewers: rnk, saugustine.
sivachandra added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
http://reviews.llvm.org/D21666
Files:
include/clang/AST/NestedNameSpecifier.h
include/clang/Tooling/Core/QualTypeNames.h
lib/AST/N
Author: chapuni
Date: Thu Jun 23 17:47:59 2016
New Revision: 273624
URL: http://llvm.org/viewvc/llvm-project?rev=273624&view=rev
Log:
Parser::ParseCXXCondition(): Prune \param in r273548 [-Wdocumentation]
Modified:
cfe/trunk/lib/Parse/ParseExprCXX.cpp
Modified: cfe/trunk/lib/Parse/ParseExprC
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273619: clang-format: [JS] handle conditionals in fields,
default params. (authored by mprobst).
Changed prior to commit:
http://reviews.llvm.org/D21658?vs=61726&id=61729#toc
Repository:
rL LLVM
htt
Author: mprobst
Date: Thu Jun 23 16:51:49 2016
New Revision: 273619
URL: http://llvm.org/viewvc/llvm-project?rev=273619&view=rev
Log:
clang-format: [JS] handle conditionals in fields, default params.
Summary:
Reviewers: djasper
Subscribers: klimek, cfe-commits
Differential Revision: http://rev
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good except that the patch description can now be updated.
http://reviews.llvm.org/D21658
___
cfe-commits mailing list
cfe-commits@lists.
mprobst updated this revision to Diff 61726.
mprobst added a comment.
ok
http://reviews.llvm.org/D21658
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
===
--- un
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:1001
@@ -1000,3 +1000,3 @@
if (Style.Language == FormatStyle::LK_JavaScript &&
- Line.MustBeDeclaration) {
+ !Contexts.back().IsExpression) {
// In JavaScript, `interface X {
arsenm created this revision.
arsenm added a subscriber: cfe-commits.
Herald added a reviewer: tstellarAMD.
Herald added a subscriber: kzhuravl.
http://reviews.llvm.org/D21659
Files:
include/clang/Basic/BuiltinsAMDGPU.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGenOpenCL/builtins-amdgcn.cl
Inde
mprobst created this revision.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This causes a regression for top level ternary expressions, but that's deemed
acceptable, as those really should be very rare.
http://reviews.llvm.org/D216
Author: dehao
Date: Thu Jun 23 15:13:10 2016
New Revision: 273606
URL: http://llvm.org/viewvc/llvm-project?rev=273606&view=rev
Log:
Invoke simplifycfg and sroa before instcombine.
Summary: InstCombine needs to be performed after simplifycfg and sroa,
otherwise it may make bad optimization decisi
yaxunl added inline comments.
Comment at: include/clang/AST/BuiltinTypes.def:164
@@ +163,3 @@
+// Internal OpenCL sampler initializer type.
+BUILTIN_TYPE(OCLSamplerInit, OCLSamplerInitTy)
+
Anastasia wrote:
> I can't get why is this necessary to represent initiali
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273603: clang-format: [JS] recognize more type locations.
(authored by mprobst).
Changed prior to commit:
http://reviews.llvm.org/D21597?vs=61706&id=61711#toc
Repository:
rL LLVM
http://reviews.llvm
Author: mprobst
Date: Thu Jun 23 14:52:32 2016
New Revision: 273603
URL: http://llvm.org/viewvc/llvm-project?rev=273603&view=rev
Log:
clang-format: [JS] recognize more type locations.
Summary: Includes parenthesized type expressions and type aliases.
Reviewers: djasper
Subscribers: klimek, cfe-
On Thu, Jun 23, 2016 at 3:16 PM, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Thu Jun 23 14:16:49 2016
> New Revision: 273602
>
> URL: http://llvm.org/viewvc/llvm-project?rev=273602&view=rev
> Log:
> Implement p0292r2 (constexpr if), a likely C++1z feature.
Is there a feature tes
Author: rsmith
Date: Thu Jun 23 14:16:49 2016
New Revision: 273602
URL: http://llvm.org/viewvc/llvm-project?rev=273602&view=rev
Log:
Implement p0292r2 (constexpr if), a likely C++1z feature.
Added:
cfe/trunk/test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.spec.auto/p2-1z.cpp
cfe/trunk/test/CXX/stm
aaron.ballman closed this revision.
aaron.ballman added a comment.
Commit in r273599.
http://reviews.llvm.org/D21643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Thu Jun 23 14:02:52 2016
New Revision: 273600
URL: http://llvm.org/viewvc/llvm-project?rev=273600&view=rev
Log:
Re-commit r273548, reverted in r273589, with a fix to not produce
-Wfor-loop-analysis warnings for a for-loop with a condition variable. In such
a case, the loop con
jvesely added a comment.
In http://reviews.llvm.org/D19932#465807, @yaxunl wrote:
> > this is not true. as I pointed out earlier, take a look at libclc headers.
> > a lot functions are defined for multiple types while maintaining type
> > safety.
>
> > there is no problem having TYPE * to_glob
yaxunl added a comment.
> this is not true. as I pointed out earlier, take a look at libclc headers. a
> lot functions are defined for multiple types while maintaining type safety.
> there is no problem having TYPE * to_global(TYPE *), for every permissible
> CLC type, declared in headers with
mprobst updated this revision to Diff 61706.
mprobst marked an inline comment as done.
mprobst added a comment.
- progress
http://reviews.llvm.org/D21597
Files:
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.c
jvesely added a comment.
In http://reviews.llvm.org/D19932#465784, @yaxunl wrote:
> In http://reviews.llvm.org/D19932#465781, @jvesely wrote:
>
> > In http://reviews.llvm.org/D19932#465763, @cfe-commits wrote:
> >
> > > The returned pointer should point to the same pointee type as the
> > > argu
mprobst marked 2 inline comments as done.
Comment at: lib/Format/TokenAnnotator.cpp:155
@@ +154,3 @@
+} else if (Style.Language == FormatStyle::LK_JavaScript && Left->Previous
&&
+ Left->Previous->is(TT_JsTypeColon)) {
+ // let x: (SomeType);
--
yaxunl added a comment.
In http://reviews.llvm.org/D19932#465781, @jvesely wrote:
> In http://reviews.llvm.org/D19932#465763, @cfe-commits wrote:
>
> > The returned pointer should point to the same pointee type as the argument.
> > Header file cannot guarantee that.
> >
> > Sam
>
>
> how come? i
jvesely added a comment.
In http://reviews.llvm.org/D19932#465763, @cfe-commits wrote:
> The returned pointer should point to the same pointee type as the argument.
> Header file cannot guarantee that.
>
> Sam
how come? is there a possibility to have two different types using the same
name?
Author: pcc
Date: Thu Jun 23 13:11:15 2016
New Revision: 273589
URL: http://llvm.org/viewvc/llvm-project?rev=273589&view=rev
Log:
Revert r273548, "Rearrange condition handling so that semantic checks on a
condition variable"
as it caused a regression in -Wfor-loop-analysis.
Modified:
cfe/tru
Author: pcc
Date: Thu Jun 23 13:11:19 2016
New Revision: 273590
URL: http://llvm.org/viewvc/llvm-project?rev=273590&view=rev
Log:
Add a test case for the regression in -Wfor-loop-analysis caused by r273548.
Modified:
cfe/trunk/test/SemaCXX/warn-loop-analysis.cpp
Modified: cfe/trunk/test/Sema
The returned pointer should point to the same pointee type as the argument.
Header file cannot guarantee that.
Sam
-Original Message-
From: Jan Vesely [mailto:jan.ves...@rutgers.edu]
Sent: Wednesday, June 22, 2016 10:20 PM
To: Liu, Yaxun (Sam) ; xiuli...@outlook.com;
anastasia.stul...@
sanjoy added a comment.
One other thing to point out -- have you verified that the changes in
`unittests/` are benign (i.e. you're not semantically changing the tests)?
Repository:
rL LLVM
http://reviews.llvm.org/D21507
___
cfe-commits mailing l
Hi,
I won't have access to the system for ~2 weeks but the change looks
fine. Please commit if it passes the test on Linux with that.
Regards,
ismail
On Thu, Jun 23, 2016 at 4:39 PM, Liu, Yaxun (Sam) wrote:
> I have a patch which may workaround this issue, however I could not test it
> in Cyg
erik.pilkington created this revision.
erik.pilkington added reviewers: rsmith, faisalv.
erik.pilkington added a subscriber: cfe-commits.
Previously, Clang would incorrectly accept the following:
```
template struct A {};
struct B : A<0>, A<1> {};
template int f(A);
int main() { f(B()); }
```
The
ikudrin added a comment.
Ping...
This patch is under review for more than two months, and I believe I've
addressed all the comments. Could someone take a look at it, please?
http://reviews.llvm.org/D17815
___
cfe-commits mailing list
cfe-commits@l
carlo.bertolli added a comment.
Thanks for these further comments. I have just updated the diff applying the
suggestions.
Repository:
rL LLVM
http://reviews.llvm.org/D21564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
bcraig closed this revision.
bcraig added a comment.
Old: 106,657,666
New: 105,346,818
Submitted in r273572
http://reviews.llvm.org/D21229
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: bcraig
Date: Thu Jun 23 10:47:12 2016
New Revision: 273572
URL: http://llvm.org/viewvc/llvm-project?rev=273572&view=rev
Log:
[Analyzer] Don't cache report generation ExplodedNodes
During the core analysis, ExplodedNodes are added to the
ExplodedGraph, and those nodes are cached for dedupl
aaron.ballman added a comment.
In http://reviews.llvm.org/D21643#465583, @llvm-commits wrote:
> Should we add overloads of the UTF8 conversion functions that accept
> wstrings?
I think we should eventually consider cleaning up our Unicode APIs because
they're kind of all over the place. For i
rnk added a comment.
In http://reviews.llvm.org/D21643#465584, @aaron.ballman wrote:
> I have never successfully built compiler-rt with MSVC. Every time I've tried
> (the last time was 6+ months ago, so I will try again), the MSVC solution
> generated by CMake refuses to compile. From what I un
aaron.ballman added a comment.
In http://reviews.llvm.org/D21643#465579, @rnk wrote:
> Sure, this serves as a reminder that you should always convert from UTF-8 to
> wide in Windows support code. I still think we should always explicitly call
> the wide variants, and it seems like you agree. De
Should we add overloads of the UTF8 conversion functions that accept
wstrings?
In line with what rnk said, I'm curious about the implications of simply
#undef'ing all the non A/W versions of functions so that you have to make
the choice explicit
On Thu, Jun 23, 2016 at 8:20 AM Reid Kleckner wrote
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Sure, this serves as a reminder that you should always convert from UTF-8 to
wide in Windows support code. I still think we should always explicitly call
the wide variants, and it seems like you agr
Author: rafael
Date: Thu Jun 23 10:07:32 2016
New Revision: 273566
URL: http://llvm.org/viewvc/llvm-project?rev=273566&view=rev
Log:
Restructure the propagation of -fPIC/-fPIE.
The PIC and PIE levels are not independent. In fact, if PIE is defined
it is always the same as PIC.
This is clear in t
aaron.ballman created this revision.
aaron.ballman added reviewers: rnk, majnemer, chapuni, zturner.
aaron.ballman added subscribers: llvm-commits, cfe-commits.
We currently default to using the multibyte character versions of Win32 APIs,
commonly suffixed with an "A". However, this causes proble
vsk added a comment.
In http://reviews.llvm.org/D21507#465444, @Prazek wrote:
> In http://reviews.llvm.org/D21507#464791, @vsk wrote:
>
> > Neat! It would help to upload a git-clang-format'd. Fwiw I only managed to
> > look over the changes in lib/{ARCMigrate,AST,Analysis}.
> >
> > Have you run
craig.topper added a subscriber: craig.topper.
Comment at: tools/clang/test/CodeGen/sse2-builtins.c:1526
@@ +1525,3 @@
+ // CHECK-LABEL: test_mm_loadu_si64
+ // CHECK: load i64, i64* %{{.*}}, align 1
+ // CHECK: insertelement <2 x i64> undef, i64 %{{.*}}, i32 0
Author: aaronballman
Date: Thu Jun 23 09:33:53 2016
New Revision: 273563
URL: http://llvm.org/viewvc/llvm-project?rev=273563&view=rev
Log:
Fixing a FIXME related to Unicode support on Windows. Converted the Win32 APIs
to explicitly use the W version when it involves strings that can hold
non-ASC
On Thu, Jun 23, 2016 at 02:27:12PM +, Ben Craig via cfe-commits wrote:
> bcraig added subscribers: joerg, bcraig.
> bcraig added a comment.
>
> @joerg. I think this has been fixed in newer versions of NetBSD.
>
> Sure would be nice if someone could fix this on the MUSL side of things.
>
> S
bcraig added subscribers: joerg, bcraig.
bcraig added a comment.
@joerg. I think this has been fixed in newer versions of NetBSD.
Sure would be nice if someone could fix this on the MUSL side of things.
See https://bugs.musicpd.org/view.php?id=4110 for fun conversations about
mutex, PTHREAD_MU
klimek added inline comments.
Comment at: lib/Format/Format.cpp:1395
@@ -1394,2 +1394,3 @@
+// If any replacements in \p Replaces fails to apply, this returns \p Replaces.
template
ioeric wrote:
> klimek wrote:
> > Why would we want to return the same replacem
Anastasia added inline comments.
Comment at: include/clang/AST/BuiltinTypes.def:164
@@ +163,3 @@
+// Internal OpenCL sampler initializer type.
+BUILTIN_TYPE(OCLSamplerInit, OCLSamplerInitTy)
+
I can't get why is this necessary to represent initializer as a special
john.brawn added a comment.
Ping.
Repository:
rL LLVM
http://reviews.llvm.org/D21385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added inline comments.
Comment at: lib/Format/Format.cpp:1395
@@ -1394,2 +1394,3 @@
+// If any replacements in \p Replaces fails to apply, this returns \p Replaces.
template
klimek wrote:
> Why would we want to return the same replacements?
this is just
Author: compnerd
Date: Thu Jun 23 08:45:33 2016
New Revision: 273558
URL: http://llvm.org/viewvc/llvm-project?rev=273558&view=rev
Log:
CodeGen: support linker options on Windows ARM
We would incorrectly emit the directive sections due to the missing overridden
methods. We now emit the expected "
john.brawn accepted this revision.
john.brawn added a comment.
Looks OK from the ARM side as well.
http://reviews.llvm.org/D21611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I have a patch which may workaround this issue, however I could not test it in
Cygwin since I got issues build latest cmake in Cygwin and the downloaded cmake
does not work.
Could you please try it?
Thanks.
Sam
-Original Message-
From: Ismail Donmez [mailto:ism...@i10z.com]
Sent: Wed
dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.
In that case the MIPS side of this LGTM. Someone more familiar with ARM should
approve it for ARM.
http://reviews.llvm.org/D21611
___
cfe-co
DmitryPolukhin updated the summary for this revision.
DmitryPolukhin updated this revision to Diff 61642.
DmitryPolukhin added a comment.
Fixed issue with substitution from function name used in bare type encoding and
added test. With this patch Clang passes self build with GCC 5.3.1 headers and
Pajesz updated this revision to Diff 61651.
Pajesz added a comment.
Checker now works with for and while statements as well, new tests were added,
other syntactical and logical updates have been made.
http://reviews.llvm.org/D19586
Files:
clang-tidy/readability/MisleadingIndentationCheck.h
spetrovic added a comment.
Yes, I tried all caller - callee combinations for ARM32 big endian and
MIPS/MIPS64 big endian, and it works properly with this patch.
http://reviews.llvm.org/D21611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
elram created this revision.
elram added a reviewer: EricWF.
elram added a subscriber: cfe-commits.
Some pthread implementations use volatile types in their structs.
C++11 does not allow initializing volatile types in constexpr constructors.
This fixes building libcxx on musl-libc and NetBSD.
h
klimek added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:170
@@ +169,3 @@
+/// This completely ignores the path stored in each replacement. If all
+/// replacements are applied successfully, this returns the result code;
+/// otherwise, an llvm::Error car
Prazek updated this revision to Diff 61665.
Prazek added a comment.
- small fix
http://reviews.llvm.org/D21642
Files:
clang-tidy/boost/UseToStringCheck.cpp
test/clang-tidy/boost-use-to-string.cpp
Index: test/clang-tidy/boost-use-to-string.cpp
===
bader added a comment.
Hi Anastasia,
Sorry for the delay.
I have just a few comments.
Thanks,
Alexey
Comment at: lib/Sema/SemaChecking.cpp:95
@@ +94,3 @@
+ IllegalParams = true;
+ break;
+}
It looks like this function will report only first inval
Prazek created this revision.
Prazek added reviewers: alexfh, sbenza, hokein.
Prazek added a subscriber: cfe-commits.
getExprLoc returns location after dot for member call.
http://reviews.llvm.org/D21642
Files:
clang-tidy/boost/UseToStringCheck.cpp
test/clang-tidy/boost-use-to-string.cpp
In
aturetsk added a comment.
Hi Bruno,
As you suggested I changed -miamcu/-mno-iamcu handling code to use hasFlag.
http://reviews.llvm.org/D21641
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
aturetsk created this revision.
aturetsk added a reviewer: bruno.
aturetsk added a subscriber: cfe-commits.
Use ArgList::hasFlag to check if -miamcu/-mno-iamcu is passed. NFC.
http://reviews.llvm.org/D21641
Files:
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
==
AsafBadouh updated this revision to Diff 61661.
AsafBadouh added a comment.
add align to CHECK
Repository:
rL LLVM
http://reviews.llvm.org/D21504
Files:
tools/clang/lib/Headers/emmintrin.h
tools/clang/test/CodeGen/sse2-builtins.c
Index: tools/clang/lib/Headers/emmintrin.h
==
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
http://reviews.llvm.org/D21031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
dsanders added a comment.
This change agrees with what I think the calling convention is and the
documentation. However, I've hit quite a few discrepancies between the
documented calling convention and the de-facto one implemented by gcc so I'm
wary of going by that alone.
Have you tried putti
Prazek added a comment.
In http://reviews.llvm.org/D21507#464791, @vsk wrote:
> Neat! It would help to upload a git-clang-format'd. Fwiw I only managed to
> look over the changes in lib/{ARCMigrate,AST,Analysis}.
>
> Have you run check-all and the full test-suite?
Yep, didn't have any problems
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Basically looks good.
Comment at: lib/Format/TokenAnnotator.cpp:155
@@ +154,3 @@
+} else if (Style.Language == FormatStyle::LK_JavaScript && Left->Previous
&&
+
Author: djasper
Date: Thu Jun 23 04:40:19 2016
New Revision: 273553
URL: http://llvm.org/viewvc/llvm-project?rev=273553&view=rev
Log:
clang-format: [Proto] Use more compact format for text-formatted options
Before:
enum Type {
UNKNOWN = 0 [(some_options) = {
a: aa,
b: bb
}];
Author: dsanders
Date: Thu Jun 23 04:29:38 2016
New Revision: 273552
URL: http://llvm.org/viewvc/llvm-project?rev=273552&view=rev
Log:
Attempt to fix MIPS buildbots after r273425.
MIPS has a 'signext' attribute that was causing the check to fail.
Modified:
cfe/trunk/test/CodeGenOpenCL/kernel
Author: rsmith
Date: Thu Jun 23 03:41:20 2016
New Revision: 273548
URL: http://llvm.org/viewvc/llvm-project?rev=273548&view=rev
Log:
Rearrange condition handling so that semantic checks on a condition variable
are performed before the other substatements of the construct are parsed,
rather than de
87 matches
Mail list logo