Trivial comment updates: include/clang/Lex/PPCallbacks.h, docs/pp-trace.rst (clang-tools-extra)

2016-07-03 Thread via cfe-commits
Delete "param MD The MacroDefinition if the name was a macro, null otherwise.". Reason: MD, a reference, can't be null. Index: include/clang/Lex/PPCallbacks.h === --- include/clang/Lex/PPCallbacks.h (revision 274481) +++ includ

r274477 - [Sema] A flexible array member must not be the only named member

2016-07-03 Thread David Majnemer via cfe-commits
Author: majnemer Date: Sun Jul 3 19:24:59 2016 New Revision: 274477 URL: http://llvm.org/viewvc/llvm-project?rev=274477&view=rev Log: [Sema] A flexible array member must not be the only named member We didn't correctly detect situations where a flexible array member was the only named member in

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

2016-07-03 Thread Alexander Droste via cfe-commits
Alexander_Droste updated this revision to Diff 62640. Alexander_Droste added a comment. - fix comments http://reviews.llvm.org/D21962 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/MpiTypeMismatchCheck.cpp clang-tidy/misc/MpiTypeMismatchCheck.h

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

2016-07-03 Thread Alexander Droste via cfe-commits
Alexander_Droste updated this revision to Diff 62639. Alexander_Droste added a comment. - fix some comments http://reviews.llvm.org/D21962 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/MpiTypeMismatchCheck.cpp clang-tidy/misc/MpiTypeMismatchChe

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

2016-07-03 Thread Alexander Droste via cfe-commits
Alexander_Droste updated this revision to Diff 62638. Alexander_Droste added a comment. - change comment style to LLVM style - remove 'misc-m-p-i-type-mismatch' entry from `list.rst` (misc-mpi-type-mismatch is the correct one) http://reviews.llvm.org/D21962 Files: clang-tidy/misc/CMakeLists.

r274475 - [AST] Use ArrayRef in more interfaces

2016-07-03 Thread David Majnemer via cfe-commits
Author: majnemer Date: Sun Jul 3 16:17:51 2016 New Revision: 274475 URL: http://llvm.org/viewvc/llvm-project?rev=274475&view=rev Log: [AST] Use ArrayRef in more interfaces ArrayRef is a little better than passing around a pointer/length pair. No functional change is intended. Modified: cfe

Re: [PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

2016-07-03 Thread Alexander Droste via cfe-commits
Alexander_Droste added a comment. Hi Alexander, this is the check that verifies buffer type / MPI datatype inconsistencies that was originally part of http://reviews.llvm.org/D12761. Comment at: docs/clang-tidy/checks/list.rst:63 @@ -62,2 +62,3 @@ misc-inefficient-algorithm

[PATCH] D21962: MPITypeMismatchCheck for Clang-Tidy

2016-07-03 Thread Alexander Droste via cfe-commits
Alexander_Droste created this revision. Alexander_Droste added a reviewer: alexfh. Alexander_Droste added a subscriber: cfe-commits. This check verifies if buffer type and MPI (Message Passing Interface) datatype pairs match. All MPI datatypes defined by the MPI standard (3.1) are verified by this

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

2016-07-03 Thread Sean Silva via cfe-commits
On Sat, Jul 2, 2016 at 7:38 PM, Xinliang David Li wrote: > Sanitizers are different IMO. Different santizers are rather independent, > and there is no such thing as -fsantize to mean -fsantize=all > > For PGO, in most of the cases, users do not need to care about the > sub-options implied -- by d

[PATCH] D21959: [X86] Add xgetbv xsetbv intrinsics

2016-07-03 Thread Guy Blank via cfe-commits
guyblank created this revision. guyblank added reviewers: aaboud, delena, craig.topper, AsafBadouh, m_zuckerman, igorb. guyblank added a subscriber: cfe-commits. [X86] Add xgetbv xsetbv intrinsics http://reviews.llvm.org/D21959 Files: include/clang/Basic/BuiltinsX86.def lib/CodeGen/CGBuilt

Re: r274110 - [AVX512] Zero extend cmp intrinsic return value.

2016-07-03 Thread Craig Topper via cfe-commits
Also should we change the AutoUpgrade code for the cmp intrinsics in the backend to also use zero instead of undef? ~Craig On Sun, Jul 3, 2016 at 12:11 AM, Breger, Igor wrote: > Hello Craig, > > Thanks a lot for pointing it out to me. I familiar with this problem, we > are planning to improv

RE: r274110 - [AVX512] Zero extend cmp intrinsic return value.

2016-07-03 Thread Breger, Igor via cfe-commits
Hello Craig, Thanks a lot for pointing it out to me. I familiar with this problem, we are planning to improve CodeGen to handle with this case in near future. Regards, Igor From: Craig Topper [mailto:craig.top...@gmail.com] Sent: Saturday, July 02, 2016 08:46 To: Breger, Igor; Eric Christophe