Author: majnemer
Date: Sat Jul 16 19:39:12 2016
New Revision: 275699
URL: http://llvm.org/viewvc/llvm-project?rev=275699&view=rev
Log:
[CodeGen] Some assorted cleanups
No functional change, just some cleanups:
- Use auto when it is appropriate.
- There were some strange static_casts which were su
Prazek removed rL LLVM as the repository for this revision.
Prazek updated this revision to Diff 64238.
Prazek marked 6 inline comments as done.
https://reviews.llvm.org/D22208
Files:
clang-tidy/modernize/UseEmplaceCheck.cpp
clang-tidy/modernize/UseEmplaceCheck.h
clang-tidy/utils/Matchers.h
Author: compnerd
Date: Sat Jul 16 17:42:06 2016
New Revision: 275697
URL: http://llvm.org/viewvc/llvm-project?rev=275697&view=rev
Log:
CodeGen: use StringRefs more in ObjC class generation, NFC
Rather than building up a number of SmallString-s in order to construct a
std::string, use more StringR
Author: compnerd
Date: Sat Jul 16 17:42:04 2016
New Revision: 275696
URL: http://llvm.org/viewvc/llvm-project?rev=275696&view=rev
Log:
CodeGen: simplify using a local variable, NFC
Add a couple of local variables for the class interface and the super class
interface. This allows for the repeated
Prazek added a subscriber: Prazek.
Prazek closed this revision.
Prazek added a comment.
Already in master
https://reviews.llvm.org/D2
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
omtcyfz added a comment.
In https://reviews.llvm.org/D21814#486269, @vmiklos wrote:
> In https://reviews.llvm.org/D21814#486204, @omtcyfz wrote:
>
> > - Can you please update diff? I changed most of the tests recently.
>
>
> Sure, I actually wanted to ask if those test additions were meant to be
vmiklos added a comment.
In https://reviews.llvm.org/D21814#486204, @omtcyfz wrote:
> - Can you please update diff? I changed most of the tests recently.
Sure, I actually wanted to ask if those test additions were meant to be test
renames. :-)
> - I think you should update `doc/clang-rename` i
vmiklos updated this revision to Diff 64231.
https://reviews.llvm.org/D21814
Files:
clang-rename/tool/ClangRename.cpp
clang-rename/tool/clang-rename.py
docs/clang-rename.rst
test/clang-rename/ClassFindByName.cpp
test/clang-rename/ClassReplacements.cpp
test/clang-rename/ClassSimpleRena
v.g.vassilev created this revision.
v.g.vassilev added a reviewer: rsmith.
v.g.vassilev added a subscriber: cfe-commits.
I am not sure if we should #include but the instantiation of
`operator*` of `ManagedStatic` needs `std::memory_order_aquire`. Modules builds
error out with:
`In module 'LLVM
mehdi_amini added a comment.
Can you rebase? I can't apply it right now.
https://reviews.llvm.org/D20100
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz added inline comments.
Comment at: clang-rename/USRFindingAction.cpp:62
@@ +61,3 @@
+ bool Found = false;
+ for (auto &OverriddenMethod : D->overridden_methods()) {
+if (std::find(USRs->begin(), USRs->end(),
Prazek wrote:
> const auto &Ov
omtcyfz updated this revision to Diff 64228.
omtcyfz marked an inline comment as done.
https://reviews.llvm.org/D22408
Files:
clang-rename/USRFindingAction.cpp
test/clang-rename/VirtualFunctionFindInBaseClass.cpp
test/clang-rename/VirtualFunctionFindInDerivedClass.cpp
Index: test/clang-ren
Prazek added inline comments.
Comment at: docs/clang-tidy/checks/misc-move-forwarding-reference.rst:30
@@ +29,3 @@
+Background
+--
+
Nothing from me. It's just general comment
https://reviews.llvm.org/D0
___
Prazek added a subscriber: Prazek.
Prazek added a comment.
haven't found anything else
Comment at: clang-rename/USRFindingAction.cpp:62
@@ +61,3 @@
+ bool Found = false;
+ for (auto &OverriddenMethod : D->overridden_methods()) {
+if (std::find(USRs->begin(), US
vmiklos abandoned this revision.
vmiklos added a comment.
I see your point, then let me abandon this.
https://reviews.llvm.org/D22237
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: omtcyfz
Date: Sat Jul 16 03:55:01 2016
New Revision: 275681
URL: http://llvm.org/viewvc/llvm-project?rev=275681&view=rev
Log:
[clang-rename] remove obsolete tests and apply fixes to existing
Few tests introduced by previous patch had obsolete counterparts.
Applied fixes to {Dynamic|Stati
omtcyfz added a subscriber: omtcyfz.
omtcyfz added a comment.
- Can you please update diff? I changed most of the tests recently.
- I think you should update `doc/clang-rename` in this patch (making it a
subsequent patch isn't worthy IMO)
- Updating `clang-rename/tool/clang-rename.py` (simply add
kevgs added a comment.
Good. I have no commit rights.
https://reviews.llvm.org/D20100
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hfinkel
Date: Sat Jul 16 02:22:09 2016
New Revision: 275679
URL: http://llvm.org/viewvc/llvm-project?rev=275679&view=rev
Log:
Revert "Revert r275029 - Update Clang tests after adding inference for the
returned argument attribute"
This reverts commit r275043 after reapplying the underlyin
19 matches
Mail list logo
