Re: [PATCH] D22900: Revert r244207 - Mark calls in thunk functions as tail-call optimization

> On Jul 31, 2016, at 12:11 AM, Amjad Aboud wrote: > > aaboud added a comment. > > Reverting https://reviews.llvm.org/rL244207, would be fine if we assure that > PR24235, is fixed in another way. I think it is inappropriate for anyone who introduced a bug to condition

Re: [PATCH] D22900: Revert r244207 - Mark calls in thunk functions as tail-call optimization

> On Jul 31, 2016, at 1:46 AM, Amjad Aboud wrote: > > aaboud added a comment. > >> ISTM that the DWARF spec intended such thunks to be encoded as >> `DW_AT_trampoline`. That seems more appropriate than relying on codegen >> emitting a tailcall. This way the debugger

RE: [PATCH] D20979: [OpenCL] Use function metadata to represent kernel attributes

Hi Sam, I am now using llvm39 to enable our opencl driver, but I found this patch broke the spir target as well. The opencl.kernels metadata is required by spir spec. I think we should keep the old code for spir target. Thanks Xiuli -Original Message- From: Yaxun Liu

Re: [PATCH] D22982: [CloneDetector] No longer reporting clones that don't have a common referenced variable pattern.

teemperor added a comment. I've deleted false-positives.cpp because all false-positives in there are now resolved and the test did no longer serve a purpose. We could leave the test file in there, but I think new false-positives either belong to an existing test category or deserve their own

Re: [PATCH] D22982: [CloneDetector] No longer reporting clones that don't have a common referenced variable pattern.

teemperor marked 2 inline comments as done. teemperor added a comment. https://reviews.llvm.org/D22982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22982: [CloneDetector] No longer reporting clones that don't have a common referenced variable pattern.

teemperor updated this revision to Diff 66262. teemperor added a comment. - Fixed a few typos in the comments. - Removed unnecessary `std::`. - Added the new tests to functions.cpp instead of their own file. https://reviews.llvm.org/D22982 Files: lib/Analysis/CloneDetection.cpp

Re: [PATCH] D22514: CloneDetection now respects statement specific data when searching for clones.

teemperor updated this revision to Diff 66261. teemperor added a comment. - Added typedef for the contents of the data vector. - Fixed that StmtDataCollector isn't visiting all parent classes of a statement. - Removed 'test-' prefix from test files. - Fixed the other problems as pointed out by

Re: [PATCH] D22725: [clang-tidy] Add check 'modernize-use-algorithm'

Prazek added a comment. I see you solved the void and conmpatible types problems. Excellent! Can you post a patch with changes after running LLVM? I would wait for Alex or Aaron to accept it. Comment at: clang-tidy/modernize/UseAlgorithmCheck.cpp:58-60 @@ +57,5 @@ + + for

Re: r277307 - Add more gcc compatibility names to clang's cpuid.h

Hi Hans, I would like to merge this one to release_39, since it fixes a few third party programs using cpuid.h, and expecting gcc-compatible CPUID bit macros. -Dimitry > On 31 Jul 2016, at 22:23, Dimitry Andric via cfe-commits > wrote: > > Author: dim > Date: Sun

Re: [PATCH] D22010: Add more gcc compatibility names to clang's cpuid.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL277307: Add more gcc compatibility names to clang's cpuid.h (authored by dim). Changed prior to commit: https://reviews.llvm.org/D22010?vs=62781=66250#toc Repository: rL LLVM

r277307 - Add more gcc compatibility names to clang's cpuid.h

Author: dim Date: Sun Jul 31 15:23:23 2016 New Revision: 277307 URL: http://llvm.org/viewvc/llvm-project?rev=277307=rev Log: Add more gcc compatibility names to clang's cpuid.h Summary: Some cpuid bit defines are named slightly different from how gcc's cpuid.h calls them. Define a few more

Re: [PATCH] D22725: [clang-tidy] Add check 'modernize-use-algorithm'

JDevlieghere retitled this revision from "[clang-tidy] Add check 'misc-replace-memcpy'" to "[clang-tidy] Add check 'modernize-use-algorithm'". JDevlieghere updated the summary for this revision. JDevlieghere set the repository for this revision to rL LLVM. JDevlieghere updated this revision to

Re: [PATCH] D22904: Fix two bugs for musl-libc on ARM

rengolin accepted this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D22904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D22900: Revert r244207 - Mark calls in thunk functions as tail-call optimization

aaboud added a comment. > ISTM that the DWARF spec intended such thunks to be encoded as > `DW_AT_trampoline`. That seems more appropriate than relying on codegen > emitting a tailcall. This way the debugger can make the policy decision of > whether or not thunks should show up in the

Re: [PATCH] D22900: Revert r244207 - Mark calls in thunk functions as tail-call optimization

majnemer added a comment. In https://reviews.llvm.org/D22900#501597, @aaboud wrote: > Reverting https://reviews.llvm.org/rL244207, would be fine if we assure that > PR24235, is fixed in another way. > I added Reid who helped reviewing the original patch > https://reviews.llvm.org/D11476.

Re: [PATCH] D22900: Revert r244207 - Mark calls in thunk functions as tail-call optimization

aaboud added a comment. Reverting https://reviews.llvm.org/rL244207, would be fine if we assure that PR24235, is fixed in another way. I added Reid who helped reviewing the original patch https://reviews.llvm.org/D11476. https://reviews.llvm.org/D22900