Author: ericwf
Date: Thu Aug 11 02:04:14 2016
New Revision: 278319
URL: http://llvm.org/viewvc/llvm-project?rev=278319&view=rev
Log:
Refactor test archetypes implementation.
Added:
libcxx/trunk/test/support/archetypes.ipp
Modified:
libcxx/trunk/test/std/utilities/utility/pairs/pairs.pair/
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
I would love to see a benchmark with this, but I've done enough investigating
on my own that I *know* this patch is beneficial.
https://reviews.llvm.org/D2278
Author: ericwf
Date: Thu Aug 11 03:15:35 2016
New Revision: 278323
URL: http://llvm.org/viewvc/llvm-project?rev=278323&view=rev
Log:
Unbreak C++03 build.
Modified:
libcxx/trunk/test/std/utilities/utility/pairs/pairs.pair/default.pass.cpp
Modified:
libcxx/trunk/test/std/utilities/utility/pai
Author: omtcyfz
Date: Thu Aug 11 03:18:39 2016
New Revision: 278324
URL: http://llvm.org/viewvc/llvm-project?rev=278324&view=rev
Log:
[clang-tidy] fix readability-else-after-return test
As pointed by Yung Douglas, exceptions in
test/clang-tidy/readability-else-after-return.cpp are causing PS4 bot
honggyu.kim added a comment.
In https://reviews.llvm.org/D22666#509904, @compnerd wrote:
> Theres a frontend mangler and a backend mangler. You should try this on
> Windows GNU environments :-).
Thanks for the confirmation :)
If so, would it be okay if I put one more backslash for each mcount
andreybokhanko added a subscriber: andreybokhanko.
andreybokhanko added a comment.
@uweigand Ulrich, any objections here? If not, I will commit this patch
tomorrow (as the author, Vladimir, doesn't have commit access yet).
Andrey
Repository:
rL LLVM
https://reviews.llvm.org/D21678
__
omtcyfz created this revision.
omtcyfz added reviewers: alexfh, klimek.
omtcyfz added a subscriber: cfe-commits.
As Alexander pointed out, LLVM Coding Standards are more conservative about
using `auto`, i.e. it should be used in the following situations:
* When the type is //obvious//, i.e. expl
djasper added a comment.
Sorry :(... Review is easy enough.. Feel free to ping me more often in the
future.
Comment at: lib/Format/WhitespaceManager.cpp:95
@@ -97,2 +94,3 @@
std::sort(Changes.begin(), Changes.end(), Change::IsBeforeInFile(SourceMgr));
+ calculateScopeLevel(
v.g.vassilev created this revision.
v.g.vassilev added subscribers: teemperor, dergachev.a, krememek, cfe-commits.
v.g.vassilev set the repository for this revision to rL LLVM.
As a result of a few internal discussions, I'd like to continue the work done
in this ancient thread
(http://lists.llvm
On Wed, Aug 10, 2016 at 02:36:01PM -0700, Bruno Cardoso Lopes wrote:
> Hi Joerg,
>
> > Given that bzero is pretty much non-standard at this point, I strongly
> > dislike the approach of checking only the function name.
>
> Thanks for the feedback. bzero it's widely used though, I think it's a
> u
omtcyfz added a subscriber: omtcyfz.
Comment at: lib/Analysis/CloneDetection.cpp:436
@@ +435,3 @@
+if (IsInMacro) {
+ Signature.Complexity = 0;
+}
Do I understand correctly that a code generated by a macro doesn't affect
"complexity" at all then?
``
NoQ added inline comments.
Comment at: lib/Analysis/CloneDetection.cpp:436
@@ +435,3 @@
+if (IsInMacro) {
+ Signature.Complexity = 0;
+}
omtcyfz wrote:
> Do I understand correctly that a code generated by a macro doesn't affect
> "complexity" at all
omtcyfz added inline comments.
Comment at: lib/Analysis/CloneDetection.cpp:436
@@ +435,3 @@
+if (IsInMacro) {
+ Signature.Complexity = 0;
+}
NoQ wrote:
> omtcyfz wrote:
> > Do I understand correctly that a code generated by a macro doesn't affect
> >
omtcyfz added inline comments.
Comment at: lib/Analysis/CloneDetection.cpp:436
@@ +435,3 @@
+if (IsInMacro) {
+ Signature.Complexity = 0;
+}
omtcyfz wrote:
> NoQ wrote:
> > omtcyfz wrote:
> > > Do I understand correctly that a code generated by a macr
omtcyfz added inline comments.
Comment at: lib/Analysis/CloneDetection.cpp:436
@@ +435,3 @@
+if (IsInMacro) {
+ Signature.Complexity = 0;
+}
omtcyfz wrote:
> omtcyfz wrote:
> > NoQ wrote:
> > > omtcyfz wrote:
> > > > Do I understand correctly that a c
bcraig added a comment.
Note: In the future, try to provide more context lines in the patch.
http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
I'm mostly fine with the algorithmic changes. I'm not thrilled with the
formatting of the error message, but I'm not sur
bcraig added a comment.
I am kind of interested in what the warning message for clang::Sema in
clang/include/clang/Sema/Sema.h looks like. When I last analyzed that file,
there was a bunch of padding. It's a very long class though, so it can stress
the usability of your messages.
https://re
yaxunl updated this revision to Diff 67687.
yaxunl added a comment.
Revised by Matt's comments.
https://reviews.llvm.org/D23361
Files:
include/clang/Basic/TargetInfo.h
lib/Basic/TargetInfo.cpp
lib/Basic/Targets.cpp
lib/CodeGen/CodeGenModule.cpp
test/CodeGenOpenCL/size_t.cl
Index: tes
teemperor updated this revision to Diff 67691.
teemperor added a comment.
- Rebased the patch to the newest code base.
This patch is live again as it turned out that the CloneDetector can't handle
large code bases without it. The simpler approach that we implemented instead
consumed too much me
NoQ added a comment.
The checker's in great shape! I see a few minor things, but that's it.
The checks are split into two sections ("uninitialized" and "unterminated"),
but there seem to be more auxiliary checks provided (eg. "copies into itself")
that are on for both checkers, do you think you
On Wed, Aug 10, 2016 at 5:39 PM Eric Fiselier wrote:
> On Mon, Aug 8, 2016 at 9:32 AM, David Blaikie via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> I'm still (as per another similar thread) a bit concerned this is working
>> around a compiler optimizer bug - I'd love to see a standal
vleschuk updated this revision to Diff 67694.
vleschuk added a comment.
Add IR tests
https://reviews.llvm.org/D23168
Files:
lib/AST/Decl.cpp
lib/CodeGen/CGDebugInfo.cpp
test/Frontend/dinoreturn.c
test/Frontend/dinoreturn.cpp
test/Frontend/dinoreturn.m
Index: test/Frontend/dinoreturn.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278356: Add 'inline' attribute to __init to inline the
basic_string's constructor (authored by spop).
Changed prior to commit:
https://reviews.llvm.org/D22782?vs=67597&id=67699#toc
Repository:
rL LLV
zturner created this revision.
zturner added reviewers: alexfh, djasper, rnk.
zturner added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Attempting to run clang-tidy with the clang-cl driver results in a number of
warnings and errors that make the tool unusable. The two main iss
Author: compnerd
Date: Thu Aug 11 11:58:12 2016
New Revision: 278357
URL: http://llvm.org/viewvc/llvm-project?rev=278357&view=rev
Log:
test: relax the FS test a slight bit to be more reliable
Some filesystems track atime always. This relaxes the test to accept either a
filesystem which does not
NoQ added a comment.
No comments of my own, the patch looks good :)
Comment at: lib/Analysis/CloneDetection.cpp:436
@@ +435,3 @@
+if (IsInMacro) {
+ Signature.Complexity = 0;
+}
omtcyfz wrote:
> omtcyfz wrote:
> > omtcyfz wrote:
> > > NoQ wrote:
> >
sebpop added a comment.
In https://reviews.llvm.org/D22782#512337, @EricWF wrote:
> I would love to see a benchmark with this, but I've done enough investigating
> on my own that I *know* this patch is beneficial.
This patch was motivated by perf analysis we did on a proprietary benchmark in
Author: spop
Date: Thu Aug 11 11:51:48 2016
New Revision: 278356
URL: http://llvm.org/viewvc/llvm-project?rev=278356&view=rev
Log:
Add 'inline' attribute to __init to inline the basic_string's constructor
basic_string's constructor calls init which was not getting inlined. This
prevented optimiz
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a comment.
Patch generally LGTM, though I wonder if there's a way we can add test coverage
for this.
https://reviews.llvm.org/D23409
___
cfe-commits mailing list
cfe-commits@lists
Anastasia added a comment.
I think Clang is supposed to generate the IR specific to the target
architecture. It seems strange to ignore the pointer size. I am not sure if it
might lead to some issues for the backends.
Comment at: lib/CodeGen/CodeGenModule.cpp:107
@@ -106,2 +10
Anastasia added a comment.
Is this related to our discussion on cfe-dev about the extensions and also the
earlier review you have created: https://reviews.llvm.org/D21698?
https://reviews.llvm.org/D23322
___
cfe-commits mailing list
cfe-commits@lis
rnk added inline comments.
Comment at: lib/Driver/Driver.cpp:93
@@ +92,3 @@
+ ArrayRef Args) {
+ auto Default = ToolChain::getTargetAndModeFromProgramName(ProgramName);
+ StringRef DefaultMode(Default.second);
Why not change ToolInvoc
zturner added a comment.
In https://reviews.llvm.org/D23409#512720, @aaron.ballman wrote:
> Patch generally LGTM, though I wonder if there's a way we can add test
> coverage for this.
I'd imagine we can just enable the clang-tidy test suite on Windows (I'm
assuming it's currently disabled).
aprantl added inline comments.
Comment at: test/Frontend/dinoreturn.c:2
@@ +1,3 @@
+// RUN: %clang %s -c -std=c11 -emit-llvm -S -g -o - | FileCheck %s
+// CHECK: DIFlagNoReturn
+#include
Please check for more context. For example:
CHECK: !DISubprogram({{.*}}na
zturner added inline comments.
Comment at: lib/Tooling/JSONCompilationDatabase.cpp:119
@@ -115,1 +118,3 @@
StringRef EscapedCommandLine) {
+#if defined(LLVM_ON_WIN32)
+ llvm::BumpPtrAllocator Alloc;
rnk wrote:
> It would be nice if the JSON file just told us
aprantl added a comment.
You are adding a new constant to the LLVM IR, so there should be a round-trip
test that tests the LLVM IR parser, bitcode writer, bitcode reader, and LLVM IR
printer to make sure we're handling the new constant correctly.
One easy way to do this is by adding the new fla
zturner added inline comments.
Comment at: lib/Driver/Driver.cpp:93
@@ +92,3 @@
+ ArrayRef Args) {
+ auto Default = ToolChain::getTargetAndModeFromProgramName(ProgramName);
+ StringRef DefaultMode(Default.second);
rnk wrote:
> Why not
yaxunl added a comment.
In https://reviews.llvm.org/D23322#512732, @Anastasia wrote:
> Is this related to our discussion on cfe-dev about the extensions and also
> the earlier review you have created: https://reviews.llvm.org/D21698?
Since that feature takes time to implement, we decide to add
alexshap added a comment.
Thanks, your points regarding better formatting of the diagnostics / moving it
into a note or fixit and using more stable sort
are valid, i will update this diff today or tomorrow. Regarding the type name -
i am not sure - for example for template specializations
(for
Yes, this should be merged. It's not quite right, but it's certainly better
than what we had before.
On Mon, Aug 8, 2016 at 1:34 PM, Hans Wennborg wrote:
> Richard: ping?
>
> On Wed, Jul 27, 2016 at 4:46 PM, Hans Wennborg wrote:
> > Should this be merged to 3.9?
> >
> > Thanks,
> > Hans
> >
> >
zturner added a comment.
In https://reviews.llvm.org/D23409#512745, @zturner wrote:
> In https://reviews.llvm.org/D23409#512720, @aaron.ballman wrote:
>
> > Patch generally LGTM, though I wonder if there's a way we can add test
> > coverage for this.
>
>
> I'd imagine we can just enable the clan
Well, the whole approach here is still wrong (per the FIXME in
CFGBuilder::addLocalScopeForVarDecl) but this at least makes it consistent.
Let's take this for 3.9 to at least stem the bleeding.
On Tue, Aug 9, 2016 at 11:57 AM, Hans Wennborg wrote:
> For the record, this was for PR28666.
>
> Rich
Anastasia added a comment.
Ok, sure. Is the plan to refactor this bit in case we implement the generic
support later then?
It seems fine, although I can't check much without any documentation. Is there
any reference available online?
https://reviews.llvm.org/D23322
yaxunl added a comment.
In https://reviews.llvm.org/D23322#512823, @Anastasia wrote:
> Ok, sure. Is the plan to refactor this bit in case we implement the generic
> support later then?
>
> It seems fine, although I can't check much without any documentation. Is
> there any reference available o
Merged in r278374.
Thanks,
Hans
On Thu, Aug 11, 2016 at 11:07 AM, Richard Smith wrote:
> Yes, this should be merged. It's not quite right, but it's certainly better
> than what we had before.
>
> On Mon, Aug 8, 2016 at 1:34 PM, Hans Wennborg wrote:
>>
>> Richard: ping?
>>
>> On Wed, Jul 27, 201
yaxunl marked an inline comment as done.
yaxunl added a comment.
In https://reviews.llvm.org/D23361#512729, @Anastasia wrote:
> I think Clang is supposed to generate the IR specific to the target
> architecture. It seems strange to ignore the pointer size. I am not sure if
> it might lead to so
teemperor retitled this revision from "Added false-positive filter for
unintended hash code collisions to the CloneDetector." to "[analyzer] Added
custom hashing to the CloneDetector.".
teemperor updated the summary for this revision.
teemperor updated this revision to Diff 67715.
teemperor added
Merged in r278376.
Thanks,
Hans
On Thu, Aug 11, 2016 at 11:13 AM, Richard Smith wrote:
> Well, the whole approach here is still wrong (per the FIXME in
> CFGBuilder::addLocalScopeForVarDecl) but this at least makes it consistent.
> Let's take this for 3.9 to at least stem the bleeding.
>
>
> On
Author: bruno
Date: Thu Aug 11 13:33:15 2016
New Revision: 278379
URL: http://llvm.org/viewvc/llvm-project?rev=278379&view=rev
Log:
[Sema] Add more strict check for sizeof diagnostics for bzero
Follow-up from r278264 after Joerg's feedback.
Since bzero is not standard, be more strict: also check
manmanren added inline comments.
Comment at: lib/Frontend/CompilerInstance.cpp:1438-1450
@@ -1437,3 +1437,15 @@
// Search for a module with the given name.
Module = PP->getHeaderSearchInfo().lookupModule(ModuleName);
-if (!Module) {
+HeaderSearchOptions &HSOpts =
On Thu, Aug 11, 2016 at 5:43 AM, Joerg Sonnenberger via cfe-commits
wrote:
>
> On Wed, Aug 10, 2016 at 02:36:01PM -0700, Bruno Cardoso Lopes wrote:
> > Hi Joerg,
> >
> > > Given that bzero is pretty much non-standard at this point, I strongly
> > > dislike the approach of checking only the functio
Author: dcoughlin
Date: Thu Aug 11 13:41:29 2016
New Revision: 278382
URL: http://llvm.org/viewvc/llvm-project?rev=278382&view=rev
Log:
[analyzer] Teach RetainCountChecker about CVFooRetain
Change the retain count checker to treat CoreFoundation-style "CV"-prefixed
reference types from CoreVideo
erik.pilkington updated this revision to Diff 67713.
erik.pilkington added a comment.
This new patch adds some testcases for templates, and simplifies some control
flow in `TraverseIfStmt`. This patch also removes diagnostics for instantiated
templates, instead just using the pattern. This means
Author: marshall
Date: Thu Aug 11 13:46:24 2016
New Revision: 278387
URL: http://llvm.org/viewvc/llvm-project?rev=278387&view=rev
Log:
Remove test for the sign of a NaN - doesn't work on MIPS, not strictly legal.
Fixes bug 28936
Modified:
libcxx/trunk/test/std/numerics/complex.number/comple
I'm just curious: Is libcxx generally supposed to merely pass through what the
operating system is returning (as in this case) or is is supposed to provide a
common abstraction that behaves the same on all platforms?
-- adrian
> On Aug 10, 2016, at 8:23 PM, Eric Fiselier via cfe-commits
> wro
manmanren updated this revision to Diff 67727.
manmanren added a comment.
Addressing Richard's comments.
https://reviews.llvm.org/D23125
Files:
docs/Modules.rst
include/clang/Driver/Options.td
include/clang/Lex/HeaderSearch.h
include/clang/Lex/HeaderSearchOptions.h
include/clang/Seria
Author: ed
Date: Thu Aug 11 14:23:30 2016
New Revision: 278393
URL: http://llvm.org/viewvc/llvm-project?rev=278393&view=rev
Log:
Pass in frame pointer omitting compiler flags for CloudABI as well.
On Linux we pass in -fomit-frame-pointer flags (and similar)
automatically if optimization is enable
teemperor created this revision.
teemperor added reviewers: v.g.vassilev, NoQ, zaks.anna.
teemperor added a subscriber: cfe-commits.
https://reviews.llvm.org/D23418
Files:
include/clang/Analysis/CloneDetection.h
lib/Analysis/CloneDetection.cpp
lib/StaticAnalyzer/Checkers/CloneChecker.cpp
I
teemperor planned changes to this revision.
teemperor added a comment.
- Add description
- Make sure functions in CloneDetection.cpp are in a more logical order.
https://reviews.llvm.org/D23418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
zatrazz created this revision.
zatrazz added reviewers: jroelofs, danalbert.
zatrazz added subscribers: rengolin, cfe-commits.
Herald added a subscriber: aemerson.
Some tests uses 'long double' to/from conversions and for some targets
they are provided by compiler runtime (either compiler-rt or li
Author: ed
Date: Thu Aug 11 15:03:22 2016
New Revision: 278395
URL: http://llvm.org/viewvc/llvm-project?rev=278395&view=rev
Log:
Don't enable PIE on i686-unknown-cloudabi.
We're only going to provide support for using PIE on architectures that
provide PC-relative addressing. i686 is not one of th
bruno created this revision.
bruno added a reviewer: benlangmuir.
bruno added a subscriber: cfe-commits.
Add 'ignore-non-existent-contents' to tell the VFS whether an invalid path
obtained via 'external-contents' should cause iteration on the VFS to stop.
If 'true', the VFS should ignore the entr
alexfh added a comment.
In https://reviews.llvm.org/D23409#512819, @zturner wrote:
> In https://reviews.llvm.org/D23409#512745, @zturner wrote:
>
> > In https://reviews.llvm.org/D23409#512720, @aaron.ballman wrote:
> >
> > > Patch generally LGTM, though I wonder if there's a way we can add test
On Thu, Aug 11, 2016 at 1:07 PM, Richard Smith wrote:
> Yes, this should be merged. It's not quite right, but it's certainly better
> than what we had before.
I would agree that the comment is broken - but, unless i'm missing
something subtle, the subsequent logic and call to
adjustCVQualifiersF
On Thu, Aug 11, 2016 at 08:03:22PM -, Ed Schouten via cfe-commits wrote:
> Modified: cfe/trunk/lib/Driver/ToolChains.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=278395&r1=278394&r2=278395&view=diff
> =
alexfh added a comment.
May I ask you to upload patches with full diff context next time? I know, it's
not directly supported by TortoiseGit, but there are at least two other
reasonable ways of generating full diffs for Phabricator:
http://llvm.org/docs/Phabricator.html#requesting-a-review-via-
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
If I'm not mistaken, GCC or Clang has warning that result of comparison is
always true for such situations.
Comment at: clang-tidy/misc/ComparisonFunctionAddressCheck.h:
Eugene.Zelenko added a comment.
Clang-tidy terminology use //checks//, not //checkers//.
Repository:
rL LLVM
https://reviews.llvm.org/D23423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
falho created this revision.
falho added reviewers: xazax.hun, o.gyorgy, alexfh, aaron.ballman, etienneb,
hokein, Prazek.
falho added a subscriber: cfe-commits.
falho set the repository for this revision to rL LLVM.
This checker warns for the misuse of comparison operators
- char* is compared to
zturner added a comment.
In https://reviews.llvm.org/D23409#513017, @alexfh wrote:
> May I ask you to upload patches with full diff context next time? I know,
> it's not directly supported by TortoiseGit, but there are at least two other
> reasonable ways of generating full diffs for Phabricato
rmaprath added a subscriber: rmaprath.
rmaprath added a comment.
I too noticed this very recently (on our non-bare-metal builds), and wondered
why these dependencies are not included by default. Thanks for looking into it.
I'll let someone familiar with the details approve.
https://reviews.llv
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Comment at: docs/clang-tidy/checks/cert-msc50-cpp.rst:4
@@ +3,3 @@
+cert-msc-50
+===
+
Should be same length as section name above.
=
aaron.ballman added a comment.
Thank you for working on this check! There is a slight problem, however, in
that the check as-written will flag false positives because there are times
when it is permissible to modify the std namespace. The important bit of the
CERT requirement is "Do not add dec
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Please run Clang-format on newly added files. Test case is definitely needs it.
Comment at: clang-tidy/misc/ComparisonM
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/misc/ComparisonMisuseCheck.cpp:21
@@ +20,3 @@
+void ComparisonMisuseCheck::registerMatchers(MatchFinder *Finder) {
+
+ Finder->addMatcher(
Please remove this line.
Repository:
rL LLVM
https://revie
Eugene.Zelenko added a comment.
This check looks like specific case of https://reviews.llvm.org/D23427. May be
they should be merged?
Repository:
rL LLVM
https://reviews.llvm.org/D23423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
benlangmuir added a comment.
This should have a test for the writer change. Otherwise LGTM.
https://reviews.llvm.org/D23422
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hans
Date: Thu Aug 11 16:47:28 2016
New Revision: 278425
URL: http://llvm.org/viewvc/llvm-project?rev=278425&view=rev
Log:
Merging r278387:
r278387 | marshall | 2016-08-11 11:46:24 -0700 (Thu, 11 Aug 2016) | 1 line
R
Merged to 3.9 in r278425, as the PR was marked as a release blocker.
On Thu, Aug 11, 2016 at 11:46 AM, Marshall Clow via cfe-commits
wrote:
> Author: marshall
> Date: Thu Aug 11 13:46:24 2016
> New Revision: 278387
>
> URL: http://llvm.org/viewvc/llvm-project?rev=278387&view=rev
> Log:
> Remove t
EricWF added a subscriber: EricWF.
EricWF added a reviewer: EricWF.
EricWF added a comment.
Urg... Not this again. This link order is important. I can't remember *why*,
but libgcc has to appear both before and after `pthread` and `libc` IIRC.
Either way the intention here is to mimic the output
Author: hans
Date: Thu Aug 11 16:48:37 2016
New Revision: 278426
URL: http://llvm.org/viewvc/llvm-project?rev=278426&view=rev
Log:
Merging r278282:
r278282 | marshall | 2016-08-10 13:04:46 -0700 (Wed, 10 Aug 2016) | 1 line
s
I've gone ahead and merged it in r278426.
On Wed, Aug 10, 2016 at 5:19 PM, Eric Fiselier wrote:
> I would support merging this change.
>
> /Eric
>
> On Wed, Aug 10, 2016 at 3:20 PM, Hans Wennborg via cfe-commits
> wrote:
>>
>> Should we merge this to 3.9? Looks like a straight-forward fix for
>>
zturner updated this revision to Diff 67751.
zturner added a comment.
I added a test for the clang Driver changes.
It seems I'm still having some trouble writing the clang-cl test for
clang-tidy. It depends on having a different compilation database that uses
clang-cl instead of clang. I foun
On Thu, Aug 11, 2016 at 1:38 PM, Faisal Vali wrote:
> On Thu, Aug 11, 2016 at 1:07 PM, Richard Smith
> wrote:
> > Yes, this should be merged. It's not quite right, but it's certainly
> better
> > than what we had before.
>
> I would agree that the comment is broken - but, unless i'm missing
> s
tra created this revision.
tra added a reviewer: jlebar.
tra added a subscriber: cfe-commits.
This matches the way nvcc encapsulates GPU binaries into host object file.
Now cuobjdump can deal with clang-compiled object files.
https://reviews.llvm.org/D23429
Files:
lib/CodeGen/CGCUDANV.cpp
Author: rsmith
Date: Thu Aug 11 17:25:46 2016
New Revision: 278435
URL: http://llvm.org/viewvc/llvm-project?rev=278435&view=rev
Log:
P0217R3: Perform semantic checks and initialization for the bindings in a
decomposition declaration for arrays, aggregate-like structs, tuple-like
types, and (as an
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
OK. This should help with PR26966.
https://reviews.llvm.org/D23341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Makes sense. isMacroID and isInSystemHeader are both already marked const.
https://reviews.llvm.org/D23433
___
cfe-commits mailing list
cfe-commits@lis
jlebar added inline comments.
Comment at: lib/CodeGen/CGCUDANV.cpp:62
@@ -60,2 +61,3 @@
llvm::ConstantInt::get(SizeTy, 0)};
-auto ConstStr = CGM.GetAddrOfConstantCString(Str, Name.c_str());
+auto ConstStr = CGM.GetAddrOfConstantCString(Str,
thegameg created this revision.
thegameg added reviewers: joker-eph, vsk, dblaikie.
thegameg added a subscriber: cfe-commits.
The member function is a predicate, and doesn't apply any changes on the object.
https://reviews.llvm.org/D23433
Files:
include/clang/Basic/SourceManager.h
Index: incl
EricWF updated this revision to Diff 67768.
EricWF added a comment.
Re-flow comments because I suck at English.
https://reviews.llvm.org/D23385
Files:
include/clang/AST/Expr.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/ExpressionTraits.h
include/clang/Basic/TokenKind
jroelofs added a subscriber: jroelofs.
Comment at: lib/AST/Expr.cpp:2656
@@ +2655,3 @@
+AllowNonLiteral)) {
+if (!CE->getNumArgs()) return true;
+unsigned numArgs = CE->getNumArgs();
no need for this `if`.
Also, I think the `for` shoul
jroelofs added a comment.
One more thing: need to add docs to `clang/docs/LanguageExtensions.rst`.
https://reviews.llvm.org/D23385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zturner created this revision.
zturner added reviewers: alexfh, djasper.
zturner added a subscriber: cfe-commits.
See llvm.org/pr28943 for some context.
I'm not sure if this is the right fix, but it seems to pass the test suite for
me.
https://reviews.llvm.org/D23434
Files:
clang-tidy/llvm/I
zatrazz added a comment.
I tried to find why exactly libgcc has to appear before and after but I
couldn't get any information from commit history. On my system (aarch64/linux)
I am also getting "-lc++" "-lm" "-lgcc_s" "-lgcc" "-lpthread" "-lc" "-lgcc_s"
"-lgcc".
I think we can got by the safe
EricWF marked an inline comment as done.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6807
@@ +6806,3 @@
+
+def err_has_constant_init_expression_trait_invalid_arg : Error<
+ "expression does not reference a named variable">;
Help improving this wording
zturner updated this revision to Diff 67772.
zturner added a comment.
Fixed the test for this. Confirmed that it fails before the patch and succeeds
after the patch.
https://reviews.llvm.org/D23434
Files:
clang-tidy/llvm/IncludeOrderCheck.cpp
test/clang-tidy/Inputs/Headers/cross-file-a.h
alexshap updated this revision to Diff 67773.
alexshap added a comment.
Use more stable sort (preserving the original order if possible).
Change the format of the report.
Update the tests.
I have not turned it to "note:" or "remark:" because in this case
it's not included into the description and
EricWF added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:4775
@@ +4774,3 @@
+ // a 'constant initializer'.
+ else if ((VD->hasGlobalStorage() ||
+ VD->getTLSKind() != VarDecl::TLS_None) && VD->hasInit()) {
EricWF wrote:
> jroelofs wrot
thegameg added a comment.
Thanks @vsk. As I don't have commit access, is it possible to commit this for
me, please? Thanks.
https://reviews.llvm.org/D23433
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
1 - 100 of 128 matches
Mail list logo
