r278655 - [CodeGen] Correctly implement the AVX512 psABI rules

2016-08-14 Thread David Majnemer via cfe-commits
Author: majnemer Date: Mon Aug 15 01:39:18 2016 New Revision: 278655 URL: http://llvm.org/viewvc/llvm-project?rev=278655&view=rev Log: [CodeGen] Correctly implement the AVX512 psABI rules An __m512 vector type wrapped in a structure should be passed in a vector register. Our prior implementation

r278650 - cxx_status: update features implemented in clang 3.9 from "svn" to "Clang 3.9" now that svn trunk is 4.0.

2016-08-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Aug 14 21:47:23 2016 New Revision: 278650 URL: http://llvm.org/viewvc/llvm-project?rev=278650&view=rev Log: cxx_status: update features implemented in clang 3.9 from "svn" to "Clang 3.9" now that svn trunk is 4.0. Modified: cfe/trunk/www/cxx_status.html Modified: cf

r278649 - cxx_status: mark decomposition declarations as "partial": the implementation is

2016-08-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Aug 14 21:37:43 2016 New Revision: 278649 URL: http://llvm.org/viewvc/llvm-project?rev=278649&view=rev Log: cxx_status: mark decomposition declarations as "partial": the implementation is essentially complete, other than parts where design questions have been raised (lambd

r278648 - Disable lambda-capture of decomposition declaration bindings for now, until CWG

2016-08-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Aug 14 21:34:23 2016 New Revision: 278648 URL: http://llvm.org/viewvc/llvm-project?rev=278648&view=rev Log: Disable lambda-capture of decomposition declaration bindings for now, until CWG agrees on how they're supposed to work. Modified: cfe/trunk/include/clang/Basic/

r278647 - Add a triple to this test to make buildbots happier.

2016-08-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Aug 14 21:24:00 2016 New Revision: 278647 URL: http://llvm.org/viewvc/llvm-project?rev=278647&view=rev Log: Add a triple to this test to make buildbots happier. Modified: cfe/trunk/test/CodeGenCXX/cxx1z-decomposition.cpp Modified: cfe/trunk/test/CodeGenCXX/cxx1z-deco

[libcxx] r278643 - Check in SFINAE base class for use in optional/variant

2016-08-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Aug 14 20:51:54 2016 New Revision: 278643 URL: http://llvm.org/viewvc/llvm-project?rev=278643&view=rev Log: Check in SFINAE base class for use in optional/variant Modified: libcxx/trunk/include/__tuple Modified: libcxx/trunk/include/__tuple URL: http://llvm.org/view

r278642 - P0217R3: code generation support for decomposition declarations.

2016-08-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Aug 14 20:33:41 2016 New Revision: 278642 URL: http://llvm.org/viewvc/llvm-project?rev=278642&view=rev Log: P0217R3: code generation support for decomposition declarations. Added: cfe/trunk/test/CodeGenCXX/cxx1z-decomposition.cpp Modified: cfe/trunk/lib/AST/ASTCon

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

2016-08-14 Thread Hal Finkel via cfe-commits
hfinkel updated this revision to Diff 67992. hfinkel added a comment. Updated to use scheme suggested by Marshall. https://reviews.llvm.org/D18639 Files: include/cmath include/complex Index: include/complex === --- include/com

Re: [PATCH] D18639: Use __builtin_isnan/isinf/isfinite in complex

2016-08-14 Thread Hal Finkel via cfe-commits
hfinkel added a comment. In https://reviews.llvm.org/D18639#491232, @mclow.lists wrote: > And is there any reason why `__libcpp_isinf` can't just return `false` for > non-fp types? For custom numeric types that have an isinf, etc. found by ADL, they should continue to work. https://reviews.

r278640 - Explicitly generate a reference variable to hold the initializer for a

2016-08-14 Thread Richard Smith via cfe-commits
Author: rsmith Date: Sun Aug 14 18:15:52 2016 New Revision: 278640 URL: http://llvm.org/viewvc/llvm-project?rev=278640&view=rev Log: Explicitly generate a reference variable to hold the initializer for a tuple-like decomposition declaration. This significantly simplifies the semantics of BindingDe

[libcxx] r278638 - Add private option to change build dialect from C++11

2016-08-14 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Sun Aug 14 17:51:54 2016 New Revision: 278638 URL: http://llvm.org/viewvc/llvm-project?rev=278638&view=rev Log: Add private option to change build dialect from C++11 Although libc++ only requires C++11 to build, there are other reasons to turn on a newer dialect in the build.

[PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

2016-08-14 Thread Faisal Vali via cfe-commits
faisalv created this revision. faisalv added reviewers: rsmith, hans. faisalv added a subscriber: cfe-commits. faisalv set the repository for this revision to rL LLVM. Fix the following Bug: https://llvm.org/bugs/show_bug.cgi?id=28366 This patch teaches the constant expression evaluator to search

Re: [PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

2016-08-14 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23 @@ +21,4 @@ + Finder->addMatcher( + declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")), + parameterCountIs(0 +

Re: [PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

2016-08-14 Thread Benedek Kiss via cfe-commits
falho added a comment. Hi! Thanks for the reviews! I will be off for a few days so I will start working on it when Im back. Greetz! Benedek Repository: rL LLVM https://reviews.llvm.org/D22346 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

Re: [PATCH] D23397: [clang-rename] cleanup `auto` usages

2016-08-14 Thread Kirill Bobyrev via cfe-commits
omtcyfz updated this revision to Diff 67989. omtcyfz marked 3 inline comments as done. omtcyfz added a comment. Address comments. https://reviews.llvm.org/D23397 Files: clang-rename/RenamingAction.cpp clang-rename/USRFinder.cpp clang-rename/USRFindingAction.cpp clang-rename/USRLocFinder

Re: [PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

2016-08-14 Thread Piotr Padlewski via cfe-commits
Prazek added inline comments. Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23 @@ +21,4 @@ + Finder->addMatcher( + declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")), + parameterCountIs(0 +

[PATCH] D23492: Make function local tags visible.

2016-08-14 Thread Vassil Vassilev via cfe-commits
v.g.vassilev created this revision. v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. Upon instantiating function decls, we should mark visible any tag decl in the function's body. Repository: rL L

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

2016-08-14 Thread Eric Fiselier via cfe-commits
EricWF updated this revision to Diff 67987. EricWF added a comment. Fix missing semicolon. https://reviews.llvm.org/D23385 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/AttributeList.h lib/Sema/SemaDecl

Re: [PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

2016-08-14 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23 @@ +21,4 @@ + Finder->addMatcher( + declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")), + parameterCountIs(0 +

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

2016-08-14 Thread Eric Fiselier via cfe-commits
EricWF updated this revision to Diff 67986. EricWF marked an inline comment as done. EricWF added a comment. Get all tests passing regarding duplicate warnings between `__attribute__((requires_constant_initialization))` and `-Wglobal-constructors`. The warning will not emit a duplicate warning a

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

2016-08-14 Thread Eric Fiselier via cfe-commits
EricWF marked an inline comment as done. Comment at: lib/Sema/SemaDecl.cpp:10528 @@ +10527,3 @@ +var->getLocation())) { + // Warn about globals which don't have a constant initializer. Don't + // warn about globals with a non-trivial

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

2016-08-14 Thread Eric Fiselier via cfe-commits
EricWF added inline comments. Comment at: lib/Sema/SemaDecl.cpp:10484-10485 @@ -10478,1 +10483,4 @@ + if (var->hasAttr() && !Init) + Diag(var->getLocation(), diag::err_require_constant_init_failed); + rsmith wrote: > I think this check is incorrect: we perf

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

2016-08-14 Thread Eric Fiselier via cfe-commits
EricWF updated this revision to Diff 67983. EricWF marked 2 inline comments as done. EricWF added a comment. Attempt to address Richards concerns about duplicate diagnostics and add tests for those cases. Unfortunately the tests are failing, because there is a duplicate -Wglobal-constructors di

Re: [PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

2016-08-14 Thread Piotr Padlewski via cfe-commits
Prazek added inline comments. Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23 @@ +21,4 @@ + Finder->addMatcher( + declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")), + parameterCountIs(0 +

Re: [PATCH] D21959: [X86] Add xgetbv xsetbv intrinsics

2016-08-14 Thread Craig Topper via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D21959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

2016-08-14 Thread Zachary Turner via cfe-commits
It occurred to me that eol detection won't work reliably. Especially for tests, someone will write a compilation database by hand and check it in. Maybe they have git set to convert newlines for them, and we don't want a test to behave differently based on your source control settings. The target

Re: [PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

2016-08-14 Thread Aaron Ballman via cfe-commits
aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Thank you for working on this check! Comment at: clang-tidy/cert/CERTTidyModule.cpp:37 @@ -35,1 +36,3 @@ // DCL +CheckFactories.registerCheck(

Re: [PATCH] D21959: [X86] Add xgetbv xsetbv intrinsics

2016-08-14 Thread Guy Blank via cfe-commits
guyblank added a comment. If there aren't any further objections, I'd like go ahead with the commit. https://reviews.llvm.org/D21959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22862: [analyzer] Fix for PR15623: eliminate unwanted ProgramState checker data propagation.

2016-08-14 Thread Anton Yartsev via cfe-commits
ayartsev added a comment. @zaks.anna, sorry for the noise about the "misc-ps-region-store.m" test, my mistake. In https://reviews.llvm.org/D22862#508674, @NoQ wrote: > Hmm. The test in `unwanted-programstate-data-propagation.c` passes on my > machine even without the patch, and the return valu

Re: [PATCH] D23455: [Tooling] Parse compilation database command lines properly on Windows

2016-08-14 Thread Manuel Klimek via cfe-commits
On Sun, Aug 14, 2016, 9:52 AM Zachary Turner wrote: > I'll try and figure out who that was on Monday and loop them in. I'm not > sure what problems the previous person ran into, but the test suite passes, > i can run it on a large codebase, and all the results look fine and as if > the tool is wo

Re: [PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

2016-08-14 Thread Piotr Padlewski via cfe-commits
Prazek accepted this revision. Prazek added a comment. This revision is now accepted and ready to land. LGTM with the fixes of docs. Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:31 @@ +30,3 @@ + Result.Nodes.getNodeAs("randomGenerator"); + diag(MatchedDecl->getLo