r280197 - [AVX-512] Implement masked floating point logical operations with native IR and remove the builtins.

Author: ctopper Date: Wed Aug 31 00:38:58 2016 New Revision: 280197 URL: http://llvm.org/viewvc/llvm-project?rev=280197=rev Log: [AVX-512] Implement masked floating point logical operations with native IR and remove the builtins. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

r280196 - [X86] Use v2i64 vectors to implement _mm_and/andn/or/xor_pd.

Author: ctopper Date: Wed Aug 31 00:38:55 2016 New Revision: 280196 URL: http://llvm.org/viewvc/llvm-project?rev=280196=rev Log: [X86] Use v2i64 vectors to implement _mm_and/andn/or/xor_pd. These will be reused when removing some builtins from avx512vldqintrin.h and this will make the tests for

Re: [PATCH] D23279: clang-reorder-fields

djasper added a comment. As per my comment, please add tests for cases where you currently don't do re-ordering (different access specifiers, partial initializers). Other than that, yes, this is fine to commit. Repository: rL LLVM https://reviews.llvm.org/D23279

Re: [PATCH] D24065: [libc++] Don't attempt to dllexport enum class

smeenai marked 3 inline comments as done. smeenai added a comment. https://reviews.llvm.org/D24065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24065: [libc++] Don't attempt to dllexport enum class

smeenai updated this revision to Diff 69797. smeenai updated the summary for this revision. smeenai added a comment. Removing export entirely, per compnerd's suggestion https://reviews.llvm.org/D24065 Files: include/__config Index: include/__config

Re: [PATCH] D24065: [libc++] Don't attempt to dllexport enum class

compnerd added inline comments. Comment at: include/__config:719 @@ -718,3 +718,3 @@ #else // _LIBCPP_HAS_NO_STRONG_ENUMS -#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS x +#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS_ONLY x #define

Re: [PATCH] D24065: [libc++] Don't attempt to dllexport enum class

smeenai added inline comments. Comment at: include/__config:719 @@ -718,3 +718,3 @@ #else // _LIBCPP_HAS_NO_STRONG_ENUMS -#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS x +#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS_ONLY x #define

Re: [PATCH] D23734: Add -fprofile-dir= to clang.

compnerd added inline comments. Comment at: lib/Transforms/Instrumentation/GCOVProfiling.cpp:447 @@ -432,3 +446,3 @@ return Filename.str(); } } A quick pass over this yielded something like: if (N->getNumOperands() != 2 &&

Re: [PATCH] D21385: Adjust Registry interface to not require plugins to export a registry

reames added a comment. This seems to have landed a couple of days ago without problem, but if anyone sees any weird effects in shared builds for Linux, this change is probably the culprit. The last time I tried to do something like this, I had to back out my change due to linker errors I

r280190 - PR12298 et al: don't recursively instantiate a template specialization from

Author: rsmith Date: Tue Aug 30 21:15:21 2016 New Revision: 280190 URL: http://llvm.org/viewvc/llvm-project?rev=280190=rev Log: PR12298 et al: don't recursively instantiate a template specialization from within the instantiation of that same specialization. This could previously happen for

r280189 - Concatenate two FileCheck lines in a test.

Author: rtrieu Date: Tue Aug 30 20:57:12 2016 New Revision: 280189 URL: http://llvm.org/viewvc/llvm-project?rev=280189=rev Log: Concatenate two FileCheck lines in a test. 'cc1' is a valid sequence of hexadecimal and sometimes can occur in the path when testing. This can lead to FileCheck

r280187 - clangTooling: Update libdeps: LLVMOptions, since r280118.

Author: chapuni Date: Tue Aug 30 19:46:32 2016 New Revision: 280187 URL: http://llvm.org/viewvc/llvm-project?rev=280187=rev Log: clangTooling: Update libdeps: LLVMOptions, since r280118. Modified: cfe/trunk/lib/Tooling/CMakeLists.txt Modified: cfe/trunk/lib/Tooling/CMakeLists.txt URL:

r280186 - clangTooling depends on ClangDriverOptions since r280118.

Author: chapuni Date: Tue Aug 30 19:46:25 2016 New Revision: 280186 URL: http://llvm.org/viewvc/llvm-project?rev=280186=rev Log: clangTooling depends on ClangDriverOptions since r280118. Modified: cfe/trunk/lib/Tooling/CMakeLists.txt Modified: cfe/trunk/lib/Tooling/CMakeLists.txt URL:

Re: [PATCH] D23657: Remove some false positives when taking the address of packed members

rsmith added inline comments. Comment at: lib/Sema/SemaChecking.cpp:11054 @@ +11053,3 @@ + auto AlignRecord = Context.getTypeAlignInChars(BaseType); + if ((RequiredAlignment > AlignRecord) || + ((Context.toCharUnitsFromBits( Suppose I have

Re: [PATCH] D23325: [WIP] Binding of references to packed fields

rsmith added inline comments. Comment at: include/clang/AST/Expr.h:441 @@ +440,3 @@ + /// Likewise bitfields, we model gl-values referring to packed-fields as + /// an aspect of the value-kind type system. + bool refersToPackedField() const { return getObjectKind() ==

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF added a comment. Are there any remaining issues with this patch? https://reviews.llvm.org/D23385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF added inline comments. Comment at: include/clang/Basic/AttrDocs.td:836 @@ +835,3 @@ + let Content = [{ +This attribute specifies that the variable to which it is attached is intended +to have a `constant initializer

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

Prazek added a comment. Sorry for long delay. I had some issues with git-svn on mac. Repository: rL LLVM https://reviews.llvm.org/D23343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23343: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

This revision was automatically updated to reflect the committed changes. Closed by commit rL280180: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix (authored by Prazek). Changed prior to commit: https://reviews.llvm.org/D23343?vs=68824=69787#toc Repository: rL LLVM

[clang-tools-extra] r280180 - [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix

Author: prazek Date: Tue Aug 30 19:06:55 2016 New Revision: 280180 URL: http://llvm.org/viewvc/llvm-project?rev=280180=rev Log: [clang-tidy] modernize-make-{smart_ptr} private ctor bugfix Summary: Bugfix for 27321. When the constructor of stored pointer type is private then it is invalid to

[PATCH] D24065: [libc++] Don't attempt to dllexport enum class

smeenai created this revision. smeenai added reviewers: abdulras, EricWF, mclow.lists. smeenai added subscribers: cfe-commits, kastiglione. An enum class can't be dllexport'ed, and attempting to do so produces warnings. https://reviews.llvm.org/D24065 Files: include/__config Index:

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

rsmith added inline comments. Comment at: include/clang/Basic/AttrDocs.td:836 @@ +835,3 @@ + let Content = [{ +This attribute specifies that the variable to which it is attached is intended +to have a `constant initializer

r280178 - Don't try to run a test that generates code for x86 if it's not a registered target.

Author: rsmith Date: Tue Aug 30 18:53:34 2016 New Revision: 280178 URL: http://llvm.org/viewvc/llvm-project?rev=280178=rev Log: Don't try to run a test that generates code for x86 if it's not a registered target. Modified: cfe/trunk/test/Driver/cl-pch.c Modified:

Re: r280133 - PR30195: Fix clang-cl attempting to precompile bogus (non-precompilable) input types.

Hopefully r280178 should fix this. On Tue, Aug 30, 2016 at 4:00 PM, Renato Golin wrote: > On 30 August 2016 at 22:44, Renato Golin wrote: > > This breakage was hidden by Duncan's build breakage: > > > >

Re: [PATCH] D23944: Parsing MS pragma intrinsic

rnk accepted this revision. rnk added a comment. lgtm https://reviews.llvm.org/D23944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23734: Add -fprofile-dir= to clang.

nlewycky added inline comments. Comment at: lib/Transforms/Instrumentation/GCOVProfiling.cpp:447 @@ -432,3 +446,3 @@ return Filename.str(); } } compnerd wrote: > It really feels like these two cases can be collapsed. I don't see a great way

Re: [PATCH] D23734: Add -fprofile-dir= to clang.

nlewycky updated this revision to Diff 69778. nlewycky marked 5 inline comments as done. https://reviews.llvm.org/D23734 Files: lib/Transforms/Instrumentation/GCOVProfiling.cpp test/Transforms/GCOVProfiling/three-element-mdnode.ll tools/clang/include/clang/Driver/CC1Options.td

r280174 - [analyzer] Use lazily created buffer in EmptyLocalizationContextChecker

Author: dcoughlin Date: Tue Aug 30 18:07:14 2016 New Revision: 280174 URL: http://llvm.org/viewvc/llvm-project?rev=280174=rev Log: [analyzer] Use lazily created buffer in EmptyLocalizationContextChecker Fix a crash when relexing the underlying memory buffer to find incorrect arguments to

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF marked an inline comment as done. Comment at: utils/TableGen/ClangAttrEmitter.cpp:2794 @@ -2794,1 +2793,3 @@ +if ((*I)->getValueAsBit("Negated")) { + FnName += "Not"; Test += "!"; This is needed so that the `COnly` and `CPlusPlus` entries

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF updated this revision to Diff 69775. EricWF added a comment. Make the attribute C++ only. https://reviews.llvm.org/D23385 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/AttributeList.h

Re: r280104 - Disable clang/test/SemaTemplate/instantiation-depth-default.cpp temporarily for targeting mingw32. It crashes. Investigating.

Thanks, Richard. Conversely, do we need to give sufficient amount of stack to the clang executable whenever this fails? By default, clang.exe has 2MiB (and *-tblgen.exe(s) are gaven 16MiB) of stack on mingw-w64. 10,000,000 bytes on MS-compiled executables. I can easily increase the size. See

Re: r280133 - PR30195: Fix clang-cl attempting to precompile bogus (non-precompilable) input types.

On 30 August 2016 at 22:44, Renato Golin wrote: > This breakage was hidden by Duncan's build breakage: > > http://lab.llvm.org:8011/builders/clang-cmake-aarch64-42vma/builds/11172 Also, http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/9813 Same

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 2 inline comments as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. Okay, many thanks for the code review. May i commit this ? I will add more tests as a follow-up Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23279: clang-reorder-fields

djasper added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:179 @@ +178,3 @@ +const ASTContext , +std::map ) { + assert(InitListEx && "Init list expression is null"); alexshap wrote: >

Re: [PATCH] D23279: clang-reorder-fields

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Now that you can, you should add test cases for the different cases where you cannot reorder fields. Otherwise looks good. Repository: rL LLVM https://reviews.llvm.org/D23279

Re: [PATCH] D23944: Parsing MS pragma intrinsic

agutowski marked an inline comment as done. agutowski added a comment. https://reviews.llvm.org/D23944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 4 inline comments as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:179 @@ +178,3 @@ +const ASTContext , +std::map ) { + assert(InitListEx && "Init list expression is null"); >Also, I don't

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 69769. alexshap marked an inline comment as not done. alexshap added a comment. Check the return value of reorderFieldsInInitListExpr. Repository: rL LLVM https://reviews.llvm.org/D23279 Files: CMakeLists.txt clang-reorder-fields/CMakeLists.txt

Re: [PATCH] D23944: Parsing MS pragma intrinsic

agutowski updated this revision to Diff 69768. agutowski added a comment. Fixed typo https://reviews.llvm.org/D23944 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/IdentifierTable.h include/clang/Parse/Parser.h lib/Parse/ParsePragma.cpp

[PATCH] D24059: NFC: refactor applyObjCProtocolQualifiers from SemaType.cpp to ASTContext so it can be shared.

manmanren created this revision. manmanren added a reviewer: doug.gregor. manmanren added a subscriber: cfe-commits. To construct the canonical type of ObjCTypeParamType, we need to apply qualifiers on ObjCObjectPointerType. The updated applyObjCProtocolQualifiers handles this case by merging

r280169 - Driver: use the canonical static library naming

Author: compnerd Date: Tue Aug 30 17:10:27 2016 New Revision: 280169 URL: http://llvm.org/viewvc/llvm-project?rev=280169=rev Log: Driver: use the canonical static library naming On Windows, static libraries are named lib.lib while import libraries are named .lib. Use the appropriate naming on

Re: [PATCH] D23944: Parsing MS pragma intrinsic

agutowski updated this revision to Diff 69767. agutowski added a comment. Fixed checking if the function is an intrinsic. Updated getBuiltinID description. https://reviews.llvm.org/D23944 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Basic/IdentifierTable.h

Re: [PATCH] D23080: ObjC: Use a new type for ObjC type parameter (patch 3 out of 3)

manmanren updated the summary for this revision. manmanren updated this revision to Diff 69765. manmanren added a comment. This patch is now much simpler with the updated version of https://reviews.llvm.org/D23079. https://reviews.llvm.org/D23080 Files: lib/AST/ASTContext.cpp

Re: [PATCH] D23079: ObjC: Use a new type for ObjC type parameter (patch 2 out of 3)

manmanren updated this revision to Diff 69764. manmanren added a comment. Address Doug's comment. ObjCTypeParamType is a non-canonical type now, it is canonicalized to the underlying type with protocol qualifiers. https://reviews.llvm.org/D23079 Files: include/clang/AST/ASTContext.h

Re: [PATCH] D23279: clang-reorder-fields

djasper added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:178 @@ +177,3 @@ +const InitListExpr *InitListEx, ArrayRef NewFieldsOrder, +const ASTContext , +std::map ) { alexshap wrote: >

Re: [PATCH] D23944: Parsing MS pragma intrinsic

rnk added a comment. One buglet, otherwise looks good. Comment at: lib/Parse/ParsePragma.cpp:2169 @@ +2168,3 @@ +IdentifierInfo *II = Tok.getIdentifierInfo(); +if (II->getBuiltinID() < 2) + PP.Diag(Tok.getLocation(), diag::warn_pragma_intrinsic_builtin)

[PATCH] D24054: Do not validate pch when -fno-validate-pch is set

yaxunl created this revision. yaxunl added reviewers: rsmith, Anastasia. yaxunl added a subscriber: cfe-commits. There is a bug causing pch to be validated even though -fno-validate-pch is set. This patch fixes it. https://reviews.llvm.org/D24054 Files: lib/Serialization/ASTReader.cpp

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF updated this revision to Diff 69761. EricWF added a comment. Address all comments except making the attribute C++ only. https://reviews.llvm.org/D23385 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

EricWF marked 3 inline comments as done. Comment at: include/clang/Basic/AttrDocs.td:836 @@ +835,3 @@ + let Content = [{ +This attribute specifies that the variable to which it is attached is intended +to have a `constant initializer

Re: r280133 - PR30195: Fix clang-cl attempting to precompile bogus (non-precompilable) input types.

On 30 August 2016 at 19:55, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Tue Aug 30 13:55:16 2016 > New Revision: 280133 > > URL: http://llvm.org/viewvc/llvm-project?rev=280133=rev > Log: > PR30195: Fix clang-cl attempting to precompile bogus

Re: [PATCH] D23657: Remove some false positives when taking the address of packed members

aaron.ballman added a comment. Some minor nits; @rsmith may have more substantial comments. Comment at: lib/Sema/SemaChecking.cpp:11039 @@ -11036,2 +11038,3 @@ std::function Action) { + // return; const auto *ME =

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked 5 inline comments as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r280165 - clang-format: Correctly calculate affected ranges when sorting #includes.

Author: djasper Date: Tue Aug 30 16:33:41 2016 New Revision: 280165 URL: http://llvm.org/viewvc/llvm-project?rev=280165=rev Log: clang-format: Correctly calculate affected ranges when sorting #includes. affectedRanges takes a start and an end offset, not offset and length. Modified:

Re: [PATCH] D23905: [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list.

bruno closed this revision. bruno added a comment. Thanks Richard. r280159 https://reviews.llvm.org/D23905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23325: [WIP] Binding of references to packed fields

aaron.ballman added inline comments. Comment at: include/clang/AST/Expr.h:436 @@ -434,1 +435,3 @@ + /// \brief Returns true if this expression is a gl-value that + /// potentially refers to a packed-field. Here packed-field means s/gl-value/glvalue

r280159 - [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list.

Author: bruno Date: Tue Aug 30 16:25:42 2016 New Revision: 280159 URL: http://llvm.org/viewvc/llvm-project?rev=280159=rev Log: [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list. This adds support for modules that require (no-)gnu-inline-asm environment, such as the compiler

r280157 - Fix memory leak by storing returned pointer in std::unique_ptr

Author: rtrieu Date: Tue Aug 30 16:12:48 2016 New Revision: 280157 URL: http://llvm.org/viewvc/llvm-project?rev=280157=rev Log: Fix memory leak by storing returned pointer in std::unique_ptr Modified: cfe/trunk/lib/Tooling/Tooling.cpp Modified: cfe/trunk/lib/Tooling/Tooling.cpp URL:

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

Haha, the joke is on me. I had the opposite opinion two years ago (I guess by virtue of working on the sanitizers for a while, I've come to see them as default libs?). Making the behavior more consistent is good, and the r218541 discussion (+220455) makes me think your patch is good. We end up

Re: [PATCH] D23279: clang-reorder-fields

alexshap added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:83 @@ +82,3 @@ +static void +addReplacement(SourceRange Old, SourceRange New, const ASTContext , + std::map ) { khm, it

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

thakis marked 2 inline comments as done. thakis added a comment. (Just wanted to ask if I'm missing something about these three bullets. I do need to make a few other changes: More tests, parsing for uuid(1-2-3) without quotes + tests, and I also want to add a deprecation warning with a fixit,

Re: [PATCH] D23385: Implement __attribute__((require_constant_initialization)) for safe static initialization.

aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:836 @@ +835,3 @@ + let Content = [{ +This attribute specifies that the variable to which it is attached is intended +to have a `constant initializer

Re: [PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a comment. In https://reviews.llvm.org/D23852#525291, @doug.gregor wrote: > This will work, but it's *really* unfortunate to put tentative parsing into > this code path because tentative parsing is far from free, and

Re: [PATCH] D24042: [test] Add libLTO as a clang test dependency on Darwin

Done in r280149 (revert this commit) and r280150 (use fake libLTO.dylib). thanks, vedant > On Aug 30, 2016, at 1:12 PM, Mehdi Amini wrote: > > Alternatively, since you only need the presence of a file named libLTO for > the driver to do its magic, test can create an

r280149 - Revert "[test] Add libLTO as a clang test dependency on Darwin"

Author: vedantk Date: Tue Aug 30 15:36:48 2016 New Revision: 280149 URL: http://llvm.org/viewvc/llvm-project?rev=280149=rev Log: Revert "[test] Add libLTO as a clang test dependency on Darwin" This reverts commit r280142. Mehdi suggested a better way to fix up the test: just create a fake

r280150 - [test] Pass a fake libLTO.dylib to a driver test which depends on it

Author: vedantk Date: Tue Aug 30 15:36:50 2016 New Revision: 280150 URL: http://llvm.org/viewvc/llvm-project?rev=280150=rev Log: [test] Pass a fake libLTO.dylib to a driver test which depends on it This makes it possible to run 'check-clang' on Darwin without building libLTO.dylib. See r280142

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a reviewer: djasper. alexshap updated this revision to Diff 69748. alexshap added a comment. Address @djasper 's comments Repository: rL LLVM https://reviews.llvm.org/D23279 Files: CMakeLists.txt clang-reorder-fields/CMakeLists.txt

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

aaron.ballman added a comment. In https://reviews.llvm.org/D23895#529275, @thakis wrote: > > There are things missing from this patch as well. To wit: > > > > > > - Attributes.h needs to know about this attribute syntax, and > > `hasAttribute()` needs to support it (this hooks into

Re: [PATCH] D23905: [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D23905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

aaron.ballman requested changes to this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision now requires changes to proceed. Thank you for working on this! Comment at:

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

bruno added a subscriber: bruno. bruno added a comment. Regardless of the way we decide to go with this, it would be nice if a driver level warning is used to tell users about any non-obvious assumed behavior when these flags are used together. https://reviews.llvm.org/D24048

Re: [PATCH] D24042: [test] Add libLTO as a clang test dependency on Darwin

Alternatively, since you only need the presence of a file named libLTO for the driver to do its magic, test can create an empty file named libLTO.dylib and use the -ccc-install-dir to make sure the right flag is passed. > On Aug 30, 2016, at 10:40 AM, Vedant Kumar wrote: > >

Re: [PATCH] D23895: [ms] Add support for parsing uuid as a MS attribute

thakis marked 3 inline comments as done. thakis added a comment. > There are things missing from this patch as well. To wit: > > - Attributes.h needs to know about this attribute syntax, and > `hasAttribute()` needs to support it (this hooks into `__has_attribute` > support). > -

Re: [PATCH] D24042: [test] Add libLTO as a clang test dependency on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rL280142: [test] Add libLTO as a clang test dependency on Darwin (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D24042?vs=69723=69743#toc Repository: rL LLVM

r280142 - [test] Add libLTO as a clang test dependency on Darwin

Author: vedantk Date: Tue Aug 30 14:57:40 2016 New Revision: 280142 URL: http://llvm.org/viewvc/llvm-project?rev=280142=rev Log: [test] Add libLTO as a clang test dependency on Darwin Running 'check-clang' on a stock checkout of llvm+clang doesn't work on Darwin, because

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

Filipe, You say that, but the darwin driver’s behavior is different from the FreeBSD or GNUTools behavior. This patch provides the GNUTools & FreeBSD behavior via the Darwin driver. -Chris > On Aug 30, 2016, at 12:26 PM, Filipe Cabecinhas > wrote: > > I

Re: [PATCH] D24042: [test] Add libLTO as a clang test dependency on Darwin

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Nice, LGTM https://reviews.llvm.org/D24042 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23746: Basic/Targets.cpp: Add polaris10 and polaris11 gpus

This revision was automatically updated to reflect the committed changes. Closed by commit rL280120: Basic/Targets.cpp: Add polaris10 and polaris11 gpus (authored by olesalscheider). Changed prior to commit: https://reviews.llvm.org/D23746?vs=69485=69730#toc Repository: rL LLVM

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

I don't think so. "No default libs" should mean "no default libs", not "some default libs". Maybe you're using an alternate sanitizer lib or something, hence usage of that flag. Thank you, Filipe On Tuesday, 30 August 2016, Chris Bieneman via cfe-commits < cfe-commits@lists.llvm.org> wrote: >

r280136 - PR29166: when merging declarations with typedef names for linkage purposes,

Author: rsmith Date: Tue Aug 30 14:13:18 2016 New Revision: 280136 URL: http://llvm.org/viewvc/llvm-project?rev=280136=rev Log: PR29166: when merging declarations with typedef names for linkage purposes, don't assume that the anonymous struct will be part of the most recent declaration of the

r280134 - Unrevert r280035 now that the clang-cl bug it exposed has been fixed by

Author: rsmith Date: Tue Aug 30 14:06:26 2016 New Revision: 280134 URL: http://llvm.org/viewvc/llvm-project?rev=280134=rev Log: Unrevert r280035 now that the clang-cl bug it exposed has been fixed by r280133. Original commit message: C++ Modules TS: driver support for building modules. This

Re: r280104 - Disable clang/test/SemaTemplate/instantiation-depth-default.cpp temporarily for targeting mingw32. It crashes. Investigating.

On Tue, Aug 30, 2016 at 8:38 AM, NAKAMURA Takumi via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: chapuni > Date: Tue Aug 30 10:38:18 2016 > New Revision: 280104 > > URL: http://llvm.org/viewvc/llvm-project?rev=280104=rev > Log: > Disable

[PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

beanz created this revision. beanz added reviewers: zaks.anna, kubabrecka, bogner. beanz added a subscriber: cfe-commits. The -nodefaultlibs and -nostdlib flags suppress all the runtime libraries that the driver puts on the link line. This feels wrong. If a user specifies "-fsanitize=" I think

r280133 - PR30195: Fix clang-cl attempting to precompile bogus (non-precompilable) input types.

Author: rsmith Date: Tue Aug 30 13:55:16 2016 New Revision: 280133 URL: http://llvm.org/viewvc/llvm-project?rev=280133=rev Log: PR30195: Fix clang-cl attempting to precompile bogus (non-precompilable) input types. Modified: cfe/trunk/include/clang/Driver/Types.h

Re: [PATCH] D23944: Parsing MS pragma intrinsic

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but you should wait for @rnk to accept as well. https://reviews.llvm.org/D23944 ___ cfe-commits mailing list

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

Eugene.Zelenko added a subscriber: aaron.ballman. Eugene.Zelenko added a comment. I don't have further comments, but as non-English speaker and mediocre writer, I would like see other people comments. May be @aaron.ballman could help if Alexander is busy? https://reviews.llvm.org/D23918

r280127 - typo + indentation [NFC]

Author: etienneb Date: Tue Aug 30 13:38:25 2016 New Revision: 280127 URL: http://llvm.org/viewvc/llvm-project?rev=280127=rev Log: typo + indentation [NFC] Modified: cfe/trunk/lib/Driver/MSVCToolChain.cpp cfe/trunk/lib/Driver/ToolChains.h Modified: cfe/trunk/lib/Driver/MSVCToolChain.cpp

Re: [PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

bruno added a comment. Ping! https://reviews.llvm.org/D23852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23905: [Modules] Add 'gnuinlineasm' to the 'requires-declaration' feature-list.

bruno added a comment. Ping! https://reviews.llvm.org/D23905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] r280121 - configure.py: Add polaris10 and polaris11

Author: olesalscheider Date: Tue Aug 30 13:00:41 2016 New Revision: 280121 URL: http://llvm.org/viewvc/llvm-project?rev=280121=rev Log: configure.py: Add polaris10 and polaris11 Modified: libclc/trunk/configure.py Modified: libclc/trunk/configure.py URL:

r280120 - Basic/Targets.cpp: Add polaris10 and polaris11 gpus

Author: olesalscheider Date: Tue Aug 30 13:00:22 2016 New Revision: 280120 URL: http://llvm.org/viewvc/llvm-project?rev=280120=rev Log: Basic/Targets.cpp: Add polaris10 and polaris11 gpus Differential Revision: https://reviews.llvm.org/D23746 Modified: cfe/trunk/lib/Basic/Targets.cpp

[clang-tools-extra] r280119 - [Release notes] Fix highlighting.

Author: eugenezelenko Date: Tue Aug 30 12:47:07 2016 New Revision: 280119 URL: http://llvm.org/viewvc/llvm-project?rev=280119=rev Log: [Release notes] Fix highlighting. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst URL:

Re: [PATCH] D23837: Fix colored diagnostics from tools

This revision was automatically updated to reflect the committed changes. Closed by commit rL280118: Fix colored diagnostics from tools (authored by ogoffart). Changed prior to commit: https://reviews.llvm.org/D23837?vs=69225=69725#toc Repository: rL LLVM https://reviews.llvm.org/D23837

r280118 - Fix colored diagnostics from tools

Author: ogoffart Date: Tue Aug 30 12:42:29 2016 New Revision: 280118 URL: http://llvm.org/viewvc/llvm-project?rev=280118=rev Log: Fix colored diagnostics from tools r271042 changed the way the diagnostic arguments are parsed. It assumes that the diagnostics options were already parsed by the

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r279164 and r279486. https://reviews.llvm.org/D23492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23492: Make function local tags visible.

Yes please On 30 Aug 2016 10:33 am, "Vassil Vassilev" wrote: > v.g.vassilev added a comment. > > Thanks! Shall I close this? > > > https://reviews.llvm.org/D23492 > > > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24042: [test] Add libLTO as a clang test dependency on Darwin

vsk created this revision. vsk added a reviewer: bruno. vsk added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. Running 'check-clang' on a stock checkout of llvm+clang doesn't work on Darwin, because test/Driver/darwin-ld-lto.c can't find libLTO.dylib. Add libLTO as a clang

Re: [PATCH] D23987: [Coverage] Suppress creating a code region if the same area is covered by an expansion region.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Lgtm! https://reviews.llvm.org/D23987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >