Re: [PATCH] D24446: Implement revision to LWG#2758

2016-09-11 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: include/string:615 @@ +614,3 @@ + +// template +// struct __can_be_converted_to_string_view : public _LIBCPP_BOOL_CONSTANT( These bits will be removed. Comment at:

r281189 - [MS ABI] Add /include directives for dynamic TLS

2016-09-11 Thread David Majnemer via cfe-commits
Author: majnemer Date: Sun Sep 11 21:51:43 2016 New Revision: 281189 URL: http://llvm.org/viewvc/llvm-project?rev=281189=rev Log: [MS ABI] Add /include directives for dynamic TLS MSVC emits /include directives in the .drective section for the __dyn_tls_init function (decorated as

Re: [PATCH] D21968: [libcxx] Externally threaded libc++ variant - Take 2

2016-09-11 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281179: [libcxx] Introduce an externally-threaded libc++ variant. (authored by asiri). Changed prior to commit: https://reviews.llvm.org/D21968?vs=70840=70969#toc Repository: rL LLVM

[libcxx] r281179 - [libcxx] Introduce an externally-threaded libc++ variant.

2016-09-11 Thread Asiri Rathnayake via cfe-commits
Author: asiri Date: Sun Sep 11 16:46:40 2016 New Revision: 281179 URL: http://llvm.org/viewvc/llvm-project?rev=281179=rev Log: [libcxx] Introduce an externally-threaded libc++ variant. This patch further decouples libc++ from pthread, allowing libc++ to be built against other threading systems.

[PATCH] D24444: [clang-tidy] modernize-use-default default constructor bugfix

2016-09-11 Thread Malcolm Parsons via cfe-commits
malcolm.parsons created this revision. malcolm.parsons added a reviewer: klimek. malcolm.parsons added subscribers: cfe-commits, klimek, alexfh. Only member initializers that are written should prevent using '= default' on a default constructor. https://reviews.llvm.org/D2 Files:

Re: [PATCH] D24426: DebugInfo: Pass non-zero alignment to DIBuilder only if aligment was forced

2016-09-11 Thread Victor Leschuk via cfe-commits
vleschuk retitled this revision from "DebugInfo: use llvm::DINode::FlagAlignment to mark forcibly aligned data" to "DebugInfo: Pass non-zero alignment to DIBuilder only if aligment was forced". vleschuk updated the summary for this revision. vleschuk updated this revision to Diff 70965. vleschuk

Re: [PATCH] D24395: Align declarations that are preceded by different number of commas.

2016-09-11 Thread Nikola Smiljanić via cfe-commits
nikola abandoned this revision. nikola added a comment. Thanks for letting me know, that patch looks more complete so I'll abandon this. I hope it lands soon! https://reviews.llvm.org/D24395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24439: [Clang] Fix some Clang-tidy modernize-use-bool-literals and Include What You Use warnings; other minor fixes

2016-09-11 Thread Piotr Padlewski via cfe-commits
Prazek added a subscriber: Prazek. Prazek accepted this revision. Prazek added a reviewer: Prazek. Prazek added a comment. This revision is now accepted and ready to land. Lgtm Repository: rL LLVM https://reviews.llvm.org/D24439 ___ cfe-commits