Re: [PATCH] D23765: Fix for clang PR 29087

sepavloff added a subscriber: sepavloff. sepavloff added a comment. You need to provide a test for the fix. https://reviews.llvm.org/D23765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

r281587 - Update clang unittests for rL281586.

Author: wmi Date: Thu Sep 15 01:31:30 2016 New Revision: 281587 URL: http://llvm.org/viewvc/llvm-project?rev=281587&view=rev Log: Update clang unittests for rL281586. The change in rL281586 is in llvm component and tests updated here are in clang component, so I have to commit them consecutively.

r281582 - Builtins.def: Explicitly undef finitef, to appease mingw. It defines finitef as alias of _finitef.

Author: chapuni Date: Thu Sep 15 00:11:43 2016 New Revision: 281582 URL: http://llvm.org/viewvc/llvm-project?rev=281582&view=rev Log: Builtins.def: Explicitly undef finitef, to appease mingw. It defines finitef as alias of _finitef. Modified: cfe/trunk/include/clang/Basic/Builtins.def Modif

[PATCH] D24600: [libc++] Add _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY to support GCC ABI compatibility

EricWF created this revision. EricWF added reviewers: mclow.lists, eugenis, danalbert, jroelofs. EricWF added a subscriber: cfe-commits. Herald added subscribers: mgorny, beanz. GCC and Clang handle visibility attributes on the out-of-line definition of externally instantiated templates different

[PATCH] D24599: Add 'inline' but not _LIBCPP_INLINE_VISIBILITY to basic_string's destructor

EricWF created this revision. EricWF added reviewers: mclow.lists, laxmansole, hiraditya, dblaikie. EricWF added a subscriber: cfe-commits. r280944 attempted to add both `inline` and `_LIBCPP_INLINE_VISIBILITY` to basic_string's destructor in order to achieve better inlining behavior. Unfortunat

[PATCH] D24598: Separate builtins for x84-64 and i386; implement __mulh and __umulh

agutowski created this revision. agutowski added reviewers: rnk, thakis, majnemer. agutowski added a subscriber: cfe-commits. We need x86-64-specific builtins if we want to implement some of the MS intrinsics - winnt.h contains definitions of some functions for i386, but not for x86-64 (for exam

Re: [PATCH] D24289: Add warning when assigning enums to bitfields without an explicit unsigned underlying type

sashab added a comment. Pinging for another LGTM since I have added it to -Wall and added a portability comment to the error message :) https://reviews.llvm.org/D24289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[libclc] r281566 - math: Implement tgamma

Author: awatry Date: Wed Sep 14 19:17:34 2016 New Revision: 281566 URL: http://llvm.org/viewvc/llvm-project?rev=281566&view=rev Log: math: Implement tgamma Signed-off-by: Aaron Watry Reviewed-by: Tom Stellard Added: libclc/trunk/generic/include/clc/math/tgamma.h libclc/trunk/generic/in

[libclc] r281563 - Add ADDR_SPACE parameter to _CLC_V_V_VP_VECTORIZE

Author: awatry Date: Wed Sep 14 19:17:22 2016 New Revision: 281563 URL: http://llvm.org/viewvc/llvm-project?rev=281563&view=rev Log: Add ADDR_SPACE parameter to _CLC_V_V_VP_VECTORIZE This macro is currently unused, but I plan to use it shortly. The previous form did casts of pointers without an

[libclc] r281565 - math: Implement lgamma

Author: awatry Date: Wed Sep 14 19:17:31 2016 New Revision: 281565 URL: http://llvm.org/viewvc/llvm-project?rev=281565&view=rev Log: math: Implement lgamma Just use lgamma_r and ignore the value returned in the second argument Signed-off-by: Aaron Watry Reviewed-by: Tom Stellard Added: li

[libclc] r281564 - math: Implement lgamma_r

Author: awatry Date: Wed Sep 14 19:17:28 2016 New Revision: 281564 URL: http://llvm.org/viewvc/llvm-project?rev=281564&view=rev Log: math: Implement lgamma_r Ported from the amd-builtins branch, which is itself based on the Sun Microsystems implementation. Signed-off-by: Aaron Watry Reviewed-by

Re: [libcxx] r280944 - Added 'inline' attribute to basic_string's destructor

FYI I had to revert this in r281562 because of: * http://llvm.org/PR30341 which breaks the LLVM build. * http://llvm.org/PR30391 which breaks ABI compatibility when libc++.so is compiled with GCC. I'm working on fixing these issues so that this patch may be recommitted. The GCC issue also made wo

[libcxx] r281562 - Revert r280944 - Added 'inline' attribute to basic_string's destructor

Author: ericwf Date: Wed Sep 14 18:52:01 2016 New Revision: 281562 URL: http://llvm.org/viewvc/llvm-project?rev=281562&view=rev Log: Revert r280944 - Added 'inline' attribute to basic_string's destructor This patch causes a couple of issues: 1) It triggers http://llvm.org/PR30341. Although the b

Re: [PATCH] D23765: Fix for clang PR 29087

twoh added a comment. Ping. https://reviews.llvm.org/D23765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r281557 - Revert r281457 "Supports adding insertion around non-insertion replacements."

Author: tra Date: Wed Sep 14 18:03:06 2016 New Revision: 281557 URL: http://llvm.org/viewvc/llvm-project?rev=281557&view=rev Log: Revert r281457 "Supports adding insertion around non-insertion replacements." Commit was breaking our internal tests. Modified: cfe/trunk/include/clang/Tooling/Co

Re: [PATCH] D24590: [test-suite] [CUDA] Update README.

This revision was automatically updated to reflect the committed changes. Closed by commit rL281552: [test-suite] [CUDA] Update README. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D24590?vs=71445&id=71457#toc Repository: rL LLVM https://reviews.llvm.org/D24590 F

Re: [PATCH] D24590: [test-suite] [CUDA] Update README.

jlebar marked an inline comment as done. jlebar added a comment. Will add. Thank you for the reviews! https://reviews.llvm.org/D24590 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r281550 - [clang-cl] Accept the joined equals version of -resource-dir=

Author: rnk Date: Wed Sep 14 17:31:24 2016 New Revision: 281550 URL: http://llvm.org/viewvc/llvm-project?rev=281550&view=rev Log: [clang-cl] Accept the joined equals version of -resource-dir= lib/Tooling injects this argument without regard for what driver syntax is in use. Modified: cfe/tru

Re: [PATCH] D24590: [test-suite] [CUDA] Update README.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM Comment at: External/CUDA/README:58 @@ +57,3 @@ + There's a cuda-tests-simple target that excludes tests that take a long time + to build (thrust). + It may

Re: [PATCH] D24589: [test-suite] [CUDA] Add and tests.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D24589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

LGTM On 14 Sep 2016 2:36 pm, "Dimitry Andric" wrote: dim added a comment. FWIW, I have already imported this fix into FreeBSD two weeks ago: https://svnweb.freebsd.org/changeset/base/304960 It has been working fine for us. https://reviews.llvm.org/D23921 __

Re: [PATCH] D22057: Prevent devirtualization of calls to un-instantiated functions.

Sunil_Srivastava updated this revision to Diff 71432. Sunil_Srivastava added a comment. This is an update to address points raised by Richard Smith: 1. The bit and the access functions have been renamed from MarkedForPendingInstantiation to InstantiationIsPending. 2. It closely, though not entir

Re: [PATCH] D24513: [AMDGPU] Expose flat work group size, register and wave control attributes

kzhuravl added inline comments. Comment at: include/clang/Basic/Attr.td:1067 @@ +1066,3 @@ + let Spellings = [GNU<"amdgpu_waves_per_eu">]; + let Args = [UnsignedArgument<"Min">, VariadicUnsignedArgument<"Max">]; + let Documentation = [AMDGPUWavesPerEUDocs]; aar

Re: [PATCH] D24513: [AMDGPU] Expose flat work group size, register and wave control attributes

kzhuravl updated this revision to Diff 71449. kzhuravl marked 15 inline comments as done. kzhuravl added a comment. Address review feedback https://reviews.llvm.org/D24513 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td lib/C

Re: [PATCH] D24588: [CUDA] Make __clang_cuda_cmath.h compatible with libc++.

This revision was automatically updated to reflect the committed changes. Closed by commit rL281544: [CUDA] Make __clang_cuda_cmath.h compatible with libc++. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D24588?vs=71443&id=71447#toc Repository: rL LLVM https://revi

Re: [PATCH] D24581: [CUDA] Add test checking our ability to take a function pointer to a __global__ function on the host side.

This revision was automatically updated to reflect the committed changes. Closed by commit rL281543: [CUDA] Add test checking our ability to take a function pointer to a… (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D24581?vs=71423&id=71446#toc Repository: rL LLVM

r281543 - [CUDA] Add test checking our ability to take a function pointer to a __global__ function on the host side.

Author: jlebar Date: Wed Sep 14 16:50:11 2016 New Revision: 281543 URL: http://llvm.org/viewvc/llvm-project?rev=281543&view=rev Log: [CUDA] Add test checking our ability to take a function pointer to a __global__ function on the host side. Summary: This functionality is used by Thrust. Reviewer

r281544 - [CUDA] Make __clang_cuda_cmath.h compatible with libc++.

Author: jlebar Date: Wed Sep 14 16:50:14 2016 New Revision: 281544 URL: http://llvm.org/viewvc/llvm-project?rev=281544&view=rev Log: [CUDA] Make __clang_cuda_cmath.h compatible with libc++. Summary: We need to add a bunch more "using"s, which weren't necessary with libstdc++. Once this is in I c

[PATCH] D24590: [test-suite] [CUDA] Update README.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added a subscriber: cfe-commits. Fix typo (s/Externals/External/), and mention cuda-tests-simple. https://reviews.llvm.org/D24590 Files: External/CUDA/README Index: External/CUDA/README

Re: [PATCH] D24588: [CUDA] Make __clang_cuda_cmath.h compatible with libc++.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D24588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D24588: [CUDA] Make __clang_cuda_cmath.h compatible with libc++.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added a subscriber: cfe-commits. We need to add a bunch more "using"s, which weren't necessary with libstdc++. Once this is in I can check in a test to the test-suite. https://reviews.llvm.org/D24588 Files: clang/lib/Headers/_

Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

dim added a comment. FWIW, I have already imported this fix into FreeBSD two weeks ago: https://svnweb.freebsd.org/changeset/base/304960 It has been working fine for us. https://reviews.llvm.org/D23921 ___ cfe-commits mailing list cfe-commits@lists

Re: [PATCH] D24584: Do not warn about format strings that are indexed string literals.

meikeb updated this revision to Diff 71438. meikeb added a comment. Fix typos in commit message. https://reviews.llvm.org/D24584 Files: lib/Sema/SemaChecking.cpp test/Sema/format-strings.c Index: test/Sema/format-strings.c ===

Re: [PATCH] D24584: Do not warn about format strings that are indexed string literals.

meikeb added a comment. This is the same as https://reviews.llvm.org/D23820 besides that I added myself in the commit message as "Patch by". https://reviews.llvm.org/D23820 was reverted in https://reviews.llvm.org/D24579 because srhines' commit took authorship of this patch. https://reviews.l

r281540 - Add some MS aliases for existing intrinsics

Author: agutowski Date: Wed Sep 14 16:19:43 2016 New Revision: 281540 URL: http://llvm.org/viewvc/llvm-project?rev=281540&view=rev Log: Add some MS aliases for existing intrinsics Reviewers: thakis, compnerd, majnemer, rsmith, rnk Subscribers: alexshap, cfe-commits Differential Revision: https:

Re: [PATCH] D24330: Add some MS aliases for existing intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rL281540: Add some MS aliases for existing intrinsics (authored by agutowski). Changed prior to commit: https://reviews.llvm.org/D24330?vs=71404&id=71437#toc Repository: rL LLVM https://reviews.llvm.o

[PATCH] D24584: Do not warn about format strings that are indexed string literals.

meikeb created this revision. meikeb added a reviewer: rsmith. meikeb added subscribers: cfe-commits, srhines. The warning for a format string not being a sting literal and therefore being potentially insecure is overly strict for indecies into sting literals. This fix checks if the index into the

Re: [PATCH] D24581: [CUDA] Add test checking our ability to take a function pointer to a __global__ function on the host side.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D24581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

EricWF added a comment. LGTM after addressing the inline comments. Comment at: src/cxa_thread_atexit.cpp:70 @@ +69,3 @@ +while (auto head = dtors) { + dtors = head->next; + head->dtor(head->obj); tavianator wrote: > EricWF wrote: > > tavianator wro

Re: [PATCH] D24467: Fix an error after D21678

ahatanak added inline comments. Comment at: llvm/tools/clang/test/Sema/vecshift.c:56 @@ +55,3 @@ + + vc4 = vc4 << vc8; // expected-error {{vector operands do not have the same number of elements}} + vi4 = vi4 << vuc8; // expected-error {{vector operands do not have the same nu

[PATCH] D24581: [CUDA] Add test checking our ability to take a function pointer to a __global__ function on the host side.

jlebar created this revision. jlebar added a reviewer: tra. jlebar added a subscriber: cfe-commits. This functionality is used by Thrust. https://reviews.llvm.org/D24581 Files: clang/test/SemaCUDA/reference-to-kernel-fn.cu Index: clang/test/SemaCUDA/reference-to-kernel-fn.cu =

Re: [PATCH] D24579: Revert "Do not warn about format strings that are indexed string literals."

This revision was automatically updated to reflect the committed changes. Closed by commit rL281530: Revert "Do not warn about format strings that are indexed string literals." (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D24579?vs=71417&id=71419#toc Repository: r

r281530 - Revert "Do not warn about format strings that are indexed string literals."

Author: srhines Date: Wed Sep 14 15:20:14 2016 New Revision: 281530 URL: http://llvm.org/viewvc/llvm-project?rev=281530&view=rev Log: Revert "Do not warn about format strings that are indexed string literals." Summary: This reverts r281527 because I messed up the attribution. Reviewers: srhines

Re: [PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

rsmith added a comment. I think you'll also need to update the `ASTDeclReader` to merge `VarDecl` definitions together if it reads a definition and there already is one in the AST. I note that right now `Sema::AddInitializerToDecl` permits multiple definitions of a `VarDecl`, which doesn't seem

[PATCH] D24579: Revert "Do not warn about format strings that are indexed string literals."

srhines created this revision. srhines added a subscriber: cfe-commits. This reverts r281527 because I messed up the attribution. https://reviews.llvm.org/D24579 Files: lib/Sema/SemaChecking.cpp test/Sema/format-strings.c Index: test/Sema/format-strings.c ===

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

This revision was automatically updated to reflect the committed changes. Closed by commit rL281527: Do not warn about format strings that are indexed string literals. (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D23820?vs=71286&id=71416#toc Repository: rL LLVM h

r281527 - Do not warn about format strings that are indexed string literals.

Author: srhines Date: Wed Sep 14 15:05:20 2016 New Revision: 281527 URL: http://llvm.org/viewvc/llvm-project?rev=281527&view=rev Log: Do not warn about format strings that are indexed string literals. Summary: The warning for a format string not being a sting literal and therefore being potential

Re: [PATCH] D24372: [libcxx] Sprinkle constexpr over compressed_pair

static_cast(t) also works as a constexpr C++11 forward. On Sep 13, 2016 4:07 PM, "Keno Fischer" wrote: > loladiro added inline comments. > > > Comment at: include/memory:2137 > @@ -2132,3 +2136,3 @@ > > -_LIBCPP_INLINE_VISIBILITY > +_LIBCPP_INLINE_VISIBILITY _LIBCPP_CONS

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

srhines added a comment. I will take care of submitting this. Thanks for the reviews everybody! https://reviews.llvm.org/D23820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24518: Correct assert text in DeclGroup::getSingleDecl()

This revision was automatically updated to reflect the committed changes. Closed by commit rL281525: Correct assert text in DeclGroup::getSingleDecl() (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D24518?vs=71188&id=71414#toc Repository: rL LLVM https://reviews.ll

r281525 - Correct assert text in DeclGroup::getSingleDecl()

Author: omtcyfz Date: Wed Sep 14 14:59:26 2016 New Revision: 281525 URL: http://llvm.org/viewvc/llvm-project?rev=281525&view=rev Log: Correct assert text in DeclGroup::getSingleDecl() Assert text for getSingleDecl() is inaccurate. Appears to have been copy pasted from getDeclGroup(). Patch by Be

Re: [PATCH] D22452: [libcxx] Fix last_write_time tests for filesystems that don't support negative and very large times.

EricWF added a comment. Thanks. I'll update this patch today. https://reviews.llvm.org/D22452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

meikeb marked an inline comment as done. meikeb added a comment. Thanks for reviewing my patch! It would be great if someone could submit this patch for me. https://reviews.llvm.org/D23820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

Re: [PATCH] D24518: Correct assert text in DeclGroup::getSingleDecl()

brtaylor92 added a comment. I don't have commit access. @alexfh could you please land the patch? https://reviews.llvm.org/D24518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24467: Fix an error after D21678

vbyakovlcl added inline comments. Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8790 @@ -8774,3 +8789,3 @@ S.Context.getExtVectorType(RHSEleType, LHSVecTy->getNumElements()); RHS = S.ImpCastExprToType(RHS.get(), VecTy, CK_VectorSplat); } ahatan

Re: [PATCH] D24574: clang-format: [JS] ASI insertion after boolean literals.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Interesting.. Would have expected true/false to be literals as well, but ok :). https://reviews.llvm.org/D24574 ___ cfe-commits mailing list cf

Re: [PATCH] D21506: [analyzer] Block in critical section

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Future steps: How do we plan to bring this checker out of alpha? Have you evaluated it on large codebases? Repository: rL LLVM https://reviews.llvm.org/D21506 _

Re: [PATCH] D21506: [analyzer] Block in critical section

zaks.anna added a comment. Do you have commit access or should we commit? Repository: rL LLVM https://reviews.llvm.org/D21506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24467: Fix an error after D21678

ahatanak added inline comments. Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8751 @@ -8747,3 +8750,3 @@ // OpenCL v1.1 s6.3.j says that the operands need to be integers. if (!LHSEleType->isIntegerType()) { Should we mention that any vectors used as s

Re: [PATCH] D24330: Add some MS aliases for existing intrinsics

agutowski updated this revision to Diff 71404. agutowski added a comment. Fix doxygen comment https://reviews.llvm.org/D24330 Files: include/clang/Basic/Builtins.def include/clang/Basic/Builtins.h include/clang/Basic/BuiltinsX86.def lib/Basic/Targets.cpp lib/CodeGen/CGBuiltin.cpp li

Re: [PATCH] D24330: Add some MS aliases for existing intrinsics

agutowski marked an inline comment as done. agutowski added a comment. https://reviews.llvm.org/D24330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24470: [analyzer] scan-build-py: Remove relative path hack for SATestsBuild.py

This revision was automatically updated to reflect the committed changes. Closed by commit rL281516: [analyzer] scan-build-py: Remove relative path hack for SATestsBuild.py (authored by dcoughlin). Changed prior to commit: https://reviews.llvm.org/D24470?vs=71046&id=71401#toc Repository: rL

r281516 - [analyzer] scan-build-py: Remove relative path hack for SATestsBuild.py

Author: dcoughlin Date: Wed Sep 14 13:14:11 2016 New Revision: 281516 URL: http://llvm.org/viewvc/llvm-project?rev=281516&view=rev Log: [analyzer] scan-build-py: Remove relative path hack for SATestsBuild.py Remove the relative path hack in scan-build-py that converts a fully qualified directory

Re: [PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

aaron.ballman added inline comments. Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:22-23 @@ +21,4 @@ + Finder->addMatcher( + declRefExpr(hasDeclaration(functionDecl(namedDecl(hasName("::rand")), + parameterCountIs(0 +

Re: [PATCH] D24526: [Release notes] Mention readability-container-size-empty improvements

This revision was automatically updated to reflect the committed changes. Closed by commit rL281510: [Release notes] Mention readability-container-size-empty improvements. (authored by eugenezelenko). Changed prior to commit: https://reviews.llvm.org/D24526?vs=71250&id=71394#toc Repository:

[clang-tools-extra] r281510 - [Release notes] Mention readability-container-size-empty improvements.

Author: eugenezelenko Date: Wed Sep 14 12:41:51 2016 New Revision: 281510 URL: http://llvm.org/viewvc/llvm-project?rev=281510&view=rev Log: [Release notes] Mention readability-container-size-empty improvements. Differential revision: https://reviews.llvm.org/D24526 Modified: clang-tools-extr

Re: [PATCH] D24526: [Release notes] Mention readability-container-size-empty improvements

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:94 @@ +93,3 @@ + `_ check + supports arbitrary containers with ``empty()`` and ``size()`` methods. + al

Re: [PATCH] D24513: [AMDGPU] Expose flat work group size, register and wave control attributes

aaron.ballman requested changes to this revision. This revision now requires changes to proceed. Comment at: include/clang/Basic/Attr.td:1054-1056 @@ -1058,3 +1053,5 @@ +// // FIXME: This should be for OpenCLKernelFunction, but is not to // workaround needing to see kernel attri

r281509 - Convert finite to builtin

Author: dehao Date: Wed Sep 14 12:34:14 2016 New Revision: 281509 URL: http://llvm.org/viewvc/llvm-project?rev=281509&view=rev Log: Convert finite to builtin Summary: This patch converts finite/__finite to builtin functions so that it will be inlined by compiler. Reviewers: hfinkel, davidxl, ef

[PATCH] D24574: clang-format: [JS] ASI insertion after boolean literals.

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. Before when a semicolon was missing after a boolean literal: a = true return 1; clang-format would parse this as one line and format as: a = tr

Re: [PATCH] D24513: [AMDGPU] Expose flat work group size, register and wave control attributes

kzhuravl updated this revision to Diff 71382. kzhuravl added a comment. Fix minor typos https://reviews.llvm.org/D24513 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/TargetInfo.cpp lib/Sema/SemaDeclAttr.cpp

[PATCH] D24573: [CUDA] Do a better job at detecting wrong-side calls.

jlebar created this revision. jlebar added a reviewer: rsmith. jlebar added subscribers: tra, cfe-commits. Move CheckCUDACall from ActOnCallExpr and BuildDeclRefExpr to DiagnoseUseOfDecl. This lets us catch some edge cases we were missing, specifically around class operators. This necessitates a

[PATCH] D24572: [clang-tidy] Clean up code after applying replacements.

alexfh created this revision. alexfh added reviewers: ioeric, hokein. alexfh added a subscriber: cfe-commits. Remove empty namespaces and initializer list commas / colons in affected ranges. A strawman patch: proper options for enabling the cleanup and specifying the format style are needed. http

[PATCH] D24571: [CUDA] Disallow overloading destructors.

jlebar created this revision. jlebar added a reviewer: rsmith. jlebar added subscribers: tra, cfe-commits. We'd attempted to allow this, but turns out we were doing a very bad job. :) Making this work properly would be a giant change in clang. For example, we'd need to make CXXRecordDecl::getDe

Re: [PATCH] D21506: [analyzer] Block in critical section

zdtorok added a comment. You are right NoQ, thank you for the remark, I've upload a new diff containing a fix for the integer underflow case. Repository: rL LLVM https://reviews.llvm.org/D21506 ___ cfe-commits mailing list cfe-commits@lists.llvm

Re: [PATCH] D21506: [analyzer] Block in critical section

zdtorok updated this revision to Diff 71375. zdtorok added a comment. Herald added subscribers: mgorny, beanz. Fixed possible integer-underflow in case of unexpected unlocking function. Also added test for this. Repository: rL LLVM https://reviews.llvm.org/D21506 Files: include/clang/Stat

Re: [PATCH] D24467: Fix an error after D21678

vbyakovlcl added inline comments. Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8733 @@ -8731,2 +8732,3 @@ if (!IsCompAssign) { -LHS = S.UsualUnaryConversions(LHS.get()); +if (S.LangOpts.OpenCL || S.LangOpts.ZVector) + LHS = S.UsualUnaryConversions(LHS.get());

Re: [PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

rmaprath added a comment. In https://reviews.llvm.org/D24562#542630, @mclow.lists wrote: > What an awful test. I wonder who wrote such a steaming pile. Probably me. I think I've thrown quite a lot of XFAILs like this in the past, just to get the no-exceptions build passing. Now I've got to c

Re: [PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

mclow.lists added a comment. What an awful test. I wonder who wrote such a steaming pile. Probably me. https://reviews.llvm.org/D24562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D24567: [clang-rename] Merge rename-{at|all} & optimise.

omtcyfz created this revision. omtcyfz added reviewers: alexfh, vmiklos. omtcyfz added a subscriber: cfe-commits. Having both rename-at and rename-all both seems confusing and introduces unneeded difficulties. After merging rename-at and rename-all maintaining main function wrappers and custom h

Re: [PATCH] D24245: [ARM] ARM-specific attributes should be accepted for big-endian

rovka added a subscriber: rovka. rovka accepted this revision. rovka added a reviewer: rovka. rovka added a comment. This revision is now accepted and ready to land. Looks like a sensible thing to do. Repository: rL LLVM https://reviews.llvm.org/D24245 _

r281487 - CodeGen: simplify the logic a slight bit

Author: compnerd Date: Wed Sep 14 10:17:46 2016 New Revision: 281487 URL: http://llvm.org/viewvc/llvm-project?rev=281487&view=rev Log: CodeGen: simplify the logic a slight bit Move the definition of `getTriple()` into the header. It would just call `getTarget().getTriple()`. Inline the definiti

[libcxx] r281477 - [libcxx] Add a TSan regression test for a data race in call_once

Author: kuba.brecka Date: Wed Sep 14 09:15:42 2016 New Revision: 281477 URL: http://llvm.org/viewvc/llvm-project?rev=281477&view=rev Log: [libcxx] Add a TSan regression test for a data race in call_once Differential Revision: https://reviews.llvm.org/D24297 Added: libcxx/trunk/test/std/thr

[libcxx] r281476 - [libcxx] Fix a typo in test/libcxx/test/target_info.py that prevents running tests on Darwin with sanitizers

Author: kuba.brecka Date: Wed Sep 14 09:13:50 2016 New Revision: 281476 URL: http://llvm.org/viewvc/llvm-project?rev=281476&view=rev Log: [libcxx] Fix a typo in test/libcxx/test/target_info.py that prevents running tests on Darwin with sanitizers Differential Revision: https://reviews.llvm.org/D

[libcxx] r281475 - [libcxx] Enable building and testing of libcxx with ThreadSanitizer on OS X

Author: kuba.brecka Date: Wed Sep 14 09:12:50 2016 New Revision: 281475 URL: http://llvm.org/viewvc/llvm-project?rev=281475&view=rev Log: [libcxx] Enable building and testing of libcxx with ThreadSanitizer on OS X This patch enables building and testing libcxx under ThreadSanitizer on OS X. CMak

Re: [PATCH] D23907: Fix documentation of MemberExpr::getMemberDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rL281469: Fix documentation of MemberExpr::getMemberDecl (authored by sberg). Changed prior to commit: https://reviews.llvm.org/D23907?vs=69317&id=71357#toc Repository: rL LLVM https://reviews.llvm.or

r281469 - Fix documentation of MemberExpr::getMemberDecl

Author: sberg Date: Wed Sep 14 09:03:50 2016 New Revision: 281469 URL: http://llvm.org/viewvc/llvm-project?rev=281469&view=rev Log: Fix documentation of MemberExpr::getMemberDecl Differential Revision: https://reviews.llvm.org/D23907 Modified: cfe/trunk/include/clang/AST/Expr.h Modified: cf

Re: [PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

rmaprath updated this revision to Diff 71349. rmaprath added a comment. (Added more context) https://reviews.llvm.org/D24562 Files: test/std/re/re.alg/re.alg.search/grep.pass.cpp Index: test/std/re/re.alg/re.alg.search/grep.pass.cpp ===

[PATCH] D24562: [libcxx] Recover no-exceptions XFAILs

rmaprath created this revision. rmaprath added reviewers: EricWF, mclow.lists. rmaprath added a subscriber: cfe-commits. When we added support for the no-exceptions build of `libc++`, all the tests that used exceptions got a blanket XFAIL for the no-exceptions variety. Previously, we tried to fi

Re: [PATCH] D24005: [compiler-rt cmake] Support overriding llvm-config query results

mgorny added a comment. Thanks again. I've left them as-is and committed. Repository: rL LLVM https://reviews.llvm.org/D24005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24561: [clang-tidy] Add dependency on clangAnalysis to clangTidyMiscModule

mboehme added a comment. Thanks! Repository: rL LLVM https://reviews.llvm.org/D24561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24005: [compiler-rt cmake] Support overriding llvm-config query results

This revision was automatically updated to reflect the committed changes. Closed by commit rL281461: [cmake] Support overriding llvm-config query results (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D24005?vs=71040&id=71348#toc Repository: rL LLVM https://reviews.

[clang-tools-extra] r281460 - [clang-tidy] Add dependency on clangAnalysis to clangTidyMiscModule

Author: mboehme Date: Wed Sep 14 08:33:11 2016 New Revision: 281460 URL: http://llvm.org/viewvc/llvm-project?rev=281460&view=rev Log: [clang-tidy] Add dependency on clangAnalysis to clangTidyMiscModule Summary: This is needed for the recently submitted misc-use-after-move check (rL281453). For so

Re: [PATCH] D24561: [clang-tidy] Add dependency on clangAnalysis to clangTidyMiscModule

This revision was automatically updated to reflect the committed changes. Closed by commit rL281460: [clang-tidy] Add dependency on clangAnalysis to clangTidyMiscModule (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D24561?vs=71345&id=71346#toc Repository: rL LLVM

Re: [PATCH] D24561: [clang-tidy] Add dependency on clangAnalysis to clangTidyMiscModule

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM -- for these sort of post-commit fixes that are trivial and make failing bots

Re: [PATCH] D24561: [clang-tidy] Add dependency on clangAnalysis to clangTidyMiscModule

mboehme added a comment. Trivial build fix, will submit without review. https://reviews.llvm.org/D24561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24561: [clang-tidy] Add dependency on clangAnalysis to clangTidyMiscModule

mboehme created this revision. mboehme added a subscriber: cfe-commits. Herald added subscribers: mgorny, beanz. This is needed for the recently submitted misc-use-after-move check (rL281453). For some reason, this still built under Linux, but it caused the PPC build bot to fail. https://reviews.

Re: r281452 - Revert "[modules] When merging one definition into another, propagate the list of re-exporting modules from the discarded definition to the retained definition."

This revision caused internal build breakage, but unfortunately I'm not sure what exactly in this revision caused the breakage. I have reported the issue to @rsmith - the revision author. On Wed, Sep 14, 2016 at 3:10 PM Nico Weber wrote: > When reverting something, please say why in the commit m

[clang-tools-extra] r281459 - reverting r281456

Author: omtcyfz Date: Wed Sep 14 08:23:14 2016 New Revision: 281459 URL: http://llvm.org/viewvc/llvm-project?rev=281459&view=rev Log: reverting r281456 Modified: clang-tools-extra/trunk/clang-rename/USRFindingAction.cpp clang-tools-extra/trunk/clang-rename/USRFindingAction.h clang-too

Re: [clang-tools-extra] r281453 - [clang-tidy] Add check 'misc-use-after-move'

> > While I'm excited to see this go in anywhere, I have to say I'm a bit sad > it isn't going in as a warning and instead inside clang-tidy. This has been > a much requested warning from Clang for many years. > > Is there a concise description of why this design was chosen? Are there > specific pr

  1   2   >