rsmith added a comment.
I'm not OK with losing this checking entirely. It seems like the problem case
is when we're currently processing the definition of the function in question
(so it /does/ have a body, it just doesn't have a /complete/ body yet)? I
suppose we could track that directly some
chandlerc added a comment.
In https://reviews.llvm.org/D23754#580612, @mgorny wrote:
> In https://reviews.llvm.org/D23754#580441, @chandlerc wrote:
>
> > In https://reviews.llvm.org/D23754#580277, @mgorny wrote:
> >
> > > The difference is that LLVMgold.so is not used by LLVM or clang directly
>
rsmith added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:412-417
+ /// \brief The template parameter list and optional requires-clause
+ /// associated with this declaration.
+ ///
+ /// The boolean value indicates whether this particular declaration has an
mgorny added a comment.
In https://reviews.llvm.org/D23754#580620, @chandlerc wrote:
> I'm not sure it really makes sense for the Clang driver to go hunting for an
> LLVMgold.so from an unrelated build of Clang and LLVM.
>
> The Clang driver is going to run a particular CC1 invocation, ask it to
rsmith added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:3429-3430
// initial standard conversion sequence converts the source type to
- // the type required by the argument of the constructor
- BeforeToType =
Ctor->getParamDecl(0)->getType
rsmith added inline comments.
Comment at: lib/AST/DeclCXX.cpp:1350
while (auto *NewCTD = CTD->getInstantiatedFromMemberTemplate()) {
-if (NewCTD->isMemberSpecialization())
+if (NewCTD->isMemberSpecialization() ||
+!NewCTD->isThisDeclarationADefi
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D25349#571778, @GorNishanov wrote:
> @rsmith, I am wondering what were your thoughts on where to generate try {
> body } catch (...) { p.set_exception(std::exceptio
Author: ericwf
Date: Thu Oct 27 02:30:31 2016
New Revision: 285271
URL: http://llvm.org/viewvc/llvm-project?rev=285271&view=rev
Log:
[coroutines] Build fallthrough and set_exception statements.
Summary:
This patch adds semantic checking and building of the fall-through `co_return;`
statement as
klimek added a comment.
> It's mostly about how much is "underlined". If there is only a caret, that
> quite often translates into a single character being pointed out, instead of
> an identifier (i.e. the first character). Hene the extension of the range.
Aren't we mostly doing token positions
nemanjai added a comment.
Other than the minor nit, this LGTM.
Comment at: include/clang/Basic/BuiltinsPPC.def:275
+
+BUILTIN(__builtin_altivec_vclzlsbb, "SiV16Uc", "")
No need for this extra blank line.
https://reviews.llvm.org/D26002
__
chandlerc added a comment.
In https://reviews.llvm.org/D23754#580631, @mgorny wrote:
> In https://reviews.llvm.org/D23754#580620, @chandlerc wrote:
>
> > I'm not sure it really makes sense for the Clang driver to go hunting for
> > an LLVMgold.so from an unrelated build of Clang and LLVM.
> >
>
mgorny abandoned this revision.
mgorny added a comment.
Works for me. I don't know if this even has a valid failure case, just felt
uneasy about having the obviously-wrong path in code.
https://reviews.llvm.org/D23754
___
cfe-commits mailing list
c
sammccall created this revision.
sammccall added a reviewer: dberris.
sammccall added a subscriber: cfe-commits.
Don't generate output for xray tests
https://reviews.llvm.org/D26024
Files:
test/Driver/XRay/xray-instrument-cpu.c
test/Driver/XRay/xray-instrument-os.c
Index: test/Driver/XRay
Author: erikjv
Date: Thu Oct 27 03:37:14 2016
New Revision: 285275
URL: http://llvm.org/viewvc/llvm-project?rev=285275&view=rev
Log:
Mark invalid RecordDecls as completed.
Sema::ActOnTag creates TagDecls for records. However, if those record
declarations are invalid, and the parser is in C++ mode
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285275: Mark invalid RecordDecls as completed. (authored by
erikjv).
Changed prior to commit:
https://reviews.llvm.org/D21176?vs=60152&id=75992#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2117
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Testing the code generator in a Driver test is a really weird thing to do. The
patch doesn't make it worse though and spamming the test directory is a bad
thing. I'll land this.
https://re
dberris accepted this revision.
dberris added a comment.
Yes, thanks (and sorry for missing this).
https://reviews.llvm.org/D26024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: d0k
Date: Thu Oct 27 03:49:18 2016
New Revision: 285276
URL: http://llvm.org/viewvc/llvm-project?rev=285276&view=rev
Log:
[Xray] Don't generate output for xray tests
Patch by Sam McCall!
Differential Revision: http://reviews.llvm.org/D26024
Modified:
cfe/trunk/test/Driver/XRay/xray-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285276: [Xray] Don't generate output for xray tests
(authored by d0k).
Changed prior to commit:
https://reviews.llvm.org/D26024?vs=75991&id=75994#toc
Repository:
rL LLVM
https://reviews.llvm.org/D26
timshen created this revision.
timshen added a reviewer: mclow.lists.
timshen added a subscriber: cfe-commits.
Herald added a subscriber: emaste.
Fixes PR19851.
alg.re.match/ecma.pass.cpp still XFAILS on linux, but after commenting out
locale-related tests, it passes. I don't have a freebsd machin
Author: vvassilev
Date: Thu Oct 27 04:12:20 2016
New Revision: 285277
URL: http://llvm.org/viewvc/llvm-project?rev=285277&view=rev
Log:
Empty the CtorLists/DtorLists once emitted.
This is essential when clang is running in incremental processing mode because
we don't want to reemit the 'tors over
v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Landed in r285277.
Repository:
rL LLVM
https://reviews.llvm.org/D25605
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
mgorny retitled this revision from "cmake: Supporting overriding runtime libdir
via CLANG_LIBDIR_SUFFIX" to "[cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX".
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 75996.
mgorny added a comment.
Here's the initial patch for
mgorny added inline comments.
Comment at: lib/Driver/Tools.cpp:2021
std::string Plugin =
- ToolChain.getDriver().Dir + "/../lib" CLANG_LIBDIR_SUFFIX "/LLVMgold.so";
+ ToolChain.getDriver().Dir + "/../lib" LLVM_RUNTIMES_LIBDIR_SUFFIX
"/LLVMgold.so";
CmdArgs.push_b
malcolm.parsons updated this revision to Diff 75997.
malcolm.parsons added a comment.
Add tests for operator new with FIXME comment.
https://reviews.llvm.org/D25925
Files:
clang-tidy/cert/StaticObjectExceptionCheck.cpp
docs/clang-tidy/checks/cert-err58-cpp.rst
test/clang-tidy/cert-static-
NoQ updated this revision to Diff 75998.
NoQ marked 3 inline comments as done.
NoQ added a comment.
Also, do not create error nodes unless we're sure we're throwing a report.
https://reviews.llvm.org/D25909
Files:
lib/StaticAnalyzer/Checkers/MacOSXAPIChecker.cpp
lib/StaticAnalyzer/Core/Simp
NoQ added inline comments.
Comment at: test/Analysis/dispatch-once.m:62
+- (void)test_ivar_struct_from_inside {
+ dispatch_once(&s.once, ^{}); // expected-warning{{Call to 'dispatch_once'
uses the instance variable 's' for the predicate value.}}
+}
dcoughlin wr
NoQ added a comment.
Thanks!! Will try to look at the rest of the stuff as soon as possible><
Comment at: test/Analysis/iterator-past-end.cpp:3
+
+template struct __iterator {
+ typedef __iterator iterator;
baloghadamsoftware wrote:
> NoQ wrote:
> > We should
baloghadamsoftware added inline comments.
Comment at: test/Analysis/iterator-past-end.cpp:3
+
+template struct __iterator {
+ typedef __iterator iterator;
NoQ wrote:
> baloghadamsoftware wrote:
> > NoQ wrote:
> > > We should probably separate this into an #incl
arphaman added a comment.
Hi Paul,
Are you planning to work on this patch? If not, can I take a shot at it?
Cheers,
Alex
https://reviews.llvm.org/D16533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Author: rksimon
Date: Thu Oct 27 05:51:29 2016
New Revision: 285281
URL: http://llvm.org/viewvc/llvm-project?rev=285281&view=rev
Log:
Fix MSVC warning about missing 'this' from lambda default capture mode
Modified:
cfe/trunk/lib/Lex/PPLexerChange.cpp
Modified: cfe/trunk/lib/Lex/PPLexerChange
Author: erikjv
Date: Thu Oct 27 07:12:08 2016
New Revision: 285287
URL: http://llvm.org/viewvc/llvm-project?rev=285287&view=rev
Log:
Add const versions of Expr::getInits() and Expr::inits()
Modified:
cfe/trunk/include/clang/AST/Expr.h
Modified: cfe/trunk/include/clang/AST/Expr.h
URL:
http:/
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
This makes sense. While variable definitions in a header are weird, the warning
that they're unused isn't adding any value.
https://reviews.llvm.org/D25990
__
bkramer added inline comments.
Comment at: lib/Sema/Sema.cpp:870
+ if (SM.getMainFileID() != SM.getFileID(DiagD->getLocation())
+ || !PP.getLangOpts().IsHeaderFile)
+Diag(DiagD->getLocation(), diag::warn_unused_const_variable)
Do
v.g.vassilev created this revision.
v.g.vassilev added reviewers: NoQ, zaks.anna.
v.g.vassilev added a subscriber: cfe-commits.
v.g.vassilev set the repository for this revision to rL LLVM.
This is another home grown patch I'd like to upstream.
Repository:
rL LLVM
https://reviews.llvm.org/D26
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D25989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, klimek.
malcolm.parsons added a subscriber: cfe-commits.
https://reviews.llvm.org/D26032
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.c
logan added inline comments.
Comment at: src/cxa_personality.cpp:363
+ "Unexpected TTypeEncoding");
(void)ttypeEncoding;
mclow.lists wrote:
> logan wrote:
> > mclow.lists wrote:
> > > It's not clear to me how this accomplishes what you want.
> >
aaron.ballman added a reviewer: sbenza.
aaron.ballman added a subscriber: sbenza.
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:4042
+/// \endcode
+AST_MATCHER_P(CXXNewExpr, operatorNew,
+ internal::Matcher, InnerMatcher) {
Author: arphaman
Date: Thu Oct 27 08:30:51 2016
New Revision: 285289
URL: http://llvm.org/viewvc/llvm-project?rev=285289&view=rev
Log:
[Sema] -Wunused-variable warning for array variables should behave
similarly to scalar variables.
This commit makes the -Wunused-variable warning behaviour more c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285289: [Sema] -Wunused-variable warning for array variables
should behave (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D25937?vs=75877&id=76017#toc
Repository:
rL LLVM
Author: alexfh
Date: Thu Oct 27 08:46:49 2016
New Revision: 285291
URL: http://llvm.org/viewvc/llvm-project?rev=285291&view=rev
Log:
Fix warnings from python difflib.
Modified:
cfe/trunk/tools/clang-format/clang-format.py
Modified: cfe/trunk/tools/clang-format/clang-format.py
URL:
http://ll
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. One minor suggestion (adding a comment to a test).
Comment at: libcxx/test/std/re/re.alg/re.alg.match/ecma.pass.cpp:374
std::cmatch m;
cons
arphaman updated this revision to Diff 76019.
arphaman marked 3 inline comments as done.
arphaman added a comment.
The updated patch adds documentation and modifies the diagnostic message.
Repository:
rL LLVM
https://reviews.llvm.org/D25993
Files:
include/clang/Basic/Attr.td
include/clan
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclObjC.cpp:3859
+// objc_subclassing_restricted attribute when it has that attribute as
+// well (because of interfaces imported from Swift). Therefore we have
+// to check if we can subclass
Author: arphaman
Date: Thu Oct 27 08:51:30 2016
New Revision: 285292
URL: http://llvm.org/viewvc/llvm-project?rev=285292&view=rev
Log:
Add documentation for the transparent_union attribute
Differential Revision: https://reviews.llvm.org/D25995
Modified:
cfe/trunk/include/clang/Basic/Attr.td
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285292: Add documentation for the transparent_union
attribute (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D25995?vs=75905&id=76020#toc
Repository:
rL LLVM
https://revie
arphaman added inline comments.
Comment at: lib/Sema/SemaDeclObjC.cpp:3859
+// objc_subclassing_restricted attribute when it has that attribute as
+// well (because of interfaces imported from Swift). Therefore we have
+// to check if we can subclass in th
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Sema/SemaDeclObjC.cpp:3859
+// objc_subclassing_restricted attribute when it has that attribute as
+// well (because of int
a.sidorin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:209
+ CheckerContext &C) const {
+ const auto *Func = Call.getDecl()->getAsFunction();
+ if (Func->isOverloadedOperator()) {
---
a.sidorin added a comment.
Thank you for this patch! I like some solutions used in it but I also have some
comments (inline).
https://reviews.llvm.org/D25660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285295: Do not print include_next/pragma once warnings when
input is a header. (authored by erikjv).
Changed prior to commit:
https://reviews.llvm.org/D25989?vs=75890&id=76024#toc
Repository:
rL LLVM
Author: erikjv
Date: Thu Oct 27 09:17:10 2016
New Revision: 285295
URL: http://llvm.org/viewvc/llvm-project?rev=285295&view=rev
Log:
Do not print include_next/pragma once warnings when input is a header.
r276653 suppressed the pragma once warning when generating a PCH file.
This patch extends tha
alexfh added a comment.
A few late comments (seems to be relevant to the revision finally committed
after all fixes).
Comment at: clang-tidy/utils/NamespaceAliaser.cpp:35
+return None;
+
+
nit: Too many empty lines.
Comment at: clang-tid
alexfh requested changes to this revision.
alexfh added a reviewer: alexfh.
alexfh added a comment.
This revision now requires changes to proceed.
Kirill, if you still have time for this, could you submit reformatting as a
separate patch to make semantic changes more visible?
https://reviews.ll
arphaman updated this revision to Diff 76029.
arphaman marked an inline comment as done.
arphaman added a comment.
The updated patch follows Richard's explanation and fixes the problem by
checking if `CTD` is a member specialization without irrelevant definition
checks.
Repository:
rL LLVM
arphaman added inline comments.
Comment at: lib/AST/DeclCXX.cpp:1350
while (auto *NewCTD = CTD->getInstantiatedFromMemberTemplate()) {
-if (NewCTD->isMemberSpecialization())
+if (NewCTD->isMemberSpecialization() ||
+!NewCTD->isThisDeclarationADe
NoQ updated this revision to Diff 76031.
NoQ marked 2 inline comments as done.
NoQ added a comment.
In https://reviews.llvm.org/D25940#579227, @dcoughlin wrote:
> Are the parameter types actually needed? I think in general the rest of the
> analyzer uses arity alone.
Arity checks are to avoid
sebpop added inline comments.
Comment at: libcxx/include/string:1841
template
+inline _LIBCPP_HEADER_INLINE_VISIBILITY
basic_string<_CharT, _Traits, _Allocator>::~basic_string()
and let's also use the define just here:
#ifndef _LIBCPP_BUILDING_STRING
inli
Author: marshall
Date: Thu Oct 27 10:10:07 2016
New Revision: 285300
URL: http://llvm.org/viewvc/llvm-project?rev=285300&view=rev
Log:
Move 'quoted' for string_view from to (where the other
versions of 'quoted' live. No functional change.
Modified:
libcxx/trunk/include/iomanip
libcxx/t
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
These scripts aren't `+x`. Maybe you want to make them executable as well.
Also, scan-build-py adds `# -*- coding: utf-8 -*-` as well to its python
executables.
Repository:
rL LLVM
https://revie
Author: alexfh
Date: Thu Oct 27 10:15:23 2016
New Revision: 285301
URL: http://llvm.org/viewvc/llvm-project?rev=285301&view=rev
Log:
Attempt to make clang-format.py python 3 - compatible.
Modified:
cfe/trunk/tools/clang-format/clang-format.py
Modified: cfe/trunk/tools/clang-format/clang-form
rSerge added a comment.
@dberris , thanks! I ran clang-format on Tools.cpp , then just copy-pasted the
changed piece. Do you remember, was the whitespace problem in this file? Or was
it in the tests?
Repository:
rL LLVM
https://reviews.llvm.org/D24799
NoQ updated this revision to Diff 76043.
NoQ added a comment.
- Fix warning messages, finally, hopefully.
- Make handling of macros much more careful, because errors of form `x == Y`,
where X is an `NSNumber` pointer, and `Y` is a custom macro that expands to
`0`, were found.
https://reviews.l
arphaman created this revision.
arphaman added a reviewer: akyrtzi.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch implements a heuristic that I mentioned in
https://reviews.llvm.org/D25520. When completing blocks properties that ret
thakis created this revision.
thakis added a reviewer: hans.
thakis added a subscriber: cfe-commits.
This is a misspelling of the intended `!(x & A)` negated bit test that happens
in practice every now and then.
I ran this on Chromium and all its dependencies, and it fired 0 times -- no
false o
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Looks great! Please, commit.
https://reviews.llvm.org/D25909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm, very nice! (with one clarifying question)
Comment at: test/SemaCXX/warn-logical-not-compare.cpp:224
+ // These already err, don't also warn.
+ !x &= 1; // expected-error{
thakis added a comment.
Thanks! Landing…
Comment at: test/SemaCXX/warn-logical-not-compare.cpp:224
+ // These already err, don't also warn.
+ !x &= 1; // expected-error{{expression is not assignable}}
+ !x |= 1; // expected-error{{expression is not assignable}}
-
On 27 Oct 2016 7:26 am, "Erik Verbruggen via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Author: erikjv
Date: Thu Oct 27 09:17:10 2016
New Revision: 285295
URL: http://llvm.org/viewvc/llvm-project?rev=285295&view=rev
Log:
Do not print include_next/pragma once warnings when input is a header
On 27 Oct 2016 5:21 am, "Erik Verbruggen via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Author: erikjv
Date: Thu Oct 27 07:12:08 2016
New Revision: 285287
URL: http://llvm.org/viewvc/llvm-project?rev=285287&view=rev
Log:
Add const versions of Expr::getInits() and Expr::inits()
Modified:
Author: gornishanov
Date: Thu Oct 27 11:28:31 2016
New Revision: 285306
URL: http://llvm.org/viewvc/llvm-project?rev=285306&view=rev
Log:
[coroutines] Add allocation and deallocation substatements.
Summary:
SemaCoroutine: Add allocation / deallocation substatements.
CGCoroutine/Test: Emit allocat
Author: sfantao
Date: Thu Oct 27 11:29:20 2016
New Revision: 285307
URL: http://llvm.org/viewvc/llvm-project?rev=285307&view=rev
Log:
[Driver][CUDA][OpenMP] Reimplement tool selection in the driver.
Summary:
This creates a tool selector in the driver that replaces the existing one. The
goal is t
Author: nico
Date: Thu Oct 27 11:32:06 2016
New Revision: 285310
URL: http://llvm.org/viewvc/llvm-project?rev=285310&view=rev
Log:
Expand -Wlogical-not-parentheses to also fire on `!x & A`.
This is a misspelling of the intended !(x & A) negated bit test that happens in
practice every now and then
thakis closed this revision.
thakis added a comment.
285310
https://reviews.llvm.org/D26035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sfantao
Date: Thu Oct 27 11:38:05 2016
New Revision: 285311
URL: http://llvm.org/viewvc/llvm-project?rev=285311&view=rev
Log:
[Driver][OpenMP] Create tool chains for OpenMP offloading kind.
Summary: This patch adds new logic to create the necessary tool chains to
support offloading for O
Author: sfantao
Date: Thu Oct 27 12:08:03 2016
New Revision: 285314
URL: http://llvm.org/viewvc/llvm-project?rev=285314&view=rev
Log:
[Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.
Summary:
This patch adds a new specialized action builder to create OpenMP offloadin
Author: majnemer
Date: Thu Oct 27 12:11:51 2016
New Revision: 285315
URL: http://llvm.org/viewvc/llvm-project?rev=285315&view=rev
Log:
[MS ABI] Reuse getVFPtrOffsets instead of using getClassAtVTableLocation
getClassAtVTableLocation hunts through virtual bases without using the
MDC layout which i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285315: [MS ABI] Reuse getVFPtrOffsets instead of using
getClassAtVTableLocation (authored by majnemer).
Changed prior to commit:
https://reviews.llvm.org/D25895?vs=75523&id=76059#toc
Repository:
rL
Author: majnemer
Date: Thu Oct 27 12:18:24 2016
New Revision: 285316
URL: http://llvm.org/viewvc/llvm-project?rev=285316&view=rev
Log:
[CodeGen] Provide an appropriate alignment for dynamic allocas
GCC documents __builtin_alloca as aligning the storage to at least
__BIGGEST_ALIGNMENT__.
MSVC doc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285316: [CodeGen] Provide an appropriate alignment for
dynamic allocas (authored by majnemer).
Changed prior to commit:
https://reviews.llvm.org/D24378?vs=70789&id=76060#toc
Repository:
rL LLVM
http
sfantao updated this revision to Diff 76061.
sfantao marked 2 inline comments as done.
sfantao added a comment.
- Capitalize Clang in linker script comment and explain that the linker script
dump option is required to test the driver with -###.
https://reviews.llvm.org/D21847
Files:
include/
sfantao updated this revision to Diff 76062.
sfantao added a comment.
- Capitalize Clang in the regression test too.
https://reviews.llvm.org/D21847
Files:
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-
Author: sfantao
Date: Thu Oct 27 12:31:22 2016
New Revision: 285319
URL: http://llvm.org/viewvc/llvm-project?rev=285319&view=rev
Log:
[Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc
tool chains.
Summary:
This patch adds logic to create jobs for OpenMP offloading a
Author: sfantao
Date: Thu Oct 27 12:39:44 2016
New Revision: 285320
URL: http://llvm.org/viewvc/llvm-project?rev=285320&view=rev
Log:
[Driver][OpenMP] Add logic for offloading-specific argument translation.
Summary:
This patch includes support for argument translation that is specific of a
given
jwhowarth reopened this revision.
jwhowarth added a comment.
This approach doesn't work if the user installs clang in a buried subdirectory
such as /sw/opt/llvm-4.0 but accesses the compilers via a /sw/bin/clang-4.0
symlink pointing at /sw/opt/llvm-4.0/bin/clang-4.0...
$ /sw/bin/clang-4.0 -flto
erichkeane added a comment.
I guess I'm not sure how to respond to that... Calling conventions
traditionally use double underscore to prevent from stomping on user keywords.
Additionally, this is in a specification that has an existing implementation
available, so I'm not sure what could be do
mehdi_amini added a comment.
Since you re-open this revision, can you clarify how this is triggering the bug
you mention? It seems like the issue already existed?
Repository:
rL LLVM
https://reviews.llvm.org/D25932
___
cfe-commits mailing list
c
mehdi_amini added a comment.
I just verified that I reproduce with -flto and an previous clang version.
Repository:
rL LLVM
https://reviews.llvm.org/D25932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Author: sfantao
Date: Thu Oct 27 12:50:43 2016
New Revision: 285323
URL: http://llvm.org/viewvc/llvm-project?rev=285323&view=rev
Log:
[Driver][OpenMP] Update actions builder to create bundling action when
necessary.
Summary:
In order to save the user from dealing with multiple output files (for
jwhowarth added a comment.
Opened https://llvm.org/bugs/show_bug.cgi?id=30811 since the inability for
symlinks to be handled in locating libLTO.dylib defeats the purpose of this
commit.
Repository:
rL LLVM
https://reviews.llvm.org/D25932
___
cf
Author: sfantao
Date: Thu Oct 27 13:00:51 2016
New Revision: 285324
URL: http://llvm.org/viewvc/llvm-project?rev=285324&view=rev
Log:
[Driver][OpenMP] Update actions builder to create unbundling action when
necessary.
Summary:
Each time that offloading support is requested by the user and the in
sfantao updated this revision to Diff 76064.
sfantao marked an inline comment as done.
sfantao added a comment.
- Add comment explaing that the bundler tool can detect if the input file is a
bundle or not.
https://reviews.llvm.org/D21853
Files:
include/clang/Driver/Action.h
include/clang/D
mehdi_amini added a comment.
I reproduced with clang that ships with XCode by doing:
ln -s `xcrun -find clang` /tmp/clang
/tmp/clang /tmp/main.cpp -flto
clang: warning: libLTO.dylib relative to clang installed dir not found;
using 'ld' default search path instead
`
Repos
Author: sfantao
Date: Thu Oct 27 13:04:42 2016
New Revision: 285325
URL: http://llvm.org/viewvc/llvm-project?rev=285325&view=rev
Log:
[Driver][OpenMP] Add support to create jobs for bundling actions.
Summary: This patch adds the support to create a job for the
`OffloadBundlingAction` which will
Author: sfantao
Date: Thu Oct 27 13:14:55 2016
New Revision: 285326
URL: http://llvm.org/viewvc/llvm-project?rev=285326&view=rev
Log:
[Driver][OpenMP] Add support to create jobs for unbundling actions.
Summary:
This patch adds the support to create jobs for the `OffloadBundlingAction`
which will
sfantao updated this revision to Diff 76069.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21857
Files:
include/clang/Driver/Action.h
include/clang/Driver/Driver.h
include/clang/Driver/Tool.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/Tool.cpp
lib/Driver
Author: sfantao
Date: Thu Oct 27 13:29:57 2016
New Revision: 285327
URL: http://llvm.org/viewvc/llvm-project?rev=285327&view=rev
Log:
Use -fopenmp=libomp in all OpenMP offloading tests.
This will make sure the right features are being tested even for machines that
default to libgomp.
Modified:
majnemer added a comment.
The __ namespace is reserved for us and I can't imagine how __regcall would
upset any existing code out there.
https://reviews.llvm.org/D25204
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
EricWF updated this revision to Diff 76076.
EricWF added a comment.
Resolved merge conflicts.
https://reviews.llvm.org/D25292
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutines.cpp
Index: test/SemaCXX/coroutines.cpp
==
1 - 100 of 168 matches
Mail list logo
