mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Thanks for making these changes; I think this looks much better than before.
Feature creep: A bunch of the local variables can be marked as `const`.
Comment at:
te
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This looks OK to me.
https://reviews.llvm.org/D26184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
On Tue, Nov 1, 2016 at 3:13 AM Alex L wrote:
> On 31 October 2016 at 15:34, David Blaikie wrote:
>
>
>
> On Thu, Oct 27, 2016 at 6:40 AM Alex Lorenz via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
> Author: arphaman
> Date: Thu Oct 27 08:30:51 2016
> New Revision: 285289
>
> URL: http:/
arphaman created this revision.
arphaman added reviewers: rsmith, rjmccall.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch improves the "must have C++ linkage" error diagnostics for C++ by
adding an additional note that points to the
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseEqualsDeleteCheck.cpp:29
+cxxMethodDecl(
+anyOf(isCopyAssignmentOperator(), isMoveAssignmentOperator())),
+cxxDestructorDecl()));
malcolm.parsons wrot
Author: danielmarjamaki
Date: Tue Nov 1 08:26:15 2016
New Revision: 285689
URL: http://llvm.org/viewvc/llvm-project?rev=285689&view=rev
Log:
[clang-tidy] Add check readability-redundant-declaration
Finds redundant variable and function declarations.
extern int X;
extern int X; // <- redund
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285689: [clang-tidy] Add check
readability-redundant-declaration (authored by danielmarjamaki).
Changed prior to commit:
https://reviews.llvm.org/D24656?vs=74478&id=76548#toc
Repository:
rL LLVM
htt
Author: mzuckerm
Date: Tue Nov 1 08:16:44 2016
New Revision: 285688
URL: http://llvm.org/viewvc/llvm-project?rev=285688&view=rev
Log:
[x86][inline-asm][clang] accept 'v' constraint
Commit on behalf of: Coby Tayree
1.'v' constraint for (x86) non-avx arch imitates the already implemented 'x'
cons
rogfer01 created this revision.
rogfer01 added reviewers: rmaprath, mclow.lists, EricWF.
rogfer01 added a subscriber: cfe-commits.
Skip tests that expect an exception to be thrown.
https://reviews.llvm.org/D26184
Files:
test/std/thread/thread.mutex/thread.lock.algorithm/lock.pass.cpp
test/s
falho added a comment.
Thanks but I think I will try it!
https://reviews.llvm.org/D22346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arphaman
Date: Tue Nov 1 06:12:41 2016
New Revision: 285686
URL: http://llvm.org/viewvc/llvm-project?rev=285686&view=rev
Log:
[www] Fix a typo on the analyzer website
Modified:
cfe/trunk/www/analyzer/annotations.html
Modified: cfe/trunk/www/analyzer/annotations.html
URL:
http://llv
mayurpandey added a comment.
Hi David,
The crash that we see can be seen with other diagnostics for builtin if we use
the diagnostic format you suggested. I tried the same thing with
err_builtin_annotation_first_arg. The same crash can be seen. So shall I fix
this crash with this bug or file a
Author: klimek
Date: Tue Nov 1 05:30:50 2016
New Revision: 285685
URL: http://llvm.org/viewvc/llvm-project?rev=285685&view=rev
Log:
Fix parenthesized assert (nfc).
Modified:
cfe/trunk/lib/AST/Decl.cpp
Modified: cfe/trunk/lib/AST/Decl.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/l
On 1 November 2016 at 10:13, Alex L wrote:
>
> On 31 October 2016 at 15:34, David Blaikie wrote:
>
>>
>>
>> On Thu, Oct 27, 2016 at 6:40 AM Alex Lorenz via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Author: arphaman
>>> Date: Thu Oct 27 08:30:51 2016
>>> New Revision: 285289
>>>
On 31 October 2016 at 15:34, David Blaikie wrote:
>
>
> On Thu, Oct 27, 2016 at 6:40 AM Alex Lorenz via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: arphaman
>> Date: Thu Oct 27 08:30:51 2016
>> New Revision: 285289
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=285289&view
rogfer01 updated the summary for this revision.
rogfer01 updated this revision to Diff 76532.
rogfer01 added a comment.
Update tests following Marshall's suggestion to avoid too much code
duplication. Also add assert(false) after the throwing action to ensure that
the expected exception is actua
malcolm.parsons updated this revision to Diff 76529.
malcolm.parsons added a comment.
Rename modernize-use-default to modernize-use-equals-default
https://reviews.llvm.org/D26138
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/U
nemanjai added a comment.
Committed revision 285679.
Sean, please close this review pending no buildbot failures.
https://reviews.llvm.org/D26073
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: nemanjai
Date: Tue Nov 1 03:39:56 2016
New Revision: 285679
URL: http://llvm.org/viewvc/llvm-project?rev=285679&view=rev
Log:
[PPC] Add vec_absd functions to altivec.h
This patch corresponds to review https://reviews.llvm.org/D26073.
Committing on behalf of Sean Fertile.
Modified:
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285677: Protect tests that expect an exception for an
unknown std::random_device (authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D26141?vs=76378&id=76527#toc
Repository:
rL
Author: rogfer01
Date: Tue Nov 1 03:11:12 2016
New Revision: 285677
URL: http://llvm.org/viewvc/llvm-project?rev=285677&view=rev
Log:
Protect tests that expect an exception for an unknown std::random_device
Skip these tests under libcpp-no-exceptions.
Differential Revision: https://reviews.llvm
101 - 121 of 121 matches
Mail list logo
