[clang-tools-extra] r288043 - [include-fixer] Don't interfere with typo correction if we found nothing.

Author: d0k Date: Mon Nov 28 11:16:18 2016 New Revision: 288043 URL: http://llvm.org/viewvc/llvm-project?rev=288043=rev Log: [include-fixer] Don't interfere with typo correction if we found nothing. Just let the existing typo correction machinery handle that. Modified:

[PATCH] D26979: Do not hard-code locale data in unit tests: get it from the OS instead

vangyzen added inline comments. Comment at: projects/libcxx/test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp:79 const std::numpunct& np = std::use_facet(l); -assert(np.thousands_sep()

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

beanz added a reviewer: eugenis. beanz added a subscriber: eugenis. beanz added a comment. Looping in @eugenis, who added i686 support in r218761. eugenis, since i686 is identical to i386 generating it as a separate target is undesirable. Can you help advise as to how we can better meet your

[PATCH] D27167: [libc++] Support multibyte decimal_point and thousands_sep

vangyzen created this revision. vangyzen added a subscriber: cfe-commits. Herald added a subscriber: emaste. Herald added a reviewer: EricWF. numpunct_byname assumed that decimal_point and thousands_sep were ASCII and simply copied the first byte from them. Add support for multibyte strings in

[PATCH] D26904: [astimporter] Support importing CXXDependentScopeMemberExpr and FunctionTemplateDecl

a.sidorin added a comment. Hello Kareem. There are some tests in "class-template" dir that may serve as example. You don't need a warning for a function that was found: you should just return found declaration. There is already a warning for a declaration that is defined in multiple TUs. You

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, Prazek, alexfh. malcolm.parsons added a subscriber: cfe-commits. Herald added a subscriber: JDevlieghere. Use auto when declaring variables that are initialized by calling a templated function that returns its

[PATCH] D27109: [OpenCL] Prevent generation of globals in non-constant address space for OpenCL

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D27109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26672: Avoid -Wshadow warnings for parameters that shadow fields in setter-like methods

arphaman added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D26672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26196: Add support for non-zero null pointer for C and OpenCL

yaxunl updated the summary for this revision. yaxunl updated this revision to Diff 79406. yaxunl added a comment. Revised by John's comments. Emit null pointer in target-specific representation in folded constant expressions. Fix casting null pointer to integer in constant expressions.

r288039 - [OPENMP] Fix for PR31137: Wrong DSA for members in struct.

Author: abataev Date: Mon Nov 28 09:55:15 2016 New Revision: 288039 URL: http://llvm.org/viewvc/llvm-project?rev=288039=rev Log: [OPENMP] Fix for PR31137: Wrong DSA for members in struct. If member expression is used in the task region and the base expression is a DeclRefExp and the variable

[PATCH] D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value

arphaman created this revision. arphaman added reviewers: aaron.ballman, manmanren. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch adds a new ``format_dynamic_key_arg``. It's intended to be used instead of ``format_arg`` for

[PATCH] D27138: Extend CompilationDatabase by a field for the output filename

joerg added inline comments. Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266 +nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])), +Output ? Output->getValue(OutputStorage) : ""); } klimek wrote: > joerg wrote: > > klimek wrote: > >

[PATCH] D27109: [OpenCL] Prevent generation of globals in non-constant address space for OpenCL

Anastasia updated this revision to Diff 79403. Anastasia added a comment. Merged if statements into one! https://reviews.llvm.org/D27109 Files: lib/CodeGen/CGDecl.cpp test/CodeGenOpenCL/constant-addr-space-globals.cl Index: test/CodeGenOpenCL/constant-addr-space-globals.cl

[PATCH] D27138: Extend CompilationDatabase by a field for the output filename

klimek added inline comments. Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266 +nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])), +Output ? Output->getValue(OutputStorage) : ""); } joerg wrote: > klimek wrote: > > joerg wrote: > >

[PATCH] D27138: Extend CompilationDatabase by a field for the output filename

joerg added inline comments. Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266 +nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])), +Output ? Output->getValue(OutputStorage) : ""); } klimek wrote: > joerg wrote: > > klimek wrote: > >

[PATCH] D26764: [compiler-rt] [cmake] Remove i686 target that is duplicate to i386

mgorny added a comment. Ping. https://reviews.llvm.org/D26764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux)

mgorny added a comment. Ping. https://reviews.llvm.org/D26796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26887: [Driver] Fix finding multilib gcc install on Gentoo (with gcc-config)

mgorny added a comment. Ping. https://reviews.llvm.org/D26887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25686: [Driver] Support "hardfloat" vendor triples used by Gentoo

mgorny added a comment. Second ping. @hfinkel, could you suggest me how to proceed with this? https://reviews.llvm.org/D25686 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27099: [OpenCL] Prohibit using reserve_id_t in program scope.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Please, address the small nitpick before committing. Comment at: lib/Sema/SemaDecl.cpp:5965 + +// OpenCL 1.2 spec, p6.9 r: +// The event type

[PATCH] D27049: [OpenCL] Refactor out ReadPipe/WritePipe

joey updated this revision to Diff 79399. joey added a comment. Pipe types cannot be merged by ASTContext::mergeTypes. Repository: rL LLVM https://reviews.llvm.org/D27049 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Serialization/ASTBitCodes.h

[PATCH] D27109: [OpenCL] Prevent generation of globals in non-constant address space for OpenCL

yaxunl added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:954 + if (!getLangOpts().OpenCL || Ty.getAddressSpace() == LangAS::opencl_constant) +if (CGM.getCodeGenOpts().MergeAllConstants && !NRVO && !isByRef && +CGM.isTypeConstant(Ty, true)) {

[clang-tools-extra] r288034 - ClangMoveTests.cpp: Fix a bogus comparison of iterator.

Author: chapuni Date: Mon Nov 28 08:27:37 2016 New Revision: 288034 URL: http://llvm.org/viewvc/llvm-project?rev=288034=rev Log: ClangMoveTests.cpp: Fix a bogus comparison of iterator. msc Debug build detected it. Modified: clang-tools-extra/trunk/unittests/clang-move/ClangMoveTests.cpp

[PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

arphaman updated this revision to Diff 79396. arphaman added a comment. Fixed comment typo. Repository: rL LLVM https://reviews.llvm.org/D27163 Files: include/clang/AST/Decl.h include/clang/Basic/LangOptions.def include/clang/Driver/Options.td

[PATCH] D27163: Introduce -f[no-]strict-return flag that controls code generation for C++'s undefined behaviour return optimisation

arphaman created this revision. arphaman added reviewers: rjmccall, rsmith, mehdi_amini. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch adds a new clang flag called `-f[no-]strict-return`. The purpose of this flag is to control how

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

NoQ added a comment. This looks good to me (bikeshedded a bit), but i think Devin should have another look, because his comments were way deeper than mine. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:217 + + llvm::ImmutableList

Re: [PATCH] Warning for main returning a bool.

Thanks Richard for looking at the revised patch. On Mon, Nov 21, 2016 at 1:50 PM Richard Smith wrote: > This looks good to me. (While we could generalize this further, this patch > is a strict improvement, and we'll probably want to treat the 'main' case > specially

[PATCH] D27138: Extend CompilationDatabase by a field for the output filename

klimek added inline comments. Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266 +nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])), +Output ? Output->getValue(OutputStorage) : ""); } joerg wrote: > klimek wrote: > > Optional: I'd

[PATCH] D27138: Extend CompilationDatabase by a field for the output filename

joerg added inline comments. Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266 +nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])), +Output ? Output->getValue(OutputStorage) : ""); } klimek wrote: > Optional: I'd probably let the

r288025 - [Sema] Set range end of constructors and destructors in template instantiations

Author: malcolm.parsons Date: Mon Nov 28 05:11:34 2016 New Revision: 288025 URL: http://llvm.org/viewvc/llvm-project?rev=288025=rev Log: [Sema] Set range end of constructors and destructors in template instantiations Summary: clang-tidy checks frequently use source ranges of functions. The

[PATCH] D26849: [Sema] Set range end of constructors and destructors in template instantiations

This revision was automatically updated to reflect the committed changes. Closed by commit rL288025: [Sema] Set range end of constructors and destructors in template instantiations (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D26849?vs=78522=79385#toc

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

kromanenkov added a comment. ping https://reviews.llvm.org/D25475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26849: [Sema] Set range end of constructors and destructors in template instantiations

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. I think it LG, thanks for adding the test https://reviews.llvm.org/D26849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D21099: [Sema] Teach -Wcast-align to look at the aligned attribute of the declared variables

arphaman accepted this revision. arphaman added a reviewer: arphaman. arphaman added a comment. This revision is now accepted and ready to land. LGTM, Thanks https://reviews.llvm.org/D21099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27138: Extend CompilationDatabase by a field for the output filename

klimek added inline comments. Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266 +nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])), +Output ? Output->getValue(OutputStorage) : ""); } Optional: I'd probably let the nodeToCommandLine

[PATCH] D26137: [clang-tidy] Add check name to YAML export

Alpha added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D26137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2