r290059 - Fix a lit test issue exposed by r290056

2016-12-17 Thread Yaxun Liu via cfe-commits
Author: yaxunl Date: Sun Dec 18 01:26:01 2016 New Revision: 290059 URL: http://llvm.org/viewvc/llvm-project?rev=290059&view=rev Log: Fix a lit test issue exposed by r290056 The test requests a target which supports cl_khr_gl_msaa_sharing since in test/PCH/ocl_types.h it tries to enable cl_khr_gl

[PATCH] D27897: [Modules] Enable the Modules language feature by default for the Clang builtins.

2016-12-17 Thread Elad Cohen via Phabricator via cfe-commits
eladcohen created this revision. eladcohen added reviewers: rsmith, rnk, zvi, chandlerc, thakis. eladcohen added a subscriber: cfe-commits. The motivation is to reduce the compile time of the Clang intrinsics header files. Furthermore, this should allow us to remove the feature guards from these

r290058 - Attempt to fix build failure and regressions due to r290056

2016-12-17 Thread Yaxun Liu via cfe-commits
Author: yaxunl Date: Sun Dec 18 00:35:06 2016 New Revision: 290058 URL: http://llvm.org/viewvc/llvm-project?rev=290058&view=rev Log: Attempt to fix build failure and regressions due to r290056 Add llvm:: namespace to StringRef. Make conversion between bool and uint64_t explicit. Modified: cf

[PATCH] D27896: Remove the feature guards from the Clang intrinsics header files.

2016-12-17 Thread Elad Cohen via Phabricator via cfe-commits
eladcohen created this revision. eladcohen added a subscriber: cfe-commits. These were re-introduced to get better compile times in cases that don't actually require all the features. However, it creates compatibility issues with MSVC (in which all the intrinsics are available all the time). Wit

RE: r289991 - Revert r289979 due to regressions

2016-12-17 Thread Liu, Yaxun (Sam) via cfe-commits
Thanks. Sam From: Reid Kleckner [mailto:r...@google.com] Sent: Friday, December 16, 2016 5:24 PM To: Liu, Yaxun (Sam) Cc: cfe-commits Subject: Re: r289991 - Revert r289979 due to regressions This revert broke the build because you failed to resolve conflicts in include/clang/Basic/OpenCLOptio

r290056 - Recommit r289979 [OpenCL] Allow disabling types and declarations associated with extensions

2016-12-17 Thread Yaxun Liu via cfe-commits
Author: yaxunl Date: Sat Dec 17 23:18:55 2016 New Revision: 290056 URL: http://llvm.org/viewvc/llvm-project?rev=290056&view=rev Log: Recommit r289979 [OpenCL] Allow disabling types and declarations associated with extensions Fixed undefined behavior due to cast integer to bool in initializer lis

[PATCH] D27836: Store the "current position" index within the ASTRecordReader.

2016-12-17 Thread David L. Jones via Phabricator via cfe-commits
dlj added a comment. Yeah, that makes more sense. Switched to readInt/peekInt/skipInts, let me know if you have a better idea for the names. https://reviews.llvm.org/D27836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D27546: [ASTReader] Sort RawComments before merging

2016-12-17 Thread Manman Ren via Phabricator via cfe-commits
manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman https://reviews.llvm.org/D27546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[libcxx] r290052 - [CMake] Fix issue reported on sanitizer bots

2016-12-17 Thread Chris Bieneman via cfe-commits
Author: cbieneman Date: Sat Dec 17 15:28:24 2016 New Revision: 290052 URL: http://llvm.org/viewvc/llvm-project?rev=290052&view=rev Log: [CMake] Fix issue reported on sanitizer bots This should resolve an issue reported on the commit thread that impacted sanitizer bots. Modified: libcxx/trun

[PATCH] D26453: [clang-tidy] Remove duplicated check from move-constructor-init

2016-12-17 Thread Malcolm Parsons via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL290051: [clang-tidy] Remove duplicated check from move-constructor-init (authored by malcolm.parsons). Changed prior to commit: https://reviews.llvm.org/D26453?vs=78867&id=81849#toc Repository: rL LL

[clang-tools-extra] r290051 - [clang-tidy] Remove duplicated check from move-constructor-init

2016-12-17 Thread Malcolm Parsons via cfe-commits
Author: malcolm.parsons Date: Sat Dec 17 14:23:14 2016 New Revision: 290051 URL: http://llvm.org/viewvc/llvm-project?rev=290051&view=rev Log: [clang-tidy] Remove duplicated check from move-constructor-init Summary: An addition to the move-constructor-init check was duplicating the modernize-pass-

[PATCH] D22507: Clang-tidy - Enum misuse check

2016-12-17 Thread Peter Szecsi via Phabricator via cfe-commits
szepet updated this revision to Diff 81848. szepet added a comment. Herald added a subscriber: JDevlieghere. Minor changes to improve the readability of the code according to comments. https://reviews.llvm.org/D22507 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

[PATCH] D27854: [analyzer] Add check for mutex acquisition during interrupt context in Magenta kernel

2016-12-17 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. This checker looks good to me! I don't see any obvious problems, and i think we can land it into non-alpha (enabled by default) once reviewers' comments are addressed. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:78 +def Magenta : Packa