Author: rsmith
Date: Tue Dec 27 01:56:27 2016
New Revision: 290593
URL: http://llvm.org/viewvc/llvm-project?rev=290593&view=rev
Log:
DR1495: A partial specialization is ill-formed if it is not (strictly) more
specialized than the primary template. (Put another way, if we imagine there
were a parti
Great, thanks!
On 26 December 2016 at 21:44, George Burgess IV wrote:
> r290584 :)
>
> On Mon, Dec 26, 2016 at 8:30 PM, George Burgess IV <
> george.burgess...@gmail.com> wrote:
>
>> SG; working on a follow-up now. Thanks!
>>
>> On Mon, Dec 26, 2016 at 8:26 PM, Richard Smith
>> wrote:
>>
>>> On
myatsina added a comment.
In https://reviews.llvm.org/D15075#631207, @vitalybuka wrote:
> These patches break asan tests:
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/528/steps/check-asan%20in%20gcc%20build/logs/stdio
Vitaly ,
This patch is a gcc compatibility issue and i
Alpha added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I suspect that this commit is responsible for a regression parsing widely
used open source packages like Eigen.
See the code in Eigen here:
https://bitbucket.org/eigen/eigen/src/e46c8246b284dea1690ac260dfe50851906138f0/unsupported/Eigen/CXX11/src/Tensor/TensorStorage.h?at=default&fileviewer=file-v
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290600: [clang-tidy] Add enum misuse check. (authored by
xazax).
Changed prior to commit:
https://reviews.llvm.org/D22507?vs=82488&id=82533#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22507
F
Author: xazax
Date: Tue Dec 27 04:07:39 2016
New Revision: 290600
URL: http://llvm.org/viewvc/llvm-project?rev=290600&view=rev
Log:
[clang-tidy] Add enum misuse check.
The checker detects various cases when an enum is probably misused
(as a bitmask).
Patch by: Peter Szecsi!
Differential Revisio
kimgr added a comment.
Minor spelling nits inline
Comment at: clang-tidy/cppcoreguidelines/NoMallocCheck.cpp:30
+ callExpr(callee(functionDecl(hasAnyName("::malloc", "::calloc"
+ .bind("aquisition"),
+ this);
Spelling nit: acquisition
Bu
Author: xazax
Date: Tue Dec 27 05:56:54 2016
New Revision: 290605
URL: http://llvm.org/viewvc/llvm-project?rev=290605&view=rev
Log:
Attempt to fix non-determinism in tests.
Modified:
clang-tools-extra/trunk/test/clang-tidy/misc-suspicious-enum-usage-strict.cpp
Modified:
clang-tools-extra/t
arpith-jacob created this revision.
arpith-jacob added reviewers: ABataev, sfantao, carlo.bertolli, kkwli0, caomhin.
arpith-jacob added a subscriber: cfe-commits.
Herald added a subscriber: jholewinski.
This patch cleans up private methods for NVPTX OpenMP codegen. It converts
private members to
ahatanak added a comment.
In https://reviews.llvm.org/D15075#631237, @myatsina wrote:
> In https://reviews.llvm.org/D15075#631207, @vitalybuka wrote:
>
> > These patches break asan tests:
> > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/528/steps/check-asan%20in%20gcc%20build/
On Mon, Dec 26, 2016 at 03:35:25AM -, Saleem Abdulrasool via cfe-commits
wrote:
> Driver: warn on -fPIC/-fpic/-fPIE/-fpie on Windows
Can we please invert this behavior? Complain if the effective PIC mode
is not level 2 and silently ignore it otherwise? I find the MinGW
warnings to be highly a
myatsina added a comment.
In https://reviews.llvm.org/D15075#631316, @ahatanak wrote:
> In https://reviews.llvm.org/D15075#631237, @myatsina wrote:
>
> > In https://reviews.llvm.org/D15075#631207, @vitalybuka wrote:
> >
> > > These patches break asan tests:
> > > http://lab.llvm.org:8011/builder
arpith-jacob created this revision.
arpith-jacob added reviewers: ABataev, sfantao, carlo.bertolli, kkwli0, caomhin.
arpith-jacob added a subscriber: cfe-commits.
Herald added subscribers: aprantl, jholewinski.
This patch includes updates for codegen of the target region for the NVPTX
device. It
On 27 Dec 2016 1:42 am, "Chandler Carruth via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
I suspect that this commit is responsible for a regression parsing widely
used open source packages like Eigen.
See the code in Eigen here:
https://bitbucket.org/eigen/eigen/src/e46c8246b284dea1690ac26
cpplearner updated this revision to Diff 82549.
cpplearner added a comment.
test updated
https://reviews.llvm.org/D27850
Files:
test/std/utilities/optional/optional.object/optional.object.observe/value_or.pass.cpp
Index:
test/std/utilities/optional/optional.object/optional.object.observe/
ahatanak added a comment.
I guess it doesn't build because output constraints need "=" (e.g., "=D")?
Also, I think all registers ("D", "S", and "c") should be in both the output
and input operands list. You can probably declare new variables and use them in
the output operands (e.g., "=D"(newD
Author: kromanova
Date: Tue Dec 27 12:53:29 2016
New Revision: 290619
URL: http://llvm.org/viewvc/llvm-project?rev=290619&view=rev
Log:
[DOXYGEN] Improved doxygen comments for xmmintrin.h intrinsics.
Added \n commands to insert a line breaks where necessary, since one long line
of documentation
rnk added a comment.
I think you uploaded the wrong patch on the last upload, the code looks like
it's related to __attribute__((deprecated)) now?
https://reviews.llvm.org/D27529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
cpplearner updated this revision to Diff 82551.
https://reviews.llvm.org/D27850
Files:
include/experimental/optional
include/optional
test/std/experimental/optional/optional.object/optional.object.observe/value_or.pass.cpp
test/std/utilities/optional/optional.object/optional.object.obse
Both work:
#define DECLARE_ASM_REP_MOVS(Type, Movs)
\
template <> void asm_rep_movs(Type * dst, Type * src, size_t size)
{ \
__asm__("rep " Movs " \n\t"
\
: "+D"(dst), "+S"(src), "+c"(size) \
: \
: "memory"); \
}
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
The changes to `` LGTM but not the ones to ``
Unfortunately libc++'s `` doesn't yet implement LFTS v2
so all of the other non-const observers are also not constexpr in our
implementation. I t
ioeric added inline comments.
Comment at: include/clang/Format/Format.h:862
///
/// \returns FormatStyle as specified by ``StyleName``. If no style could be
/// determined, the default is LLVM Style (see ``getLLVMStyle()``).
Is this still true?
=
Author: ericwf
Date: Tue Dec 27 13:59:50 2016
New Revision: 290624
URL: http://llvm.org/viewvc/llvm-project?rev=290624&view=rev
Log:
Fix PR31481 - 3+ parameter common_type isn't SFINAE friendly
Modified:
libcxx/trunk/include/type_traits
libcxx/trunk/test/std/utilities/meta/meta.trans/met
Hi Eigen folks,
Clang (and GCC) recently implemented C++ DR 1495 (wg21.link/cwg1495), which
says that a class template partial specialization is ill-formed if it is
not more specialized than the primary template. (If we imagine the primary
template had a corresponding partial specialization, we re
Author: rsmith
Date: Tue Dec 27 14:03:09 2016
New Revision: 290625
URL: http://llvm.org/viewvc/llvm-project?rev=290625&view=rev
Log:
Add warning flag for "partial specialization is not more specialized than
primary template" error (since Eigen hits it), and while I'm here also add a
warning flag
On 27 December 2016 at 10:41, Richard Smith wrote:
> On 27 Dec 2016 1:42 am, "Chandler Carruth via cfe-commits" <
> cfe-commits@lists.llvm.org> wrote:
>
> I suspect that this commit is responsible for a regression parsing widely
> used open source packages like Eigen.
>
> See the code in Eigen he
malcolm.parsons accepted this revision.
malcolm.parsons added a comment.
LGTM!
https://reviews.llvm.org/D27210
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
amaiorano added a comment.
Thank you, @ioeric for your feedback!
Comment at: include/clang/Format/Format.h:862
///
/// \returns FormatStyle as specified by ``StyleName``. If no style could be
/// determined, the default is LLVM Style (see ``getLLVMStyle()``).
---
Id really rather not change the behavior. We would generate ELF style PIC,
which obviously doesn't work.
On Tue, Dec 27, 2016 at 10:09 AM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, Dec 26, 2016 at 03:35:25AM -, Saleem Abdulrasool via
> cfe-commits wrot
Author: ericwf
Date: Tue Dec 27 15:16:48 2016
New Revision: 290627
URL: http://llvm.org/viewvc/llvm-project?rev=290627&view=rev
Log:
Implement P0435R1 - Resolving LWG issues for common_type
Modified:
libcxx/trunk/include/type_traits
libcxx/trunk/test/std/utilities/meta/meta.trans/meta.tr
Author: malcolm.parsons
Date: Tue Dec 27 16:01:37 2016
New Revision: 290630
URL: http://llvm.org/viewvc/llvm-project?rev=290630&view=rev
Log:
[clang-tidy] Replace dead link in modernize-pass-by-value doc
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/modernize-pass-by-value.rst
Mod
Author: dblaikie
Date: Tue Dec 27 16:05:35 2016
New Revision: 290631
URL: http://llvm.org/viewvc/llvm-project?rev=290631&view=rev
Log:
DebugInfo: Don't include size/alignment on class declarations
This seems like it must've been a leftover by accident - no tests were
backing it up & it doesn't ma
Author: malcolm.parsons
Date: Tue Dec 27 16:14:40 2016
New Revision: 290633
URL: http://llvm.org/viewvc/llvm-project?rev=290633&view=rev
Log:
[clang-tidy] Make 2 checks register matchers for C++ only.
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/UseEqualsDeleteCheck.cpp
clang-to
EricWF created this revision.
EricWF added reviewers: mclow.lists, vsk.
EricWF added a subscriber: cfe-commits.
This patch fixes llvm.org/PR31402 by replacing `map::__find_equal_key` with
`__tree::__find_equal`, which has already addressed the same undefined behavior.
Unfortunately I haven't bee
On Tue, Dec 27, 2016 at 12:41:08PM -0800, Saleem Abdulrasool wrote:
> Id really rather not change the behavior. We would generate ELF style PIC,
> which obviously doesn't work.
That's not what I mean. I simply say that we should ignore
-fPIC/-fpic/-fPIE/-fpie on Windows, silently. The relality is
Author: mkuper
Date: Tue Dec 27 18:30:43 2016
New Revision: 290642
URL: http://llvm.org/viewvc/llvm-project?rev=290642&view=rev
Log:
Update test that relies on the optimizer to match new output.
Modified:
cfe/trunk/test/CodeGen/avx-shuffle-builtins.c
Modified: cfe/trunk/test/CodeGen/avx-shuf
kcc created this revision.
kcc added reviewers: compnerd, mehdi_amini, mclow.lists.
kcc added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.
All easy-to-find bugs in cxa_demangle where fixed now
(https://bugs.chromium.org/p/chromium/issues/detail?id=606626)
except for one (https://l
mehdi_amini added inline comments.
Comment at: fuzz/CMakeLists.txt:3
+if( LLVM_USE_SANITIZE_COVERAGE )
+ set(LLVM_LINK_COMPONENTS support)
+
This is a dependency on libLLVMSupport right? Why is this needed?
https://reviews.llvm.org/D28133
__
Author: rsmith
Date: Tue Dec 27 20:37:25 2016
New Revision: 290647
URL: http://llvm.org/viewvc/llvm-project?rev=290647&view=rev
Log:
DR1315: a non-type template argument in a partial specialization is permitted
to make reference to template parameters. This is only a partial
implementation; we ret
kcc updated this revision to Diff 82571.
kcc added a comment.
remove unneeded set(LLVM_LINK_COMPONENTS support)
https://reviews.llvm.org/D28133
Files:
CMakeLists.txt
fuzz/
fuzz/CMakeLists.txt
fuzz/cxa_demangle_fuzzer.cpp
Index: fuzz/cxa_demangle_fuzzer.cpp
===
kcc marked an inline comment as done.
kcc added a comment.
yes, removed.
https://reviews.llvm.org/D28133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM.
(I can't test because LLVM_USE_SANITIZE_COVERAGE seems broken on Darwin)
https://reviews.llvm.org/D28133
___
cfe-commits mailing
Author: kcc
Date: Tue Dec 27 21:28:29 2016
New Revision: 290650
URL: http://llvm.org/viewvc/llvm-project?rev=290650&view=rev
Log:
add cxa_demangle_fuzzer
Summary:
All easy-to-find bugs in cxa_demangle where fixed now
(https://bugs.chromium.org/p/chromium/issues/detail?id=606626)
except for one (h
Author: ericwf
Date: Tue Dec 27 22:58:52 2016
New Revision: 290651
URL: http://llvm.org/viewvc/llvm-project?rev=290651&view=rev
Log:
Implement a throwing version of _LIBCPP_ASSERT.
This patch implements changes to allow _LIBCPP_ASSERT to throw on failure
instead of aborting. The main changes need
Author: ericwf
Date: Tue Dec 27 23:20:27 2016
New Revision: 290652
URL: http://llvm.org/viewvc/llvm-project?rev=290652&view=rev
Log:
Fix debug mode build w/o exceptions
Modified:
libcxx/trunk/include/__debug
libcxx/trunk/lib/abi/CHANGELOG.TXT
libcxx/trunk/src/debug.cpp
Modified: libc
Author: ericwf
Date: Tue Dec 27 23:26:56 2016
New Revision: 290653
URL: http://llvm.org/viewvc/llvm-project?rev=290653&view=rev
Log:
Fix build errors in C++03 caused by recent debug changes
Modified:
libcxx/trunk/include/__debug
libcxx/trunk/test/libcxx/debug/debug_throw.pass.cpp
Modifie
Author: ericwf
Date: Tue Dec 27 23:35:32 2016
New Revision: 290654
URL: http://llvm.org/viewvc/llvm-project?rev=290654&view=rev
Log:
Fix __wrap_iter in debug mode and apply _NOEXCEPT_DEBUG to it
Modified:
libcxx/trunk/include/algorithm
libcxx/trunk/include/iterator
Modified: libcxx/trunk
Author: ericwf
Date: Tue Dec 27 23:53:01 2016
New Revision: 290655
URL: http://llvm.org/viewvc/llvm-project?rev=290655&view=rev
Log:
Add tests for unordered container tests and std::string
Added:
libcxx/trunk/test/libcxx/debug/containers/
libcxx/trunk/test/libcxx/debug/containers/db_strin
Author: ericwf
Date: Tue Dec 27 23:56:16 2016
New Revision: 290656
URL: http://llvm.org/viewvc/llvm-project?rev=290656&view=rev
Log:
Fix stupid build error caused by a stupid person
Modified:
libcxx/trunk/include/__debug
Modified: libcxx/trunk/include/__debug
URL:
http://llvm.org/viewvc/llv
Author: ericwf
Date: Wed Dec 28 00:06:09 2016
New Revision: 290657
URL: http://llvm.org/viewvc/llvm-project?rev=290657&view=rev
Log:
Fix debug mode for vector/list and cleanup tests
Added:
libcxx/trunk/test/libcxx/debug/containers/db_associative_container_tests.pass.cpp
libcxx/trunk/tes
Author: ericwf
Date: Wed Dec 28 00:15:01 2016
New Revision: 290658
URL: http://llvm.org/viewvc/llvm-project?rev=290658&view=rev
Log:
Ensure <__debug> gets the nullptr definition in C++03
Modified:
libcxx/trunk/include/__debug
Modified: libcxx/trunk/include/__debug
URL:
http://llvm.org/viewv
Author: ericwf
Date: Wed Dec 28 00:21:09 2016
New Revision: 290659
URL: http://llvm.org/viewvc/llvm-project?rev=290659&view=rev
Log:
Remove dead debug_mode doc link
Modified:
libcxx/trunk/docs/index.rst
Modified: libcxx/trunk/docs/index.rst
URL:
http://llvm.org/viewvc/llvm-project/libcxx/tr
Author: rsmith
Date: Wed Dec 28 00:27:18 2016
New Revision: 290660
URL: http://llvm.org/viewvc/llvm-project?rev=290660&view=rev
Log:
Mark 'auto' as dependent when instantiating the type of a non-type template
parameter. Fixes failed deduction for 'auto' non-type template parameters
nested within t
EricWF abandoned this revision.
EricWF added a comment.
This was already committed.
https://reviews.llvm.org/D13332
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF abandoned this revision.
EricWF added a comment.
This is long dead.
https://reviews.llvm.org/D13796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF abandoned this revision.
EricWF added a comment.
Already committed.
https://reviews.llvm.org/D20800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF abandoned this revision.
EricWF added a comment.
Another version of this has already been committed.
https://reviews.llvm.org/D23495
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
EricWF abandoned this revision.
EricWF added a comment.
Another version of this has already been committed.
https://reviews.llvm.org/D24599
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: gbiv
Date: Wed Dec 28 01:27:40 2016
New Revision: 290661
URL: http://llvm.org/viewvc/llvm-project?rev=290661&view=rev
Log:
[CodeGen] Unique constant CompoundLiterals.
Our newly aggressive constant folding logic makes it possible for
CGExprConstant to see the same CompoundLiteralExpr more
60 matches
Mail list logo