[PATCH] D28296: [ObjC] The declarator for a block literal should be a definition

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D28296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28258: [Sema] Handle invalid noexcept expressions correctly.

hintonda abandoned this revision. hintonda added a comment. Unable to test change here, so have included fix directly in https://reviews.llvm.org/D20428. https://reviews.llvm.org/D28258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20428: Tracking exception specification source locations

hintonda updated this revision to Diff 83346. hintonda added a comment. - Fix compile errors. - When noexcept expr is invalid, set NoexceptType to EST_BasicNoexcept https://reviews.llvm.org/D20428 Files: include/clang/AST/Decl.h include/clang/AST/TypeLoc.h lib/AST/Decl.cpp

Re: r291123 - CodeGen: plumb header search down to the IAS

Thanks! -eric On Thu, Jan 5, 2017 at 6:38 PM Saleem Abdulrasool wrote: > SVN r291208 > > On Thu, Jan 5, 2017 at 6:30 PM, Eric Christopher > wrote: > > Ok, thanks. I agree that it's a problem. I'm definitely open for testing > ideas here. There are a

Re: [libcxx] r291192 - config_elast: fix typo (NFC)

On Thu, Jan 5, 2017 at 3:25 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Thu Jan 5 17:25:44 2017 > New Revision: 291192 > > URL: http://llvm.org/viewvc/llvm-project?rev=291192=rev > Log: > config_elast: fix typo (NFC) > > Missed the

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

xiangzhai updated this revision to Diff 83339. xiangzhai added a comment. Hi Anna, Thanks for your review! I resubmit the patch with context, please check is it correct, thanks a lot! And I add testcase: test/Analysis/gmalloc.c Repository: rL LLVM https://reviews.llvm.org/D28348 Files:

Re: r291123 - CodeGen: plumb header search down to the IAS

SVN r291208 On Thu, Jan 5, 2017 at 6:30 PM, Eric Christopher wrote: > Ok, thanks. I agree that it's a problem. I'm definitely open for testing > ideas here. There are a few other things in the > TargetOptions/MCTargetOptions area that are already problematic to test. > >

r291208 - CodeGen: address post commit review comments for r291123

Author: compnerd Date: Thu Jan 5 20:27:40 2017 New Revision: 291208 URL: http://llvm.org/viewvc/llvm-project?rev=291208=rev Log: CodeGen: address post commit review comments for r291123 This test would force the execution of the backend. However, the backend already has a test for this.

Re: r291123 - CodeGen: plumb header search down to the IAS

Ok, thanks. I agree that it's a problem. I'm definitely open for testing ideas here. There are a few other things in the TargetOptions/MCTargetOptions area that are already problematic to test. -eric On Thu, Jan 5, 2017 at 6:27 PM Saleem Abdulrasool wrote: > This was

Re: r291123 - CodeGen: plumb header search down to the IAS

Hi Saleem, Love that you wanted to add a test for it, but I'd really prefer that you not engage the backend here in order to do it. You can verify some of it from the backend and just that the module is correct via the front end if you'd like. Ensuring the paths are correct is a bit of a sticky

[clang-tools-extra] r291203 - Fixes for Clang API change

Author: dblaikie Date: Thu Jan 5 19:09:06 2017 New Revision: 291203 URL: http://llvm.org/viewvc/llvm-project?rev=291203=rev Log: Fixes for Clang API change Modified: clang-tools-extra/trunk/modularize/ModularizeUtilities.cpp clang-tools-extra/trunk/modularize/ModularizeUtilities.h

r291202 - shared_ptrify (from InclusiveRefCntPtr) HeaderSearchOptions

Author: dblaikie Date: Thu Jan 5 19:04:46 2017 New Revision: 291202 URL: http://llvm.org/viewvc/llvm-project?rev=291202=rev Log: shared_ptrify (from InclusiveRefCntPtr) HeaderSearchOptions Modified: cfe/trunk/include/clang/Frontend/ASTUnit.h

[PATCH] D28387: [tsan] Do not report errors in __destroy_helper_block_

zaks.anna created this revision. zaks.anna added a reviewer: kubabrecka. zaks.anna added a subscriber: cfe-commits. There is a synchronization point between the reference count of a block dropping to zero and it's destruction, which TSan does not observe. Do not report errors in the

[PATCH] D28383: build: add a heuristic to determine the C++ ABI

rnk added a comment. In https://reviews.llvm.org/D28383#637570, @majnemer wrote: > Why isn't this equivalent to `_MSC_VER` ? It might also be nice for clang to define some macro to indicate which C++ ABI is in use. All that said, I think it makes sense to encode this in libc++

[PATCH] D28212: typeinfo: provide a partial implementation for Win32

compnerd set the repository for this revision to rL LLVM. compnerd updated this revision to Diff 83326. Repository: rL LLVM https://reviews.llvm.org/D28212 Files: include/typeinfo src/typeinfo.cpp Index: src/typeinfo.cpp ===

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

hamzasood updated this revision to Diff 83325. hamzasood added a comment. Improved the code slightly. Sorry for the spam everyone, this is definitely the one. https://reviews.llvm.org/D28365 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/MSVCToolChain.cpp

[PATCH] D28383: build: add a heuristic to determine the C++ ABI

smeenai added a comment. In https://reviews.llvm.org/D28383#637570, @majnemer wrote: > Why isn't this equivalent to `_MSC_VER` ? You can have scenarios where you're targeting the Itanium ABI but still have `_MSC_VER` defined, e.g. % clang -target i686-windows-itanium -fmsc-version=1900 -E

[PATCH] D28383: build: add a heuristic to determine the C++ ABI

majnemer added a comment. Why isn't this equivalent to `_MSC_VER` ? Repository: rL LLVM https://reviews.llvm.org/D28383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28385: Add a cc1 option to force disabling lifetime-markers emission from clang

mehdi_amini created this revision. mehdi_amini added reviewers: chandlerc, rsmith. mehdi_amini added a subscriber: cfe-commits. This intended as a debugging/development flag only. https://reviews.llvm.org/D28385 Files: clang/include/clang/Driver/CC1Options.td

[PATCH] D28258: [Sema] Handle invalid noexcept expressions correctly.

rsmith added a comment. Looks OK. Is it possible to add a test case for this without https://reviews.llvm.org/D20428? If not, this is small enough that rolling it into https://reviews.llvm.org/D20428 (so it can be committed with its testcase) would make sense. https://reviews.llvm.org/D28258

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

hamzasood updated this revision to Diff 83318. hamzasood added a comment. - Re-implemented the PATH searching behaviour (thanks @amccarth for pointing that out) - Updated the base revision. https://reviews.llvm.org/D28365 Files: include/clang/Basic/DiagnosticDriverKinds.td

[libcxx] r291192 - config_elast: fix typo (NFC)

Author: compnerd Date: Thu Jan 5 17:25:44 2017 New Revision: 291192 URL: http://llvm.org/viewvc/llvm-project?rev=291192=rev Log: config_elast: fix typo (NFC) Missed the original typo which was duplicated. NFC. Modified: libcxx/trunk/src/include/config_elast.h Modified:

r291191 - Fix bug where types other than 'cv auto', 'cv auto &', and 'cv auto &&' could

Author: rsmith Date: Thu Jan 5 17:12:16 2017 New Revision: 291191 URL: http://llvm.org/viewvc/llvm-project?rev=291191=rev Log: Fix bug where types other than 'cv auto', 'cv auto &', and 'cv auto &&' could incorrectly be deduced from an initializer list in pathological cases. Modified:

[PATCH] D28383: build: add a heuristic to determine the C++ ABI

compnerd created this revision. compnerd added reviewers: EricWF, mclow.lists, smeenai, kastiglione. compnerd added subscribers: cfe-commits, rnk. compnerd set the repository for this revision to rL LLVM. Herald added a subscriber: mgorny. We need to have a more principled method to detect the

[PATCH] D27429: [Chrono][Darwin] On Darwin use CLOCK_UPTIME_RAW instead of CLOCK_MONOTONIC

bruno added a comment. @EricWF ok to commit? https://reviews.llvm.org/D27429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r291190 - Add missing "original call argument has same type as deduced parameter type"

Author: rsmith Date: Thu Jan 5 17:02:44 2017 New Revision: 291190 URL: http://llvm.org/viewvc/llvm-project?rev=291190=rev Log: Add missing "original call argument has same type as deduced parameter type" check for deductions from elements of a braced-init-list. Modified:

Re: r291179 - Add vec_insert4b and vec_extract4b functions to altivec.h

  Sorry about that I've removed the  2 tests causing the issue for now.   Sean   - Original message -From: Evgenii Stepanov To: Sean Fertile/Toronto/IBM@IBMCACc: cfe-commits Subject: Re: r291179 - Add vec_insert4b and vec_extract4b

r291188 - Remove the ppc insertword/extractword expected fail tests.

Author: sfertile Date: Thu Jan 5 16:54:34 2017 New Revision: 291188 URL: http://llvm.org/viewvc/llvm-project?rev=291188=rev Log: Remove the ppc insertword/extractword expected fail tests. Removed: cfe/trunk/test/CodeGen/builtins-ppc-extractword-error.c

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

firolino added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:34 + // a tag declaration (e.g. struct, class etc.): + // class A { } Object1, Object2; <-- won't be matched + Finder->addMatcher( aaron.ballman wrote: >

[clang-tools-extra] r291186 - Fix for shared_ptrification in Clang

Author: dblaikie Date: Thu Jan 5 16:44:07 2017 New Revision: 291186 URL: http://llvm.org/viewvc/llvm-project?rev=291186=rev Log: Fix for shared_ptrification in Clang Modified: clang-tools-extra/trunk/include-fixer/IncludeFixer.cpp clang-tools-extra/trunk/include-fixer/IncludeFixer.h

[PATCH] D28381: [WebAssembly] Always inline atomics

jgravelle-google created this revision. jgravelle-google added reviewers: dschuff, sunfish. jgravelle-google added a subscriber: cfe-commits. Herald added a subscriber: jfb. Wasm MVP doesn't have any mechanism to respect atomicity. Skip emitting libcalls for the time being.

r291185 - Fix examples for recent shared_ptrification

Author: dblaikie Date: Thu Jan 5 16:36:44 2017 New Revision: 291185 URL: http://llvm.org/viewvc/llvm-project?rev=291185=rev Log: Fix examples for recent shared_ptrification Modified: cfe/trunk/examples/clang-interpreter/main.cpp Modified: cfe/trunk/examples/clang-interpreter/main.cpp URL:

[PATCH] D28231: -Wunreachable-code: Avoid multiple diagnostics that are triggered by the same source range and fix the unary operator fixit source range

ahatanak added inline comments. Comment at: lib/Analysis/ReachableCode.cpp:229 + if (SilenceableCondValNotSet && SilenceableCondVal->getBegin().isValid()) +*SilenceableCondVal = UO->getSourceRange(); + return UO->getOpcode() == UO_LNot && IsSubExprConfigValue;

r291184 - IntrusiveRefCntPtr -> std::shared_ptr for CompilerInvocationBase and CodeCompleteConsumer

Author: dblaikie Date: Thu Jan 5 16:19:11 2017 New Revision: 291184 URL: http://llvm.org/viewvc/llvm-project?rev=291184=rev Log: IntrusiveRefCntPtr -> std::shared_ptr for CompilerInvocationBase and CodeCompleteConsumer Modified: cfe/trunk/include/clang/Frontend/ASTUnit.h

Re: r291179 - Add vec_insert4b and vec_extract4b functions to altivec.h

Tests on linux/x86_64 are failing with: fatal error: error in backend: Cannot select: intrinsic %llvm.ppc.vsx.xxinsertw On Thu, Jan 5, 2017 at 1:43 PM, Sean Fertile via cfe-commits wrote: > Author: sfertile > Date: Thu Jan 5 15:43:30 2017 > New Revision: 291179 > >

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

amccarth added a comment. (I could be missing something because the diff doesn't have much context.) If I'm reading this right, it looks like it will no longer search the PATH in order to find cl.exe. If that's the case, then I'm mildly worried about this change in behavior. I know I have

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

hamzasood updated this revision to Diff 83303. hamzasood added a comment. - Fixed an error in retrieving a toolchain path from the registry. - Updated the base revision. https://reviews.llvm.org/D28365 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/MSVCToolChain.cpp

r291179 - Add vec_insert4b and vec_extract4b functions to altivec.h

Author: sfertile Date: Thu Jan 5 15:43:30 2017 New Revision: 291179 URL: http://llvm.org/viewvc/llvm-project?rev=291179=rev Log: Add vec_insert4b and vec_extract4b functions to altivec.h Add builtins for the functions and custom codegen mapping the builtins to their corresponding intrinsics and

[PATCH] D28242: [ubsan] Minimize size of data for type_mismatch (Redo of D19667)

vitalybuka added a comment. LGTM, but I am not the owner. https://reviews.llvm.org/D28242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28304: [compiler-rt] [cmake] Disable appending -msse4.2 flag implicitly

mgorny added a comment. @cryptoad good to go then? https://reviews.llvm.org/D28304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28304: [compiler-rt] [cmake] Disable appending -msse4.2 flag implicitly

mgorny retitled this revision from "[compiler-rt] [cmake] Disable appending -msse* flags implicitly" to "[compiler-rt] [cmake] Disable appending -msse4.2 flag implicitly". mgorny updated the summary for this revision. mgorny updated this revision to Diff 83298. https://reviews.llvm.org/D28304

[PATCH] D28304: [compiler-rt] [cmake] Disable appending -msse* flags implicitly

mgorny added a comment. Oh, sorry that I didn't check that. Then I guess it's good enough for me, we're losing just few old Athlon 64 CPUs, I guess. I'll update the patch to remove 4.2 only. https://reviews.llvm.org/D28304 ___ cfe-commits mailing

[libcxx] r291174 - typeinfo: style adjustments for adding MS ABI RTTI

Author: compnerd Date: Thu Jan 5 15:22:22 2017 New Revision: 291174 URL: http://llvm.org/viewvc/llvm-project?rev=291174=rev Log: typeinfo: style adjustments for adding MS ABI RTTI This is motivated by adding a third RTTI scheme to libc++. Split out the two forms of the itanium RTTI

[PATCH] D28220: provide Win32 native threading

halyavin added inline comments. Comment at: include/__threading_support:474 + system_clock::time_point(duration_cast(duration)); + auto timeout_ms = duration_cast(abstime - system_clock::now()); + compnerd wrote: > halyavin wrote: > > Since negative

r291170 - If an explicitly-specified pack might have been extended by template argument

Author: rsmith Date: Thu Jan 5 14:27:28 2017 New Revision: 291170 URL: http://llvm.org/viewvc/llvm-project?rev=291170=rev Log: If an explicitly-specified pack might have been extended by template argument deduction, don't forget to check the argument is valid. Modified:

[PATCH] D28304: [compiler-rt] [cmake] Disable appending -msse* flags implicitly

dvyukov added a comment. > I don't see a big issue enabling it for x86-64 but for 32-bit systems you're > ruling out quite a lot of hardware. Tsan does not support 32-bits. https://reviews.llvm.org/D28304 ___ cfe-commits mailing list

r291167 - Move SerializedDiagnosticPrinter's SharedState to std::shared_ptr rather than IntrusiveRefCntPtr

Author: dblaikie Date: Thu Jan 5 13:48:10 2017 New Revision: 291167 URL: http://llvm.org/viewvc/llvm-project?rev=291167=rev Log: Move SerializedDiagnosticPrinter's SharedState to std::shared_ptr rather than IntrusiveRefCntPtr Modified: cfe/trunk/lib/Frontend/SerializedDiagnosticPrinter.cpp

r291166 - Move Preprocessor over to std::shared_ptr rather than IntrusiveRefCntPtr

Author: dblaikie Date: Thu Jan 5 13:48:07 2017 New Revision: 291166 URL: http://llvm.org/viewvc/llvm-project?rev=291166=rev Log: Move Preprocessor over to std::shared_ptr rather than IntrusiveRefCntPtr Modified: cfe/trunk/include/clang/Frontend/ASTUnit.h

r291159 - Move FailedModulesSet over to shared_ptr from IntrusiveRefCntPtr

Author: dblaikie Date: Thu Jan 5 13:11:31 2017 New Revision: 291159 URL: http://llvm.org/viewvc/llvm-project?rev=291159=rev Log: Move FailedModulesSet over to shared_ptr from IntrusiveRefCntPtr Modified: cfe/trunk/include/clang/Lex/PreprocessorOptions.h

r291160 - Move PreprocessorOptions to std::shared_ptr from IntrusiveRefCntPtr

Author: dblaikie Date: Thu Jan 5 13:11:36 2017 New Revision: 291160 URL: http://llvm.org/viewvc/llvm-project?rev=291160=rev Log: Move PreprocessorOptions to std::shared_ptr from IntrusiveRefCntPtr Modified: cfe/trunk/include/clang/Frontend/CompilerInvocation.h

r291156 - Move VariantMatcher's Payload to std::shared_ptr rather than IntrusiveRefCntPtr

Author: dblaikie Date: Thu Jan 5 12:51:54 2017 New Revision: 291156 URL: http://llvm.org/viewvc/llvm-project?rev=291156=rev Log: Move VariantMatcher's Payload to std::shared_ptr rather than IntrusiveRefCntPtr Modified: cfe/trunk/include/clang/ASTMatchers/Dynamic/VariantValue.h

r291155 - Simplify ASTReader ctor by using in-class initializers for many member variables

Author: dblaikie Date: Thu Jan 5 12:45:45 2017 New Revision: 291155 URL: http://llvm.org/viewvc/llvm-project?rev=291155=rev Log: Simplify ASTReader ctor by using in-class initializers for many member variables Modified: cfe/trunk/include/clang/Serialization/ASTWriter.h

r291154 - Simplify ASTReader ctor by using in-class initializers (NSDMIs to the rest of you) for many member variables

Author: dblaikie Date: Thu Jan 5 12:45:43 2017 New Revision: 291154 URL: http://llvm.org/viewvc/llvm-project?rev=291154=rev Log: Simplify ASTReader ctor by using in-class initializers (NSDMIs to the rest of you) for many member variables Modified:

[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

manmanren added inline comments. Comment at: include/clang/Basic/DiagnosticSerializationKinds.td:131 + "diagnostic options now it is a non-system module">, + InGroup; + aprantl wrote: > Is this better? > > "module file '%0' was validated as a system module

[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

manmanren updated this revision to Diff 83273. manmanren added a comment. Add testing case. https://reviews.llvm.org/D28299 Files: include/clang/Basic/DiagnosticSerializationKinds.td include/clang/Basic/FileManager.h include/clang/Serialization/ASTReader.h

[PATCH] D28299: Module: use PCMCache to manage memory buffers for pcm files.

manmanren added a comment. I forgot to upload the testing case, I will add it now. Manman Comment at: include/clang/Basic/FileManager.h:176 + /// Manage memory buffers associated with pcm files. + std::unique_ptr BufferMgr; + benlangmuir wrote: > Why is

[PATCH] D28362: [ThinLTO] Optionally ignore empty index file

mehdi_amini added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:65 +"Ignore an empty index file and perform non-ThinLTO compilation"), +llvm::cl::init(false)); + Is it common to do this in clang? https://reviews.llvm.org/D28362

r291150 - Use shared_ptr instead of IntrusiveRefCntPtr for ModuleFileExtension

Author: dblaikie Date: Thu Jan 5 12:23:18 2017 New Revision: 291150 URL: http://llvm.org/viewvc/llvm-project?rev=291150=rev Log: Use shared_ptr instead of IntrusiveRefCntPtr for ModuleFileExtension The intrusiveness wasn't needed here, so this simplifies/clarifies the ownership model.

[PATCH] D27424: Add the diagnose_if attribute to clang.

aaron.ballman added a comment. In https://reviews.llvm.org/D27424#636496, @george.burgess.iv wrote: > Do we have a page that details when we should/shouldn't use `auto`? I was > under the impression that it was preferred only in cases where the type's > spelled out (e.g. `cast`, ...). (To be

[PATCH] D28220: provide Win32 native threading

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: include/__threading_support:474 + system_clock::time_point(duration_cast(duration)); + auto timeout_ms = duration_cast(abstime - system_clock::now()); + halyavin wrote:

r291148 - Typo

Author: joerg Date: Thu Jan 5 11:59:44 2017 New Revision: 291148 URL: http://llvm.org/viewvc/llvm-project?rev=291148=rev Log: Typo Modified: cfe/trunk/unittests/Format/FormatTestJS.cpp Modified: cfe/trunk/unittests/Format/FormatTestJS.cpp URL:

[PATCH] D28338: thread_support: split out {,non-}recursive mutex

compnerd closed this revision. compnerd added a comment. SVN r291145 Repository: rL LLVM https://reviews.llvm.org/D28338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r291145 - thread_support: split out {,non-}recursive mutex

Author: compnerd Date: Thu Jan 5 11:54:45 2017 New Revision: 291145 URL: http://llvm.org/viewvc/llvm-project?rev=291145=rev Log: thread_support: split out {,non-}recursive mutex Split out the recursive and non-recursive mutex. This split is needed for platforms which may use differing types

[PATCH] D28330: [analyzer] Fix false positives in Keychain API checker

zaks.anna added a comment. I did not think of solution #1! It's definitely better than the pattern matching I've added here. However, this checker fires so infrequently, that I do not think it's worth investing more time into perfecting it. I suspect the solution #2 is what this checker was

Re: Fix for Visual Studio 2017

I’ve submitted an updated version via Phabricator (https://reviews.llvm.org/D28365 ), so this one can be ignored.___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28365: [Driver] Updated for Visual Studio 2017

hamzasood created this revision. hamzasood added reviewers: rnk, ruiu, hans. hamzasood added a subscriber: cfe-commits. The patch updates the MSVC ToolChain for the changes made in Visual Studio 2017 (https://blogs.msdn.microsoft.com/vcblog/2016/10/07/compiler-tools-layout-in-visual-studio-15/).

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

aaron.ballman added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:34 + // a tag declaration (e.g. struct, class etc.): + // class A { } Object1, Object2; <-- won't be matched + Finder->addMatcher( firolino wrote: >

[PATCH] D28348: Taught the analyzer about Glib API to check Memory-leak

zaks.anna added a comment. Thanks for the patch! Could you, please, resubmit the patch with context as described here http://llvm.org/docs/Phabricator.html Also, please, add tests. See test/Analysis/ for examples. Repository: rL LLVM https://reviews.llvm.org/D28348

r291143 - Migrate PathDiagnosticPiece to std::shared_ptr

Author: dblaikie Date: Thu Jan 5 11:26:53 2017 New Revision: 291143 URL: http://llvm.org/viewvc/llvm-project?rev=291143=rev Log: Migrate PathDiagnosticPiece to std::shared_ptr Simplifies and makes explicit the memory ownership model rather than implicitly passing/acquiring ownership. Modified:

[PATCH] D28362: [ThinLTO] Optionally ignore empty index file

tejohnson created this revision. tejohnson added a reviewer: mehdi_amini. tejohnson added a subscriber: cfe-commits. In order to simplify distributed build system integration, where actions may be scheduled before the Thin Link which determines the list of objects selected by the linker. The gold

[PATCH] D28131: [libcxx] Fix PR31402: map::__find_equal_key has undefined behavior.

mclow.lists added inline comments. Comment at: include/__tree:1400 __parent_pointer& __parent, const key_type& __v); +// FIXME: Make this function const qualified. Unfortunetly doing so +// breaks existing code which uses non-const callable

r291142 - test: add a requires registered target

Author: compnerd Date: Thu Jan 5 11:09:20 2017 New Revision: 291142 URL: http://llvm.org/viewvc/llvm-project?rev=291142=rev Log: test: add a requires registered target It seems that the ARM buildbots do not include x86 support. However, other x86 targets do not support the ARM target. Use a

[PATCH] D28323: [CUDA] Let NVPTX inherit the host's calling conventions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291136: [CUDA] Let NVPTX inherit the host's calling conventions. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28323?vs=83130=83259#toc Repository: rL LLVM

[PATCH] D28326: [Docs] Update docs to indicate that CUDA compilation is supported on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291139: [Docs] Update docs to indicate that CUDA compilation is supported on Windows. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28326?vs=83134=83262#toc Repository: rL

[PATCH] D28325: [CUDA] Rename keywords used in macro so they don't conflict with MSVC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291138: [CUDA] Rename keywords used in macro so they don't conflict with MSVC. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28325?vs=83133=83261#toc Repository: rL LLVM

[PATCH] D28317: [Windows] Remove functions in intrin.h that are defined in Builtin.def.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291128: [Windows] Remove functions in intrin.h that are defined in Builtin.def. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28317?vs=83124=83252#toc Repository: rL LLVM

r291138 - [CUDA] Rename keywords used in macro so they don't conflict with MSVC.

Author: jlebar Date: Thu Jan 5 10:54:11 2017 New Revision: 291138 URL: http://llvm.org/viewvc/llvm-project?rev=291138=rev Log: [CUDA] Rename keywords used in macro so they don't conflict with MSVC. Summary: MSVC seems to use "__in" and "__out" for its own purposes, so we have to pick different

[PATCH] D28324: [CUDA] Don't define functions that the CUDA headers themselves define on Windows.

This revision was automatically updated to reflect the committed changes. jlebar marked an inline comment as done. Closed by commit rL291137: [CUDA] Don't define functions that the CUDA headers themselves define on… (authored by jlebar). Changed prior to commit:

r291137 - [CUDA] Don't define functions that the CUDA headers themselves define on Windows.

Author: jlebar Date: Thu Jan 5 10:53:55 2017 New Revision: 291137 URL: http://llvm.org/viewvc/llvm-project?rev=291137=rev Log: [CUDA] Don't define functions that the CUDA headers themselves define on Windows. Reviewers: tra Subscribers: cfe-commits Differential Revision:

r291136 - [CUDA] Let NVPTX inherit the host's calling conventions.

Author: jlebar Date: Thu Jan 5 10:53:38 2017 New Revision: 291136 URL: http://llvm.org/viewvc/llvm-project?rev=291136=rev Log: [CUDA] Let NVPTX inherit the host's calling conventions. Summary: When compiling device code, we may still see host code with explicit calling conventions. NVPTX needs

[PATCH] D28322: [CUDA] More correctly inherit primitive types from the host during device compilation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291135: [CUDA] More correctly inherit primitive types from the host during device… (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28322?vs=83129=83258#toc Repository: rL

[PATCH] D28321: [CUDA] Add __declspec spellings for CUDA attributes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291134: [CUDA] Add __declspec spellings for CUDA attributes. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28321?vs=83128=83257#toc Repository: rL LLVM

r291135 - [CUDA] More correctly inherit primitive types from the host during device compilation.

Author: jlebar Date: Thu Jan 5 10:53:21 2017 New Revision: 291135 URL: http://llvm.org/viewvc/llvm-project?rev=291135=rev Log: [CUDA] More correctly inherit primitive types from the host during device compilation. Summary: CUDA lets users share structs between the host and device, so for that

r291134 - [CUDA] Add __declspec spellings for CUDA attributes.

Author: jlebar Date: Thu Jan 5 10:53:04 2017 New Revision: 291134 URL: http://llvm.org/viewvc/llvm-project?rev=291134=rev Log: [CUDA] Add __declspec spellings for CUDA attributes. Summary: CUDA attributes are spelled __declspec(__foo__) on Windows. Reviewers: tra Subscribers: cfe-commits, rnk

[PATCH] D28320: [Driver] Driver changes to support CUDA compilation on Windows.

This revision was automatically updated to reflect the committed changes. jlebar marked an inline comment as done. Closed by commit rL291131: [Driver] Driver changes to support CUDA compilation on Windows. (authored by jlebar). Changed prior to commit:

r291133 - [ToolChains] Use "static" instead of an anonymous namespace for a function. NFC

Author: jlebar Date: Thu Jan 5 10:52:47 2017 New Revision: 291133 URL: http://llvm.org/viewvc/llvm-project?rev=291133=rev Log: [ToolChains] Use "static" instead of an anonymous namespace for a function. NFC Modified: cfe/trunk/lib/Driver/MinGWToolChain.cpp Modified:

r291131 - [Driver] Driver changes to support CUDA compilation on Windows.

Author: jlebar Date: Thu Jan 5 10:52:29 2017 New Revision: 291131 URL: http://llvm.org/viewvc/llvm-project?rev=291131=rev Log: [Driver] Driver changes to support CUDA compilation on Windows. Summary: For the most part this is straightforward: Just add a CudaInstallation object to the MSVC and

[PATCH] D28319: [CUDA] Make CUDAInstallationDetector take the host triple in its constructor.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291130: [CUDA] Make CUDAInstallationDetector take the host triple in its constructor. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28319?vs=83126=83254#toc Repository: rL

r291130 - [CUDA] Make CUDAInstallationDetector take the host triple in its constructor.

Author: jlebar Date: Thu Jan 5 10:52:11 2017 New Revision: 291130 URL: http://llvm.org/viewvc/llvm-project?rev=291130=rev Log: [CUDA] Make CUDAInstallationDetector take the host triple in its constructor. Summary: Previously it was taking the true target triple, which is not really what it

r291129 - [TableGen] Only normalize the spelling of GNU-style attributes.

Author: jlebar Date: Thu Jan 5 10:51:54 2017 New Revision: 291129 URL: http://llvm.org/viewvc/llvm-project?rev=291129=rev Log: [TableGen] Only normalize the spelling of GNU-style attributes. Summary: When Sema looks up an attribute name, it strips off leading and trailing "__" if the attribute

[PATCH] D28318: [TableGen] Only normalize the spelling of GNU-style attributes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291129: [TableGen] Only normalize the spelling of GNU-style attributes. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D28318?vs=83125=83253#toc Repository: rL LLVM

r291128 - [Windows] Remove functions in intrin.h that are defined in Builtin.def.

Author: jlebar Date: Thu Jan 5 10:51:37 2017 New Revision: 291128 URL: http://llvm.org/viewvc/llvm-project?rev=291128=rev Log: [Windows] Remove functions in intrin.h that are defined in Builtin.def. Summary: These duplicate declarations cause a problem for CUDA compiles on Windows. All

[PATCH] D28349: [Frontend] The macro that describes the Objective-C bool type should be defined in C as well

doug.gregor added a comment. The "!LangOpts.CPlusPlus" doesn't make sense to me. You're presumably defining this macro in C because the Objective-C runtime is usable from C, but that same logic applies to C++ code. It seems like we should be defining this macro unconditionally. Repository:

r291125 - test: add an explicit triple

Author: compnerd Date: Thu Jan 5 10:36:15 2017 New Revision: 291125 URL: http://llvm.org/viewvc/llvm-project?rev=291125=rev Log: test: add an explicit triple Not all targets use the integrated assembler. Specify a triple to ensure we use the integrated as for this. Modified:

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

sdardis added a comment. Ping. https://reviews.llvm.org/D25866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

firolino added inline comments. Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:34 + // a tag declaration (e.g. struct, class etc.): + // class A { } Object1, Object2; <-- won't be matched + Finder->addMatcher( aaron.ballman wrote: >

r291124 - [OpenMP] Add fields for flags in the offload entry descriptor.

Author: sfantao Date: Thu Jan 5 10:02:49 2017 New Revision: 291124 URL: http://llvm.org/viewvc/llvm-project?rev=291124=rev Log: [OpenMP] Add fields for flags in the offload entry descriptor. Summary: This patch adds two fields to the offload entry descriptor. One field is meant to signal

r291123 - CodeGen: plumb header search down to the IAS

Author: compnerd Date: Thu Jan 5 10:02:32 2017 New Revision: 291123 URL: http://llvm.org/viewvc/llvm-project?rev=291123=rev Log: CodeGen: plumb header search down to the IAS inline assembly may use the `.include` directive to include other content into the file. Without the integrated

[PATCH] D28304: [compiler-rt] [cmake] Disable appending -msse* flags implicitly

mgorny added a comment. In https://reviews.llvm.org/D28304#636669, @dvyukov wrote: > User -march flag won't help as runtime is prebuilt. I meant the flag used by the compiler vendor when compiler-rt is built. > SCUDO is sse4.2, but tsan is sse3. Do you actually see any problems with > sse3?

[PATCH] D28298: [OpenMP] Add fields for flags in the offload entry descriptor.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D28298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >