pboettch created this revision.
Herald added a subscriber: jyknight.
Make clang recognize floating point registers in inline assembler
when using the targeting Sparc.
This code now works:
static inline float fabsf(float a)
{
float res;
__asm __volatile__("fabss %1, %0;"
Erm, the revert was actually r293032, sorry about the confusion.
On 25 January 2017 at 09:34, Diana Picus wrote:
> Hi David,
>
> Sorry, but I had to revert this (r283029) because it was breaking the
> non-x86 buildbots (arm, powerpc, hexagon), with errors along the lines
> of:
> error: unknown ta
Author: rovka
Date: Wed Jan 25 01:27:05 2017
New Revision: 293032
URL: http://llvm.org/viewvc/llvm-project?rev=293032&view=rev
Log:
Revert "Use filename in linemarker when compiling preprocessed source"
This reverts commit r293004 because it broke the buildbots with "unknown CPU"
errors. I tried
Hi David,
Sorry, but I had to revert this (r283029) because it was breaking the
non-x86 buildbots (arm, powerpc, hexagon), with errors along the lines
of:
error: unknown target CPU 'cortex-a8'
Please recommit after you've fixed the issue.
Thanks,
Diana
PS: I tried to fix it in r293024, but that
Hahnfeld accepted this revision.
Hahnfeld added a comment.
This revision is now accepted and ready to land.
SGTM
https://reviews.llvm.org/D28529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: rovka
Date: Wed Jan 25 00:23:50 2017
New Revision: 293026
URL: http://llvm.org/viewvc/llvm-project?rev=293026&view=rev
Log:
Try to fix test from r293004
This test broke on a lot of non-x86 buildbots with "unknowm CPU" errors. I don't
see anything platform-specific about this test, and it
coby added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D28989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Thanks for the comments. The new version is attached.
Wrt two of your questions:
(1) “The description that you have on CheckShadowInheritedVariables isn't
really the type of comments that we have in doxygen form. Im not sure if its
in line with the rest of the code.”
I’ve read through the doxy
compnerd closed this revision.
compnerd added a comment.
SVN r293014.
https://reviews.llvm.org/D29101
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: compnerd
Date: Tue Jan 24 21:36:28 2017
New Revision: 293014
URL: http://llvm.org/viewvc/llvm-project?rev=293014&view=rev
Log:
Driver: ignore -fno-objc-arc-exception when -fno-objc-arc set
Sometime clang would be supplied -fobjc-arc -f(no)objc-arc-exceptions
and then later disable ARC wit
Richard: This ought to be ready for another round of review at this point,
I Think.
Got test cases (showing opt and non-opt behavior, direct and indirect
modular dependencies, unused modular code, etc - might need some more
comments?), flag, moved the linkage code to GetGVALinkageForFunction.
One
dblaikie updated this revision to Diff 85686.
dblaikie added a comment.
- Add test coverage
https://reviews.llvm.org/D28845
Files:
include/clang/AST/ASTContext.h
include/clang/AST/ExternalASTSource.h
include/clang/Basic/LangOptions.def
include/clang/Basic/Module.h
include/clang/Driver
Some more stylistic comments:
The description that you have on CheckShadowInheritedVariables isn't really
the type of comments that we have in doxygen form. Im not sure if its in
line with the rest of the code.
The ignore warning comments are restating what is in the code, please
remove them.
C
Oops. Should be fixed in SVN r293008.
On Mon, Jan 23, 2017 at 4:01 AM, Oliver Stannard
wrote:
> Hi Saleem,
>
> This patch is causing our internal runs of the libc++ and libc++abi tests
> to fail, because logDWARF is referenced but not defined in release builds
> (with NDEBUG defined).
>
> Howev
Author: compnerd
Date: Tue Jan 24 20:27:45 2017
New Revision: 293008
URL: http://llvm.org/viewvc/llvm-project?rev=293008&view=rev
Log:
DWARF: fix -Asserts builds
no-op the DWARF tracing macros in non-debug builds.
Modified:
libunwind/trunk/src/DwarfParser.hpp
libunwind/trunk/src/config.h
Author: arpith
Date: Tue Jan 24 20:18:43 2017
New Revision: 293005
URL: http://llvm.org/viewvc/llvm-project?rev=293005&view=rev
Log:
[OpenMP] Codegen support for 'target teams' on the host.
This patch adds support for codegen of 'target teams' on the host.
This combined directive has two captured
Author: david2050
Date: Tue Jan 24 19:55:28 2017
New Revision: 293004
URL: http://llvm.org/viewvc/llvm-project?rev=293004&view=rev
Log:
Use filename in linemarker when compiling preprocessed source
Summary:
Clang appears to always use name as specified on the command
line, whereas gcc uses the na
Hi Hans,
This is relatively minor, but it's safe and fixes a rejects-valid
regression in some configurations. Might be worth taking for Clang 4.
On 24 January 2017 at 15:18, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Tue Jan 24 17:18:28 2017
> New
According to the comment at line 239:
if (LoadedSuccessfully.count(*victim) == 0) {
// Before removing the module file, check if it was validated in an
// ancestor thread, if yes, throw a hard error instead of causing
// use-after-free in the ancestor thread.
bool IsSys
Author: arpith
Date: Tue Jan 24 19:45:59 2017
New Revision: 293003
URL: http://llvm.org/viewvc/llvm-project?rev=293003&view=rev
Log:
Reverting commit because an NVPTX patch sneaked in. Break up into two
patches.
Removed:
cfe/trunk/test/OpenMP/target_teams_codegen.cpp
cfe/trunk/test/OpenM
bruno added inline comments.
Comment at: lib/Serialization/ASTReader.cpp:3692
+ValidationConflicts);
+for (auto N : ValidationConflicts)
+ Diag(diag::err_module_ancestor_conflict) << N;
This should honor `ARR_OutOfDate`, so th
jlebar added inline comments.
Comment at: llvm/unittests/ADT/APFloatTest.cpp:3534
Op2[1])
.str();
}
timshen wrote:
> jlebar wrote:
> > Honestly I am not sure this is an improvement over writing it out by hand:
> >
> > EXPEC
Author: arpith
Date: Tue Jan 24 19:38:33 2017
New Revision: 293001
URL: http://llvm.org/viewvc/llvm-project?rev=293001&view=rev
Log:
[OpenMP] Codegen support for 'target teams' on the host.
This patch adds support for codegen of 'target teams' on the host.
This combined directive has two captured
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293001: [OpenMP] Codegen support for 'target teams' on the
host. (authored by arpith).
Changed prior to commit:
https://reviews.llvm.org/D29084?vs=85585&id=85673#toc
Repository:
rL LLVM
https://revi
timshen marked 13 inline comments as done.
timshen added inline comments.
Comment at: llvm/include/llvm/ADT/APFloat.h:1054
+ opStatus next(bool nextDown) {
+if (usesLayout(getSemantics()))
jlebar wrote:
> FWIW, see my screed on this:
> http://jlebar.com/2
Author: arpith
Date: Tue Jan 24 19:18:34 2017
New Revision: 292999
URL: http://llvm.org/viewvc/llvm-project?rev=292999&view=rev
Log:
[OpenMP] Support for the num_threads-clause on 'target parallel' on the NVPTX
device.
This patch adds support for the Spmd construct 'target parallel' on the
NVPTX
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292999: [OpenMP] Support for the num_threads-clause on
'target parallel' on the NVPTX… (authored by arpith).
Changed prior to commit:
https://reviews.llvm.org/D29083?vs=85583&id=85670#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292997: [OpenMP] Support for the num_threads-clause on
'target parallel'. (authored by arpith).
Changed prior to commit:
https://reviews.llvm.org/D29082?vs=85582&id=85662#toc
Repository:
rL LLVM
htt
Author: arpith
Date: Tue Jan 24 18:57:16 2017
New Revision: 292997
URL: http://llvm.org/viewvc/llvm-project?rev=292997&view=rev
Log:
[OpenMP] Support for the num_threads-clause on 'target parallel'.
The num_threads-clause on the combined directive applies to the
'parallel' region of this construc
ahatanak added inline comments.
Comment at: include/clang/Basic/DiagnosticGroups.td:290
def NullableToNonNullConversion : DiagGroup<"nullable-to-nonnull-conversion">;
+def NullConstToNonnull : DiagGroup<"null-const-to-nonnull">;
def NullabilityCompletenessOnArrays :
DiagGroup<
jordan_rose added inline comments.
Comment at: include/clang/Basic/DiagnosticGroups.td:290
def NullableToNonNullConversion : DiagGroup<"nullable-to-nonnull-conversion">;
+def NullConstToNonnull : DiagGroup<"null-const-to-nonnull">;
def NullabilityCompletenessOnArrays :
DiagGro
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Yes, that seems reasonable.
https://reviews.llvm.org/D29101
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks. Some minor changes and then LGTM.
I'm currently wondering if a better solution might be to just teach the
Bypasses analysis about the C lifetime rule. But we don't need to do tha
ahatanak updated this revision to Diff 85651.
ahatanak added a reviewer: jordan_rose.
ahatanak added a comment.
Rebase.
https://reviews.llvm.org/D22391
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Sema/Sema.cpp
Coding style change
From: James Sun
Date: Tuesday, January 24, 2017 at 2:36 PM
To: "cfe-commits@lists.llvm.org"
Subject: Add warning for c++ member variable shadowing
Dear members
Here is a patch (attached) to create warnings where a member variable shadows
the one in one of its inheriting cl
dblaikie updated this revision to Diff 85649.
dblaikie added a comment.
- Add cc1 flag for modular codegen, -fmodule-codegen
https://reviews.llvm.org/D28845
Files:
include/clang/AST/ASTContext.h
include/clang/AST/ExternalASTSource.h
include/clang/Basic/LangOptions.def
include/clang/Basi
Author: marshall
Date: Tue Jan 24 17:09:12 2017
New Revision: 292990
URL: http://llvm.org/viewvc/llvm-project?rev=292990&view=rev
Log:
Change the return type of emplace_[front|back] back to void when building with
C++14 or before. Resolves PR31680.
Modified:
libcxx/trunk/include/deque
li
Author: rsmith
Date: Tue Jan 24 17:18:28 2017
New Revision: 292991
URL: http://llvm.org/viewvc/llvm-project?rev=292991&view=rev
Log:
PR31742: Don't emit a bogus "zero size array" extwarn when initializing a
runtime-sized array from an empty list in an array new.
Modified:
cfe/trunk/lib/Sema/S
Author: marshall
Date: Tue Jan 24 17:28:25 2017
New Revision: 292992
URL: http://llvm.org/viewvc/llvm-project?rev=292992&view=rev
Log:
Implement LWG2556: Wide contract for future::share()
Modified:
libcxx/trunk/include/future
libcxx/trunk/test/std/thread/futures/futures.unique_future/shar
onhachoe created this revision.
Sometime clang would be supplied -fobjc-arc -f(no)objc-arc-exceptions
and then later disable ARC with -fno-objc-arc, which only negate first
option, but not the latter, resulting usused argument warning.
Silence this warning only when -fno-objc-arc option is present
ahatanak updated this revision to Diff 85643.
ahatanak marked an inline comment as done.
ahatanak added a comment.
To decide whether lifetime markers should be disabled, check whether the
current LexicalScope has labels instead of introducing a new structure that
keeps track of labels seen in th
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Landed as revision 292990.
https://reviews.llvm.org/D28933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
joerg added a comment.
Always defining __mips_abicalls is certainly the saner choice. I'm discussing
with the NetBSD/MIPS guys whether we just want to go with it all the time and
drop our custom changes for __ABICALLS__. Chances are quite good that we are
going in that direction.
https://revi
rsmith added a comment.
In https://reviews.llvm.org/D22587#551647, @mgehre wrote:
> I'm sorry if this sounds dumb, but is there a way for me to follow that
> particular discussion?
Only if you have access to the C++ committee's internal reflectors. Sadly this
is not on the issues list yet eit
Dear members
Here is a patch (attached) to create warnings where a member variable shadows
the one in one of its inheriting classes. For cases where we really don't want
to shadow member variables, e.g.
class a {
int foo;
}
class b : a {
int foo; // Generate a warning
}
This patch
(1) add
mgehre added a comment.
Ping
https://reviews.llvm.org/D22587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: marshall
Date: Tue Jan 24 16:22:33 2017
New Revision: 292986
URL: http://llvm.org/viewvc/llvm-project?rev=292986&view=rev
Log:
Remove auto_ptr in C++17. Get it back by defining
_LIBCPP_ENABLE_CXX17_REMOVED_AUTO_PTR
Added:
libcxx/trunk/test/libcxx/depr/depr.auto.ptr/
libcxx/trunk/
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D29067
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
sdardis added a comment.
@joerg , @emaste : My concern is that the stock gcc distributions for FreeBSD,
NetBSD from your sources doesn't define __mips_abicalls, so I'm worried about
potential incompatibilities.
Comment at: test/Preprocessor/init.c:4533
+// MIPS-ABICALLS-NETBS
sdardis added a comment.
@slthakur can you take a look at this too?
Thanks,
Simon
Repository:
rL LLVM
https://reviews.llvm.org/D29031
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
rjmccall added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.h:217
+ /// statements.
+ llvm::SmallVector LabelSeenStack;
+
ahatanak wrote:
> ahatanak wrote:
> > rjmccall wrote:
> > > Shouldn't this be maintained by some existing scoping structure lik
ahatanak added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.h:217
+ /// statements.
+ llvm::SmallVector LabelSeenStack;
+
ahatanak wrote:
> rjmccall wrote:
> > Shouldn't this be maintained by some existing scoping structure like
> > LexicalScope?
>
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8708
+def note_redefinition_modules_same_file : Note<
+ "'%0' included multiple times, additional (likely non-modular) include
site in module '%1'">;
+def note_redefinition_modules_same_fi
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM with some minor comments.
Comment at: lib/StaticAnalyzer/Checkers/MacOSXAPIChecker.cpp:98
+const VarDecl *VD = VR->getDecl();
+// FIXME: These should have
ahatanak added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.h:217
+ /// statements.
+ llvm::SmallVector LabelSeenStack;
+
rjmccall wrote:
> Shouldn't this be maintained by some existing scoping structure like
> LexicalScope?
I think I need a struct
On 23 January 2017 at 08:57, David Blaikie wrote:
> Should this test that some specific mangling comes out the other end
> (tests that amount to "test that this does anything other than crashing"
> always make me a bit suspicious that there's /some/ specific behavior that
> is intended/should be
Author: rsmith
Date: Tue Jan 24 15:03:48 2017
New Revision: 292978
URL: http://llvm.org/viewvc/llvm-project?rev=292978&view=rev
Log:
Strengthen test from r292632 to also check we get the mangling correct for this
case.
Modified:
cfe/trunk/test/CodeGenCXX/mangle.cpp
Modified: cfe/trunk/test/
dcoughlin added a comment.
In https://reviews.llvm.org/D28952#655278, @ddcc wrote:
> > - That said, I think there are still significant optimization
> > opportunities. It looks like when performing a query you create a new
> > solver for each set of constraints. My understanding (and perhaps @n
ddcc updated this revision to Diff 85621.
ddcc added a comment.
Add CMake CLANG_BUILD_Z3 option, add Z3Model and Z3Solver classes, reuse solver
in checkNull() and getSymVal()
https://reviews.llvm.org/D28952
Files:
CMakeLists.txt
cmake/modules/FindZ3.cmake
include/clang/Config/config.h.cm
ddcc added a comment.
> - That said, I think there are still significant optimization opportunities.
> It looks like when performing a query you create a new solver for each set of
> constraints. My understanding (and perhaps @nlopes can correct me here) is
> that these days Z3 is quite good at
pcc added inline comments.
Comment at: clang/include/clang/CodeGen/BackendUtil.h:51
+ llvm::Expected
+ FindThinLTOModule(llvm::MemoryBufferRef MBRef);
}
mehdi_amini wrote:
> Indentation seems strange?
Yes, it's what clang-format does though.
pcc updated this revision to Diff 85618.
pcc added a comment.
Address review comments
https://reviews.llvm.org/D29067
Files:
clang/lib/CodeGen/CodeGenAction.cpp
clang/test/CMakeLists.txt
clang/test/CodeGen/thinlto-multi-module.ll
Index: clang/test/CodeGen/thinlto-multi-module.ll
===
Author: compnerd
Date: Tue Jan 24 13:57:05 2017
New Revision: 292973
URL: http://llvm.org/viewvc/llvm-project?rev=292973&view=rev
Log:
cxa_demangle: fix rvalue ref check
When checking if the type is a r-value ref, we would not do a complete
check. This would result in us treating a trailing para
Author: pcc
Date: Tue Jan 24 13:55:38 2017
New Revision: 292972
URL: http://llvm.org/viewvc/llvm-project?rev=292972&view=rev
Log:
IRGen: Factor out function CodeGenAction::loadModule. NFCI.
Modified:
cfe/trunk/include/clang/CodeGen/CodeGenAction.h
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Author: pcc
Date: Tue Jan 24 13:54:37 2017
New Revision: 292970
URL: http://llvm.org/viewvc/llvm-project?rev=292970&view=rev
Log:
IRGen: Factor out function clang::FindThinLTOModule. NFCI.
Modified:
cfe/trunk/include/clang/CodeGen/BackendUtil.h
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modif
Author: marshall
Date: Tue Jan 24 13:44:55 2017
New Revision: 292969
URL: http://llvm.org/viewvc/llvm-project?rev=292969&view=rev
Log:
Add a test to make sure that implicit conversion from error_code to bool will
fail
Added:
libcxx/trunk/test/std/diagnostics/syserr/syserr.errcode/syserr.err
Author: marshall
Date: Tue Jan 24 13:37:09 2017
New Revision: 292967
URL: http://llvm.org/viewvc/llvm-project?rev=292967&view=rev
Log:
Update status for LWG2733
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/viewvc/llvm-project
eugenis added a comment.
A test would be nice.
Repository:
rL LLVM
https://reviews.llvm.org/D29077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mehdi_amini
Date: Tue Jan 24 12:49:49 2017
New Revision: 292964
URL: http://llvm.org/viewvc/llvm-project?rev=292964&view=rev
Log:
Fix test/Driver/embed-bitcode.c on non-Darwin host by setting the target
explicitly
Modified:
cfe/trunk/test/Driver/embed-bitcode.c
Modified: cfe/trunk/t
kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D29077
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: compnerd
Date: Tue Jan 24 12:42:56 2017
New Revision: 292963
URL: http://llvm.org/viewvc/llvm-project?rev=292963&view=rev
Log:
cxa_demangle: avoid butchering the last parameter type
Fix an off-by-one case which would destroy the final parameter in a
CV-qualified function type with a refer
alexfh added inline comments.
Comment at: clang-tidy/readability/OneNamePerDeclarationCheck.cpp:130
+if (isa(*(FirstVarIt + 1)))
+ return "typedef " + TypeString;
+
Should we suggest `using x = ...;` in C++11 code?
Comment at: clang-ti
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292961: Forward -bitcode_process_mode to ld64 in marker-only
mode (authored by mehdi_amini).
Changed prior to commit:
https://reviews.llvm.org/D29066?vs=85530&id=85606#toc
Repository:
rL LLVM
https:
Author: marshall
Date: Tue Jan 24 12:15:48 2017
New Revision: 292962
URL: http://llvm.org/viewvc/llvm-project?rev=292962&view=rev
Log:
Implement LWG2733: [fund.ts.v2] gcd / lcm and bool. We already did tbis for
C++17, so replicate the changes in experimental.
Added:
libcxx/trunk/test/std/e
Author: mehdi_amini
Date: Tue Jan 24 12:15:21 2017
New Revision: 292961
URL: http://llvm.org/viewvc/llvm-project?rev=292961&view=rev
Log:
Forward -bitcode_process_mode to ld64 in marker-only mode
Reviewers: steven_wu
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D2906
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292960: Split isUsingLTO() outside of embedBitcodeInObject()
and embedBitcodeMarkerOnly… (authored by mehdi_amini).
Changed prior to commit:
https://reviews.llvm.org/D29065?vs=85511&id=85605#toc
Reposi
Author: mehdi_amini
Date: Tue Jan 24 12:12:25 2017
New Revision: 292960
URL: http://llvm.org/viewvc/llvm-project?rev=292960&view=rev
Log:
Split isUsingLTO() outside of embedBitcodeInObject() and
embedBitcodeMarkerOnly().
Summary: These accessors maps directly to the command line option.
Reviewe
jlebar added a comment.
Eric asked me to do a review of this. I notice now it was submitted while I
was doing the review. Oh well. Here are the comments I had.
Comment at: llvm/include/llvm/ADT/APFloat.h:1054
+ opStatus next(bool nextDown) {
+if (usesLayout(getSemant
alexfh added a comment.
https://reviews.llvm.org/D27621 seems to have a more up-to-date version of this
patch.
https://reviews.llvm.org/D25024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
Author: marshall
Date: Tue Jan 24 12:03:32 2017
New Revision: 292958
URL: http://llvm.org/viewvc/llvm-project?rev=292958&view=rev
Log:
Mark LWG2736 as complete. No code changes, but we have more tests now
Added:
libcxx/trunk/test/std/utilities/optional/optional.nullopt/nullopt_t.fail.cpp
Modi
alexfh accepted this revision.
alexfh added a comment.
LGTM, if Aaron has no concerns.
Thank you for the new check!
https://reviews.llvm.org/D20693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
alexfh added a comment.
My apologies again for the delay. There are a few things I'm concerned about:
1. Suppression list being a command-line option is going to be inconvenient to
completely useless in many setups. The `-line-filter` option is special in this
regard, since it was added for a r
dblaikie updated this revision to Diff 85599.
dblaikie added a comment.
- Move linkage handling into GetGVALinkageForFunction
https://reviews.llvm.org/D28845
Files:
include/clang/AST/ASTContext.h
include/clang/AST/ExternalASTSource.h
include/clang/Basic/LangOptions.def
include/clang/Bas
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D29087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D29085
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D29084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D29083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
steven_wu accepted this revision.
steven_wu added a comment.
This revision is now accepted and ready to land.
Depending on how you look at the previous commit, you can think that as a new
API or just rename the old API. I actually dont think there is too much issue
names. Plz go ahead.
https:/
djasper added a comment.
No problem :)
Repository:
rL LLVM
https://reviews.llvm.org/D29039
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
stryku added a comment.
@djasper You're probably right. Thanks anyway for your time (:
Repository:
rL LLVM
https://reviews.llvm.org/D29039
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG with a nit
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4996
+ CodeGenFunction::RunCleanupsScope NumThreadsScope(CGF);
+ auto NumThreads = CGF.EmitScalarExpr(Nu
Thanks for letting me know!
I've merged your revert to the branch in r292947. Please let me know
if there is any more follow-up.
On Mon, Jan 23, 2017 at 6:30 PM, Devin Coughlin wrote:
> FYI, I reverted r292800 from trunk in r292874. It was causing our internal
> validation bots to have false pos
hintonda updated this revision to Diff 85593.
hintonda marked 4 inline comments as done.
hintonda added a comment.
- Addressed comments and added additional test cases.
https://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
arpith-jacob created this revision.
The thread_limit-clause on the combined directive applies to the
'teams' region of this construct. We modify the ThreadLimitClause
class to capture the clause expression within the 'target' region.
https://reviews.llvm.org/D29087
Files:
include/clang/AST/O
klimek added inline comments.
Comment at: lib/Format/BreakableToken.h:42-48
+/// There is a pair of operations that are used to compress a long whitespace
+/// range with a single space if that will bring the line lenght under the
+/// column limit:
+/// - getLineLengthAfterCompr
Author: marshall
Date: Tue Jan 24 10:28:02 2017
New Revision: 292943
URL: http://llvm.org/viewvc/llvm-project?rev=292943&view=rev
Log:
A couple more tests for constexpr stuff in string_view. No changes other than
test code.
Modified:
libcxx/trunk/test/std/strings/string.view/string.view.ite
krasimir marked an inline comment as done.
krasimir added inline comments.
Comment at: lib/Format/BreakableToken.h:42-48
+/// There is a pair of operations that are used to compress a long whitespace
+/// range with a single space if that will bring the line lenght under the
+///
klimek added a comment.
This is starting to be pretty awesome. The one thing that would help me review
the gist of the implementation a bit more is if that had a bit more comments.
Perhaps go over the math in the code and put some comments in why we're doing
what at various steps.
==
NoQ updated this revision to Diff 85588.
NoQ added a comment.
Reopening due to a revert.
This time i reduce the scope of the fix to the checker, and add FIXMEs to the
problems that showed up while testing it.
https://reviews.llvm.org/D28946
Files:
lib/StaticAnalyzer/Checkers/MacOSXAPIChecke
arpith-jacob created this revision.
The num_teams-clause on the combined directive applies to the
'teams' region of this construct. We modify the NumTeamsClause
class to capture the clause expression within the 'target' region.
https://reviews.llvm.org/D29085
Files:
include/clang/AST/OpenMPC
1 - 100 of 144 matches
Mail list logo
