vsk created this revision.
Given a load of a member variable from an instance method ('this->x'),
ubsan inserts a null check for 'this', and another null check for
'&this->x', before allowing the load to occur. Both of these checks are
redundant, because 'this' must have been null-checked before t
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Fri Feb 3 19:28:01 2017
New Revision: 294078
URL: http://llvm.org/viewvc/llvm-project?rev=294078&view=rev
Log:
PR31846: Don't replace 'auto' type with a template parameter type in a generic
lambda
until after we've checked whether 'auto' is valid in the current language mode
dylanmckay updated this revision to Diff 87054.
dylanmckay marked 5 inline comments as done.
dylanmckay added a comment.
Code review comments
- Add 'Subjects = [ObjCMethod]' to attributes
- Use 'auto' keyword in one place
- Move complex attr parsing logic into static function
https://reviews.ll
dylanmckay marked an inline comment as done.
dylanmckay added a comment.
Ping
https://reviews.llvm.org/D28344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dylanmckay marked an inline comment as done.
dylanmckay added a comment.
Ping
https://reviews.llvm.org/D28344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dylanmckay added a comment.
Ping
https://reviews.llvm.org/D28346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: matze
Date: Fri Feb 3 17:09:31 2017
New Revision: 294065
URL: http://llvm.org/viewvc/llvm-project?rev=294065&view=rev
Log:
Driver: Do not warn about unused -pthread when linking on darwin
While there is nothing to do at link time to get pthreads support on
darwin, specifying the argument
tigerleapgorge created this revision.
I am continuing to make Lit tests C++11 compatible.
This patch contains 4 tests, previously in review
https://reviews.llvm.org/D20710 and https://reviews.llvm.org/D21626.
test/SemaCXX/MicrosoftExtensions.cpp
This test checks for Microsoft extensions.
Po
Note that this also failed on Linux:
http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules/builds/2728
This looks like a modules compiler bug, as opposed to a problem in the commit
itself. Alex, can you file a PR for this?
> On 2017-Feb-01, at 07:35, Alex L via cfe-commits
> w
LGTM.
> On 2017-Feb-03, at 14:16, Matthias Braun via Phabricator
> wrote:
>
> MatzeB updated this revision to Diff 87024.
> MatzeB added a comment.
>
> Address review comments:
>
> - Simplify test
> - Only perform the ClaimAll() if we actually link libc, so we get the warning
> back when com
ahatanak updated this revision to Diff 87016.
ahatanak marked 2 inline comments as done.
ahatanak added a comment.
Turning the warning on by default caused clang to issue warnings in many other
cases, including Objective-C methods returning nil, which was something r240153
tried to avoid. If we
Thanks! r294059.
On Fri, Feb 3, 2017 at 2:29 PM, Richard Smith wrote:
> It looks like the only cases it should have any real impact on are those
> where we would previously miscompile/crash, so this seems OK to me to merge
> to Clang 4.
>
>
> On 3 February 2017 at 13:45, Hans Wennborg wrote:
>>
vsk updated this revision to Diff 87030.
vsk edited the summary of this revision.
vsk added a comment.
- Use switches per Filipe's comment, and fix a comment in the test case.
https://reviews.llvm.org/D29369
Files:
lib/CodeGen/CGExprScalar.cpp
test/CodeGen/compound-assign-overflow.c
test/
It looks like the only cases it should have any real impact on are those
where we would previously miscompile/crash, so this seems OK to me to merge
to Clang 4.
On 3 February 2017 at 13:45, Hans Wennborg wrote:
> IIUC, this isn't strictly fixing a regression from 3.9, but it looks
> like a prett
dim added a comment.
In https://reviews.llvm.org/D28213#666269, @dim wrote:
> In https://reviews.llvm.org/D28213#666196, @mgorny wrote:
>
> >
>
...
>> What's the value of `__atomic_always_lock_free(sizeof(long long), 0)` for
>> gcc and clang?
>
> For gcc, it is always 0, for clang (I tested
MatzeB updated this revision to Diff 87024.
MatzeB added a comment.
Address review comments:
- Simplify test
- Only perform the ClaimAll() if we actually link libc, so we get the warning
back when combining -nostdlib/-nodefaultlibs with -pthread
Repository:
rL LLVM
https://reviews.llvm.org/
Author: spatel
Date: Fri Feb 3 16:03:47 2017
New Revision: 294058
URL: http://llvm.org/viewvc/llvm-project?rev=294058&view=rev
Log:
[x86] fix tests with wrong dependency to pass because they broke with r294049
Modified:
cfe/trunk/test/CodeGen/avx512-reduceMinMaxIntrin.c
Modified: cfe/trunk/
MatzeB updated this revision to Diff 87023.
Repository:
rL LLVM
https://reviews.llvm.org/D29479
Files:
lib/Driver/Tools.cpp
test/Driver/darwin-ld-pthread.c
Index: test/Driver/darwin-ld-pthread.c
===
--- /dev/null
+++ test/Dr
aaboud updated this revision to Diff 87020.
aaboud marked 4 inline comments as done.
aaboud added a comment.
Addressed Adrian's comments.
Please, let me know if I missed any.
Also, I improved the code and added explanation about the file inclusion
structure that is being handled in the macro cal
vsk marked an inline comment as done.
vsk added a comment.
In https://reviews.llvm.org/D29369#666308, @vsk wrote:
> In https://reviews.llvm.org/D29369#665878, @filcab wrote:
>
> > Why the switch to `if` instead of a fully-covered switch/case?
>
>
> It lets me avoid repeating two function calls:
vsk marked an inline comment as done.
vsk added a comment.
In https://reviews.llvm.org/D29369#665878, @filcab wrote:
> Why the switch to `if` instead of a fully-covered switch/case?
It lets me avoid repeating two function calls:
switch (CGF.getLangOpts().getSignedOverflowBehavior()) {
case
r294050.
Thanks,
Hans
On Fri, Feb 3, 2017 at 1:50 PM, Anna Zaks wrote:
> Fine with merging. Thank you!
> Anna.
>> On Feb 1, 2017, at 11:00 AM, Hans Wennborg wrote:
>>
>> If Anna is Ok with it, I'm fine with merging.
>>
>> Thanks,
>> Hans
>>
>> On Wed, Feb 1, 2017 at 10:29 AM, Artem Dergachev w
Fine with merging. Thank you!
Anna.
> On Feb 1, 2017, at 11:00 AM, Hans Wennborg wrote:
>
> If Anna is Ok with it, I'm fine with merging.
>
> Thanks,
> Hans
>
> On Wed, Feb 1, 2017 at 10:29 AM, Artem Dergachev wrote:
>> Hans,
>>
>> This is a fixed and tested version of the previously-merged-a
jbcoe added a comment.
High Integrity C++ is often used as a standard for safety-critical systems.
High Integrity C++ requires no assembler due to portability issues. Not my
choice of wording.
I plan to implement more of the High Integrity C++ checks, some of which are
more obviously safety-re
dim added a comment.
In https://reviews.llvm.org/D28213#666196, @mgorny wrote:
> In https://reviews.llvm.org/D28213#665967, @dim wrote:
>
> > I don't think FreeBSD has lock-free 64 bit atomic operations on 32-bit x86.
> > IIRC we already had some trouble before with clang emitting libcalls to
IIUC, this isn't strictly fixing a regression from 3.9, but it looks
like a pretty small diff.
Richard, what do you think?
On Fri, Feb 3, 2017 at 6:37 AM, Alex L wrote:
> Hi Hans,
>
> Is there any chance we can merge this for 4.0? It fixed a nasty bug where
> clang didn't catch invalid ObjC++ co
Ping?
On Wed, Feb 1, 2017 at 11:00 AM, Hans Wennborg wrote:
> If Anna is Ok with it, I'm fine with merging.
>
> Thanks,
> Hans
>
> On Wed, Feb 1, 2017 at 10:29 AM, Artem Dergachev wrote:
>> Hans,
>>
>> This is a fixed and tested version of the previously-merged-and-reverted
>> r292800, do we sti
mgorny added a comment.
In https://reviews.llvm.org/D28213#665967, @dim wrote:
> I don't think FreeBSD has lock-free 64 bit atomic operations on 32-bit x86.
> IIRC we already had some trouble before with clang emitting libcalls to
> `__atomic_fetch_add_8` and friends, which then lead to linkin
malcolm.parsons added inline comments.
Comment at: clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp:63
+cxxOperatorCallExpr(argumentCountIs(1),
+callee(unresolvedLookupExpr()),
+hasArgument(0, cxxThi
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: test/SemaOpenCL/logical-ops.cl:1-3
+// RUN: %clang_cc1 %s -verify -cl-std=CL1.1 -triple x86_64-unknown-linux-gnu
+// RUN: %clang_cc1 %s -verify -cl-std=CL1.2
arpith-jacob added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:524
+
+ static bool classof(const CGOpenMPRuntime *RT) {
+return RT->getKind() == RK_HOST;
This is required to cast to the NVPTX runtime in a static function as follows;
CGOpenMPR
tigerleapgorge updated this revision to Diff 86994.
tigerleapgorge added a comment.
Update again, remove 4 OpenMP tests here because they have been checked in
https://reviews.llvm.org/rL294025 under review https://reviews.llvm.org/D29480.
13 tests left.
https://reviews.llvm.org/D20710
Files:
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed to r294026
https://reviews.llvm.org/D28243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: cbertol
Date: Fri Feb 3 13:09:16 2017
New Revision: 294026
URL: http://llvm.org/viewvc/llvm-project?rev=294026&view=rev
Log:
[OpenMP] Add missing regression test for pragma distribute, clause firstprivate
https://reviews.llvm.org/D28243
The regression test was missing from the previous
idlecode added a comment.
Standard you linked mentions portability as the reason inline assembler should
be avoided. Should it really be named 'safety'?
https://reviews.llvm.org/D29267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
Author: lcharles
Date: Fri Feb 3 12:58:34 2017
New Revision: 294025
URL: http://llvm.org/viewvc/llvm-project?rev=294025&view=rev
Log:
[Lit Test] Make tests C++11 compatible - OpenMP constant expressions
C++11 introduced constexpr, hence the change in diagnostics.
Differential Revision: https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294025: [Lit Test] Make tests C++11 compatible - OpenMP
constant expressions (authored by lcharles).
Changed prior to commit:
https://reviews.llvm.org/D29480?vs=86925&id=86988#toc
Repository:
rL LLVM
dim added a comment.
In https://reviews.llvm.org/D28213#639397, @hfinkel wrote:
> LGTM. This seems consistent with what GCC does. On x86 it also sets
> __GCC_ATOMIC_LLONG_LOCK_FREE to 2.
Hmm, unfortunately on i386-freebsd, it does not:
$ gcc6 -v
Using built-in specs.
COLLECT_GCC=gcc6
idlecode added inline comments.
Comment at: clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp:63
+cxxOperatorCallExpr(argumentCountIs(1),
+callee(unresolvedLookupExpr()),
+hasArgument(0, cxxThisExpr()
alexfh added a comment.
In https://reviews.llvm.org/D29151#662504, @zaks.anna wrote:
> Before clang-tidy came into existence the guidelines were very clear. One
> should write a clang warning if the diagnostic:
>
> - can be implemented without path-insensitive analysis (including
> flow-sensiti
filcab added a comment.
Why the switch to `if` instead of a fully-covered switch/case?
In https://reviews.llvm.org/D29369#664426, @vsk wrote:
> In https://reviews.llvm.org/D29369#664366, @regehr wrote:
>
> > Out of curiosity, how many of these superfluous checks are not subsequently
> > elimina
mati865 added a comment.
I know why mingw-w64 limits.h weren't used (check first comment).
At first I was using this hack:
diff -urN clang.orig/3.9.0/include/limits.h clang/3.9.0/include/limits.h
--- clang.orig/3.9.0/include/limits.h 2016-09-26 22:29:13.496441000 +0200
+++ clang/3.9.0/inclu
Anastasia added a comment.
@arsenm, do you think you could complete the review?
https://reviews.llvm.org/D29038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaron.keren added a comment.
Hiding these two include dirs removes many headers. Most has clang equivalents
but not all of them.
For example quadmath.h is only there, and without the include path programs
using it will fail to compile.
The reason mingw limits.h isn't used in your example is tha
Author: djasper
Date: Fri Feb 3 08:32:38 2017
New Revision: 294009
URL: http://llvm.org/viewvc/llvm-project?rev=294009&view=rev
Log:
clang-format: [JS] Fix bugs in parsing and aligning template strings.
Modified:
cfe/trunk/lib/Format/ContinuationIndenter.cpp
cfe/trunk/lib/Format/TokenAnn
Author: arphaman
Date: Fri Feb 3 08:22:33 2017
New Revision: 294008
URL: http://llvm.org/viewvc/llvm-project?rev=294008&view=rev
Log:
[Sema][ObjC++] Typo correction should handle ivars and properties
After r260016 and r260017 disabled typo correction for ivars and properties
clang didn't report
Hi Hans,
Is there any chance we can merge this for 4.0? It fixed a nasty bug where
clang didn't catch invalid ObjC++ code during semantic analysis which led
to invalid object files or crashes in CodeGen.
Cheers,
Alex
On 3 February 2017 at 14:22, Alex Lorenz via cfe-commits <
cfe-commits@lists.ll
mati865 added a comment.
Adding
// c:\mingw32\lib\gcc\i686-w64-mingw32\4.9.1\include
// c:\mingw32\lib\gcc\i686-w64-mingw32\4.9.1\include-fixed
for Clang is wrong on Windows because including limits.h will not show an error
and won't really include mingw-w64 limits.h
Output of code from my
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
A couple of nits. Please address Aaron's comment as well.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:53
+ for (const auto &NoExceptRange : NoExceptRang
Adi added inline comments.
Comment at: clangd/JSONRPCDispatcher.h:25-32
+ virtual ~Handler() = default;
+
+ /// Called when the server receives a method call. This is supposed to return
+ /// a result on Outs.
+ virtual void handleMethod(llvm::yaml::MappingNode *Params, Strin
yaron.keren added a comment.
This code is actually used with Windows as well as Linux (with the exception of
line 218), see the comment blocks above for detailed include dirs from all
platforms from which it was derived.
Please make sure include dirs between gcc and clang match after the patch
klimek added inline comments.
Comment at: clangd/JSONRPCDispatcher.h:25-32
+ virtual ~Handler() = default;
+
+ /// Called when the server receives a method call. This is supposed to return
+ /// a result on Outs.
+ virtual void handleMethod(llvm::yaml::MappingNode *Params, St
klimek accepted this revision.
klimek added a comment.
LG. Couple of questions.
Comment at: clangd/ClangDMain.cpp:65
+// Now read the JSON.
+std::vector JSON;
+JSON.resize(Len);
Adi wrote:
> Avoid unnecessary JSON.resize(Len) & potential reallocatio
Adi added a comment.
I had some spare time ... I hope you don't mind the comments. Hopefully you
will find something useful :)
Comment at: clangd/ClangDMain.cpp:65-70
+std::vector JSON;
+JSON.resize(Len);
+std::cin.read(JSON.data(), Len);
+
+// Insert a trailin
djasper accepted this revision.
djasper added a comment.
Just a few nits. I think this looks like a great starting point!
Comment at: clangd/ClangDMain.cpp:33
+ llvm::make_unique(Outs, Logs, Store));
+ // FIXME: textDocument/didClose
+ Dispatcher.registerHandler(
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293997: [clang-format] Re-align broken comment lines where
appropriate. (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29486?vs=86942&id=86945#toc
Repository:
rL LLVM
htt
Author: krasimir
Date: Fri Feb 3 04:18:25 2017
New Revision: 293997
URL: http://llvm.org/viewvc/llvm-project?rev=293997&view=rev
Log:
[clang-format] Re-align broken comment lines where appropriate.
Summary:
The comment aligner was skipping over newly broken comment lines. This patch
fixes that.
krasimir added a comment.
It's very unlikely that you caused this. After re-flowing lots of cases started
going over alternative code paths, and this looks like an instance of that.
https://reviews.llvm.org/D29486
___
cfe-commits mailing list
cfe-c
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Thanks and sorry if I caused this :(
https://reviews.llvm.org/D29486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
Author: djasper
Date: Fri Feb 3 02:29:02 2017
New Revision: 293995
URL: http://llvm.org/viewvc/llvm-project?rev=293995&view=rev
Log:
clang-format: [Proto] Also supports implicit string literal concatenation
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/trunk/unittests/Format/Form
61 matches
Mail list logo
