dylanmckay updated this revision to Diff 87190.
dylanmckay marked an inline comment as done.
dylanmckay added a comment.
Add tests
- Add multichar constraint tests
- Add 'unsupported constraint' tests
https://reviews.llvm.org/D28344
Files:
lib/Basic/Targets.cpp
test/CodeGen/avr-inline-asm-
bmharper added a comment.
Thanks @daphnediane. I only read your comment after merging, but that would
have been helpful.
https://reviews.llvm.org/D21279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
compnerd closed this revision.
compnerd added a comment.
SVN r294171
https://reviews.llvm.org/D28407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: compnerd
Date: Sun Feb 5 23:26:49 2017
New Revision: 294171
URL: http://llvm.org/viewvc/llvm-project?rev=294171&view=rev
Log:
Refer to _LIBCPP_MSVC macro where applicable
Replace preprocess conditions of defined(_MSC_VER) &&
!defined(__clang__) with defined(_LIBCPP_MSVC). NFC.
Patch by
bmharper updated this revision to Diff 87179.
bmharper added a comment.
Fixed a stale comment
https://reviews.llvm.org/D21279
Files:
lib/Format/WhitespaceManager.cpp
lib/Format/WhitespaceManager.h
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
bmharper updated this revision to Diff 87178.
bmharper added a comment.
Hi @djasper,
I've made the latest bunch of review changes, and rebased onto master. I didn't
check the numbers, but I think the code is slightly smaller after the rebase.
Regards,
Ben
https://reviews.llvm.org/D21279
Files
Author: ericwf
Date: Sun Feb 5 20:41:49 2017
New Revision: 294167
URL: http://llvm.org/viewvc/llvm-project?rev=294167&view=rev
Log:
Mark LWG 2765 as complete. No changes needed
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/vi
Author: ericwf
Date: Sun Feb 5 19:25:31 2017
New Revision: 294165
URL: http://llvm.org/viewvc/llvm-project?rev=294165&view=rev
Log:
Implement LWG 2773 - std::ignore should be constexpr.
In addition to the PR for LWG 2773 this patch also ensures
that each of std::ignores constructors or assignmen
jlebar added inline comments.
Comment at: lib/Basic/Targets.cpp:1808
+if (HostTriple.getArch() == llvm::Triple::x86)
+ HostTarget->setCPU("i586");
+
Okay, is this still needed now?
https://reviews.llvm.org/D29542
dylanmckay marked 4 inline comments as done.
dylanmckay added inline comments.
Comment at: test/CodeGen/avr/attributes/interrupt.m:4
+// CHECK: define void @_Z3foov() #0
+void foo() __attribute__((interrupt)) { }
+
aaron.ballman wrote:
> This is not an Objective-
dylanmckay added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5137
+ if (!checkAttributeNumArgs(S, Attr, 0))
+Attr.setInvalid();
+
aaron.ballman wrote:
> This should simply return rather than attempt to attach an invalid attribute
> to the declara
dylanmckay updated this revision to Diff 87174.
dylanmckay marked 2 inline comments as done.
dylanmckay added a comment.
Code review
- Remove support for ObjC methods. We shouldn't do this as it doesn't really
make sense
- Move some tests to `Sema`
- Don't attach invalid attributes when it isn't
dylanmckay marked 2 inline comments as done.
dylanmckay added inline comments.
Comment at: test/CodeGen/avr/target-cpu-defines/atmega328p.c:1
+// RUN: %clang_cc1 -triple avr-unknown-unknown -target-cpu atmega328p
-emit-llvm %s -o - | FileCheck %s
+
asl wrote:
>
dylanmckay updated this revision to Diff 87172.
dylanmckay added a comment.
Clean up the tests
- Dump all defines and search for specific ones
- Remove some unrelated tests. I will commit them separately, as they don't
actually test any behaviour modified in this change.
https://reviews.llvm.o
mgorny updated this revision to Diff 87170.
mgorny added a comment.
CUDA: added the `MaxAtomicPromoteWidth` setting, and moved the CPU setting a
little lower to ensure that it doesn't get called with null `HostTarget`.
https://reviews.llvm.org/D29542
Files:
lib/Basic/Targets.cpp
test/CodeG
STL_MSFT accepted this revision.
STL_MSFT added a comment.
This revision is now accepted and ready to land.
Committed with the requested changes. Thanks!
https://reviews.llvm.org/D29135
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
Author: stl_msft
Date: Sun Feb 5 16:48:27 2017
New Revision: 294161
URL: http://llvm.org/viewvc/llvm-project?rev=294161&view=rev
Log:
[libcxx] [test] Strip trailing whitespace.
No functional change, no code review.
Modified:
libcxx/trunk/test/std/strings/basic.string/string.cons/copy_alloc.
Author: stl_msft
Date: Sun Feb 5 16:48:13 2017
New Revision: 294159
URL: http://llvm.org/viewvc/llvm-project?rev=294159&view=rev
Log:
[libcxx] [test] Avoid MSVC's non-Standard ABI in underlying_type.pass.cpp.
When compiled with Clang for Windows, this was emitting "enumerator value
evaluates to
Author: stl_msft
Date: Sun Feb 5 16:48:20 2017
New Revision: 294160
URL: http://llvm.org/viewvc/llvm-project?rev=294160&view=rev
Log:
[libcxx] [test] Fix comment typos.
No functional change, no code review.
Modified:
libcxx/trunk/test/libcxx/utilities/function.objects/func.require/invoke_h
Author: stl_msft
Date: Sun Feb 5 16:48:07 2017
New Revision: 294158
URL: http://llvm.org/viewvc/llvm-project?rev=294158&view=rev
Log:
[libcxx] [test] Fix Clang -Wpessimizing-move "moving a temporary object
prevents copy elision".
N4618 30.6.6 [futures.unique_future]/12 declares "shared_future s
Author: stl_msft
Date: Sun Feb 5 16:48:02 2017
New Revision: 294157
URL: http://llvm.org/viewvc/llvm-project?rev=294157&view=rev
Log:
[libcxx] [test] Fix Clang -Wdeprecated-declarations with MSVC's CRT.
libcxx's tests use various C Standard Library functions that have been
marked by MSVC's CRT a
Author: stl_msft
Date: Sun Feb 5 16:47:54 2017
New Revision: 294156
URL: http://llvm.org/viewvc/llvm-project?rev=294156&view=rev
Log:
[libcxx] [test] Fix Clang -Wunused-local-typedef, part 3/3.
test/std/strings/string.classes/typedefs.pass.cpp
Actually test what basic_string's typedefs stand for
Author: stl_msft
Date: Sun Feb 5 16:47:09 2017
New Revision: 294154
URL: http://llvm.org/viewvc/llvm-project?rev=294154&view=rev
Log:
[libcxx] [test] Fix Clang -Wunused-local-typedef, part 1/3.
Guard typedefs and static_asserts with _LIBCPP_VERSION.
test/std/containers/sequences/vector.bool/mov
Author: stl_msft
Date: Sun Feb 5 16:47:41 2017
New Revision: 294155
URL: http://llvm.org/viewvc/llvm-project?rev=294155&view=rev
Log:
[libcxx] [test] Fix Clang -Wunused-local-typedef, part 2/3.
These typedefs were completely unused.
Fixes D29136.
Modified:
libcxx/trunk/test/std/containers/
aaron.ballman added a comment.
The new tests aren't really what I had in mind. The codegen tests that should
be sema tests can just be rolled into your existing sema tests, by the way.
Comment at: lib/Sema/SemaDeclAttr.cpp:5137
+ if (!checkAttributeNumArgs(S, Attr, 0))
+A
Author: compnerd
Date: Sun Feb 5 16:18:15 2017
New Revision: 294148
URL: http://llvm.org/viewvc/llvm-project?rev=294148&view=rev
Log:
Basic: match GCC behaviour for SuS macro
GCC does not generate `__unix` nor `unix` macros. The latter already
intrudes into the user's namespace and should be av
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
This LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D29209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
jlebar added inline comments.
Comment at: lib/Basic/Targets.cpp:1784
+ // atomics. This matches the defaults for the systems using CUDA.
+ // TODO: pass the host target CPU
+ if (HostTriple.getArch() == llvm::Triple::x86)
Someone else is calling se
dylanmckay updated this revision to Diff 87164.
dylanmckay marked 2 inline comments as done.
dylanmckay added a comment.
Verify that no arguments are given to the attributes
Also adds a bunch of tests.
https://reviews.llvm.org/D28451
Files:
include/clang/Basic/Attr.td
include/clang/Basic/A
Author: marshall
Date: Sun Feb 5 14:52:32 2017
New Revision: 294142
URL: http://llvm.org/viewvc/llvm-project?rev=294142&view=rev
Log:
Restore the _NOEXCEPT on the dtor of bad_optional_access. Destructors are
noexcept by default, so it's not really needed, but the other exception classes
have th
Author: ericwf
Date: Sun Feb 5 14:36:07 2017
New Revision: 294141
URL: http://llvm.org/viewvc/llvm-project?rev=294141&view=rev
Log:
Fix variant build errors with GCC 7
Modified:
libcxx/trunk/include/variant
Modified: libcxx/trunk/include/variant
URL:
http://llvm.org/viewvc/llvm-project/lib
Author: ericwf
Date: Sun Feb 5 14:17:41 2017
New Revision: 294139
URL: http://llvm.org/viewvc/llvm-project?rev=294139&view=rev
Log:
Adjust Apple ABI list after r294133
Modified:
libcxx/trunk/lib/abi/x86_64-apple-darwin16.abilist
Modified: libcxx/trunk/lib/abi/x86_64-apple-darwin16.abilist
U
Author: marshall
Date: Sun Feb 5 14:06:38 2017
New Revision: 294133
URL: http://llvm.org/viewvc/llvm-project?rev=294133&view=rev
Log:
Change the base class of std::bad_optional_access. This is a (subtle) ABI
change, and is in response to http://http://wg21.link/LWG2806, which I *expect*
to be
Minor nit: your diff is much bigger than it should have been due to
whitespace changes.
On Sun, Feb 5, 2017 at 9:21 AM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Sun Feb 5 11:21:52 2017
> New Revision: 294127
>
> URL: http://llvm.org/view
Author: compnerd
Date: Sun Feb 5 11:21:52 2017
New Revision: 294127
URL: http://llvm.org/viewvc/llvm-project?rev=294127&view=rev
Log:
filesystem: fix n4100 conformance for `temp_directory_path`
N4100 states that an error shall be reported if
`!exists(p) || !is_directory(p)`. We were missing the
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/ReturnBracedInitListCheck.cpp:59
+ // Skip explicit construcotrs.
+ if (MatchedConstructExpr->getConstructor()->isExplicit())
+return;
Can't this be handled as part of the matcher? Someth
aaron.ballman added inline comments.
Comment at: clang-tools-extra/clang-tidy/safety/NoAssemblerCheck.cpp:32
+
+ diag(ASM->getAsmLoc(), "'%0' is an inline assembler statement") <<
SourceText;
+}
The diagnostic text doesn't help the user to understand why the co
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a minor nit that can be fixed without further review.
Comment at: test/clang-tidy/misc-unconventional-assign-operator.cpp:92
+enum E { e };
+E operato
aaron.ballman added a comment.
Just one more issue due to the nature of needing a custom parsed attribute.
Comment at: lib/Sema/SemaDeclAttr.cpp:5130
+static void handleAVRInterruptAttr(Sema &S, Decl *D, const AttributeList
&Attr) {
+ if (!isFunctionOrMethod(D)) {
+S.Diag
Author: coby
Date: Sun Feb 5 04:23:06 2017
New Revision: 294120
URL: http://llvm.org/viewvc/llvm-project?rev=294120&view=rev
Log:
[X86][MS]Adjacent comments within multi-line inline assembly statement
Allowing adjacent comments within MS inline assembly multi-line statement
Differential Revisio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294120: [X86][MS]Adjacent comments within multi-line inline
assembly statement (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D28989?vs=85276&id=87135#toc
Repository:
rL LLVM
mgorny updated this revision to Diff 87134.
mgorny edited the summary of this revision.
mgorny added a comment.
Ok, this CUDA fix should be reasonable, i think. It simply assumes i586+ (i.e.
all inline atomics enabled) for CUDA target builds. I seriously doubt it's
technically possible that anyo
42 matches
Mail list logo
