[PATCH] D29750: [PPC] Enable -fomit-frame-pointer by default for PPC

2017-02-08 Thread Hiroshi Inoue via Phabricator via cfe-commits
inouehrs created this revision. This patch enables `-fomit-frame-pointer` option by default for PowerPC if -O1 or above optimization level is specified. GCC already enables this option by default for -O1 or above in all of ppc32, ppc64 and ppc64le. This option gives some performance improvements

r294560 - [X86] Fix copy and paste bug in clzero test from r294559.

2017-02-08 Thread Craig Topper via cfe-commits
Author: ctopper Date: Thu Feb 9 00:22:43 2017 New Revision: 294560 URL: http://llvm.org/viewvc/llvm-project?rev=294560&view=rev Log: [X86] Fix copy and paste bug in clzero test from r294559. Modified: cfe/trunk/test/CodeGen/builtin-clzero.c Modified: cfe/trunk/test/CodeGen/builtin-clzero.c

[PATCH] D29386: Clzero flag addition and inclusion under znver1

2017-02-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL294559: [X86] Clzero flag addition and inclusion under znver1 (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D29386?vs=87437&id=87762#toc Repository: rL LLVM https://review

r294559 - [X86] Clzero flag addition and inclusion under znver1

2017-02-08 Thread Craig Topper via cfe-commits
Author: ctopper Date: Thu Feb 9 00:10:14 2017 New Revision: 294559 URL: http://llvm.org/viewvc/llvm-project?rev=294559&view=rev Log: [X86] Clzero flag addition and inclusion under znver1 1. Adds the command line flag for clzero. 2. Includes the clzero flag under znver1. 3. Defines the macro for

[PATCH] D29386: Clzero flag addition and inclusion under znver1

2017-02-08 Thread Ganesh Gopalasubramanian via Phabricator via cfe-commits
GGanesh added a comment. Thank you @craig.topper. Just want to check if the patch can be commited to 4.0 release branch as well. I understand that the trunk is in blocker bug-fix stage but just want to get it confirmed. Repository: rL LLVM https://reviews.llvm.org/D29386

[PATCH] D29748: [cxx1z-constexpr-lambda] Implement captures - thus completing implementation of constexpr lambdas.

2017-02-08 Thread Faisal Vali via Phabricator via cfe-commits
faisalv added inline comments. Comment at: lib/AST/ExprConstant.cpp:5061 + APValue RVal; + // FIXME: We need to make sure we're passing the right type that + // maintains cv-qualifiers. I don't think we need this fixme - the type of the

[PATCH] D29748: [cxx1z-constexpr-lambda] Implement captures - thus completing implementation of constexpr lambdas.

2017-02-08 Thread Faisal Vali via Phabricator via cfe-commits
faisalv created this revision. faisalv added a project: clang-c. Herald added a subscriber: EricWF. This patch attempts to enable evaluation of all forms of captures (however deeply nested) within constexpr lambdas. Appreciate the feedback. Thanks! Repository: rL LLVM https://reviews.llvm.

[PATCH] D29386: Clzero flag addition and inclusion under znver1

2017-02-08 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM, but i'll make some additional testing changes before committing it. -Add __CLZERO__ checks to test/Preprocessor/predefined-arch-macros.c for znver1 -Add command line testing t

[PATCH] D28445: [Analyzer] Extend taint propagation and checking

2017-02-08 Thread Vlad Tsyrklevich via Phabricator via cfe-commits
vlad.tsyrklevich added inline comments. Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:442 + +const RecordDecl *RD = RT->getDecl()->getDefinition(); +for (const auto *I : RD->fields()) { a.sidorin wrote: > NoQ wrote: > > We need to be car

[libunwind] r294556 - Revert "[libunwind][CMake] Use libc++ headers when available"

2017-02-08 Thread Petr Hosek via cfe-commits
Author: phosek Date: Wed Feb 8 21:56:47 2017 New Revision: 294556 URL: http://llvm.org/viewvc/llvm-project?rev=294556&view=rev Log: Revert "[libunwind][CMake] Use libc++ headers when available" This is causing build failure when building libc++abi with libunwind. This reverts commit 42bf29501df

[libunwind] r294554 - [libunwind][CMake] Use libc++ headers when available

2017-02-08 Thread Petr Hosek via cfe-commits
Author: phosek Date: Wed Feb 8 20:20:25 2017 New Revision: 294554 URL: http://llvm.org/viewvc/llvm-project?rev=294554&view=rev Log: [libunwind][CMake] Use libc++ headers when available libunwind depends on C++ library headers. When building libunwind as part of LLVM and libc++ is available, use

[libcxx] r294553 - [libcxx][CMake] Support in-tree libunwind when building as part of runtimes

2017-02-08 Thread Petr Hosek via cfe-commits
Author: phosek Date: Wed Feb 8 20:19:43 2017 New Revision: 294553 URL: http://llvm.org/viewvc/llvm-project?rev=294553&view=rev Log: [libcxx][CMake] Support in-tree libunwind when building as part of runtimes When building as part of runtimes, there is no predefined order in which the runtimes ar

[libcxxabi] r294552 - [libcxxabi][CMake] Support in-tree libunwind when building as part of runtimes

2017-02-08 Thread Petr Hosek via cfe-commits
Author: phosek Date: Wed Feb 8 20:19:30 2017 New Revision: 294552 URL: http://llvm.org/viewvc/llvm-project?rev=294552&view=rev Log: [libcxxabi][CMake] Support in-tree libunwind when building as part of runtimes When building as part of runtimes, there is no predefined order in which the runtimes

Re: [cfe-commits] r164177 - in /cfe/trunk: lib/Driver/ test/Driver/ test/Driver/Inputs/freescale_ppc_tree/ test/Driver/Inputs/freescale_ppc_tree/lib/ test/Driver/Inputs/freescale_ppc_tree/usr/ test/Dr

2017-02-08 Thread Chandler Carruth via cfe-commits
It's blast from the past time! On Tue, Sep 18, 2012 at 3:28 PM Hal Finkel wrote: > Author: hfinkel > Date: Tue Sep 18 17:25:07 2012 > New Revision: 164177 > > URL: http://llvm.org/viewvc/llvm-project?rev=164177&view=rev > Log: > Add C/C++ header locations for the Freescale SDK. > > The Freescale

[PATCH] D29739: Make Lit tests C++11 compatible - Objective-C++

2017-02-08 Thread Charles Li via Phabricator via cfe-commits
tigerleapgorge created this revision. I am continuing to make our Lit tests C++11 compatible. This patch defaults five Objective-C++ tests to run under -std=gnu++98 This patch is essentially a continuation of Bug 24344 https://llvm.org/bugs/show_bug.cgi?id=24344 Fix r289167 resolved all tests in

[PATCH] D25674: [Concepts] Class template associated constraints

2017-02-08 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: include/clang/AST/DeclTemplate.h:373-391 +class TemplateDeclWithACBase { +protected: + TemplateDeclWithACBase() = default; + + ConstrainedTemplateDeclInfo CTDInfo; +}; + rsmith wrote: > This mechanism se

[libunwind] r294547 - Creating release candidate rc2 from release_400 branch

2017-02-08 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Feb 8 18:14:34 2017 New Revision: 294547 URL: http://llvm.org/viewvc/llvm-project?rev=294547&view=rev Log: Creating release candidate rc2 from release_400 branch Added: libunwind/tags/RELEASE_400/rc2/ (props changed) - copied from r294546, libunwind/branches/re

[libcxx] r294540 - Creating release candidate rc2 from release_400 branch

2017-02-08 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Feb 8 18:14:12 2017 New Revision: 294540 URL: http://llvm.org/viewvc/llvm-project?rev=294540&view=rev Log: Creating release candidate rc2 from release_400 branch Added: libcxx/tags/RELEASE_400/rc2/ (props changed) - copied from r294539, libcxx/branches/release_

[libcxxabi] r294541 - Creating release candidate rc2 from release_400 branch

2017-02-08 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Feb 8 18:14:16 2017 New Revision: 294541 URL: http://llvm.org/viewvc/llvm-project?rev=294541&view=rev Log: Creating release candidate rc2 from release_400 branch Added: libcxxabi/tags/RELEASE_400/rc2/ (props changed) - copied from r294540, libcxxabi/branches/re

Buildbot numbers for the last week of 01/29/2017 - 02/04/2017

2017-02-08 Thread Galina Kistanova via cfe-commits
Hello everyone, Below are some buildbot numbers for the last week of 01/29/2017 - 02/04/2017. Please see the same data in attached csv files: The longest time each builder was red during the last week; "Status change ratio" by active builder (percent of builds that changed the builder status fro

[PATCH] D29736: [WebAssembly] Add target specific overrides for lgamma family functions

2017-02-08 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. It doesn't make sense to do this in WebAssembly-specific code; every POSIX platform has a signgam which behaves the same way. https://reviews.llvm.org/D29736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

r294534 - Add check that "#define unix 1" is present for the PS4 target.

2017-02-08 Thread Douglas Yung via cfe-commits
Author: dyung Date: Wed Feb 8 18:07:38 2017 New Revision: 294534 URL: http://llvm.org/viewvc/llvm-project?rev=294534&view=rev Log: Add check that "#define unix 1" is present for the PS4 target. Modified: cfe/trunk/test/Preprocessor/init.c Modified: cfe/trunk/test/Preprocessor/init.c URL:

[PATCH] D29737: Updates documentation to include command to run clang-tidy tests.

2017-02-08 Thread CJ DiMeglio via Phabricator via cfe-commits
lethalantidote created this revision. Herald added a subscriber: JDevlieghere. Adds the commandline need to run clang-tidy tests. https://reviews.llvm.org/D29737 Files: clang-tools-extra/docs/clang-tidy/index.rst Index: clang-tools-extra/docs/clang-tidy/index.rst ===

[PATCH] D28543: Elliminates uninitialized warning for volitile varibles.

2017-02-08 Thread CJ DiMeglio via Phabricator via cfe-commits
lethalantidote added a comment. Any updates on this? https://reviews.llvm.org/D28543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29736: [WebAssembly] Add target specific overrides for lgamma family functions

2017-02-08 Thread Jacob Gravelle via Phabricator via cfe-commits
jgravelle-google created this revision. Herald added a subscriber: jfb. Current WebAssembly implementations use musl libc, which writes to signgam in its lgamma functions. We want the rest of the builtins to be const under -fno-math-errno, so overwrite lgamma's builtin definitions to be never-cons

[PATCH] D25674: [Concepts] Class template associated constraints

2017-02-08 Thread Richard Smith via Phabricator via cfe-commits
rsmith added inline comments. Comment at: include/clang/AST/DeclTemplate.h:373-391 +class TemplateDeclWithACBase { +protected: + TemplateDeclWithACBase() = default; + + ConstrainedTemplateDeclInfo CTDInfo; +}; + This mechanism seems unnecessary to me; allocatin

[PATCH] D29726: [Clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work for class members

2017-02-08 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/readability/DeleteNullPointerCheck.cpp:46 + DeleteExpr, DeleteMemberExpr, + compoundStmt(anyOf(has(Delete

[PATCH] D25674: [Concepts] Class template associated constraints

2017-02-08 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. Ping 2? https://reviews.llvm.org/D25674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16135: Macro Debug Info support in Clang

2017-02-08 Thread Adrian Prantl via cfe-commits
> On Feb 8, 2017, at 2:31 PM, David Blaikie wrote: > > > > On Wed, Feb 8, 2017 at 2:25 PM Amjad Aboud via Phabricator > mailto:revi...@reviews.llvm.org>> wrote: > aaboud added a comment. > > > How much does the build directory grow? > > Is there any noticeable compile time regression? > >

[PATCH] D29630: [libcxx] Threading support: externalize sleep_for()

2017-02-08 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg accepted this revision. joerg added a comment. One small issue left, otherwise LGTM. Comment at: include/__threading_support:187 +_LIBCPP_THREAD_ABI_VISIBILITY +void __libcpp_thread_sleep_for(const chrono::nanoseconds& ns); + Drop the name here. https:/

Re: [PATCH] D16135: Macro Debug Info support in Clang

2017-02-08 Thread David Blaikie via cfe-commits
On Wed, Feb 8, 2017 at 2:25 PM Amjad Aboud via Phabricator < revi...@reviews.llvm.org> wrote: > aaboud added a comment. > > > How much does the build directory grow? > > Is there any noticeable compile time regression? > > I build clang in release mode using GCC, then used that build to build > c

[PATCH] D16135: Macro Debug Info support in Clang

2017-02-08 Thread Amjad Aboud via Phabricator via cfe-commits
aaboud added a comment. > How much does the build directory grow? > Is there any noticeable compile time regression? I build clang in release mode using GCC, then used that build to build clang in debug mode with "-fstandalone-debug" flag, one time with my changes and another time without my c

[PATCH] D21626: Lit C++11 Compatibility Patch #10

2017-02-08 Thread Charles Li via Phabricator via cfe-commits
tigerleapgorge updated this revision to Diff 87711. tigerleapgorge edited the summary of this revision. tigerleapgorge added a comment. Remove 2 OpenMP tests reviewed via https://reviews.llvm.org/D29725 https://reviews.llvm.org/D21626 Files: test/Modules/Inputs/merge-using-decls/a.h test/Mo

r294522 - [sancov] pc_guard_init is called at least once per DSO.

2017-02-08 Thread Mike Aizatsky via cfe-commits
Author: aizatsky Date: Wed Feb 8 15:28:39 2017 New Revision: 294522 URL: http://llvm.org/viewvc/llvm-project?rev=294522&view=rev Log: [sancov] pc_guard_init is called at least once per DSO. Summary: Documentation update for https://reviews.llvm.org/D29662 Differential Revision: https://reviews.

r294512 - Initialize builtins during modular codegen

2017-02-08 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Wed Feb 8 14:51:11 2017 New Revision: 294512 URL: http://llvm.org/viewvc/llvm-project?rev=294512&view=rev Log: Initialize builtins during modular codegen Added: cfe/trunk/test/Modules/Inputs/codegen-opt/ cfe/trunk/test/Modules/Inputs/codegen-opt/bar.h - copie

r294509 - More fixes for places where 'decltype(auto)' is permitted in the C++ grammar but makes no sense.

2017-02-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Feb 8 14:39:08 2017 New Revision: 294509 URL: http://llvm.org/viewvc/llvm-project?rev=294509&view=rev Log: More fixes for places where 'decltype(auto)' is permitted in the C++ grammar but makes no sense. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D29726: [Clang-tidy] Fix for bug 31838: readability-delete-null-pointer does not work for class members

2017-02-08 Thread Mads Ravn via Phabricator via cfe-commits
madsravn created this revision. Made a small fix to readability-delete-null-pointer check such that it includes class members. https://reviews.llvm.org/D29726 Files: clang-tidy/readability/DeleteNullPointerCheck.cpp clang-tidy/readability/DeleteNullPointerCheck.h test/clang-tidy/readabil

r294506 - Don't crash on 'decltype(auto)::'. Rather than treating it as a meaningless

2017-02-08 Thread Richard Smith via cfe-commits
Author: rsmith Date: Wed Feb 8 13:58:48 2017 New Revision: 294506 URL: http://llvm.org/viewvc/llvm-project?rev=294506&view=rev Log: Don't crash on 'decltype(auto)::'. Rather than treating it as a meaningless nested-name-specifier (as the standard appears to require), treat it as the type specifie

r294504 - [Lit Test] Make tests C++11 compatible - Parse OpenMP

2017-02-08 Thread Charles Li via cfe-commits
Author: lcharles Date: Wed Feb 8 13:46:15 2017 New Revision: 294504 URL: http://llvm.org/viewvc/llvm-project?rev=294504&view=rev Log: [Lit Test] Make tests C++11 compatible - Parse OpenMP Differential Revision: https://reviews.llvm.org/D29725 Modified: cfe/trunk/test/OpenMP/declare_reductio

[PATCH] D29725: Lit C++11 Compatibility - Parse OpenMP

2017-02-08 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL294504: [Lit Test] Make tests C++11 compatible - Parse OpenMP (authored by lcharles). Changed prior to commit: https://reviews.llvm.org/D29725?vs=87684&id=87687#toc Repository: rL LLVM https://revie

[PATCH] D29725: Lit C++11 Compatibility - Parse OpenMP

2017-02-08 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D29725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2017-02-08 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:54 +// FIXME use DiagnosticIDs::Level::Note +diag(NoExceptRange.getBegin(), "in a function declared no-throw here:", DiagnosticIDs::Note) +<< FixItHint::CreateRemoval(NoExceptRan

[PATCH] D29725: Lit C++11 Compatibility - Parse OpenMP

2017-02-08 Thread Charles Li via Phabricator via cfe-commits
tigerleapgorge created this revision. I am continuing to make out Lit tests C++11 compatible. There are two tests in this patch. Both tests verify parse errors with ill formed OpenMP expressions. test/OpenMP/declare_reduction_messages.cpp In C++11, an opening square bracket is the start of a l

[PATCH] D29724: [Driver] Report available language standards on user error

2017-02-08 Thread Paweł Żukowski via Phabricator via cfe-commits
idlecode created this revision. In case user did not provide valid standard name for `-std` option, available values (with short description) will be reported. To test: `clang -std=iso3103 -c source.c` https://reviews.llvm.org/D29724 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/

[libcxx] r294501 - Update info for LWG 2665 in upcoming_meeting.html

2017-02-08 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Wed Feb 8 13:04:18 2017 New Revision: 294501 URL: http://llvm.org/viewvc/llvm-project?rev=294501&view=rev Log: Update info for LWG 2665 in upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http:

[PATCH] D29723: [Sema] Add lvalue-to-rvalue cast in direct-list-initialization of enum

2017-02-08 Thread Vedant Kumar via Phabricator via cfe-commits
vsk created this revision. After r264564, we allowed direct-list-initialization of an enum from an integral value in C++1z mode, so long as that value can convert to the enum's underlying type. In this kind of initialization, we need a lvalue-to-rvalue conversion for the initializer value if it i

[PATCH] D29699: [clang-tidy] Add -extra-arg and -extra-arg-before to clang-tidy-diff.py

2017-02-08 Thread Ehsan Akhgari via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL294491: [clang-tidy] Add -extra-arg and -extra-arg-before to clang-tidy-diff.py (authored by ehsan). Changed prior to commit: https://reviews.llvm.org/D29699?vs=87576&id=87673#toc Repository: rL LLVM

[clang-tools-extra] r294491 - [clang-tidy] Add -extra-arg and -extra-arg-before to clang-tidy-diff.py

2017-02-08 Thread Ehsan Akhgari via cfe-commits
Author: ehsan Date: Wed Feb 8 11:50:24 2017 New Revision: 294491 URL: http://llvm.org/viewvc/llvm-project?rev=294491&view=rev Log: [clang-tidy] Add -extra-arg and -extra-arg-before to clang-tidy-diff.py Summary: These flags allow specifying extra arguments to the tool's command line which don't

[libcxx] r294483 - Docs: drop minor version

2017-02-08 Thread Hans Wennborg via cfe-commits
Author: hans Date: Wed Feb 8 11:28:23 2017 New Revision: 294483 URL: http://llvm.org/viewvc/llvm-project?rev=294483&view=rev Log: Docs: drop minor version Modified: libcxx/branches/release_40/docs/conf.py Modified: libcxx/branches/release_40/docs/conf.py URL: http://llvm.org/viewvc/llvm-pr

[PATCH] D29630: [libcxx] Threading support: externalize sleep_for()

2017-02-08 Thread Asiri Rathnayake via Phabricator via cfe-commits
rmaprath added a comment. In https://reviews.llvm.org/D29630#670876, @EricWF wrote: > In https://reviews.llvm.org/D29630#670873, @rmaprath wrote: > > > Sorry for the delay, I've updated the patch with all the comments addressed. > > > > @EricWF: Got one question before I commit: The `sleep_for` f

[PATCH] D29630: [libcxx] Threading support: externalize sleep_for()

2017-02-08 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. In https://reviews.llvm.org/D29630#670873, @rmaprath wrote: > Sorry for the delay, I've updated the patch with all the comments addressed. > > @EricWF: Got one question before I commit: The `sleep_for` function in the > dylib (`thread.cpp`) is now quite small. Is there a

[PATCH] D29630: [libcxx] Threading support: externalize sleep_for()

2017-02-08 Thread Asiri Rathnayake via Phabricator via cfe-commits
rmaprath updated this revision to Diff 87669. rmaprath added a comment. Sorry for the delay, I've updated the patch with all the comments addressed. @EricWF: Got one question before I commit: The `sleep_for` function in the dylib (`thread.cpp`) is now quite small. Is there a particular reason to

r294465 - [MS] Fix C++ destructor thunk line info for a declaration

2017-02-08 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Feb 8 10:09:32 2017 New Revision: 294465 URL: http://llvm.org/viewvc/llvm-project?rev=294465&view=rev Log: [MS] Fix C++ destructor thunk line info for a declaration Sometimes the MS ABI needs to emit thunks for declarations that don't have bodies. Destructor thunks make cal

[clang-tools-extra] r294467 - [clang-tidy] hasErrorOccurred() -> hasUncompilableErrorOccurred()

2017-02-08 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Wed Feb 8 10:11:22 2017 New Revision: 294467 URL: http://llvm.org/viewvc/llvm-project?rev=294467&view=rev Log: [clang-tidy] hasErrorOccurred() -> hasUncompilableErrorOccurred() hasErrorOccurred() -> hasUncompilableErrorOccurred(), since we only care about errors that lead to

[PATCH] D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks

2017-02-08 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: lib/Tooling/RefactoringCallbacks.cpp:160 +llvm::Expected> +ReplaceNodeWithTemplate::create(StringRef FromId, StringRef ToTemplate) { + std::vector ParsedTemplate; Is this covered in the test? Comment a

[PATCH] D29718: [libclang] [OpenCL] Expose half type

2017-02-08 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh created this revision. Expose the half type (fp16) through libclang and the python bindings. It seems CXType_LastBuiltin was not updated in b2ea6d9 ("Enable support for __float128 in Clang", 2016-04-13), so update it now. Add an Index test for OpenCL types; in the future we will add other

[PATCH] D28973: Supresses misc-move-constructor-init warning for const fields.

2017-02-08 Thread Alexander Kornienko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL294459: [clang-tidy] Supresses misc-move-constructor-init warning for const fields. (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D28973?vs=87484&id=87655#toc Repository: rL

[clang-tools-extra] r294459 - [clang-tidy] Supresses misc-move-constructor-init warning for const fields.

2017-02-08 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Wed Feb 8 08:56:16 2017 New Revision: 294459 URL: http://llvm.org/viewvc/llvm-project?rev=294459&view=rev Log: [clang-tidy] Supresses misc-move-constructor-init warning for const fields. Patch by CJ DiMeglio! Differential revision: https://reviews.llvm.org/D28973 Modified:

[PATCH] D29716: [clang-format] Move OriginalPrefix from base to subclass.

2017-02-08 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL294457: [clang-format] Move OriginalPrefix from base to subclass. (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D29716?vs=87643&id=87653#toc Repository: rL LLVM https://r

[PATCH] D29716: [clang-format] Move OriginalPrefix from base to subclass.

2017-02-08 Thread Daniel Jasper via Phabricator via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

r294457 - [clang-format] Move OriginalPrefix from base to subclass.

2017-02-08 Thread Krasimir Georgiev via cfe-commits
Author: krasimir Date: Wed Feb 8 08:45:19 2017 New Revision: 294457 URL: http://llvm.org/viewvc/llvm-project?rev=294457&view=rev Log: [clang-format] Move OriginalPrefix from base to subclass. Summary: OriginalPrefix is only needed for line comment sections. Moved from the base class to the chil

[PATCH] D28973: Supresses misc-move-constructor-init warning for const fields.

2017-02-08 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. I'll commit the patch for you. https://reviews.llvm.org/D28973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D29713: [clang-format] Move comment tests to their own file.

2017-02-08 Thread Daniel Jasper via Phabricator via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D29708: [compiler-rt] [test] #ifdef new builtin tests for __arm__ platform

2017-02-08 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL294438: [test] #ifdef new builtin tests for __arm__ platform (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D29708?vs=87617&id=87629#toc Repository: rL LLVM https://reviews.

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

2017-02-08 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL294435: [clang-format] Break before a sequence of line comments aligned with the next… (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D29626?vs=87615&id=87622#toc Repository:

r294435 - [clang-format] Break before a sequence of line comments aligned with the next line.

2017-02-08 Thread Krasimir Georgiev via cfe-commits
Author: krasimir Date: Wed Feb 8 04:30:44 2017 New Revision: 294435 URL: http://llvm.org/viewvc/llvm-project?rev=294435&view=rev Log: [clang-format] Break before a sequence of line comments aligned with the next line. Summary: Make the comment alignment respect sections of line comments origina

[PATCH] D29692: [clang-tidy] add check modernize-use-const-instead-of-define

2017-02-08 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons added inline comments. Comment at: clang-tidy/modernize/UseConstInsteadOfDefineCheck.cpp:20 +namespace { +class MacroParenthesesPPCallbacks : public PPCallbacks { +public: s/MacroParentheses/ConstantValues/ ? Comment at: docs/cl

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

2017-02-08 Thread Manuel Klimek via Phabricator via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg. I'd probably still call it consumeComments or something, as we require a flush afterwards for the unconsumed comments, but I don't feel too strongly about that. https://reviews.llvm.org

[PATCH] D29706: [libcxx] [test] Fix hard_link_count test to account for fs with dir nlink==1

2017-02-08 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL294431: [test] Fix hard_link_count test to account for fs with dir nlink==1 (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D29706?vs=87613&id=87618#toc Repository: rL LLVM h

[libcxx] r294431 - [test] Fix hard_link_count test to account for fs with dir nlink==1

2017-02-08 Thread Michal Gorny via cfe-commits
Author: mgorny Date: Wed Feb 8 03:57:32 2017 New Revision: 294431 URL: http://llvm.org/viewvc/llvm-project?rev=294431&view=rev Log: [test] Fix hard_link_count test to account for fs with dir nlink==1 Filesystems are not required to maintain a hard link count consistent with number of subdirector

[PATCH] D29708: [compiler-rt] [test] #ifdef new builtin tests for __arm__ platform

2017-02-08 Thread Michał Górny via Phabricator via cfe-commits
mgorny created this revision. Herald added subscribers: dberris, aemerson. Add an #if that excludes the newly added aeabi* tests on non-ARM platforms. This is consistent with other ARM tests, and aims to make running builtin tests easier. Lacking a proper infrastructure to run tests selectively, i

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

2017-02-08 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: lib/Format/UnwrappedLineParser.h:121-123 + // Comments specifies the sequence of comment tokens to analyze. They get + // either pushed to the current line or added to the comments before the next + // token. klimek

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

2017-02-08 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 87615. krasimir marked an inline comment as done. krasimir added a comment. - Updated call sites. https://reviews.llvm.org/D29626 Files: lib/Format/UnwrappedLineParser.cpp lib/Format/UnwrappedLineParser.h unittests/Format/FormatTest.cpp Index: unitt

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

2017-02-08 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 87614. krasimir added a comment. - Invent better name for comment analysis. https://reviews.llvm.org/D29626 Files: lib/Format/UnwrappedLineParser.cpp lib/Format/UnwrappedLineParser.h unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest

[PATCH] D29707: Fix improper microsoft-pure-definition warning on template class

2017-02-08 Thread Rudy Pons via Phabricator via cfe-commits
Ilod created this revision. Clang emits a warning when using pure specifier =0 in function definition at class scope, which is a MS-specific construct, when using -fms-extensions. However, to detect this, it was using FD->isCanonicalDecl() on function declaration, which was also detecting out-of

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

2017-02-08 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added inline comments. Comment at: lib/Format/UnwrappedLineParser.h:121-123 + // Comments specifies the sequence of comment tokens to analyze. They get + // either pushed to the current line or added to the comments before the next + // token. krasimir

[PATCH] D29706: [libcxx] [test] Fix hard_link_count test to account for fs with dir nlink==1

2017-02-08 Thread Michał Górny via Phabricator via cfe-commits
mgorny created this revision. Filesystems are not required to maintain a hard link count consistent with number of subdirectories. For example, on btrfs all directories have nlink==1. Account for that in the test. Repository: rL LLVM https://reviews.llvm.org/D29706 Files: test/std/experim

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

2017-02-08 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: lib/Format/UnwrappedLineParser.h:121-123 + // Comments specifies the sequence of comment tokens to analyze. They get + // either pushed to the current line or added to the comments before the next + // token. klimek

[PATCH] D29469: Fix PR31843: Clang-4.0 crashes/assert while evaluating __builtin_object_size

2017-02-08 Thread Mehdi AMINI via Phabricator via cfe-commits
mehdi_amini added a comment. Ping? This is hitting 4.0 https://reviews.llvm.org/D29469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29699: [clang-tidy] Add -extra-arg and -extra-arg-before to clang-tidy-diff.py

2017-02-08 Thread Manuel Klimek via Phabricator via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

2017-02-08 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added inline comments. Comment at: lib/Format/UnwrappedLineParser.h:121-123 + // Comments specifies the sequence of comment tokens to analyze. They get + // either pushed to the current line or added to the comments before the next + // token. krasimir

[PATCH] D29628: [compiler-rt] [test] Enable the strace_test only if strace is installed

2017-02-08 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL294425: [test] Enable the strace_test only if strace is installed (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D29628?vs=87392&id=87603#toc Repository: rL LLVM https://rev

[PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

2017-02-08 Thread Varju Janos via Phabricator via cfe-commits
varjujan added a comment. @xazax.hun Yes I do. Obviously some of them seem to be better than the others so I can remove a couple if needed. https://reviews.llvm.org/D20689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

r294424 - [X86] Add -mprefetchwt1/-mno-prefetchwt1 command line options and __PREFETCHWT1__ define to match gcc.

2017-02-08 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Feb 8 02:23:40 2017 New Revision: 294424 URL: http://llvm.org/viewvc/llvm-project?rev=294424&view=rev Log: [X86] Add -mprefetchwt1/-mno-prefetchwt1 command line options and __PREFETCHWT1__ define to match gcc. Modified: cfe/trunk/docs/ClangCommandLineReference.rst

r294423 - [X86] Add -msgx/-mno-sgx command line options and __SGX__ define to match gcc.

2017-02-08 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Feb 8 02:23:17 2017 New Revision: 294423 URL: http://llvm.org/viewvc/llvm-project?rev=294423&view=rev Log: [X86] Add -msgx/-mno-sgx command line options and __SGX__ define to match gcc. Modified: cfe/trunk/docs/ClangCommandLineReference.rst cfe/trunk/include/cla

[PATCH] D26244: [Driver] Add CLANG_PREFER_GCC_LIBRARIES which can be disabled

2017-02-08 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. gentle ping https://reviews.llvm.org/D26244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r294420 - [X86] Update command line documentation for -mclwb and -mmovbe which I forgot in my previous commits.

2017-02-08 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Feb 8 01:57:01 2017 New Revision: 294420 URL: http://llvm.org/viewvc/llvm-project?rev=294420&view=rev Log: [X86] Update command line documentation for -mclwb and -mmovbe which I forgot in my previous commits. Modified: cfe/trunk/docs/ClangCommandLineReference.rst

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

2017-02-08 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir marked an inline comment as done. krasimir added inline comments. Comment at: lib/Format/UnwrappedLineParser.h:121-123 + // Comments specifies the sequence of comment tokens to analyze. They get + // either pushed to the current line or added to the comments before the

r294419 - [X86] Add -mmpx/-mno-mpx command line options and __MPX__ define to match gcc.

2017-02-08 Thread Craig Topper via cfe-commits
Author: ctopper Date: Wed Feb 8 01:56:42 2017 New Revision: 294419 URL: http://llvm.org/viewvc/llvm-project?rev=294419&view=rev Log: [X86] Add -mmpx/-mno-mpx command line options and __MPX__ define to match gcc. Modified: cfe/trunk/docs/ClangCommandLineReference.rst cfe/trunk/include/cla