pirama updated this revision to Diff 88662.
pirama added a comment.
Changed the name of the utility that builds the arch-specific directory.
https://reviews.llvm.org/D30015
Files:
include/clang/Driver/ToolChain.h
lib/Driver/ToolChain.cpp
lib/Driver/Tools.cpp
test/Driver/Inputs/resource_
mgorny added inline comments.
Comment at: lib/Driver/ToolChain.cpp:327
+ llvm::sys::path::append(Path, "lib", OSLibName,
+ getArchName());
+ return Path.str();
I would suggest using arch type, to avoid e.g. i386/i486/i586 mess. It's rea
mgorny added inline comments.
Comment at: lib/Driver/Tools.cpp:3267
+ if (llvm::sys::fs::is_directory(CandidateLibPath))
+CmdArgs.push_back(Args.MakeArgString("-L" + CandidateLibPath));
+
Don't you also need rpath for it? Or is this purely for static runtime
karies added inline comments.
Comment at: lib/Lex/PPDirectives.cpp:1983
+ isLeadingSeparator = false;
+else
+ Path.append(Component);
eric_niebler wrote:
> What happens on Windows for an absolute path like "C:/hello/world.h", I
> wonder
pirama updated this revision to Diff 88663.
pirama added a comment.
Use getArchTypeName() instead of getArchName().
https://reviews.llvm.org/D30015
Files:
include/clang/Driver/ToolChain.h
lib/Driver/ToolChain.cpp
lib/Driver/Tools.cpp
test/Driver/Inputs/resource_dir_with_arch_subdir/lib/
Michał,
It'd make sense to use file(TO_CMAKE_PATH). I forgot it.
I think get_file_component() satisfies in this case. Do you think to use
file(TO_CMAKE_PATH) anyways?
I'll wait for you as an opinion before proposing this fix to release_40.
The bug is still in release_40.
I don't think we could tw
pirama added a subscriber: openmp-commits.
pirama marked an inline comment as done.
pirama added inline comments.
Comment at: lib/Driver/Tools.cpp:3267
+ if (llvm::sys::fs::is_directory(CandidateLibPath))
+CmdArgs.push_back(Args.MakeArgString("-L" + CandidateLibPath));
+
---
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
https://reviews.llvm.org/D29922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Hahnfeld added a comment.
I still think this should not be done for OpenMP only and hence move out of
`addOpenMPRuntime`.
(Why the heck are there //two// places to add `-lomp`?!? I'll clean that up
later...)
https://reviews.llvm.org/D30015
___
cf
pirama added a comment.
I am fine to do this more generally, but not sure of the scope. Should this be
always added or only if a runtime (sanitizer or openmp or xray) is requested?
https://reviews.llvm.org/D30015
___
cfe-commits mailing list
cfe-c
Hahnfeld added a comment.
In https://reviews.llvm.org/D30015#678294, @pirama wrote:
> I am fine to do this more generally, but not sure of the scope. Should this
> be always added or only if a runtime (sanitizer or openmp or xray) is
> requested?
I think always. From my point of view, this w
sepavloff created this revision.
These attributes effectively turns a non-defining declaration into a
definition, so the case when the declaration already has a body must
be diagnosed properly.
https://reviews.llvm.org/D30032
Files:
lib/Sema/SemaDecl.cpp
test/Sema/alias-redefinition.c
tes
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295301: Cache FileID when translating diagnostics in PCH
files (authored by erikjv).
Changed prior to commit:
https://reviews.llvm.org/D29755?vs=88366&id=88701#toc
Repository:
rL LLVM
https://review
Author: erikjv
Date: Thu Feb 16 03:49:30 2017
New Revision: 295301
URL: http://llvm.org/viewvc/llvm-project?rev=295301&view=rev
Log:
Cache FileID when translating diagnostics in PCH files
Modules/preambles/PCH files can contain diagnostics, which, when used,
are added to the current ASTUnit. For
krasimir updated this revision to Diff 88703.
krasimir edited the summary of this revision.
krasimir added a comment.
- Address review comments
https://reviews.llvm.org/D29990
Files:
clangd/ClangDMain.cpp
clangd/Protocol.cpp
clangd/Protocol.h
clangd/ProtocolHandlers.cpp
clangd/Protoco
theraven added a comment.
This code is working around something that's probably a clang bug. It would be
better to fix the clang bug than add more complex workarounds.
Repository:
rL LLVM
https://reviews.llvm.org/D30025
___
cfe-commits mailing
klimek added inline comments.
Comment at: lib/Format/BreakableToken.cpp:397
+//
+// Don't try aligning if there are less lines, since some patterns like
+//
fewer lines
Comment at: lib/Format/BreakableToken.cpp:402
+
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D29990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
hiraditya created this revision.
https://reviews.llvm.org/D30035
Files:
include/locale
Index: include/locale
===
--- include/locale
+++ include/locale
@@ -385,12 +385,12 @@
_CharT& __thousan
Author: alexfh
Date: Thu Feb 16 04:23:18 2017
New Revision: 295303
URL: http://llvm.org/viewvc/llvm-project?rev=295303&view=rev
Log:
[clang-tidy] Ignore spaces between globs in the Checks option.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp
clang-tools-ext
redm123 added a comment.
In https://reviews.llvm.org/D29944#678033, @arphaman wrote:
> Do these diagnostics have the full qualifiers for errors that occur with
> record types instead of typedefs?
Not sure what you mean by that, but as far as I can see all the changed errors
refer to typedefs/
alexfh added a comment.
> it may introduce true positives
True positives is all we need from clang-tidy checks ;) I guess, you meant
"false negatives"
(https://en.wikipedia.org/wiki/False_positives_and_false_negatives).
The main question here is whether we should extend the AST instead of ha
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295304: [clangd] Implement format on type (authored by
krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29990?vs=88703&id=88708#toc
Repository:
rL LLVM
https://reviews.llvm.org/D29990
Author: krasimir
Date: Thu Feb 16 04:49:46 2017
New Revision: 295304
URL: http://llvm.org/viewvc/llvm-project?rev=295304&view=rev
Log:
[clangd] Implement format on type
Summary:
This patch adds onTypeFormatting to clangd.
The trigger character is '}' and it works by scanning for the matching '{'
Author: krasimir
Date: Thu Feb 16 04:53:27 2017
New Revision: 295305
URL: http://llvm.org/viewvc/llvm-project?rev=295305&view=rev
Log:
[clangd] Fix Output.log error
Modified:
clang-tools-extra/trunk/clangd/ProtocolHandlers.cpp
Modified: clang-tools-extra/trunk/clangd/ProtocolHandlers.cpp
URL
arpith-jacob marked an inline comment as done.
arpith-jacob added a comment.
Alexey, do you any more comments on this patch?
https://reviews.llvm.org/D29879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
alexfh added a comment.
Richard, it seems like the AST could be improved here by adding nodes for the
explicit instantiation declarations and definitions or using existing nodes, if
there are suitable ones. What do you think?
https://reviews.llvm.org/D30034
_
Author: stulova
Date: Thu Feb 16 05:13:30 2017
New Revision: 295307
URL: http://llvm.org/viewvc/llvm-project?rev=295307&view=rev
Log:
[OpenCL] Disallow blocks capture other blocks (v2.0, s6.12.5)
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/trunk/lib/Sema/SemaExpr.c
Hahnfeld added a comment.
Maybe something like the following (without tests):
diff --git a/include/clang/Driver/ToolChain.h
b/include/clang/Driver/ToolChain.h
index ffb0d60..0f3507d 100644
--- a/include/clang/Driver/ToolChain.h
+++ b/include/clang/Driver/ToolChain.h
@@ -299,6 +299,11 @
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:715
+// lane_offset, int16_t shortCircuit),
+// void (*kmp_InterWarpCopyFctPtr)(void* src, int warp_num),
+// void (*kmp_CopyToScratchpadFctPtr)(void *reduce_data, void * scratchpad,
-
mgorny added a comment.
In https://reviews.llvm.org/D30025#678462, @theraven wrote:
> This code is working around something that's probably a clang bug. It would
> be better to fix the clang bug than add more complex workarounds.
Well, clang explicitly rejects those functions as errors, so I
Author: stulova
Date: Thu Feb 16 06:27:47 2017
New Revision: 295311
URL: http://llvm.org/viewvc/llvm-project?rev=295311&view=rev
Log:
[OpenCL] Correct ndrange_t implementation
Removed ndrange_t as Clang builtin type and added
as a struct type in the OpenCL header.
Use type name to do the Sema ch
krasimir updated this revision to Diff 88713.
krasimir added a comment.
- Align decorations of block comments spanning two lines
https://reviews.llvm.org/D29943
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
unittests/Format/FormatTest.cpp
unittests/Format/FormatTestCo
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D29943
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: krasimir
Date: Thu Feb 16 06:39:31 2017
New Revision: 295312
URL: http://llvm.org/viewvc/llvm-project?rev=295312&view=rev
Log:
[clang-format] Align block comment decorations
Summary:
This patch implements block comment decoration alignment.
source:
```
/* line 1
* line 2
*/
```
result b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295312: [clang-format] Align block comment decorations
(authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29943?vs=88713&id=88714#toc
Repository:
rL LLVM
https://reviews.llvm
arpith-jacob updated this revision to Diff 88715.
arpith-jacob added a comment.
Addressed review comments.
https://reviews.llvm.org/D29879
Files:
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/nvptx_teams_reduction_codegen.cpp
Index: test/OpenMP/nvptx_teams
Author: stulova
Date: Thu Feb 16 06:49:29 2017
New Revision: 295313
URL: http://llvm.org/viewvc/llvm-project?rev=295313&view=rev
Log:
[OpenCL][Doc] Added OpenCL vendor extension description to user manual doc
Added description of a new feature that allows to specify
vendor extension in flexible w
Of course Richard - I'll be happy to bump that value for C++1z
hopefully later today.
Thanks!
Faisal Vali
On Wed, Feb 15, 2017 at 10:30 PM, Richard Smith wrote:
> On 15 February 2017 at 20:12, Faisal Vali via cfe-commits
> wrote:
>>
>> Author: faisalv
>> Date: Wed Feb 15 22:12:21 2017
>> New R
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D29879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: krasimir
Date: Thu Feb 16 07:17:38 2017
New Revision: 295317
URL: http://llvm.org/viewvc/llvm-project?rev=295317&view=rev
Log:
Fix clang-move test after clang-format update r295312
Modified:
clang-tools-extra/trunk/unittests/clang-move/ClangMoveTests.cpp
Modified: clang-tools-extra/t
sylvestre.ledru added a comment.
Maybe this could be added to the release notes?
Repository:
rL LLVM
https://reviews.llvm.org/D29943
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
sebpop added a comment.
Looks good to me.
https://reviews.llvm.org/D30035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
theraven added a comment.
No, it's a bug in clang. Clang does not reject other functions that are used
to implement builtins (if it did, compiler-rt would be a lot more difficult to
build).
Repository:
rL LLVM
https://reviews.llvm.org/D30025
_
Anastasia closed this revision.
Anastasia added a comment.
Committed to release40@295315
https://reviews.llvm.org/D29830
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia closed this revision.
Anastasia added a comment.
Committed in 295311
https://reviews.llvm.org/D28058
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arpith
Date: Thu Feb 16 08:03:36 2017
New Revision: 295319
URL: http://llvm.org/viewvc/llvm-project?rev=295319&view=rev
Log:
[OpenMP] Parallel reduction on the NVPTX device.
This patch implements codegen for the reduction clause on
any parallel construct for elementary data types. An eff
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295319: [OpenMP] Parallel reduction on the NVPTX device.
(authored by arpith).
Changed prior to commit:
https://reviews.llvm.org/D29758?vs=88149&id=88726#toc
Repository:
rL LLVM
https://reviews.llvm
Anastasia closed this revision.
Anastasia added a comment.
Committed in 295313!
https://reviews.llvm.org/D29829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
idlecode closed this revision.
idlecode added a comment.
Committed as r295113
https://reviews.llvm.org/D29724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: d0k
Date: Thu Feb 16 08:08:41 2017
New Revision: 295320
URL: http://llvm.org/viewvc/llvm-project?rev=295320&view=rev
Log:
Silence sign compare warning. NFC.
ExprConstant.cpp:6344:20: warning: comparison of integers of different
signs: 'const size_t' (aka 'const unsigned long') and 'typena
joerg added a comment.
Note that the normal compiler-rt functions have a different name than the
builtins they provide, at least from the C frontend view.
Repository:
rL LLVM
https://reviews.llvm.org/D30025
___
cfe-commits mailing list
cfe-commi
Hans, could we merge this documentation only change (r295313) in release40
branch. I can commit myself if needed. :)
Thanks in advance,
Anastasia
-Original Message-
From: Anastasia Stulova via Phabricator [mailto:revi...@reviews.llvm.org]
Sent: 16 February 2017 14:15
To: Anastasia Stulov
Anastasia closed this revision.
Anastasia added a comment.
Committed in r295307!
https://reviews.llvm.org/D29764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: arpith
Date: Thu Feb 16 08:25:35 2017
New Revision: 295323
URL: http://llvm.org/viewvc/llvm-project?rev=295323&view=rev
Log:
Revert r295319 while investigating buildbot failure.
Removed:
cfe/trunk/test/OpenMP/nvptx_target_parallel_reduction_codegen.cpp
Modified:
cfe/trunk/lib/Code
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. Sorry for the slow response.
https://reviews.llvm.org/D28172
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
mclow.lists created this revision.
http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4190 removed
`random_shuffle` from C++1z. (and other stuff)
Wrap all the random_shuffle bits in an #ifdef so they disappear when compiling
with `-std=c++1z` or later.
Introduce a new configuration opti
On Wed, Feb 15, 2017 at 7:42 PM, Richard Smith via cfe-commits
wrote:
> https://bugs.llvm.org/show_bug.cgi?id=31977 makes the good point that this
> is warning on a certain idiomatic use of capture-by-value to extend the
> lifetime of an RAII object; consider:
>
> shared_ptr p = /*...*/;
> int
Author: compnerd
Date: Thu Feb 16 09:47:50 2017
New Revision: 295330
URL: http://llvm.org/viewvc/llvm-project?rev=295330&view=rev
Log:
math: correct the MSVCRT condition
Fixes a number of tests in the testsuite on Windows.
Modified:
libcxx/trunk/include/cmath
libcxx/trunk/include/math.h
Author: compnerd
Date: Thu Feb 16 09:47:45 2017
New Revision: 295329
URL: http://llvm.org/viewvc/llvm-project?rev=295329&view=rev
Log:
threading_support: make __thread_sleep_for be alertable
On Windows, we were using `Sleep` which is not alertable. This means
that if the thread was used for a us
Author: arpith
Date: Thu Feb 16 10:20:16 2017
New Revision: 295333
URL: http://llvm.org/viewvc/llvm-project?rev=295333&view=rev
Log:
[OpenMP] Parallel reduction on the NVPTX device.
This patch implements codegen for the reduction clause on
any parallel construct for elementary data types. An eff
Author: arpith
Date: Thu Feb 16 10:48:49 2017
New Revision: 295335
URL: http://llvm.org/viewvc/llvm-project?rev=295335&view=rev
Log:
[OpenMP] Teams reduction on the NVPTX device.
This patch implements codegen for the reduction clause on
any teams construct for elementary data types. It builds
on
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295335: [OpenMP] Teams reduction on the NVPTX device.
(authored by arpith).
Changed prior to commit:
https://reviews.llvm.org/D29879?vs=88715&id=88746#toc
Repository:
rL LLVM
https://reviews.llvm.or
I've merged it in r295340.
Cheers,
Hans
On Thu, Feb 16, 2017 at 6:26 AM, Anastasia Stulova
wrote:
> Hans, could we merge this documentation only change (r295313) in release40
> branch. I can commit myself if needed. :)
>
> Thanks in advance,
> Anastasia
>
> -Original Message-
> From: An
erichkeane added a comment.
@rsmith did you ever get a chance to re-review this? Is this what you were
wanting for this?
https://reviews.llvm.org/D27486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
erichkeane added a comment.
Hi guys-
Since this is a rework of Vlad's changes, I'm not sure you noticed that this
was a different review! Anyone have opinions? Additionally, I had 1 question
in SemaDecl.cpp that I think was right, otherwise I hope this is a pretty light
review.
https://revi
erichkeane added a comment.
Thoughts?
https://reviews.llvm.org/D29401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D29530
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
arphaman added a comment.
In https://reviews.llvm.org/D30009#678091, @hfinkel wrote:
> I don't understand why it only supports some attributes. Is there some
> handling that needs to take place (I don't see anything obvious in this
> patch)? If most attributes will "just work", I'd much rather
hfinkel added a comment.
In https://reviews.llvm.org/D30009#678890, @arphaman wrote:
> In https://reviews.llvm.org/D30009#678091, @hfinkel wrote:
>
> > I don't understand why it only supports some attributes. Is there some
> > handling that needs to take place (I don't see anything obvious in th
efriedma added inline comments.
Comment at: lib/Parse/ParseStmt.cpp:186
// found.
-if (Next.isNot(tok::coloncolon)) {
+if (Next.isNot(tok::coloncolon) && (!getLangOpts().MSVCCompat ||
+Next.isNot(tok::less))) {
erichkeane wrote:
> Clang-tidy
erichkeane added inline comments.
Comment at: lib/Parse/ParseStmt.cpp:186
// found.
-if (Next.isNot(tok::coloncolon)) {
+if (Next.isNot(tok::coloncolon) && (!getLangOpts().MSVCCompat ||
+Next.isNot(tok::less))) {
efriedma wrote:
> erichkeane
Author: marshall
Date: Thu Feb 16 12:50:30 2017
New Revision: 295355
URL: http://llvm.org/viewvc/llvm-project?rev=295355&view=rev
Log:
Update a couple of issue statuses
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/viewvc/llvm
efriedma added inline comments.
Comment at: lib/Parse/ParseStmt.cpp:186
// found.
-if (Next.isNot(tok::coloncolon)) {
+if (Next.isNot(tok::coloncolon) && (!getLangOpts().MSVCCompat ||
+Next.isNot(tok::less))) {
erichkeane wrote:
> efriedma wr
erichkeane added inline comments.
Comment at: lib/Parse/ParseStmt.cpp:186
// found.
-if (Next.isNot(tok::coloncolon)) {
+if (Next.isNot(tok::coloncolon) && (!getLangOpts().MSVCCompat ||
+Next.isNot(tok::less))) {
efriedma wrote:
> erichkeane
tigerleapgorge added a comment.
@rjmccall
Hi John, I've made the changes to volatile.cpp.
I take it this patch is good for commit?
https://reviews.llvm.org/D24812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
karies added inline comments.
Comment at: test/Lexer/case-insensitive-include-pr31836.sh:6
+// RUN: touch %T/case-insensitive-include-pr31836.h
+// RUN: echo "#include \"%T/Case-Insensitive-Include-Pr31836.h\"" | %clang_cc1
-E - 2>&1 | FileCheck %s
+
@twoh Does
twoh added inline comments.
Comment at: test/Lexer/case-insensitive-include-pr31836.sh:6
+// RUN: touch %T/case-insensitive-include-pr31836.h
+// RUN: echo "#include \"%T/Case-Insensitive-Include-Pr31836.h\"" | %clang_cc1
-E - 2>&1 | FileCheck %s
+
karies wrote:
What is _VC_CRT_NAJOR_VERSION? Is it misprint or a hack? Google gives zero
results.
-- Andrey Khalyavin
On Thu, Feb 16, 2017 at 6:47 PM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Thu Feb 16 09:47:50 2017
> New Revision: 295330
>
> URL: htt
arphaman updated this revision to Diff 88764.
arphaman marked an inline comment as done.
arphaman added a comment.
The updated patch switches over to the opt-out approach, allows the C++11 style
syntax and improves documentation.
Repository:
rL LLVM
https://reviews.llvm.org/D30009
Files:
arphaman added inline comments.
Comment at: docs/LanguageExtensions.rst:2349
+attribute is supported by the pragma by referring to the
+:doc:`individual documentation for that attribute `.
arphaman wrote:
> efriedma wrote:
> > I'm wondering if we can tweak the ap
pirama updated this revision to Diff 88768.
pirama added a comment.
- Arch-subdir is now always added to -L
- It is added to -rpath during native compilation.
- Tests have been updated
https://reviews.llvm.org/D30015
Files:
include/clang/Driver/ToolChain.h
lib/Driver/ToolChain.cpp
lib/Dri
phosek updated this revision to Diff 88770.
Repository:
rL LLVM
https://reviews.llvm.org/D26654
Files:
cmake/caches/Fuchsia-stage2.cmake
cmake/caches/Fuchsia.cmake
Index: cmake/caches/Fuchsia.cmake
===
--- /dev/null
+++ cmake
pirama added inline comments.
Comment at: test/Driver/arch-specific-libdir-rpath.c:6
+// -rpath only gets added during native compilation
+// REQUIRES: native
+//
I feel this test is fragile. Any idea how to further restrict and require that
the default target
efriedma added inline comments.
Comment at: docs/LanguageExtensions.rst:2349
+attribute is supported by the pragma by referring to the
+:doc:`individual documentation for that attribute `.
arphaman wrote:
> arphaman wrote:
> > efriedma wrote:
> > > I'm wondering
arphaman added inline comments.
Comment at: docs/LanguageExtensions.rst:2349
+attribute is supported by the pragma by referring to the
+:doc:`individual documentation for that attribute `.
efriedma wrote:
> arphaman wrote:
> > arphaman wrote:
> > > efriedma wrote
arphaman added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D28670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Merged in r295375.
Thanks,
Hans
On Wed, Feb 15, 2017 at 12:14 PM, Richard Smith wrote:
> Hans, this would be a good candidate for Clang 4. The bug in question is not
> a regression, but it is an accepts-invalid / wrong-code bug.
>
> On 15 February 2017 at 11:57, Richard Smith via cfe-commits
>
aaron.ballman added inline comments.
Comment at: docs/LanguageExtensions.rst:2418
+In general, the attributes are applied to a declaration only when there would
+have been no error or warning for that attribute if it was specified
explicitly.
+An attribute is applied to each rel
rnk added inline comments.
Comment at: docs/LanguageExtensions.rst:2349
+attribute is supported by the pragma by referring to the
+:doc:`individual documentation for that attribute `.
arphaman wrote:
> efriedma wrote:
> > arphaman wrote:
> > > arphaman wrote:
> >
erichkeane added a comment.
Well hmm... changing this from MSVC to always caused a ton of regressions. I
no longer think that this is a proper patch as it sits. Additionally, it
doesn't fix the A::TYPE *var3 condition.
https://reviews.llvm.org/D29401
__
Author: rsmith
Date: Thu Feb 16 15:29:21 2017
New Revision: 295379
URL: http://llvm.org/viewvc/llvm-project?rev=295379&view=rev
Log:
Properly set up the DeclContext for parameters of implicit deduction guides;
this is needed for deferred instantiation of default arguments.
Modified:
cfe/trunk
Richard, can you take a look when you have a moment? The PR is marked
as a release blocker.
On Thu, Feb 9, 2017 at 1:54 PM, Duncan P. N. Exon Smith via
Phabricator via cfe-commits wrote:
> dexonsmith added a comment.
>
> I'm not comfortable signing off on this, but it seems like this should be se
arphaman added inline comments.
Comment at: include/clang/Basic/Attr.td:308-311
+ // - An attribute requires delayed parsing (LateParsed is on)
+ // - An attribute has no GNU/CXX11 spelling
+ // - An attribute has no subject list
+ // - An attribute derives from a StmtAttr or
rsmith added a comment.
It seems to me that the problem here is that `DeclMustBeEmitted` is not safe to
call in the middle of deserialization if anything partially-deserialized might
be reachable from the declaration we're querying, and yet we're currently
calling it in that case. I don't see h
mgorny added inline comments.
Comment at: test/Driver/arch-specific-libdir.c:6
+// RUN: -resource-dir=%S/Inputs/resource_dir_with_arch_subdir \
+// RUN: | FileCheck --check-prefix=CHECK-ARCHDIR %s
+//
Please be more specific in the tests, i.e. check if the
dblaikie updated this revision to Diff 88792.
dblaikie added a comment.
- Simplify ModuleFile lookup
https://reviews.llvm.org/D29901
Files:
include/clang/AST/ExternalASTSource.h
include/clang/Sema/MultiplexExternalSemaSource.h
include/clang/Serialization/ASTReader.h
lib/AST/ASTContext.c
EricWF updated this revision to Diff 88794.
EricWF retitled this revision from "Add `__is_direct_constructible` trait for
checking safe reference initialization." to "Add
`__reference_binds_to_temporary` trait for checking safe reference
initialization.".
EricWF edited the summary of this revisi
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:308-311
+ // - An attribute requires delayed parsing (LateParsed is on)
+ // - An attribute has no GNU/CXX11 spelling
+ // - An attribute has no subject list
+ // - An attribute derives from a StmtAt
EricWF updated this revision to Diff 88795.
EricWF added a comment.
Remove test code that snuck in.
https://reviews.llvm.org/D29930
Files:
docs/LanguageExtensions.rst
include/clang/Basic/TokenKinds.def
include/clang/Basic/TypeTraits.h
lib/Parse/ParseDeclCXX.cpp
lib/Parse/ParseExpr.cpp
1 - 100 of 157 matches
Mail list logo
