NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Oh well, that's not good. Probably that's because we always highlight the
current statement in path-sensitive reports. I guess we could improve upon that
in the bug reporter.
Repository:
rL LLVM
danielmarjamaki added a comment.
No the argument is not shown with tilde/column number.
Code example:
void f(int x, ...);
void dostuff() {
int x[10];
f(12,3,4,5,x[3],6,7,8);
}
Output:
C:\Users\danielm>\llvm\build\Debug\bin\clang -cc1 -analyze
-analyzer-checker=core test3.c
Hello everyone,
LLVM buildmaster will be restarted in few minutes.
Thank you for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak added a comment.
In https://reviews.llvm.org/D30662#693609, @andrew.w.kaylor wrote:
> In https://reviews.llvm.org/D30662#693559, @ahatanak wrote:
>
> > Is it possible to add a test case (possibly in CodeGen)?
>
>
> This is covered by CodeGen/ms-inline-asm.c, which Reid added after I brok
> On Mar 6, 2017, at 10:17 AM, Lobron, David wrote:
>
> Hi Akira,
>
> Pardon my slowness in addressing your question.
>
>> This patch changes the encoding of an id conforming to a protocol, which I
>> think was not intended: For example:
>>
>> @encode(id)
>>
>> Would passing IVD to the call
jroelofs added a comment.
I think this might miss loads from bitfield ivars. Also, what about the
conversion that happens for properties whose backing ivar is a bitfield? (or
does that happen in the runtime? can't remember)
Comment at: test/CodeGenObjC/ubsan-bool.m:25
+ // O
ddcc added a comment.
Thanks for your help! Let me know when the buildbot is ready for this to land.
https://reviews.llvm.org/D28952
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini added inline comments.
Comment at: test/libcxx/test/config.py:66
self.env = {}
self.use_target = False
self.use_system_cxx_lib = False
mehdi_amini wrote:
> EricWF wrote:
> > Was the omission of `self.use_deployment` here int
Hello everyone,
LLVM buildmaster will be updated and restarted in the nearest hour.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini added inline comments.
Comment at: test/libcxx/test/config.py:66
self.env = {}
self.use_target = False
self.use_system_cxx_lib = False
EricWF wrote:
> Was the omission of `self.use_deployment` here intentional? Python linter
mehdi_amini updated this revision to Diff 90779.
mehdi_amini added a comment.
Add back the python changes (files were moved, I lost them in the rebase)
https://reviews.llvm.org/D17469
Files:
test/std/localization/locale.categories/category.ctype/ctype_base.pass.cpp
test/std/localization/lo
Hello everyone,
Below are some buildbot numbers for the week of 02/19/2017 - 02/25/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
Hello everyone,
Below are some buildbot numbers for the last week of 02/26/2017 -
03/04/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
malaperle-ericsson updated this revision to Diff 90776.
https://reviews.llvm.org/D30476
Files:
clangd/clients/lsp4e-cpp/.gitignore
clangd/clients/lsp4e-cpp/.mvn/extensions.xml
clangd/clients/lsp4e-cpp/.travis.yml
clangd/clients/lsp4e-cpp/LICENSE
clangd/clients/lsp4e-cpp/README.md
clan
malaperle-ericsson added a comment.
Please disregard the last diff, I misused arc.
https://reviews.llvm.org/D30476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malaperle-ericsson updated this revision to Diff 90774.
malaperle-ericsson added a comment.
[clangd] Fix not being able to attach a debugger on macOS
Clangd is often waiting for input on getline as it awaits requests.
If the getline is interrupted, it causes the system call (read) to
fail and the
mehdi_amini updated this revision to Diff 90773.
mehdi_amini edited the summary of this revision.
mehdi_amini added a comment.
Rebase
https://reviews.llvm.org/D17469
Files:
test/std/localization/locale.categories/category.ctype/ctype_base.pass.cpp
test/std/localization/locale.categories/ca
vsk added a comment.
Thanks for the feedback!
Comment at: test/CodeGenCXX/ubsan-bitfields.cpp:21
+ // CHECK: call void @__ubsan_handle_load_invalid_value
+ return s->e1;
+}
arphaman wrote:
> Can we avoid the check if the bitfield is 2 bits wide?
I don't think
kmarshall added a comment.
It appears that the "suppress-c++-stdlib" option in
LikelyFalsePositiveSuppressionBRVisitor is yielding promising results. It
removes warnings from the "std" namespace which addresses both false positives
that I cited above.
Repository:
rL LLVM
https://reviews.ll
bruno added a comment.
Hi Alex,
Comment at: lib/Sema/SemaDeclObjC.cpp:4312
+ for (const ParmVarDecl *P : Method->parameters()) {
+if (P->getType()->isVectorType()) {
+ Loc = P->getLocStart();
Assuming objc/c++ can pass/return these, the current check
dcoughlin added a comment.
We add the suppression for libcxx issues in
LikelyFalsePositiveSuppressionBRVisitor in BugReporterVisitors.cpp. It is
ad-hoc pattern recognition of idioms we know cause false positives rather than
an explicit database.
Repository:
rL LLVM
https://reviews.llvm.org
kmarshall added a comment.
Also, it looks like some instances of safe unique_ptr assignment using
std::move() are tripping up the analyzer.
Error:
../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/unique_ptr.h:190:4:
warning: Pot
kmarshall added a comment.
That makes sense. In the cases that I'm finding, the original call site is in
application source code, but the warning is generated from inside a system
header. So, I suppose the suppressions are working as intended, and we just
need to add one-off suppressions for th
Author: ericwf
Date: Mon Mar 6 18:15:18 2017
New Revision: 297106
URL: http://llvm.org/viewvc/llvm-project?rev=297106&view=rev
Log:
Define LLVM_ENABLE_WARNINGS when building standalone clang to ensure warnings
get enabled
Modified:
cfe/trunk/CMakeLists.txt
Modified: cfe/trunk/CMakeLists.tx
Author: ericwf
Date: Mon Mar 6 18:01:13 2017
New Revision: 297105
URL: http://llvm.org/viewvc/llvm-project?rev=297105&view=rev
Log:
Fix unused variable in SemaCoroutine.cpp
Modified:
cfe/trunk/lib/Sema/SemaCoroutine.cpp
Modified: cfe/trunk/lib/Sema/SemaCoroutine.cpp
URL:
http://llvm.org/vi
Author: rnk
Date: Mon Mar 6 17:52:53 2017
New Revision: 297101
URL: http://llvm.org/viewvc/llvm-project?rev=297101&view=rev
Log:
Fix some widespread warnings in headers from the new coroutine code
Modified:
cfe/trunk/include/clang/AST/Stmt.h
cfe/trunk/include/clang/Sema/ScopeInfo.h
Modi
Author: rnk
Date: Mon Mar 6 17:49:18 2017
New Revision: 297099
URL: http://llvm.org/viewvc/llvm-project?rev=297099&view=rev
Log:
Relax stmtexpr.cpp checks for PPC64
Modified:
cfe/trunk/test/CodeGenCXX/stmtexpr.cpp
Modified: cfe/trunk/test/CodeGenCXX/stmtexpr.cpp
URL:
http://llvm.org/viewvc
Author: brad
Date: Mon Mar 6 17:48:31 2017
New Revision: 297098
URL: http://llvm.org/viewvc/llvm-project?rev=297098&view=rev
Log:
Set the Int64Type / IntMaxType types correctly for OpenBSD/mips64
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/test/Preprocessor/init.c
Modified: cfe/
brad added a comment.
Good to know about the reviewer.
I am not familiar with phabricator and was just trying something with the
addition of the subscriber.
I will keep the amount of context in mind for future diffs.
Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D30465
_
Author: ericwf
Date: Mon Mar 6 17:38:15 2017
New Revision: 297093
URL: http://llvm.org/viewvc/llvm-project?rev=297093&view=rev
Log:
[coroutines] Add DependentCoawaitExpr and fix re-building CoroutineBodyStmt.
Summary:
The changes contained in this patch are:
1. Defines a new AST node `CoawaitDe
rsmith added inline comments.
Comment at: lib/Sema/TreeTransform.h:6802
+ return getDerived().RebuildDependentCoawaitExpr(
+ E->getKeywordLoc(), Result.get(), E->getOperatorCoawaitLookup());
+}
EricWF wrote:
> rsmith wrote:
> > You need to transform the Unr
EricWF added inline comments.
Comment at: include/clang/Sema/ScopeInfo.h:138-140
+ /// \brief Whether this function has already built, or tried to build, the
+ /// the initial and final coroutine suspend points.
+ bool NeedsCoroutineSuspends : 1;
rsmith wrote:
EricWF updated this revision to Diff 90752.
EricWF marked an inline comment as done.
EricWF added a comment.
- Address @rsmith's final review comments.
https://reviews.llvm.org/D26057
Files:
include/clang/AST/ExprCXX.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/AST/Stmt.h
inc
bruno added a comment.
Hi,
Thanks for working on this. Few questions:
- What happens with the validation if +soft-float is used?
- What about the 'e' mode, can you double check if the sparc backend support
these instructions? If so it might be interesting to add it here.
Also, please attach pa
On 6 March 2017 at 14:18, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Mon Mar 6 16:18:34 2017
> New Revision: 297084
>
> URL: http://llvm.org/viewvc/llvm-project?rev=297084&view=rev
> Log:
> Don't assume cleanup emission preserves dominance in expr eva
Author: ericwf
Date: Mon Mar 6 16:52:28 2017
New Revision: 297089
URL: http://llvm.org/viewvc/llvm-project?rev=297089&view=rev
Log:
[coroutines] Improve diagnostics when building implicit constructs.
Previously when a coroutine was building the implicit setup/destroy
constructs it would emit dia
alexshap added inline comments.
Comment at: lib/Basic/SourceManager.cpp:843
if (E.getOffset() <= SLocOffset) {
FileID Res = FileID::get(-int(I) - 2);
not particularly important (and unrelated to your changes) - nit - s /C-style
cast / static_cast /
bruno added a comment.
Hi Daniel,
This seems pretty nice. Can you share how much performance improvements you got
by this / how did you test it?
https://reviews.llvm.org/D28218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: rnk
Date: Mon Mar 6 16:18:34 2017
New Revision: 297084
URL: http://llvm.org/viewvc/llvm-project?rev=297084&view=rev
Log:
Don't assume cleanup emission preserves dominance in expr evaluation
Summary:
Because of the existence branches out of GNU statement expressions, it
is possible that e
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297084: Don't assume cleanup emission preserves dominance in
expr evaluation (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D30590?vs=90743&id=90747#toc
Repository:
rL LLVM
htt
rnk added a comment.
I think we should really change this code to filter out clobber registers that
do not name valid gcc inline asm clobbers. That's basically what we require
later. I think if you change this condition to just check
Target.isValidGCCRegisterName.
Repository:
rL LLVM
https
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: include/clang/Sema/ScopeInfo.h:138-140
+ /// \brief Whether this function has already built, or tried to build, the
+ /// the initial and final coroutine su
bruno added a comment.
Hey, really sorry for the delay here.
Comment at: lib/Sema/SemaExpr.cpp:8007
+static bool canConvertIntToOtherIntTy(Sema &S, ExprResult *Int,
+ QualType OtherIntTy) {
+ QualType IntTy = Int->get()->getType().getU
rnk updated this revision to Diff 90743.
rnk added a comment.
- comments
https://reviews.llvm.org/D30590
Files:
lib/CodeGen/CGCleanup.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CGExprComplex.cpp
lib/CodeGen/CGExprScalar.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGenCXX/stmtexpr.cpp
Ind
rnk added inline comments.
Comment at: lib/CodeGen/CGExprComplex.cpp:204-206
+Scope.ensureDominatingValue(&Vals.first);
+Scope.ensureDominatingValue(&Vals.second);
+Scope.ForceCleanup();
rsmith wrote:
> I'm a little concerned about the loose connectio
alexfh added a comment.
In https://reviews.llvm.org/D30650#693165, @Eugene.Zelenko wrote:
> I think we should refactor this check as part of Static Analyzer, since it's
> path-sensitive.
We can think about trying this as a SA checker, but it's irrelevant to this
patch.
https://reviews.llvm.
andrew.w.kaylor added a comment.
In https://reviews.llvm.org/D30662#693559, @ahatanak wrote:
> Is it possible to add a test case (possibly in CodeGen)?
This is covered by CodeGen/ms-inline-asm.c, which Reid added after I broke this
adding the mxcsr register a couple of weeks ago.
Repository:
Author: ericwf
Date: Mon Mar 6 15:23:36 2017
New Revision: 297079
URL: http://llvm.org/viewvc/llvm-project?rev=297079&view=rev
Log:
Add list of filesystem NB comments to TODO.TXT so they can be tracked separately
Modified:
libcxx/trunk/TODO.TXT
Modified: libcxx/trunk/TODO.TXT
URL:
http://l
Author: gornishanov
Date: Mon Mar 6 15:12:54 2017
New Revision: 297076
URL: http://llvm.org/viewvc/llvm-project?rev=297076&view=rev
Log:
[coroutines] Add co_return statement emission
Summary:
Added co_return statement emission.
Tweaked coro-alloc.cpp test to use co_return to trigger coroutine p
Author: ericwf
Date: Mon Mar 6 15:09:02 2017
New Revision: 297074
URL: http://llvm.org/viewvc/llvm-project?rev=297074&view=rev
Log:
Mark LWG 2806 as complete. Libc++ speculatively shiped this change in 4.0
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.
Author: ericwf
Date: Mon Mar 6 15:07:18 2017
New Revision: 297073
URL: http://llvm.org/viewvc/llvm-project?rev=297073&view=rev
Log:
Mark LWG 2789 as complete. No changes required
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/
Author: ericwf
Date: Mon Mar 6 15:02:06 2017
New Revision: 297071
URL: http://llvm.org/viewvc/llvm-project?rev=297071&view=rev
Log:
Implement LWG 2787 - [file_status.cons] is inconsistent
Modified:
libcxx/trunk/include/experimental/filesystem
libcxx/trunk/test/std/experimental/filesyste
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Hal and I discussed exactly the same problem (in the context of coroutines) on
Saturday and came up with exactly the same approach :) I think this is the
right direction.
C
Author: ericwf
Date: Mon Mar 6 14:56:13 2017
New Revision: 297069
URL: http://llvm.org/viewvc/llvm-project?rev=297069&view=rev
Log:
Mark LWG 2781 as complete. No changes required
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/
Author: ericwf
Date: Mon Mar 6 14:49:42 2017
New Revision: 297066
URL: http://llvm.org/viewvc/llvm-project?rev=297066&view=rev
Log:
Mark two any_cast issues as complete
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/viewvc/llv
Author: mpark
Date: Mon Mar 6 14:46:55 2017
New Revision: 297065
URL: http://llvm.org/viewvc/llvm-project?rev=297065&view=rev
Log:
Updated email address in `CREDITS.txt`.
Modified:
libcxx/trunk/CREDITS.TXT
Modified: libcxx/trunk/CREDITS.TXT
URL:
http://llvm.org/viewvc/llvm-project/libcxx/t
sbarzowski added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.h:20
+///\brief Warns about using throw in function declared as noexcept.
+/// It complains about every throw, even if it is caught later.
+class ThrowWithNoexceptCheck : public ClangTidyCheck {
vmiklos added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.h:20
+///\brief Warns about using throw in function declared as noexcept.
+/// It complains about every throw, even if it is caught later.
+class ThrowWithNoexceptCheck : public ClangTidyCheck {
---
Gosh, I missed the reserve() call. Sorry! I'll be happy to implement this
change.
Sean
> On Mar 6, 2017, at 10:05 AM, Sean Callanan wrote:
>
> Aleksei,
>
> thank you for your comments!
>
> I appreciate your comments in particular about source/destination confusion.
> I can relate to this
ahatanak added a comment.
Is it possible to add a test case (possibly in CodeGen)?
Repository:
rL LLVM
https://reviews.llvm.org/D30662
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
twoh updated this revision to Diff 90735.
twoh added a comment.
Herald added a subscriber: mehdi_amini.
addressing comments from @inglorion
https://reviews.llvm.org/D30663
Files:
include/clang/Frontend/FrontendOptions.h
lib/Frontend/FrontendAction.cpp
test/Frontend/preprocessed-input.i
I
jyknight added a comment.
Ping
https://reviews.llvm.org/D30427
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GorNishanov commandeered this revision.
GorNishanov edited reviewers, added: EricWF; removed: GorNishanov.
GorNishanov added a comment.
Comandeering this patch.
Last week Richard gave me some feedback in person on this code (in the full
coroutine implementation not this patch in particular). I am
Author: rnk
Date: Mon Mar 6 13:43:16 2017
New Revision: 297057
URL: http://llvm.org/viewvc/llvm-project?rev=297057&view=rev
Log:
[MS] Add support for __ud2 and __int2c MSVC intrinsics
This was requested in PR31958 and elsewhere.
Modified:
cfe/trunk/include/clang/Basic/BuiltinsX86.def
cf
twoh added inline comments.
Comment at: test/Frontend/preprocessed-input.c:3
+// RUN: %clang -emit-llvm -S -o - %t.i | FileCheck %s
+// CHECK: source_filename = {{.*}}preprocessed-input.c"{{$}}
inglorion wrote:
> Actually, I think you don't even have to run the p
Hi Akira,
Pardon my slowness in addressing your question.
> This patch changes the encoding of an id conforming to a protocol, which I
> think was not intended: For example:
>
> @encode(id)
>
> Would passing IVD to the call to getObjCEncodingForType in
> CGObjCGNU::GenerateClass solve the pro
Author: rjmccall
Date: Mon Mar 6 13:04:16 2017
New Revision: 297050
URL: http://llvm.org/viewvc/llvm-project?rev=297050&view=rev
Log:
Further fixes and improvements to the ConstantInitBuilder API.
Added:
cfe/trunk/include/clang/CodeGen/ConstantInitFuture.h
Modified:
cfe/trunk/include/cla
dexonsmith added a subscriber: mehdi_amini.
dexonsmith added a comment.
Mehdi, are you interested in rebasing this?
https://reviews.llvm.org/D17469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
inglorion added inline comments.
Comment at: test/Frontend/preprocessed-input.c:3
+// RUN: %clang -emit-llvm -S -o - %t.i | FileCheck %s
+// CHECK: source_filename = {{.*}}preprocessed-input.c"{{$}}
Actually, I think you don't even have to run the preprocessor -
On Mon, Mar 6, 2017 at 7:00 PM, Pirama Arumuga Nainar wrote:
> Adding Reid, Michal
>
>
> On Mon, Mar 6, 2017 at 5:01 AM, Benjamin Kramer wrote:
>>
>> On Sat, Mar 4, 2017 at 12:20 AM, Pirama Arumuga Nainar via cfe-commits
>> wrote:
>> > Author: pirama
>> > Date: Fri Mar 3 17:20:49 2017
>> > New
zaks.anna requested changes to this revision.
zaks.anna added a comment.
This revision now requires changes to proceed.
Following Gabor's suggestion, we should investigate if ArrayBoundCheckerV2
supports this. If not it's possible that we are hitting the Constraint Solver
limitations.
Reposito
Aleksei,
thank you for your comments!
I appreciate your comments in particular about source/destination confusion. I
can relate to this, as this was (a) an area that confused me while I was
working on this code in LLDB; and (b) it was something I had to keep straight
in my head even when doin
twoh created this revision.
This is a revised version of https://reviews.llvm.org/D28796. Included test is
changed to
resolve the target compatibility issue reported
(https://reviews.llvm.org/rL293032).
https://reviews.llvm.org/D30663
Files:
include/clang/Frontend/FrontendOptions.h
lib/Fr
Adding Reid, Michal
On Mon, Mar 6, 2017 at 5:01 AM, Benjamin Kramer wrote:
> On Sat, Mar 4, 2017 at 12:20 AM, Pirama Arumuga Nainar via cfe-commits
> wrote:
> > Author: pirama
> > Date: Fri Mar 3 17:20:49 2017
> > New Revision: 296927
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=29692
zaks.anna added a comment.
This is waiting for a resolution on a CallEvent API patch as described in
https://reviews.llvm.org/D27091.
This is blocked on https://reviews.llvm.org/D27091.
Comment at: lib/StaticAnalyzer/Checkers/RecursionChecker.cpp:29
+// this patch.
+REGISTER_
Author: vvassilev
Date: Mon Mar 6 11:47:57 2017
New Revision: 297037
URL: http://llvm.org/viewvc/llvm-project?rev=297037&view=rev
Log:
[modules] Add missing test from r297030.
Added:
cfe/trunk/test/Modules/Inputs/gnumode-non-benign/
cfe/trunk/test/Modules/Inputs/gnumode-non-benign/module
On Mon, Mar 6, 2017 at 6:29 PM, Krasimir Georgiev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: krasimir
> Date: Mon Mar 6 11:29:25 2017
> New Revision: 297034
>
> URL: http://llvm.org/viewvc/llvm-project?rev=297034&view=rev
> Log:
> [clang-format] Add tests for ambiguous namespa
a.sidorin added a comment.
Hello Sean,
It is good to have the ability of recursive lookup. But for me (and I'm sorry),
the code becomes very hard to understand: I need to track if the Decl/DC is in
the source AST or in the AST being imported, if it was imported or if was in
the AST before acro
andrew.w.kaylor created this revision.
This patch updates the clang function that filters the mxcsr register name to
recognize that mxcsr is being split into two pseduo-registers that model the
control and status bits separately.
Repository:
rL LLVM
https://reviews.llvm.org/D30662
Files:
Author: krasimir
Date: Mon Mar 6 11:29:25 2017
New Revision: 297034
URL: http://llvm.org/viewvc/llvm-project?rev=297034&view=rev
Log:
[clang-format] Add tests for ambiguous namespaces to the comment fixer
Modified:
cfe/trunk/unittests/Format/NamespaceEndCommentsFixerTest.cpp
Modified: cfe/t
arphaman added inline comments.
Comment at: test/CodeGenCXX/ubsan-bitfields.cpp:21
+ // CHECK: call void @__ubsan_handle_load_invalid_value
+ return s->e1;
+}
Can we avoid the check if the bitfield is 2 bits wide?
Comment at: test/CodeGenObjC
sepavloff added a comment.
Ping.
https://reviews.llvm.org/D26065
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vvassilev
Date: Mon Mar 6 10:54:40 2017
New Revision: 297030
URL: http://llvm.org/viewvc/llvm-project?rev=297030&view=rev
Log:
[modules] Make GNUMode a normal language option to fix module compilation.
GNUMode shouldn't be a benign language option because it influences the
resulting AST
Author: krasimir
Date: Mon Mar 6 10:44:45 2017
New Revision: 297028
URL: http://llvm.org/viewvc/llvm-project?rev=297028&view=rev
Log:
[clang-format] Make NamespaceEndCommentFixer add at most one comment
Summary:
Until now, NamespaceEndCommentFixer was adding missing comments for every run,
which
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297028: [clang-format] Make NamespaceEndCommentFixer add at
most one comment (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D30659?vs=90715&id=90716#toc
Repository:
rL LLVM
krasimir updated this revision to Diff 90715.
krasimir added a comment.
- Added missing newline
https://reviews.llvm.org/D30659
Files:
lib/Format/NamespaceEndCommentsFixer.cpp
unittests/Format/NamespaceEndCommentsFixerTest.cpp
Index: unittests/Format/NamespaceEndCommentsFixerTest.cpp
Author: arphaman
Date: Mon Mar 6 10:37:06 2017
New Revision: 297027
URL: http://llvm.org/viewvc/llvm-project?rev=297027&view=rev
Log:
[Docs] Add missing quotes to the language literal in the
external_source_symbol attribute docs
Modified:
cfe/trunk/include/clang/Basic/AttrDocs.td
Modified:
Author: sylvestre
Date: Mon Mar 6 10:35:28 2017
New Revision: 297025
URL: http://llvm.org/viewvc/llvm-project?rev=297025&view=rev
Log:
Add examples to clang-format configuration
Reviewers: klimek, djasper
Reviewed By: djasper
Subscribers: krasimir, kimgr, cfe-commits
Differential Revision: ht
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Would probably be interesting to add these test cases:
#if A
namespace A {
#else
namespace B {
#endif
int i;
int j;
}//namespace A
and:
namespace A {
int i;
int j;
#
krasimir created this revision.
Herald added a subscriber: klimek.
Until now, NamespaceEndCommentFixer was adding missing comments for every run,
which results in multiple end comments for:
namespace {
int i;
int j;
}
#if A
int a = 1;
#else
int a = 2;
#endif
result befo
hokein added inline comments.
Comment at:
clang-tools-extra/trunk/test/clang-tidy/modernize-use-nullptr.cpp:254
+
+ void h(T *default_value = 0) {}
+
alexfh wrote:
> xazax.hun wrote:
> > Maybe as a separate patch, but I think it might be worth to warn here.
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297023: [CodeGen][Blocks] Refactor capture handling in code
that generates (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D30345?vs=90197&id=90712#toc
Repository:
rL LLVM
Author: arphaman
Date: Mon Mar 6 10:23:04 2017
New Revision: 297023
URL: http://llvm.org/viewvc/llvm-project?rev=297023&view=rev
Log:
[CodeGen][Blocks] Refactor capture handling in code that generates
block copy/destroy routines
This is a preparation commit for work on merging unique block copy/
alexfh added inline comments.
Comment at:
clang-tools-extra/trunk/test/clang-tidy/modernize-use-nullptr.cpp:254
+
+ void h(T *default_value = 0) {}
+
xazax.hun wrote:
> Maybe as a separate patch, but I think it might be worth to warn here. WDYT?
> (Sorry for t
Author: marshall
Date: Mon Mar 6 10:09:02 2017
New Revision: 297022
URL: http://llvm.org/viewvc/llvm-project?rev=297022&view=rev
Log:
Header update with info about the current status of C++17
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
htt
Author: arphaman
Date: Mon Mar 6 09:58:34 2017
New Revision: 297019
URL: http://llvm.org/viewvc/llvm-project?rev=297019&view=rev
Log:
[Sema][ObjC] Warn about 'performSelector' calls with selectors
that return record or vector types
The performSelector family of methods from Foundation use objc_m
Author: marshall
Date: Mon Mar 6 10:06:02 2017
New Revision: 297021
URL: http://llvm.org/viewvc/llvm-project?rev=297021&view=rev
Log:
Update list with changes from Kona meeting
Modified:
libcxx/trunk/www/cxx1z_status.html
Modified: libcxx/trunk/www/cxx1z_status.html
URL:
http://llvm.org/vi
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you for doing this!
https://reviews.llvm.org/D30532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297019: [Sema][ObjC] Warn about 'performSelector' calls with
selectors (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D30174?vs=90473&id=90709#toc
Repository:
rL LLVM
http
Eugene.Zelenko added a comment.
I think we should refactor this check as part of Static Analyzer, since it's
path-sensitive.
https://reviews.llvm.org/D30650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
1 - 100 of 133 matches
Mail list logo
