EricWF created this revision.
Herald added a subscriber: mehdi_amini.
Some coroutine diagnostics need to point to the location of the first coroutine
keyword in the function, like when diagnosing a `return` inside a coroutine.
Previously we did this by storing each *valid* coroutine statement in
Author: ed
Date: Thu Mar 9 02:04:07 2017
New Revision: 297364
URL: http://llvm.org/viewvc/llvm-project?rev=297364&view=rev
Log:
Fix up the places where AddressSpace.hpp is included.
The AddressSpace.hpp header declares two classes: LocalAddressSpace and
RemoteAddressSpace. These classes are only
kimgr added a comment.
Some nits from a Python3 hacker.
Comment at: tools/clang-format/git-clang-format:143
for filename in ignored_files:
-print ' ', filename
+print(' ', filename)
if changed_lines:
I find `print('template', tai
EricWF marked 4 inline comments as done.
EricWF added inline comments.
Comment at: tools/clang-format/git-clang-format:323
allowed_extensions = frozenset(allowed_extensions)
- for filename in dictionary.keys():
+ for filename in list(dictionary.keys()):
base_ext = filen
EricWF marked 2 inline comments as done.
EricWF added inline comments.
Comment at: tools/clang-format/git-clang-format:323
allowed_extensions = frozenset(allowed_extensions)
- for filename in dictionary.keys():
+ for filename in list(dictionary.keys()):
base_ext = filen
kimgr added inline comments.
Comment at: tools/clang-format/git-clang-format:323
allowed_extensions = frozenset(allowed_extensions)
- for filename in dictionary.keys():
+ for filename in list(dictionary.keys()):
base_ext = filename.rsplit('.', 1)
EricWF
leanil updated this revision to Diff 91144.
leanil added a comment.
Fix enable_if detection in pointer and reference types.
Improve test coverage for these cases.
Repository:
rL LLVM
https://reviews.llvm.org/D30547
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/ForwardingReference
Author: hokein
Date: Thu Mar 9 03:15:16 2017
New Revision: 297367
URL: http://llvm.org/viewvc/llvm-project?rev=297367&view=rev
Log:
[clang-tidy] Update the doc according to r297311.
Modified:
clang-tools-extra/trunk/docs/clang-tidy/checks/readability-function-size.rst
Modified:
clang-tools
EricWF updated this revision to Diff 91145.
EricWF added a comment.
This still isn't working in python3 due to more bytes vs str issues, but this
is my progress so far.
https://reviews.llvm.org/D30773
Files:
tools/clang-format/git-clang-format
Index: tools/clang-format/git-clang-format
leanil marked 3 inline comments as done.
leanil added inline comments.
Comment at: clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp:31
+ ->getName()
+ .find("enable_if") != StringRef::npos;
+ };
aaron.ballman wrote:
> This should
Thank you! Completely forgot about this.
On Thu, Mar 9, 2017 at 10:15 AM, Haojian Wu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: hokein
> Date: Thu Mar 9 03:15:16 2017
> New Revision: 297367
>
> URL: http://llvm.org/viewvc/llvm-project?rev=297367&view=rev
> Log:
> [clang-tidy]
sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.
LGTM. Minor nit: there's some spurious whitespace that can be removed, see my
inlined comment.
Comment at: test/CodeGen/builtins-mips-msa.c:701
v2i64_r = __msa_sld_d(v2
curdeius added a comment.
Hi Alex and sorry for the late reply.
The main use case is a more readable `.clang-tidy` configuration checks.
Before this correction one can use something like this:
---
Checks: '
,*,
,-cert-dcl03-c,
'
...
It works, but is hardly comprehensible to
echuraev added a comment.
In https://reviews.llvm.org/D27334#614826, @Anastasia wrote:
> In https://reviews.llvm.org/D27334#614389, @bader wrote:
>
> > In https://reviews.llvm.org/D27334#613504, @Anastasia wrote:
> >
> > > In https://reviews.llvm.org/D27334#612858, @bader wrote:
> > >
> > > > In
Author: sammccall
Date: Thu Mar 9 04:47:44 2017
New Revision: 297371
URL: http://llvm.org/viewvc/llvm-project?rev=297371&view=rev
Log:
[include-fixer] Remove line number from Symbol identity
Summary:
Remove line number from Symbol identity.
For our purposes (include-fixer and clangd autocomplet
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297371: [include-fixer] Remove line number from Symbol
identity (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D30685?vs=90990&id=91149#toc
Repository:
rL LLVM
https://re
ioeric created this revision.
... which applies a set of `AtomicChange`s on code.
https://reviews.llvm.org/D30777
Files:
include/clang/Tooling/Refactoring/AtomicChange.h
lib/Tooling/Refactoring/AtomicChange.cpp
unittests/Tooling/RefactoringTest.cpp
Index: unittests/Tooling/RefactoringTes
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Lex/Lexer.cpp:457
+static bool isNewLineEscaped(const char *BufferStart, const char *Str) {
+ while (Str > BufferStart && isWhitespace(*Str))
+
klimek added inline comments.
Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:129
+struct ApplyChangesSpec {
+ // If true, cleans up redundant/erroneous around changed code with
+ // clang-format's cleanup functionality, e.g. redundant commas around deleted
---
smaksimovic updated this revision to Diff 91158.
smaksimovic added a comment.
Removed whitespace.
https://reviews.llvm.org/D30693
Files:
lib/Sema/SemaChecking.cpp
test/CodeGen/builtins-mips-msa-error.c
test/CodeGen/builtins-mips-msa.c
Index: test/CodeGen/builtins-mips-msa.c
ioeric updated this revision to Diff 91163.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Addressed comments; stylized code.
https://reviews.llvm.org/D30777
Files:
include/clang/Tooling/Refactoring/AtomicChange.h
lib/Tooling/Refactoring/AtomicChange.cpp
unittests/Tool
ioeric added inline comments.
Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:147-149
+/// This completely ignores the file path in each change and replaces them with
+/// \p FilePath, i.e. callers are responsible for ensuring all changes are for
+/// the same file.
Abpostelnicu added a comment.
Daniel what do you think about the last version of the patch? I don't want to
have this stalled since we really need this modifications in order to be able
to run clang-format on our repository.
Repository:
rL LLVM
https://reviews.llvm.org/D30487
___
madsravn added a comment.
Any updates on this?
https://reviews.llvm.org/D30158
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D30776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
jroelofs added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1911
+if (auto Nullability = Ty->getNullability(getContext())) {
+ if (Nullability && *Nullability == NullabilityKind::NonNull) {
+SanitizerScope SanScope(this);
aprantl wrote:
>
djasper added a comment.
I think the patch is fine, except for the name of the flag. It is not breaking
inheritance ;).
Maybe BreakBeforeInhertianceColonAndComma, but that's pretty long still. I
think maybe we can shorten this to BreakBeforeInhertianceComma, as it never
makes sense to break be
mgorny added inline comments.
Comment at: tools/clang-format/git-clang-format:293
+def to_bytes(str):
+# Encode to UTF-8 to get binary data.
Pretty much a nit but using variable names that match type names can be a bit
confusing here.
Co
Abpostelnicu updated this revision to Diff 91174.
Abpostelnicu added a comment.
Yes that's a better name :)
Repository:
rL LLVM
https://reviews.llvm.org/D30487
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.
Author: vedantk
Date: Thu Mar 9 10:06:27 2017
New Revision: 297389
URL: http://llvm.org/viewvc/llvm-project?rev=297389&view=rev
Log:
Retry: [ubsan] Detect UB loads from bitfields
It's possible to load out-of-range values from bitfields backed by a
boolean or an enum. Check for UB loads from bitf
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
A few nits, otherwise looks good.
Comment at: include/clang/Format/Format.h:426
+ /// \brief If ``true``, in the class inheritance expression clang-format will
+ /// brea
Consider landing the obvious bits (print function, mostly) separately and
use this only for the interesting bits.
On Thu, Mar 9, 2017 at 11:10 AM, Michał Górny via Phabricator via
cfe-commits wrote:
> mgorny added inline comments.
>
>
>
> Comment at: tools/clang-format/git-clang
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8263
+def err_atomic_init_addressspace : Error<
+ "initialization of atomic variables is restricted to variables in global
address space">;
def err_atomic_init_constant : Error<
---
kimgr added a comment.
Oops, the flag is called `BreakBeforeInhertianceComma` with a misspelling
throughout. May want to search for `inhertiance` throughout and see if there
are more cases.
Comment at: docs/ClangFormatStyleOptions.rst:531
+**BreakBeforeInhertianceComma** (`
hiraditya added a comment.
ping
https://reviews.llvm.org/D30268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk marked 8 inline comments as done.
vsk added a comment.
Thanks for your comments, and sorry for jumping the gun earlier with an updated
diff. I'll attach a fixed-up diff shortly.
Comment at: lib/CodeGen/CGDecl.cpp:1911
+if (auto Nullability = Ty->getNullability(getConte
vsk updated this revision to Diff 91180.
vsk added a comment.
- Add a test for the mixed _Nonnull arg + __attribute__((nonnull)) arg case.
- Reword docs per Adrian's comments, fix up doxygen comments, add better code
comments, drop redundant "Nullability" truthiness checks.
https://reviews.llvm
zaks.anna added inline comments.
Comment at: docs/UndefinedBehaviorSanitizer.rst:101
+ ``-fsanitize=nullability-assign``, and the argument check with
+ ``-fsanitize=nullability-arg``. While violating nullability rules does
+ not result in undefined behavior, it is oft
fgross updated this revision to Diff 91183.
fgross added a comment.
Added examples to options doc.
https://reviews.llvm.org/D30610
Files:
clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp
clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.h
docs/clang-tidy/checks/cppcoreg
fgross updated this revision to Diff 91188.
fgross added a comment.
Diff was missing cppcoreguidelines-special-member-functions-relaxed.cpp...
https://reviews.llvm.org/D30610
Files:
clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp
clang-tidy/cppcoreguidelines/SpecialMemberFuncti
filcab added a comment.
Please make the tests tighter using `CHECK-NEXT` when possible. Much easier if
later anyone needs to debug differences in IR.
Comment at: docs/UndefinedBehaviorSanitizer.rst:102
+ violating nullability rules does not result in undefined behavior, it
Author: kzhuravl
Date: Thu Mar 9 12:06:23 2017
New Revision: 297397
URL: http://llvm.org/viewvc/llvm-project?rev=297397&view=rev
Log:
[DebugInfo] Append extended dereferencing mechanism to variables' DIExpression
for targets that support more than one address space
Differential Revision: https:
manmanren added a comment.
Please update the patch with context:
http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
Thanks,
Manman
Comment at: unittests/Basic/SourceManagerTest.cpp:251
std::string Name;
- bool isDefinition; // if false, it is
dblaikie updated this revision to Diff 91193.
dblaikie added a comment.
sync/resolve
https://reviews.llvm.org/D29901
Files:
include/clang/AST/ASTContext.h
include/clang/AST/ExternalASTSource.h
include/clang/Sema/MultiplexExternalSemaSource.h
include/clang/Serialization/ASTReader.h
lib
dblaikie added a comment.
Ping
I've got a relatively small patch to add support for debug info types after
this one & working on a patch on top of that to enable one/the other/both of
these (to test their value independently/together). Might be more expedient to
sit down & push through them al
djasper added inline comments.
Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:139
+ // kNone: Don't format anything.
+ // kViolations: Format lines exceeding 80 columns.
+ enum FormatOption { kAll, kNone, kViolations };
Should probably be "exceed
kzhuravl added a comment.
Once you rebase, can you also update AMDGPUTargetInfo::getDWARFAddressSpace to
use AddrSpaceKind?
https://reviews.llvm.org/D27627
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
bettinson updated this revision to Diff 91204.
bettinson added a comment.
Updated the test name. Sorry for the delay!
https://reviews.llvm.org/D26800
Files:
include/clang/Basic/Attr.td
test/Sema/nonnull.c
Index: test/Sema/nonnull.c
=
bruno added a comment.
Hi Juergen,
Thanks for working on this.
Comment at: include/clang/Basic/VirtualFileSystem.h:164
EC = Impl->increment();
-if (EC || !Impl->CurrentEntry.isStatusKnown())
+if (!Impl->CurrentEntry.isStatusKnown())
Impl.reset(); // Normali
Hi Akira,
> My concern is that the patch changes the encoding of @encode(id) on
> Darwin, which I think isn’t what you are trying to fix. If you compile the
> following code with command “clang -cc1 -triple x86_64-apple-macosx”, the
> type encoding changes after applying the patch.
>
> const c
Hi David,
The patch looks good to me.
> On Mar 9, 2017, at 1:01 PM, Lobron, David wrote:
>
> Hi Akira,
>
>> My concern is that the patch changes the encoding of @encode(id)
>> on Darwin, which I think isn’t what you are trying to fix. If you compile
>> the following code with command “clang
bruno added a comment.
Please attach a testcase!
https://reviews.llvm.org/D27810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Thu Mar 9 16:00:01 2017
New Revision: 297412
URL: http://llvm.org/viewvc/llvm-project?rev=297412&view=rev
Log:
Add -cc1 flag -ast-dump-all to perform an AST dump including entities that
haven't yet been deserialized.
Modified:
cfe/trunk/include/clang/AST/DeclBase.h
tejohnson added a comment.
Great, thanks. One question below and a format nit.
Comment at: lib/CodeGen/CodeGenAction.cpp:177
+if (LM.Internalize) {
+ Err = Linker::linkModules(
+ *getModule(), std::move(LM.Module), LM.LinkFlags,
Need
ributzka added inline comments.
Comment at: lib/Basic/VirtualFileSystem.cpp:1873
vfs::directory_iterator I = FS->dir_begin(State->top()->getName(), EC);
-if (EC)
+if (EC && EC != std::errc::no_such_file_or_directory)
return *this;
bruno wrote:
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM with the format fix I pointed out.
Comment at: lib/CodeGen/CodeGenAction.cpp:186
+} else {
+ Err = Linker::linkModules(*getModule(), std::move(LM.
kmarshall added a comment.
OK. I'll make bugs for the false positives I'm confident about.
Repository:
rL LLVM
https://reviews.llvm.org/D30593
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
pirama added inline comments.
Comment at: lib/Driver/ToolChain.cpp:652
+// libc++ may be installed per arch.
+addArchSpecificRPath(*this, Args, CmdArgs);
break;
`addArchSpecificRPath` is a static function in Tools.cpp and isn't visible here.
https:
zaks.anna created this revision.
We have several reports of false positives coming from libc++. For example,
there are reports of false positives in std::regex, std::wcout, and also a
bunch of issues are reported in https://reviews.llvm.org/D30593. In many cases,
the analyzer trips over the com
ributzka added inline comments.
Comment at: include/clang/Basic/VirtualFileSystem.h:164
EC = Impl->increment();
-if (EC || !Impl->CurrentEntry.isStatusKnown())
+if (!Impl->CurrentEntry.isStatusKnown())
Impl.reset(); // Normalize the end iterator to Impl == nul
zaks.anna added a comment.
@kmarshall,
We are going to turn this off by default, see https://reviews.llvm.org/D30798.
Please, do file a bug that lists all the issues you are seeing and desirably
instructions on how to reproduce. (Please, list even the cases you are not 100%
sure are false posi
jroelofs requested changes to this revision.
jroelofs added a comment.
This revision now requires changes to proceed.
As I said on https://reviews.llvm.org/D30214, it is inappropriate to be
installing libc++ in the resource directory... please **do not** do that.
https://reviews.llvm.org/D30733
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM,
https://reviews.llvm.org/D30798
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297429: [analyzer] Turn suppress-c++-stdlib on by default
(authored by zaks).
Changed prior to commit:
https://reviews.llvm.org/D30798?vs=91236&id=91238#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: zaks
Date: Thu Mar 9 18:33:19 2017
New Revision: 297429
URL: http://llvm.org/viewvc/llvm-project?rev=297429&view=rev
Log:
[analyzer] Turn suppress-c++-stdlib on by default
We have several reports of false positives coming from libc++. For example,
there are reports of false positives in
zaks.anna added a comment.
I've committed the change, but would very much appreciate community feedback
here if if there is any!
Repository:
rL LLVM
https://reviews.llvm.org/D30798
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
Author: yaxunl
Date: Thu Mar 9 19:30:46 2017
New Revision: 297436
URL: http://llvm.org/viewvc/llvm-project?rev=297436&view=rev
Log:
[AMDGPU] Add builtin functions readlane ds_permute mov_dpp
Differential Revision: https://reviews.llvm.org/D30551
Modified:
cfe/trunk/include/clang/Basic/Built
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297436: [AMDGPU] Add builtin functions readlane ds_permute
mov_dpp (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D30551?vs=90520&id=91243#toc
Repository:
rL LLVM
https://re
hfinkel added a comment.
In https://reviews.llvm.org/D12689#515120, @eastig wrote:
> The issue is reported as:
> https://llvm.org/bugs/show_bug.cgi?id=28954
We do need to fix this bug; I posted to the PR so we can discuss approach there.
https://reviews.llvm.org/D12689
___
malaperle-ericsson updated this revision to Diff 91246.
malaperle-ericsson added a comment.
Remove ifdexf
https://reviews.llvm.org/D30675
Files:
clangd/ClangDMain.cpp
Index: clangd/ClangDMain.cpp
===
--- clangd/ClangDMain.cpp
+
vsk added a comment.
One question for Anna (inline). I will update the diff with the
documentation/code comments/renaming fixes once I hear back. Thanks again for
the comments!
Comment at: docs/UndefinedBehaviorSanitizer.rst:101
+ ``-fsanitize=nullability-assign``, and th
GorNishanov requested changes to this revision.
GorNishanov added a comment.
This revision now requires changes to proceed.
One thought I had with respect to removing array of statements: We need to
check during Sema that await_ready returns a type contextually convertible to
bool and await_susp
EricWF added a comment.
Good to know. I'll update this tomorrow.
https://reviews.llvm.org/D30776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chandlerc created this revision.
Herald added a subscriber: mcrosier.
This follows the design direction discussed on cfe-dev here:
http://lists.llvm.org/pipermail/cfe-dev/2017-January/052066.html
The idea is that for C standard library builtins, even if the library
vendor chooses to annotate thei
GorNishanov added a comment.
In https://reviews.llvm.org/D30776#697233, @EricWF wrote:
> Good to know. I'll update this tomorrow.
Well, that is just the thought. Possibly we can check for the types of
await_ready and await_suspend in BuildResolvedCoawaitExpr. Then, we don't have
to keep the v
zaks.anna added inline comments.
Comment at: docs/UndefinedBehaviorSanitizer.rst:101
+ ``-fsanitize=nullability-assign``, and the argument check with
+ ``-fsanitize=nullability-arg``. While violating nullability rules does
+ not result in undefined behavior, it is oft
GorNishanov created this revision.
Herald added a subscriber: mehdi_amini.
Emit suspend expression which roughly looks like:
auto && x = CommonExpr();
if (!x.await_ready()) {
llvm_coro_save();
x.await_suspend(...); (*)
llvm_coro_suspend(); (**)
}
x.await_resume();
wher
Hello everyone,
LLVM buildmaster will be updated and restarted in the nearest hour.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jaykang10 created this revision.
Preserve vec3 type with CodeGen option.
https://reviews.llvm.org/D30810
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CGExpr.cpp
lib/Frontend/CompilerInvocation.cpp
test/CodeGenOpenCL/preserve_vec3.cl
Hahnfeld marked an inline comment as done.
Hahnfeld added a comment.
In https://reviews.llvm.org/D30733#697108, @jroelofs wrote:
> As I said on https://reviews.llvm.org/D30214, it is inappropriate to be
> installing libc++ in the resource directory... please **do not** do that.
Can you give re
80 matches
Mail list logo
