[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

2017-03-23 Thread András Leitereg via Phabricator via cfe-commits
leanil marked 3 inline comments as done. leanil added inline comments. Comment at: clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp:125-126 +} +diag(Ctor->getLocation(), "function %0 can hide copy and move constructors") +<< Ctor; + }

[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

2017-03-23 Thread András Leitereg via Phabricator via cfe-commits
leanil updated this revision to Diff 92765. leanil added a comment. Simplify the note generation and correct the documentation. Repository: rL LLVM https://reviews.llvm.org/D30547 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp

[PATCH] D30388: [XRay] Add -fxray-{always, never}-instrument= flags to clang

2017-03-23 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris added a comment. In https://reviews.llvm.org/D30388#707719, @rnk wrote: > I think you need some driver logic to make sure the xray lists show up in .d > files so that modifications to them trigger rebuilds in most build systems. > See the SanitizerArgs.cpp driver logic for this. Good

[PATCH] D30388: [XRay] Add -fxray-{always, never}-instrument= flags to clang

2017-03-23 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris updated this revision to Diff 92766. dberris marked 2 inline comments as done. dberris added a comment. - fixup: address reviewer comments https://reviews.llvm.org/D30388 Files: include/clang/AST/ASTContext.h include/clang/Basic/LangOptions.def include/clang/Basic/LangOptions.h

[libcxx] r298582 - Silence a couple of 'unused variable' warnings in c++03 tests. No functional change

2017-03-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Mar 23 01:25:26 2017 New Revision: 298582 URL: http://llvm.org/viewvc/llvm-project?rev=298582=rev Log: Silence a couple of 'unused variable' warnings in c++03 tests. No functional change Modified:

[libcxx] r298581 - Worked around GCC bug 56480. Explicit specialization in a different namespace.

2017-03-23 Thread Michael Park via cfe-commits
Author: mpark Date: Thu Mar 23 01:21:24 2017 New Revision: 298581 URL: http://llvm.org/viewvc/llvm-project?rev=298581=rev Log: Worked around GCC bug 56480. Explicit specialization in a different namespace. Summary: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56480 Reviewers: EricWF Reviewed

[libcxx] r298580 - Can't test for noexcept on C++03; std::hash isn't available until C++17

2017-03-23 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Mar 23 01:20:18 2017 New Revision: 298580 URL: http://llvm.org/viewvc/llvm-project?rev=298580=rev Log: Can't test for noexcept on C++03; std::hash isn't available until C++17 Modified: libcxx/trunk/include/functional

<    1   2