[PATCH] D31382: [XRay][clang] Remove dependency on libatomic for XRay builds

dberris created this revision. This change depends on https://reviews.llvm.org/D31381 where we change the implementation to use sanitizer_common provided atomic operations library. Fixes http://llvm.org/PR32274. https://reviews.llvm.org/D31382 Files: lib/Driver/ToolChains/Gnu.cpp Index:

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

xiangzhai added a comment. Hi Raphael, Thanks for your awesome job! I have read about the slide of "LLVM: built-in scalable code clone detection based on semantic analysis", and sent email to Shamil for asking "Is Code clone

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist updated this revision to Diff 93092. enyquist added a comment. Option implemented completely in WhitespaceManager.cpp, so no overhead if the option isn't used. Also some minor style fixes. Repository: rL LLVM https://reviews.llvm.org/D28462 Files:

[PATCH] D30909: [Analyzer] Finish taint propagation to derived symbols of tainted regions

vlad.tsyrklevich added inline comments. Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:494 + SymbolManager = C.getSymbolManager(); + return SM.getDerivedSymbol(Sym, LCV.getRegion()); } NoQ wrote: > I'd think about this a bit more and come

[PATCH] D30909: [Analyzer] Finish taint propagation to derived symbols of tainted regions

vlad.tsyrklevich updated this revision to Diff 93091. vlad.tsyrklevich marked 2 inline comments as done. vlad.tsyrklevich added a comment. Respond to Artem's comments. https://reviews.llvm.org/D30909 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h

[PATCH] D31378: [PCH] Attach instance's dependency collectors to PCH external AST sources.

graydon created this revision. When a PCH is included via -include-pch, clang should treat the current TU as dependent on the sourcefile that the PCH was generated from. This is currently _partly_ accomplished by InitializePreprocessor calling AddImplicitIncludePCH to synthesize an implicit

r298824 - Revert r298742 "[ODRHash] Add error messages for mismatched parameters in methods."

Author: vvassilev Date: Sun Mar 26 16:39:16 2017 New Revision: 298824 URL: http://llvm.org/viewvc/llvm-project?rev=298824=rev Log: Revert r298742 "[ODRHash] Add error messages for mismatched parameters in methods." I failed to revert this in r298816. Modified:

r298816 - Revert 298754 and 298742.

Author: vvassilev Date: Sun Mar 26 13:32:53 2017 New Revision: 298816 URL: http://llvm.org/viewvc/llvm-project?rev=298816=rev Log: Revert 298754 and 298742. They broke llvm modules builds and our internal modules infrastructure. Modified:

Re: [PATCH] D30760: Record command lines in objects built by clang, Clang part

Sounds good to me. On Sun, Mar 26, 2017, 9:40 AM David Blaikie wrote: > Yeah, I don't know/mind either way - I think there's a tidy simplicity to > including exactly what the user wrote on the command line, so don't mind if > it's not removed, but can see the argument to

Re: [PATCH] D30760: Record command lines in objects built by clang, Clang part

Yeah, I don't know/mind either way - I think there's a tidy simplicity to including exactly what the user wrote on the command line, so don't mind if it's not removed, but can see the argument to omit it. I'd probably leave it in for simplicity. On Fri, Mar 24, 2017 at 5:48 PM Eric Christopher

[PATCH] D31375: Add docs for libunwind

jroelofs updated this revision to Diff 93075. https://reviews.llvm.org/D31375 Files: CMakeLists.txt docs/BuildingLibunwind.rst docs/CMakeLists.txt docs/README.txt docs/conf.py docs/index.rst Index: docs/index.rst ===

[PATCH] D31375: Add docs for libunwind

jroelofs added a comment. In https://reviews.llvm.org/D31375#710891, @compnerd wrote: > What happens when you try building it in tree? The docs-libunwind-html target is missing, and the docs don't get built. Comment at: docs/index.rst:82 + +If you want to contribute a patch

[PATCH] D31375: Add docs for libunwind

compnerd added a comment. What happens when you try building it in tree? Comment at: docs/index.rst:82 + +If you want to contribute a patch to libc++, the best place for that is +`Phabricator `_. Please include [libunwind] in the subject

Re: [PATCH] Use the correct ObjC++ personality

On 3/26/17 10:13 AM, Jonathan Schleifer via cfe-commits wrote: Use the correct EH personality for ObjC++ code. Previously, it would just always use the ObjC DWARF personality, even with SjLj or SEH exceptions. diff --git a/lib/CodeGen/CGException.cpp b/lib/CodeGen/CGException.cpp index

[PATCH] Use the correct ObjC++ personality

Use the correct EH personality for ObjC++ code. Previously, it would just always use the ObjC DWARF personality, even with SjLj or SEH exceptions. diff --git a/lib/CodeGen/CGException.cpp b/lib/CodeGen/CGException.cpp index 228efec51b..ca1535182e 100644 --- a/lib/CodeGen/CGException.cpp +++

[PATCH] D31375: Add docs for libunwind

jroelofs updated this revision to Diff 93074. https://reviews.llvm.org/D31375 Files: CMakeLists.txt docs/BuildingLibunwind.rst docs/CMakeLists.txt docs/README.txt docs/conf.py docs/index.rst Index: docs/index.rst ===

[PATCH] D31375: Add docs for libunwind

krytarowski added inline comments. Comment at: docs/index.rst:51 +LinuxARM Clang, GCC EHABI +Bare Metal ARM Clang, GCC EHABI + NetBSD amd64

[PATCH] D31375: Add docs for libunwind

jroelofs created this revision. Herald added a subscriber: mgorny. I'm still iffy about the build goop for this. I started mostly cargo-culting the stuff from libcxx, but couldn't get that to work. What's in the patch seems to work for the standalone build, but does not work for in tree builds

[PATCH] D29599: Clang Changes for alloc_align

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:1224 +def AllocAlign : InheritableAttr { + let Spellings = [ GCC<"alloc_align"> ]; + let Subjects = SubjectList<[Function]>; Extra spaces in the declaration that do not match the

[PATCH] D24886: Add [[clang::suppress(rule, ...)]] attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D24886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30809: [coroutines] Add codegen for await and yield expressions

GorNishanov closed this revision. GorNishanov added a comment. Commit: r298784 https://reviews.llvm.org/D30809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r298742 - [ODRHash] Add error messages for mismatched parameters in methods.

Hi, This seems broke quite a lot of code, similarly to this: http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules-2/builds/5727/steps/compile.llvm.stage2/logs/stdio and also http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules/builds/4162 Could we back