[PATCH] D31667: [Sema] Extend GetSignedVectorType to deal with non ExtVector types

sdardis marked an inline comment as done. sdardis added inline comments. Comment at: lib/Sema/SemaExpr.cpp:9736 + } + + if (TypeSize == Context.getTypeSize(Context.LongLongTy)) ahatanak wrote: > This isn't particularly urgent, but can we use ASTContext >

r299639 - PR16106: Correct the docs to reflect the actual behavior of the interface.

Author: vvassilev Date: Thu Apr 6 05:05:46 2017 New Revision: 299639 URL: http://llvm.org/viewvc/llvm-project?rev=299639=rev Log: PR16106: Correct the docs to reflect the actual behavior of the interface. Modified: cfe/trunk/include/clang-c/Index.h Modified:

[clang-tools-extra] r299638 - [clang-tidy] Check for forwarding reference overload in constructors.

Author: xazax Date: Thu Apr 6 04:56:42 2017 New Revision: 299638 URL: http://llvm.org/viewvc/llvm-project?rev=299638=rev Log: [clang-tidy] Check for forwarding reference overload in constructors. Patch by András Leitereg! Differential Revision: https://reviews.llvm.org/D30547 Added:

[PATCH] D30547: [clang-tidy] Forwarding reference overload in constructors

This revision was automatically updated to reflect the committed changes. Closed by commit rL299638: [clang-tidy] Check for forwarding reference overload in constructors. (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D30547?vs=94028=94339#toc Repository: rL LLVM

[PATCH] D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks

ioeric added a comment. Still LGTM. Please run `ninja check-clang` and fix the warning. I'll land this patch for you afterwards. Comment at: lib/Tooling/RefactoringCallbacks.cpp:222 +} +default: + llvm_unreachable("Element.Type not recognized");

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor added inline comments. Comment at: lib/Analysis/CloneDetection.cpp:395 + + for (const Stmt *Child : S->children()) { +if (Child == nullptr) { I couldn't reproduce, but from what I assume form the warning and the crash that we confused the

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

teemperor updated this revision to Diff 94337. teemperor added a comment. - Renamed variable from 'S' to 'Child' to make the buildbots happy (and because it's more expressive) - Fixed the name of the unit test. https://reviews.llvm.org/D23418 Files: include/clang/Analysis/CloneDetection.h

[PATCH] D31652: [clang-format] Recognize Java logical shift assignment operator

bradfier updated this revision to Diff 94334. bradfier added a reviewer: klimek. bradfier added a comment. Add more diff context, add klimek as reviewer. Repository: rL LLVM https://reviews.llvm.org/D31652 Files: include/clang/Basic/LangOptions.def include/clang/Basic/TokenKinds.def

[PATCH] D31713: [Basic] getColumnNumber returns location of CR+LF on Windows

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with one nit. Thank you for tracking down this bug and fixing it! Comment at: lib/Basic/SourceManager.cpp:1153 + if (FilePos + 1 == LineEnd && FilePos > LineStart)

[PATCH] D31745: [OpenCL] Added diagnostic for implicit declaration of function in OpenCL

echuraev created this revision. Herald added a subscriber: yaxunl. https://reviews.llvm.org/D31745 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/SemaOpenCL/clang-builtin-version.cl test/SemaOpenCL/to_addr_builtin.cl Index:

[PATCH] D27334: [OpenCL] Ambiguous function call.

echuraev added a comment. In https://reviews.llvm.org/D27334#700521, @Anastasia wrote: > I don't actually. But remembering the follow up discussion: > http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20161205/178846.html > and since we have to deviate from the standard C/C++

[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

chrib updated this revision to Diff 94329. chrib added a comment. - NeedsUnwindTable check thumb arch https://reviews.llvm.org/D31140 Files: lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h Index: lib/CodeGen/CodeGenModule.h

<    1   2