[PATCH] D32675: in expression evaluator, treat non-literal types as discarded value expressions if EvalInfo says to continue evaluating them

2017-04-29 Thread Nick Lewycky via Phabricator via cfe-commits
nlewycky created this revision. Make the integer overflow evaluator continue into expressions with non-literal types, notably void. In passing it fixes a crash attempting to codegen: struct A { char x; }; struct B : virtual A {}; A &a = ((A&)*(B*)0); which we nearly have a test for excep

[PATCH] D31739: Add markup for libc++ dylib availability

2017-04-29 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. This LGTM, and it's liable to bitrot if it hangs out here any longer. We can always iterate in tree if we find a better way to organize the markup and/or tests. Eric and Marshall: do

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

2017-04-29 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter updated this revision to Diff 97204. CaseyCarter added a comment. Fix a weird corner case in variant's move assignment triviality test. https://reviews.llvm.org/D32671 Files: test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp test/std/utilities/variant/varia

[PATCH] D32385: [libcxx] optional: Implement LWG 2900 and P0602

2017-04-29 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter updated this revision to Diff 97203. CaseyCarter added a comment. Fix comment typo in optional.object.assign/move.pass.cpp https://reviews.llvm.org/D32385 Files: include/optional test/std/utilities/optional/optional.object/optional.object.assign/copy.pass.cpp test/std/utilit

[clang-tools-extra] r301762 - clang-tools-extra/test/CMakeLists.txt: Rework r297806 (D29851) to make sure test utils should be built.

2017-04-29 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Sat Apr 29 22:19:04 2017 New Revision: 301762 URL: http://llvm.org/viewvc/llvm-project?rev=301762&view=rev Log: clang-tools-extra/test/CMakeLists.txt: Rework r297806 (D29851) to make sure test utils should be built. FIXME: This may be moved to llvm's add_lit_target(). Modi

[PATCH] D32670: Ensure showbase does not overflow do_put buffers

2017-04-29 Thread Dimitry Andric via Phabricator via cfe-commits
dim updated this revision to Diff 97198. dim added a comment. Simplify test case a bit. https://reviews.llvm.org/D32670 Files: include/locale test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/minmax_showbase.pass.cpp Index: test/std/input.

r301749 - [X86][AVX] Added support for _mm256_zext* helper intrinsics (PR32839)

2017-04-29 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Sat Apr 29 12:17:06 2017 New Revision: 301749 URL: http://llvm.org/viewvc/llvm-project?rev=301749&view=rev Log: [X86][AVX] Added support for _mm256_zext* helper intrinsics (PR32839) Modified: cfe/trunk/lib/Headers/avx512fintrin.h cfe/trunk/lib/Headers/avxintrin.h

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

2017-04-29 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter created this revision. NOTE: Unlike my typical `variant` test PRs, this one is actually safe to merge - crazy, I know - since it only adds coverage while testing the VC++ STL. - Define a new macro `_MSVC_STL_VER` to distinguish testing the VC++ standard library implementation in t

[PATCH] D32670: Ensure showbase does not overflow do_put buffers

2017-04-29 Thread Dimitry Andric via Phabricator via cfe-commits
dim added a comment. Note: I copied some of the test case from https://reviews.llvm.org/rL227097, which had a similar case of a too short buffer. https://reviews.llvm.org/D32670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D32670: Ensure showbase does not overflow do_put buffers

2017-04-29 Thread Dimitry Andric via Phabricator via cfe-commits
dim created this revision. Herald added a subscriber: emaste. In https://bugs.freebsd.org/207918, Daniel McRobb describes how using std::showbase with ostreams can cause truncation of unsigned long long when output format is octal. In fact, this can even happen with unsigned int and unsigned long

[PATCH] D32385: [libcxx] optional: Implement LWG 2900 and P0602

2017-04-29 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter updated this revision to Diff 97188. CaseyCarter retitled this revision from "[libcxx] Implement LWG 2900 "The copy and move constructors of optional are not constexpr"" to "[libcxx] optional: Implement LWG 2900 and P0602". CaseyCarter edited the summary of this revision. CaseyCarter

[clang-tools-extra] r301743 - [clang-tidy] Expand AllowConditional*Casts to binary logical operators

2017-04-29 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Sat Apr 29 07:06:45 2017 New Revision: 301743 URL: http://llvm.org/viewvc/llvm-project?rev=301743&view=rev Log: [clang-tidy] Expand AllowConditional*Casts to binary logical operators Modified: clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp c

r301742 - Remove Sema::CheckForIntOverflow, and instead check all full-expressions.

2017-04-29 Thread Nick Lewycky via cfe-commits
Author: nicholas Date: Sat Apr 29 04:33:46 2017 New Revision: 301742 URL: http://llvm.org/viewvc/llvm-project?rev=301742&view=rev Log: Remove Sema::CheckForIntOverflow, and instead check all full-expressions. CheckForIntOverflow used to implement a whitelist of top-level expressions to send to th