Author: faisalv
Date: Mon May 8 23:17:15 2017
New Revision: 302507
URL: http://llvm.org/viewvc/llvm-project?rev=302507&view=rev
Log:
Fix PR32638 : Make sure we switch Sema's CurContext to the substituted
FunctionDecl when instantiating the exception specification.
This fixes the bug: https://bu
Author: gbiv
Date: Mon May 8 23:06:24 2017
New Revision: 302506
URL: http://llvm.org/viewvc/llvm-project?rev=302506&view=rev
Log:
[Sema] Make typeof(OverloadedFunctionName) not a pointer.
We were sometimes doing a function->pointer conversion in
Sema::CheckPlaceholderExpr, which isn't the job of
EricWF planned changes to this revision.
EricWF added a comment.
This breaks MinGW. I'll update soon.
Comment at: include/algorithm:647
#endif
-#if defined(_LIBCPP_MSVCRT) || defined(__MINGW32__)
-#include "support/win32/support.h"
+#if defined(_LIBCPP_COMPILER_MSVC)
+#include
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: test/CodeGenCXX/amdgcn-automatic-variable.cpp:25
+ // CHECK: store i32 2, i32* %[[r1]]
+ int lv1;
+ lv1 = 1;
yaxunl wrote:
> Anastasia wrote:
> > I am wondering if all these dif
Author: rtrieu
Date: Mon May 8 22:24:34 2017
New Revision: 302505
URL: http://llvm.org/viewvc/llvm-project?rev=302505&view=rev
Log:
[ODRHash] Loosen checks on typedefs.
When a type in a class is from a typedef, only check the canonical type. Skip
checking the intermediate underlying types. Thi
beanz accepted this revision.
beanz added a comment.
Yep, this seems straight forward.
Repository:
rL LLVM
https://reviews.llvm.org/D32815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: ahatanak
Date: Mon May 8 20:54:51 2017
New Revision: 302503
URL: http://llvm.org/viewvc/llvm-project?rev=302503&view=rev
Log:
[Sema][ObjC] Clean up possible null dereference.
It appears that the code is actually dead since unbridged-cast
placeholder types are created by calling CastOpera
Author: tstellar
Date: Mon May 8 20:42:33 2017
New Revision: 302500
URL: http://llvm.org/viewvc/llvm-project?rev=302500&view=rev
Log:
docs: Fix Sphinx detection with out-of-tree builds
Adapt to changes made in r302499.
Modified:
cfe/trunk/docs/CMakeLists.txt
Modified: cfe/trunk/docs/CMakeL
Author: bcraig
Date: Mon May 8 20:34:12 2017
New Revision: 302497
URL: http://llvm.org/viewvc/llvm-project?rev=302497&view=rev
Log:
Fix Windows tests when __config_site is present.
Previously, the force includes would complain about a missing _DEBUG symbol.
Now we dump macros before adding the fo
EricWF updated this revision to Diff 98246.
EricWF added a comment.
- Rename `msvc_support.h` to `msvc_builtin_support.h`.
https://reviews.llvm.org/D32988
Files:
include/__config
include/algorithm
include/ctype.h
include/limits
include/stdio.h
include/stdlib.h
include/support/win3
Author: bcraig
Date: Mon May 8 20:26:39 2017
New Revision: 302496
URL: http://llvm.org/viewvc/llvm-project?rev=302496&view=rev
Log:
Revert "Fix Windows tests when __config_site is present."
It's 2017, and line endings are still an issue.
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Mo
danbeam created this revision.
Herald added a subscriber: klimek.
Because IIFEs[1] are often used like an anonymous namespace around large
sections of JavaScript code, it's useful not to indent to them (which
effectively reduces the column limit by the indent amount needlessly).
It's also common
Thank you for the fix. I committed a follow-up patch in r302495, which makes
IRGen emit @objc_retain at -O0.
> On May 5, 2017, at 11:39 AM, Saleem Abdulrasool via cfe-commits
> wrote:
>
> Author: compnerd
> Date: Fri May 5 13:39:06 2017
> New Revision: 302270
>
> URL: http://llvm.org/viewvc/
EricWF created this revision.
This patch refactors and tries to remove as much of the Windows support headers
as possible. This is needed because they currently introduce super weird
include cycles and dependencies between STL and libc headers.
The changes in this patch are:
- remove `support/
Author: ahatanak
Date: Mon May 8 20:20:05 2017
New Revision: 302495
URL: http://llvm.org/viewvc/llvm-project?rev=302495&view=rev
Log:
[CodeGen][ObjC] Emit @objc_retain at -O0 for variables captured by
blocks.
r302270 made changes to avoid emitting clang.arc.use at -O0 and instead
emit @objc_rele
dberris marked an inline comment as done.
dberris added a comment.
Thanks @rnk!
Comment at: lib/CodeGen/CGBuiltin.cpp:2748
+if (const auto *XRayAttr =
+this->CurFuncDecl->getAttr()) {
+ if (XRayAttr->neverXRayInstrument())
rnk wrote:
> rnk
Author: dberris
Date: Mon May 8 19:45:40 2017
New Revision: 302492
URL: http://llvm.org/viewvc/llvm-project?rev=302492&view=rev
Log:
[XRay] Add __xray_customeevent(...) as a clang-supported builtin
Summary:
We define the `__xray_customeevent` builtin that gets translated to
IR calls to the corre
This revision was automatically updated to reflect the committed changes.
dberris marked an inline comment as done.
Closed by commit rL302492: [XRay] Add __xray_customeevent(...) as a
clang-supported builtin (authored by dberris).
Changed prior to commit:
https://reviews.llvm.org/D30018?vs=9812
Author: bruno
Date: Mon May 8 19:41:38 2017
New Revision: 302491
URL: http://llvm.org/viewvc/llvm-project?rev=302491&view=rev
Log:
[Modules] Allow umbrella frameworks to define private submodules for
subframeworks
In r298391 we fixed the umbrella framework model to work when submodules
named "P
Author: vedantk
Date: Mon May 8 19:12:33 2017
New Revision: 302490
URL: http://llvm.org/viewvc/llvm-project?rev=302490&view=rev
Log:
Rename a method. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGExprScalar.cpp
Modified: cfe/trunk/lib/CodeGen/CGExprScalar.cpp
URL:
http://llvm.org/viewvc/llvm-proj
Author: ericwf
Date: Mon May 8 19:11:02 2017
New Revision: 302489
URL: http://llvm.org/viewvc/llvm-project?rev=302489&view=rev
Log:
XFAIL noexcept member function throw/catch test under GCC.
I'm still not exactly sure why the test fails, but I suspect it's
a bug in GCC. More investigation needed
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Mon May 8 19:00:00 2017
New Revision: 302488
URL: http://llvm.org/viewvc/llvm-project?rev=302488&view=rev
Log:
Fix GCC 7 test failures.
This patch fixes the test failures and unexpected passes that occur
when testing against GCC 7. Specifically:
* don't mark __gcd as always
EricWF updated this revision to Diff 98234.
EricWF marked 2 inline comments as done.
EricWF added a comment.
- Fix incorrect issue number.
- Regenerate issue list.
https://reviews.llvm.org/D32984
Files:
lib/AST/Type.cpp
test/CXX/drs/dr20xx.cpp
test/CXX/drs/dr4xx.cpp
test/SemaCXX/type-tr
pcc accepted this revision.
pcc added a comment.
LGTM
Unfortunate, but I guess this is in the same category as things like
`-fsized-deallocation`.
Comment at: lib/Driver/SanitizerArgs.cpp:573
+
+// This is a workaround for a bug in gold and enabled by default for
non-ELF
rsmith added inline comments.
Comment at: test/CXX/drs/dr4xx.cpp:1205
-namespace dr496 { // dr496: no
+namespace dr496 { // dr496: reverted by dr2095 in 5.0
struct A { int n; };
Write this as "dr496: sup 2094" and then rerun the `make_cxx_dr_status` script
EricWF updated this revision to Diff 98229.
EricWF added a comment.
- Use `sup` instead of `reverted by` to match style of other DRs.
https://reviews.llvm.org/D32984
Files:
lib/AST/Type.cpp
test/CXX/drs/dr20xx.cpp
test/CXX/drs/dr4xx.cpp
test/SemaCXX/type-traits.cpp
Index: test/SemaCXX
EricWF created this revision.
This patch implements
http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#2094 which reverts
Core 496.
https://reviews.llvm.org/D32984
Files:
lib/AST/Type.cpp
test/CXX/drs/dr20xx.cpp
test/CXX/drs/dr4xx.cpp
test/SemaCXX/type-traits.cpp
Index: te
Author: adrian
Date: Mon May 8 17:44:00 2017
New Revision: 302476
URL: http://llvm.org/viewvc/llvm-project?rev=302476&view=rev
Log:
Update testcase for upstream LLVM changes.
Modified:
cfe/trunk/test/CodeGenCXX/linetable-virtual-variadic.cpp
Modified: cfe/trunk/test/CodeGenCXX/linetable-vir
Author: ericwf
Date: Mon May 8 17:02:43 2017
New Revision: 302474
URL: http://llvm.org/viewvc/llvm-project?rev=302474&view=rev
Log:
Refactor RAII guards to aid upcoming Windows locale changes.
Previously used std::unique_ptr,
locale-mgmt-function>
as a scope guard for (A) creating new locales
yaxunl marked 18 inline comments as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1115
+ if (AddrTy->getAddressSpace() != ExpectedAddrSpace &&
+ Ty.getAddressSpace() != LangAS::opencl_constant) {
+address = Address(Builder.CreateAddrSpaceCast(Ad
Author: bion
Date: Mon May 8 16:54:53 2017
New Revision: 302473
URL: http://llvm.org/viewvc/llvm-project?rev=302473&view=rev
Log:
Fix possible loss of data warnings on amd64
In T_size_size.pass, there is an explicit template argument to std::min to ask
for unsigned, to avoid type deduction error
Author: bion
Date: Mon May 8 16:52:05 2017
New Revision: 302472
URL: http://llvm.org/viewvc/llvm-project?rev=302472&view=rev
Log:
Resolve integer overflow warnings in GCD and LCM tests
lcm.pass.cpp:
19: Update headers to that actually used in the test.
41: test0 was triggering narrowing warnings
BillyONeal updated this revision to Diff 98219.
BillyONeal marked 2 inline comments as done.
BillyONeal edited the summary of this revision.
BillyONeal added a comment.
Do Eric's suggestions.
https://reviews.llvm.org/D32309
Files:
test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp
t
spyffe updated this revision to Diff 98218.
spyffe added a comment.
Eliminated a //missing newline at end of file// error
Repository:
rL LLVM
https://reviews.llvm.org/D32981
Files:
include/clang/AST/ExternalASTMerger.h
lib/AST/ASTImporter.cpp
lib/AST/ASTStructuralEquivalence.cpp
lib/
spyffe created this revision.
`ASTImporter` has some bugs when it's importing types that themselves come from
an `ExternalASTSource`. This is exposed particularly in the behavior when
comparing complete TagDecls with forward declarations. This patch does several
things:
- Adds a test case ma
EricWF added inline comments.
Comment at: test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp:42
+constexpr bool test0(int in1, int in2, int out)
{
+static_assert(std::is_same EricWF wrote:
> > Nit but this seems much cleaner and more readable without the casts.
> >
BillyONeal added inline comments.
Comment at: test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp:42
+constexpr bool test0(int in1, int in2, int out)
{
+static_assert(std::is_same Nit but this seems much cleaner and more readable without the casts.
>
> ```
> auto val
rnkovacs added a comment.
The current proposition could be that we only keep the first two cases,
possibly merging in the google check for a third case (with its old name
evoking original functionality). Separately, another check could be written
that warns when the below mentioned memory manag
EricWF accepted this revision.
EricWF added a comment.
Still LGTM.
https://reviews.llvm.org/D32574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
BillyONeal updated this revision to Diff 98214.
BillyONeal marked 4 inline comments as done.
BillyONeal edited the summary of this revision.
BillyONeal added a comment.
Instead, change the tests to pass around std::size_t instances, and explicitly
narrow when constructing the string type under tes
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM, preferably with the suggested cleanups.
Comment at: test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp:146
+auto res = std::gcd(static_cast(1234), INT32
Author: vedantk
Date: Mon May 8 16:11:55 2017
New Revision: 302468
URL: http://llvm.org/viewvc/llvm-project?rev=302468&view=rev
Log:
[Driver] Don't enable -fsanitize-use-after-scope when ASan is disabled
When enabling any sanitizer, -fsanitize-use-after-scope is enabled by
default. This doesn't
t-tye added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1115
+ if (AddrTy->getAddressSpace() != ExpectedAddrSpace &&
+ Ty.getAddressSpace() != LangAS::opencl_constant) {
+address = Address(Builder.CreateAddrSpaceCast(Addr,
Anastasia wrote:
> Do
BillyONeal updated this revision to Diff 98205.
BillyONeal added a comment.
Resolved CR comments
https://reviews.llvm.org/D32309
Files:
test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp
test/std/numerics/numeric.ops/numeric.ops.lcm/lcm.pass.cpp
Index: test/std/numerics/numeric.ops
jbangert updated this revision to Diff 98203.
jbangert added a comment.
Ran check-clang
https://reviews.llvm.org/D29621
Files:
include/clang/Tooling/RefactoringCallbacks.h
lib/Tooling/RefactoringCallbacks.cpp
unittests/Tooling/RefactoringCallbacksTest.cpp
Index: unittests/Tooling/Refacto
Thanks!
On 06/05/17 00:34, Richard Smith via cfe-commits wrote:
Author: rsmith
Date: Fri May 5 17:34:07 2017
New Revision: 302312
URL: http://llvm.org/viewvc/llvm-project?rev=302312&view=rev
Log:
Permit keywords in module names in #pragma clang module *.
This is necessary to be able to build a
Author: rsmith
Date: Mon May 8 15:30:47 2017
New Revision: 302463
URL: http://llvm.org/viewvc/llvm-project?rev=302463&view=rev
Log:
If we are building a module, and we read a second description of the same
module from a different module map, ignore it.
This happens during builds of preprocessed
eugenis updated this revision to Diff 98200.
Herald added a subscriber: krytarowski.
Repository:
rL LLVM
https://reviews.llvm.org/D32886
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cpp
l
yaxunl added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1105-1119
+ // Alloca always returns a pointer in alloca address space, which may
+ // be different from the type defined by the language. For example,
+ // in C++ the auto variables are in the default address sp
yaxunl created this revision.
Herald added a subscriber: nhaehnle.
https://reviews.llvm.org/D32977
Files:
include/clang/AST/Decl.h
lib/Sema/SemaDecl.cpp
test/CodeGenOpenCL/amdgpu-debug-info-pointer-address-space.cl
test/CodeGenOpenCL/amdgpu-debug-info-variable-expression.cl
test/CodeGen
efriedma added a comment.
In https://reviews.llvm.org/D32759#748653, @chenwj wrote:
> In https://reviews.llvm.org/D32759#748007, @efriedma wrote:
>
> > The difference between returning true and false here is just the way error
> > recovery works: when we return true, we know the type is invalid,
rjmccall added a comment.
In https://reviews.llvm.org/D31885#748873, @kparzysz wrote:
> Ping.
>
> What's the next step here?
Sounds to me like we should just not apply struct-path TBAA data that runs
through a union field because either LLVM's representation can't handle it or
Clang isn't gen
kparzysz added a comment.
Ping.
What's the next step here?
Repository:
rL LLVM
https://reviews.llvm.org/D31885
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yamaguchi added a comment.
@teemperor ping..?
https://reviews.llvm.org/D32341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
spyffe added inline comments.
Comment at: lib/Basic/LangOptions.cpp:32
- // FIXME: This should not be reset; modules can be different with different
- // sanitizer options (this affects __has_feature(address_sanitizer) etc).
- Sanitize.clear();
+ // These options do not aff
RKSimon added a comment.
In https://reviews.llvm.org/D32770#748762, @craig.topper wrote:
> Sorry I missed this patch, but shouldn't we had __LWP__ to the relevant
> processors in test/Preprocessor/predefined-arch-macros.c and the command
> line switch testing to test/Preprocessor/x86_target_fe
Author: rksimon
Date: Mon May 8 12:25:48 2017
New Revision: 302445
URL: http://llvm.org/viewvc/llvm-project?rev=302445&view=rev
Log:
[X86][LWP] Add __LWP__ macro tests
Missed in rL302418
Differential Revision: https://reviews.llvm.org/D32770
Modified:
cfe/trunk/test/Preprocessor/predefined
arphaman created this revision.
This patch implements basic support for indexing of dependent declaration
references. Now the indexer tries to find a suitable match in the base template
for a dependent member ref/decl ref/dependent type.
This will be used to improve the "go-to-definition" / "fi
Author: jroelofs
Date: Mon May 8 12:06:17 2017
New Revision: 302443
URL: http://llvm.org/viewvc/llvm-project?rev=302443&view=rev
Log:
Fix grammar in comment. NFC
Modified:
cfe/trunk/test/Misc/warning-flags.c
Modified: cfe/trunk/test/Misc/warning-flags.c
URL:
http://llvm.org/viewvc/llvm-pro
cynecx added a comment.
Would it be possible to land this patch? I would really like to see this fixed.
Repository:
rL LLVM
https://reviews.llvm.org/D25051
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Author: malcolm.parsons
Date: Mon May 8 11:43:29 2017
New Revision: 302440
URL: http://llvm.org/viewvc/llvm-project?rev=302440&view=rev
Log:
[AST] Fix copy&paste error in comment. NFC.
Modified:
cfe/trunk/include/clang/AST/Decl.h
Modified: cfe/trunk/include/clang/AST/Decl.h
URL:
http://llv
craig.topper added a comment.
Sorry I missed this patch, but shouldn't we had __LWP__ to the relevant
processors in test/Preprocessor/predefined-arch-macros.c and the command line
switch testing to test/Preprocessor/x86_target_features.c
Repository:
rL LLVM
https://reviews.llvm.org/D32770
xazax.hun marked 4 inline comments as done.
xazax.hun added inline comments.
Comment at: test/clang-tidy/cert-dcl21-cpp.cpp:1
+// RUN: %check_clang_tidy %s cert-dcl21-cpp %t
+
aaron.ballman wrote:
> xazax.hun wrote:
> > aaron.ballman wrote:
> > > alexfh wrote:
>
xazax.hun updated this revision to Diff 98179.
xazax.hun added a comment.
- Do not do fixits for type aliases.
https://reviews.llvm.org/D32743
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/cert/PostfixOperatorCheck.cpp
clang-tidy/cert/PostfixOperato
Author: stulova
Date: Mon May 8 11:05:54 2017
New Revision: 302435
URL: http://llvm.org/viewvc/llvm-project?rev=302435&view=rev
Log:
[Sema] Fix typos handling in an overloadable call.
In C typos in arguments in a call of an overloadable function lead
to a failure of construction of CallExpr and
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/CodeGen/CGBuiltin.cpp:2748
+if (const auto *XRayAttr =
+this->CurFuncDecl->getAttr()) {
+ if (XRayAttr->neverXRayInstrument())
---
hiraditya added a comment.
Ping
https://reviews.llvm.org/D30268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: alexfh
Date: Mon May 8 10:22:09 2017
New Revision: 302431
URL: http://llvm.org/viewvc/llvm-project?rev=302431&view=rev
Log:
[clang-tidy] Fix readability-implicit-bool-cast false positives
The patch makes the check treat binary conditional operator (`x ?: y`), `while`
and regular `for` lo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302429: clang-tidy: add IgnoreMacros option to
modernize-use-default-member-init (authored by vmiklos).
Changed prior to commit:
https://reviews.llvm.org/D32945?vs=98163&id=98173#toc
Repository:
rL L
Author: vmiklos
Date: Mon May 8 10:13:31 2017
New Revision: 302429
URL: http://llvm.org/viewvc/llvm-project?rev=302429&view=rev
Log:
clang-tidy: add IgnoreMacros option to modernize-use-default-member-init
Summary:
And also enable it by default to be consistent with e.g.
modernize-use-using.
Th
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Submitted as r302427.
https://reviews.llvm.org/D32475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
djasper closed this revision.
djasper added a comment.
Submitted as r302428.
https://reviews.llvm.org/D32733
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: djasper
Date: Mon May 8 10:08:00 2017
New Revision: 302428
URL: http://llvm.org/viewvc/llvm-project?rev=302428&view=rev
Log:
[clang-format] Convert AlignEscapedNewlinesLeft to an enum, adding
DontAlign
This converts the clang-format option AlignEscapedNewlinesLeft from a
boolean to an en
malcolm.parsons accepted this revision.
malcolm.parsons added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D32945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
Author: alexfh
Date: Mon May 8 09:17:27 2017
New Revision: 302425
URL: http://llvm.org/viewvc/llvm-project?rev=302425&view=rev
Log:
[clang-tidy] Ignore private =deleted methods in macros.
modernize-use-equals-delete is extremely noisy in code using
DISALLOW_COPY_AND_ASSIGN-style macros and there
vmiklos added a comment.
In https://reviews.llvm.org/D32945#748604, @malcolm.parsons wrote:
> Please change modernize-use-using to match.
Done.
https://reviews.llvm.org/D32945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
vmiklos updated this revision to Diff 98163.
https://reviews.llvm.org/D32945
Files:
clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
clang-tidy/modernize/UseDefaultMemberInitCheck.h
clang-tidy/modernize/UseUsingCheck.cpp
docs/clang-tidy/checks/modernize-use-default-member-init.rst
tes
aaron.ballman added inline comments.
Comment at: test/clang-tidy/cert-dcl21-cpp.cpp:1
+// RUN: %check_clang_tidy %s cert-dcl21-cpp %t
+
xazax.hun wrote:
> aaron.ballman wrote:
> > alexfh wrote:
> > > As usual, please add tests with macros and templates with multi
chenwj added a comment.
In https://reviews.llvm.org/D32759#748007, @efriedma wrote:
> The difference between returning true and false here is just the way error
> recovery works: when we return true, we know the type is invalid, so we
> suppress it, and subsequent errors involving the declarati
xazax.hun added inline comments.
Comment at: test/clang-tidy/cert-dcl21-cpp.cpp:1
+// RUN: %check_clang_tidy %s cert-dcl21-cpp %t
+
aaron.ballman wrote:
> alexfh wrote:
> > As usual, please add tests with macros and templates with multiple
> > instantiations. Wh
xazax.hun updated this revision to Diff 98162.
xazax.hun added a comment.
- Added more test cases and make them pass.
https://reviews.llvm.org/D32743
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/cert/PostfixOperatorCheck.cpp
clang-tidy/cert/Postfix
Author: bcraig
Date: Mon May 8 08:15:22 2017
New Revision: 302421
URL: http://llvm.org/viewvc/llvm-project?rev=302421&view=rev
Log:
Fix Windows tests when __config_site is present.
Previously, the force includes would complain about a missing _DEBUG symbol.
Now we dump macros before adding the fo
Author: aaronballman
Date: Mon May 8 07:39:17 2017
New Revision: 302419
URL: http://llvm.org/viewvc/llvm-project?rev=302419&view=rev
Log:
Correct the attribute spelling for guarded_var and pt_guarded_var.
Patch by Roman Lebedev.
Modified:
cfe/trunk/docs/ThreadSafetyAnalysis.rst
Modified: c
malcolm.parsons added a comment.
In https://reviews.llvm.org/D32945#748250, @vmiklos wrote:
> The updated patch uses `getLocalOrGlobal()` for the new option.
Please change modernize-use-using to match.
https://reviews.llvm.org/D32945
___
cfe-comm
malcolm.parsons added a comment.
Have you looked at the tests for clang-tidy's modernize-use-nullptr check?
I wouldn't expect to see a warning for template types:
template
class TemplateClass {
public:
explicit TemplateClass(int a, T default_value = 0) {}
};
void IgnoreSubstTempla
aaron.ballman added inline comments.
Comment at: test/clang-tidy/cert-dcl21-cpp.cpp:1
+// RUN: %check_clang_tidy %s cert-dcl21-cpp %t
+
alexfh wrote:
> As usual, please add tests with macros and templates with multiple
> instantiations. When diagnostics in macro
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302418: [X86][LWP] Add clang support for LWP instructions.
(authored by RKSimon).
Changed prior to commit:
https://reviews.llvm.org/D32770?vs=97521&id=98156#toc
Repository:
rL LLVM
https://reviews.l
Author: rksimon
Date: Mon May 8 07:09:45 2017
New Revision: 302418
URL: http://llvm.org/viewvc/llvm-project?rev=302418&view=rev
Log:
[X86][LWP] Add clang support for LWP instructions.
This patch adds support for the the LightWeight Profiling (LWP) instructions
which are available on all AMD Bul
andreadb accepted this revision.
andreadb added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D32770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
RKSimon added a comment.
ping? llvm support landed at https://reviews.llvm.org/rL302041
Repository:
rL LLVM
https://reviews.llvm.org/D32770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302411: [OpenCL] Check that global samplers are const
(authored by svenvh).
Changed prior to commit:
https://reviews.llvm.org/D32856?vs=97959&id=98143#toc
Repository:
rL LLVM
https://reviews.llvm.or
Author: svenvh
Date: Mon May 8 04:29:06 2017
New Revision: 302411
URL: http://llvm.org/viewvc/llvm-project?rev=302411&view=rev
Log:
[OpenCL] Check that global samplers are const
Patch by Simon Perretta.
Differential Revision: https://reviews.llvm.org/D32856
Modified:
cfe/trunk/include/cla
dberris updated this revision to Diff 98129.
dberris marked 6 inline comments as done.
dberris added a comment.
Address comments.
https://reviews.llvm.org/D30018
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/xray-customevent.cpp
Index: test/CodeGen/xray-
dberris added inline comments.
Comment at: lib/Headers/xrayintrin.h:28
+extern "C" {
+inline void __xray_customevent(const char*, size_t) {
+ // Does nothing by design. The intent is the compiler's back-end will handle
rnk wrote:
> I don't think you need this he
kazuhiro.yabe created this revision.
Herald added subscribers: rengolin, aemerson.
Dear all,
This patch adds the '-target' option to the clang option to invoke to
check the syntax when scan-build is called with the --analyzer-target
option.
I'm using scan-build in cross compile project. (target:
96 matches
Mail list logo
