[PATCH] D30909: [Analyzer] Finish taint propagation to derived symbols of tainted regions

vlad.tsyrklevich added inline comments. Comment at: lib/StaticAnalyzer/Core/ProgramState.cpp:656-659 + // If the SVal is a LazyCompoundVal it might only cover sub-region of a given + // symbol. For example, the LCV might represent a field in an uninitialized + // struct. In th

[PATCH] D30909: [Analyzer] Finish taint propagation to derived symbols of tainted regions

vlad.tsyrklevich updated this revision to Diff 98726. vlad.tsyrklevich marked 2 inline comments as done. vlad.tsyrklevich added a comment. Minor updates & some clarification on the feedback https://reviews.llvm.org/D30909 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h

[PATCH] D33080: [Libc++] Use #pragma push_macro/pop_macro to better handle min/max on Windows

EricWF updated this revision to Diff 98725. EricWF added a comment. - Fix missing `_LIBCPP_POP_MACROS` in `<__threading_support>`. - Add test that each header is unaffected by `min` and `max` macros and that the macros themselves are unaffected. https://reviews.llvm.org/D33080 Files: include

[PATCH] D33080: [Libc++] Use #pragma push_macro/pop_macro to better handle min/max on Windows

EricWF added a comment. In https://reviews.llvm.org/D33080#752202, @bcraig wrote: > I like the warning that you generate for min and max macros existing. Only on warn on platforms where we don't have `#pragma push_macro/pop_macro`. > Is the push_macro / pop_macro the right way to go though? Y

[PATCH] D33095: [analyzer] Avoid allocation in Std C function modelling.

xazax.hun added a comment. In https://reviews.llvm.org/D33095#752879, @NoQ wrote: > Is it an actual performance problem? Cause i think i did somehow test the > checker for performance regressions and it seemed all good. I did not measure it. Just spotted by skimming through the code. I think,

[PATCH] D33095: [analyzer] Avoid allocation in Std C function modelling.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks :o I guess i was planning for C++ support here, but never reached that far. Is it an actual performance problem? Cause i think i did the checker for performance regressions and it seemed all

[PATCH] D33092: [analyzer] Add checker to model builtin functions

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thanks! Comment at: lib/StaticAnalyzer/Checkers/BuiltinFunctionChecker.cpp:51 +state = state->assume(ArgSVal.castAs(), true); +// FIXME: do we want to warn here? +

[libcxx] r302871 - Fix C++03 test failures caused by static_assert emulation

Author: ericwf Date: Thu May 11 22:53:56 2017 New Revision: 302871 URL: http://llvm.org/viewvc/llvm-project?rev=302871&view=rev Log: Fix C++03 test failures caused by static_assert emulation Modified: libcxx/trunk/test/std/localization/locales/locale.convenience/conversions/conversions.strin

[libcxx] r302870 - Cleanup test issues reported by STL @ Microsoft.

Author: ericwf Date: Thu May 11 22:38:28 2017 New Revision: 302870 URL: http://llvm.org/viewvc/llvm-project?rev=302870&view=rev Log: Cleanup test issues reported by STL @ Microsoft. This patch cleans up a number of issues reported by STL, including: 1) Fix duplicate is_convertible test. 2) Move

[libcxx] r302869 - Remove non-standard basic_string_view::clear() member.

Author: ericwf Date: Thu May 11 22:35:53 2017 New Revision: 302869 URL: http://llvm.org/viewvc/llvm-project?rev=302869&view=rev Log: Remove non-standard basic_string_view::clear() member. This patch removes the clear() member from . The modifier was removed from the TS before it ever landed in th

[libcxx] r302865 - Move POSIX specific test under test/libcxx subdirectory

Author: ericwf Date: Thu May 11 21:02:09 2017 New Revision: 302865 URL: http://llvm.org/viewvc/llvm-project?rev=302865&view=rev Log: Move POSIX specific test under test/libcxx subdirectory Added: libcxx/trunk/test/libcxx/thread/thread.condition/PR30202_notify_from_pthread_created_thread.pass

Re: r302835 - Issue diagnostics when returning FP values on x86_64 without SSE1/2

Re add list On May 11, 2017 7:03 PM, "Reid Kleckner" wrote: > The mailer divides patches by repo: llvm, cfe, compiler-rt, and this patch > spanned clang and llvm. I'm living in the monorepo future. 😀 > > On May 11, 2017 6:46 PM, "Nico Weber" wrote: > >> The inline snippet doesn't show the actua

[libcxx] r302864 - Move tests for libc++ configurations into libcxx/ test subdirectory

Author: ericwf Date: Thu May 11 20:49:32 2017 New Revision: 302864 URL: http://llvm.org/viewvc/llvm-project?rev=302864&view=rev Log: Move tests for libc++ configurations into libcxx/ test subdirectory Added: libcxx/trunk/test/libcxx/input.output/file.streams/c.files/no.global.filesystem.name

[libcxx] r302862 - Fix or move tests with non-standard assumptions

Author: ericwf Date: Thu May 11 20:44:51 2017 New Revision: 302862 URL: http://llvm.org/viewvc/llvm-project?rev=302862&view=rev Log: Fix or move tests with non-standard assumptions Added: libcxx/trunk/test/libcxx/thread/thread.threads/thread.thread.this/ libcxx/trunk/test/libcxx/thread/t

Re: r302835 - Issue diagnostics when returning FP values on x86_64 without SSE1/2

The inline snippet doesn't show the actual code change, but http://llvm.org/viewvc/llvm-project?view=revision&revision=302835 does show it. Is the email sender broken? On Thu, May 11, 2017 at 6:43 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Thu May

[libcxx] r302859 - Guard usage of libc++ regex internals inside test.

Author: ericwf Date: Thu May 11 20:19:01 2017 New Revision: 302859 URL: http://llvm.org/viewvc/llvm-project?rev=302859&view=rev Log: Guard usage of libc++ regex internals inside test. This patch attempts to make lookup_classname.pass.cpp usable against other STL implementations by guarding the us

[PATCH] D33103: [clang-tidy] TwineLocalCheck: add param # checking

chh added a comment. LGTM. Leave approval to bkramer. https://reviews.llvm.org/D33103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33103: [clang-tidy] TwineLocalCheck: add param # checking

yawanng updated this revision to Diff 98705. yawanng added a comment. Add more tests. https://reviews.llvm.org/D33103 Files: clang-tidy/llvm/TwineLocalCheck.cpp test/clang-tidy/llvm-twine-local.cpp Index: test/clang-tidy/llvm-twine-local.cpp ===

[PATCH] D33061: [tooling] RefactoringCallbacks code cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit rL302855: [tooling] RefactoringCallbacks code cleanup (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D33061?vs=98509&id=98704#toc Repository: rL LLVM https://reviews.llvm.or

r302855 - [tooling] RefactoringCallbacks code cleanup

Author: alexshap Date: Thu May 11 19:16:56 2017 New Revision: 302855 URL: http://llvm.org/viewvc/llvm-project?rev=302855&view=rev Log: [tooling] RefactoringCallbacks code cleanup This diff 1. adds missing "explicit" for single argument constructors 2. adds missing std::move in ReplaceNodeWithTe

r302854 - Fix uninitialized bool read causing x86_64-mno-sse.c test failure

Author: rnk Date: Thu May 11 19:10:49 2017 New Revision: 302854 URL: http://llvm.org/viewvc/llvm-project?rev=302854&view=rev Log: Fix uninitialized bool read causing x86_64-mno-sse.c test failure Modified: cfe/trunk/lib/CodeGen/CodeGenAction.cpp Modified: cfe/trunk/lib/CodeGen/CodeGenAction.

Re: r302840 - Module Debug Info: Emit namespaced C++ forward decls in the correct module.

> On May 11, 2017, at 4:43 PM, Richard Smith wrote: > > On 11 May 2017 at 15:59, Adrian Prantl via cfe-commits > wrote: > Author: adrian > Date: Thu May 11 17:59:19 2017 > New Revision: 302840 > > URL: http://llvm.org/viewvc/llvm-project?rev=302840&view=rev > Log: > Module Debug Info: Emit na

[PATCH] D32178: Delete unstable integration tests

rsmith added a comment. Clang's regression test suite is not a sensible home for these tests. We should have a home and a plan for system-specific integration tests, but this is not it. Perhaps this should instead be a part of LNT / the test-suite project? https://reviews.llvm.org/D32178 __

Re: r302840 - Module Debug Info: Emit namespaced C++ forward decls in the correct module.

On 11 May 2017 at 15:59, Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: adrian > Date: Thu May 11 17:59:19 2017 > New Revision: 302840 > > URL: http://llvm.org/viewvc/llvm-project?rev=302840&view=rev > Log: > Module Debug Info: Emit namespaced C++ forward decls in the

[PATCH] D33109: Enhance synchscope representation (clang)

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D33109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D33109: Enhance synchscope representation (clang)

kzhuravl created this revision. Herald added a subscriber: wdng. https://reviews.llvm.org/D33109 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/ms-barriers-intrinsics.c Index: test/CodeGen/ms-barriers-intrinsics.c === --- test/Co

[PATCH] D32248: CodeGen: Cast alloca to expected address space

rjmccall added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7291 + Address adjustAddrSpaceForAutoVar(Address A, const VarDecl *VD, + CodeGen::CodeGenFunction &CGF) const override; }; yaxunl wrote: > rjmccall wrote: > > yaxunl wrote: > > > rjmcca

[PATCH] D32178: Delete unstable integration tests

jroelofs added a comment. ping @arphaman https://reviews.llvm.org/D32178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r302842 - Remove unnecessary mapping from SourceLocation to Module.

Author: rsmith Date: Thu May 11 18:11:16 2017 New Revision: 302842 URL: http://llvm.org/viewvc/llvm-project?rev=302842&view=rev Log: Remove unnecessary mapping from SourceLocation to Module. When we parse a redefinition of an entity for which we have a hidden existing declaration, make it visible

[libcxx] r302841 - Fix XFAIL to reflect recent fixes in GCC

Author: ericwf Date: Thu May 11 18:04:04 2017 New Revision: 302841 URL: http://llvm.org/viewvc/llvm-project?rev=302841&view=rev Log: Fix XFAIL to reflect recent fixes in GCC Modified: libcxx/trunk/test/std/experimental/utilities/meta/meta.type.synop/meta.unary.prop.pass.cpp Modified: libcx

r302840 - Module Debug Info: Emit namespaced C++ forward decls in the correct module.

Author: adrian Date: Thu May 11 17:59:19 2017 New Revision: 302840 URL: http://llvm.org/viewvc/llvm-project?rev=302840&view=rev Log: Module Debug Info: Emit namespaced C++ forward decls in the correct module. The AST merges NamespaceDecls, but for module debug info it is important to put a namesp

r302835 - Issue diagnostics when returning FP values on x86_64 without SSE1/2

Author: rnk Date: Thu May 11 17:43:02 2017 New Revision: 302835 URL: http://llvm.org/viewvc/llvm-project?rev=302835&view=rev Log: Issue diagnostics when returning FP values on x86_64 without SSE1/2 Avoid using report_fatal_error, because it will ask the user to file a bug. If the user attempts to

Re: r302817 - PR22877: When constructing an array via a constructor with a default argument

Looks like we'd want something like this: Index: lib/CodeGen/TargetInfo.cpp === --- lib/CodeGen/TargetInfo.cpp (revision 302818) +++ lib/CodeGen/TargetInfo.cpp (working copy) @@ -7043,13 +7043,13 @@ ABIArgInfo::getExten

[PATCH] D33103: [clang-tidy] TwineLocalCheck: add param # checking

yawanng updated this revision to Diff 98684. https://reviews.llvm.org/D33103 Files: clang-tidy/llvm/TwineLocalCheck.cpp test/clang-tidy/llvm-twine-local.cpp Index: test/clang-tidy/llvm-twine-local.cpp === --- test/clang-tidy/ll

Re: r302817 - PR22877: When constructing an array via a constructor with a default argument

XFAIL'd for hexagon in r302825, filed PR33009 for the miscompile. Looks like it's only passing empty structs in C++ that is miscompiled, but that's still pretty serious. On 11 May 2017 at 14:30, Richard Smith wrote: > Wow, the Hexagon target is just horribly broken. Reduced testcase: > > struct

r302825 - XFAIL this test for Hexagon.

Author: rsmith Date: Thu May 11 16:18:27 2017 New Revision: 302825 URL: http://llvm.org/viewvc/llvm-project?rev=302825&view=rev Log: XFAIL this test for Hexagon. It's failing due to Hexagon calling convention lowering being broken (empty structs are not passed even if they have nontrivial destruc

Re: r302817 - PR22877: When constructing an array via a constructor with a default argument

Wow, the Hexagon target is just horribly broken. Reduced testcase: struct A { A(); A(const A&); ~A(); }; void f(A a); void g() { f(A()); } This completely fails to pass an A object to f. Instrumented version: #include #define DUMP(ptr) printf("%s %p\\n", __PRETTY_FUNCTION__, ptr) struct A {

[libcxxabi] r302824 - [Libcxxabi]: Support using compiler-rt for MinGW64

Author: martell Date: Thu May 11 16:16:29 2017 New Revision: 302824 URL: http://llvm.org/viewvc/llvm-project?rev=302824&view=rev Log: [Libcxxabi]: Support using compiler-rt for MinGW64 Reviewers: EricWF Differential Revision: https://reviews.llvm.org/D33098 Modified: libcxxabi/trunk/cmake/c

[PATCH] D32248: CodeGen: Cast alloca to expected address space

yaxunl added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7291 + Address adjustAddrSpaceForAutoVar(Address A, const VarDecl *VD, + CodeGen::CodeGenFunction &CGF) const override; }; rjmccall wrote: > yaxunl wrote: > > rjmccall wrote: > > > How ab

Re: r302817 - PR22877: When constructing an array via a constructor with a default argument

Hexagon is still broken. :( http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/7942 -Krzysztof On 5/11/2017 1:58 PM, Richard Smith via cfe-commits wrote: Author: rsmith Date: Thu May 11 13:58:24 2017 New Revision: 302817 URL: http://llvm.org/viewvc/llvm-project?rev=302817&view=rev Lo

r302818 - Work around different -std= default for PS4 target.

Author: rsmith Date: Thu May 11 14:17:54 2017 New Revision: 302818 URL: http://llvm.org/viewvc/llvm-project?rev=302818&view=rev Log: Work around different -std= default for PS4 target. Modified: cfe/trunk/test/CodeGenCXX/array-default-argument.cpp Modified: cfe/trunk/test/CodeGenCXX/array-de

Re: r302750 - PR22877: When constructing an array via a constructor with a default argument

Thanks for the revert, fixed up and recommitted in r302817. Any idea why not a single buildbot sent me any email about this? :( (A couple of them were red at the previous change too, but some of them were not (eg. clang-cmake-armv7-a15). On 11 May 2017 at 01:28, Diana Picus wrote: > Hexagon too

r302817 - PR22877: When constructing an array via a constructor with a default argument

Author: rsmith Date: Thu May 11 13:58:24 2017 New Revision: 302817 URL: http://llvm.org/viewvc/llvm-project?rev=302817&view=rev Log: PR22877: When constructing an array via a constructor with a default argument in list-initialization, run cleanups for the default argument after each iteration of t

[PATCH] D30949: [CodeGen] Add an option to enable LLVM IR linting

vsk abandoned this revision. vsk added a comment. I'll try doing this some other way, maybe with optimization remarks. https://reviews.llvm.org/D30949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D32690: [clang-tidy] modernize-use-emplace: Remove unnecessary make_tuple calls

JDevlieghere added a comment. No comments from me either, looks good! https://reviews.llvm.org/D32690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32248: CodeGen: Cast alloca to expected address space

rjmccall added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7291 + Address adjustAddrSpaceForAutoVar(Address A, const VarDecl *VD, + CodeGen::CodeGenFunction &CGF) const override; }; yaxunl wrote: > rjmccall wrote: > > How about, instead of intr

r302809 - Add a test that local submodule visibility has no effect on debug info

Author: adrian Date: Thu May 11 11:40:48 2017 New Revision: 302809 URL: http://llvm.org/viewvc/llvm-project?rev=302809&view=rev Log: Add a test that local submodule visibility has no effect on debug info rdar://problem/27876262 Modified: cfe/trunk/test/Modules/DebugInfoSubmoduleImport.c Mod

Re: [PATCH v2] [PPC64]: Add support for Swift calling convention

Thanks, with the testcase this LGTM! -- adrian > On May 11, 2017, at 12:07 AM, Andrew Jeffery wrote: > > Ping - does anyone have a moment to take a look? > > Cheers, > > Andrew > > On Thu, 2017-04-27 at 13:52 +0930, Andrew Jeffery wrote: >> For the tests I've extracted the int5 and int8 cases

[PATCH] D33047: [ClangD] Refactor clangd into separate components

ilya-biryukov added inline comments. Comment at: clangd/ClangdMain.cpp:41 // dispatching. - DocumentStore Store; - ASTManager AST(Out, Store, RunSynchronously); - Store.addListener(&AST); + ClangdLSPServer AST(Out, RunSynchronously); JSONRPCDispatcher Dispatcher(llvm::m

[PATCH] D33010: Make google-build-using-namespace skip std::.*literals

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/google/UsingNamespaceDirectiveCheck.cpp:43 + if (StandardLiteralsNamespaceRE.match( + U->getNominatedNamespace()->getQualifiedN

[PATCH] D33047: [ClangD] Refactor clangd into separate components

ilya-biryukov updated this revision to Diff 98634. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. Addressed style comments. Moved ClangdScheduler to be the last field of the ClangdServer, so that it's constructed last and destructed first. https://reviews.llvm.org

[PATCH] D33082: Fix Libc++ build with MinGW64

bcraig added a comment. I agree that we need to be precise in our platform detection macros. On Windows, we currently need to worry about which compiler is being used, whether we are targeting the mingw environment or the native (?) environment, and which c-runtime is being used. For my msvc-

[PATCH] D32248: CodeGen: Cast alloca to expected address space

yaxunl added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7291 + Address adjustAddrSpaceForAutoVar(Address A, const VarDecl *VD, + CodeGen::CodeGenFunction &CGF) const override; }; rjmccall wrote: > How about, instead of introducing a second met

[libcxx] r302802 - Mark LWG#2782 as complete. No functionality change; we already do this. Just added a few more tests.

Author: marshall Date: Thu May 11 09:25:45 2017 New Revision: 302802 URL: http://llvm.org/viewvc/llvm-project?rev=302802&view=rev Log: Mark LWG#2782 as complete. No functionality change; we already do this. Just added a few more tests. Modified: libcxx/trunk/test/std/utilities/allocator.ada

[libcxx] r302800 - Replace a nested namespace used for overload resolution with a struct. Richard Smith says that using the namespace results in an ODR violation, but I disagree. Nevertheless, the str

Author: marshall Date: Thu May 11 09:00:54 2017 New Revision: 302800 URL: http://llvm.org/viewvc/llvm-project?rev=302800&view=rev Log: Replace a nested namespace used for overload resolution with a struct. Richard Smith says that using the namespace results in an ODR violation, but I disagree. N

[libcxx] r302799 - Mark LWG#2850 as complete. No functionality change; we had tests that covered it already. Just added comments to the tests. Thanks to K-ballo for the heads up.

Author: marshall Date: Thu May 11 08:55:20 2017 New Revision: 302799 URL: http://llvm.org/viewvc/llvm-project?rev=302799&view=rev Log: Mark LWG#2850 as complete. No functionality change; we had tests that covered it already. Just added comments to the tests. Thanks to K-ballo for the heads up.

[libcxx] r302798 - Mark LWG#2796 as complete. No functionality change; we had tests that covered it already. Just added comments to the tests

Author: marshall Date: Thu May 11 08:51:09 2017 New Revision: 302798 URL: http://llvm.org/viewvc/llvm-project?rev=302798&view=rev Log: Mark LWG#2796 as complete. No functionality change; we had tests that covered it already. Just added comments to the tests Modified: libcxx/trunk/test/std/ut

r302797 - [CodeCompletion] Provide member completions for dependent expressions whose

Author: arphaman Date: Thu May 11 08:48:57 2017 New Revision: 302797 URL: http://llvm.org/viewvc/llvm-project?rev=302797&view=rev Log: [CodeCompletion] Provide member completions for dependent expressions whose type is a TemplateSpecializationType or InjectedClassNameType Fixes PR30847. Partially

r302796 - [CodeCompletion] NFC, extract a function that generates member

Author: arphaman Date: Thu May 11 08:41:00 2017 New Revision: 302796 URL: http://llvm.org/viewvc/llvm-project?rev=302796&view=rev Log: [CodeCompletion] NFC, extract a function that generates member completion results for records Modified: cfe/trunk/lib/Sema/SemaCodeComplete.cpp Modified: cfe

Re: Fix two-stage build on windows using DistributionExample cmake cache

Thanks a lot! On Thu, May 11, 2017 at 4:32 PM, NAKAMURA Takumi wrote: > Applied in r302795. > > On Thu, May 11, 2017 at 9:51 PM Chris Bieneman via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Normally I would be happy to, but I'm actually at the airport about to >> board a flight and

[PATCH] D33047: [ClangD] Refactor clangd into separate components

krasimir added inline comments. Comment at: clangd/CMakeLists.txt:12 ProtocolHandlers.cpp ) nit: we might want to keep these sorted Comment at: clangd/ClangdMain.cpp:41 // dispatching. - DocumentStore Store; - ASTManager AST(Out, S

[PATCH] D33094: [ASTMatchers] Add equals support for integer and boolean literals

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3827 +/// \brief Instantiations for the \c equals matcher. +/// TODO add support for FloatingLiteral and CharacterLiteral +/// @{ Lekensteyn wrote: > aaron.ballman wrote: > >

[PATCH] D33080: [Libc++] Use #pragma push_macro/pop_macro to better handle min/max on Windows

bcraig added a comment. I like the warning that you generate for min and max macros existing. Is the push_macro / pop_macro the right way to go though? You could throw extra parenthesis around the declaration and usages of min/max to avoid macro expansion. #define add(x,y) (x)-(y) tem

Re: Fix two-stage build on windows using DistributionExample cmake cache

Applied in r302795. On Thu, May 11, 2017 at 9:51 PM Chris Bieneman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Normally I would be happy to, but I'm actually at the airport about to > board a flight and won't have reliable internet access for at least the > next 24 hours. > > Can someo

r302795 - Fix two-stage build on windows using DistributionExample cmake cache

Author: chapuni Date: Thu May 11 08:19:24 2017 New Revision: 302795 URL: http://llvm.org/viewvc/llvm-project?rev=302795&view=rev Log: Fix two-stage build on windows using DistributionExample cmake cache Thanks to Matthew Larionov Modified: cfe/trunk/CMakeLists.txt cfe/trunk/cmake/caches

[PATCH] D33094: [ASTMatchers] Add equals support for integer and boolean literals

Lekensteyn added a comment. In https://reviews.llvm.org/D33094#752153, @aaron.ballman wrote: > Please be sure to regenerate the AST matcher documentation as well by running > clang/docs/tools/dump_ast_matchers.py Will do, thanks for the hint. Comment at: include/clang/ASTMa

[PATCH] D33093: [ASTMatchers] Add support for boolean literals

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D33093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D33094: [ASTMatchers] Add equals support for integer and boolean literals

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Please be sure to regenerate the AST matcher documentation as well by running clang/docs/tools/dump_ast_matchers.py Comment at: include/clang/ASTMatchers/ASTMatchers.h:3827 +/// \brief Instantiations

Re: Fix two-stage build on windows using DistributionExample cmake cache

Normally I would be happy to, but I'm actually at the airport about to board a flight and won't have reliable internet access for at least the next 24 hours. Can someone else land this for Matthew? Matthew, if nobody responds in email, try hopping onto LLVM's IRC channel. Thanks, -Chris > On M

[PATCH] D30896: [Clang-tidy] add check misc-prefer-switch-for-enums

alexfh requested changes to this revision. alexfh added a comment. In https://reviews.llvm.org/D30896#703046, @jbcoe wrote: > I think that clang-tidy allows case-specific subsetting of C++. It is said > that C++ contains a beautiful language and I've found that definition of > beauty to be very

[PATCH] D33095: [analyzer] Avoid allocation in Std C function modelling.

xazax.hun created this revision. Herald added a subscriber: whisperity. Avoid an allocation in modelling Std C functions to improve the performance. Repository: rL LLVM https://reviews.llvm.org/D33095 Files: lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp Index: lib/StaticAnal

[PATCH] D33092: [analyzer] Add checker to model builtin functions

xazax.hun added a comment. In https://reviews.llvm.org/D33092#752039, @NoQ wrote: > Hmm, shouldn't this be part of `BuiltinFunctionChecker` aka > `core.builtin.BuiltinFunctions`? We already have `__builtin_assume_aligned` > here (though it doesn't seem to assume anything because that particular

[PATCH] D33092: [analyzer] Add checker to model builtin functions

xazax.hun updated this revision to Diff 98609. xazax.hun marked an inline comment as done. xazax.hun edited the summary of this revision. xazax.hun added a comment. - Move this to the right checker. https://reviews.llvm.org/D33092 Files: lib/StaticAnalyzer/Checkers/BuiltinFunctionChecker.cpp

[PATCH] D33094: [ASTMatchers] Add equals support for integer and boolean literals

Lekensteyn created this revision. This allows the clang-query tool to use matchers like "integerLiteral(equals(32))". The equals function is a template, so some special trickery is needed. https://reviews.llvm.org/D33094 Files: include/clang/ASTMatchers/ASTMatchers.h include/clang/ASTMatche

[PATCH] D33093: [ASTMatchers] Add support for boolean literals

Lekensteyn created this revision. Recognize boolean literals for future extensions ("equals(true)"). Note that a specific VariantValue constructor is added to resolve ambiguity (like "Value = 5") between unsigned and bool. --- Passes clang-test

[PATCH] D33047: [ClangD] Refactor clangd into separate components

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.h:23 + +class ClangdLSPServer { + class LSPDiagnosticsConsumer; klimek wrote: > I'd have expected something that's called LSP server to work on the LSP > protocol level (that is, have a ser

[PATCH] D33047: [ClangD] Refactor clangd into separate components

ilya-biryukov updated this revision to Diff 98606. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. Addressed review comments https://reviews.llvm.org/D33047 Files: clangd/ASTManager.cpp clangd/ASTManager.h clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp

Re: Fix two-stage build on windows using DistributionExample cmake cache

Unfortunately I don't have commit rights. Could you please land it for me? On Thu, May 11, 2017 at 1:28 PM, Chris Bieneman wrote: > This patch LGTM! > > Thanks! > -Chris > > On May 11, 2017, at 3:13 AM, Matthew Larionov > wrote: > > Chris, Hi! Could you please take a look at my patch? > Or advi

Re: Fix two-stage build on windows using DistributionExample cmake cache

This patch LGTM! Thanks! -Chris > On May 11, 2017, at 3:13 AM, Matthew Larionov wrote: > > Chris, Hi! Could you please take a look at my patch? > Or advice someone who could. > > On Wed, May 3, 2017 at 8:28 PM, Matthew Larionov > wrote: > I've added a correct comp

Re: Fix two-stage build on windows using DistributionExample cmake cache

Chris, Hi! Could you please take a look at my patch? Or advice someone who could. On Wed, May 3, 2017 at 8:28 PM, Matthew Larionov wrote: > I've added a correct compiler name for bootstrap builds on windows. > Also added an opportunity to override stage2 cache file to make > distribution example

[PATCH] D33092: [analyzer] Add checker to model builtin functions

NoQ added a comment. Hmm, shouldn't this be part of `BuiltinFunctionChecker` aka `core.builtin.BuiltinFunctions`? We already have `__builtin_assume_aligned` here (though it doesn't seem to assume anything because that particular assumption is hard to model). Comment at: lib/

[PATCH] D33092: [analyzer] Add checker to model builtin functions

xazax.hun created this revision. Herald added subscribers: whisperity, mgorny. I added a checker to model builtin functions. Only one builtin function is modelled so far. The motivation behind using `__builtin_assume` from the analyzers point of view is to add assumptions. The conventional way t

[PATCH] D33080: [Libc++] Use #pragma push_macro/pop_macro to better handle min/max on Windows

EricWF added inline comments. Comment at: include/__threading_support:632 #endif // _LIBCPP_HAS_THREAD_API_PTHREAD #endif // !_LIBCPP_HAS_THREAD_LIBRARY_EXTERNAL || _LIBCPP_BUILDING_THREAD_LIBRARY_EXTERNAL Missing _LIBCPP_POP_MACROS https://reviews.llvm.or

[PATCH] D33047: [ClangD] Refactor clangd into separate components

klimek added inline comments. Comment at: clangd/ClangdLSPServer.h:23 + +class ClangdLSPServer { + class LSPDiagnosticsConsumer; I'd have expected something that's called LSP server to work on the LSP protocol level (that is, have a server(iostream) equivalent

Re: r302777 - Reverted r302775

Sorry. I have to investigate a fail in clang-tidy. Thanks, --Serge 2017-05-11 15:43 GMT+07:00 Richard Smith : > When you revert a patch (even one of your own), please say why you > reverted it in the commit message. > > > On 11 May 2017 1:38 am, "Serge Pavlov via cfe-commits" < > cfe-commits@lis

Re: r302777 - Reverted r302775

When you revert a patch (even one of your own), please say why you reverted it in the commit message. On 11 May 2017 1:38 am, "Serge Pavlov via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Author: sepavloff Date: Thu May 11 03:25:22 2017 New Revision: 302777 URL: http://llvm.org/viewvc/llvm

r302777 - Reverted r302775

Author: sepavloff Date: Thu May 11 03:25:22 2017 New Revision: 302777 URL: http://llvm.org/viewvc/llvm-project?rev=302777&view=rev Log: Reverted r302775 Added: cfe/trunk/test/Driver/arm-darwin-builtin.c - copied unchanged from r302774, cfe/trunk/test/Driver/arm-darwin-builtin.c Modifie

Re: r302750 - PR22877: When constructing an array via a constructor with a default argument

Hexagon too: http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/7916 On 11 May 2017 at 10:27, Diana Picus wrote: > Hi Richard, > > I reverted this and its fixup in r302776 since some of the ARM bots > were still broken: > http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/6969

Re: r302750 - PR22877: When constructing an array via a constructor with a default argument

Hi Richard, I reverted this and its fixup in r302776 since some of the ARM bots were still broken: http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/6969 http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15/builds/6959 http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/

r302776 - Revert "PR22877: When constructing an array via a constructor with a default argument in list-initialization, run cleanups for the default argument after each iteration of the initialization

Author: rovka Date: Thu May 11 03:10:41 2017 New Revision: 302776 URL: http://llvm.org/viewvc/llvm-project?rev=302776&view=rev Log: Revert "PR22877: When constructing an array via a constructor with a default argument in list-initialization, run cleanups for the default argument after each itera

[PATCH] D32825: [clang-format] Improve understanding of combined typedef+record declarations

jtbandes updated this revision to Diff 98593. jtbandes added a comment. Update from review https://reviews.llvm.org/D32825 Files: lib/Format/UnwrappedLineFormatter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ==

[PATCH] D32825: [clang-format] Improve understanding of combined typedef+record declarations

jtbandes marked an inline comment as done. jtbandes added inline comments. Comment at: lib/Format/UnwrappedLineFormatter.cpp:368 // We don't merge short records. - if (Line.First->isOneOf(tok::kw_class, tok::kw_union, tok::kw_struct, - Key

r302775 - Driver must return non-zero code on errors in command line

Author: sepavloff Date: Thu May 11 03:00:33 2017 New Revision: 302775 URL: http://llvm.org/viewvc/llvm-project?rev=302775&view=rev Log: Driver must return non-zero code on errors in command line Now if clang driver is given wrong arguments, in some cases it continues execution and returns zero co

[PATCH] D33013: Driver must return non-zero code on errors in command line

This revision was automatically updated to reflect the committed changes. Closed by commit rL302775: Driver must return non-zero code on errors in command line (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D33013?vs=98395&id=98592#toc Repository: rL LLVM https:/

[PATCH] D33061: [tooling] RefactoringCallbacks code cleanup

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D33061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[libcxx] r302773 - Fix `std::visit` for the zero variants case.

Author: mpark Date: Thu May 11 02:17:12 2017 New Revision: 302773 URL: http://llvm.org/viewvc/llvm-project?rev=302773&view=rev Log: Fix `std::visit` for the zero variants case. Summary: The following code is broken: ``` std::visit([]{}); ``` Reviewers: EricWF Reviewed By: EricWF Different

r302771 - Make tests from r302765 windows friendly

Author: bruno Date: Thu May 11 02:06:52 2017 New Revision: 302771 URL: http://llvm.org/viewvc/llvm-project?rev=302771&view=rev Log: Make tests from r302765 windows friendly and appease: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/2030 Modified: cfe/trunk/t

Re: [PATCH v2] [PPC64]: Add support for Swift calling convention

Ping - does anyone have a moment to take a look? Cheers, Andrew On Thu, 2017-04-27 at 13:52 +0930, Andrew Jeffery wrote: > For the tests I've extracted the int5 and int8 cases to cater for > different alignments for different platform ABIs. For Linux on POWER the > 5 and 8 element vectors must b