[PATCH] D33639: [OpenCL] Use SPIR_CC by default for kernels

pekka.jaaskelainen closed this revision. pekka.jaaskelainen marked 4 inline comments as done. pekka.jaaskelainen added a comment. Committed in r304389. Comment at: lib/CodeGen/TargetInfo.cpp:400 unsigned TargetCodeGenInfo::getOpenCLKernelCallingConv() const { + // OpenCL ke

r304391 - Adapt tests after making mcpu=generic the default for armv7-a and armv8-a.

Author: kbeyls Date: Thu Jun 1 02:31:50 2017 New Revision: 304391 URL: http://llvm.org/viewvc/llvm-project?rev=304391&view=rev Log: Adapt tests after making mcpu=generic the default for armv7-a and armv8-a. Modified: cfe/trunk/test/Driver/arm-cortex-cpus.c cfe/trunk/test/Driver/gold-lto.

r304389 - [OpenCL] Makes kernels use the SPIR_KERNEL CC by default.

Author: pjaaskel Date: Thu Jun 1 02:18:49 2017 New Revision: 304389 URL: http://llvm.org/viewvc/llvm-project?rev=304389&view=rev Log: [OpenCL] Makes kernels use the SPIR_KERNEL CC by default. Rationale: OpenCL kernels are called via an explicit runtime API with arguments set with clSetKernelArg(

[PATCH] D33398: Mangle __unaligned in Itanium ABI

rogfer01 updated this revision to Diff 100974. rogfer01 added a comment. Changelog: - Fix formatting. - Emit `__unaligned` in the right order (as defined by the Itanium ABI) when there are Objective-C++ ARC vendor qualifiers. - New test for `__unaligned` and ARC's `__weak`, `__strong` and `__aut

[PATCH] D33398: Mangle __unaligned in Itanium ABI

rogfer01 added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:2210 + if (Quals.hasUnaligned()) + mangleVendorQualifier("__unaligned"); + rsmith wrote: > Too much indentation here. Also, the ABI requires the "unordered" vendor > qualifiers to be emi

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

chrib added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:569 + if (Triple.getEnvironment() == llvm::Triple::EABI) { +switch (Triple.getArch()) { efriedma wrote: > Specifically checking for "llvm::Triple::EABI" is suspicious... what are you

[PATCH] D33437: Emit available_externally vtables opportunistically

This revision was automatically updated to reflect the committed changes. Closed by commit rL304394: Emit available_externally vtables opportunistically (authored by Prazek). Changed prior to commit: https://reviews.llvm.org/D33437?vs=100641&id=100976#toc Repository: rL LLVM https://reviews

r304394 - Emit available_externally vtables opportunistically

Author: prazek Date: Thu Jun 1 03:04:05 2017 New Revision: 304394 URL: http://llvm.org/viewvc/llvm-project?rev=304394&view=rev Log: Emit available_externally vtables opportunistically Summary: We can emit vtable definition having inline function if they are all emitted. Reviewers: rjmccall, rsm

[PATCH] D33412: Add support for #pragma clang section

rogfer01 added a comment. After the docs update this looks good to me. @rnk @jroelofs what do you think? Thanks! https://reviews.llvm.org/D33412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D31830: Emit invariant.group.barrier when using union field

Prazek updated this revision to Diff 100977. Prazek marked an inline comment as done. Prazek added a comment. Extra test https://reviews.llvm.org/D31830 Files: lib/CodeGen/CGExpr.cpp test/CodeGenCXX/strict-vtable-pointers.cpp Index: test/CodeGenCXX/strict-vtable-pointers.cpp ==

r304397 - Fixed warnings

Author: prazek Date: Thu Jun 1 04:24:36 2017 New Revision: 304397 URL: http://llvm.org/viewvc/llvm-project?rev=304397&view=rev Log: Fixed warnings Modified: cfe/trunk/include/clang/AST/VTableBuilder.h cfe/trunk/lib/CodeGen/CodeGenModule.cpp Modified: cfe/trunk/include/clang/AST/VTableBu

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

schroedersi added a comment. Ping :) https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33765: Show correct column nr. when multi-byte utf8 chars are used.

erikjv created this revision. Previously, the column number in a diagnostic would be the byte position in the line. This results in incorrect column numbers when a multi-byte UTF-8 character would be present in the input. By ignoring all bytes starting with 0b10 the correct column number is cr

[PATCH] D33721: [ARM] Add support for target("arm") and target("thumb").

fhahn updated this revision to Diff 100994. fhahn added a comment. Agreed, ARMTargetInfo is a much better place to do the conversion! Moved attribute conversion to ARMTargetInfo::initFeatureMap. Unfortunately FeaturesVec is const, so creating a mutable clone seemed the most straight-forward thi

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

krasimir added a comment. I think that what you're trying to solve is not practically that important, is unlikely to improve the handling of comments, and will add a lot of complexity. From a usability perspective, I think that people are happy enough when their comments don't exceed the line l

[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

NoQ added a comment. I have just one comment and i think it'd be good to land. Comment at: lib/StaticAnalyzer/Core/CheckerHelpers.cpp:104 + ProgramStateManager &Mgr = State->getStateManager(); + if (!LHSVal.getAs() && LHSVal.getAs()) { +LHSVal = Mgr.getStoreManager().getB

[PATCH] D30489: [analyzer] catch out of bounds for VLA

NoQ added a comment. An idea. I believe the safest way to find the bugs you mentioned would be to replace extent-as-a-symbol with extent-as-a-trait. I.e., currently we construct `extent_$3{SymRegion{conj_$1{char *}}}`, assume that it is equal to `reg_$0` (which produces a `SymSymExpr`) and then

[PATCH] D30489: [analyzer] catch out of bounds for VLA

xazax.hun added a comment. In https://reviews.llvm.org/D30489#769916, @NoQ wrote: > An idea. I believe the safest way to find the bugs you mentioned would be to > replace extent-as-a-symbol with extent-as-a-trait. > > I.e., currently we construct `extent_$3{SymRegion{conj_$1{char *}}}`, assume

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

NoQ added a comment. The code looks good now! A few minor comments and we can commit this :) Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:2010 + const Expr *Mem = CE->getArg(0); + const Expr *Const = CE->getArg(1); + const Expr *Size = CE->getArg(2); --

r304408 - Make the clang-cl test less restrictive.

Author: alexfh Date: Thu Jun 1 06:41:21 2017 New Revision: 304408 URL: http://llvm.org/viewvc/llvm-project?rev=304408&view=rev Log: Make the clang-cl test less restrictive. Make the test less restrictive to allow directory layout used in our test setup. Modified: cfe/trunk/test/Driver/cl-in

r304396 - [OpenCL] spir_kern by defaul: fix old test cases

Author: pjaaskel Date: Thu Jun 1 03:19:43 2017 New Revision: 304396 URL: http://llvm.org/viewvc/llvm-project?rev=304396&view=rev Log: [OpenCL] spir_kern by defaul: fix old test cases Modified: cfe/trunk/test/CodeGenOpenCL/bool_cast.cl cfe/trunk/test/CodeGenOpenCL/kernel-attributes.cl

[PATCH] D33401: [mips] Add runtime options to enable/disable generation of madd.fmt, msub.fmt

smaksimovic updated this revision to Diff 101010. smaksimovic added a comment. Changed feature name from madd4 to nomadd4 to reflect the change from the dependency. Added macro definition when +nomadd4 is present. https://reviews.llvm.org/D33401 Files: include/clang/Driver/Options.td lib/B

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai added a comment. Hi Artem, Long time no see! miss you :) I will update my patch next Thursday! I am doing my work assignment about L4 right now. Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/

Re: r304346 - [modules] When compiling a preprocessed module map, look for headers relative

Hi Richard, This broke the tests on the Windows bot: http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/5266 1. FAIL: Clang::preprocess-nested.cpp

[PATCH] D33774: [CodeGen] Make __attribute__(const) calls speculatable

grosser created this revision. Herald added subscribers: javed.absar, wdng. Today 'const' functions are only marked 'readnone' and 'nounwind', but lack the 'speculatable' attribute for historic reasons. As 'const' functions are known to not have any side effects and are intended to enable loop opt

r304411 - Increase the limit for the number of DiagnosticLexKinds.td diags.

Author: yrnkrn Date: Thu Jun 1 07:46:59 2017 New Revision: 304411 URL: http://llvm.org/viewvc/llvm-project?rev=304411&view=rev Log: Increase the limit for the number of DiagnosticLexKinds.td diags. 300 was reached in r304190, 400 should be enough for a while. Modified: cfe/trunk/include/cla

[PATCH] D33774: [CodeGen] Make __attribute__(const) calls speculatable

Meinersbur added a comment. Definition of `__attibute__((const))` from https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#Common-Function-Attributes > Many functions do not examine any values except their arguments, and have no > effects except the return value. Basically this i

[PATCH] D33776: [libcxx] LWG2221: No formatted output operator for nullptr

K-ballo created this revision. With effects equivalent to `os << (const void*)nullptr`. https://reviews.llvm.org/D33776 Files: include/ostream test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/nullptr_t.pass.cpp www/cxx1z_status.html Ind

[PATCH] D33597: [OpenCL] Fix pipe size in TypeInfo.

Anastasia updated this revision to Diff 101031. Anastasia edited reviewers, added: yaxunl; removed: echuraev. Anastasia removed a subscriber: yaxunl. Anastasia added a comment. Use global AS pointer for pipe size. @Sam, I am moving you to the reviewer to finish this change. Do you think it makes

[PATCH] D33597: [OpenCL] Fix pipe size in TypeInfo.

yaxunl added a comment. In https://reviews.llvm.org/D33597#770137, @Anastasia wrote: > Use global AS pointer for pipe size. > > @Sam, I am moving you to the reviewer to finish this change. Do you think it > makes sense to add RUN line with some AMD GPU in triple to the test? I would appreciate

[libcxx] r304425 - Creating release candidate rc2 from release_401 branch

Author: tstellar Date: Thu Jun 1 11:29:42 2017 New Revision: 304425 URL: http://llvm.org/viewvc/llvm-project?rev=304425&view=rev Log: Creating release candidate rc2 from release_401 branch Added: libcxx/tags/RELEASE_401/rc2/ (props changed) - copied from r304424, libcxx/branches/rele

[libcxxabi] r304426 - Creating release candidate rc2 from release_401 branch

Author: tstellar Date: Thu Jun 1 11:29:45 2017 New Revision: 304426 URL: http://llvm.org/viewvc/llvm-project?rev=304426&view=rev Log: Creating release candidate rc2 from release_401 branch Added: libcxxabi/tags/RELEASE_401/rc2/ (props changed) - copied from r304425, libcxxabi/branche

[libunwind] r304432 - Creating release candidate rc2 from release_401 branch

Author: tstellar Date: Thu Jun 1 11:30:02 2017 New Revision: 304432 URL: http://llvm.org/viewvc/llvm-project?rev=304432&view=rev Log: Creating release candidate rc2 from release_401 branch Added: libunwind/tags/RELEASE_401/rc2/ (props changed) - copied from r304431, libunwind/branche

[PATCH] D33108: Generate extra .ll files before/after optimization when using -save-temps.

tra added inline comments. Comment at: lib/Driver/Driver.cpp:2603-2614 + // lipo-able. + if (!MultiArchUniversalBuild) { +if (isSaveTempsEnabled() && Phase == phases::Compile) { + Actions.push_back( + C.MakeAction(Current, types::TY_LLVM_IR

[PATCH] D33739: [Sema] Improve -Wstrict-prototypes diagnostic message for blocks

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D33739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

aaron.ballman added a comment. In https://reviews.llvm.org/D3#768332, @jyu2 wrote: > Okay this CFG version of this change. In this change I am basic using same > algorithm with -Winfinite-recursion. > > In addition to my original implementation, I add handler type checking which > basic u

[PATCH] D33537: [clang-tidy] Exception Escape Checker

aaron.ballman added a comment. In https://reviews.llvm.org/D33537#765445, @baloghadamsoftware wrote: > In https://reviews.llvm.org/D33537#764834, @Prazek wrote: > > > How is that compared to https://reviews.llvm.org/D19201 and the clang patch > > mentioned in this patch? > > > Actually, this che

[PATCH] D31830: Emit invariant.group.barrier when using union field

rjmccall accepted this revision. rjmccall added a comment. Thanks, LGTM. https://reviews.llvm.org/D31830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

aaron.ballman added a comment. Can you help me to understand what problem is being solved with this new attribute? Under what circumstances would the first argument be an `ImplicitParamDecl` but not an implicit this or self? https://reviews.llvm.org/D33735 __

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

ABataev added a comment. In https://reviews.llvm.org/D33735#770288, @aaron.ballman wrote: > Can you help me to understand what problem is being solved with this new > attribute? Under what circumstances would the first argument be an > `ImplicitParamDecl` but not an implicit this or self? For

[PATCH] D33588: Fix two sources of UB in __next_hash_pow2 (from __hash_table)

vsk added inline comments. Comment at: include/__hash_table:139 { -return size_t(1) << (std::numeric_limits::digits - __clz(__n-1)); +return (__n > 1) ? (size_t(1) << (std::numeric_limits::digits - __clz(__n-1))) : __n; } EricWF wrote: > Shouldn't this

[PATCH] D33788: Return a canonical path from getClangResourcePath()

aaron.ballman created this revision. on POSIX systems, CIndexer::getClangResourcesPath() uses dladdr() to get the path of the shared object. It seems that on some systems (in our case, OS X 10.6.8), dladdr() does not return a canonicalized path. We're getting a path like PATH/TO/CLANG/build/bin

[PATCH] D33774: [CodeGen] Make __attribute__(const) calls speculatable

efriedma added a comment. Consider something like this: define i32 @div(i32 %x, i32 %y) { entry: %div = sdiv i32 %x, %y ret i32 %div } We can mark this function readnone, but not speculatable: it doesn't read or write memory, but could exhibit undefined behavior. Consider another

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

aaron.ballman added a comment. In https://reviews.llvm.org/D33735#770296, @ABataev wrote: > In https://reviews.llvm.org/D33735#770288, @aaron.ballman wrote: > > > Can you help me to understand what problem is being solved with this new > > attribute? Under what circumstances would the first argu

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

rjmccall added a comment. In https://reviews.llvm.org/D33735#770318, @aaron.ballman wrote: > In https://reviews.llvm.org/D33735#770296, @ABataev wrote: > > > In https://reviews.llvm.org/D33735#770288, @aaron.ballman wrote: > > > > > Can you help me to understand what problem is being solved with

[PATCH] D33735: [DebugInfo] Add ThisOrSelf attribute for emission of FlagObjectPointer.

ABataev added a comment. In https://reviews.llvm.org/D33735#770333, @rjmccall wrote: > In https://reviews.llvm.org/D33735#770318, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D33735#770296, @ABataev wrote: > > > > > In https://reviews.llvm.org/D33735#770288, @aaron.ballman wrote: > > >

[PATCH] D33765: Show correct column nr. when multi-byte utf8 chars are used.

efriedma added a comment. Correctly counting columns is a bit more complicated that that... for example, consider what happens if you replace `ideëen` with `idez̈en`. See https://stackoverflow.com/questions/3634627/how-to-know-the-preferred-display-width-in-columns-of-unicode-characters . ht

[PATCH] D24371: Add diagnostics to require_constant_initialization

loladiro added a comment. Sure, I'll commit it. https://reviews.llvm.org/D24371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r304346 - [modules] When compiling a preprocessed module map, look for headers relative

Hello Richard, This commit broke tests on few of our builders: Failing Tests (2): Clang :: Modules/preprocess-module.cpp Clang :: Modules/preprocess-nested.cpp http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/10199 and http://lab.llvm.org:8011/bui

r304444 - Remove late nullptr pointer test (PR32447)

Author: rksimon Date: Thu Jun 1 13:13:02 2017 New Revision: 30 URL: http://llvm.org/viewvc/llvm-project?rev=30&view=rev Log: Remove late nullptr pointer test (PR32447) IgnoreNarrowingConversion should never return nullptr, but I've added an assert just in case. Modified: cfe/trunk/

r304445 - Strip trailing whitespace. NFCI.

Author: rksimon Date: Thu Jun 1 13:17:18 2017 New Revision: 304445 URL: http://llvm.org/viewvc/llvm-project?rev=304445&view=rev Log: Strip trailing whitespace. NFCI. Modified: cfe/trunk/lib/Sema/SemaOverload.cpp Modified: cfe/trunk/lib/Sema/SemaOverload.cpp URL: http://llvm.org/viewvc/llvm

Re: r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

On Tue, Mar 14, 2017 at 04:00:53AM -, Akira Hatanaka via cfe-commits wrote: > Author: ahatanak > Date: Mon Mar 13 23:00:52 2017 > New Revision: 297702 > > URL: http://llvm.org/viewvc/llvm-project?rev=297702&view=rev > Log: > [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded >

[PATCH] D33726: [driver][netbsd] Build and pass `-L` arguments to the linker

joerg added a comment. A small subset can be found by searching for LINKER_RPATH_FLAG in pkgsrc. A classic offender is Emacs. For more, I would have to systematically search. Repository: rL LLVM https://reviews.llvm.org/D33726 ___ cfe-commits ma

r304448 - Emit invariant.group.barrier when using union field

Author: prazek Date: Thu Jun 1 13:39:34 2017 New Revision: 304448 URL: http://llvm.org/viewvc/llvm-project?rev=304448&view=rev Log: Emit invariant.group.barrier when using union field Summary: We need to emit barrier if the union field is CXXRecordDecl because it might have vptrs. The testcode w

[PATCH] D31830: Emit invariant.group.barrier when using union field

This revision was automatically updated to reflect the committed changes. Closed by commit rL304448: Emit invariant.group.barrier when using union field (authored by Prazek). Changed prior to commit: https://reviews.llvm.org/D31830?vs=100977&id=101058#toc Repository: rL LLVM https://reviews

r304449 - [CodeGen][ObjC] Fix assertion failure in EmitARCStoreStrongCall.

Author: ahatanak Date: Thu Jun 1 13:41:25 2017 New Revision: 304449 URL: http://llvm.org/viewvc/llvm-project?rev=304449&view=rev Log: [CodeGen][ObjC] Fix assertion failure in EmitARCStoreStrongCall. The assertion fails because EmitValueForIvarAtOffset doesn't get the correct type of the ivar whe

[PATCH] D33698: [CodeGen][ObjC] Fix assertion failure in CodeGenFunction::EmitARCStoreStrongCall

This revision was automatically updated to reflect the committed changes. Closed by commit rL304449: [CodeGen][ObjC] Fix assertion failure in EmitARCStoreStrongCall. (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D33698?vs=100787&id=101060#toc Repository: rL LLVM

[libcxx] r304450 - Remove ubsan XFAILS in two tests

Author: vedantk Date: Thu Jun 1 13:48:27 2017 New Revision: 304450 URL: http://llvm.org/viewvc/llvm-project?rev=304450&view=rev Log: Remove ubsan XFAILS in two tests These two tests are ubsan-clean now: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/3553/ Modified: libcx

[PATCH] D24371: Add diagnostics to require_constant_initialization

This revision was automatically updated to reflect the committed changes. Closed by commit rL304451: [SemaCXX] Add diagnostics to require_constant_initialization (authored by kfischer). Changed prior to commit: https://reviews.llvm.org/D24371?vs=100949&id=101066#toc Repository: rL LLVM http

r304451 - [SemaCXX] Add diagnostics to require_constant_initialization

Author: kfischer Date: Thu Jun 1 13:54:16 2017 New Revision: 304451 URL: http://llvm.org/viewvc/llvm-project?rev=304451&view=rev Log: [SemaCXX] Add diagnostics to require_constant_initialization Summary: This hooks up the detailed diagnostics of why constant initialization was not possible if re

[PATCH] D33706: CodeGen: Cast temporary variable to proper address space

yaxunl updated this revision to Diff 101070. yaxunl marked 2 inline comments as done. yaxunl retitled this revision from "[AMDGPU] Fix address space for global and temporary variables in C++" to "CodeGen: Cast temporary variable to proper address space". yaxunl edited the summary of this revision

r304455 - Fixed broken test (strict-vtable-pointers)

Author: prazek Date: Thu Jun 1 14:08:05 2017 New Revision: 304455 URL: http://llvm.org/viewvc/llvm-project?rev=304455&view=rev Log: Fixed broken test (strict-vtable-pointers) Modified: cfe/trunk/test/CodeGenCXX/strict-vtable-pointers.cpp Modified: cfe/trunk/test/CodeGenCXX/strict-vtable-poi

r304456 - Add compatibility alias for -Wno-#warnings

Author: dblaikie Date: Thu Jun 1 14:08:34 2017 New Revision: 304456 URL: http://llvm.org/viewvc/llvm-project?rev=304456&view=rev Log: Add compatibility alias for -Wno-#warnings GCC uses -Wno-cpp for this, so seems reasonable to add an alias to match. Modified: cfe/trunk/include/clang/Basic/

[PATCH] D31972: Do not force the frame pointer by default for ARM EABI

efriedma added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:569 + if (Triple.getEnvironment() == llvm::Triple::EABI) { +switch (Triple.getArch()) { chrib wrote: > efriedma wrote: > > Specifically checking for "llvm::Triple::EABI" is suspici

r304459 - [ubsan] Add a check for pointer overflow UB

Author: vedantk Date: Thu Jun 1 14:22:18 2017 New Revision: 304459 URL: http://llvm.org/viewvc/llvm-project?rev=304459&view=rev Log: [ubsan] Add a check for pointer overflow UB Check pointer arithmetic for overflow. For some more background on this check, see: https://wdtz.org/catching-point

[PATCH] D33305: [ubsan] Add a check for pointer overflow UB

This revision was automatically updated to reflect the committed changes. Closed by commit rL304459: [ubsan] Add a check for pointer overflow UB (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D33305?vs=100475&id=101078#toc Repository: rL LLVM https://reviews.llvm.o

Re: r304346 - [modules] When compiling a preprocessed module map, look for headers relative

On 1 June 2017 at 11:10, Galina Kistanova wrote: > Hello Richard, > > This commit broke tests on few of our builders: > > Failing Tests (2): > Clang :: Modules/preprocess-module.cpp > Clang :: Modules/preprocess-nested.cpp > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64- > sce

[libcxx] r304462 - Mark two coroutine tests as unsupported under ubsan

Author: vedantk Date: Thu Jun 1 15:00:40 2017 New Revision: 304462 URL: http://llvm.org/viewvc/llvm-project?rev=304462&view=rev Log: Mark two coroutine tests as unsupported under ubsan They appear to crash inside of SelectionDAG on some Linux bots, when ubsan is enabled. https://bugs.llvm.org/s

r304463 - [Modules] Handle sanitizer feature mismatches when importing modules

Author: vedantk Date: Thu Jun 1 15:01:01 2017 New Revision: 304463 URL: http://llvm.org/viewvc/llvm-project?rev=304463&view=rev Log: [Modules] Handle sanitizer feature mismatches when importing modules This patch makes it an error to have a mismatch between the enabled sanitizers in a CU, and in

[PATCH] D32724: [Modules] Handle sanitizer feature mismatches when importing modules

This revision was automatically updated to reflect the committed changes. Closed by commit rL304463: [Modules] Handle sanitizer feature mismatches when importing modules (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D32724?vs=98371&id=101088#toc Repository: rL LLVM

[PATCH] D33797: [coroutines] Fix rebuilding of dependent coroutine parameters

GorNishanov created this revision. We were not handling correctly rebuilding of parameter and were not creating copies for them. With this checking, we will be always rebuilding parameter moves in TreeTransform's TransformCoroutineBodyStmt. https://reviews.llvm.org/D33797 Files: lib/Sema/Co

[PATCH] D33398: Mangle __unaligned in Itanium ABI

rsmith accepted this revision. rsmith added a comment. Looks great, thanks! Comment at: lib/AST/ItaniumMangle.cpp:2210 + if (Quals.hasUnaligned()) + mangleVendorQualifier("__unaligned"); + rogfer01 wrote: > rsmith wrote: > > Too much indentation here. Als

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

loladiro updated this revision to Diff 101092. loladiro added a comment. Finalize all subprograms when we're done emitting them. The one we're interested in is a side effect, but doing this uniformly might be cleaner and help avoid similar errors in the future. https://reviews.llvm.org/D33705 F

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

loladiro added a comment. @aprantl @dblaikie See if you like this better. https://reviews.llvm.org/D33705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r304464 - Escape filenames in module map line marker directives, to unbreak Windows build bots.

Author: rsmith Date: Thu Jun 1 15:10:35 2017 New Revision: 304464 URL: http://llvm.org/viewvc/llvm-project?rev=304464&view=rev Log: Escape filenames in module map line marker directives, to unbreak Windows build bots. Modified: cfe/trunk/lib/Frontend/FrontendActions.cpp cfe/trunk/lib/Fr

Re: r304346 - [modules] When compiling a preprocessed module map, look for headers relative

On 1 June 2017 at 12:53, Richard Smith wrote: > On 1 June 2017 at 11:10, Galina Kistanova wrote: > >> Hello Richard, >> >> This commit broke tests on few of our builders: >> >> Failing Tests (2): >> Clang :: Modules/preprocess-module.cpp >> Clang :: Modules/preprocess-nested.cpp >> >> ht

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. I guess this would need a cross-project test case (ie: it'd have to run LLVM optimizations to fail/pass/demonstrate the fix). I think it'd be OK to add one if there's a neat/clean/obvious

r304465 - Don't assume that a store source is a vector type just because the destination is (PR26099)

Author: rksimon Date: Thu Jun 1 15:13:34 2017 New Revision: 304465 URL: http://llvm.org/viewvc/llvm-project?rev=304465&view=rev Log: Don't assume that a store source is a vector type just because the destination is (PR26099) Added: cfe/trunk/test/CodeGen/pr26099.c Modified: cfe/trunk/li

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

loladiro added a comment. There's already such a test case, but the cloning currently doesn't assert properly (but it can generate incorrect code). https://reviews.llvm.org/D33655 fixes that up, so I think the testing is covered once that LLVM commit goes in. I'll hold off a little while to giv

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

aprantl added a comment. Looks good.. Are you also planning to change DIBuilder to not finalize subprograms automatically any more (and not insert them into AllSubprograms)? (That will be the more impactful change as it will force all non-clang frontends to make a similar change). https://rev

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

loladiro added a comment. I don't think that change is entirely necessary. I don't have any strong objections to it, but I also don't see a good reason to require it. In any case, let me get this in to be able to re-land https://reviews.llvm.org/D33655 and we can revisit the more disruptive cha

[PATCH] D33692: [ThinLTO] Migrate ThinLTOBitcodeWriter to the new PM.

timshen updated this revision to Diff 101106. timshen added a comment. Rebase the patch onto https://reviews.llvm.org/D33799. https://reviews.llvm.org/D33692 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/thin_link_bitcode.c Index: clang/test/CodeGen/thin_link_bitcode.c =

r304470 - [CGDebugInfo] Finalize SubPrograms when we're done with them

Author: kfischer Date: Thu Jun 1 16:14:03 2017 New Revision: 304470 URL: http://llvm.org/viewvc/llvm-project?rev=304470&view=rev Log: [CGDebugInfo] Finalize SubPrograms when we're done with them `GenerateVarArgsThunk` in `CGVTables` clones a function before the frontend is done emitting the comp

[PATCH] D33705: [CGVTables] Finalize SP before attempting to clone it

This revision was automatically updated to reflect the committed changes. Closed by commit rL304470: [CGDebugInfo] Finalize SubPrograms when we're done with them (authored by kfischer). Changed prior to commit: https://reviews.llvm.org/D33705?vs=101092&id=101107#toc Repository: rL LLVM http

r304472 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:15:34 2017 New Revision: 304472 URL: http://llvm.org/viewvc/llvm-project?rev=304472&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseDecl.cpp Modified: cfe/trunk/lib/Parse/

r304473 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:19:06 2017 New Revision: 304473 URL: http://llvm.org/viewvc/llvm-project?rev=304473&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseDeclCXX.cpp Modified: cfe/trunk/lib/Par

r304475 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:21:49 2017 New Revision: 304475 URL: http://llvm.org/viewvc/llvm-project?rev=304475&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseExpr.cpp Modified: cfe/trunk/lib/Parse/

r304477 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:23:52 2017 New Revision: 304477 URL: http://llvm.org/viewvc/llvm-project?rev=304477&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseInit.cpp Modified: cfe/trunk/lib/Parse/

r304478 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:26:38 2017 New Revision: 304478 URL: http://llvm.org/viewvc/llvm-project?rev=304478&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseOpenMP.cpp Modified: cfe/trunk/lib/Pars

r304479 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:28:26 2017 New Revision: 304479 URL: http://llvm.org/viewvc/llvm-project?rev=304479&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseStmt.cpp Modified: cfe/trunk/lib/Parse/

r304481 - Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC.

Author: gkistanova Date: Thu Jun 1 16:29:45 2017 New Revision: 304481 URL: http://llvm.org/viewvc/llvm-project?rev=304481&view=rev Log: Added LLVM_FALLTHROUGH to address warning: this statement may fall through. NFC. Modified: cfe/trunk/lib/Parse/ParseTentative.cpp Modified: cfe/trunk/lib/P

[PATCH] D33692: [ThinLTO] Wire up ThinLTO and new PM

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. This patch LGTM whenever the underlying LLVM change lands, thanks https://reviews.llvm.org/D33692 ___ cfe-commits mailing list cfe-comm

Re: [PATCH] D33424: Lexer: allow imaginary constants in GNU mode (only).

On 26 May 2017 at 11:29, Richard Smith wrote: > If we generally think that distinction is a good thing, then (because this > is a conforming extension) consistency weakly suggests that it should not be > controlled by GNU mode. But I don't find that argument decisive; the > important thing is that

[PATCH] D33692: [ThinLTO] Wire up ThinLTO and new PM

davide added a comment. LGTM once the other patch lands. https://reviews.llvm.org/D33692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33721: [ARM] Add support for target("arm") and target("thumb").

echristo added inline comments. Comment at: lib/Basic/Targets.cpp:5439-5442 +// [-|+]thumb-mode target features respectively. +std::vector UpdatedFeaturesVec(FeaturesVec); +for (auto &Feature : UpdatedFeaturesVec) { + if (Feature.compare("+arm") == 0) ---

Re: [PATCH] D33424: Lexer: allow imaginary constants in GNU mode (only).

On 1 June 2017 at 14:36, Tim Northover wrote: > On 26 May 2017 at 11:29, Richard Smith wrote: > > If we generally think that distinction is a good thing, then (because > this > > is a conforming extension) consistency weakly suggests that it should > not be > > controlled by GNU mode. But I don'

Re: r304459 - [ubsan] Add a check for pointer overflow UB

Hello Vedant, This commit broke tests on some of our builders: Failing Tests (1): Clang :: CodeGen/ubsan-pointer-overflow.m http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/2865/steps/test-check-all/logs/stdio http://lab.llvm.org:8011/builders/llvm-clang-lld-x8

Re: r304459 - [ubsan] Add a check for pointer overflow UB

Taking a look. vedant > On Jun 1, 2017, at 2:45 PM, Galina Kistanova wrote: > > Hello Vedant, > > This commit broke tests on some of our builders: > > Failing Tests (1): > Clang :: CodeGen/ubsan-pointer-overflow.m > > http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-w

r304486 - Relax test to try and appease builders. NFC.

Author: vedantk Date: Thu Jun 1 17:27:39 2017 New Revision: 304486 URL: http://llvm.org/viewvc/llvm-project?rev=304486&view=rev Log: Relax test to try and appease builders. NFC. I'm not sure why, but on some bots, the order of two instructions are swapped (as compared to the output on my machine

Re: r304459 - [ubsan] Add a check for pointer overflow UB

I checked in r304486 to try and address the issue. thanks, vedant > On Jun 1, 2017, at 3:21 PM, Vedant Kumar via cfe-commits > wrote: > > Taking a look. > > vedant > >> On Jun 1, 2017, at 2:45 PM, Galina Kistanova > > wrote: >> >> Hello Vedant, >> >> This commi

  1   2   >