[PATCH] D33606: [Sema] Fix a crash-on-invalid when a template parameter list has a class definition or non-reference class type

ahatanak added a comment. ping https://reviews.llvm.org/D33606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

On Jun 15, 2017 11:22 PM, "Eric Fiselier" wrote: On Thu, Jun 15, 2017 at 11:00 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > Your suggestion is essentially to replace experimental/string_view with > something like: > > namespace std { inline namespace __1 {

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

On Thu, Jun 15, 2017 at 11:00 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > Your suggestion is essentially to replace experimental/string_view with > something like: > > namespace std { inline namespace __1 { namespace experimental { > template > using

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

Your suggestion is essentially to replace experimental/string_view with something like: namespace std { inline namespace __1 { namespace experimental { template using basic_string_view = _VSTD::basic_string_view; }}} That breaks: 1. User compiles 1.cpp with older toolchain.

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

I would also want to do serious performance analysis on this patch. Does removing the string_view overloads cause less optimal overloads to be chosen? Perhaps allocating ones? That would be really unfortunate, and I'm not sure that's in the best interest of our users at large. /Eric On Thu, Jun

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

I should mention that depends on C++17 string_view in older dialects :-S So this change will break that. I would prefer to fix your specific use case by making std::experimental::string_view literally be std::string_view. /Eric On Thu, Jun 15, 2017 at 8:42 PM, Eric Fiselier

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

On Jun 15, 2017, at 19:42, Eric Fiselier wrote:On Thu, Jun 15, 2017 at 8:38 PM, Duncan P. N. Exon Smith  wrote:I just started working on a patch to add #if guards, and the first interesting thing I found was the basic_string constructor:template template

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

dexonsmith added inline comments. Comment at: src/experimental/filesystem/operations.cpp:22-24 +#if defined(__APPLE__) +#include +#endif EricWF wrote: > dexonsmith wrote: > > I only just noticed you were including Availability.h. That shouldn't be > >

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

EricWF added inline comments. Comment at: src/experimental/filesystem/operations.cpp:22-24 +#if defined(__APPLE__) +#include +#endif dexonsmith wrote: > I only just noticed you were including Availability.h. That shouldn't be > necessary, since the macros

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

dexonsmith added inline comments. Comment at: src/experimental/filesystem/operations.cpp:23-28 +// We can use the presence of UTIME_OMIT to detect platforms that do not +// provide utimensat, with some exceptions on OS X. +#if !defined(UTIME_OMIT) || \ +

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

dexonsmith added inline comments. Comment at: src/experimental/filesystem/operations.cpp:23-28 +// We can use the presence of UTIME_OMIT to detect platforms that do not +// provide utimensat, with some exceptions on OS X. +#if !defined(UTIME_OMIT) || \ +

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

EricWF updated this revision to Diff 102783. EricWF marked an inline comment as done. EricWF added a comment. - Address inline comments. https://reviews.llvm.org/D34249 Files: src/experimental/filesystem/operations.cpp Index: src/experimental/filesystem/operations.cpp

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

EricWF updated this revision to Diff 102782. https://reviews.llvm.org/D34249 Files: src/experimental/filesystem/operations.cpp Index: src/experimental/filesystem/operations.cpp === --- src/experimental/filesystem/operations.cpp

[PATCH] D34268: [clang] Fix format specifiers fixits for nested macros

alexshap updated this revision to Diff 102781. alexshap added a comment. minor update Repository: rL LLVM https://reviews.llvm.org/D34268 Files: include/clang/Edit/EditedSource.h lib/Edit/EditedSource.cpp test/FixIt/fixit-format-darwin.m Index: test/FixIt/fixit-format-darwin.m

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai updated this revision to Diff 102777. xiangzhai added a comment. Herald added a subscriber: xazax.hun. Dear Raphael, Thanks for your suggestion! > Would it solve your use case if allow specifying file patterns via the > command line like this -analyzer-config Fixed!

[PATCH] D34268: [clang] Fix format specifiers fixits for nested macros

mehdi_amini added a comment. Thanks for fixing! (I'm still not the best qualified to review this) Comment at: lib/Edit/EditedSource.cpp:78 if (I != ExpansionToArgMap.end() && -std::find_if( -I->second.begin(), I->second.end(), [&](const MacroArgUse ) {

[PATCH] D34262: [ubsan] PR33081: Skip the standard type checks for volatile

This revision was automatically updated to reflect the committed changes. Closed by commit rL305546: [ubsan] PR33081: Skip the standard type checks for volatile (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D34262?vs=102758=102778#toc Repository: rL LLVM

r305546 - [ubsan] PR33081: Skip the standard type checks for volatile

Author: vedantk Date: Thu Jun 15 22:27:36 2017 New Revision: 305546 URL: http://llvm.org/viewvc/llvm-project?rev=305546=rev Log: [ubsan] PR33081: Skip the standard type checks for volatile Skip checks for null dereference, alignment violation, object size violation, and dynamic type violation if

[PATCH] D34262: [ubsan] PR33081: Skip the standard type checks for volatile

vsk added a comment. Thanks for the review. I'll make the suggested test changes and commit. https://reviews.llvm.org/D34262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34052: [XRay][clang] Support capturing the implicit `this` argument to C++ class member functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL305544: [XRay][clang] Support capturing the implicit `this` argument to C++ class… (authored by dberris). Changed prior to commit: https://reviews.llvm.org/D34052?vs=102491=102775#toc Repository: rL

r305544 - [XRay][clang] Support capturing the implicit `this` argument to C++ class member functions

Author: dberris Date: Thu Jun 15 22:22:09 2017 New Revision: 305544 URL: http://llvm.org/viewvc/llvm-project?rev=305544=rev Log: [XRay][clang] Support capturing the implicit `this` argument to C++ class member functions Summary: Before this change, we couldn't capture the `this` pointer that's

[PATCH] D30406: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output

vlad.tsyrklevich updated this revision to Diff 102765. vlad.tsyrklevich added a comment. Herald added a subscriber: xazax.hun. Updates to cleanly rebase on a recent clang master. Ran all tests with ASan to ensure I avoided a broken build post-merge as with https://reviews.llvm.org/D30909

[PATCH] D34268: [clang] Fix format specifiers fixits for nested macros

alexshap created this revision. ExpansionLoc was previously calculated incorrectly in the case of nested macros expansions. In this diff we build the stack of expansions where the last one is the actual expansion (in the source code) which should be used for grouping together the edits. The

r305543 - [ODRHash] Hash VarDecl members.

Author: rtrieu Date: Thu Jun 15 21:44:29 2017 New Revision: 305543 URL: http://llvm.org/viewvc/llvm-project?rev=305543=rev Log: [ODRHash] Hash VarDecl members. These VarDecl's are static data members of classes. Since the initializers are also hashed, this also provides checking for default

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

On Thu, Jun 15, 2017 at 8:38 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > I just started working on a patch to add #if guards, and the first > interesting thing I found was the basic_string constructor: > > template > template > basic_string<_CharT, _Traits,

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

Ah, also the enable_if for same: > template > _LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS > basic_string(const _Tp& __t, size_type __pos, size_type __n, > const allocator_type& __a = allocator_type(), > typename >

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

I just started working on a patch to add #if guards, and the first interesting thing I found was the basic_string constructor: > template > template > basic_string<_CharT, _Traits, _Allocator>::basic_string( > const _Tp& __t, size_type __pos, size_type __n, const >

[PATCH] D34267: do more processing in clang-fuzzer (use EmitAssemblyAction)

kcc created this revision. Herald added a subscriber: mgorny. use EmitAssemblyAction in clang-fuzzer https://reviews.llvm.org/D34267 Files: tools/clang-fuzzer/CMakeLists.txt tools/clang-fuzzer/ClangFuzzer.cpp Index: tools/clang-fuzzer/ClangFuzzer.cpp

[libcxx] r305539 - Allow the libc++ C header wrappers to be included when compiling C.

Author: ericwf Date: Thu Jun 15 20:57:41 2017 New Revision: 305539 URL: http://llvm.org/viewvc/llvm-project?rev=305539=rev Log: Allow the libc++ C header wrappers to be included when compiling C. C99 at least. C89 still fails due to the use of block comments. NOTE: Having libc++ on the include

[PATCH] D34237: Mark the operations of __wrap_iter as constexpr

EricWF added a comment. A large portion of this patch is UB. Any function that unconditionally calls `__get_db()` can never be a valid constant expression, hence UB. Is there a smaller set of operations or `__wrap_iter` that *must* be made constexpr? Or do they all need to be?

[PATCH] D34266: Static Analyzer - Localizability Checker: New Localizable APIs for macOS High Sierra & iOS 11

kulpreet created this revision. - Added in new iOS and macOS APIs that require a localized string - Ran unit tests Repository: rL LLVM https://reviews.llvm.org/D34266 Files: lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp Index: lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

It *shouldn't* include , that's a given. IIRC, and Marshall would know better, I believe it was untenable to maintain a version of that didn't depend on after making the changes required for C++17. However inspecting now it does seem possible that the entanglement is avoidable.Though it's

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

erik.pilkington added a comment. Ping! https://reviews.llvm.org/D33816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34264: Introduce -Wunguarded-availability-new, which is like -Wunguarded-availability, except that it's enabled by default for new deployment targets

erik.pilkington added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:7315 + default: +assert(!Triple.isMacOSX() && "MacOS should be handled in the switch"); +// New targets should always warn about availability. This assert seems a bit

[PATCH] D34264: Introduce -Wunguarded-availability-new, which is like -Wunguarded-availability, except that it's enabled by default for new deployment targets

arphaman created this revision. This patch adds a new warning flag called `-Wunguarded-availability-new`. If `-Wunguarded-availability` is off, this warning only warns about uses of APIs that have been introduced in macOS >= 10.13, iOS >= 11, watchOS >= 4 and tvOS >= 11. This warning is on by

[PATCH] D34262: [ubsan] PR33081: Skip the standard type checks for volatile

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good, and I did ask Richard about this in person before filing the bug and he was in favor of it, so feel free to commit. If I'd known how easy it was to implement and how few tests it would

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

> On Jul 20, 2016, at 22:31, Marshall Clow via cfe-commits > wrote: > > Modified: libcxx/trunk/include/string > URL: > http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/string?rev=276238=276237=276238=diff >

[PATCH] D34256: [PR33394] Avoid lexing editor placeholders when running the preprocessor only

arphaman updated this revision to Diff 102764. arphaman added a comment. Fair enough. I removed the special checks for `<#>` and `<##>`. Repository: rL LLVM https://reviews.llvm.org/D34256 Files: include/clang/Lex/PreprocessorOptions.h lib/Frontend/CompilerInvocation.cpp

[libcxx] r305536 - Allow coroutine_handle to support creation from const references to the promise_type

Author: ericwf Date: Thu Jun 15 19:36:17 2017 New Revision: 305536 URL: http://llvm.org/viewvc/llvm-project?rev=305536=rev Log: Allow coroutine_handle to support creation from const references to the promise_type It seems conceivable that a user would need to get a coroutine handle having only

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

akyrtzi created this revision. This is useful for being able to parse the preprocessor directive blocks even the header that defined the macro that they check for hasn't been included. https://reviews.llvm.org/D34263 Files: include/clang/Lex/Preprocessor.h lib/Lex/PPDirectives.cpp

[PATCH] D28953: [analyzer] Eliminate analyzer limitations on symbolic constraint generation

ddcc added inline comments. Comment at: lib/StaticAnalyzer/Core/SValBuilder.cpp:356 QualType ResultTy) { - if (!State->isTainted(RHS) && !State->isTainted(LHS)) -return UnknownVal(); zaks.anna wrote: > I am concerned that

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 marked 7 inline comments as done. jyu2 added inline comments. Comment at: lib/Sema/AnalysisBasedWarnings.cpp:296 + + if (ThrowType->isReferenceType()) +ThrowType = ThrowType->castAs() aaron.ballman wrote: > If `ThrowType` can be null, there should be a

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 updated this revision to Diff 102759. jyu2 marked 13 inline comments as done. https://reviews.llvm.org/D3 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/AnalysisBasedWarnings.cpp test/CXX/except/except.spec/p11.cpp test/SemaCXX/warn-throw-out-noexcept-func.cpp

[PATCH] D34262: [ubsan] PR33081: Skip the standard type checks for volatile

vsk created this revision. Skip checks for null dereference, alignment violation, object size violation, and dynamic type violation if the pointer points to volatile data. https://bugs.llvm.org/show_bug.cgi?id=33081 https://reviews.llvm.org/D34262 Files: lib/CodeGen/CGExpr.cpp

[PATCH] D34237: Mark the operations of __wrap_iter as constexpr

EricWF added a comment. Could you re-upload this with a updated diff against trunk, and one with more context. https://reviews.llvm.org/D34237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

jyu2 updated this revision to Diff 102754. jyu2 added a comment. Address Aaron's comments. https://reviews.llvm.org/D3 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/AnalysisBasedWarnings.cpp test/CXX/except/except.spec/p11.cpp

Re: r284060 - Implement MS _BitScan intrinsics

On Tue, Jun 13, 2017 at 8:13 PM, Bruno Cardoso Lopes wrote: > On Mon, Jun 12, 2017 at 2:01 PM, Erik Schwiebert via cfe-commits > wrote: >> SGTM too. Regarding Duncan's last question -- I can't think of any such >> customer. :) If you all

[PATCH] D34256: [PR33394] Avoid lexing editor placeholders when running the preprocessor only

benlangmuir added a comment. I agree with not detecting these during PP-only, but there's nothing wrong with `<#>`. It's either not a placeholder, or it's part of a placeholder like `<#>#>`, which is a placeholder containing the text ">". Similarly, `<##` could be the start of an empty

[PATCH] D34256: [PR33394] Avoid lexing editor placeholders when running the preprocessor only

arphaman created this revision. r300667 added support for editor placeholder to Clang. That commit didn’t take into account that users who use Clang for preprocessing only (-E) will get the “editor placeholder in source file” error when preprocessing their source (PR33394). This commit

[PATCH] D33406: PR28129 expand vector oparation to an IR constant.

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D33406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

EricWF added inline comments. Comment at: src/experimental/filesystem/operations.cpp:23-28 +// We can use the presence of UTIME_OMIT to detect platforms that do not +// provide utimensat, with some exceptions on OS X. +#if !defined(UTIME_OMIT) || \ +

[PATCH] D34185: [Parser][ObjC] Avoid crashing when skipping to EOF while parsing an ObjC interface/implementation

ahatanak added inline comments. Comment at: lib/Parse/ParseObjc.cpp:220 CheckNestedObjCContexts(AtLoc); + if (isEofOrEom()) +return nullptr; Do you need this check here (and below)? Comment at: lib/Parse/ParseObjc.cpp:3674 + + //

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

dexonsmith added a comment. This is the right idea, although it only covers macOS. Any ideas for how to test this? Comment at: src/experimental/filesystem/operations.cpp:23-28 +// We can use the presence of UTIME_OMIT to detect platforms that do not +// provide utimensat,

[PATCH] D34252: Add arbitrary file/path support to clang-format style file selection

dciliske created this revision. Herald added a subscriber: klimek. The Format library has no way to specify a specific file to be used as the style source. It climbs the path looking for ‘.clang_format’. This patch adds the ability to specify a specific file to use for clang Format utilities.

[PATCH] D34251: Add a new driver option to disable warning about c++17's non-throwing exception specification in function signature

ahatanak created this revision. The option allows disabling just the warning about non-throwing exception specification in function signature instead of disabling all c++1z compatibility warnings with -Wno-c++1z-compat. I'm not sure "-Wc++1z-compat-exception-spec" sounds right. Maybe

[PATCH] D32411: [libcxx] Provide #include_next alternative for MSVC

bcraig added a comment. ping https://reviews.llvm.org/D32411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20596: [libcxx] Refactor locale switching, creation, and destruction

bcraig abandoned this revision. bcraig added a comment. This is very stale at this point, and isn't blocking anything. Closing. https://reviews.llvm.org/D20596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r305511 - [Completion] Code complete the members for a dependent type after a '::'

Author: arphaman Date: Thu Jun 15 16:40:54 2017 New Revision: 305511 URL: http://llvm.org/viewvc/llvm-project?rev=305511=rev Log: [Completion] Code complete the members for a dependent type after a '::' This commit is a follow up to r302797 which added support for dependent completions after the

[PATCH] D34173: [Completion] Code complete the members for a dependent type after a '::'

This revision was automatically updated to reflect the committed changes. Closed by commit rL305511: [Completion] Code complete the members for a dependent type after a '::' (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D34173?vs=102410=102724#toc Repository: rL

[PATCH] D34091: Support for querying the exception specification type through libclang

aaron.ballman added inline comments. Comment at: include/clang-c/Index.h:213 + /** + * \brief The exception specification has not yet been evaluated + */ This comment is now missing the full-stop at the end of the sentence (you dropped one too many

[PATCH] D33920: [index] Record C++17 binding declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rL305508: [index] Record C++17 global binding declarations (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D33920?vs=101478=102722#toc Repository: rL LLVM

r305508 - [index] Record C++17 global binding declarations

Author: arphaman Date: Thu Jun 15 16:19:01 2017 New Revision: 305508 URL: http://llvm.org/viewvc/llvm-project?rev=305508=rev Log: [index] Record C++17 global binding declarations The global C++17 binding declarations should be indexed as variable symbols. Differential Revision:

r305507 - Added braces to work around gcc warning in googletest: suggest explicit braces to avoid ambiguous 'else'. NFC.

Author: gkistanova Date: Thu Jun 15 16:01:24 2017 New Revision: 305507 URL: http://llvm.org/viewvc/llvm-project?rev=305507=rev Log: Added braces to work around gcc warning in googletest: suggest explicit braces to avoid ambiguous 'else'. NFC. Modified:

[PATCH] D33913: [index] Index static_assert declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rL305504: [index] Index static_assert declarations (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D33913?vs=101458=102720#toc Repository: rL LLVM

r305504 - [index] Index static_assert declarations

Author: arphaman Date: Thu Jun 15 15:50:43 2017 New Revision: 305504 URL: http://llvm.org/viewvc/llvm-project?rev=305504=rev Log: [index] Index static_assert declarations static_assert declarations have to be visited while indexing so that we can gather the references to declarations that are

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

EricWF created this revision. This fixes llvm.org/PR33469. https://reviews.llvm.org/D34249 Files: src/experimental/filesystem/operations.cpp Index: src/experimental/filesystem/operations.cpp === ---

[PATCH] D34185: [Parser][ObjC] Avoid crashing when skipping to EOF while parsing an ObjC interface/implementation

arphaman updated this revision to Diff 102718. arphaman added a comment. Use the 'Eof' token to make sure that the "expected '}'" error is presented not at the end of the file, but at the start of the `@interface`/`@implementation`. Repository: rL LLVM https://reviews.llvm.org/D34185

[PATCH] D33406: PR28129 expand vector oparation to an IR constant.

dtemirbulatov updated this revision to Diff 102717. dtemirbulatov added a comment. Update formatting, comments https://reviews.llvm.org/D33406 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx-builtins.c Index: test/CodeGen/avx-builtins.c

[PATCH] D33989: [OpenCL] Allow targets to select address space per type

yaxunl added inline comments. Comment at: include/clang/Basic/TargetInfo.h:1041 +default: + return LangAS::Default; +} bader wrote: > yaxunl wrote: > > I think the default (including even_t, clk_event_t, queue_t, reserved_id_t) > > should be global

[PATCH] D34233: [CFI] Add ability to explicitly link classes

egoktas added a comment. To address pcc's questions, I have sent an email to llvm-dev: http://lists.llvm.org/pipermail/llvm-dev/2017-June/114168.html. https://reviews.llvm.org/D34233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxxabi] r305500 - Use _LIBCPP_FALLTHROUGH() to avoid warnings about [[gnu::fallthrough]] being unsupported

Author: ericwf Date: Thu Jun 15 15:18:10 2017 New Revision: 305500 URL: http://llvm.org/viewvc/llvm-project?rev=305500=rev Log: Use _LIBCPP_FALLTHROUGH() to avoid warnings about [[gnu::fallthrough]] being unsupported Modified: libcxxabi/trunk/src/cxa_demangle.cpp Modified:

[PATCH] D34156: [LTO] Enable module summary emission by default for regular LTO

tobiasvk added a comment. In https://reviews.llvm.org/D34156#781415, @pcc wrote: > Please confirm that we can still self host with full LTO now that > https://reviews.llvm.org/D33922 has landed. Good point. And the answer seems to be no :/ ld.lld: .../llvm/lib/Linker/IRMover.cpp:242:

r305498 - [coroutines] Remove pass-through operator co_await; Replace it with the input expression

Author: ericwf Date: Thu Jun 15 15:00:54 2017 New Revision: 305498 URL: http://llvm.org/viewvc/llvm-project?rev=305498=rev Log: [coroutines] Remove pass-through operator co_await; Replace it with the input expression Reviewers: GorNishanov, rsmith Reviewed By: GorNishanov Differential

[PATCH] D34091: Support for querying the exception specification type through libclang

ajbennieston updated this revision to Diff 102707. ajbennieston added a comment. Fixes for review comments. https://reviews.llvm.org/D34091 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_exception_specification_kind.py include/clang-c/Index.h

r305496 - [coroutines] Allow co_await and co_yield expressions that return an lvalue to compile

Author: ericwf Date: Thu Jun 15 14:43:36 2017 New Revision: 305496 URL: http://llvm.org/viewvc/llvm-project?rev=305496=rev Log: [coroutines] Allow co_await and co_yield expressions that return an lvalue to compile Summary: The title says it all. Reviewers: GorNishanov, rsmith Reviewed By:

[PATCH] D34194: [coroutines] Allow co_await and co_yield expressions that return an lvalue to compile

EricWF updated this revision to Diff 102705. EricWF added a comment. - Fix the test when -discard-value-names is present, at least my part of the test. https://reviews.llvm.org/D34194 Files: lib/AST/ExprClassification.cpp lib/CodeGen/CGCoroutine.cpp lib/CodeGen/CGExpr.cpp

Re: [PATCH] D34052: [XRay][clang] Support capturing the implicit `this` argument to C++ class member functions

On Mon, Jun 12, 2017 at 9:15 PM Dean Michael Berris via Phabricator < revi...@reviews.llvm.org> wrote: > dberris added a reviewer: dblaikie. > dberris added a subscriber: dblaikie. > dberris added a comment. > > @dblaikie -- do you have time to have a look? > Sure sure - no need to ping a patch

[PATCH] D34052: [XRay][clang] Support capturing the implicit `this` argument to C++ class member functions

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks fine - thanks https://reviews.llvm.org/D34052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34194: [coroutines] Allow co_await and co_yield expressions that return an lvalue to compile

EricWF updated this revision to Diff 102701. EricWF added a comment. - Address most inline comments. https://reviews.llvm.org/D34194 Files: lib/AST/ExprClassification.cpp lib/CodeGen/CGCoroutine.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.h

[PATCH] D34194: [coroutines] Allow co_await and co_yield expressions that return an lvalue to compile

EricWF marked 2 inline comments as done. EricWF added inline comments. Comment at: test/CodeGenCoroutines/coro-await.cpp:310 + int& x = co_await a; + // CHECK: await2.ready: + // CHECK-NEXT: %[[RES2:.+]] = call dereferenceable(4) i32*

RE: [PATCH] D32046: [Preprocessor]Correct Macro-Arg allocation of StringifiedArguments, correct getNumArguments

Thanks for the heads up! Fixed in 305491. Turns out a function that AllocateMacroInfo returns a pointer, but the PP still owns it. MacroArgs::create returns a pointer, and expects the user to delete it. I added a unique_ptr with a custom delete to call the macro-args 'destroy' function.

r305491 - LexerTest memory leak fix-

Author: erichkeane Date: Thu Jun 15 13:34:47 2017 New Revision: 305491 URL: http://llvm.org/viewvc/llvm-project?rev=305491=rev Log: LexerTest memory leak fix- A new LexerTest unittest introduced a memory leak. This patch uses a unique_ptr with a custom deleter to ensure it is properly deleted.

[PATCH] D34182: [analyzer] Performance optimizations for the CloneChecker

teemperor updated this revision to Diff 102700. teemperor marked an inline comment as done. teemperor added a comment. - made saveHash static. https://reviews.llvm.org/D34182 Files: include/clang/Analysis/CloneDetection.h lib/Analysis/CloneDetection.cpp

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

zaks.anna added a comment. > -(Anna) Scan-build-py integration of the functionality is nearly finished > (see https://github.com/rizsotto/scan-build/issues/83) (--ctu switch performs > both analysis phases at once). This I think could go in a different patch, > but until we could keep the

RE: r305425 - [Preprocessor]Correct Macro-Arg allocation of StringifiedArguments,

Ah, right… This function mallocs, and is usually tossed in the Preprocessor Cache, but I’m doing an end-run around that this time. I’ll see if it is better to put it into the PP Cache, or just call ‘free’ on it. Thanks! -Erich From: Kostya Serebryany [mailto:k...@google.com] Sent: Thursday,

[PATCH] D33304: [clang-tidy][Part1] Add a new module Android and three new checks.

yawanng updated this revision to Diff 102690. yawanng added a comment. Format change. https://reviews.llvm.org/D33304 Files: clang-tidy/CMakeLists.txt clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/FileOpenFlagCheck.cpp

[PATCH] D32046: [Preprocessor]Correct Macro-Arg allocation of StringifiedArguments, correct getNumArguments

kcc added a comment. the bots complain about a leak in the new test code. Please fix/revert ASAP. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/5691/steps/check-clang%20asan/logs/stdio 28905==ERROR: LeakSanitizer: detected memory leaks

Re: r305425 - [Preprocessor]Correct Macro-Arg allocation of StringifiedArguments,

the bots complain about a leak in the new test code. Please fix/revert ASAP. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/5691/steps/check-clang%20asan/logs/stdio =28905==ERROR: LeakSanitizer: detected memory leaks Direct leak of 216 byte(s) in 1 object(s) allocated from:

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

https://sarcasm.github.io/notes/dev/compilation-database.html#cmake If you enable the CMAKE_EXPORT_COMPILE_COMMANDS option in cmake (& have a sufficiently recent cmake), then CMake will generate a compile_commands.json in the root of the build tree. The test finds this & fails, instead of finding

[PATCH] D34156: [LTO] Enable module summary emission by default for regular LTO

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. Please confirm that we can still self host with full LTO now that https://reviews.llvm.org/D33922 has landed. LGTM otherwise. Thanks! https://reviews.llvm.org/D34156

r305482 - Apply summary-based dead stripping to regular LTO modules with summaries.

Author: pcc Date: Thu Jun 15 12:26:13 2017 New Revision: 305482 URL: http://llvm.org/viewvc/llvm-project?rev=305482=rev Log: Apply summary-based dead stripping to regular LTO modules with summaries. If a regular LTO module has a summary index, then instead of linking it into the combined regular

[PATCH] D34194: [coroutines] Allow co_await and co_yield expressions that return an lvalue to compile

GorNishanov added inline comments. Comment at: test/CodeGenCoroutines/coro-await.cpp:310 + int& x = co_await a; + // CHECK: await2.ready: + // CHECK-NEXT: %[[RES2:.+]] = call dereferenceable(4) i32*

[PATCH] D34194: [coroutines] Allow co_await and co_yield expressions that return an lvalue to compile

GorNishanov added a comment. Added John McCall as he made great suggestions last time I touched emitSuspendExpression https://reviews.llvm.org/D34194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34194: [coroutines] Allow co_await and co_yield expressions that return an lvalue to compile

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM with changes https://reviews.llvm.org/D34194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34194: [coroutines] Allow co_await and co_yield expressions that return an lvalue to compile

GorNishanov requested changes to this revision. GorNishanov added inline comments. This revision now requires changes to proceed. Comment at: lib/CodeGen/CGCoroutine.cpp:255 + +static QualType getCoroutineSuspendExprReturnType(const ASTContext , + const CoroutineSuspendExpr *E)

r305480 - [analyzer]: Improve test handling with multiple constraint managers

Author: ddcc Date: Thu Jun 15 12:05:07 2017 New Revision: 305480 URL: http://llvm.org/viewvc/llvm-project?rev=305480=rev Log: [analyzer]: Improve test handling with multiple constraint managers Summary: Modify the test infrastructure to properly handle tests that require z3, and merge together

[PATCH] D33308: [analyzer]: Improve test handling with multiple constraint managers

This revision was automatically updated to reflect the committed changes. Closed by commit rL305480: [analyzer]: Improve test handling with multiple constraint managers (authored by ddcc). Changed prior to commit: https://reviews.llvm.org/D33308?vs=99394=102682#toc Repository: rL LLVM

[PATCH] D33406: PR28129 expand vector oparation to an IR constant.

spatel added a comment. Functionally, I think this is correct and complete now. See inline for some nits. Comment at: lib/CodeGen/CGBuiltin.cpp:7925 // We can't handle 8-31 immediates with native IR, use the intrinsic. Intrinsic::ID ID; Fix

[PATCH] D32751: [ASTImporter] Support new kinds of declarations (mostly Using*)

a.sidorin added inline comments. Comment at: lib/AST/ASTImporter.cpp:2993 + return nullptr; + } + szepet wrote: > nit: As I see these cases typically handled in the way: > > ``` > FrPattern = .; > ToPattern = ..; > if(FrPattern && !ToPattern) > ``` > Just

[PATCH] D32751: [ASTImporter] Support new kinds of declarations (mostly Using*)

a.sidorin updated this revision to Diff 102679. a.sidorin marked an inline comment as done. a.sidorin added a comment. Herald added a subscriber: kristof.beyls. Add a FIXME. https://reviews.llvm.org/D32751 Files: lib/AST/ASTImporter.cpp test/ASTMerge/namespace/Inputs/namespace1.cpp

  1   2   >