[PATCH] D34330: [clang-format] handle `if constexpr`

jtbandes added a comment. Thanks for the review. Please note that there was a prior effort to implement this in https://reviews.llvm.org/D26953. However if you are happy with this version, feel free to commit (as I don’t have commit access). https://reviews.llvm.org/D34330 _

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan added a comment. btw my cl version is 19.00.24215.1 (MS VS 2015 Update 3). Do you use the same one? https://reviews.llvm.org/D34279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan added a comment. I've checked once again. Werror is disabled and no /WX flag is used. So this is a compiler error in case of msvc even without these flags. https://reviews.llvm.org/D34279 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D34330: [clang-format] handle `if constexpr`

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Thanks for implementing this. https://reviews.llvm.org/D34330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D34332: path: Use string_view_t consistently

dexonsmith closed this revision. dexonsmith added a comment. Fixed in r305661. https://reviews.llvm.org/D34332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r305661 - path: Use string_view_t consistently

Author: dexonsmith Date: Sun Jun 18 23:27:41 2017 New Revision: 305661 URL: http://llvm.org/viewvc/llvm-project?rev=305661&view=rev Log: path: Use string_view_t consistently Most of filesystem/path.cpp uses string_view_t. This fixes the two spots that use string_view directly. https://reviews.ll

[PATCH] D34329: [GSoC] Clang AST diffing

johannes updated this revision to Diff 102986. https://reviews.llvm.org/D34329 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp lib/Tooling/ASTDiff/CMakeLists.txt lib/Tooling/CMakeLists.txt tools/CMakeLists.txt tools/clang-diff/CMakeLists.txt tools/clan

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

This revision was automatically updated to reflect the committed changes. Closed by commit rL305659: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler (authored by xiangzhai). Changed prior to commit: https://reviews.llvm.org/D31320?vs=102840&id=102984#toc Repository: rL LLVM ht

r305659 - [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

Author: xiangzhai Date: Sun Jun 18 20:55:50 2017 New Revision: 305659 URL: http://llvm.org/viewvc/llvm-project?rev=305659&view=rev Log: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler Reviewers: v.g.vassilev, zaks.anna, NoQ, teemperor Reviewed By: v.g.vassilev, zaks.anna, NoQ, teem

[PATCH] D33383: [GSoC] Flag value completion for clang

yamaguchi updated this revision to Diff 102982. yamaguchi added a comment. Add support and test for -cl-std=,-fno-sanitize-coverage=,-ffp-contract=,-flto=,-fveclib=,-fshow-overloads=,-fvisibility=,-mfloat-abi=,-mthread-model. https://reviews.llvm.org/D33383 Files: clang/include/clang/Driver/

[PATCH] D33383: [GSoC] Flag value completion for clang

yamaguchi updated this revision to Diff 102981. yamaguchi marked 6 inline comments as done. yamaguchi added a comment. Update code comment according to Rui's comment. https://reviews.llvm.org/D33383 Files: clang/include/clang/Driver/Options.h clang/include/clang/Driver/Options.td clang/li

[PATCH] D34332: path: Use string_view_t consistently

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Thanks! https://reviews.llvm.org/D34332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

teemperor accepted this revision. teemperor added a comment. LGTM, thanks for the patch! Repository: rL LLVM https://reviews.llvm.org/D31320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D34332: path: Use string_view_t consistently

dexonsmith created this revision. Most of filesystem/path.cpp uses `string_view_t`. This fixes the two spots that use `string_view` directly. https://reviews.llvm.org/D34332 Files: libcxx/src/experimental/filesystem/path.cpp Index: libcxx/src/experimental/filesystem/path.cpp =

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

dexonsmith created this revision. Be defensive against a reentrant std::function::operator=(), in case the held function object has a non-trivial destructor. Destroying the function object in-place can lead to the destructor being called twice. rdar://problem/32836603 https://reviews.llvm.or

[PATCH] D26953: clang-format: handle formatting on constexpr if

jtbandes added a comment. Hm, I probably should've searched first — but I just re-implemented this in https://reviews.llvm.org/D34330. Actually, I think my implementation solves the `AllowShortIfStatementsOnASingleLine` issue you were mentioning here 🎉 https://reviews.llvm.org/D26953 _

[PATCH] D34330: [clang-format] handle `if constexpr`

jtbandes created this revision. Herald added a subscriber: klimek. Changes to handle `if constexpr` the same way as `if`. https://reviews.llvm.org/D34330 Files: lib/Format/ContinuationIndenter.cpp lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTe

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

> On 2017-Jun-18, at 10:46, Duncan P. N. Exon Smith > wrote: > >> >> On 2017-Jun-16, at 05:58, Duncan Exon Smith > > wrote: >> >> >> On Jun 15, 2017, at 22:22, Eric Fiselier > > wrote: >> >>> >>> >>> On Thu, Jun 15, 2017 at 11:00 PM, Dunca

Re: [libcxx] r276238 - Implement std::string_view as described in http://wg21.link/P0254R1. Reviewed as https://reviews.llvm.org/D21459

> On 2017-Jun-16, at 05:58, Duncan Exon Smith wrote: > > > On Jun 15, 2017, at 22:22, Eric Fiselier mailto:e...@efcs.ca>> > wrote: > >> >> >> On Thu, Jun 15, 2017 at 11:00 PM, Duncan P. N. Exon Smith >> mailto:dexonsm...@apple.com>> wrote: >> Your suggestion is essentially to replace exper

[libcxx] r305649 - iostreams: Fix deployment target for streams dylib support

Author: dexonsmith Date: Sun Jun 18 11:50:23 2017 New Revision: 305649 URL: http://llvm.org/viewvc/llvm-project?rev=305649&view=rev Log: iostreams: Fix deployment target for streams dylib support Fix an off-by-one in r302172, which triggered building local versions of the iostreams when deploying

[PATCH] D34329: [GSoC] Clang AST diffing

johannes created this revision. Herald added subscribers: mgorny, klimek. https://reviews.llvm.org/D34329 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp lib/Tooling/ASTDiff/CMakeLists.txt lib/Tooling/CMakeLists.txt tools/CMakeLists.txt tools/clang-diff/

[PATCH] D33383: [GSoC] Flag value completion for clang

ruiu added a comment. Yuka, This is beautiful. Overall looking pretty good. Some minor stylistic comments. Comment at: clang/include/clang/Driver/Options.h:43 +#define OPTION(PREFIX, NAME, ID, KIND, GROUP, ALIAS, ALIASARGS, FLAGS, PARAM, \ + HELPTEXT, METAVAR,

[libcxx] r305648 - func.wrap.func.con: Fix test comment

Author: dexonsmith Date: Sun Jun 18 10:34:47 2017 New Revision: 305648 URL: http://llvm.org/viewvc/llvm-project?rev=305648&view=rev Log: func.wrap.func.con: Fix test comment This tests moving `function`, not `const function`. Modified: libcxx/trunk/test/std/utilities/function.objects/func.w

[PATCH] D33177: any: Add availability for experimental::bad_any_cast

dexonsmith closed this revision. dexonsmith added a comment. Committed in r305647. https://reviews.llvm.org/D33177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r305647 - any: Add availability for experimental::bad_any_cast

Author: dexonsmith Date: Sun Jun 18 09:52:26 2017 New Revision: 305647 URL: http://llvm.org/viewvc/llvm-project?rev=305647&view=rev Log: any: Add availability for experimental::bad_any_cast As a follow up to r302172, add missing availability for bad_any_cast. rdar://problem/32161524 Modified:

[PATCH] D33383: [GSoC] Flag value completion for clang

yamaguchi updated this revision to Diff 102964. yamaguchi added a comment. Made a trivial change in optionMatches. https://reviews.llvm.org/D33383 Files: clang/include/clang/Driver/Options.h clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp clang/lib/Driver/DriverOptions