Author: arphaman
Date: Mon Jun 19 06:25:37 2017
New Revision: 305680
URL: http://llvm.org/viewvc/llvm-project?rev=305680&view=rev
Log:
Add missing OS check to r305678
That commit failed on non-macOS buildbots as I've forgotten to make sure that
the system on which Clang is running on is actually
bader requested changes to this revision.
bader added a comment.
This revision now requires changes to proceed.
Please, split this patch into two parts:
1. Improve diagnostics on extension enabling.
2. Add missing `sub_group_*` built-in functions.
Comment at: Sema/SemaChecking
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305678: [driver][macOS] Pick the system version for the
deployment target (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D34175?vs=102607&id=103009#toc
Repository:
rL LLVM
Author: arphaman
Date: Mon Jun 19 05:57:27 2017
New Revision: 305678
URL: http://llvm.org/viewvc/llvm-project?rev=305678&view=rev
Log:
[driver][macOS] Pick the system version for the deployment target
if the SDK is newer than the system
This commit improves the driver by making sure that it picks
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:339
Left->Type = TT_JsComputedPropertyName;
+ } else if ((Style.Language == FormatStyle::LK_Cpp ||
+ Style.Language == FormatStyle::LK_ObjC) &&
Use Style.isCpp
teemperor added inline comments.
Comment at: cfe/trunk/include/clang/Analysis/CloneDetection.h:324
+struct AutoGeneratedCloneConstraint {
+ StringRef IgnoredFilesPattern;
xiangzhai wrote:
> v.g.vassilev wrote:
> > Shouldn't the name be more generic. What this
teemperor accepted this revision.
teemperor added a comment.
LGTM.
https://reviews.llvm.org/D33383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.
LGTM. My comments can be addressed in a separate patch.
Comment at: clang/include/clang/Driver/Options.td:496
def cl_std_EQ : Joined<["-"], "cl-std=">, Group,
F
voskresensky.vladimir added a comment.
In https://reviews.llvm.org/D34263#782391, @akyrtzi wrote:
> Hey Vladimir, what you are proposing is orthogonal to this patch. You are
> proposing for "the client to provide the value for an undefined identifier",
> and the patch is about the client not kn
yvvan added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:2453
std::string PlaceholderStr = FormatFunctionParameter(Policy, Param);
+if (Param->hasDefaultArg() && PlaceholderStr.find("=") ==
std::string::npos) {
+std::string DefaultValue =
-
klimek added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:2453
std::string PlaceholderStr = FormatFunctionParameter(Policy, Param);
+if (Param->hasDefaultArg() && PlaceholderStr.find("=") ==
std::string::npos) {
+std::string DefaultValue =
danielmarjamaki abandoned this revision.
danielmarjamaki added a comment.
I will not continue working on this checker
Repository:
rL LLVM
https://reviews.llvm.org/D32346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
klimek added inline comments.
Comment at: lib/Format/UsingDeclarationsSorter.cpp:41-42
+
+bool computeUsingDeclarationLabel(const FormatToken *UsingTok,
+ std::string *Label) {
+ assert(UsingTok && UsingTok->is(tok::kw_using) && "Expecting a usin
This revision was automatically updated to reflect the committed changes.
danielmarjamaki marked an inline comment as done.
Closed by commit rL305669: [analyzer] Fix logical not for pointers with
different bit width (authored by danielmarjamaki).
Changed prior to commit:
https://reviews.llvm.or
Author: danielmarjamaki
Date: Mon Jun 19 03:55:51 2017
New Revision: 305669
URL: http://llvm.org/viewvc/llvm-project?rev=305669&view=rev
Log:
[analyzer] Fix logical not for pointers with different bit width
Differential Revision: https://reviews.llvm.org/D31029
Modified:
cfe/trunk/include/c
On Fri, Jun 16, 2017 at 8:26 PM Dan Ciliske via Phabricator <
revi...@reviews.llvm.org> wrote:
> dciliske added a comment.
>
> So... how should I get something added? That patch has been sitting for a
> couple weeks.
>
> Should I work on that patch? If so, how do I work on it? This is the first
>
klimek added inline comments.
Comment at: include/clang/Frontend/PrecompiledPreamble.h:42-43
+/// destructors.
+/// An assertion will fire if two PCHTempFiles are created with the same name,
+/// so it's not intended to be used outside preamble-handling.
+class TempPCHFile {
bader created this revision.
Constant samplers are handled as static variables and clang's code generation
library, which leads to llvm::unreachable. We bypass emitting sampler variable
as static since it's translated to a function call later.
https://reviews.llvm.org/D34342
Files:
lib/CodeGe
Typz added a comment.
ping
https://reviews.llvm.org/D33491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz added a comment.
@krasimir, @alexfh : can I get some feedback?
This patch solves a practical problem, i.e. allowing the comment to overflow a
bit without triggering a reflow [according to the priorities which are in
config, obviously]. It may not always provide the "best" wrapping, but as
Author: mpark
Date: Mon Jun 19 03:25:57 2017
New Revision: 305668
URL: http://llvm.org/viewvc/llvm-project?rev=305668&view=rev
Log:
Add a missing SFINAE condition to the `variant`'s converting constructor.
Remarks: This function shall not participate in overload resolution unless
`is_sam
klimek added a comment.
Generally this patch lg from my side - how many patches for single file mode
are coming down the road, though? I'm somewhat concerned about the overall
complexity it'll add to clang.
When I saw your first patch my reaction was "wow, this works with this little
change - c
xiangzhai added inline comments.
Comment at: cfe/trunk/include/clang/Analysis/CloneDetection.h:324
+struct AutoGeneratedCloneConstraint {
+ StringRef IgnoredFilesPattern;
v.g.vassilev wrote:
> Shouldn't the name be more generic. What this essentially does is t
ilya-biryukov added inline comments.
Comment at: include/clang/Frontend/PrecompiledPreamble.h:248
+/// doesn't restore the state \p CI had before calling AddImplicitPreamble,
only
+/// clears relevant settings, so that preamble is disabled in \p CI.
+} // namespace clang
---
ilya-biryukov updated this revision to Diff 102993.
ilya-biryukov added a comment.
Removed a stray comment (of a previously removed declaration).
https://reviews.llvm.org/D34287
Files:
include/clang/Frontend/ASTUnit.h
include/clang/Frontend/PrecompiledPreamble.h
lib/Frontend/ASTUnit.cpp
hokein accepted this revision.
hokein added a comment.
The code looks good to me now, I'd wait to see whether @alexfh has further
comments before submitting the patch. Thanks for your patience with the review
;)
Comment at: clang-tidy/android/FileOpenFlagCheck.cpp:61
+ Sourc
klimek added a comment.
I think a better way might be to generally leave dependency options alone, add
a default argument adapter to filter out all deps related flags, and allow
users to add their own argument adapters that don't do that.
https://reviews.llvm.org/D34304
v.g.vassilev added inline comments.
Comment at: cfe/trunk/include/clang/Analysis/CloneDetection.h:324
+struct AutoGeneratedCloneConstraint {
+ StringRef IgnoredFilesPattern;
Shouldn't the name be more generic. What this essentially does is to filter out
false
hokein added a comment.
In https://reviews.llvm.org/D34206#780455, @Eugene.Zelenko wrote:
> It'll be good idea to run modernize-make-unique on LLVM/Clang/etc for
> llvm::make_unique.
+1. See https://reviews.llvm.org/D34334, https://reviews.llvm.org/D34333. And
found a few bugs in the check, w
djasper closed this revision.
djasper added a comment.
Renamed Tok to RecordTok to avoid the nested scope and submitted as r305667.
https://reviews.llvm.org/D32825
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: djasper
Date: Mon Jun 19 02:45:41 2017
New Revision: 305667
URL: http://llvm.org/viewvc/llvm-project?rev=305667&view=rev
Log:
clang-format: Improve understanding of combined typedef+record declarations
Fixes an issue where struct A { int X; }; would be broken onto multiple
lines, but type
djasper closed this revision.
djasper added a comment.
Submitted the other implementation of this as r305666.
https://reviews.llvm.org/D26953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
djasper closed this revision.
djasper added a comment.
Yes, I saw. As this version seems to handle the one-line case correctly, I
submitted this one as r305666.
https://reviews.llvm.org/D34330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: djasper
Date: Mon Jun 19 02:40:49 2017
New Revision: 305666
URL: http://llvm.org/viewvc/llvm-project?rev=305666&view=rev
Log:
clang-format: Handle "if constexpr".
c++1z adds the following constructions to the language:
if constexpr (cond)
statement1;
else if constexpr (cond)
Author: djasper
Date: Mon Jun 19 02:30:04 2017
New Revision: 305665
URL: http://llvm.org/viewvc/llvm-project?rev=305665&view=rev
Log:
clang-format: Add capability to format the diff on save in vim.
With this patch, one can configure a BufWrite hook that will make the
clang-format integration comp
101 - 135 of 135 matches
Mail list logo
