nemanjai added subscribers: iains, echristo.
nemanjai added a comment.
I'm not sure how much expertise there is for PPC32-Darwin. Perhaps @iains might
be able to offer some insight here. Also, @echristo might have a thing or two
to say in this regard.
Repository:
rL LLVM
https://reviews.llv
rnk added a comment.
Saleem, didn't something change here two months ago? Why do we want to bother
with all of this dllimport stuff in the frontend? It seems to break mingw and
add complexity for very little gain (avoiding linker provided thunks).
Repository:
rL LLVM
https://reviews.llvm.or
Author: ssrivastava
Date: Tue Jun 20 17:08:44 2017
New Revision: 305862
URL: http://llvm.org/viewvc/llvm-project?rev=305862&view=rev
Log:
Prevent devirtualization of calls to un-instantiated functions.
PR 27895
Differential Revision: https://reviews.llvm.org/D22057
Added:
cfe/trunk/test/Cod
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305862: Prevent devirtualization of calls to un-instantiated
functions. (authored by ssrivastava).
Changed prior to commit:
https://reviews.llvm.org/D22057?vs=71432&id=103273#toc
Repository:
rL LLVM
saugustine added a comment.
In https://reviews.llvm.org/D34304#785083, @klimek wrote:
> I think it's cleaner, because it uses a concept we already have (argument
> adapters).
Will you point me to an example of these. Google is coming up empty.
https://reviews.llvm.org/D34304
_
apazos created this revision.
Herald added subscribers: kristof.beyls, javed.absar, srhines, aemerson.
Unified logic for computing target ABI in backend and front end by moving this
common code to Support/TargetParser.
Modeled Triple::GNU after front end code (aapcs abi) and updated tests that
On 20 June 2017 at 14:30, Lang Hames via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: lhames
> Date: Tue Jun 20 16:30:43 2017
> New Revision: 305860
>
> URL: http://llvm.org/viewvc/llvm-project?rev=305860&view=rev
> Log:
> Special-case handling of destructors in override lists when d
manojgupta created this revision.
If a .h file is specifed as input, it gets compiled to a PCH file.
Handle the PCH Action and do not throw the error:
"cannot specify -o when generating multiple output files"
This fixes PR33533.
https://reviews.llvm.org/D34426
Files:
lib/Driver/Driver.cpp
manojgupta updated this revision to Diff 103280.
https://reviews.llvm.org/D34426
Files:
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Driver.cpp
+++ lib/Driver/Driver.cpp
@@ -2759,7 +2759,7 @@
if (Final
Should be fixed in r305860.
- Lang.
On Tue, Jun 20, 2017 at 2:19 PM, Lang Hames wrote:
> Oops - this broke Sema/ms_class_layout.cpp. Looking in to it now...
>
> - Lang.
>
> On Tue, Jun 20, 2017 at 2:06 PM, Lang Hames via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: lhames
>>
rsmith added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:4088-4089
// C++1z [meta.unary.prop]:
// remove_all_extents_t shall be a complete type or cv void.
case UTT_IsAggregate:
Please move the UTT_Has* cases up here, since this is the rule
bruno updated this revision to Diff 103287.
bruno retitled this revision from "Support MS builtins using 'long' on
Darwin/LP64" to "Support MS builtins using 'long' on LP64".
bruno edited the summary of this revision.
bruno added a comment.
New patch addressing comments from reviewers.
https://
saugustine added a comment.
In https://reviews.llvm.org/D34304#785984, @saugustine wrote:
> In https://reviews.llvm.org/D34304#785083, @klimek wrote:
>
> > I think it's cleaner, because it uses a concept we already have (argument
> > adapters).
>
>
> Will you point me to an example of these. Goo
iid_iunknown created this revision.
iid_iunknown added a project: clang.
This is a patch for PR33484.
The clang's typo correction logic may fall into an infinite loop when reaching
the typo correction limit.
When some complex expression has multiple typos in it, clang finds possible
corrections
iid_iunknown updated this revision to Diff 103297.
iid_iunknown added a comment.
Fixed white spaces.
Repository:
rL LLVM
https://reviews.llvm.org/D34430
Files:
lib/Sema/SemaExprCXX.cpp
Index: lib/Sema/SemaExprCXX.cpp
===
---
rnk added inline comments.
Comment at: include/clang/Basic/Builtins.def:55
// W -> int64_t
+// N -> 'L' if target is LP64, 'int' size otherwise.
// S -> signed
Fix the comment? "long" if target is LLP64, "int" otherwise?
Comment at:
rsmith added inline comments.
Comment at: include/clang/Basic/AttrDocs.td:608-611
declarations and definitions. Most importantly, if any function with a given
name is given the ``overloadable`` attribute, then all function declarations
and definitions with that name (and in t
bruno marked 3 inline comments as done.
bruno added inline comments.
Comment at: test/CodeGen/ms-intrinsics-darwin.c:1
+// RUN: %clang_cc1 -ffreestanding -fms-extensions \
+// RUN: -triple x86_64--darwin -Oz -emit-llvm %s -o - \
rnk wrote:
> I'd rather ge
bruno updated this revision to Diff 103315.
bruno marked an inline comment as done.
bruno added a comment.
Addressing comments!
https://reviews.llvm.org/D34377
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/BuiltinsARM.def
include/clang/Basic/BuiltinsX86.def
include/clang/B
rnk accepted this revision.
rnk added a comment.
lgtm, thanks for shuffling all the tests around!
https://reviews.llvm.org/D34377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rtrieu
Date: Tue Jun 20 20:43:13 2017
New Revision: 305872
URL: http://llvm.org/viewvc/llvm-project?rev=305872&view=rev
Log:
[ODRHash] Supply more information when generic error message is emitted.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td
cfe/trunk/l
manojgupta added a comment.
I am not sure what is the expected behavior. Maybe clang is doing the right
thing in rejecting.
But, this creates an issue in ChromeOS land where a package fails to build with
clang (https://bugs.chromium.org/p/chromium/issues/detail?id=735206).
https://reviews.llv
Author: bruno
Date: Tue Jun 20 21:20:40 2017
New Revision: 305874
URL: http://llvm.org/viewvc/llvm-project?rev=305874&view=rev
Log:
Run dos2unix on ms-intrinsics-rotations.c test. NFC
Modified:
cfe/trunk/test/CodeGen/ms-intrinsics-rotations.c
Modified: cfe/trunk/test/CodeGen/ms-intrinsics-ro
Author: bruno
Date: Tue Jun 20 21:20:46 2017
New Revision: 305875
URL: http://llvm.org/viewvc/llvm-project?rev=305875&view=rev
Log:
Support MS builtins using 'long' on LP64 platforms
This allows for -fms-extensions to work the same on LP64. For example,
_BitScanReverse is expected to be 32-bit, m
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305875: Support MS builtins using 'long' on LP64 platforms
(authored by bruno).
Changed prior to commit:
https://reviews.llvm.org/D34377?vs=103315&id=103318#toc
Repository:
rL LLVM
https://reviews.l
Author: teemperor
Date: Wed Jun 21 00:41:39 2017
New Revision: 305878
URL: http://llvm.org/viewvc/llvm-project?rev=305878&view=rev
Log:
Changed wording in comment
Modified:
cfe/trunk/lib/Analysis/CloneDetection.cpp
Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp
URL:
http://llvm.org/vie
johannes updated this revision to Diff 103320.
johannes added a comment.
- Fix a bug in getSimilarity()
- Change terminology: `label` -> `value`
- Define SNodeId: Now it cannot be implicitly constructed from an int, however
it can be converted to int. Still feels a bit weird
- Fix some issues wit
yvvan added a comment.
I've tried once again to make a clean build and it worked... :)
And I can't imagine what kind of configuration issue could it be because I
always use quite the same one :)
https://reviews.llvm.org/D34279
___
cfe-commits maili
101 - 128 of 128 matches
Mail list logo
