Re: r306127 - [GSoC] Add support for CC1 options.

On Mon, Jun 26, 2017 at 10:17 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I think that we shouldn't be providing completion for `-cc1` options. > `-cc1as` options are fine as the IAS serves as a replacement for the > traditional unix `as`. But, the

Re: r306127 - [GSoC] Add support for CC1 options.

I think that we shouldn't be providing completion for `-cc1` options. `-cc1as` options are fine as the IAS serves as a replacement for the traditional unix `as`. But, the `NoDriverOption` values shouldn't be exposed to users. They are internal details, with no compatibility. If users start

[PATCH] D34665: [CodeGen] Fix assertion failure in EmitCallArg

ahatanak created this revision. The assertion is checking that the types of the parameter and argument match. It fails when a method of a parameterized class is called. To fix the failure, this patch moves the assertion in EmitCallArg to its only caller EmitCallArgs. Instead of moving the

Re: r297702 - [CodeGen][ObjC] Fix a bug where the type of an ivar wasn't encoded

This should be fixed in r306364. > On Jun 22, 2017, at 1:26 PM, Akira Hatanaka wrote: > > According to the documentation, the starting position of the field has to be > encoded too: > > https://gcc.gnu.org/onlinedocs/gcc/Type-encoding.html >

r306364 - [CodeGen][ObjC] Fix GNU's encoding of bit-field ivars.

Author: ahatanak Date: Mon Jun 26 21:34:04 2017 New Revision: 306364 URL: http://llvm.org/viewvc/llvm-project?rev=306364=rev Log: [CodeGen][ObjC] Fix GNU's encoding of bit-field ivars. According to the documentation, when encoding a bit-field, GNU runtime needs its starting position in addition

[PATCH] D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT

compnerd added a comment. Thinking more about this, on Windows, is there a strong reason to default to a different libc by default on Windows? @bruno would reusing `-ffreestanding` work for you here? Or is there something else that we can identify about the target environment that can

[PATCH] D34018: Support __float128 on NetBSD libstdc++ x86/x86_64

krytarowski added a comment. Joerg declines to take this patch as it is, as there is no compiler-rt support for __float128 on i386 in compiler-rt. GCC knows __float128 on i386, amd64, i64, hppa, powerpc [some variations]; currently I focus on i386/amd64. My proposal was to check if there is

Re: r305850 - Preserve CXX method overrides in ASTImporter

On Tue, Jun 20, 2017 at 2:06 PM Lang Hames via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: lhames > Date: Tue Jun 20 16:06:00 2017 > New Revision: 305850 > > URL: http://llvm.org/viewvc/llvm-project?rev=305850=rev > Log: > Preserve CXX method overrides in ASTImporter > > Summary: >

[PATCH] D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT

bcraig added a comment. LGTM, but you should probably get approval from somebody a bit more senior with the project. Comment at: include/__config:234-235 +// a MS compatibility version is specified. # ifndef __MINGW32__ -#define _LIBCPP_MSVCRT // Using Microsoft's C

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

On Mon, Jun 26, 2017 at 5:31 AM Serge Pavlov wrote: > 2017-06-26 4:05 GMT+07:00 David Blaikie : > >> Ah, I see now then. >> >> I have a symlink from the root of my source directory pointing to the >> compile_commands.json in my build directory. >> >> I

[PATCH] D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax

rnk added inline comments. Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:1382 +if (const MCConstantExpr *CE = +dyn_cast_or_null(Val)) { + StringRef ErrMsg; rnk wrote: > Please use clang-format here and elsewhere not

[PATCH] D34018: Support __float128 on NetBSD libstdc++ x86/x86_64

rnk added a comment. I think there's something wrong with clang's implementation of __float128. It seems fundamentally incompatible with libstdc++'s __is_floating_point_helper mechanism. We can definitely take this patch to unblock things, but we should file a bug about investigating this all

r306350 - Remove redundant check.

Author: rsmith Date: Mon Jun 26 17:29:32 2017 New Revision: 306350 URL: http://llvm.org/viewvc/llvm-project?rev=306350=rev Log: Remove redundant check. Modified: cfe/trunk/lib/Serialization/ASTReader.cpp Modified: cfe/trunk/lib/Serialization/ASTReader.cpp URL:

[PATCH] D34590: [ubsan] Diagnose invalid uses of builtins (clang)

efriedma resigned from this revision. efriedma added a comment. The check itself looks okay, but I'm not really familiar with the other ubsan bits. https://reviews.llvm.org/D34590 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r306349 - Fix this test to use a construct that actually forces struct layout to happen when testing -Wpadded.

Author: rsmith Date: Mon Jun 26 17:22:07 2017 New Revision: 306349 URL: http://llvm.org/viewvc/llvm-project?rev=306349=rev Log: Fix this test to use a construct that actually forces struct layout to happen when testing -Wpadded. Modified: cfe/trunk/test/Modules/diag-flags.cpp Modified:

[PATCH] D34415: Allow passing a regex for headers to exclude from clang-tidy

toddlipcon abandoned this revision. toddlipcon added a comment. Re-posted as https://reviews.llvm.org/D34654 Repository: rL LLVM https://reviews.llvm.org/D34415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

toddlipcon created this revision. toddlipcon added a project: clang-tools-extra. Herald added a subscriber: JDevlieghere. This patch adds the ability to specify a regex of headers to exclude from clang-tidy diagnostics. This is the inverse of the existing header regex. In our project we want to

[PATCH] D34091: Support for querying the exception specification type through libclang

jbcoe added a comment. I can merge this for you Andrew. https://reviews.llvm.org/D34091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

compnerd closed this revision. compnerd added a comment. SVN r306347 Thanks @efriedma and @majnemer! https://reviews.llvm.org/D34523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r306347 - AST: enhance mangling for blocks with MS ABI

Author: compnerd Date: Mon Jun 26 16:28:42 2017 New Revision: 306347 URL: http://llvm.org/viewvc/llvm-project?rev=306347=rev Log: AST: enhance mangling for blocks with MS ABI When generating the decorated name for a static variable inside a BlockDecl, construct a scope for the block invocation

r306346 - Revert r301742, which caused us to try to evaluate all full-expressions.

Author: rsmith Date: Mon Jun 26 16:19:32 2017 New Revision: 306346 URL: http://llvm.org/viewvc/llvm-project?rev=306346=rev Log: Revert r301742, which caused us to try to evaluate all full-expressions. Also add testcases for a bunch of expression forms that cause our evaluator to crash. See

[PATCH] D34329: [GSoC] Clang AST diffing

ruiu added a comment. I'd copy what Hal mentioned in other review thread for other GSoC project. You don't want to tag your patches with "[GSoC]" because it doesn't describe anything about patch contents and many other unrelated patches could have been tagged as single "[GSoC]" tag. Instead,

[PATCH] D34496: [clang] Fix printf check for CFIndex

This revision was automatically updated to reflect the committed changes. Closed by commit rL306343: [clang] Enable printf check for CFIndex (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D34496?vs=103536=104038#toc Repository: rL LLVM

r306343 - [clang] Enable printf check for CFIndex

Author: alexshap Date: Mon Jun 26 16:02:27 2017 New Revision: 306343 URL: http://llvm.org/viewvc/llvm-project?rev=306343=rev Log: [clang] Enable printf check for CFIndex According to

[PATCH] D34329: [GSoC] Clang AST diffing

johannes updated this revision to Diff 104032. johannes added a comment. refactor https://reviews.llvm.org/D34329 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTDiffInternal.h lib/Tooling/ASTDiff/ASTDiff.cpp lib/Tooling/ASTDiff/CMakeLists.txt

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

efriedma added a comment. LGTM (with the caveat that I don't know anything about Microsoft mangling). https://reviews.llvm.org/D34523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34649: Remove addtional parameters in function std::next() and std::prev()

Quuxplusone added inline comments. Comment at: include/iterator:619 template inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX14 Might fix the spelling error in "BidirectionalIter" while you're here. https://reviews.llvm.org/D34649

[PATCH] D34649: Remove addtional parameters in function std::next() and std::prev()

jasonliu created this revision. Creating a function pointer with proper parameters pointing to std::next() or std::prev() should work. This change moves the invented paramater for enable_if over to the return type to resolve this QoI issue. https://reviews.llvm.org/D34649 Files:

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

compnerd updated this revision to Diff 104028. compnerd added a comment. Handle unnamed parameters, improve mangling for NSDMis. The one case that we dont handle currently causes an assertion even in itanium mode. https://reviews.llvm.org/D34523 Files: lib/AST/MicrosoftMangle.cpp

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

compnerd marked 2 inline comments as done. compnerd added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:988 + if (const auto *RD = dyn_cast(DC)) +mangleName(RD); + else compnerd wrote: > efriedma wrote: > > The call to mangleName()

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

efriedma added inline comments. Comment at: test/CodeGenCXX/msabi-blocks.cpp:90 +} + compnerd wrote: > efriedma wrote: > > The Itanium ABI document lists five cases where the mangling is externally > > visible. I think this is missing a testcase for the

RE: r306149 - Emit warning when throw exception in destruct or dealloc functions which has a

Sorry Richard, I thought I gave you enough time before committing this for Jen. Adding her so she can respond to your comments and fix these. Thanks, Erich From: meta...@gmail.com [mailto:meta...@gmail.com] On Behalf Of Richard Smith Sent: Monday, June 26, 2017 2:25 PM To: Keane, Erich

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

compnerd marked 2 inline comments as done. compnerd added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:988 + if (const auto *RD = dyn_cast(DC)) +mangleName(RD); + else efriedma wrote: > The call to mangleName() looks a little

Few builders are off-line for maintenance

Hello everyone, I took few builders off-line for maintenance. Builders: llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast clang-with-lto-ubuntu clang-with-thin-lto-ubuntu Thank you for understanding. Thanks Galina ___ cfe-commits mailing list

Re: r306149 - Emit warning when throw exception in destruct or dealloc functions which has a

On 23 June 2017 at 13:22, Erich Keane via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: erichkeane > Date: Fri Jun 23 15:22:19 2017 > New Revision: 306149 > > URL: http://llvm.org/viewvc/llvm-project?rev=306149=rev > Log: > Emit warning when throw exception in destruct or dealloc

[PATCH] D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library

dexonsmith added a comment. In https://reviews.llvm.org/D34574#791158, @rsmith wrote: > Should we also remove the recently-added availability attributes in libc++ > too? If I'm using a recent libc++ and providing my own aligned allocation > functions, we shouldn't reject attempts to call those

[PATCH] D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library

rsmith added a comment. In https://reviews.llvm.org/D34574#791157, @dexonsmith wrote: > Likely, something like `-Werror=aligned-allocation-availability` (by default). An error by default seems OK if accompanied with a "use -faligned-allocation if you supply your own aligned allocation

[PATCH] D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library

rsmith added a comment. So the driver would pass a flag to the frontend to indicate "this target probably doesn't have aligned allocation support", and Sema would produce a warning if it selects an aligned allocation function when that flag is specified? That makes sense to me. Should we also

[PATCH] D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library

dexonsmith added a comment. In https://reviews.llvm.org/D34574#791124, @ahatanak wrote: > Duncan and I had a discussion on this. > > We are thinking about adding a warning that tells users that aligned > allocation /deallocation operators are being called but they are not defined > in the

[PATCH] D33833: Fix PR 33189: Clang assertion on template destructor declaration

kuang_he updated this revision to Diff 104018. https://reviews.llvm.org/D33833 Files: lib/AST/DeclCXX.cpp test/SemaTemplate/destructor-template.cpp Index: test/SemaTemplate/destructor-template.cpp === ---

[PATCH] D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library

ahatanak added a comment. Duncan and I had a discussion on this. We are thinking about adding a warning that tells users that aligned allocation /deallocation operators are being called but they are not defined in the library. If the users haven't defined their own aligned allocation /

[PATCH] D16403: Add scope information to CFG

zaks.anna added a comment. > @dcoughlin As a reviewer of both patches - could you tell us what's the > difference between them? And how are we going to resolve this issue? Unfortunately, @dcoughlin is on vacation this week; should be back next week. Repository: rL LLVM

[PATCH] D34444: Teach codegen to work in incremental processing mode.

rsmith added a comment. This makes sense to me, but I'd like John's input on whether this is a reasonable facility for CodeGen to have, and whether this is sufficient for (for example) inline function definitions to be emitted at the right times into the right `Module`s. (The tests for this

[PATCH] D34059: Get the file name for the symbol from the Module, not the SourceManager.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good, thanks! https://reviews.llvm.org/D34059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34510: Teach clang how to merge typedef over anonymous structs in C mode.

rsmith added a comment. https://reviews.llvm.org/D31778 is related. We need to have a design for how ODR-like issues in C will be resolved before we'll know what the right fix is here. Prior to https://reviews.llvm.org/D31778 my intention had been to implement C's structural typing

[PATCH] D34506: Relax an assert in the comparison of source locations

akyrtzi added a comment. `FullSourceLoc` could be useful, it wraps the SourceManager that the SourceLocation come from. Repository: rL LLVM https://reviews.llvm.org/D34506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

rsmith added a comment. What's the status of this patch? https://reviews.llvm.org/D34510 is touching on a related issue, and we need to resolve how we're going to deal with ODR-like issues in C to determine how to address the issue that it is tackling. https://reviews.llvm.org/D31778

[PATCH] D34506: Relax an assert in the comparison of source locations

akyrtzi added a comment. Comparing SourceLocations from different translation units is not meaningful and my concern is that treating source locations like this can very easy lead to errors where by mistake the code is resolving a SourceLocation with the wrong translation unit and not the

r306327 - Check that the initializer of a non-dependent constexpr variable is constant even within templates.

Author: rsmith Date: Mon Jun 26 13:33:42 2017 New Revision: 306327 URL: http://llvm.org/viewvc/llvm-project?rev=306327=rev Log: Check that the initializer of a non-dependent constexpr variable is constant even within templates. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp

r306325 - Remove some redundant setup when preprocessing .pcm files.

Author: rsmith Date: Mon Jun 26 13:15:21 2017 New Revision: 306325 URL: http://llvm.org/viewvc/llvm-project?rev=306325=rev Log: Remove some redundant setup when preprocessing .pcm files. Both of these steps are immediately overwritten by the FrontendAction setup. Modified:

[PATCH] D34508: [Analyzer] Bug Reporter Visitor to Display Values of Variables - PRELIMINARY!

NoQ added a comment. In a perfect world, the analyzer's report would work like a debugger: jumping through stack frames, or even through diagnostic pieces, and printing symbolic values of variables at every piece would be really great. I'm not entirely understanding the behavior you intend to

r306320 - When preprocessing with -frewrite-imports and -fmodule-file=, do not pass all

Author: rsmith Date: Mon Jun 26 12:39:25 2017 New Revision: 306320 URL: http://llvm.org/viewvc/llvm-project?rev=306320=rev Log: When preprocessing with -frewrite-imports and -fmodule-file=, do not pass all modules to preprocessing of nested .pcm files. Making those module files available results

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

efriedma added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:988 + if (const auto *RD = dyn_cast(DC)) +mangleName(RD); + else The call to mangleName() looks a little weird... I would have expected a call to mangleUnqualifiedName or

[PATCH] D33606: [Sema] Fix a crash-on-invalid when a template parameter list has a class definition or non-reference class type

This revision was automatically updated to reflect the committed changes. Closed by commit rL306317: [Sema] Fix a crash-on-invalid when a template parameter list has a class (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D33606?vs=100465=104000#toc Repository: rL

r306317 - [Sema] Fix a crash-on-invalid when a template parameter list has a class

Author: ahatanak Date: Mon Jun 26 11:46:12 2017 New Revision: 306317 URL: http://llvm.org/viewvc/llvm-project?rev=306317=rev Log: [Sema] Fix a crash-on-invalid when a template parameter list has a class definition or non-reference class type. The crash occurs when there is a template parameter

[PATCH] D34636: [clangd] LLVM-ify codebase

omtcyfz created this revision. This patch introduces cosmetic changes while making ClangD code slightly more LLVM Coding Standards-compliant by - Convert names of struct fields in Protocol.h from `camelCase` to `CamelCase` - Enclose code in .cpp implementation files in appropriate namespaces

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. Looks good to me but I definitely want to hear what @efriedma has to say. Repository: rL LLVM https://reviews.llvm.org/D34523 ___

[PATCH] D34580: [CodeGen][ObjC] Load indirect ARC arguments in prolog

kastiglione added a comment. Thanks @rnk. I don't have commit access; @compnerd, @rnk would either of you mind committing this? Thanks in advance! https://reviews.llvm.org/D34580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34286: [clang-tidy] Fix type names in modernize-use-unique/shared_ptr checks.

hokein updated this revision to Diff 103995. hokein marked 2 inline comments as done. hokein added a comment. Herald added a subscriber: JDevlieghere. Address review comments. https://reviews.llvm.org/D34286 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp

[PATCH] D34580: [CodeGen][ObjC] Load indirect ARC arguments in prolog

kastiglione updated this revision to Diff 103994. kastiglione added a comment. CHECK load and call https://reviews.llvm.org/D34580 Files: lib/CodeGen/CGDecl.cpp test/CodeGenObjCXX/arc-indirect.mm Index: test/CodeGenObjCXX/arc-indirect.mm

[PATCH] D34556: [libcxx] Annotate c++17 aligned new/delete operators with availability attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL306310: [libcxx] Annotate c++17 aligned new/delete operators with availability (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D34556?vs=103883=103992#toc Repository: rL

[libcxx] r306310 - [libcxx] Annotate c++17 aligned new/delete operators with availability

Author: ahatanak Date: Mon Jun 26 10:39:48 2017 New Revision: 306310 URL: http://llvm.org/viewvc/llvm-project?rev=306310=rev Log: [libcxx] Annotate c++17 aligned new/delete operators with availability attribute. This is needed because older versions of libc++ do not have these operators. If

[PATCH] D34633: [clang-tidy] Fix a bug in android-file-open-flag

yawanng created this revision. yawanng added a project: clang-tools-extra. Herald added subscribers: xazax.hun, JDevlieghere. Handle a case when the function is passed as an argument of a function-like macro. Plus fix a format that was forgotten to commit last time. Repository: rL LLVM

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

compnerd updated this revision to Diff 103981. compnerd added a comment. __ptr64 mangling, add tests for 32-bit. Repository: rL LLVM https://reviews.llvm.org/D34523 Files: lib/AST/MicrosoftMangle.cpp test/CodeGenCXX/msabi-blocks.cpp Index: test/CodeGenCXX/msabi-blocks.cpp

[PATCH] D34556: [libcxx] Annotate c++17 aligned new/delete operators with availability attribute

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D34556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT

bruno updated this revision to Diff 103975. bruno added a comment. Update patch after reviewer suggestions! https://reviews.llvm.org/D34588 Files: include/__config Index: include/__config === --- include/__config +++

[PATCH] D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT

bruno marked an inline comment as done. bruno added inline comments. Comment at: include/__config:234-235 +// a MS compatibility version is specified. # ifndef __MINGW32__ -#define _LIBCPP_MSVCRT // Using Microsoft's C Runtime library +#ifdef _MSC_VER +# define

r306301 - [inline asm] dot operator while using imm generates wrong ir + asm - clang part

Author: myatsina Date: Mon Jun 26 09:09:55 2017 New Revision: 306301 URL: http://llvm.org/viewvc/llvm-project?rev=306301=rev Log: [inline asm] dot operator while using imm generates wrong ir + asm - clang part Inline asm dot operator while using imm generates wrong ir and asm This is the test

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

arphaman added inline comments. Comment at: test/SemaObjC/unguarded-availability.m:243 + + struct { new_int mem; } anon; // expected-warning{{'new_int' is partial}} expected-note{{annotate '' with an availability attribute}} +}; We should never have something

[PATCH] D31383: [inline asm] "=i" output constraint support - gcc compatiblity

This revision was automatically updated to reflect the committed changes. Closed by commit rL306297: [inline asm][gcc-compatiblity] "=i" output constraint support (authored by myatsina). Changed prior to commit: https://reviews.llvm.org/D31383?vs=97602=103967#toc Repository: rL LLVM

r306297 - [inline asm][gcc-compatiblity] "=i" output constraint support

Author: myatsina Date: Mon Jun 26 08:55:51 2017 New Revision: 306297 URL: http://llvm.org/viewvc/llvm-project?rev=306297=rev Log: [inline asm][gcc-compatiblity] "=i" output constraint support Ignore ‘i’,’n’,’E’,’F’ as output constraints in inline assembly (gcc compatibility) Differential

[PATCH] D34286: [clang-tidy] Fix type names in modernize-use-unique/shared_ptr checks.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:23 + const LangOptions ) { + return clang::Lexer::getSourceText( +

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

erik.pilkington updated this revision to Diff 103958. erik.pilkington added a comment. Make the diagnostic reference the context declaration instead of the offending decl if no enclosing decl is found, fixing the diagnostic bug @arphaman pointed out. https://reviews.llvm.org/D33816 Files:

[PATCH] D33277: [Clang][x86][Inline Asm] - Enum support for MS syntax

rnk added inline comments. Comment at: test/CodeGen/x86-ms-inline-asm-enum_feature.cpp:12 + const int a = 0; + // CHECK-NOT: mov eax, [$$0] + __asm mov eax, [a] rnk wrote: > mharoush wrote: > > rnk wrote: > > > Use CHECK-LABEL, CHECK, and CHECK-SAME the way

[PATCH] D34623: [clang-format] Add a test for associative map proto buffer fields

krasimir updated this revision to Diff 103962. krasimir added a comment. - Add map declarations spanning multiple lines https://reviews.llvm.org/D34623 Files: unittests/Format/FormatTestProto.cpp Index: unittests/Format/FormatTestProto.cpp

[PATCH] D34580: [CodeGen][ObjC] Load indirect ARC arguments in prolog

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: test/CodeGenObjCXX/arc-indirect.mm:19 +// CHECK-DARWIN: define internal void @"\01-[C object:struct:]"(<{ %0*, i8*, i8*, %struct.S, [3 x i8] }>* inalloca) +//

[PATCH] D34623: [clang-format] Add a test for associative map proto buffer fields

djasper added a comment. Can you create a more interesting test case where the map definition spans multiple lines? Possibly use qualified names for the field types. https://reviews.llvm.org/D34623 ___ cfe-commits mailing list

r306291 - Improve const-correctness.

Author: axel Date: Mon Jun 26 08:06:40 2017 New Revision: 306291 URL: http://llvm.org/viewvc/llvm-project?rev=306291=rev Log: Improve const-correctness. Modified: cfe/trunk/include/clang/Parse/Parser.h Modified: cfe/trunk/include/clang/Parse/Parser.h URL:

[PATCH] D34206: [clang-tidy] Add "MakeSmartPtrFunction" option to modernize-make-shared/unique checks.

hokein added a comment. In https://reviews.llvm.org/D34206#790406, @alexfh wrote: > In https://reviews.llvm.org/D34206#783673, @hokein wrote: > > > In https://reviews.llvm.org/D34206#780455, @Eugene.Zelenko wrote: > > > > > It'll be good idea to run modernize-make-unique on LLVM/Clang/etc for >

[PATCH] D34506: Relax an assert in the comparison of source locations

xazax.hun added a comment. In https://reviews.llvm.org/D34506#787971, @joerg wrote: > I don't think it is a good idea to make this function non-transitive. I think this is a good point. However, I am not entirely sure that it is transitive right now. Check the "Both are in built-in buffers,

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

klimek added a reviewer: rsmith. klimek added a comment. Richard (added as reviewer) usually owns decisions around clang itself. Writing an email to cfe-dev with the numbers and wait for whether others have concerns would probably also be good. https://reviews.llvm.org/D30691

[PATCH] D33406: PR28129 expand vector oparation to an IR constant.

RKSimon closed this revision. RKSimon added a comment. https://reviews.llvm.org/rL305551 https://reviews.llvm.org/D33406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

aaron.ballman added a comment. In https://reviews.llvm.org/D33470#789791, @Prazek wrote: > In https://reviews.llvm.org/D33470#764846, @aaron.ballman wrote: > > > Once you fix the typo in the check, can you run it over some large C++ code > > bases to see if it finds any results? > > > I tried

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

Serge_Preis added a comment. In https://reviews.llvm.org/D32439#790323, @chapuni wrote: > Just change LLVM_DEFAULT_TARGET_TRIPLE, build and run check-clang. You may > use ccmake for it. > Or, modify RUN line locally like > > RUN: c-index-test (snip) %s -Xclang -triple -Xclang x86_64-pc-win32

[PATCH] D34299: [ubsan] Improve diagnostics for return value checks (clang)

filcab added a comment. In https://reviews.llvm.org/D34299#788427, @vsk wrote: > I hope I've cleared this up, but: we need to store the source location > constant _somewhere_, before we emit the return value check. That's because > we can't infer which return location to use at compile time.

[PATCH] D34395: clang-format: add options to merge empty record body

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D34395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34395: clang-format: add options to merge empty record body

Typz updated this revision to Diff 103939. Typz added a comment. Merge `SplitEmptyClass/Struct/Union` options into a single `SplitEmptyRecord` option. https://reviews.llvm.org/D34395 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/FormatToken.h

[PATCH] D32638: [x86][inline-asm][clang]Amend size directive deduction mechanism of unsized memory operands

coby abandoned this revision. coby added a comment. superseded by https://reviews.llvm.org/rL302179 Repository: rL LLVM https://reviews.llvm.org/D32638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33440: clang-format: better handle statement and namespace macros

Typz updated this revision to Diff 103937. Typz added a comment. Fix typo https://reviews.llvm.org/D33440 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/FormatToken.h lib/Format/FormatTokenLexer.cpp lib/Format/FormatTokenLexer.h

[PATCH] D33440: clang-format: properly handle Q_UNUSED and QT_REQUIRE_VERSION

Typz updated this revision to Diff 103935. Typz added a comment. Complete refactor to make the processing much more generic https://reviews.llvm.org/D33440 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/FormatToken.h lib/Format/FormatTokenLexer.cpp

[PATCH] D34091: Support for querying the exception specification type through libclang

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D34091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-06-26 4:05 GMT+07:00 David Blaikie : > Ah, I see now then. > > I have a symlink from the root of my source directory pointing to the > compile_commands.json in my build directory. > > I have this so that the vim YouCompleteMe plugin (& any other clang tools) > can find

[PATCH] D34206: [clang-tidy] Add "MakeSmartPtrFunction" option to modernize-make-shared/unique checks.

alexfh added a comment. In https://reviews.llvm.org/D34206#783673, @hokein wrote: > In https://reviews.llvm.org/D34206#780455, @Eugene.Zelenko wrote: > > > It'll be good idea to run modernize-make-unique on LLVM/Clang/etc for > > llvm::make_unique. > > > +1. See https://reviews.llvm.org/D34334,

[PATCH] D34329: [GSoC] Clang AST diffing

johannes added inline comments. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:730 + +Mapping TreeComparator::matchTopDown() const { + PriorityList L1(T1); johannes wrote: > arphaman wrote: > > Johannes, it seems to me that your implementation of the top-down

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

chapuni added a comment. In https://reviews.llvm.org/D32439#790302, @Serge_Preis wrote: > Thank you for clarifications, would you explain how may I reproduce failure > locally or remotely. I'd like to see c-index-test output before clang-check > to understand what's going on. Just change

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

Serge_Preis added a comment. In https://reviews.llvm.org/D32439#790252, @chapuni wrote: > In https://reviews.llvm.org/D32439#790248, @Serge_Preis wrote: > > > Is there any meaning in 'test-clang-msc-x64-on-i686-linux-RA' (I just don't > > knwo what this configuration mean) - I tested on Linux

[PATCH] D33816: [Sema][ObjC] Don't allow -Wunguarded-availability to be silenced with redeclarations

arphaman added a comment. I don't think the new warning is ideal, e.g.: #import __attribute__((visibility("default"))) __attribute__((availability(macosx,introduced=10_10))) @interface Test : NSObject @end Test *testVar; E.g.: test.m:13:1: warning: 'Test' is partial:

r306280 - [mips] Enable IAS by default for Android 64-bit MIPS target (N64)

Author: petarj Date: Mon Jun 26 02:58:01 2017 New Revision: 306280 URL: http://llvm.org/viewvc/llvm-project?rev=306280=rev Log: [mips] Enable IAS by default for Android 64-bit MIPS target (N64) IAS is already used for MIPS64 in majority of Android projects. Android MIPS64 uses N64 ABI. Set IAS

[PATCH] D34514: [mips] Enable IAS by default for Android 64-bit MIPS target (N64)

This revision was automatically updated to reflect the committed changes. Closed by commit rL306280: [mips] Enable IAS by default for Android 64-bit MIPS target (N64) (authored by petarj). Changed prior to commit: https://reviews.llvm.org/D34514?vs=103574=103912#toc Repository: rL LLVM

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

chapuni added a comment. In https://reviews.llvm.org/D32439#790248, @Serge_Preis wrote: > Is there any meaning in 'test-clang-msc-x64-on-i686-linux-RA' (I just don't > knwo what this configuration mean) - I tested on Linux that I have at my > disposal and tesing passes. It's cross-compiling.

  1   2   >