[libcxx] r307461 - Fix filesystem build on platforms with weird time_t types.

2017-07-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Jul 7 21:18:41 2017 New Revision: 307461 URL: http://llvm.org/viewvc/llvm-project?rev=307461=rev Log: Fix filesystem build on platforms with weird time_t types. 32-bit powerpc provides a 64 bit time_t type and older ppc64 systems provide time_t as a floating point type.

r307458 - [ODRHash] Support FriendDecl

2017-07-07 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Fri Jul 7 19:04:42 2017 New Revision: 307458 URL: http://llvm.org/viewvc/llvm-project?rev=307458=rev Log: [ODRHash] Support FriendDecl Modified: cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td cfe/trunk/lib/AST/ODRHash.cpp

r307456 - [X86] Move AVX512VPOPCNTDQ in __builtin_cpu_support's enum to match trunk gcc.

2017-07-07 Thread Craig Topper via cfe-commits
Author: ctopper Date: Fri Jul 7 17:47:44 2017 New Revision: 307456 URL: http://llvm.org/viewvc/llvm-project?rev=307456=rev Log: [X86] Move AVX512VPOPCNTDQ in __builtin_cpu_support's enum to match trunk gcc. There are two other features before it that we don't currently support in the the

r307455 - Fix warnings introduced by r307434.

2017-07-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Jul 7 17:37:59 2017 New Revision: 307455 URL: http://llvm.org/viewvc/llvm-project?rev=307455=rev Log: Fix warnings introduced by r307434. Modified: cfe/trunk/tools/libclang/CIndex.cpp cfe/trunk/tools/libclang/CXIndexDataConsumer.cpp Modified:

LLVM buildmaster will be updated and restarted tonight

2017-07-07 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r307450 - Fix diagnostic in verify test to match new Clang output

2017-07-07 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Fri Jul 7 16:02:30 2017 New Revision: 307450 URL: http://llvm.org/viewvc/llvm-project?rev=307450=rev Log: Fix diagnostic in verify test to match new Clang output Modified: libcxx/trunk/test/std/thread/futures/futures.task/futures.task.members/ctor2.fail.cpp Modified:

r307449 - Revert r307445 as it breaks on certain platforms.

2017-07-07 Thread Dehao Chen via cfe-commits
Author: dehao Date: Fri Jul 7 15:40:37 2017 New Revision: 307449 URL: http://llvm.org/viewvc/llvm-project?rev=307449=rev Log: Revert r307445 as it breaks on certain platforms. Modified: cfe/trunk/test/CodeGen/Inputs/pgo-sample.prof cfe/trunk/test/CodeGen/pgo-sample.c Modified:

r307446 - [MS] Don't statically initialize dllimport member function pointers

2017-07-07 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Jul 7 15:04:29 2017 New Revision: 307446 URL: http://llvm.org/viewvc/llvm-project?rev=307446=rev Log: [MS] Don't statically initialize dllimport member function pointers Summary: r306137 made dllimport pointers to member functions non-constant. This is correct because a

r307445 - Add sample PGO integration test to cover profile annotation and inlining.

2017-07-07 Thread Dehao Chen via cfe-commits
Author: dehao Date: Fri Jul 7 15:01:47 2017 New Revision: 307445 URL: http://llvm.org/viewvc/llvm-project?rev=307445=rev Log: Add sample PGO integration test to cover profile annotation and inlining. Summary: The patch makes the integration test cover major sample PGO components. Reviewers:

r307444 - Add testcase for r305850.

2017-07-07 Thread Lang Hames via cfe-commits
Author: lhames Date: Fri Jul 7 14:51:11 2017 New Revision: 307444 URL: http://llvm.org/viewvc/llvm-project?rev=307444=rev Log: Add testcase for r305850. Accidentally left this out of the original commit. Added: cfe/trunk/test/Import/import-overrides/

r307438 - Enable the new PM + SamlePGO + ThinLTO testing.

2017-07-07 Thread Dehao Chen via cfe-commits
Author: dehao Date: Fri Jul 7 13:53:17 2017 New Revision: 307438 URL: http://llvm.org/viewvc/llvm-project?rev=307438=rev Log: Enable the new PM + SamlePGO + ThinLTO testing. Summary: This patch should be enabled after https://reviews.llvm.org/D34895 Reviewers: chandlerc, tejohnson, davidxl

Re: r307434 - [modules ts] Basic for module linkage.

2017-07-07 Thread Richard Smith via cfe-commits
On 7 July 2017 at 13:04, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Fri Jul 7 13:04:28 2017 > New Revision: 307434 > > URL: http://llvm.org/viewvc/llvm-project?rev=307434=rev > Log: > [modules ts] Basic for module linkage. > Sorry, that should

r307434 - [modules ts] Basic for module linkage.

2017-07-07 Thread Richard Smith via cfe-commits
Author: rsmith Date: Fri Jul 7 13:04:28 2017 New Revision: 307434 URL: http://llvm.org/viewvc/llvm-project?rev=307434=rev Log: [modules ts] Basic for module linkage. In addition to the formal linkage rules, the Modules TS includes cases where internal-linkage symbols within a module interface

r307420 - [X86] Replace 'fallthrough' comments with LLVM_FALLTHROUGH.

2017-07-07 Thread Craig Topper via cfe-commits
Author: ctopper Date: Fri Jul 7 11:41:09 2017 New Revision: 307420 URL: http://llvm.org/viewvc/llvm-project?rev=307420=rev Log: [X86] Replace 'fallthrough' comments with LLVM_FALLTHROUGH. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp URL:

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

2017-07-07 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. I discussed this with @rsmith and we think the correct fix is to update the DefinitionData bits computed when adding special members. I haven't reviewed this patch in detail, but we came to the conclusion that Clang's optimization to avoid implicit special member

[PATCH] D33676: Place implictly declared functions at block scope

2017-07-07 Thread Momchil Velikov via Phabricator via cfe-commits
chill added a comment. Ping. https://reviews.llvm.org/D33676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34985: Do not read the file to determine its name.

2017-07-07 Thread Axel Naumann via Phabricator via cfe-commits
karies added a comment. In https://reviews.llvm.org/D34985#801498, @bruno wrote: > @v.g.vassilev will this also benefit from `ContentCache::getBuffer` > improvements from https://reviews.llvm.org/D33275? I guess if `getBuffer` > transparently handles pointing to right buffer we won't need this

[PATCH] D33842: CodeGen: Fix address space of global variable

2017-07-07 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 105644. yaxunl marked 3 inline comments as done. yaxunl added a comment. Revised by John's comments. https://reviews.llvm.org/D33842 Files: include/clang/Basic/TargetInfo.h lib/Basic/Targets.cpp lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGDecl.cpp

[PATCH] D33842: CodeGen: Fix address space of global variable

2017-07-07 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1144 + ? CGM.getNSConcreteGlobalBlock() + : CGM.getNullPointer(CGM.VoidPtrPtrTy, +

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

2017-07-07 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. A few more nits. Comment at: run-clang-tidy.py:93 +def merge_replacement_files(tmpdir, fixfile): + """Merge all replacement files in a directory into a single

r307394 - clang-format: [JS] do not wrap after "readonly".

2017-07-07 Thread Martin Probst via cfe-commits
Author: mprobst Date: Fri Jul 7 06:17:10 2017 New Revision: 307394 URL: http://llvm.org/viewvc/llvm-project?rev=307394=rev Log: clang-format: [JS] do not wrap after "readonly". Summary: Breaks after "readonly" trigger automatic semicolon insertion in field declarations. Reviewers: krasimir,

[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

2017-07-07 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. In https://reviews.llvm.org/D35109#801921, @NoQ wrote: > Because integer promotion rules are tricky, could we, for now, avoid dealing > with the situation when left-hand side and right-hand side and the

[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

2017-07-07 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:583 +newRhs = BasicVals.evalAPSInt(BO_Add, *lInt, *rInt); +reverse = (lop == BO_Add); + }

[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

2017-07-07 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 105628. baloghadamsoftware added a comment. Type check added and restricted to additive operators. https://reviews.llvm.org/D35109 Files: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp test/Analysis/std-c-library-functions.c

[PATCH] D35118: [AArch64] Add support for handling the +sve target feature

2017-07-07 Thread Amara Emerson via Phabricator via cfe-commits
aemerson added inline comments. Comment at: lib/Basic/Targets.cpp:6245 enum FPUModeEnum { -FPUMode, -NeonMode +NeonMode = (1 << 0), +SveMode = (1 << 1) rengolin wrote: > Is there any AArch64 arch without SIMD? > > Anyway, that seems

[PATCH] D35118: [AArch64] Add support for handling the +sve target feature

2017-07-07 Thread Renato Golin via Phabricator via cfe-commits
rengolin added a reviewer: t.p.northover. rengolin added a subscriber: t.p.northover. rengolin added inline comments. Comment at: lib/Basic/Targets.cpp:6245 enum FPUModeEnum { -FPUMode, -NeonMode +NeonMode = (1 << 0), +SveMode = (1 << 1) Is

[PATCH] D35118: [AArch64] Add support for handling the +sve target feature

2017-07-07 Thread Amara Emerson via Phabricator via cfe-commits
aemerson created this revision. aemerson added a project: clang. Herald added subscribers: kristof.beyls, tschuett, javed.absar. [AArch64] Add support for handling the +sve target feature. This also adds the appropriate predefine for SVE if enabled. Depends on https://reviews.llvm.org/D35076

r307388 - Recommit [driver][macOS] Pick the system version for the

2017-07-07 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Fri Jul 7 03:41:19 2017 New Revision: 307388 URL: http://llvm.org/viewvc/llvm-project?rev=307388=rev Log: Recommit [driver][macOS] Pick the system version for the deployment target if the SDK is newer than the system This commit reverts the revert commit r305891. Now the

r307386 - [driver][mips] Pass long-calls feature flag to the MIPS backend

2017-07-07 Thread Simon Atanasyan via cfe-commits
Author: atanasyan Date: Fri Jul 7 03:35:33 2017 New Revision: 307386 URL: http://llvm.org/viewvc/llvm-project?rev=307386=rev Log: [driver][mips] Pass long-calls feature flag to the MIPS backend Check the `-mlong-calls` command line option and pass the `long-calls` feature flag to the backend.

[PATCH] D35069: [Frontend] Verify that the bitstream is not empty before reading the serialised diagnostics

2017-07-07 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL307384: [Frontend] Verify that the bitstream is not empty before reading (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D35069?vs=105462=105612#toc Repository: rL LLVM

r307384 - [Frontend] Verify that the bitstream is not empty before reading

2017-07-07 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Fri Jul 7 03:25:12 2017 New Revision: 307384 URL: http://llvm.org/viewvc/llvm-project?rev=307384=rev Log: [Frontend] Verify that the bitstream is not empty before reading the serialised diagnostics Clang should avoid calling report_fatal_error when the file with the

[clang-tools-extra] r307379 - [clang-tidy] Fix modernize-use-override incorrect replacement

2017-07-07 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Fri Jul 7 03:15:24 2017 New Revision: 307379 URL: http://llvm.org/viewvc/llvm-project?rev=307379=rev Log: [clang-tidy] Fix modernize-use-override incorrect replacement Summary: For the following code: `modernize-use-override` generates a replacement with incorrect

[PATCH] D35078: [clang-tidy] Fix modernize-use-override incorrect replacement

2017-07-07 Thread Alexander Kornienko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL307379: [clang-tidy] Fix modernize-use-override incorrect replacement (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D35078?vs=105554=105610#toc Repository: rL LLVM

[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

2017-07-07 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Thanks, this looks great! Because integer promotion rules are tricky, could we, for now, avoid dealing with the situation when left-hand side and right-hand side and the result (all three) are not all of the same type? Or maybe we'd like to support substraction of

[PATCH] D35108: Fix crash parsing invalid code

2017-07-07 Thread Olivier Goffart via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL307371: Fix crash parsing invalid code (authored by ogoffart). Changed prior to commit: https://reviews.llvm.org/D35108?vs=105590=105604#toc Repository: rL LLVM https://reviews.llvm.org/D35108

r307371 - Fix crash parsing invalid code

2017-07-07 Thread Olivier Goffart via cfe-commits
Author: ogoffart Date: Fri Jul 7 02:38:59 2017 New Revision: 307371 URL: http://llvm.org/viewvc/llvm-project?rev=307371=rev Log: Fix crash parsing invalid code The code in the test caused a crash with this backtrace: RecordLayoutBuilder.cpp:2934: const clang::ASTRecordLayout

r307368 - [ObjC] Avoid the -Wunguarded-availability warnings for protocol

2017-07-07 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Fri Jul 7 02:15:29 2017 New Revision: 307368 URL: http://llvm.org/viewvc/llvm-project?rev=307368=rev Log: [ObjC] Avoid the -Wunguarded-availability warnings for protocol requirements in protocol/class/category declarations The unguarded availability warnings in the

[PATCH] D35061: [ObjC] Avoid the -Wunguarded-availability warnings for protocol requirements in protocol/class/category declarations

2017-07-07 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. arphaman marked an inline comment as done. Closed by commit rL307368: [ObjC] Avoid the -Wunguarded-availability warnings for protocol (authored by arphaman). Changed prior to commit:

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-07-07 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good. Thanks! Repository: rL LLVM https://reviews.llvm.org/D34404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33537: [clang-tidy] Exception Escape Checker

2017-07-07 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. In https://reviews.llvm.org/D33537#771274, @aaron.ballman wrote: > The check in https://reviews.llvm.org/D3 is using a CFG, not just > checking direct throws. I tested the latest revision (the fronted patch already included) on my test file.

[PATCH] D35041: [analyzer] Fix modeling of bool based types

2017-07-07 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap updated this revision to Diff 105597. Repository: rL LLVM https://reviews.llvm.org/D35041 Files: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp test/Analysis/enum.cpp Index: test/Analysis/enum.cpp

[PATCH] D12407: [clang-format-vs] Add an option to reformat source code when file is saved to disk

2017-07-07 Thread Teodor MICU via Phabricator via cfe-commits
mteodor added a comment. In https://reviews.llvm.org/D12407#314671, @klimek wrote: > I think we'll want somebody to find out whether there are simpler ways to > implement this. **Format on save** was implemented by https://reviews.llvm.org/D29221. What's the new functionality in the

[PATCH] D33719: Add _Float16 as a C/C++ source language type

2017-07-07 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer added a comment. Thanks Richard. I've opened an cxx abi issue, see comments inline. I will start working now on the doc update, and will do that in a companion change. Cheers. Comment at: lib/AST/ItaniumMangle.cpp:2457-2460 + case BuiltinType::Float16: case

[PATCH] D32642: [Analyzer] Iterator Checker - Part 2: Increment, decrement operators and ahead-of-begin checks

2017-07-07 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 105594. baloghadamsoftware added a comment. Simplified for enhanced SValBuilder and ConstraintManager. https://reviews.llvm.org/D32642 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test/Analysis/Inputs/system-header-simulator-cxx.h

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

2017-07-07 Thread Michael F. Herbst via Phabricator via cfe-commits
mfherbst added inline comments. Comment at: run-clang-tidy.py:105 + elif merged['MainSourceFile'] != content['MainSourceFile']: +# The values given for MainSourceFile are inconsistent. +# Just empty MainSourceFile blank: alexfh wrote: > This

[PATCH] D35110: [Analyzer] Constraint Manager Negates Difference

2017-07-07 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 105593. baloghadamsoftware added a comment. Wrong patch files was uploaded first. https://reviews.llvm.org/D35110 Files: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp test/Analysis/ptr-arith.c Index: test/Analysis/ptr-arith.c

[PATCH] D35110: [Analyzer] Constraint Manager Negates Difference

2017-07-07 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware created this revision. If range `[m .. n]` is stored for symbolic expression `A - B`, then we can deduce the range for `B - A` which is [-n .. -m]. This is only true for signed types, unless the range is `[0 .. 0]`. https://reviews.llvm.org/D35110 Files:

[PATCH] D31326: Add option to export fixes to run-clang-tidy.py

2017-07-07 Thread Michael F. Herbst via Phabricator via cfe-commits
mfherbst updated this revision to Diff 105592. mfherbst added a comment. Herald added a subscriber: JDevlieghere. - Adapted patch to changes suggested by alexfh - Added comment why setting MainSourceFile to an empty string if fixes are exported https://reviews.llvm.org/D31326 Files:

[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

2017-07-07 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware created this revision. Since the range-based constraint manager (default) is weak in handling comparisons where symbols are on both sides it is wise to rearrange them to have symbols only on the left side. Thus e.g. `A + n >= B + m` becomes `A - B >= m - n` which enables the

[PATCH] D35108: Fix crash parsing invalid code

2017-07-07 Thread Roger Ferrer Ibanez via Phabricator via cfe-commits
rogfer01 added a comment. Hi @ogoffart thanks for fixing this. I suggest some minor change for the check, other than that this looks good to me. Comment at: lib/Sema/SemaChecking.cpp:12099 BaseType = BaseType->getPointeeType(); RecordDecl *RD =

[PATCH] D35108: Fix crash parsing invalid code

2017-07-07 Thread Olivier Goffart via Phabricator via cfe-commits
ogoffart created this revision. The code in the test caused a crash with this backtrace: RecordLayoutBuilder.cpp:2934: const clang::ASTRecordLayout ::ASTContext::getASTRecordLayout(const clang::RecordDecl *) const: Assertion `!D->isInvalidDecl() && "Cannot get layout of invalid decl!"' failed.