majnemer added a comment.
OK, so we are exporting the thunks so that the linker will generate import
thunks for the thunks. I think that we should have a comment to that effect
near the code you added.
https://reviews.llvm.org/D34972
___
cfe-commi
smeenai added a comment.
Ping. I updated the description based on the email discussion with @majnemer.
https://reviews.llvm.org/D34972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis added a comment.
From what I understand, _MSC_VER changes with each 2017 update.
https://reviews.llvm.org/D35757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
In https://reviews.llvm.org/D3#812836, @v.g.vassilev wrote:
> In https://reviews.llvm.org/D3#812418, @rjmccall wrote:
>
> > In https://reviews.llvm.org/D3#795175, @v.g.vassilev wrote:
> >
> > > @rjmccall, thanks for the prompt and thorough reply.
> > >
> > >
smeenai added inline comments.
Comment at: lib/AST/StmtProfile.cpp:1367
+#if defined(_MSC_VER) && _MSC_VER == 1911
+// Work around
https://developercommunity.visualstudio.com/content/problem/84002/clang-cl-when-built-with-vc-2017-crashes-cause-vc.html
Is it wo
ruiu added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:1302
-llvm::outs() << llvm::join(SuggestedCompletions, " ") << '\n';
+llvm::outs() << llvm::join(SuggestedCompletions, "\n") << '\n';
return false;
Now that the separator and the t
yamaguchi created this revision.
Herald added a subscriber: hiraditya.
`clang --autocomplete=-std` will show
-std: Language standard to compile for
-std= Language standard to compile for
-stdlib=C++ standard library to use
by this change.
However, showing HelpText with complet
thakis created this revision.
MSVC2017 update 3 produces a clang that crashes when compiling clang. Disabling
optimizations for StmtProfiler::VisitCXXOperatorCallExpr() makes the crash go
away.
Patch from Bruce Dawson !
https://reviews.llvm.org/D35757
Files:
lib/AST/StmtProfile.cpp
Index
fedor.sergeev created this revision.
General idea is to utilize generic (mostly Generic_GCC) code
and get rid of Solaris-specific handling as much as possible.
In particular:
- scanLibDirForGCCTripleSolaris was removed, relying on generic
CollectLibDirsAndTriples
- findBiarchMultilibs is now p
echristo added a comment.
In https://reviews.llvm.org/D35577#817267, @sgundapa wrote:
> The discussion is scattered across these patches
> https://reviews.llvm.org/D35578 and https://reviews.llvm.org/D35579.
> I will provide a brief summary here:
>
> The idea is to control the generation of dat
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D35747
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Hello everyone,
Below are some buildbot numbers for the last of 07/09/2017 - 07/15/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from gre
Author: chapuni
Date: Fri Jul 21 16:48:26 2017
New Revision: 308807
URL: http://llvm.org/viewvc/llvm-project?rev=308807&view=rev
Log:
clangDaemon: Update libdeps in r308738.
Modified:
clang-tools-extra/trunk/clangd/CMakeLists.txt
Modified: clang-tools-extra/trunk/clangd/CMakeLists.txt
URL:
mcgrathr updated this revision to Diff 107752.
mcgrathr added a comment.
test case
https://reviews.llvm.org/D35747
Files:
lib/Driver/ToolChains/Fuchsia.h
test/Driver/fast-math.c
Index: test/Driver/fast-math.c
===
--- test/Dri
mcgrathr added a comment.
Please land it for me when approved.
https://reviews.llvm.org/D35747
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mcgrathr created this revision.
Repository:
rL LLVM
https://reviews.llvm.org/D35747
Files:
lib/Driver/ToolChains/Fuchsia.h
Index: lib/Driver/ToolChains/Fuchsia.h
===
--- lib/Driver/ToolChains/Fuchsia.h
+++ lib/Driver/ToolChain
Author: benlangmuir
Date: Fri Jul 21 16:04:27 2017
New Revision: 308800
URL: http://llvm.org/viewvc/llvm-project?rev=308800&view=rev
Log:
[index] Set SymbolSubKind::Accessor[GS]etter on class methods
We have the same relation between class properties and getter/setters
that we have for instance p
danielcdh created this revision.
Herald added a subscriber: sanjoy.
The new PM needs to invoke add-discriminator pass when building with
-fdebug-info-for-profiling.
https://reviews.llvm.org/D35746
Files:
lib/CodeGen/BackendUtil.cpp
Index: lib/CodeGen/BackendUtil.cpp
===
vsk updated this revision to Diff 107741.
vsk marked an inline comment as done.
vsk added a comment.
- Drop 'REQUIRES: asserts'.
https://reviews.llvm.org/D35735
Files:
docs/UndefinedBehaviorSanitizer.rst
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/DiagnosticGroups.td
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308798: Remove Bitrig: CompilerRT Changes (authored by
erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D35709?vs=107606&id=107742#toc
Repository:
rL LLVM
https://reviews.llvm.org/D357
yawanng created this revision.
yawanng added a project: clang-tools-extra.
Herald added a subscriber: klimek.
Add handling for Structured binding declaration in C++17 in clang-format. For
example:
auto [x,y] = a;
auto &[xr, yr] = a;
auto &&[xrr, yrr] = a;
https://reviews.llvm.org/D35743
File
danalbert added a comment.
In https://reviews.llvm.org/D35739#817705, @srhines wrote:
> It's hard to believe that there is nothing in Support that gives you the
> proper suffix for shared libraries. It would seem like this might be useful
> elsewhere, but I actually didn't find really any other
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308797: Remove Bitrig: Clang Changes (authored by
erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D35708?vs=107605&id=107740#toc
Repository:
rL LLVM
https://reviews.llvm.org/D35708
F
Author: erichkeane
Date: Fri Jul 21 15:46:31 2017
New Revision: 308797
URL: http://llvm.org/viewvc/llvm-project?rev=308797&view=rev
Log:
Remove Bitrig: Clang Changes
Bitrig code has been merged back to OpenBSD, thus the OS has been abandoned.
Differential Revision: https://reviews.llvm.org/D3570
srhines added a comment.
Looks great. Thanks for fixing this up. It's hard to believe that there is
nothing in Support that gives you the proper suffix for shared libraries. It
would seem like this might be useful elsewhere, but I actually didn't find
really any other place that wants to use th
aprantl added inline comments.
Comment at: test/CodeGenCXX/ubsan-devirtualized-calls.cpp:1
-// RUN: %clang_cc1 -std=c++11 -triple %itanium_abi_triple -emit-llvm
-fsanitize=vptr %s -o - | FileCheck %s
+// REQUIRES: asserts
+// RUN: %clang_cc1 -std=c++11 -triple %itanium_abi_tripl
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D35729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
danalbert created this revision.
It's only named LLVMgold.so on Linux. Fix the name for Windows and
Darwin.
Also fix the path for Windows so binutils doesn't have to.
Repository:
rL LLVM
https://reviews.llvm.org/D35739
Files:
lib/Driver/ToolChains/CommonArgs.cpp
Index: lib/Drive
craig.topper added a comment.
LGTM
https://reviews.llvm.org/D35701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rtrieu
Date: Fri Jul 21 14:29:35 2017
New Revision: 308783
URL: http://llvm.org/viewvc/llvm-project?rev=308783&view=rev
Log:
Inline variable into assert to fix unused warning.
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp
URL:
http://llvm.or
Author: kparzysz
Date: Fri Jul 21 14:23:05 2017
New Revision: 308782
URL: http://llvm.org/viewvc/llvm-project?rev=308782&view=rev
Log:
[Hexagon] Attempt to fix selfhost bots
The codegen testcase was checking for specific value names. Make it
ignore the names instead as they are irrelevant.
Modi
craig.topper added a comment.
Please recheck all the cpp file headers. Many of them aren't 80 columns and
they should probably mention the target the way the header comments do. Right
now it looks like a copy and paste from Targets.cpp with only the file name
changed.
Clang format seems to hav
vsk created this revision.
Herald added a subscriber: kubamracek.
See: https://bugs.llvm.org/show_bug.cgi?id=33881
Depends on https://reviews.llvm.org/D35735
https://reviews.llvm.org/D35736
Files:
test/ubsan/TestCases/TypeCheck/PR33221.cpp
test/ubsan/TestCases/TypeCheck/vptr-corrupted-vtab
vsk created this revision.
The instrumentation generated by -fsanitize=vptr does not null check a
user pointer before loading from it. This causes crashes in the face of
UB member calls (this=nullptr), i.e it causes user programs to crash only
after UBSan is turned on.
The fix is to make run-time
erichkeane added a comment.
In https://reviews.llvm.org/D35701#817526, @echristo wrote:
> I'm going to say this ahead of time without looking into it "LGTM", but wait
> for ctopper (or someone else) to ack it for style etc since I'm unlikely to
> get to it any time shortly. :)
>
> Also, make su
Author: rtrieu
Date: Fri Jul 21 13:32:22 2017
New Revision: 308777
URL: http://llvm.org/viewvc/llvm-project?rev=308777&view=rev
Log:
Fix tblgen error
Add Heading string to attribute documentation.
Modified:
cfe/trunk/include/clang/Basic/AttrDocs.td
Modified: cfe/trunk/include/clang/Basic/At
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
I'm going to say this ahead of time without looking into it "LGTM", but wait
for ctopper (or someone else) to ack it for style etc since I'm unlikely to get
to it any time shortly. :)
Als
sgundapa added a comment.
This is not going to be a temporary option
https://reviews.llvm.org/D35577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danalbert created this revision.
Old versions of Android used the "Unknown error: -1" format.
Repository:
rL LLVM
https://reviews.llvm.org/D35732
Files:
test/std/diagnostics/syserr/syserr.errcat/syserr.errcat.objects/generic_category.pass.cpp
test/std/diagnostics/syserr/syserr.errcat/s
On Fri, Jul 21, 2017 at 12:57 PM David Blaikie wrote:
> On Fri, Jul 21, 2017 at 11:34 AM David Majnemer via Phabricator <
> revi...@reviews.llvm.org> wrote:
>
>> majnemer added a comment.
>>
>> This might be a silly question but why not do this by default?
>>
>
> I'd hazard a guess that GDB would
On Fri, Jul 21, 2017 at 11:34 AM David Majnemer via Phabricator <
revi...@reviews.llvm.org> wrote:
> majnemer added a comment.
>
> This might be a silly question but why not do this by default?
>
I'd hazard a guess that GDB wouldn't cope well with this (in terms of
identifying templates as the sa
Hello everyone,
I'm going on vacation starting from the next week. I will be traveling, so
likely will be slow with my e-mails.
Please feel free to contact Victor Leschuk with the questions or request
related to the LLVM Lab and the buildbot infrastructure.
Thanks
Galina
___
Author: abataev
Date: Fri Jul 21 12:26:22 2017
New Revision: 308773
URL: http://llvm.org/viewvc/llvm-project?rev=308773&view=rev
Log:
[OPENMP] Fix build problem, NFC.
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp
URL:
http://llvm.org/viewvc/llvm-pro
Author: abataev
Date: Fri Jul 21 11:55:46 2017
New Revision: 308771
URL: http://llvm.org/viewvc/llvm-project?rev=308771&view=rev
Log:
[OPENMP] Add ast-print tests for in_reduction clause, NFC.
Modified:
cfe/trunk/test/OpenMP/taskloop_ast_print.cpp
cfe/trunk/test/OpenMP/taskloop_simd_ast_p
Author: erichkeane
Date: Fri Jul 21 11:50:36 2017
New Revision: 308769
URL: http://llvm.org/viewvc/llvm-project?rev=308769&view=rev
Log:
Complex Long Double classification In RegCall calling convention
This change is part of the RegCall calling convention support for LLVM.
Existing RegCall imple
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308769: Complex Long Double classification In RegCall
calling convention (authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D35259?vs=107667&id=107696#toc
Repository:
rL LLVM
Author: abataev
Date: Fri Jul 21 11:48:21 2017
New Revision: 308768
URL: http://llvm.org/viewvc/llvm-project?rev=308768&view=rev
Log:
[OPENMP] Initial support for 'in_reduction' clause.
Parsing/sema analysis for 'in_reduction' clause for task-based
directives.
Added:
cfe/trunk/test/OpenMP/ta
majnemer added a comment.
This might be a silly question but why not do this by default?
https://reviews.llvm.org/D35715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kparzysz
Date: Fri Jul 21 11:07:15 2017
New Revision: 308763
URL: http://llvm.org/viewvc/llvm-project?rev=308763&view=rev
Log:
[Hexagon] Add inline-asm constraint 'a' for modifier register class
For example
asm ("memw(%0++%1) = %2" : : "r"(addr),"a"(mod),"r"(val) : "memory")
Modified:
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D35259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hamzasood created this revision.
While using the libtooling API, I ran into problems when using a const ASTUnit.
There were a few functions I needed to use that don't seem to modify anything,
but they weren't marked as const so I couldn't use them.
This patch marks those methods (and a few othe
erichkeane added inline comments.
Comment at: lib/Basic/Targets/OSTargets.h:13
+
+//===--===//
+// Defines specific to certain operating systems.
craig.topper wrote:
> This comment seems somewhat
craig.topper added inline comments.
Comment at: lib/Basic/Targets/OSTargets.h:13
+
+//===--===//
+// Defines specific to certain operating systems.
This comment seems somewhat redundant with the
Author: abataev
Date: Fri Jul 21 10:24:30 2017
New Revision: 308759
URL: http://llvm.org/viewvc/llvm-project?rev=308759&view=rev
Log:
[OPENMP] Simplify analysis of data-sharing attributes.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/trunk/lib/Sema/SemaOpenMP.cpp
craig.topper added a comment.
I think we should drop "using namespace llvm;" from the cpp files. clang
doesn't usually do that except in codegen and it doesn't look like it was
required in the original Targets.cpp.
https://reviews.llvm.org/D35701
erik.pilkington added a comment.
Thanks for working on this! This looks like it would be very useful.
Comment at: lib/Sema/SemaDeclAttr.cpp:7230
+return;
+ for (const auto &M : S.getPreprocessor().macros()) {
+if (M.first->getName() != "API_AVAILABLE")
dblaikie added inline comments.
Comment at: include/clang/AST/TemplateBase.h:109-111
+// This is the type that most closely resembles what is in the source.
+// At the moment it is retaining typedefs, but not decltype or typeof.
+uintptr_t DisplayType;
---
Author: kasaurov
Date: Fri Jul 21 08:24:37 2017
New Revision: 308744
URL: http://llvm.org/viewvc/llvm-project?rev=308744&view=rev
Log:
Test commit
Modified:
cfe/trunk/lib/Driver/ToolChains/AMDGPU.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/AMDGPU.cpp
URL:
http://llvm.org/viewvc/llvm-proje
arphaman created this revision.
The fixit is given only if the `API_AVAILABLE` macro is defined.
Repository:
rL LLVM
https://reviews.llvm.org/D35726
Files:
lib/Sema/SemaDeclAttr.cpp
test/FixIt/fixit-availability.c
test/FixIt/fixit-availability.mm
Index: test/FixIt/fixit-availability.
sgundapa added a comment.
The discussion is scattered across these patches
https://reviews.llvm.org/D35578 and https://reviews.llvm.org/D35579.
I will provide a brief summary here:
The idea is to control the generation of data (lookup table) generated from a
function, specifically when the user
Author: nhaustov
Date: Fri Jul 21 06:58:11 2017
New Revision: 308741
URL: http://llvm.org/viewvc/llvm-project?rev=308741&view=rev
Log:
Test commit
Modified:
cfe/trunk/lib/Driver/ToolChains/AMDGPU.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/AMDGPU.cpp
URL:
http://llvm.org/viewvc/llvm-proje
eandrews updated this revision to Diff 107667.
eandrews added a comment.
Regcall-specific checks for Lin64 now occur only if CXXABI returns false. An
existing test has also been modified to verify behavior with non trivial
destructors.
https://reviews.llvm.org/D35259
Files:
lib/CodeGen/Targ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308738: [clangd] Replace ASTUnit with manual AST management.
(authored by ibiryukov).
Changed prior to commit:
https://reviews.llvm.org/D35406?vs=107475&id=107666#toc
Repository:
rL LLVM
https://rev
Author: ibiryukov
Date: Fri Jul 21 06:29:29 2017
New Revision: 308738
URL: http://llvm.org/viewvc/llvm-project?rev=308738&view=rev
Log:
[clangd] Replace ASTUnit with manual AST management.
Summary:
This refactoring does not aim to introduce any significant changes to
the behaviour of clangd to ke
Author: arphaman
Date: Fri Jul 21 06:18:51 2017
New Revision: 308737
URL: http://llvm.org/viewvc/llvm-project?rev=308737&view=rev
Log:
[clang-diff] Get rid of unused variable warnings in ASTDiff.cpp
Modified:
cfe/trunk/lib/Tooling/ASTDiff/ASTDiff.cpp
Modified: cfe/trunk/lib/Tooling/ASTDiff/A
Author: arphaman
Date: Fri Jul 21 06:12:01 2017
New Revision: 308735
URL: http://llvm.org/viewvc/llvm-project?rev=308735&view=rev
Log:
Clang's tests should depend on clang-diff
Modified:
cfe/trunk/test/CMakeLists.txt
Modified: cfe/trunk/test/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-p
Author: arphaman
Date: Fri Jul 21 06:04:57 2017
New Revision: 308734
URL: http://llvm.org/viewvc/llvm-project?rev=308734&view=rev
Log:
Fix another compiler error from r308731
std::pair in emplace back couldn't be constructed because SNodeId has an
explicit constructor. Not sure how this even comp
Author: arphaman
Date: Fri Jul 21 05:57:40 2017
New Revision: 308733
URL: http://llvm.org/viewvc/llvm-project?rev=308733&view=rev
Log:
Fix tuple construction compiler error from r308731
Modified:
cfe/trunk/lib/Tooling/ASTDiff/ASTDiff.cpp
Modified: cfe/trunk/lib/Tooling/ASTDiff/ASTDiff.cpp
UR
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308731: [clang-diff] Add initial implementation (authored by
arphaman).
Changed prior to commit:
https://reviews.llvm.org/D34329?vs=105161&id=107661#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Author: arphaman
Date: Fri Jul 21 05:49:28 2017
New Revision: 308731
URL: http://llvm.org/viewvc/llvm-project?rev=308731&view=rev
Log:
[clang-diff] Add initial implementation
This is the first commit for the "Clang-based C/C++ diff tool" GSoC project.
ASTDiff is a new library that computes a str
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:358
+void templateFunction(ExpensiveToCopyType E) {
+ // CHECK-MESSAGES: [[@LINE-1]]:64: wa
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good!
https://reviews.llvm.org/D35406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
alexfh added a comment.
Committed as r308726.
Thank you for the contribution!
One note for the future: the patch doesn't contain repository-based paths, so I
had to apply it manually. There's a good documentation at
http://llvm.org/docs/Phabricator.html, which you could follow to create the
p
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308726: [clang-tidy] Add option to export fixes to
run-clang-tidy.py (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D31326?vs=107633&id=107650#toc
Repository:
rL LLVM
https:
Author: alexfh
Date: Fri Jul 21 03:31:26 2017
New Revision: 308726
URL: http://llvm.org/viewvc/llvm-project?rev=308726&view=rev
Log:
[clang-tidy] Add option to export fixes to run-clang-tidy.py
This patch adds the option to keep the list of proposed fixes even though they
should not be applied.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308725: [clang-format] Fix comment levels between '}' and
PPDirective (authored by krasimir).
Repository:
rL LLVM
https://reviews.llvm.org/D35485
Files:
cfe/trunk/lib/Format/UnwrappedLineParser.cpp
Author: krasimir
Date: Fri Jul 21 03:26:13 2017
New Revision: 308725
URL: http://llvm.org/viewvc/llvm-project?rev=308725&view=rev
Log:
[clang-format] Fix comment levels between '}' and PPDirective
Summary:
This fixes a regression exposed by r307795 in which the level of a comment line
between '}'
mfherbst added a comment.
Many thanks!
https://reviews.llvm.org/D31326
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added a comment.
I'll commit this on behalf of Johannes today as he didn't get his access yet
https://reviews.llvm.org/D34329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. I'll commit the patch for you
https://reviews.llvm.org/D31326
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
hans added a comment.
Thanks for fixing this long-standing TODO :-)
Repository:
rL LLVM
https://reviews.llvm.org/D35427
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hans, can you please merge this to the LLVM 5.0 branch?
AFAIK It's a recent regression that should get fixed in LLVM 5.0.
Cheers,
Alex
On 21 July 2017 at 10:24, Ilya Biryukov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ibiryukov
> Date: Fri Jul 21 02:24:00 2017
> New Revision
krasimir added inline comments.
Comment at: lib/Format/UnwrappedLineFormatter.cpp:405
+for (; J != E; ++J) {
+ const AnnotatedLine *Line = J[0];
+ if (Line->InPPDirective != InPPDirective)
I'd change `J[0]` to `*J` and rename `Line` to s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308722: Fixed failing assert in code completion. (authored
by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D35682
Files:
cfe/trunk/lib/Sema/SemaCodeComplete.cpp
cfe/trunk/test/CodeComp
Author: ibiryukov
Date: Fri Jul 21 02:24:00 2017
New Revision: 308722
URL: http://llvm.org/viewvc/llvm-project?rev=308722&view=rev
Log:
Fixed failing assert in code completion.
Summary:
The code was accessing uninstantiated default argument.
This resulted in failing assertion at ParmVarDecl::getD
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D35485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
Looks good!
https://reviews.llvm.org/D35682
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
xazax.hun accepted this revision.
xazax.hun added a comment.
One minor nit, otherwise looks good to me.
Comment at: lib/StaticAnalyzer/Core/BugReporter.cpp:
+})) {
+ // Throw-expressions are currently generating sinks during symbolic
+ // execution: they'r
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
Just a minor nit.
Comment at: lib/StaticAnalyzer/Core/BugReporter.cpp:3332
+
+if (Visited.count(Blk)) {
+ // We've encountered a loop. We won't see anything ne
Author: ibiryukov
Date: Fri Jul 21 01:20:47 2017
New Revision: 308721
URL: http://llvm.org/viewvc/llvm-project?rev=308721&view=rev
Log:
[clangd] Specified --gcc-toolchain explicitly in VFS test.
In order to avoid platform-specific configuration quirks.
(Possible fix for https://bugs.llvm.org/show
Thanks for the reminder! I regenerated on the branch in r308720.
Cheers,
Hans
On Thu, Jul 20, 2017 at 7:59 PM, Craig Topper wrote:
> Hans,
>
> This needs to be ported to the 5.0 branch. Not sure if any new options have
> been added to 6.0 since the branch that would make this patch not correct.
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D35674
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
krasimir added a comment.
@djasper: ping
https://reviews.llvm.org/D35485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: atanasyan
Date: Fri Jul 21 01:10:57 2017
New Revision: 308719
URL: http://llvm.org/viewvc/llvm-project?rev=308719&view=rev
Log:
[mips] Add `short_call` to the set of `long_call/far/near` attributes
MIPS gcc supports `long_call/far/near` attributes only, but other
targets have the `short_c
94 matches
Mail list logo
