[PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

mgrang created this revision. This patch is in response to https://reviews.llvm.org/D35043 which removed -reverse-iterate flag and the base definition for PointerLikeTypeTrait. https://reviews.llvm.org/D36386 Files: include/clang/AST/ExternalASTSource.h

[PATCH] D36019: [clang-format] Fix bug with ENAS_DontAlign and empty lines

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Thanks you. Comment at: lib/Format/WhitespaceManager.cpp:650 +for (unsigned i = 0; i < Newlines; ++i) + Text.append(UseCRLF ? " \\\r\n" : " \\\n"); +return;

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

rjmccall added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:5742 +// effect of performing a trivial copy of the type. +bool Sema::CanPassInRegisters(CXXRecordDecl *D) { + if (D->isDependentType()) This should probably be called something like

[PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

hintonda updated this revision to Diff 109949. hintonda added a comment. - Use temp files instead of temp dir. https://reviews.llvm.org/D36347 Files: CMakeLists.txt utils/CMakeLists.txt utils/run_lldb.sh.in Index: utils/run_lldb.sh.in

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

phosek added inline comments. Comment at: cmake/caches/Fuchsia-stage2.cmake:56 +foreach(target x86_64;aarch64) + set(RUNTIMES_${target}-fuchsia-asan_CMAKE_BUILD_WITH_INSTALL_RPATH ON CACHE BOOL "") mcgrathr wrote: > Can you do this without duplicating all

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

mcgrathr added inline comments. Comment at: cmake/caches/Fuchsia-stage2.cmake:56 +foreach(target x86_64;aarch64) + set(RUNTIMES_${target}-fuchsia-asan_CMAKE_BUILD_WITH_INSTALL_RPATH ON CACHE BOOL "") Can you do this without duplicating all the identical

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. LGTM. Thanks for all of your work on this! Comment at: test/Driver/openmp-offload.c:603 + +/// Check -Xopenmp-target=powerpc64le-ibm-linux-gnu -march=pwr8 is passed when

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

gtbercea updated this revision to Diff 109939. gtbercea added a comment. Fix -march special casing. https://reviews.llvm.org/D34784 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/Options.td include/clang/Driver/ToolChain.h lib/Driver/Compilation.cpp

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

gtbercea added inline comments. Comment at: lib/Driver/ToolChain.cpp:808 + continue; + } else if (XOpenMPTargetNoTriple) +// Passing device args: -Xopenmp-target -opt=val. hfinkel wrote: > Please include {} around this else-if code, even

[PATCH] D34784: [OpenMP] Add flag for specifying the target device architecture for OpenMP device offloading

gtbercea updated this revision to Diff 109938. gtbercea added a comment. Address comments. https://reviews.llvm.org/D34784 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/Options.td include/clang/Driver/ToolChain.h lib/Driver/Compilation.cpp

[libcxxabi] r310226 - [demangler] Fix another oss-fuzz bug

Author: epilk Date: Sun Aug 6 13:46:33 2017 New Revision: 310226 URL: http://llvm.org/viewvc/llvm-project?rev=310226=rev Log: [demangler] Fix another oss-fuzz bug Modified: libcxxabi/trunk/src/cxa_demangle.cpp libcxxabi/trunk/test/test_demangle.pass.cpp Modified:

[PATCH] D36363: [test] Remove an unintentional -x cl flag in an aarch64-windows test

This revision was automatically updated to reflect the committed changes. Closed by commit rL310222: [test] Remove an unintentional -x cl flag in an aarch64-windows test (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D36363?vs=109889=109936#toc Repository: rL LLVM

r310222 - [test] Remove an unintentional -x cl flag in an aarch64-windows test

Author: mstorsjo Date: Sun Aug 6 12:57:49 2017 New Revision: 310222 URL: http://llvm.org/viewvc/llvm-project?rev=310222=rev Log: [test] Remove an unintentional -x cl flag in an aarch64-windows test This test was only intended to test compiling C, not OpenCL. Differential Revision:

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

mstorsjo updated this revision to Diff 109935. mstorsjo added a comment. Added a fixme comment about this being incorrect for WinCE. https://reviews.llvm.org/D36364 Files: lib/Basic/Targets.cpp lib/Basic/Targets/AArch64.cpp lib/Basic/Targets/AArch64.h

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev updated this revision to Diff 109932. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. We set the record's property denoting whether we can pass the decl by registers as a last step of `Sema::CheckCompletedCXXClass`. We cannot do it any earlier than that

Re: [PATCH] D24933: Enable configuration files in clang

On 6 August 2017 at 11:15, Serge Pavlov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > 2017-08-06 6:43 GMT+07:00 Hal Finkel : > >> On 07/24/2017 10:18 AM, Serge Pavlov wrote: >> >> I am thinking about reducing the patch further to leave only the ability >> to include

Re: [PATCH] D24933: Enable configuration files in clang

On 08/06/2017 01:15 PM, Serge Pavlov wrote: 2017-08-06 6:43 GMT+07:00 Hal Finkel >: On 07/24/2017 10:18 AM, Serge Pavlov wrote: I am thinking about reducing the patch further to leave only the ability to include config file when clang is

Re: [PATCH] D24933: Enable configuration files in clang

2017-08-06 6:43 GMT+07:00 Hal Finkel : > On 07/24/2017 10:18 AM, Serge Pavlov wrote: > > I am thinking about reducing the patch further to leave only the ability > to include config file when clang is called as `target-clang-drivermode`. > It is still useful for cross compilation

[PATCH] D36353: Postpone instantiation of constexpr functions

rsmith added inline comments. Comment at: lib/Sema/Sema.cpp:189 + + Context.setInstantiator(new SemaTemplateInstantiator(*this)); } It's not correct/reasonable to instantiate whenever an expression happens to be evaluated, in numerous ways: 1) You'll get the

[PATCH] D36353: Instantiate constexpr function when it is used

sepavloff updated this revision to Diff 109928. sepavloff added a comment. Updated patch I missed CWG issue 1581. It make patch description invalid, but the patch itself can be repaired with small modification. This fix originated from the attempt to solve the problem described in

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

mstorsjo added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:130 + case llvm::Triple::arm: + case llvm::Triple::thumb: CmdArgs.push_back("thumb2pe"); martell wrote: > I believe this was left incase someone wanted to do windows ce in future.

[PATCH] D36378: Enable LLVM asan support for NetBSD/i386

krytarowski created this revision. krytarowski added a project: Sanitizers. Verified to work and useful to run check-asan, as this target tests 32-bit and 64-bit execution. Sponsored by Repository: rL LLVM https://reviews.llvm.org/D36378 Files: lib/Driver/ToolChains/NetBSD.cpp Index:

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

martell added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:130 + case llvm::Triple::arm: + case llvm::Triple::thumb: CmdArgs.push_back("thumb2pe"); I believe this was left incase someone wanted to do windows ce in future. Can you add a

[PATCH] D35038: [libunwind] Add a test harness

chapuni added inline comments. Comment at: test/CMakeLists.txt:34 + ${CMAKE_CURRENT_BINARY_DIR} + DEPENDS ${LIBUNWIND_TEST_DEPS} + ) Could you fill this, please? set(LIBUNWIND_TEST_DEPS unwind ) It makes "check-unwind" pass from clean.

[PATCH] D35542: libcxxabi: Suppress LLVM_ENABLE_MODULES

chapuni added a comment. @jroelofs Please do. libunwind emits unique module caches. module.cache/1JROMJZVPMD3F/std-WU7UZNPX10U5.pcm module.cache/1JROMJZVPMD3F/std_config-WU7UZNPX10U5.pcm module.cache/1JROMJZVPMD3F/_Builtin_stddef_max_align_t-1P37D07AX0QU6.pcm They are not used outside the

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

martell added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:129 + else if (TC.getArch() == llvm::Triple::aarch64) +CmdArgs.push_back("arm64pe"); + else mstorsjo wrote: > martell wrote: > > I believe the reason I used thumb2pe for the arm

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

mstorsjo added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:129 + else if (TC.getArch() == llvm::Triple::aarch64) +CmdArgs.push_back("arm64pe"); + else martell wrote: > I believe the reason I used thumb2pe for the arm triple is because MS

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

mstorsjo updated this revision to Diff 109916. mstorsjo added a comment. Updated to use a switch, added a mapping of a missed case of thumb while reformatting the if to a switch. https://reviews.llvm.org/D36364 Files: lib/Basic/Targets.cpp lib/Basic/Targets/AArch64.cpp

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

martell added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:129 + else if (TC.getArch() == llvm::Triple::aarch64) +CmdArgs.push_back("arm64pe"); + else I believe the reason I used thumb2pe for the arm triple is because MS gave us a watered

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

mstorsjo added inline comments. Comment at: lib/Driver/ToolChains/MinGW.cpp:122-131 if (TC.getArch() == llvm::Triple::x86) CmdArgs.push_back("i386pe"); - if (TC.getArch() == llvm::Triple::x86_64) + else if (TC.getArch() == llvm::Triple::x86_64)

[PATCH] D36371: [Clang][x86][Inline Asm] support for GCC style inline asm - Y constraints

coby created this revision. This patch is intended to enable the use of basic double letter constraints used in GCC extended inline asm {Yi Y2 Yz Y0 Ym Yt}. Supersedes https://reviews.llvm.org/D32505 llvm counterpart: https://reviews.llvm.org/D36369 Repository: rL LLVM

[PATCH] D36363: [test] Remove an unintentional -x cl flag in an aarch64-windows test

mgrang accepted this revision. mgrang added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D36363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org