[PATCH] D16403: Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements

m.ostapenko updated this revision to Diff 110329. m.ostapenko added a comment. Rebased and ping. Repository: rL LLVM https://reviews.llvm.org/D16403 Files: include/clang/Analysis/AnalysisContext.h include/clang/Analysis/CFG.h include/clang/StaticAnalyzer/Core/AnalyzerOptions.h lib/An

Re: [PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

In D35043 I have removed the llvm tests which use -reverse-iterate. This patch removes the clang tests. Should I post a later patch to change all "class PointerLikeTypeTraits" to "struct PointerLikeTypeTraits"? On 8/7/2017 2:50 PM, David Blaikie wrote: On Mon, Aug 7, 2017 at 12:08 PM Mande

[PATCH] D35955: clang-format: Add preprocessor directive indentation

klimek added a comment. In https://reviews.llvm.org/D35955#835994, @euhlmann wrote: > In https://reviews.llvm.org/D35955#835439, @klimek wrote: > > > I think if we need this info, we can just make it count down to -1 again > > (or, but that's isomorphic, let it run from 0 and make sure we never

r310449 - [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch statements

Author: xazax Date: Wed Aug 9 01:57:09 2017 New Revision: 310449 URL: http://llvm.org/viewvc/llvm-project?rev=310449&view=rev Log: [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch statements Patch by: Reka Nikolett Kovacs Differential Revision: https://reviews.llvm.org/D

[PATCH] D36407: [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch statements

This revision was automatically updated to reflect the committed changes. Closed by commit rL310449: [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch… (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D36407?vs=110219&id=110333#toc Repository: rL L

[PATCH] D34324: [clang-format] let PointerAlignment dictate spacing of function ref qualifiers

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Thank you! https://reviews.llvm.org/D34324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

r310458 - [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment pragmas

Author: krasimir Date: Wed Aug 9 02:42:32 2017 New Revision: 310458 URL: http://llvm.org/viewvc/llvm-project?rev=310458&view=rev Log: [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment pragmas Summary: This handles a case where the trailing '*/' of a multiline jsdoc edin

[PATCH] D36359: [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment pragmas

This revision was automatically updated to reflect the committed changes. Closed by commit rL310458: [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment… (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D36359 Files: cfe/trunk/lib/Format/BreakableT

[PATCH] D35355: Fix templated type alias completion when using global completion cache

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

arphaman added a comment. The tests actually do compile in C++03, but they still fail because of infinite recursion: frame #196562: 0x0001155c nullptr_t_assign_reentrant.pass.cpp.exe`A::~A() + 92 frame #196563: 0x00011405 nullptr_t_assign_reentrant.pass.cpp.exe`std::__1::__

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

arphaman added a comment. If you look at the AST diff between C++11 and C++03 this error still happens because of how `nullptr` is processed: C++11: | |-CXXDestructorDecl 0x7fdab27a2498 line:24:3 used ~A 'void (void) noexcept' | | `-CompoundStmt 0x7fdab27bcfb8 | | |-GCCAsmStmt 0x7fda

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

arphaman added a comment. Ah, I got it. There's a `__functional_03` header that seems to implement `function` for C++03 because of manual variadic template expansions. You have to update the operators in the header as well. https://reviews.llvm.org/D34331

[PATCH] D36179: [clang-diff] Move printing of matches and changes to clang-diff

arphaman added a comment. Previous `Move` resulted in `llvm_unreachable("TODO");`, but now it seems to be fixed. The new output for `Move` and `UpdateMove` should be tested in a test. https://reviews.llvm.org/D36179 ___ cfe-commits mailing list cfe

[PATCH] D36180: [clang-diff] Add option to dump the AST, one node per line

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

martell accepted this revision. martell added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D36182: [clang-diff] Add HTML side-by-side diff output

arphaman added inline comments. Comment at: test/Tooling/clang-diff-html.py:1 +# RUN: clang-diff %S/Inputs/clang-diff-basic-src.cpp %S/clang-diff-basic.cpp -html -- | %python %s > %t.filecheck +# RUN: clang-diff %S/Inputs/clang-diff-basic-src.cpp %S/clang-diff-basic.cpp -dump-m

[PATCH] D36183: [clang-diff] Simplify mapping

arphaman added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:114 - /// If this is set to true, nodes that have parents that must not be matched - /// (see NodeComparison) will be allowed to be matched. - bool EnableMatchingWithUnmatchableParents = fals

[PATCH] D36184: [clang-diff] Filter AST nodes

arphaman added inline comments. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:177 +static bool isDeclExcluded(const Decl *D) { return D->isImplicit(); } +static bool isStmtExcluded(const Stmt *S) { return false; } + You should just use one call `isNodeExcluded` th

[PATCH] D36450: [X86][Ms-InlineAsm] Extend MS Dot operator to accept "this" + struct/class pointers aliases

coby added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:702-705 + // MS InlineAsm often uses struct pointer aliases as a base + const QualType QT = TD->getUnderlyingType(); + RT = isa(QT) ? QT->getPointeeType()->getAs() : +

[PATCH] D36458: Fix crash when current lexer is nullptr

bkramer added a comment. Changes like this should come with a small, c-index-test based, test case so we don't reintroduce the same bug in the future. https://reviews.llvm.org/D36458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

r310464 - Revert "PR19668, PR23034: Fix handling of move constructors and deleted copy constructors when deciding whether classes should be passed indirectly."

Author: rovka Date: Wed Aug 9 05:22:25 2017 New Revision: 310464 URL: http://llvm.org/viewvc/llvm-project?rev=310464&view=rev Log: Revert "PR19668, PR23034: Fix handling of move constructors and deleted copy constructors when deciding whether classes should be passed indirectly." This reverts c

Re: r310401 - PR19668, PR23034: Fix handling of move constructors and deleted copy

Hi Richard, I'm sorry but I've reverted this in r310464 because it was breaking some ASAN tests on this bot: http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/9452 Please let me know if I can help debug this. Cheers, Diana On 8 August 2017 at 21:14, Richard Smith via cfe-commi

r310468 - [Sema] -Wenum-compare no longer warn on anonymous enums in switch statements

Author: xazax Date: Wed Aug 9 05:34:58 2017 New Revision: 310468 URL: http://llvm.org/viewvc/llvm-project?rev=310468&view=rev Log: [Sema] -Wenum-compare no longer warn on anonymous enums in switch statements Patch by: Reka Nikolett Kovacs Modified: cfe/trunk/lib/Sema/SemaStmt.cpp cfe/tr

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris added a comment. Ping. https://reviews.llvm.org/D35020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35678: Omit sumbodule semantics for TS modules

boris added a comment. Ping. https://reviews.llvm.org/D35678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36171: AMDGPU: Use direct struct returns

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D36171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[clang-tools-extra] r310470 - [clangd] Fixed a bug in make_tagged.

Author: ibiryukov Date: Wed Aug 9 05:55:13 2017 New Revision: 310470 URL: http://llvm.org/viewvc/llvm-project?rev=310470&view=rev Log: [clangd] Fixed a bug in make_tagged. It accidentally std::move'd from Value parameter if it deduced to an l-value ref. Modified: clang-tools-extra/trunk/cla

[PATCH] D36458: Fix crash when current lexer is nullptr

yvvan added a comment. But I don't know the source of that issue, I only know how to fix it because I caught that one in debugger and added a check to prevent it. How can I write testcase for such fix? https://reviews.llvm.org/D36458 ___ cfe-commit

Re: r310401 - PR19668, PR23034: Fix handling of move constructors and deleted copy

Hi Diana, It seems the service is down. Could you send us the details of the failures (incl stack traces if any) Many thanks, Vassil On 09/08/17 15:27, Diana Picus via cfe-commits wrote: Hi Richard, I'm sorry but I've reverted this in r310464 because it was breaking some ASAN tests on this

[PATCH] D36473: Fix broken getAttributeSpellingListIndex for pragma attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, good catch! https://reviews.llvm.org/D36473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

r310472 - [X86][Ms-InlineAsm] Extend MS Dot operator to accept "this" + struct/class pointers aliases

Author: coby Date: Wed Aug 9 06:31:41 2017 New Revision: 310472 URL: http://llvm.org/viewvc/llvm-project?rev=310472&view=rev Log: [X86][Ms-InlineAsm] Extend MS Dot operator to accept "this" + struct/class pointers aliases MS InlineAsm Dot operator accepts "Bases" such as "this" (cpp) and class/

[PATCH] D36450: [X86][Ms-InlineAsm] Extend MS Dot operator to accept "this" + struct/class pointers aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rL310472: [X86][Ms-InlineAsm] Extend MS Dot operator to accept "this" + struct/class… (authored by coby). Changed prior to commit: https://reviews.llvm.org/D36450?vs=110145&id=110377#toc Repository: rL

[PATCH] D36471: [StaticAnalyzer] Try to calculate arithmetic result when operand has a range of possible values

danielmarjamaki updated this revision to Diff 110378. danielmarjamaki added a comment. Refactoring, use BasicValueFactory::evalAPSInt Repository: rL LLVM https://reviews.llvm.org/D36471 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h lib/StaticAnalyzer/Core/Exp

[PATCH] D36471: [StaticAnalyzer] Try to calculate arithmetic result when operand has a range of possible values

danielmarjamaki added a comment. Should evalAPSInt() have machinery to do standard sign/type promotions? I suggest that I add one more argument `bool promote = false`, do you think that sounds good? Repository: rL LLVM https://reviews.llvm.org/D36471 _

[PATCH] D36261: [clangd] Use multiple working threads in clangd.

ilya-biryukov updated this revision to Diff 110381. ilya-biryukov added a comment. - Added a stress test for multithreading. https://reviews.llvm.org/D36261 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/tool/ClangdMain.

[PATCH] D36261: [clangd] Use multiple working threads in clangd.

ilya-biryukov added a comment. Added a test that exercises some multi-threading behaviour. It really finds bugs, at least it found a problem that was fixed by https://reviews.llvm.org/D36397. (Will make sure to submit that other change before this one). As discussed with @klimek, will move to

[PATCH] D36397: [clangd] Fixed a data race.

ilya-biryukov added a comment. In https://reviews.llvm.org/D36397#833912, @klimek wrote: > Yea, we'll probably want to add a "smash it hard with parallel" requests kind > of test to catch these things. You're right, there is probably not a better > solution for this specific bug. Added a rele

Re: r310449 - [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch statements

Any way we could put this behind a different flag (say, -Wenum-compare-switch, in the same group as -Wenum-compare, so that -W(no-)enum-compare affects both)? Our codebase was -Wenum-compare clean before this commit but is very not clean now, so we'd now have to disable -Wenum-compare altogether, b

Re: r310449 - [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch statements

Sure! There was a follow-up patch that excluded anonymous enums. Is it still that bad to introduce it under a new flag? Regards, Gábor On 9 August 2017 at 16:07, Nico Weber wrote: > Any way we could put this behind a different flag (say, > -Wenum-compare-switch, in the same group as -Wenum-com

Re: r310449 - [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch statements

On Wed, Aug 9, 2017 at 10:07 AM, Nico Weber via cfe-commits wrote: > Any way we could put this behind a different flag (say, > -Wenum-compare-switch, in the same group as -Wenum-compare, so that > -W(no-)enum-compare affects both)? Our codebase was -Wenum-compare clean > before this commit but is

r310477 - [OpenCL] Minor refactoring to reduce copy/pasted code

Author: joey Date: Wed Aug 9 07:52:47 2017 New Revision: 310477 URL: http://llvm.org/viewvc/llvm-project?rev=310477&view=rev Log: [OpenCL] Minor refactoring to reduce copy/pasted code Set the type of TheCall inside SemaBuiltinReserveRWPipe to reduce duplicated code. Modified: cfe/trunk/lib/

r310478 - Reapply Sema: allow imaginary constants via GNU extension if UDL overloads not present.

Author: tnorthover Date: Wed Aug 9 07:56:48 2017 New Revision: 310478 URL: http://llvm.org/viewvc/llvm-project?rev=310478&view=rev Log: Reapply Sema: allow imaginary constants via GNU extension if UDL overloads not present. C++14 added user-defined literal support for complex numbers so that yo

r310482 - clang-format: [JS] detect ASI after closing parens.

Author: mprobst Date: Wed Aug 9 08:19:16 2017 New Revision: 310482 URL: http://llvm.org/viewvc/llvm-project?rev=310482&view=rev Log: clang-format: [JS] detect ASI after closing parens. Summary: A closing parenthesis followed by a declaration or statement should always terminate the current stat

[PATCH] D36491: clang-format: [JS] detect ASI after closing parens.

This revision was automatically updated to reflect the committed changes. Closed by commit rL310482: clang-format: [JS] detect ASI after closing parens. (authored by mprobst). Repository: rL LLVM https://reviews.llvm.org/D36491 Files: cfe/trunk/lib/Format/UnwrappedLineParser.cpp cfe/trunk

[PATCH] D33945: [OpenCL] Add support for missing sub_group functions.

joey closed this revision. joey added a comment. I committed all the parts separately: r309567 (with r309571 to fix a test), r309678 and r310477. https://reviews.llvm.org/D33945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

r310483 - Fix broken getAttributeSpellingListIndex for pragma attributes

Author: erichkeane Date: Wed Aug 9 08:27:36 2017 New Revision: 310483 URL: http://llvm.org/viewvc/llvm-project?rev=310483&view=rev Log: Fix broken getAttributeSpellingListIndex for pragma attributes We noticed when implementing a new pragma that the TableGen-generated function getAttributeSpell

[PATCH] D36473: Fix broken getAttributeSpellingListIndex for pragma attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rL310483: Fix broken getAttributeSpellingListIndex for pragma attributes (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D36473?vs=110217&id=110404#toc Repository: rL LLVM

Re: r310449 - [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch statements

On Wed, Aug 9, 2017 at 10:11 AM, Gábor Horváth wrote: > Sure! > > There was a follow-up patch that excluded anonymous enums. Is it still > that bad to introduce it under a new flag? > The follow-up was at r310468. https://build.chromium.org/p/chromium.fyi/ builders/ClangToTLinux/builds/8808 is w

[libcxx] r310487 - Change the way the literal operators are defined - now w/o a seperating space. This should be a NFC, but it will change how the compiler parses it.

Author: marshall Date: Wed Aug 9 08:42:50 2017 New Revision: 310487 URL: http://llvm.org/viewvc/llvm-project?rev=310487&view=rev Log: Change the way the literal operators are defined - now w/o a seperating space. This should be a NFC, but it will change how the compiler parses it. Modified:

[PATCH] D36526: [Sema] Assign new flag -Wenum-compare-switch to switch-related parts of -Wenum-compare

rnkovacs created this revision. This patch assigns switch-related parts of the `-Wenum-compare` diagnostic to a new flag `-Wenum-compare-switch`. `-Wenum-compare-switch` is put into the same group as `-Wenum-compare` so that `-W(no-)enum-compare` affects both. https://reviews.llvm.org/D36526

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

hamzasood created this revision. This patch provides an implementation for P0428R2 . https://reviews.llvm.org/D36527 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Sema/ScopeInfo.h include/clang/Sema/Sema.h lib/Parse/ParseExprCXX.cpp lib/Sem

[clang-tools-extra] r310491 - [clang-tidy] Ignore newlines in checks list

Author: alexfh Date: Wed Aug 9 09:00:31 2017 New Revision: 310491 URL: http://llvm.org/viewvc/llvm-project?rev=310491&view=rev Log: [clang-tidy] Ignore newlines in checks list This is a follow up to https://reviews.llvm.org/D30567 where I overlooked that LLVM YAML parser doesn't support multilin

[PATCH] D36482: Enable SanitizerKind::Vptr on NetBSD/X86 and X86_64

krytarowski added a comment. check-ubsan -- Testing: 172 tests, 8 threads -- Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. Testing Time: 20.19s Expected Passes: 156 Unsupported Tests : 16 I will enable more options and extend this commit. Repository: rL LLVM

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

gtbercea closed this revision. gtbercea added a comment. Already covered by https://reviews.llvm.org/D34888 Repository: rL LLVM https://reviews.llvm.org/D29905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D34512: Add preliminary Cross Translation Unit support library

whisperity added a comment. Apart from those in the in-line comments, I have a question: how safe is this library to `Release` builds? I know this is only a submodule dependency for the "real deal" in https://reviews.llvm.org/D30691, but I have seen some asserts that "imported function should a

[PATCH] D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

alexfh added a comment. I'm not sure this approach is the best to deal with the boilerplate, but it seems like an improvement compared to repeating code. See a few comments inline. Comment at: clang-tidy/android/CloexecCheck.cpp:66 + +StringRef CloexecCheck::getSpellingArg(con

[PATCH] D36529: Fixed a race condition in PrecompiledPreamble.

ilya-biryukov added a comment. Catched by a test from https://reviews.llvm.org/D36261. https://reviews.llvm.org/D36529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36529: Fixed a race condition in PrecompiledPreamble.

ilya-biryukov created this revision. Two PrecompiledPreambles, used in parallel on separate threads, could be writing preamble to the same temporary file. https://reviews.llvm.org/D36529 Files: lib/Frontend/PrecompiledPreamble.cpp Index: lib/Frontend/PrecompiledPreamble.cpp

[PATCH] D36452: [clang-tidy] Fix another crash in make-unique check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Thank you for the fix! Looks good! Comment at: test/clang-tidy/modernize-make-unique.cpp:419 + +class UniqueFoo : public std::unique_ptr { + public: I suspec

[PATCH] D36482: Enable SanitizerKind::Vptr on NetBSD/X86 and X86_64

krytarowski updated this revision to Diff 110420. krytarowski edited the summary of this revision. krytarowski added a comment. Enable more sanitizers. Repository: rL LLVM https://reviews.llvm.org/D36482 Files: lib/Driver/ToolChains/NetBSD.cpp Index: lib/Driver/ToolChains/NetBSD.cpp

[clang-tools-extra] r310496 - [clang-tidy] Fix another crash in make-unique check.

Author: hokein Date: Wed Aug 9 10:03:42 2017 New Revision: 310496 URL: http://llvm.org/viewvc/llvm-project?rev=310496&view=rev Log: [clang-tidy] Fix another crash in make-unique check. Summary: The crash happens when calling `reset` method without any preceding operation like "->" or ".", this c

[PATCH] D36452: [clang-tidy] Fix another crash in make-unique check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL310496: [clang-tidy] Fix another crash in make-unique check. (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D36452 Files: clang-tools-extra/trunk/clang-tidy/modernize/MakeSmartPt

[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies

modocache created this revision. Add documentation for `clang::ParseAST` parameters `PrintStats` and `SkipFunctionBodies`. Also, remove a tiny bit of trailing whitespace. https://reviews.llvm.org/D36530 Files: include/clang/Parse/ParseAST.h Index: include/clang/Parse/ParseAST.h

[PATCH] D36482: Enable SanitizerKind::Vptr on NetBSD/X86 and X86_64

krytarowski added a comment. check-safestack -- Testing: 8 tests, 8 threads -- Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. Testing Time: 0.56s Expected Passes: 7 Unsupported Tests : 1 I will research how to add the requested tests. Repository: rL LLVM http

[PATCH] D36531: [Parse] Document Parser::SkipFunctionBodies

modocache created this revision. https://reviews.llvm.org/D36531 Files: include/clang/Parse/Parser.h Index: include/clang/Parse/Parser.h === --- include/clang/Parse/Parser.h +++ include/clang/Parse/Parser.h @@ -253,6 +253,10 @@

[PATCH] D35932: [clang-tidy] Add integer division check

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. A few more nits. Comment at: clang-tidy/bugprone/IntegerDivisionCheck.cpp:40-44 + hasAncestor( + castExpr(hasCastKind(CK_IntegralToFloating)).

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

arphaman added a comment. Looks like this test is failing on macOS again after this change: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/39231/testReport/Clang/Driver/openmp_offload_c/ Can you please take a look? Repository: rL LLVM https://reviews.llvm.org/D29

[PATCH] D36532: Add -std=c++17

hans created this revision. As suggested on PR33912. Trying to keep this small to make it easy to merge to the 5.0 branch. We can do a follow-up with more thorough renaming (diagnostic text, options, ids, etc.) later. (For c++14 this was done in r215982, and I think a smaller patch for the 3.5

[PATCH] D35955: clang-format: Add preprocessor directive indentation

euhlmann updated this revision to Diff 110429. euhlmann edited the summary of this revision. euhlmann added a comment. This addresses Daniel's previous concerns. The option is now an enum, the heuristic for detecting include guards is expanded and has corresponding unit tests, and style issues a

[PATCH] D36427: [libcxxabi][demangler] Improve representation of substitutions/templates

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. I have a few more nitpicks; LGTM after you fix those. Comment at: src/cxa_demangle.cpp:1621-1631 +// Name stack, this is used by the parser to hold temporary name

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. In https://reviews.llvm.org/D29660#836927, @arphaman wrote: > Looks like this test is failing on macOS again after this change: > > http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/39231/testReport/Clang/Driver/openmp_offload_c/ > > Can you plea

[PATCH] D36492: [RFC][time-report] Add preprocessor timer

vsk added subscribers: mzolotukhin, vsk. vsk added a comment. Thanks for working on this. Collecting better timing information in the frontend sgtm. It's cheap to do, and we can use the information to guide our efforts re: attacking the compile-time problem. Feel free to add me to future timing

[PATCH] D36482: Enable bunch of sanitizers on NetBSD/X86 and X86_64

krytarowski updated this revision to Diff 110442. krytarowski edited the summary of this revision. krytarowski added a comment. Fix lsan entry. Add tests. Repository: rL LLVM https://reviews.llvm.org/D36482 Files: lib/Driver/ToolChains/NetBSD.cpp test/Driver/fsanitize.c Index: test/Dri

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

alexfh added a comment. A few late comments. Comment at: clang-tools-extra/trunk/docs/clang-tidy/checks/readability-static-accessed-through-instance.rst:28-29 + + C::foo(); + C::x; + This may be confusing as to whether the check removes the struct definition

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. Revision 310505 fixes the tests for this patch. Repository: rL LLVM https://reviews.llvm.org/D29660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

yawanng updated this revision to Diff 110443. yawanng marked 5 inline comments as done. https://reviews.llvm.org/D35372 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecCheck.cpp clang-tidy/android/CloexecCheck.h clang-tidy/andr

r310508 - PointerLikeTypeTraits: class->struct to match LLVM change

Author: dblaikie Date: Wed Aug 9 11:34:22 2017 New Revision: 310508 URL: http://llvm.org/viewvc/llvm-project?rev=310508&view=rev Log: PointerLikeTypeTraits: class->struct to match LLVM change Modified: cfe/trunk/include/clang/AST/CanonicalType.h cfe/trunk/include/clang/AST/DeclCXX.h

Re: [PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

On Wed, Aug 9, 2017 at 1:44 AM Grang, Mandeep Singh wrote: > In D35043 I have removed the llvm tests which use -reverse-iterate. This > patch removes the clang tests. > Ah, OK. I'm still curious about whether this results in a loss of test coverage. Without this test, would the bug it was testin

[PATCH] D36537: [OpenMP] Enable executable lookup into driver directory.

gtbercea created this revision. Invoking the compiler inside a script causes the clang-offload-bundler executable to not be found. This patch fixes this error. Repository: rL LLVM https://reviews.llvm.org/D36537 Files: lib/Driver/ToolChains/Cuda.cpp Index: lib/Driver/ToolChains/Cuda.cpp

[PATCH] D35449: [X86] Implement __builtin_cpu_is

craig.topper added a comment. Ping https://reviews.llvm.org/D35449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36537: [OpenMP] Enable executable lookup into driver directory.

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. I think this is fine, but please add a comment explaining that you're doing this to find (e.g., to find the offload bundler, etc.). Repository: rL LLVM https://reviews.llvm.org/D36537

[PATCH] D36537: [OpenMP] Enable executable lookup into driver directory.

gtbercea updated this revision to Diff 110447. gtbercea added a comment. Add comment. https://reviews.llvm.org/D36537 Files: lib/Driver/ToolChains/Cuda.cpp Index: lib/Driver/ToolChains/Cuda.cpp === --- lib/Driver/ToolChains/Cud

Re: [PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

> Ah, OK. I'm still curious about whether this results in a loss of test coverage. Without this test, would the bug it was testing still be caught by some test failure in at least one of the forward or reverse iteration modes? Sorry ... I missed that. Yes, the reverse iteration buildbot http:

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

joerg added a comment. In https://reviews.llvm.org/D34158#836026, @jyknight wrote: > In https://reviews.llvm.org/D34158#827178, @joerg wrote: > > > (2) It adds magic behavior that can make debugging more difficult. > > Partially preprocessed sources for example could be compiled with plain -c >

Re: [PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

OK - go ahead and remove the tests then, if the functionality is now covered by the buildbot+existing tests. On Wed, Aug 9, 2017 at 12:04 PM Grang, Mandeep Singh wrote: > > Ah, OK. I'm still curious about whether this results in a loss of test > coverage. Without this test, would the bug it was

r310511 - [OPENMP] Emit non-debug version of outlined functions with original

Author: abataev Date: Wed Aug 9 12:38:53 2017 New Revision: 310511 URL: http://llvm.org/viewvc/llvm-project?rev=310511&view=rev Log: [OPENMP] Emit non-debug version of outlined functions with original name. If the host code is compiled with the debug info, while the target without, there is a pr

[PATCH] D36532: Add -std=c++17

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Frontend/LangStandards.def:113 +LANGSTANDARD(cxx17, "c++17", + CXX, "ISO C++ 2017", LineComment | CPlusPlus | CPlusPlu

Re: r310401 - PR19668, PR23034: Fix handling of move constructors and deleted copy

Reverting this also fixed the selfhost bots: http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15-full-sh/builds/2142 http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-selfhost/builds/2309 http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-selfhost-neon/builds/1819 I'm afraid the l

Re: r310401 - PR19668, PR23034: Fix handling of move constructors and deleted copy

On 09/08/17 22:54, Diana Picus wrote: Reverting this also fixed the selfhost bots: http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15-full-sh/builds/2142 http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-selfhost/builds/2309 http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-sel

[PATCH] D36526: [Sema] Assign new flag -Wenum-compare-switch to switch-related parts of -Wenum-compare

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D36532: Add -std=c++17

hans added inline comments. Comment at: include/clang/Frontend/LangStandards.def:113 +LANGSTANDARD(cxx17, "c++17", + CXX, "ISO C++ 2017", LineComment | CPlusPlus | CPlusPlus11 | CPlusPlus14 | CPlusPlus1z | rsmith wrote: > Missing "with

r310516 - Make -std=c++17 an alias of -std=c++1z

Author: hans Date: Wed Aug 9 13:12:53 2017 New Revision: 310516 URL: http://llvm.org/viewvc/llvm-project?rev=310516&view=rev Log: Make -std=c++17 an alias of -std=c++1z As suggested on PR33912. Trying to keep this small to make it easy to merge to the 5.0 branch. We can do a follow-up with more

[PATCH] D36532: Add -std=c++17

This revision was automatically updated to reflect the committed changes. Closed by commit rL310516: Make -std=c++17 an alias of -std=c++1z (authored by hans). Changed prior to commit: https://reviews.llvm.org/D36532?vs=110430&id=110462#toc Repository: rL LLVM https://reviews.llvm.org/D3653

[PATCH] D36423: [libc++] Introsort based sorting function

DIVYA added a comment. Link to algorithm.bench.cpp benchmark https://github.com/hiraditya/std-benchmark/blob/master/cxx/algorithm.bench.cpp Comment at: include/algorithm:4208 + + // Threshold(or depth limit) for introsort is taken to be 2*log2(size) + typedef typename iterat

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

hfinkel added a comment. In https://reviews.llvm.org/D34158#837130, @joerg wrote: > In https://reviews.llvm.org/D34158#836026, @jyknight wrote: > > > In https://reviews.llvm.org/D34158#827178, @joerg wrote: > > > > > (2) It adds magic behavior that can make debugging more difficult. > > > Partia

Re: r310436 - [AST] Move visibility computations into a class; NFC

This seems to cause UBSAN issues: runtime error: load of value 4294967295, which is not a valid value for type 'clang::LVComputationKind' See ASAN+UBSAN bot on Green Dragon: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/4065/console On Tue, Aug 8, 2017 at 9:02 PM, George Burg

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. Even after r310505, openmp-offload.c continues to haunt our bots, for example http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/2012. Can you please fix this test? Repository: rL LLVM https://reviews.llvm.org/D29660

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. In https://reviews.llvm.org/D29660#837298, @alekseyshl wrote: > Even after r310505, openmp-offload.c continues to haunt our bots, for example > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/2012. > Can you please fix this test? Preparing a

r310521 - [Sema] Assign new flag -Wenum-compare-switch to switch-related parts of -Wenum-compare

Author: xazax Date: Wed Aug 9 13:56:43 2017 New Revision: 310521 URL: http://llvm.org/viewvc/llvm-project?rev=310521&view=rev Log: [Sema] Assign new flag -Wenum-compare-switch to switch-related parts of -Wenum-compare Patch by: Reka Nikolett Kovacs Differential Revision: https://reviews.llvm.o

[PATCH] D36526: [Sema] Assign new flag -Wenum-compare-switch to switch-related parts of -Wenum-compare

thakis accepted this revision. thakis added a comment. Thanks! https://reviews.llvm.org/D36526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >