[PATCH] D36567: [Bash-autocompletion] Add --autocomplete flag to 5.0 release notes

yamaguchi created this revision. I thought we should add this information to release notes, because we added a new flag to clang driver. https://reviews.llvm.org/D36567 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/ReleaseNotes.rst

[PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

wmi added a comment. In https://reviews.llvm.org/D36562#837594, @chandlerc wrote: > This has been discussed before and I still pretty strongly disagree with it. > > This cripples the ability of TSan to find race conditions between accesses to > consecutive bitfields -- and these bugs have

[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

zaks.anna added a comment. > What do you suggest? Should we widen the type of the difference, or abandon > this patch and revert back to the local solution I originally used in the > iterator checker? Does the local solution you used in the iterator checker not have the same problem?

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. 310549 should solve this problem by using a default architecture that is supported by the current device version. Repository: rL LLVM https://reviews.llvm.org/D29660 ___ cfe-commits mailing list

[PATCH] D35820: [Driver] Search compiler-rt paths in -print-file-name=

This revision was automatically updated to reflect the committed changes. Closed by commit rL310548: [Driver] Search compiler-rt paths in -print-file-name= (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D35820?vs=109485=110515#toc Repository: rL LLVM

r310548 - [Driver] Search compiler-rt paths in -print-file-name=

Author: phosek Date: Wed Aug 9 21:16:38 2017 New Revision: 310548 URL: http://llvm.org/viewvc/llvm-project?rev=310548=rev Log: [Driver] Search compiler-rt paths in -print-file-name= This makes it possible to print the name of compiler-rt libraries by using simply clang

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

jtbandes added a comment. FWIW, I'm able to reproduce the failure using Docker: Dockerfile: FROM ubuntu:xenial RUN apt-get update RUN apt-get install -y build-essential ca-certificates subversion python cmake --no-install-recommends WORKDIR / RUN svn co -q -r 310537

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. Thanks for running the test on your machine! This is very useful. I see what the problem is now: "clang: error: cannot find libdevice for sm_20. Provide path to different CUDA installation via --cuda-path, or pass -nocudalib to build without linking with libdevice."

[PATCH] D36441: Add Support for Reference Counting of Parameters on the Callee Side in RetainCountChecker

malhar1995 updated this revision to Diff 110514. malhar1995 marked 7 inline comments as done. malhar1995 added a comment. Addressed comments. P.S: I'm yet to test this callee-side parameter checking functionality on the actual ISL codebase. I'll do that ASAP. Repository: rL LLVM

[libcxxabi] r310546 - [demangler] Fix some more -Wshadow warnings I missed in r310535

Author: epilk Date: Wed Aug 9 19:48:13 2017 New Revision: 310546 URL: http://llvm.org/viewvc/llvm-project?rev=310546=rev Log: [demangler] Fix some more -Wshadow warnings I missed in r310535 Modified: libcxxabi/trunk/src/cxa_demangle.cpp Modified: libcxxabi/trunk/src/cxa_demangle.cpp URL:

[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies

craig.topper resigned from this revision. craig.topper added a comment. Guessing I'm only on here because I did the bulk of the 0->nullptr changes to clang a few years back. https://reviews.llvm.org/D36530 ___ cfe-commits mailing list

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

dyung added a comment. Hi, we are seeing this test fail on our internal linux build bot. I built/ran your latest change r310537 and here is the test result: /home/dyung/src/upstream/llvm_clean/tools/clang/test/Driver/openmp-offload.c:722:23: error: expected string not found in input

r310539 - clang-format: Fix bug with ENAS_DontAlign and empty lines

Author: jtbandes Date: Wed Aug 9 17:15:31 2017 New Revision: 310539 URL: http://llvm.org/viewvc/llvm-project?rev=310539=rev Log: clang-format: Fix bug with ENAS_DontAlign and empty lines This fixes a bug in `ENAS_DontAlign` (introduced in D32733) where blank lines had an EscapedNewlineColumn

[PATCH] D36564: [analyzer] Fix SimpleSValBuilder::simplifySVal

alexshap created this revision. Herald added a subscriber: xazax.hun. This diff attempts to address a crash (triggered assert) on the newly-added test case. The assert being discussed is inside SValBuilder::evalBinOp if (Optional RV = rhs.getAs()) { // Support pointer arithmetic where

[PATCH] D36563: Add a getName accessor for ModuleMacros

bob.wilson created this revision. Herald added a subscriber: mcrosier. Swift would like to be able to access the name of a ModuleMacro. There was some discussion of this in https://github.com/apple/swift-clang/pull/93, suggesting that it makes sense to have this accessor in Clang.

r310540 - Remove unused function

Author: arsenm Date: Wed Aug 9 17:19:43 2017 New Revision: 310540 URL: http://llvm.org/viewvc/llvm-project?rev=310540=rev Log: Remove unused function Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp URL:

[PATCH] D36019: [clang-format] Fix bug with ENAS_DontAlign and empty lines

This revision was automatically updated to reflect the committed changes. Closed by commit rL310539: clang-format: Fix bug with ENAS_DontAlign and empty lines (authored by jtbandes). Repository: rL LLVM https://reviews.llvm.org/D36019 Files: cfe/trunk/lib/Format/WhitespaceManager.cpp

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. I've removed that test. Let's see if the other two tests pass or not. I can't reproduce the error locally so it's hard to figure out what's failing. If you have a machine with that configuration and can run the command I would appreciate seeing the output of the

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

Marshall: ping? On Thu, Aug 3, 2017 at 10:20 AM, Hans Wennborg wrote: > Sounds good to me, but Eric or Marshall need to sign off. > > On Thu, Aug 3, 2017 at 10:15 AM, Shoaib Meenai wrote: >> Ping. >> >> On 7/28/17, 7:57 PM, "Shoaib Meenai"

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. r310519 did not fix the problem, see http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7062. I would suggest to revert and fix it properly, our bots are broken for a few days already. Repository: rL LLVM https://reviews.llvm.org/D29660

[libcxxabi] r310535 - [demangler] Fix a bunch of -Wshadow warnings

Author: epilk Date: Wed Aug 9 15:45:35 2017 New Revision: 310535 URL: http://llvm.org/viewvc/llvm-project?rev=310535=rev Log: [demangler] Fix a bunch of -Wshadow warnings These were causing failures in -Werror builds. Modified: libcxxabi/trunk/src/cxa_demangle.cpp Modified:

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

jyknight added a comment. Just to restate: the ideal outcome of this discussion for me would be to resolve things such that _ALL_ libc implementations will feel comfortable using this technique to provide the C11-required predefined macros. I'd love for linux, freebsd, macos, solaris, etc etc

[clang-tools-extra] r310532 - [clang-tidy] Don't compute the edit distance if it's over the threshold.

Author: d0k Date: Wed Aug 9 15:09:29 2017 New Revision: 310532 URL: http://llvm.org/viewvc/llvm-project?rev=310532=rev Log: [clang-tidy] Don't compute the edit distance if it's over the threshold. No functional change intended. Modified:

[PATCH] D32896: [OpenCL] Make CLK_NULL_RESERVE_ID invalid reserve id.

b-sumner added inline comments. Comment at: lib/Headers/opencl-c.h:16020 +// The macro CLK_NULL_RESERVE_ID refers to an invalid reservation ID. +#define CLK_NULL_RESERVE_ID (__builtin_astype((void *)0, reserve_id_t)) bool __ovld is_valid_reserve_id(reserve_id_t reserve_id);

[PATCH] D36171: AMDGPU: Use direct struct returns

arsenm closed this revision. arsenm added a comment. r310527 https://reviews.llvm.org/D36171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

saugustine created this revision. Herald added a subscriber: mgorny. https://reviews.llvm.org/D36555 Files: compiler-rt/lib/builtins/CMakeLists.txt Index: compiler-rt/lib/builtins/CMakeLists.txt === ---

[PATCH] D36230: [X86][Asm] Allow negative immediate to appear before bracketed expression

This revision was automatically updated to reflect the committed changes. Closed by commit rL310529: [X86][Asm] Allow negative immediate to appear before bracketed expression (authored by coby). Changed prior to commit: https://reviews.llvm.org/D36230?vs=109374=110485#toc Repository: rL

[libcxxabi] r310530 - Mark test as unsupported c++98/03 to fix buildbots

Author: epilk Date: Wed Aug 9 14:51:56 2017 New Revision: 310530 URL: http://llvm.org/viewvc/llvm-project?rev=310530=rev Log: Mark test as unsupported c++98/03 to fix buildbots Modified: libcxxabi/trunk/test/unittest_demangle.pass.cpp Modified:

r310529 - [X86][Asm] Allow negative immediate to appear before bracketed expression

Author: coby Date: Wed Aug 9 14:50:22 2017 New Revision: 310529 URL: http://llvm.org/viewvc/llvm-project?rev=310529=rev Log: [X86][Asm] Allow negative immediate to appear before bracketed expression Currently, only non-negative immediate is allowed prior to a brac expression (memory

r310527 - AMDGPU: Use direct struct returns and arguments

Author: arsenm Date: Wed Aug 9 14:44:58 2017 New Revision: 310527 URL: http://llvm.org/viewvc/llvm-project?rev=310527=rev Log: AMDGPU: Use direct struct returns and arguments This is an improvement over always using byval for structs. This will use registers until ~16 are used, and then switch

[PATCH] D36427: [libcxxabi][demangler] Improve representation of substitutions/templates

This revision was automatically updated to reflect the committed changes. Closed by commit rL310525: [demangler] Improve representation of substitutions/templates (authored by epilk). Changed prior to commit: https://reviews.llvm.org/D36427?vs=110281=110480#toc Repository: rL LLVM

[libcxxabi] r310525 - [demangler] Improve representation of substitutions/templates

Author: epilk Date: Wed Aug 9 14:30:57 2017 New Revision: 310525 URL: http://llvm.org/viewvc/llvm-project?rev=310525=rev Log: [demangler] Improve representation of substitutions/templates Differential revision: https://reviews.llvm.org/D36427 Added:

Re: r310436 - [AST] Move visibility computations into a class; NFC

Sorry about that! Attempted fix is r310523. I'll keep an eye on the bot to make sure it turns green. On Wed, Aug 9, 2017 at 1:23 PM, Juergen Ributzka wrote: > This seems to cause UBSAN issues: > > runtime error: load of value 4294967295, which is not a valid value for type

r310523 - Use unsigned instead of an enum for map keys

Author: gbiv Date: Wed Aug 9 14:20:41 2017 New Revision: 310523 URL: http://llvm.org/viewvc/llvm-project?rev=310523=rev Log: Use unsigned instead of an enum for map keys ubsan's enum sanitizer doesn't like the latter, and we had to have out-of-bounds values for DenseMapInfo's tombstone/empty

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

atanasyan created this revision. atanasyan added a project: clang. Herald added a subscriber: arichardson. While we do not support `-mshared / -mno-shared` properly, show warning and ignore `-mlong-calls` option in case of implicitly or explicitly provided `-mabicalls` option. The patch

[PATCH] D36550: [mips] Notify user that `-mabicalls` is ignored on non-PIC N64 ABI

atanasyan created this revision. atanasyan added a project: clang. Herald added a subscriber: arichardson. The `-mabicalls` option does not have a sense in case of non position independent code on N64 ABI. After this change driver starts to show a warning that `-mabicalls` is ignored in that

[PATCH] D36526: [Sema] Assign new flag -Wenum-compare-switch to switch-related parts of -Wenum-compare

This revision was automatically updated to reflect the committed changes. Closed by commit rL310521: [Sema] Assign new flag -Wenum-compare-switch to switch-related parts of -Wenum… (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D36526?vs=110407=110473#toc Repository:

r310521 - [Sema] Assign new flag -Wenum-compare-switch to switch-related parts of -Wenum-compare

Author: xazax Date: Wed Aug 9 13:56:43 2017 New Revision: 310521 URL: http://llvm.org/viewvc/llvm-project?rev=310521=rev Log: [Sema] Assign new flag -Wenum-compare-switch to switch-related parts of -Wenum-compare Patch by: Reka Nikolett Kovacs Differential Revision:

[PATCH] D36526: [Sema] Assign new flag -Wenum-compare-switch to switch-related parts of -Wenum-compare

thakis accepted this revision. thakis added a comment. Thanks! https://reviews.llvm.org/D36526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. In https://reviews.llvm.org/D29660#837298, @alekseyshl wrote: > Even after r310505, openmp-offload.c continues to haunt our bots, for example > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/2012. > Can you please fix this test? Preparing

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

alekseyshl added a comment. Even after r310505, openmp-offload.c continues to haunt our bots, for example http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/2012. Can you please fix this test? Repository: rL LLVM https://reviews.llvm.org/D29660

Re: r310436 - [AST] Move visibility computations into a class; NFC

This seems to cause UBSAN issues: runtime error: load of value 4294967295, which is not a valid value for type 'clang::LVComputationKind' See ASAN+UBSAN bot on Green Dragon: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/4065/console On Tue, Aug 8, 2017 at 9:02 PM, George

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

hfinkel added a comment. In https://reviews.llvm.org/D34158#837130, @joerg wrote: > In https://reviews.llvm.org/D34158#836026, @jyknight wrote: > > > In https://reviews.llvm.org/D34158#827178, @joerg wrote: > > > > > (2) It adds magic behavior that can make debugging more difficult. > > >

[PATCH] D36423: [libc++] Introsort based sorting function

DIVYA added a comment. Link to algorithm.bench.cpp benchmark https://github.com/hiraditya/std-benchmark/blob/master/cxx/algorithm.bench.cpp Comment at: include/algorithm:4208 + + // Threshold(or depth limit) for introsort is taken to be 2*log2(size) + typedef typename

[PATCH] D36532: Add -std=c++17

This revision was automatically updated to reflect the committed changes. Closed by commit rL310516: Make -std=c++17 an alias of -std=c++1z (authored by hans). Changed prior to commit: https://reviews.llvm.org/D36532?vs=110430=110462#toc Repository: rL LLVM https://reviews.llvm.org/D36532

r310516 - Make -std=c++17 an alias of -std=c++1z

Author: hans Date: Wed Aug 9 13:12:53 2017 New Revision: 310516 URL: http://llvm.org/viewvc/llvm-project?rev=310516=rev Log: Make -std=c++17 an alias of -std=c++1z As suggested on PR33912. Trying to keep this small to make it easy to merge to the 5.0 branch. We can do a follow-up with more

[PATCH] D36532: Add -std=c++17

hans added inline comments. Comment at: include/clang/Frontend/LangStandards.def:113 +LANGSTANDARD(cxx17, "c++17", + CXX, "ISO C++ 2017", LineComment | CPlusPlus | CPlusPlus11 | CPlusPlus14 | CPlusPlus1z | rsmith wrote: > Missing "with

[PATCH] D36526: [Sema] Assign new flag -Wenum-compare-switch to switch-related parts of -Wenum-compare

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r310401 - PR19668, PR23034: Fix handling of move constructors and deleted copy

On 09/08/17 22:54, Diana Picus wrote: Reverting this also fixed the selfhost bots: http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15-full-sh/builds/2142 http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-selfhost/builds/2309

Re: r310401 - PR19668, PR23034: Fix handling of move constructors and deleted copy

Reverting this also fixed the selfhost bots: http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15-full-sh/builds/2142 http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-selfhost/builds/2309 http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-selfhost-neon/builds/1819 I'm afraid the

[PATCH] D36532: Add -std=c++17

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Frontend/LangStandards.def:113 +LANGSTANDARD(cxx17, "c++17", + CXX, "ISO C++ 2017", LineComment | CPlusPlus |

r310511 - [OPENMP] Emit non-debug version of outlined functions with original

Author: abataev Date: Wed Aug 9 12:38:53 2017 New Revision: 310511 URL: http://llvm.org/viewvc/llvm-project?rev=310511=rev Log: [OPENMP] Emit non-debug version of outlined functions with original name. If the host code is compiled with the debug info, while the target without, there is a

Re: [PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

OK - go ahead and remove the tests then, if the functionality is now covered by the buildbot+existing tests. On Wed, Aug 9, 2017 at 12:04 PM Grang, Mandeep Singh wrote: > > Ah, OK. I'm still curious about whether this results in a loss of test > coverage. Without this

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

joerg added a comment. In https://reviews.llvm.org/D34158#836026, @jyknight wrote: > In https://reviews.llvm.org/D34158#827178, @joerg wrote: > > > (2) It adds magic behavior that can make debugging more difficult. > > Partially preprocessed sources for example could be compiled with plain -c

Re: [PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

> Ah, OK. I'm still curious about whether this results in a loss of test coverage. Without this test, would the bug it was testing still be caught by some test failure in at least one of the forward or reverse iteration modes? Sorry ... I missed that. Yes, the reverse iteration buildbot

[PATCH] D36537: [OpenMP] Enable executable lookup into driver directory.

gtbercea updated this revision to Diff 110447. gtbercea added a comment. Add comment. https://reviews.llvm.org/D36537 Files: lib/Driver/ToolChains/Cuda.cpp Index: lib/Driver/ToolChains/Cuda.cpp === ---

[PATCH] D36537: [OpenMP] Enable executable lookup into driver directory.

hfinkel accepted this revision. hfinkel added a comment. This revision is now accepted and ready to land. I think this is fine, but please add a comment explaining that you're doing this to find (e.g., to find the offload bundler, etc.). Repository: rL LLVM https://reviews.llvm.org/D36537

[PATCH] D35449: [X86] Implement __builtin_cpu_is

craig.topper added a comment. Ping https://reviews.llvm.org/D35449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36537: [OpenMP] Enable executable lookup into driver directory.

gtbercea created this revision. Invoking the compiler inside a script causes the clang-offload-bundler executable to not be found. This patch fixes this error. Repository: rL LLVM https://reviews.llvm.org/D36537 Files: lib/Driver/ToolChains/Cuda.cpp Index:

Re: [PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

On Wed, Aug 9, 2017 at 1:44 AM Grang, Mandeep Singh wrote: > In D35043 I have removed the llvm tests which use -reverse-iterate. This > patch removes the clang tests. > Ah, OK. I'm still curious about whether this results in a loss of test coverage. Without this test,

r310508 - PointerLikeTypeTraits: class->struct to match LLVM change

Author: dblaikie Date: Wed Aug 9 11:34:22 2017 New Revision: 310508 URL: http://llvm.org/viewvc/llvm-project?rev=310508=rev Log: PointerLikeTypeTraits: class->struct to match LLVM change Modified: cfe/trunk/include/clang/AST/CanonicalType.h cfe/trunk/include/clang/AST/DeclCXX.h

[PATCH] D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

yawanng updated this revision to Diff 110443. yawanng marked 5 inline comments as done. https://reviews.llvm.org/D35372 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecCheck.cpp clang-tidy/android/CloexecCheck.h

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. Revision 310505 fixes the tests for this patch. Repository: rL LLVM https://reviews.llvm.org/D29660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

alexfh added a comment. A few late comments. Comment at: clang-tools-extra/trunk/docs/clang-tidy/checks/readability-static-accessed-through-instance.rst:28-29 + + C::foo(); + C::x; + This may be confusing as to whether the check removes the struct

[PATCH] D36482: Enable bunch of sanitizers on NetBSD/X86 and X86_64

krytarowski updated this revision to Diff 110442. krytarowski edited the summary of this revision. krytarowski added a comment. Fix lsan entry. Add tests. Repository: rL LLVM https://reviews.llvm.org/D36482 Files: lib/Driver/ToolChains/NetBSD.cpp test/Driver/fsanitize.c Index:

[PATCH] D36492: [RFC][time-report] Add preprocessor timer

vsk added subscribers: mzolotukhin, vsk. vsk added a comment. Thanks for working on this. Collecting better timing information in the frontend sgtm. It's cheap to do, and we can use the information to guide our efforts re: attacking the compile-time problem. Feel free to add me to future

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea added a comment. In https://reviews.llvm.org/D29660#836927, @arphaman wrote: > Looks like this test is failing on macOS again after this change: > > http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/39231/testReport/Clang/Driver/openmp_offload_c/ > > Can you

[PATCH] D36427: [libcxxabi][demangler] Improve representation of substitutions/templates

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. I have a few more nitpicks; LGTM after you fix those. Comment at: src/cxa_demangle.cpp:1621-1631 +// Name stack, this is used by the parser to hold temporary

[PATCH] D35955: clang-format: Add preprocessor directive indentation

euhlmann updated this revision to Diff 110429. euhlmann edited the summary of this revision. euhlmann added a comment. This addresses Daniel's previous concerns. The option is now an enum, the heuristic for detecting include guards is expanded and has corresponding unit tests, and style issues

[PATCH] D36532: Add -std=c++17

hans created this revision. As suggested on PR33912. Trying to keep this small to make it easy to merge to the 5.0 branch. We can do a follow-up with more thorough renaming (diagnostic text, options, ids, etc.) later. (For c++14 this was done in r215982, and I think a smaller patch for the

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

arphaman added a comment. Looks like this test is failing on macOS again after this change: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/39231/testReport/Clang/Driver/openmp_offload_c/ Can you please take a look? Repository: rL LLVM

[PATCH] D35932: [clang-tidy] Add integer division check

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. A few more nits. Comment at: clang-tidy/bugprone/IntegerDivisionCheck.cpp:40-44 + hasAncestor( +

[PATCH] D36531: [Parse] Document Parser::SkipFunctionBodies

modocache created this revision. https://reviews.llvm.org/D36531 Files: include/clang/Parse/Parser.h Index: include/clang/Parse/Parser.h === --- include/clang/Parse/Parser.h +++ include/clang/Parse/Parser.h @@ -253,6 +253,10 @@

[PATCH] D36482: Enable SanitizerKind::Vptr on NetBSD/X86 and X86_64

krytarowski added a comment. check-safestack -- Testing: 8 tests, 8 threads -- Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. Testing Time: 0.56s Expected Passes: 7 Unsupported Tests : 1 I will research how to add the requested tests. Repository: rL LLVM

[PATCH] D36530: [Parse] Document PrintStats, SkipFunctionBodies

modocache created this revision. Add documentation for `clang::ParseAST` parameters `PrintStats` and `SkipFunctionBodies`. Also, remove a tiny bit of trailing whitespace. https://reviews.llvm.org/D36530 Files: include/clang/Parse/ParseAST.h Index: include/clang/Parse/ParseAST.h

[PATCH] D36452: [clang-tidy] Fix another crash in make-unique check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL310496: [clang-tidy] Fix another crash in make-unique check. (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D36452 Files:

[clang-tools-extra] r310496 - [clang-tidy] Fix another crash in make-unique check.

Author: hokein Date: Wed Aug 9 10:03:42 2017 New Revision: 310496 URL: http://llvm.org/viewvc/llvm-project?rev=310496=rev Log: [clang-tidy] Fix another crash in make-unique check. Summary: The crash happens when calling `reset` method without any preceding operation like "->" or ".", this could

[PATCH] D36482: Enable SanitizerKind::Vptr on NetBSD/X86 and X86_64

krytarowski updated this revision to Diff 110420. krytarowski edited the summary of this revision. krytarowski added a comment. Enable more sanitizers. Repository: rL LLVM https://reviews.llvm.org/D36482 Files: lib/Driver/ToolChains/NetBSD.cpp Index: lib/Driver/ToolChains/NetBSD.cpp

[PATCH] D36452: [clang-tidy] Fix another crash in make-unique check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Thank you for the fix! Looks good! Comment at: test/clang-tidy/modernize-make-unique.cpp:419 + +class UniqueFoo : public std::unique_ptr { + public: I

[PATCH] D36529: Fixed a race condition in PrecompiledPreamble.

ilya-biryukov created this revision. Two PrecompiledPreambles, used in parallel on separate threads, could be writing preamble to the same temporary file. https://reviews.llvm.org/D36529 Files: lib/Frontend/PrecompiledPreamble.cpp Index: lib/Frontend/PrecompiledPreamble.cpp

[PATCH] D36529: Fixed a race condition in PrecompiledPreamble.

ilya-biryukov added a comment. Catched by a test from https://reviews.llvm.org/D36261. https://reviews.llvm.org/D36529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

alexfh added a comment. I'm not sure this approach is the best to deal with the boilerplate, but it seems like an improvement compared to repeating code. See a few comments inline. Comment at: clang-tidy/android/CloexecCheck.cpp:66 + +StringRef

[PATCH] D34512: Add preliminary Cross Translation Unit support library

whisperity added a comment. Apart from those in the in-line comments, I have a question: how safe is this library to `Release` builds? I know this is only a submodule dependency for the "real deal" in https://reviews.llvm.org/D30691, but I have seen some asserts that "imported function should

[PATCH] D29905: [OpenMP] Pass argument to device kernel by reference when map is used.

gtbercea closed this revision. gtbercea added a comment. Already covered by https://reviews.llvm.org/D34888 Repository: rL LLVM https://reviews.llvm.org/D29905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36482: Enable SanitizerKind::Vptr on NetBSD/X86 and X86_64

krytarowski added a comment. check-ubsan -- Testing: 172 tests, 8 threads -- Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. Testing Time: 20.19s Expected Passes: 156 Unsupported Tests : 16 I will enable more options and extend this commit. Repository: rL LLVM

[clang-tools-extra] r310491 - [clang-tidy] Ignore newlines in checks list

Author: alexfh Date: Wed Aug 9 09:00:31 2017 New Revision: 310491 URL: http://llvm.org/viewvc/llvm-project?rev=310491=rev Log: [clang-tidy] Ignore newlines in checks list This is a follow up to https://reviews.llvm.org/D30567 where I overlooked that LLVM YAML parser doesn't support multiline

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

hamzasood created this revision. This patch provides an implementation for P0428R2 . https://reviews.llvm.org/D36527 Files: include/clang/Basic/DiagnosticParseKinds.td include/clang/Sema/ScopeInfo.h include/clang/Sema/Sema.h lib/Parse/ParseExprCXX.cpp

[PATCH] D36526: [Sema] Assign new flag -Wenum-compare-switch to switch-related parts of -Wenum-compare

rnkovacs created this revision. This patch assigns switch-related parts of the `-Wenum-compare` diagnostic to a new flag `-Wenum-compare-switch`. `-Wenum-compare-switch` is put into the same group as `-Wenum-compare` so that `-W(no-)enum-compare` affects both. https://reviews.llvm.org/D36526

[libcxx] r310487 - Change the way the literal operators are defined - now w/o a seperating space. This should be a NFC, but it will change how the compiler parses it.

Author: marshall Date: Wed Aug 9 08:42:50 2017 New Revision: 310487 URL: http://llvm.org/viewvc/llvm-project?rev=310487=rev Log: Change the way the literal operators are defined - now w/o a seperating space. This should be a NFC, but it will change how the compiler parses it. Modified:

Re: r310449 - [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch statements

On Wed, Aug 9, 2017 at 10:11 AM, Gábor Horváth wrote: > Sure! > > There was a follow-up patch that excluded anonymous enums. Is it still > that bad to introduce it under a new flag? > The follow-up was at r310468. https://build.chromium.org/p/chromium.fyi/

[PATCH] D36473: Fix broken getAttributeSpellingListIndex for pragma attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rL310483: Fix broken getAttributeSpellingListIndex for pragma attributes (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D36473?vs=110217=110404#toc Repository: rL LLVM

r310483 - Fix broken getAttributeSpellingListIndex for pragma attributes

Author: erichkeane Date: Wed Aug 9 08:27:36 2017 New Revision: 310483 URL: http://llvm.org/viewvc/llvm-project?rev=310483=rev Log: Fix broken getAttributeSpellingListIndex for pragma attributes We noticed when implementing a new pragma that the TableGen-generated function

[PATCH] D33945: [OpenCL] Add support for missing sub_group functions.

joey closed this revision. joey added a comment. I committed all the parts separately: r309567 (with r309571 to fix a test), r309678 and r310477. https://reviews.llvm.org/D33945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36491: clang-format: [JS] detect ASI after closing parens.

This revision was automatically updated to reflect the committed changes. Closed by commit rL310482: clang-format: [JS] detect ASI after closing parens. (authored by mprobst). Repository: rL LLVM https://reviews.llvm.org/D36491 Files: cfe/trunk/lib/Format/UnwrappedLineParser.cpp

r310482 - clang-format: [JS] detect ASI after closing parens.

Author: mprobst Date: Wed Aug 9 08:19:16 2017 New Revision: 310482 URL: http://llvm.org/viewvc/llvm-project?rev=310482=rev Log: clang-format: [JS] detect ASI after closing parens. Summary: A closing parenthesis followed by a declaration or statement should always terminate the current

r310478 - Reapply Sema: allow imaginary constants via GNU extension if UDL overloads not present.

Author: tnorthover Date: Wed Aug 9 07:56:48 2017 New Revision: 310478 URL: http://llvm.org/viewvc/llvm-project?rev=310478=rev Log: Reapply Sema: allow imaginary constants via GNU extension if UDL overloads not present. C++14 added user-defined literal support for complex numbers so that you

r310477 - [OpenCL] Minor refactoring to reduce copy/pasted code

Author: joey Date: Wed Aug 9 07:52:47 2017 New Revision: 310477 URL: http://llvm.org/viewvc/llvm-project?rev=310477=rev Log: [OpenCL] Minor refactoring to reduce copy/pasted code Set the type of TheCall inside SemaBuiltinReserveRWPipe to reduce duplicated code. Modified:

Re: r310449 - [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch statements

On Wed, Aug 9, 2017 at 10:07 AM, Nico Weber via cfe-commits wrote: > Any way we could put this behind a different flag (say, > -Wenum-compare-switch, in the same group as -Wenum-compare, so that > -W(no-)enum-compare affects both)? Our codebase was -Wenum-compare clean

Re: r310449 - [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch statements

Sure! There was a follow-up patch that excluded anonymous enums. Is it still that bad to introduce it under a new flag? Regards, Gábor On 9 August 2017 at 16:07, Nico Weber wrote: > Any way we could put this behind a different flag (say, > -Wenum-compare-switch, in the

Re: r310449 - [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch statements

Any way we could put this behind a different flag (say, -Wenum-compare-switch, in the same group as -Wenum-compare, so that -W(no-)enum-compare affects both)? Our codebase was -Wenum-compare clean before this commit but is very not clean now, so we'd now have to disable -Wenum-compare altogether,

  1   2   >