[PATCH] D36397: [clangd] Fixed a data race.

ilya-biryukov added a comment. In https://reviews.llvm.org/D36397#833912, @klimek wrote: > Yea, we'll probably want to add a "smash it hard with parallel" requests kind > of test to catch these things. You're right, there is probably not a better > solution for this specific bug. Added a

[PATCH] D36261: [clangd] Use multiple working threads in clangd.

ilya-biryukov added a comment. Added a test that exercises some multi-threading behaviour. It really finds bugs, at least it found a problem that was fixed by https://reviews.llvm.org/D36397. (Will make sure to submit that other change before this one). As discussed with @klimek, will move to

[PATCH] D36261: [clangd] Use multiple working threads in clangd.

ilya-biryukov updated this revision to Diff 110381. ilya-biryukov added a comment. - Added a stress test for multithreading. https://reviews.llvm.org/D36261 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/ClangdServer.h

[PATCH] D36471: [StaticAnalyzer] Try to calculate arithmetic result when operand has a range of possible values

danielmarjamaki added a comment. Should evalAPSInt() have machinery to do standard sign/type promotions? I suggest that I add one more argument `bool promote = false`, do you think that sounds good? Repository: rL LLVM https://reviews.llvm.org/D36471

[PATCH] D36471: [StaticAnalyzer] Try to calculate arithmetic result when operand has a range of possible values

danielmarjamaki updated this revision to Diff 110378. danielmarjamaki added a comment. Refactoring, use BasicValueFactory::evalAPSInt Repository: rL LLVM https://reviews.llvm.org/D36471 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h

[PATCH] D36450: [X86][Ms-InlineAsm] Extend MS Dot operator to accept "this" + struct/class pointers aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rL310472: [X86][Ms-InlineAsm] Extend MS Dot operator to accept "this" + struct/class… (authored by coby). Changed prior to commit: https://reviews.llvm.org/D36450?vs=110145=110377#toc Repository: rL

r310472 - [X86][Ms-InlineAsm] Extend MS Dot operator to accept "this" + struct/class pointers aliases

Author: coby Date: Wed Aug 9 06:31:41 2017 New Revision: 310472 URL: http://llvm.org/viewvc/llvm-project?rev=310472=rev Log: [X86][Ms-InlineAsm] Extend MS Dot operator to accept "this" + struct/class pointers aliases MS InlineAsm Dot operator accepts "Bases" such as "this" (cpp) and

[PATCH] D36473: Fix broken getAttributeSpellingListIndex for pragma attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, good catch! https://reviews.llvm.org/D36473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r310401 - PR19668, PR23034: Fix handling of move constructors and deleted copy

Hi Diana, It seems the service is down. Could you send us the details of the failures (incl stack traces if any) Many thanks, Vassil On 09/08/17 15:27, Diana Picus via cfe-commits wrote: Hi Richard, I'm sorry but I've reverted this in r310464 because it was breaking some ASAN tests on

[PATCH] D36458: Fix crash when current lexer is nullptr

yvvan added a comment. But I don't know the source of that issue, I only know how to fix it because I caught that one in debugger and added a check to prevent it. How can I write testcase for such fix? https://reviews.llvm.org/D36458 ___

[clang-tools-extra] r310470 - [clangd] Fixed a bug in make_tagged.

Author: ibiryukov Date: Wed Aug 9 05:55:13 2017 New Revision: 310470 URL: http://llvm.org/viewvc/llvm-project?rev=310470=rev Log: [clangd] Fixed a bug in make_tagged. It accidentally std::move'd from Value parameter if it deduced to an l-value ref. Modified:

[PATCH] D36171: AMDGPU: Use direct struct returns

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D36171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris added a comment. Ping. https://reviews.llvm.org/D35020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35678: Omit sumbodule semantics for TS modules

boris added a comment. Ping. https://reviews.llvm.org/D35678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r310468 - [Sema] -Wenum-compare no longer warn on anonymous enums in switch statements

Author: xazax Date: Wed Aug 9 05:34:58 2017 New Revision: 310468 URL: http://llvm.org/viewvc/llvm-project?rev=310468=rev Log: [Sema] -Wenum-compare no longer warn on anonymous enums in switch statements Patch by: Reka Nikolett Kovacs Modified: cfe/trunk/lib/Sema/SemaStmt.cpp

Re: r310401 - PR19668, PR23034: Fix handling of move constructors and deleted copy

Hi Richard, I'm sorry but I've reverted this in r310464 because it was breaking some ASAN tests on this bot: http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/9452 Please let me know if I can help debug this. Cheers, Diana On 8 August 2017 at 21:14, Richard Smith via

r310464 - Revert "PR19668, PR23034: Fix handling of move constructors and deleted copy constructors when deciding whether classes should be passed indirectly."

Author: rovka Date: Wed Aug 9 05:22:25 2017 New Revision: 310464 URL: http://llvm.org/viewvc/llvm-project?rev=310464=rev Log: Revert "PR19668, PR23034: Fix handling of move constructors and deleted copy constructors when deciding whether classes should be passed indirectly." This reverts

[PATCH] D36458: Fix crash when current lexer is nullptr

bkramer added a comment. Changes like this should come with a small, c-index-test based, test case so we don't reintroduce the same bug in the future. https://reviews.llvm.org/D36458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36450: [X86][Ms-InlineAsm] Extend MS Dot operator to accept "this" + struct/class pointers aliases

coby added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:702-705 + // MS InlineAsm often uses struct pointer aliases as a base + const QualType QT = TD->getUnderlyingType(); + RT = isa(QT) ? QT->getPointeeType()->getAs() : +

[PATCH] D36184: [clang-diff] Filter AST nodes

arphaman added inline comments. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:177 +static bool isDeclExcluded(const Decl *D) { return D->isImplicit(); } +static bool isStmtExcluded(const Stmt *S) { return false; } + You should just use one call `isNodeExcluded`

[PATCH] D36183: [clang-diff] Simplify mapping

arphaman added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:114 - /// If this is set to true, nodes that have parents that must not be matched - /// (see NodeComparison) will be allowed to be matched. - bool EnableMatchingWithUnmatchableParents =

[PATCH] D36182: [clang-diff] Add HTML side-by-side diff output

arphaman added inline comments. Comment at: test/Tooling/clang-diff-html.py:1 +# RUN: clang-diff %S/Inputs/clang-diff-basic-src.cpp %S/clang-diff-basic.cpp -html -- | %python %s > %t.filecheck +# RUN: clang-diff %S/Inputs/clang-diff-basic-src.cpp %S/clang-diff-basic.cpp

[PATCH] D36364: [AArch64] Add support for a MinGW AArch64 target

martell accepted this revision. martell added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36180: [clang-diff] Add option to dump the AST, one node per line

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36179: [clang-diff] Move printing of matches and changes to clang-diff

arphaman added a comment. Previous `Move` resulted in `llvm_unreachable("TODO");`, but now it seems to be fixed. The new output for `Move` and `UpdateMove` should be tested in a test. https://reviews.llvm.org/D36179 ___ cfe-commits mailing list

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

arphaman added a comment. Ah, I got it. There's a `__functional_03` header that seems to implement `function` for C++03 because of manual variadic template expansions. You have to update the operators in the header as well. https://reviews.llvm.org/D34331

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

arphaman added a comment. If you look at the AST diff between C++11 and C++03 this error still happens because of how `nullptr` is processed: C++11: | |-CXXDestructorDecl 0x7fdab27a2498 line:24:3 used ~A 'void (void) noexcept' | | `-CompoundStmt 0x7fdab27bcfb8

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

arphaman added a comment. The tests actually do compile in C++03, but they still fail because of infinite recursion: frame #196562: 0x0001155c nullptr_t_assign_reentrant.pass.cpp.exe`A::~A() + 92 frame #196563: 0x00011405

[PATCH] D35355: Fix templated type alias completion when using global completion cache

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36359: [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment pragmas

This revision was automatically updated to reflect the committed changes. Closed by commit rL310458: [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment… (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D36359 Files:

r310458 - [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment pragmas

Author: krasimir Date: Wed Aug 9 02:42:32 2017 New Revision: 310458 URL: http://llvm.org/viewvc/llvm-project?rev=310458=rev Log: [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment pragmas Summary: This handles a case where the trailing '*/' of a multiline jsdoc eding in

[PATCH] D34324: [clang-format] let PointerAlignment dictate spacing of function ref qualifiers

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Thank you! https://reviews.llvm.org/D34324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36407: [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch statements

This revision was automatically updated to reflect the committed changes. Closed by commit rL310449: [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch… (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D36407?vs=110219=110333#toc Repository: rL

r310449 - [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch statements

Author: xazax Date: Wed Aug 9 01:57:09 2017 New Revision: 310449 URL: http://llvm.org/viewvc/llvm-project?rev=310449=rev Log: [Sema] Extend -Wenum-compare to handle mixed enum comparisons in switch statements Patch by: Reka Nikolett Kovacs Differential Revision:

[PATCH] D35955: clang-format: Add preprocessor directive indentation

klimek added a comment. In https://reviews.llvm.org/D35955#835994, @euhlmann wrote: > In https://reviews.llvm.org/D35955#835439, @klimek wrote: > > > I think if we need this info, we can just make it count down to -1 again > > (or, but that's isomorphic, let it run from 0 and make sure we never

Re: [PATCH] D36386: [clang] Remove unit test which uses reverse-iterate and fix a PointerLikeTypeTrait specialization

In D35043 I have removed the llvm tests which use -reverse-iterate. This patch removes the clang tests. Should I post a later patch to change all "class PointerLikeTypeTraits" to "struct PointerLikeTypeTraits"? On 8/7/2017 2:50 PM, David Blaikie wrote: On Mon, Aug 7, 2017 at 12:08 PM

[PATCH] D16403: Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements

m.ostapenko updated this revision to Diff 110329. m.ostapenko added a comment. Rebased and ping. Repository: rL LLVM https://reviews.llvm.org/D16403 Files: include/clang/Analysis/AnalysisContext.h include/clang/Analysis/CFG.h include/clang/StaticAnalyzer/Core/AnalyzerOptions.h

r310445 - Attempt #2 to appease buildbots

Author: gbiv Date: Tue Aug 8 23:07:08 2017 New Revision: 310445 URL: http://llvm.org/viewvc/llvm-project?rev=310445=rev Log: Attempt #2 to appease buildbots "error: unable to create target: 'No available targets are compatible with this triple.'" Modified:

<    1   2