yaxunl updated this revision to Diff 110863.
yaxunl marked 5 inline comments as done.
yaxunl added a comment.
Revised by John's and Tony's comments.
https://reviews.llvm.org/D36580
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/SyncScope.h
lib/CodeGen/CGAtomic.cpp
Yeah, we should adjust that. Technically, it is `_Unwind_Control_Block on
ARM EHABI. However, _Unwind_Exception is aliased to that, which is why we
can use that in the personality routine. We should adjust the sources for
the personality routine.
On Fri, Aug 11, 2017 at 1:12 PM, Evgenii
yaxunl marked 10 inline comments as done.
yaxunl added inline comments.
Comment at: include/clang/Basic/SyncScope.h:46
+ Scopes.push_back(SyncScope::OpenCLSubGroup);
+ return Scopes;
+}
rjmccall wrote:
> t-tye wrote:
> > Should there be an assert/static_assert
Author: rksimon
Date: Sat Aug 12 11:50:53 2017
New Revision: 310783
URL: http://llvm.org/viewvc/llvm-project?rev=310783=rev
Log:
Fix Wdocumentation warning - typo in argument list. NFCI.
Modified:
clang-tools-extra/trunk/clang-tidy/android/CloexecCheck.h
Modified:
gtbercea added a comment.
In https://reviews.llvm.org/D29660#839736, @alekseyshl wrote:
> In https://reviews.llvm.org/D29660#839728, @alekseyshl wrote:
>
> > In https://reviews.llvm.org/D29660#839550, @alekseyshl wrote:
> >
> > >
Author: sylvestre
Date: Sat Aug 12 08:15:10 2017
New Revision: 310778
URL: http://llvm.org/viewvc/llvm-project?rev=310778=rev
Log:
clang-format: add an option -verbose to list the files being processed
Reviewers: djasper
Reviewed By: djasper
Subscribers: klimek, cfe-commits
Tags: #clang
sylvestre.ledru reopened this revision.
sylvestre.ledru added a comment.
This revision is now accepted and ready to land.
actually, arc commit never landed this change :(
https://reviews.llvm.org/D34824
___
cfe-commits mailing list
mgorny requested changes to this revision.
mgorny added a comment.
This revision now requires changes to proceed.
Also, I think that if you're splitting them up, it'd also logical to move them
into a subdirectory, `x86-common` maybe.
Comment at:
