rwols updated this revision to Diff 113650.
rwols marked 3 inline comments as done.
rwols added a comment.
- Split up the CompletionItemsCollector into two classes called
PlainTextCompletionItemsCollector and SnippetCompletionItemsCollector to allow
collecting both types of items.
- Add a comman
rwols added a comment.
Forgot to mention I've also made sure the `filterText` field is taken care of
now (both for snippet and for plaintext items).
https://reviews.llvm.org/D37101
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
rwols marked 4 inline comments as done.
rwols added inline comments.
Comment at: clangd/ClangdUnit.cpp:419
+assert(item.detail.empty() && "Unexpected extraneous CK_ResultType");
+Item.detail = Chunk.Text;
+break;
ilya-biryukov wrote:
> Won
NorenaLeonetti marked 16 inline comments as done.
NorenaLeonetti added a comment.
In https://reviews.llvm.org/D33825#772688, @aaron.ballman wrote:
> This check is an interesting one. The rules around what is signal safe are
> changing for C++17 to be a bit more lenient than what the rules are fo
NorenaLeonetti updated this revision to Diff 113651.
Herald added a subscriber: JDevlieghere.
Repository:
rL LLVM
https://reviews.llvm.org/D33825
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/cert/SignalHandlerMustBePlainOldFunctionCheck.cpp
clang-
jklaehn added inline comments.
Comment at: docs/ReleaseNotes.rst:62
+<<< 2f301f50187ede4b9b8c7456ac4a67b9f7418004
- Renamed checks to use correct term "implicit conversion" instead of "implicit
You missed a conflict marker here (and below in line 149).
R
NorenaLeonetti updated this revision to Diff 113652.
Repository:
rL LLVM
https://reviews.llvm.org/D33825
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/cert/SignalHandlerMustBePlainOldFunctionCheck.cpp
clang-tidy/cert/SignalHandlerMustBePlainOldFunc
puremourning added a comment.
So I think this is ready now. Anything more you need from me?
Comment at: clangd/JSONRPCDispatcher.cpp:138
bool &IsDone) {
+ unsigned long long ContentLength = 0;
while (In.good()) {
puremour
compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
Comment at: include/experimental/__config:57
+#if defined(_LIBCPP_OBJECT_FORMAT_COFF)
+# define _LIBCPPX_TYPE_VIS
hamzasood wrote:
> smeenai wrote:
NorenaLeonetti updated this revision to Diff 113654.
NorenaLeonetti added a comment.
Herald added a subscriber: JDevlieghere.
Added a test for C++ style cast and modified the docs.
Repository:
rL LLVM
https://reviews.llvm.org/D33826
Files:
clang-tidy/cert/AvoidPointerCastToMoreStrictAlignm
hamzasood added a comment.
Thanks. Could someone commit this for me please?
Comment at: include/experimental/__config:57
+#if defined(_LIBCPP_OBJECT_FORMAT_COFF)
+# define _LIBCPPX_TYPE_VIS
compnerd wrote:
> hamzasood wrote:
> > smeenai wrote:
> > > I think i
rwols updated this revision to Diff 113657.
rwols added a comment.
- Adjust SnippetCompletionItemCollector such that it only sets insertTextFormat
to InsertTextFormat::Snippet when it's actually needed (i.e. we encounter a
CK_Placeholder chunk).
- Fix failing tests in test/clangd/{completion.tes
coby updated this revision to Diff 113659.
Repository:
rL LLVM
https://reviews.llvm.org/D37413
Files:
include/clang/Parse/Parser.h
include/clang/Sema/Sema.h
lib/Parse/ParseStmtAsm.cpp
lib/Sema/SemaStmtAsm.cpp
Index: lib/Parse/ParseStmtAsm.cpp
==
On 08/22/2017 10:56 PM, Wei Mi via llvm-commits wrote:
On Tue, Aug 22, 2017 at 7:03 PM, Xinliang David Li wrote:
On Tue, Aug 22, 2017 at 6:37 PM, Chandler Carruth via Phabricator
wrote:
chandlerc added a comment.
I'm really not a fan of the degree of complexity and subtlety that this
intro
Author: compnerd
Date: Sat Sep 2 21:46:57 2017
New Revision: 312434
URL: http://llvm.org/viewvc/llvm-project?rev=312434&view=rev
Log:
Driver: move `-mfpmath` into FP Options (NFC)
Move the `-mfpmath` handling with the rest of the floating point
optimization flags.
Modified:
cfe/trunk/lib/Dr
Author: compnerd
Date: Sat Sep 2 21:46:59 2017
New Revision: 312435
URL: http://llvm.org/viewvc/llvm-project?rev=312435&view=rev
Log:
Driver: extract debugging related options (NFC)
Out-of-line the logic for selecting the debug information handling.
This is still split across the new function an
Author: compnerd
Date: Sat Sep 2 21:47:00 2017
New Revision: 312436
URL: http://llvm.org/viewvc/llvm-project?rev=312436&view=rev
Log:
Driver; extract target specific option application (NFC)
Extract the target specific option application. This is a huge switch
which was inlined into the `Constr
17 matches
Mail list logo
