[PATCH] D37599: Add '\n' in ClangDataCollectorsEmitter

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM. Do you have commit access? https://reviews.llvm.org/D37599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37597: [ubsan] Function Sanitizer: Don't require writable text segments

vsk updated this revision to Diff 114303. vsk edited the summary of this revision. vsk added a comment. Address review feedback: - Enable this change on all platforms. - Bump the function signature version. - Store the indirect RTTI pointer as an IntPtrTy. This saves a "ptrtoint" instruction.

[PATCH] D37310: [Atomic] Merge alignment information from Decl and from Type when emit atomic expression.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rL LLVM https://reviews.llvm.org/D37310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37310: [Atomic] Merge alignment information from Decl and from Type when emit atomic expression.

wmi updated this revision to Diff 114300. wmi added a comment. Address John's comment. Repository: rL LLVM https://reviews.llvm.org/D37310 Files: lib/CodeGen/CGAtomic.cpp test/CodeGenCXX/atomic-align.cpp Index: test/CodeGenCXX/atomic-align.cpp

[PATCH] D37529: [codeview] omit debug locations for nested exprs unless column info enabled

zturner added a comment. @inglorion : Since we're already in this code anyway, should we at least do due diligence and check the basics, even if only manually? As in, at least we should check in MSVC if any of those other types of examples that I came up with present a problem. Otherwise

[PATCH] D37529: [codeview] omit debug locations for nested exprs unless column info enabled

inglorion updated this revision to Diff 114299. inglorion added a comment. removed compound statement; that was only in there to double check that the debugger stops on the first child statement, but that's true with or without this change https://reviews.llvm.org/D37529 Files:

[PATCH] D37529: [codeview] omit debug locations for nested exprs unless column info enabled

inglorion added a comment. @zturner: I am still thinking about your comment about other cases to test. My concern is that there are very many possible combinations. I'm actually not too concerned about not exactly matching cl's behavior in every single case. The difference in behavior here is

r312770 - COFF: Implement ThinLTO cache and cache pruning support.

Author: pcc Date: Thu Sep 7 17:50:50 2017 New Revision: 312770 URL: http://llvm.org/viewvc/llvm-project?rev=312770=rev Log: COFF: Implement ThinLTO cache and cache pruning support. Differential Revision: https://reviews.llvm.org/D37607 Modified: cfe/trunk/docs/ThinLTO.rst Modified:

[clang-tools-extra] r312769 - Update for PrintHelpMessage not calling exit.

Author: rafael Date: Thu Sep 7 17:33:39 2017 New Revision: 312769 URL: http://llvm.org/viewvc/llvm-project?rev=312769=rev Log: Update for PrintHelpMessage not calling exit. Modified: clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMain.cpp

[PATCH] D37529: [codeview] omit debug locations for nested exprs unless column info enabled

inglorion updated this revision to Diff 114292. inglorion added a comment. Following conversation with @rnk, I managed to whittle this down to a very small change that seems to do what we need. Step into specific works and single stepping through the program behaves similarly whether compiled

[PATCH] D37597: [ubsan] Function Sanitizer: Don't require writable text segments

vsk added a comment. Thanks for your comments! Comment at: lib/CodeGen/CodeGenFunction.cpp:434 +llvm::Constant *Addr) { + if (!CGM.getTriple().isOSDarwin()) +return Addr; pcc wrote: > I think you can just do

r312766 - Update for llvm change.

Author: rafael Date: Thu Sep 7 17:01:26 2017 New Revision: 312766 URL: http://llvm.org/viewvc/llvm-project?rev=312766=rev Log: Update for llvm change. Modified: cfe/trunk/tools/clang-format/ClangFormat.cpp cfe/trunk/tools/clang-offload-bundler/ClangOffloadBundler.cpp Modified:

[PATCH] D37604: Disable debuginfo-tests for non-native configurations

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This seems reasonable to me, thanks! When you commit this, could you please double-check that the tests are still running on the green dragon builders? I'll also keep an eye on them.

[PATCH] D37604: Disable debuginfo-tests for non-native configurations

probinson added a comment. The new file goes in the debuginfo-tests directory. It's a separate project so that's probably not obvious from the diff. https://reviews.llvm.org/D37604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37604: Disable debuginfo-tests for non-native configurations

probinson created this revision. This requires the host triple to match the default target triple, in order to run debuginfo-tests. It's possible this is too restrictive, but offhand it seems like a reasonable starting point. https://reviews.llvm.org/D37604 Files: lit.local.cfg Index:

[PATCH] D37597: [ubsan] Function Sanitizer: Don't require writable text segments

pcc added inline comments. Comment at: lib/CodeGen/CodeGenFunction.cpp:463 + auto *PCRelAsInt = + Builder.CreatePtrToInt(EncodedAddr, IntPtrTy, "encoded_addr.int"); + auto *FuncAsInt = Builder.CreatePtrToInt(F, IntPtrTy, "func_addr.int"); pcc wrote: >

[PATCH] D37597: [ubsan] Function Sanitizer: Don't require writable text segments

pcc added a comment. Thanks. Once we apply this fix to other platforms this would seem to fix PR17633. We may also want to change the ubsan function signature in order to avoid bad pointer reads in case of version mismatches. Comment at: lib/CodeGen/CodeGenFunction.cpp:434

[PATCH] D37599: Add '\n' in ClangDataCollectorsEmitter

kzhuravl created this revision. Herald added subscribers: ilya-biryukov, wdng. Otherwise it breaks our internal windows builders: StmtDataCollectors.inc: error C2220: warning treated as error - no 'object' file generated StmtDataCollectors.inc: warning C4335: Mac file format detected:

[PATCH] D37598: [ubsan] Enable -fsanitize=function on Darwin

vsk created this revision. Depends on https://reviews.llvm.org/D37597 https://reviews.llvm.org/D37598 Files: docs/UndefinedBehaviorSanitizer.rst lib/Driver/ToolChains/Darwin.cpp test/Driver/fsanitize.c Index: test/Driver/fsanitize.c

[PATCH] D37597: [ubsan] Function Sanitizer: Don't require writable text segments

vsk created this revision. This change will make it possible to use -fsanitize=function on Darwin and possibly on other platforms. It fixes an issue with the way RTTI is stored into function prologue data. On Darwin, addresses stored in prologue data can't require run-time fixups and must be

Re: r312696 - [modules ts] Add test for [basic.link]p3.

On 7 September 2017 at 13:36, Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Richard, > > This commit broke one of our builders: > http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensiv > e-checks-win/builds/4705 > > Failing Tests (1): > Clang ::

[PATCH] D37565: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

This revision was automatically updated to reflect the committed changes. Closed by commit rL312750: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S. (authored by lebedevri). Changed prior to commit: https://reviews.llvm.org/D37565?vs=114260=114265#toc Repository: rL

r312750 - [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

Author: lebedevri Date: Thu Sep 7 15:14:25 2017 New Revision: 312750 URL: http://llvm.org/viewvc/llvm-project?rev=312750=rev Log: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S. Summary: This is a first half(?) of a fix for the following bug:

r312749 - Add target triple to improve the happiness of MSVC buildbots.

Author: rsmith Date: Thu Sep 7 15:07:52 2017 New Revision: 312749 URL: http://llvm.org/viewvc/llvm-project?rev=312749=rev Log: Add target triple to improve the happiness of MSVC buildbots. Modified: cfe/trunk/test/CXX/modules-ts/basic/basic.link/p3.cppm Modified:

[PATCH] D37565: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: docs/ReleaseNotes.rst:79 +- ``-Wtautological-compare`` now warns about comparison of signed integer and + ``0U`` constant when appropriate. +

[PATCH] D37496: Fix validation of the -mthread-model flag in the Clang driver

jroelofs closed this revision. jroelofs added a comment. r312748 https://reviews.llvm.org/D37496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r312748 - Fix validation of the -mthread-model flag in the Clang driver

Author: jroelofs Date: Thu Sep 7 15:01:25 2017 New Revision: 312748 URL: http://llvm.org/viewvc/llvm-project?rev=312748=rev Log: Fix validation of the -mthread-model flag in the Clang driver The ToolChain class validates the -mthread-model flag in the constructor which doesn't work correctly

[PATCH] D37565: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

lebedev.ri updated this revision to Diff 114260. lebedev.ri marked 3 inline comments as done. lebedev.ri added a comment. Address review notes. Repository: rL LLVM https://reviews.llvm.org/D37565 Files: docs/ReleaseNotes.rst lib/Sema/SemaChecking.cpp test/Sema/compare.c

[PATCH] D37577: [libclang] add 'clang_getCursorTLSKind'

frutiger updated this revision to Diff 114256. frutiger added a comment. Exports 'TLSKind' in the '__all__' array. https://reviews.llvm.org/D37577 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_tls_kind.py include/clang-c/Index.h tools/libclang/CIndex.cpp

[PATCH] D37573: [bindings] add Cursor.linkage

frutiger updated this revision to Diff 114257. frutiger added a comment. Export 'LinkageKind' in '__all__'. Use consistent quotes in test drivers. https://reviews.llvm.org/D37573 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_linkage.py Index:

[PATCH] D37565: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

rjmccall added a comment. Great, thanks. Just a few tweaks. Comment at: docs/ReleaseNotes.rst:76 + ``0`` constant was adjusted to warn regardless of whether the constant is + signed or unsigned. + "now warns when comparing an unsigned integer and 0

[PATCH] D37565: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

lebedev.ri updated this revision to Diff 114249. lebedev.ri marked 4 inline comments as done. lebedev.ri added a comment. Address review notes. Repository: rL LLVM https://reviews.llvm.org/D37565 Files: docs/ReleaseNotes.rst lib/Sema/SemaChecking.cpp test/Sema/compare.c

Re: r312696 - [modules ts] Add test for [basic.link]p3.

Hello Richard, This commit broke one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/4705 Failing Tests (1): Clang :: CXX/modules-ts/basic/basic.link/p3.cppm Please have a look? Thanks Galina On Wed, Sep 6, 2017 at 10:29 PM, Richard Smith

r312743 - Add IDNS_Tag to C++ declarations that conflict with tag declarations.

Author: rsmith Date: Thu Sep 7 13:22:00 2017 New Revision: 312743 URL: http://llvm.org/viewvc/llvm-project?rev=312743=rev Log: Add IDNS_Tag to C++ declarations that conflict with tag declarations. Fixes some accepts-invalids with tags and other declarations declared in the same scope. Added:

[PATCH] D37101: [clangd] Add support for snippet completions

rwols updated this revision to Diff 114242. rwols added a comment. Change command-line option back to "-enable-snippets", disable snippets by default. This is a temporary solution and we should instead inspect the "initialize" request from the client to check wether the client supports

[PATCH] D37231: Add half load and store builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL312742: [OpenCL] Add half load and store builtins (authored by jvesely). Changed prior to commit: https://reviews.llvm.org/D37231?vs=113624=114240#toc Repository: rL LLVM

r312742 - [OpenCL] Add half load and store builtins

Author: jvesely Date: Thu Sep 7 12:39:10 2017 New Revision: 312742 URL: http://llvm.org/viewvc/llvm-project?rev=312742=rev Log: [OpenCL] Add half load and store builtins This enables load/stores of half type, without half being a legal type. Differential Revision:

[PATCH] D37568: [AMDGPU] Allow flexible register names in inline asm constraints

yaxunl added a comment. In https://reviews.llvm.org/D37568#863735, @b-sumner wrote: > The assembler accepts v[N] in addition to vN. I'm not sure if that is needed > here. Then we'd better also allow that in constraints to avoid confusion of users. https://reviews.llvm.org/D37568

[PATCH] D37568: [AMDGPU] Allow flexible register names in inline asm constraints

b-sumner added a comment. The assembler accepts v[N] in addition to vN. I'm not sure if that is needed here. https://reviews.llvm.org/D37568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37491: [Preamble] Fixed preamble breaking with BOM presence (and particularly, fluctuating BOM presence)

cameron314 updated this revision to Diff 114228. cameron314 added a comment. Here's an updated patch. The code required to make it work is much simpler when the BOM is simply ignored :-) https://reviews.llvm.org/D37491 Files: include/clang/Frontend/PrecompiledPreamble.h

[PATCH] D36410: [OpenCL] Handle taking address of block captures

yaxunl added a comment. In https://reviews.llvm.org/D36410#863579, @Anastasia wrote: > In https://reviews.llvm.org/D36410#863508, @yaxunl wrote: > > > In https://reviews.llvm.org/D36410#863426, @Anastasia wrote: > > > > > In https://reviews.llvm.org/D36410#863409, @yaxunl wrote: > > > > > > >

[PATCH] D37565: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

lebedev.ri planned changes to this revision. lebedev.ri added inline comments. Comment at: test/Sema/outof-range-constant-compare.c:41 +if (a < 0xUL) +return 0; +if (a <= 0xUL) rjmccall wrote: > Hmm. I think this

[PATCH] D31140: [LLVMbugs] [Bug 18710] Only generate .ARM.exidx and .ARM.extab when needed in EHABI

efriedma added a comment. If you want to follow what we do for x86-64 on ARM, you should be doing this in the driver, not codegen (grep for IsUnwindTablesDefault). https://reviews.llvm.org/D31140 ___ cfe-commits mailing list

[PATCH] D37565: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

rjmccall added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8589 + Expr *LHS = E->getLHS()->IgnoreParenImpCasts(); + Expr *RHS = E->getRHS()->IgnoreParenImpCasts(); + lebedev.ri wrote: > rjmccall wrote: > > Do you still need these? I'm always antsy

[PATCH] D37565: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

lebedev.ri added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8879 + if (IsComparisonConstant) return AnalyzeImpConvsInComparison(S, E); rjmccall wrote: > lebedev.ri wrote: > > rjmccall wrote: > > > Part of the purpose of checking for signed

[PATCH] D37565: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

rjmccall added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8879 + if (IsComparisonConstant) return AnalyzeImpConvsInComparison(S, E); lebedev.ri wrote: > rjmccall wrote: > > Part of the purpose of checking for signed comparisons up here is

[PATCH] D37568: [AMDGPU] Allow flexible register names in inline asm constraints

yaxunl updated this revision to Diff 114223. yaxunl marked 3 inline comments as done. yaxunl edited the summary of this revision. yaxunl added a comment. Revised by Matt's comments. https://reviews.llvm.org/D37568 Files: lib/Basic/Targets/AMDGPU.h test/CodeGenOpenCL/amdgcn-inline-asm.cl

[PATCH] D37565: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

lebedev.ri added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8592 + bool BadR = !RType->isIntegerType() || RType->isSignedIntegerType() || + RHS->isKnownToHaveBooleanValue(); + rjmccall wrote: > Please extract a function which computes

[PATCH] D37565: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

lebedev.ri updated this revision to Diff 114221. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Address review notes. Repository: rL LLVM https://reviews.llvm.org/D37565 Files: docs/ReleaseNotes.rst lib/Sema/SemaChecking.cpp

[PATCH] D37548: [CUDA] When compilation fails, print the compilation mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rL312736: [CUDA] When compilation fails, print the compilation mode. (authored by jlebar). Changed prior to commit: https://reviews.llvm.org/D37548?vs=114112=114222#toc Repository: rL LLVM

r312736 - [CUDA] When compilation fails, print the compilation mode.

Author: jlebar Date: Thu Sep 7 11:37:16 2017 New Revision: 312736 URL: http://llvm.org/viewvc/llvm-project?rev=312736=rev Log: [CUDA] When compilation fails, print the compilation mode. Summary: That is, instead of "1 error generated", we now say "1 error generated when compiling for sm_35".

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

schroedersi added a comment. Hello Richard, what do you think about the printing context changes? Are they what you expected? https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37576: [CUDA] Added rudimentary support for CUDA-9 and sm_70.

This revision was automatically updated to reflect the committed changes. Closed by commit rL312734: [CUDA] Added rudimentary support for CUDA-9 and sm_70. (authored by tra). Changed prior to commit: https://reviews.llvm.org/D37576?vs=114206=114216#toc Repository: rL LLVM

r312734 - [CUDA] Added rudimentary support for CUDA-9 and sm_70.

Author: tra Date: Thu Sep 7 11:14:32 2017 New Revision: 312734 URL: http://llvm.org/viewvc/llvm-project?rev=312734=rev Log: [CUDA] Added rudimentary support for CUDA-9 and sm_70. For now CUDA-9 is not included in the list of CUDA versions clang searches for, so the path to CUDA-9 must be

[PATCH] D37568: [AMDGPU] Allow flexible register names in inline asm constraints

yaxunl added inline comments. Comment at: test/Sema/inline-asm-validate-amdgpu.cl:38 +__asm("v_add_f32_e32 v1, v2, v3" : "=v1"(ci) : "v2"(ai), "v3"(bi) : ); /// expected-error {{invalid output constraint '=v1' in asm}} +__asm("v_add_f32_e32 v1, v2, v3" : "=v1:2"(ci) :

[PATCH] D37577: [libclang] add 'clang_getCursorTLSKind'

frutiger created this revision. Introduce the 'TLS Kind' property of variable declarations through libclang. Additionally, provide a Python accessor for it, and test that functionality. https://reviews.llvm.org/D37577 Files: bindings/python/clang/cindex.py

[PATCH] D37496: Fix validation of the -mthread-model flag in the Clang driver

itessier added a comment. Do you mind submitting this CL? I don't have access to SVN. https://reviews.llvm.org/D37496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37576: [CUDA] Added rudimentary support for CUDA-9 and sm_70.

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Looks great. https://reviews.llvm.org/D37576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37576: [CUDA] Added rudimentary support for CUDA-9 and sm_70.

tra updated this revision to Diff 114206. tra added a comment. Added tests for sm_70 support. https://reviews.llvm.org/D37576 Files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/Basic/Targets/NVPTX.cpp clang/lib/Driver/ToolChains/Cuda.cpp

[PATCH] D37442: [C++17] Disallow lambdas in template parameters (PR33696).

Rakete updated this revision to Diff 114204. Rakete added a comment. Good idea! Updated diff :) https://reviews.llvm.org/D37442 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/Parse/ParseDecl.cpp lib/Parse/ParseDeclCXX.cpp

[PATCH] D36410: [OpenCL] Handle taking address of block captures

Anastasia added a comment. In https://reviews.llvm.org/D36410#863508, @yaxunl wrote: > In https://reviews.llvm.org/D36410#863426, @Anastasia wrote: > > > In https://reviews.llvm.org/D36410#863409, @yaxunl wrote: > > > > > LGTM as a temporary measure until we have a solution for properly > > >

[PATCH] D37308: Interface class with uuid base record

erichkeane added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:2377 +/// \brief Tests if the __interface base is public. +static bool IsBasePublicInterface(const CXXRecordDecl *RD, + AccessSpecifier spec) { This function

[PATCH] D37576: [CUDA] Added rudimentary support for CUDA-9 and sm_70.

tra created this revision. Herald added subscribers: hiraditya, sanjoy, jholewinski. For now CUDA-9 is not included in the list of CUDA versions clang searches for, so the path to CUDA-9 must be explicitly passed via --cuda-path=. On LLVM side NVPTX added sm_70 GPU type which bumps required PTX

[PATCH] D37308: Interface class with uuid base record

zahiraam updated this revision to Diff 114201. zahiraam added a comment. Just upload a new patch. Please review. https://reviews.llvm.org/D37308 Files: lib/Sema/SemaDeclCXX.cpp test/SemaCXX/ms-uuid.cpp Index: test/SemaCXX/ms-uuid.cpp

[PATCH] D37568: [AMDGPU] Allow flexible register names in inline asm constraints

arsenm added inline comments. Comment at: test/Sema/inline-asm-validate-amdgpu.cl:38 +__asm("v_add_f32_e32 v1, v2, v3" : "=v1"(ci) : "v2"(ai), "v3"(bi) : ); /// expected-error {{invalid output constraint '=v1' in asm}} +__asm("v_add_f32_e32 v1, v2, v3" : "=v1:2"(ci) :

[PATCH] D37150: [clangd] Command line arg to specify compile_commands.json path

Nebiroth updated this revision to Diff 114199. Nebiroth marked 7 inline comments as done. Nebiroth added a comment. Modified CompileCommandsDir to only look in the specified path if the value is set. Moved CompileCommandsDir field to DirectoryBasedGlobalCompilationDatabase class. Minor

[PATCH] D37565: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

rjmccall added inline comments. Comment at: lib/Sema/SemaChecking.cpp:8592 + bool BadR = !RType->isIntegerType() || RType->isSignedIntegerType() || + RHS->isKnownToHaveBooleanValue(); + Please extract a function which computes this for an Expr* and

[PATCH] D37568: [AMDGPU] Allow flexible register names in inline asm constraints

arsenm added inline comments. Comment at: test/Sema/inline-asm-validate-amdgpu.cl:38 +__asm("v_add_f32_e32 v1, v2, v3" : "=v1"(ci) : "v2"(ai), "v3"(bi) : ); /// expected-error {{invalid output constraint '=v1' in asm}} +__asm("v_add_f32_e32 v1, v2, v3" : "=v1:2"(ci) :

[PATCH] D36410: [OpenCL] Handle taking address of block captures

This revision was automatically updated to reflect the committed changes. Closed by commit rL312728: [OpenCL] Handle taking an address of block captures. (authored by stulova). Changed prior to commit: https://reviews.llvm.org/D36410?vs=110015=114197#toc Repository: rL LLVM

r312728 - [OpenCL] Handle taking an address of block captures.

Author: stulova Date: Thu Sep 7 10:00:33 2017 New Revision: 312728 URL: http://llvm.org/viewvc/llvm-project?rev=312728=rev Log: [OpenCL] Handle taking an address of block captures. Block captures can have different physical locations in memory segments depending on the use case (as a function

[PATCH] D37562: [X86] Lower _mm[256|512]_[mask[z]]_avg_epu[8|16] intrinsics to native llvm IR

craig.topper added a comment. You need to remove the bultins from include/clang/Basic/BuiltinsX86.def too. https://reviews.llvm.org/D37562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth added a comment. ping https://reviews.llvm.org/D36354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36423: [libc++] Introsort based sorting function

hiraditya added a comment. Ping! https://reviews.llvm.org/D36423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37548: [CUDA] When compilation fails, print the compilation mode.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Nice. https://reviews.llvm.org/D37548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36410: [OpenCL] Handle taking address of block captures

yaxunl added a comment. In https://reviews.llvm.org/D36410#863426, @Anastasia wrote: > In https://reviews.llvm.org/D36410#863409, @yaxunl wrote: > > > LGTM as a temporary measure until we have a solution for properly emitting > > blocks as enqueued kernel. > > > Should I start discussion with

[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo with git

hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D35533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[bindings] add Cursor.linkage

commit cc52d367ede0f3f306014d0418e18772e0c49dec Author: Masud Rahman Date: Thu Sep 7 11:39:19 2017 -0400 [bindings] add Cursor.linkage Add Python bindings for the 'clang_getCursorLinkage', and tests to validate the functionality. diff --git

[PATCH] D37572: [clang-tidy] SuspiciousEnumUsageCheck bugfix

szepet created this revision. Herald added subscribers: baloghadamsoftware, whisperity, JDevlieghere. There is a reported bug on the checker not handling the some APSInt values correctly: https://bugs.llvm.org/show_bug.cgi?id=34400 This patch fixes it, however, it shows a false positive. (Added

[PATCH] D36410: [OpenCL] Handle taking address of block captures

Anastasia added a comment. In https://reviews.llvm.org/D36410#863409, @yaxunl wrote: > LGTM as a temporary measure until we have a solution for properly emitting > blocks as enqueued kernel. Should I start discussion with Khronos on that? What would our preference be - implicitly `generic`

[PATCH] D37231: Add half load and store builtins

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. Yes, sorry overlooked that. :) LGTM! Thanks! Repository: rL LLVM https://reviews.llvm.org/D37231 ___ cfe-commits mailing list

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

Anastasia added inline comments. Comment at: include/clang/AST/Type.h:332 + bool getImplicitAddressSpaceFlag() const { return Mask & IMask; } + void setImplicitAddressSpaceFlag(bool Value) { Could we add a bit of comment somewhere explaining why we added

[PATCH] D36410: [OpenCL] Handle taking address of block captures

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM as a temporary measure until we have a solution for properly emitting blocks as enqueued kernel. https://reviews.llvm.org/D36410 ___

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc added a comment. Another ping. Is it possible to approve this modification, or alternatively, let me know that it won't be approved indefinitely? I understand that it's a controversial change. Thanks! https://reviews.llvm.org/D34158 ___

[PATCH] D31334: [clang-format] Add options for indenting preprocessor directives

curdeius abandoned this revision. curdeius added a comment. Superseded by https://reviews.llvm.org/rL312125. https://reviews.llvm.org/D31334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r312723 - [clang-format] Add support for C++17 structured bindings.

Author: mkurdej Date: Thu Sep 7 07:28:32 2017 New Revision: 312723 URL: http://llvm.org/viewvc/llvm-project?rev=312723=rev Log: [clang-format] Add support for C++17 structured bindings. Summary: Before: ``` auto[a, b] = f(); ``` After: ``` auto [a, b] = f(); ``` or, if

[PATCH] D37568: [AMDGPU] Allow flexible register names in inline asm constraints

yaxunl created this revision. Herald added subscribers: eraman, t-tye, tpr, dstuttard, nhaehnle, wdng, kzhuravl. Currently AMDGPU inline asm only allow "v" and "s" as register names in constraints. This patch allows the following register names in constraints: (n, m is unsigned integer, n <

[PATCH] D37513: [clang-format] Fix documentation for AllowAllParametersOfDeclarationOnNextLine

djasper accepted this revision. djasper added a comment. Submitted as r312721. Thank you. https://reviews.llvm.org/D37513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r312721 - [clang-format] Fix documentation for AllowAllParametersOfDeclarationOnNextLine

Author: djasper Date: Thu Sep 7 06:45:41 2017 New Revision: 312721 URL: http://llvm.org/viewvc/llvm-project?rev=312721=rev Log: [clang-format] Fix documentation for AllowAllParametersOfDeclarationOnNextLine The current description of AllowAllParametersOfDeclarationOnNextLine in the Clang-Format

[PATCH] D37565: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

lebedev.ri updated this revision to Diff 114172. lebedev.ri added a comment. Added ReleaseNotes.rst note Repository: rL LLVM https://reviews.llvm.org/D37565 Files: docs/ReleaseNotes.rst lib/Sema/SemaChecking.cpp test/Sema/outof-range-constant-compare.c Index:

[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Sorry for the delay. https://reviews.llvm.org/D37132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37491: [Preamble] Fixed preamble breaking with BOM presence (and particularly, fluctuating BOM presence)

cameron314 added a comment. > Maybe there's a third option option to remove the BOM from the buffer before > passing it to clang? > Could you elaborate on your use-case a little more? Is there no way to > consistently always pass buffers either with or without BOM? > Out of two options you

[PATCH] D37474: [PCH] Allow VFS to be used for tests that generate PCH files

cameron314 added a comment. Looking at the way remapped buffers are handled, I just remembered that they must exist on the file system (at the very least, in a directory that exists) or the remapping is not taken into account. So that pretty much rules out the other approach, I think.

[PATCH] D37566: [clang-tidy] fixed misc-unused-parameters omitting parameters default value

PriMee created this revision. Herald added a subscriber: JDevlieghere. Bug: https://bugs.llvm.org/show_bug.cgi?id=34450 **Problem:** Clang-tidy check misc-unused-parameters omits parameter default value what results in its complete removal. Compilation errors might occur after clang-tidy fix.

[PATCH] D37565: [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

lebedev.ri created this revision. lebedev.ri added a project: clang. This is a first half(?) of a fix for the following bug: https://bugs.llvm.org/show_bug.cgi?id=34147 (gcc -Wtype-limits) GCC's -Wtype-limits does warn on comparison of unsigned value with signed zero (as in, with 0), but clang

[PATCH] D37513: [clang-format] Fix documentation for AllowAllParametersOfDeclarationOnNextLine

LuMa added a comment. I cannot commit the patch myself. https://reviews.llvm.org/D37513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37513: [clang-format] Fix documentation for AllowAllParametersOfDeclarationOnNextLine

LuMa updated this revision to Diff 114161. https://reviews.llvm.org/D37513 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h === --- include/clang/Format/Format.h +++

[PATCH] D28148: [Sema] Suppress warnings for C's zero initializer

sgilles added a comment. Sure, if it still applies. I'm just a user and have no write access. Looks like I patched this locally and then forgot all about it. https://reviews.llvm.org/D28148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo with git

minseong.kim updated this revision to Diff 114160. minseong.kim marked 3 inline comments as done. minseong.kim added a comment. Re-uploading the patch, removing debug messages accidentally included in the patch. https://reviews.llvm.org/D35533 Files: lib/Basic/CMakeLists.txt Index:

r312717 - Add an usage example of BreakBeforeBraces

Author: sylvestre Date: Thu Sep 7 05:09:14 2017 New Revision: 312717 URL: http://llvm.org/viewvc/llvm-project?rev=312717=rev Log: Add an usage example of BreakBeforeBraces Reviewers: djasper Reviewed By: djasper Subscribers: klimek, cfe-commits Differential Revision:

r312716 - Refresh the clang format options doc with the recent changes

Author: sylvestre Date: Thu Sep 7 05:08:49 2017 New Revision: 312716 URL: http://llvm.org/viewvc/llvm-project?rev=312716=rev Log: Refresh the clang format options doc with the recent changes Summary: Looks like we are out of sync between the doc and the code. Reviewers: djasper Reviewed By:

  1   2   >