On 19 Jul 2017, at 16:04, Hans Wennborg via cfe-commits
wrote:
>
> Author: hans
> Date: Wed Jul 19 07:04:19 2017
> New Revision: 308470
>
> URL: http://llvm.org/viewvc/llvm-project?rev=308470&view=rev
> Log:
> Drop 'svn' suffix from version number.
[Replying to this commit, since I don't have
zahiraam updated this revision to Diff 114497.
zahiraam added a comment.
Erich,
Addressed your comments.
Thanks.
https://reviews.llvm.org/D37308
Files:
lib/Sema/SemaDeclCXX.cpp
test/SemaCXX/ms-uuid.cpp
Index: test/SemaCXX/ms-uuid.cpp
==
Author: nlopes
Date: Sat Sep 9 11:25:36 2017
New Revision: 312870
URL: http://llvm.org/viewvc/llvm-project?rev=312870&view=rev
Log:
clang fix for LLVM API change: isKnownNonNull -> isKnownNonZero
Differential Revision: https://reviews.llvm.org/D37628
Modified:
cfe/trunk/lib/CodeGen/CGCall.c
Author: minseongkim
Date: Sat Sep 9 07:18:53 2017
New Revision: 312865
URL: http://llvm.org/viewvc/llvm-project?rev=312865&view=rev
Log:
[Basic] Update CMakeLists.txt to handle repo
Summary:
The find_first_existing_file and find_first_existing_vc_file macros in
lib/Basic/CMakeLists.txt are remov
Rakete added a comment.
> Is that a problem?
I don't think so, because `shouldVisitImplicitCode()` doesn't mean that it only
visits implicit code, it's not `onlyVisitImplicitCode()` :) In fact, I would be
surprised if the template parameters were only visited once.
Comme
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312865: [Basic] Update CMakeLists.txt to handle repo
(authored by MinSeongKIM).
Changed prior to commit:
https://reviews.llvm.org/D35533?vs=114160&id=114488#toc
Repository:
rL LLVM
https://reviews.l
JonasToth added a comment.
- Adressed some review comments.
- Added testcases, where the `owner<>` annotation might be hidden by a
`typedef` or `using`, like int `using heap_int = gsl::owner;`
The check is currently not able to resolve a `typedef` to `owner<>` correctly,
and my knowledge in cla
JonasToth updated this revision to Diff 114483.
JonasToth marked 4 inline comments as done.
JonasToth added a comment.
- Merge branch 'master'
- mention current problems with typedefs of owner<> and adjust test cases
https://reviews.llvm.org/D36354
Files:
clang-tidy/cppcoreguidelines/CMakeLis
Richard Smith writes:
> I am extremely uncomfortable about the direction this patch series is going.
>
> We have had two different RecursiveASTVisitors before (RecursiveASTVisitor
> and DataRecursiveASTVisitor), and it was a maintenance nightmare:
> frequently changes would be made to one of them
johannes created this revision.
This causes template arguments to be traversed before the templated
declaration, which is useful for clients that expect the nodes in
the same order as they are in the source code. Additionally, there
seems to be no good reason not to do so.
This was moved here fro
johannes created this revision.
This adds a special case for traversing CXXOperatorCallExpr. Its
children are traversed in the order in which they appear in the source
code, so infix and postfix operators are visited after their first
argument.
This behavior was previously only in
LexicallyOrdere
mstorsjo added a comment.
Ping @EricWF
https://reviews.llvm.org/D37134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo added a comment.
Ping @EricWF, who added this script
https://reviews.llvm.org/D37133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added inline comments.
Comment at: lib/CodeGen/CGCall.h:211
+ push_back(CallArg(rvalue, type, needscopy, AS));
}
Ah, I think I understand what's going on here now. "indirect byval" arguments
include an implicit copy to the stack, and the co
14 matches
Mail list logo
