[libcxx] r313607 - Revert "Fix llvm-lit script generation in libcxx."

Author: zturner Date: Mon Sep 18 20:11:35 2017 New Revision: 313607 URL: http://llvm.org/viewvc/llvm-project?rev=313607=rev Log: Revert "Fix llvm-lit script generation in libcxx." This reverts commit 4ad71811d45268d81b60f27e3b8b2bcbc23bd7b9. There is a bot that is checking out libcxx and lit

[libcxx] r313606 - Fix llvm-lit script generation in libcxx.

Author: zturner Date: Mon Sep 18 19:46:28 2017 New Revision: 313606 URL: http://llvm.org/viewvc/llvm-project?rev=313606=rev Log: Fix llvm-lit script generation in libcxx. Differential Revision: https://reviews.llvm.org/D37997 Modified: libcxx/trunk/CMakeLists.txt

[PATCH] D37954: Expand absolute system header paths when using -MD depfiles

Lekensteyn added a comment. In https://reviews.llvm.org/D37954#873384, @joerg wrote: > ninja is not the only consumer of this. For human inspection, it can be quite > surprising to see symlinks resolved, i.e. /usr/include/machine on NetBSD. No problem, NetBSD disables this option by default:

r313603 - [Coverage] Remove deferred region for trailing return, fixes PR34611

Author: vedantk Date: Mon Sep 18 17:29:46 2017 New Revision: 313603 URL: http://llvm.org/viewvc/llvm-project?rev=313603=rev Log: [Coverage] Remove deferred region for trailing return, fixes PR34611 As a special case, throw away deferred regions for trailing returns. This allows the closing curly

[PATCH] D37925: Allow specifying sanitizers in blacklists

eugenis added inline comments. Comment at: docs/SanitizerSpecialCaseList.rst:57 + +Sections are regular expressions written in square brackets that denote which +sanitizer the following entries apply to. For example, ``[address]`` specifies Section names are

r313591 - [Docs] Document cache pruning support for gold

Author: kongyi Date: Mon Sep 18 16:24:01 2017 New Revision: 313591 URL: http://llvm.org/viewvc/llvm-project?rev=313591=rev Log: [Docs] Document cache pruning support for gold Differential Revision: https://reviews.llvm.org/D37995 Modified: cfe/trunk/docs/ThinLTO.rst Modified:

[PATCH] D38009: [Sema] Fix using old initializer during switch statement transformation.

vsapsai created this revision. Herald added subscribers: kristof.beyls, aemerson. It fixes a crash in CodeGen when we are trying to generate code for initializer expression created before template instantiation, like CallExpr '' |-UnresolvedLookupExpr '' lvalue (ADL) = 'parse'

[PATCH] D37925: Allow specifying sanitizers in blacklists

vlad.tsyrklevich updated this revision to Diff 115751. vlad.tsyrklevich added a comment. Update for SectionsMap refactor in LLVM https://reviews.llvm.org/D37925 Files: docs/ControlFlowIntegrity.rst docs/SanitizerSpecialCaseList.rst include/clang/Basic/SanitizerBlacklist.h

r313598 - [Coverage] Use a new API to label gap areas

Author: vedantk Date: Mon Sep 18 16:37:30 2017 New Revision: 313598 URL: http://llvm.org/viewvc/llvm-project?rev=313598=rev Log: [Coverage] Use a new API to label gap areas This will make it possible for llvm-cov to pick better line execution counts, and is part of the fix for llvm.org/PR34612.

[PATCH] D37995: [Docs] Document cache pruning support for gold

This revision was automatically updated to reflect the committed changes. Closed by commit rL313591: [Docs] Document cache pruning support for gold (authored by kongyi). Changed prior to commit: https://reviews.llvm.org/D37995?vs=115710=115745#toc Repository: rL LLVM

[PATCH] D37995: [Docs] Document cache pruning support for gold

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM with one fix noted. Comment at: docs/ThinLTO.rst:144 To help keep the size of the cache under control, ThinLTO supports cache pruning. Cache pruning is

[PATCH] D37132: [clang-format] Add support for C++17 structured bindings.

chh added a comment. Please review https://reviews.llvm.org/D35743. I uploaded there a new diff that should fix the spaces around & and && tokens. Thanks. https://reviews.llvm.org/D37132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35743: [clang-format] Adjust space around &/&& of structured bindings

chh updated this revision to Diff 115741. https://reviews.llvm.org/D35743 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp === --- unittests/Format/FormatTest.cpp +++

Re: r313316 - [Module map] Introduce a private module re-export directive.

> On Sep 18, 2017, at 3:11 PM, Richard Smith wrote: > > On 18 September 2017 at 14:34, Douglas Gregor via cfe-commits > > wrote: > >> On Sep 18, 2017, at 1:45 PM, Galina Kistanova >

r313579 - [lit] Update clang and lld to use new config helpers.

Author: zturner Date: Mon Sep 18 15:26:48 2017 New Revision: 313579 URL: http://llvm.org/viewvc/llvm-project?rev=313579=rev Log: [lit] Update clang and lld to use new config helpers. NFC intended here, this only updates clang and lld's lit configs to use some helper functionality in the lit.llvm

Re: r313316 - [Module map] Introduce a private module re-export directive.

On 18 September 2017 at 14:34, Douglas Gregor via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Sep 18, 2017, at 1:45 PM, Galina Kistanova > wrote: > > Hello Douglas, > > Your r313316 commit broke one of our builders on Thursday, Sep-14th. >

[libcxx] r313576 - Fix failing ASAN test

Author: ericwf Date: Mon Sep 18 15:01:18 2017 New Revision: 313576 URL: http://llvm.org/viewvc/llvm-project?rev=313576=rev Log: Fix failing ASAN test Modified: libcxx/trunk/test/libcxx/language.support/cxa_deleted_virtual.pass.cpp Modified:

Re: r313316 - [Module map] Introduce a private module re-export directive.

> On Sep 18, 2017, at 1:45 PM, Galina Kistanova wrote: > > Hello Douglas, > > Your r313316 commit broke one of our builders on Thursday, Sep-14th. > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/17506 > >

[PATCH] D37865: [Sema] Fix a pair of crashes when generating exception specifiers with an error'ed field for a template class' default ctor.

This revision was automatically updated to reflect the committed changes. Closed by commit rL313569: [Sema] Fix a pair of crashes when generating exception specifiers with an (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D37865?vs=115278=115726#toc Repository:

r313569 - [Sema] Fix a pair of crashes when generating exception specifiers with an

Author: erichkeane Date: Mon Sep 18 14:28:55 2017 New Revision: 313569 URL: http://llvm.org/viewvc/llvm-project?rev=313569=rev Log: [Sema] Fix a pair of crashes when generating exception specifiers with an error'ed field for a template class' default ctor. The two examples in the test would both

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

efriedma added a comment. It looks like you uploaded a diff against the previous version of the patch instead of trunk? https://reviews.llvm.org/D37861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36431: Add powerpc64 to compiler-rt build infrastructure.

echristo accepted this revision. echristo added a comment. This is great with me. https://reviews.llvm.org/D36431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37865: [Sema] Fix a pair of crashes when generating exception specifiers with an error'ed field for a template class' default ctor.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks like the correct fix, thanks! https://reviews.llvm.org/D37865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35472: Implement P0463R1: "Endian just Endian"

mclow.lists updated this revision to Diff 115714. mclow.lists added a comment. Fixed test and #ifdef guard https://reviews.llvm.org/D35472 Files: include/type_traits test/std/utilities/meta/meta.type.synop/endian.pass.cpp Index: test/std/utilities/meta/meta.type.synop/endian.pass.cpp

[PATCH] D37865: [Sema] Fix a pair of crashes when generating exception specifiers with an error'ed field for a template class' default ctor.

erichkeane added a comment. Ping? I Added the three of you because you were all on the git-blame list, but if you have better ideas on someone to review this, it would be appreciated. -Erich https://reviews.llvm.org/D37865 ___ cfe-commits

Re: r313316 - [Module map] Introduce a private module re-export directive.

Hello Douglas, Your r313316 commit broke one of our builders on Thursday, Sep-14th. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/17506 Are you about to commit the fix, or shall I revert that commit to give you more time? Thanks Galina On Thu, Sep 14,

[PATCH] D37995: [Docs] Document cache pruning support for gold

kongyi created this revision. kongyi added a project: clang. Herald added subscribers: eraman, mehdi_amini. Feature implemented in https://reviews.llvm.org/D37993 Repository: rL LLVM https://reviews.llvm.org/D37995 Files: docs/ThinLTO.rst Index: docs/ThinLTO.rst

[PATCH] D37994: Implement LWG2946: More ambiguity in `string` vs. `string_view`

mclow.lists created this revision. See https://wg21.link/lwg2946 for details. This issue has not yet been adopted by WG21, but I implemented it to make sure that there were no problems in the proposed resolution. It turns out that there was. Making these changes lost the ability to construct

[PATCH] D37925: Allow specifying sanitizers in blacklists

vlad.tsyrklevich updated this revision to Diff 115703. vlad.tsyrklevich added a comment. Update documentation to mention sections in the blacklist documentation and in the CFI documentation (where it's most useful) https://reviews.llvm.org/D37925 Files: docs/ControlFlowIntegrity.rst

[PATCH] D37914: [OpenMP] Don't throw cudalib not found error if only front-end is required.

gtbercea added inline comments. Comment at: test/Driver/openmp-offload-gpu.c:133 +/// Check that the flag is passed when -fopenmp-relocatable-target is used. +// RUN: %clang -### -c -S -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -Xopenmp-target -march=sm_99

[PATCH] D37914: [OpenMP] Don't throw cudalib not found error if only front-end is required.

gtbercea updated this revision to Diff 115697. gtbercea added a comment. Only check for -S. Repository: rL LLVM https://reviews.llvm.org/D37914 Files: lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index: test/Driver/openmp-offload-gpu.c

[PATCH] D37913: [OpenMP] Enable the existing nocudalib flag for OpenMP offloading toolchain.

gtbercea updated this revision to Diff 115692. gtbercea added a comment. Add test. Repository: rL LLVM https://reviews.llvm.org/D37913 Files: lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index: test/Driver/openmp-offload-gpu.c

[PATCH] D37958: [libc++] Correctly propagate user-defined lookup_classname().

Quuxplusone added inline comments. Comment at: libcxx/test/std/re/re.traits/lookup_classname_user_defined.pass.cpp:46 +// matches all characters (they are classified as alnum) +std::wstring re1 = L"([[:alnum:]]+)"; +std::regex_search(in, m, std::wregex(re1));

[PATCH] D37903: Fix assume-filename handling in clang-format.el

phst added a comment. Thanks, generally looks good, but a couple of notes: - This is actually a bug in clang-format, which can easily be triggered with `clang-format -output-replacements-xml -assume-filename '' -offset 0 -length 10 -cursor 5 <<< ' = 1234;'` It's fine to work around

[PATCH] D37668: [X86][intrinsics] lower _mm[256|512]_mask[z]_set1_epi[8|16|32|64] intrinsic to IR

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D37668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37912: [OpenMP] Bugfix: output file name drops the absolute path where full path is needed.

gtbercea updated this revision to Diff 115667. gtbercea added a reviewer: hfinkel. Repository: rL LLVM https://reviews.llvm.org/D37912 Files: lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload-gpu.c Index: test/Driver/openmp-offload-gpu.c

[PATCH] D37822: [OpenCL] Clean up and add missing fields for block struct

Anastasia added a comment. In https://reviews.llvm.org/D37822#872446, @yaxunl wrote: > In https://reviews.llvm.org/D37822#872291, @Anastasia wrote: > > > Could you please explain a bit more why the alignment have to be put > > explicitly in the struct? I am just not very convinced this is

[PATCH] D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true.

curdeius added a comment. In https://reviews.llvm.org/D37904#873860, @krasimir wrote: > Could you please move the test that adds a namespace end comment to > `unittests/Format/NamespaceEndCommentsFixerTest.cpp`? That's what I wanted to do initially, but the very same tests there passed

[PATCH] D37978: [analyzer] Fix an assertion fail in VirtualCallChecker

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks reasonable, but please wait for someone who actually knows this code. Repository: rL LLVM https://reviews.llvm.org/D37978 ___

[PATCH] D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true.

krasimir added a comment. Could you please move the test that adds a namespace end comment to `unittests/Format/NamespaceEndCommentsFixerTest.cpp`? https://reviews.llvm.org/D37904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37980: [clang-format] Better parsing of lambda captures with initializer expressions.

curdeius created this revision. This fixes bug #19986 (https://bugs.llvm.org/show_bug.cgi?id=19986). The code was incorrectly formatted to (mind additional spaces inside brackets) when lambda capture contained an initializer expression. This patch does not handle all possible initializers, but

[PATCH] D35743: [clang-format] Handle Structured binding declaration in C++17

klimek added a comment. In https://reviews.llvm.org/D35743#841197, @chh wrote: > Daniel, Manuel, I will take over this CL since Yan has finished his > internship at Google., > Yan's latest patch to tryToParseLambda looks acceptable to me. > I think it should take care of new kw_auto in

[PATCH] D37978: [analyzer] Fix an assertion fail in VirtualCallChecker

xazax.hun created this revision. Herald added subscribers: baloghadamsoftware, whisperity. This patch attempts to fix PR34451. The `getBestDynamicClassType` call can only handle `RecordDecls` and pointers to `RecordDecls`. The code removed all the implicit casts, this includes the array to

[clang-tools-extra] r313536 - [clangd] Fix codeAction not decoded properly when sent from some clients

Author: malaperle Date: Mon Sep 18 08:02:59 2017 New Revision: 313536 URL: http://llvm.org/viewvc/llvm-project?rev=313536=rev Log: [clangd] Fix codeAction not decoded properly when sent from some clients Summary: Fix for bug https://bugs.llvm.org/show_bug.cgi?id=34559 Also log unknown fields

[PATCH] D37972: [clangd] Introduced Logger interface.

ilya-biryukov added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:88 if (!Error.empty()) { -// FIXME(ibiryukov): logging -// Output.log("Error when trying to load compilation database from " + -//Twine(Path) + ": " +

[PATCH] D37972: [clangd] Introduced Logger interface.

ilya-biryukov updated this revision to Diff 115648. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. Addressed review comments. - Replaced include with forward declaration in headers. - Removed logging on each call to loadFromDirectory.

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

zibi marked 2 inline comments as done. zibi added a comment. Good catch, thank you. I submitted a new patch. https://reviews.llvm.org/D37861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37861: preserving #pragma clang assume_nonnull in preprocessed output

zibi updated this revision to Diff 115643. zibi added a comment. Addressing the review. https://reviews.llvm.org/D37861 Files: lib/Frontend/PrintPreprocessedOutput.cpp test/Preprocessor/pragma_assume_nonnull.c Index: test/Preprocessor/pragma_assume_nonnull.c

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik added a comment. There wasn't any update on this check lately - can I help to make it better? https://reviews.llvm.org/D33722 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37972: [clangd] Introduced Logger interface.

malaperle added a comment. Looks very nice! Just a few questions. Comment at: clangd/ClangdServer.h:24 #include "ClangdUnit.h" +#include "Logger.h" #include "Protocol.h" forward declare? Comment at: clangd/ClangdUnit.h:13 +#include

[PATCH] D37023: [analyzer] Fix bugreporter::getDerefExpr() again.

alexfh added a comment. Any news here? I'm wondering mainly because this patch is supposed to fix https://bugs.llvm.org/show_bug.cgi?id=34373. https://reviews.llvm.org/D37023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37976: [docs][refactor] add refactoring engine design documentation

arphaman created this revision. This patch adds a refactoring engine design document that talks about the design and provides several example of how the engine can be used. Repository: rL LLVM https://reviews.llvm.org/D37976 Files: docs/RefactoringEngine.rst docs/index.rst Index:

[PATCH] D37973: [clang-format] Fix regression about short functions after #else

krasimir created this revision. Herald added a subscriber: klimek. This patch fixes a regression introduced in r312904, where the formatter confuses the `else` in `#else` with an `else` of an `if-else` statement. For example, formatting this code with google style #ifdef A int f() {}

[PATCH] D37972: [clangd] Introduced Logger interface.

ilya-biryukov created this revision. Herald added a subscriber: mgorny. This fixes a bunch of logging-related FIXMEs. https://reviews.llvm.org/D37972 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp

[PATCH] D36431: Add powerpc64 to compiler-rt build infrastructure.

nemanjai accepted this revision. nemanjai added subscribers: hfinkel, echristo. nemanjai added a comment. This revision is now accepted and ready to land. I hope I haven't lost track of the patches that precluded this. If I remember correctly, all the X86 80-bit stuff was sorted out. We now know

[PATCH] D37970: [clangd] Added a command-line arg to mirror clangd input into a file.

ilya-biryukov updated this revision to Diff 115628. ilya-biryukov added a comment. Replaced std::string with Path typedef. https://reviews.llvm.org/D37970 Files: clangd/JSONRPCDispatcher.cpp clangd/JSONRPCDispatcher.h clangd/tool/ClangdMain.cpp test/clangd/input-mirror.test Index:

[PATCH] D37970: [clangd] Added a command-line arg to mirror clangd input into a file.

ilya-biryukov created this revision. The arg is useful for debugging and creating test cases. https://reviews.llvm.org/D37970 Files: clangd/JSONRPCDispatcher.cpp clangd/JSONRPCDispatcher.h clangd/tool/ClangdMain.cpp test/clangd/input-mirror.test Index: test/clangd/input-mirror.test

[PATCH] D37668: [X86][intrinsics] lower _mm[256|512]_mask[z]_set1_epi[8|16|32|64] intrinsic to IR

jina.nahias added inline comments. Comment at: lib/Headers/avx512fintrin.h:9742 #ifdef __x86_64__ static __inline__ __m512i __DEFAULT_FN_ATTRS craig.topper wrote: > Please remove the #ifdef __x86_64__ from this. It should work in 32-bits as > well. the

[PATCH] D37668: [X86][intrinsics] lower _mm[256|512]_mask[z]_set1_epi[8|16|32|64] intrinsic to IR

jina.nahias updated this revision to Diff 115622. jina.nahias added a comment. rebase on @craig.topper commit. https://reviews.llvm.org/D37668 Files: include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def lib/Headers/avx512bwintrin.h lib/Headers/avx512fintrin.h

[PATCH] D37542: [ubsan] Save a ptrtoint when emitting alignment checks

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Nice, LGTM https://reviews.llvm.org/D37542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D37544: [ubsan] Skip alignment checks which are folded away

arphaman added a comment. It looks like this test passes prior to the code change in this patch. Can you please change the test? https://reviews.llvm.org/D37544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r313521 - Another attempt to fix warning discovered by r313487. [-Wunused-lambda-capture]

thanks! Faisal Vali On Mon, Sep 18, 2017 at 4:10 AM, NAKAMURA Takumi wrote: > Seems fixed! Thanks! > > On Mon, Sep 18, 2017 at 5:27 PM Vitaly Buka via cfe-commits > wrote: >> >> Author: vitalybuka >> Date: Mon Sep 18 01:26:01 2017 >> New

[PATCH] D37903: Fix assume-filename handling in clang-format.el

klimek added a reviewer: phst. klimek added a comment. +Philipp, who is our emacs expert :) https://reviews.llvm.org/D37903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r313521 - Another attempt to fix warning discovered by r313487. [-Wunused-lambda-capture]

Seems fixed! Thanks! On Mon, Sep 18, 2017 at 5:27 PM Vitaly Buka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: vitalybuka > Date: Mon Sep 18 01:26:01 2017 > New Revision: 313521 > > URL: http://llvm.org/viewvc/llvm-project?rev=313521=rev > Log: > Another attempt to fix warning

[PATCH] D37150: [clangd] Command line arg to specify compile_commands.json path

ilya-biryukov added a comment. All lit test for clangd are currently failing if I apply your change. Generally, please run `make check-clang-tools` to make sure your changes do not introduce any regressions. The tests are failing because when `--compile-commands-dir` is not specified clangd

r313521 - Another attempt to fix warning discovered by r313487. [-Wunused-lambda-capture]

Author: vitalybuka Date: Mon Sep 18 01:26:01 2017 New Revision: 313521 URL: http://llvm.org/viewvc/llvm-project?rev=313521=rev Log: Another attempt to fix warning discovered by r313487. [-Wunused-lambda-capture] Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp Modified:

[PATCH] D37958: [libc++] Correctly propagate user-defined lookup_classname().

timshen added inline comments. Comment at: libcxx/test/std/re/re.traits/lookup_classname_user_defined.pass.cpp:46 +// matches all characters (they are classified as alnum) +std::wstring re1 = L"([[:alnum:]]+)"; +std::regex_search(in, m, std::wregex(re1));

[PATCH] D37958: [libc++] Correctly propagate user-defined lookup_classname().

timshen updated this revision to Diff 115597. timshen added a comment. Propagate __icase_ correctly into lookup_classname. https://reviews.llvm.org/D37958 Files: libcxx/include/regex libcxx/test/std/re/re.traits/lookup_classname_user_defined.pass.cpp